Re: Patch 8.0.0325

2017-02-11 Fir de Conversatie Bram Moolenaar

Hirohito Higashi wrote:

> 2017-2-11(Sat) 19:37:13 UTC+9 Bram Moolenaar:
> > Patch 8.0.0325
> > Problem:Packadd test does not clean up symlink.
> > Solution:   Delete the link. (Hirohito Higashi)
> > Files:  src/testdir/test_packadd.vim
> > 
> > 
> > *** ../vim-8.0.0324/src/testdir/test_packadd.vim2017-02-05 
> > 16:07:50.291087646 +0100
> > --- src/testdir/test_packadd.vim2017-02-11 11:32:27.880899001 +0100
> > ***
> > *** 98,103 
> > --- 98,104 
> >   
> > set rtp&
> > let rtp = 
> > +   silent !rm top2_dir
> >   endfunc
> >   
> >   " Check command-line completion for 'packadd'
> > *** ../vim-8.0.0324/src/version.c   2017-02-09 22:28:11.354931464 +0100
> > --- src/version.c   2017-02-11 11:34:13.340127348 +0100
> > ***
> > *** 766,767 
> > --- 766,769 
> >   {   /* Add new patch number below this line */
> > + /**/
> > + 325,
> >   /**/
> 
> Soy, again.
> My code is very bad.
> I modified it with the attached patch, so please include it. Please.
> 
> Related thread.
> https://groups.google.com/d/topic/vim_dev/0z5sIxPz3CY/discussion
> 
> I'm so sorry.

I didn't even notice the mistake.  And the test was passing anyway.

-- 
I used to wonder about the meaning of life.  But I looked it
up in the dictionary under "L" and there it was - the meaning
of life.  It was less than I expected.  - Dogbert

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0325

2017-02-11 Fir de Conversatie h_east
Hi Bram and list,

2017-2-11(Sat) 19:37:13 UTC+9 Bram Moolenaar:
> Patch 8.0.0325
> Problem:Packadd test does not clean up symlink.
> Solution:   Delete the link. (Hirohito Higashi)
> Files:  src/testdir/test_packadd.vim
> 
> 
> *** ../vim-8.0.0324/src/testdir/test_packadd.vim  2017-02-05 
> 16:07:50.291087646 +0100
> --- src/testdir/test_packadd.vim  2017-02-11 11:32:27.880899001 +0100
> ***
> *** 98,103 
> --- 98,104 
>   
> set rtp&
> let rtp = 
> +   silent !rm top2_dir
>   endfunc
>   
>   " Check command-line completion for 'packadd'
> *** ../vim-8.0.0324/src/version.c 2017-02-09 22:28:11.354931464 +0100
> --- src/version.c 2017-02-11 11:34:13.340127348 +0100
> ***
> *** 766,767 
> --- 766,769 
>   {   /* Add new patch number below this line */
> + /**/
> + 325,
>   /**/

Soy, again.
My code is very bad.
I modified it with the attached patch, so please include it. Please.

Related thread.
https://groups.google.com/d/topic/vim_dev/0z5sIxPz3CY/discussion

I'm so sorry.
--
Best regards,
Hirohito Higashi (a.k.a. h_east)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
diff --git a/src/testdir/test_packadd.vim b/src/testdir/test_packadd.vim
index bf00fa2..8ffebf9 100644
--- a/src/testdir/test_packadd.vim
+++ b/src/testdir/test_packadd.vim
@@ -73,7 +73,7 @@ func Test_packadd_symlink_dir()
   endif
   let top2_dir = s:topdir . '/Xdir2'
   let real_dir = s:topdir . '/Xsym'
-  silent !ln -s real_dir top2_dir
+  exec "silent !ln -s" real_dir top2_dir
   let  = top2_dir . ',' . top2_dir . '/after'
   let  = 
 
@@ -98,7 +98,7 @@ func Test_packadd_symlink_dir()
 
   set rtp&
   let rtp = 
-  silent !rm top2_dir
+  exec "silent !rm" top2_dir
 endfunc
 
 " Check command-line completion for 'packadd'