When lines are folded, sign columns are highlighted with Folded group.

2012-03-26 Fir de Conversatie Yukihiro Nakadaira
When lines are folded, sign columns are highlighted with Folded group.

Steps to reproduce:

  $ vim -u NONE
  :call append(0, ['1', '2', '3', '4', '5', '6', '7', '8', '9'])
  :2,3fold
  :sign define test text=TS
  :execute 'sign place 999 line=5 name=test buffer=' . bufnr('%')
  :highlight Folded guibg=red ctermbg=red

  Then, you can see sign columns are highlighted with red.

I think it is better to highlight it with SignColumn group.

diff -r bfdab0bcf4f5 src/screen.c
--- a/src/screen.c  Fri Mar 23 18:39:18 2012 +0100
+++ b/src/screen.c  Tue Mar 27 08:14:27 2012 +0900
@@ -2293,10 +2293,10 @@
if (wp-w_p_rl)
/* the line number isn't reversed */
copy_text_attr(off + W_WIDTH(wp) - len - col,
-   (char_u *)  , len, hl_attr(HLF_FL));
+   (char_u *)  , len, hl_attr(HLF_SC));
else
 # endif
-   copy_text_attr(off + col, (char_u *)  , len, hl_attr(HLF_FL));
+   copy_text_attr(off + col, (char_u *)  , len, hl_attr(HLF_SC));
col += len;
}
 }


-- 
Yukihiro Nakadaira - yukihiro.nakada...@gmail.com

-- 
You received this message from the vim_dev maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: When lines are folded, sign columns are highlighted with Folded group.

2012-03-26 Fir de Conversatie Christian Brabandt
On Tue, March 27, 2012 01:29, Yukihiro Nakadaira wrote:
 When lines are folded, sign columns are highlighted with Folded group.

 Steps to reproduce:

   $ vim -u NONE
   :call append(0, ['1', '2', '3', '4', '5', '6', '7', '8', '9'])
   :2,3fold
   :sign define test text=TS
   :execute 'sign place 999 line=5 name=test buffer=' . bufnr('%')
   :highlight Folded guibg=red ctermbg=red

   Then, you can see sign columns are highlighted with red.

 I think it is better to highlight it with SignColumn group.

 diff -r bfdab0bcf4f5 src/screen.c
 --- a/src/screen.cFri Mar 23 18:39:18 2012 +0100
 +++ b/src/screen.cTue Mar 27 08:14:27 2012 +0900
 @@ -2293,10 +2293,10 @@
   if (wp-w_p_rl)
   /* the line number isn't reversed */
   copy_text_attr(off + W_WIDTH(wp) - len - col,
 - (char_u *)  , len, hl_attr(HLF_FL));
 + (char_u *)  , len, hl_attr(HLF_SC));
   else
  # endif
 - copy_text_attr(off + col, (char_u *)  , len, hl_attr(HLF_FL));
 + copy_text_attr(off + col, (char_u *)  , len, hl_attr(HLF_SC));
   col += len;
   }
  }

A similar issue came up before on this list:
http://groups.google.com/group/vim_dev/msg/cf0c5c29c4b6f414
where Bram states:

 Since we don't show signs for the folded region, I think it's good to
 also use the closed-fold color in the sign column.

regards,
Christian

-- 
You received this message from the vim_dev maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php