Re: [virt-tools-list] [PATCH virt-manager 0/5] Disable vmport with Spice
On 04/02/2015 06:04 PM, Marc-André Lureau wrote:
Hi,
This is a small series introducing the vmport feature configuration
with virt-install (the patches are yet to be reviewed for libvirt).
By default, vmport will be disable when the VM is using Spice, since
it prevents a Spice client from switching between absolute and
relative pointer.
Thanks for the patches! I'll push when the libvirt patches land.
I also added this additional commit to make sure xmlparse.py doesn't fail with
older libvirt.
commit 7b75f98b6c0174ddbedfa475f4c0069754bdad73
Author: Cole Robinson crobi...@redhat.com
Date: Fri Apr 3 11:18:47 2015 -0400
tests: Fix vmport test on older libvirt
diff --git a/tests/xmlparse.py b/tests/xmlparse.py
index 5077617..a900530 100644
--- a/tests/xmlparse.py
+++ b/tests/xmlparse.py
@@ -40,8 +40,10 @@ class XMLParseTest(unittest.TestCase):
actualXML = guest.get_xml_config()
utils.diff_compare(actualXML, expect_out=expectXML)
-def _alter_compare(self, actualXML, outfile):
+def _alter_compare(self, actualXML, outfile, support_check=None):
utils.diff_compare(actualXML, outfile)
+if (support_check and not conn.check_support(support_check)):
+return
utils.test_create(conn, actualXML)
def testRoundTrip(self):
@@ -228,7 +230,8 @@ class XMLParseTest(unittest.TestCase):
check(nosharepages, False, True)
check(locked, False, True)
-self._alter_compare(guest.get_xml_config(), outfile)
+self._alter_compare(guest.get_xml_config(), outfile,
+support_check=conn.SUPPORT_CONN_VMPORT)
def testAlterMinimalGuest(self):
guest, outfile = self._get_test_content(change-minimal-guest)
diff --git a/virtinst/support.py b/virtinst/support.py
index f7beeb1..9dab7d8 100644
--- a/virtinst/support.py
+++ b/virtinst/support.py
@@ -304,7 +304,7 @@ SUPPORT_CONN_DOMAIN_CAPABILITIES = _make(
run_args=(None, None, None, None))
SUPPORT_CONN_VIDEO_NEW_RAM_OUTPUT = _make(version=1.2.11)
SUPPORT_CONN_VMPORT = _make(
-version=1.2.15, hv_version={qemu: 2.2.0})
+version=1.2.15, hv_version={qemu: 2.2.0, test: 0})
# Domain checks
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [PATCH] virt-manager: Don't allow an empty string for a network name
On 04/02/2015 05:54 PM, Charles Arnold wrote: When starting the 'Create virtual network' wizard, you are allowed to proceed without specifying a Network Name. An error only occurs after all else is completed with the wizard. This patch stops the user from proceeding if a network name has not been specified. The check for an empty string is done in util.py which also effects storage pool names and guest names neither of which should have empty strings. Signed-off-by: Charles Arnold carn...@suse.com diff --git a/virtManager/create.py b/virtManager/create.py index b67af61..64d6eac 100644 --- a/virtManager/create.py +++ b/virtManager/create.py @@ -1743,7 +1743,10 @@ class vmmCreate(vmmGObjectUI): # HV + Arch selection name = self.get_config_name() if name != self.guest.name: -self.guest.name = name +try: +self.guest.name = name +except Exception, e: +return self.err.val_err(_(Invalid guest name), str(e)) if self.is_default_storage(): logging.debug(User changed VM name and using default storage, re-validating with new default storage path.) diff --git a/virtManager/createpool.py b/virtManager/createpool.py index 6641ce9..5d4558e 100644 --- a/virtManager/createpool.py +++ b/virtManager/createpool.py @@ -479,8 +479,6 @@ class vmmCreatePool(vmmGObjectUI): def _validate_page_name(self, usepool=None): name = self.get_config_name() -if not name: -return self.err.val_err(_(A name must be specified.)) try: if usepool: diff --git a/virtinst/util.py b/virtinst/util.py index baf671c..099b501 100644 --- a/virtinst/util.py +++ b/virtinst/util.py @@ -143,6 +143,9 @@ def validate_name(name_type, val): # Rather than try and match libvirt's regex, just forbid things we # know don't work forbid = [ ] +if not val: +raise ValueError( +_(A name must be specified for the %s) % name_type) for c in forbid: if c not in val: continue Thanks, pushed now - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] ERROR unsupported configuration: host doesn't support invariant TSC
On 04/02/2015 10:49 PM, pc aide wrote: Hello, I just installed a fresh CentOS 7 minimal version on my server (dell r610). Linux testServer 3.10.0-229.1.2.el7.x86_64 #1 SMP Fri Mar 27 03:04:26 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux then made update and installed kvm tools yum -y install qemu-kvm qemu-img libvirt virt-install libvirt-daemon-driver-* / // /Name: qemu-kvm Arch: x86_64 Epoch : 10 Version : 1.5.3 Release : 86.el7_1.1/ // /Name: virt-install Arch: noarch Version : 1.1.0 Release : 12.el7 And then I got an error when I'm using the virt-install command with --cpu host option: virt-install --connect qemu:///system -n archlinux -r 1024 *--cpu host* --vcpus=1 --disk path=archlinux.raw,bus=virtio --cdrom archlinux-2015.02.01-dual.iso --os-type linux --network bridge:virbr0,model=virtio --hvm --graphics vnc,listen=0.0.0.0 Starting install... *ERRORunsupported configuration: host doesn't support invariant TSC* Domain installation does not appear to have been successful. If it was, you can restart your domain by running: virsh --connect qemu:///system start archlinux otherwise, please restart your installation. I've double check the Virtualization option in the BIOS is enabled. Here is a summary of /proc/cpuinfo: processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 26 model name : Intel(R) Xeon(R) CPU L5520 @ 2.27GHz lags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmo n pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf pni dtes64 monitor ds_cpl*vmx *est tm2 ssse3 cx16 xtpr pdcm dca sse4_1 sse4_2 popcnt lahf_lm ida dtherm tpr_shadow vnmi flexpr iority ept vpid Am I missing something ? I'd like to know if there is a way to fix this. If you need more informations, just ask. Thank you for your time and consideration in this matter. That's an issue that's fixed in latest upstreams: https://bugzilla.redhat.com/show_bug.cgi?id=1133155 https://bugzilla.redhat.com/show_bug.cgi?id=1138221 Sounds like the libvirt side is fixed in 7.1, so update to that, then use --cpu host-model instead. - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
[virt-tools-list] ERROR unsupported configuration: host doesn't support invariant TSC
Hello, I just installed a fresh CentOS 7 minimal version on my server (dell r610). Linux testServer 3.10.0-229.1.2.el7.x86_64 #1 SMP Fri Mar 27 03:04:26 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux then made update and installed kvm tools yum -y install qemu-kvm qemu-img libvirt virt-install libvirt-daemon-driver-* / // /Name: qemu-kvm Arch: x86_64 Epoch : 10 Version : 1.5.3 Release : 86.el7_1.1/ // /Name: virt-install Arch: noarch Version : 1.1.0 Release : 12.el7 And then I got an error when I'm using the virt-install command with --cpu host option: virt-install --connect qemu:///system -n archlinux -r 1024 *--cpu host* --vcpus=1 --disk path=archlinux.raw,bus=virtio --cdrom archlinux-2015.02.01-dual.iso --os-type linux --network bridge:virbr0,model=virtio --hvm --graphics vnc,listen=0.0.0.0 Starting install... *ERRORunsupported configuration: host doesn't support invariant TSC* Domain installation does not appear to have been successful. If it was, you can restart your domain by running: virsh --connect qemu:///system start archlinux otherwise, please restart your installation. I've double check the Virtualization option in the BIOS is enabled. Here is a summary of /proc/cpuinfo: processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 26 model name : Intel(R) Xeon(R) CPU L5520 @ 2.27GHz lags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmo n pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf pni dtes64 monitor ds_cpl*vmx *est tm2 ssse3 cx16 xtpr pdcm dca sse4_1 sse4_2 popcnt lahf_lm ida dtherm tpr_shadow vnmi flexpr iority ept vpid Am I missing something ? I'd like to know if there is a way to fix this. If you need more informations, just ask. Thank you for your time and consideration in this matter. pcaide ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] Nested VM images fail/freeze during booting
On 04/02/2015 02:54 PM, Steve Amerige wrote: Hi Cole, Both the physical host, L1 VM, and L2 VM are CentOS 7.0 (3.10.0-123.20.1.el7.x86_64). Thanks, Steve Amerige Principal Software Developer, Fraud and Compliance Solutions Development SAS Institute, 100 SAS Campus Dr, Room U3050, Cary, NC 27513-8617 This likely isn't anything wrong on the VM config side. Nested intel virt has had a lot of upstream changes since RHEL 7.0 was released. I'd recommend updating to 7.1 or trying with something newer like Fedora. - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
