Re: [virt-tools-list] [PATCH 1/2] Remove unused 'window-removed' signal

[Pavel Grunt]

Ok, ack.

Pavel
On Tue, 2015-11-10 at 18:39 -0200, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko) 
> ---
>  src/virt-viewer-app.c | 14 --
>  src/virt-viewer-app.h |  1 -
>  2 files changed, 15 deletions(-)
> 
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index 653b30c..b14b509 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -176,7 +176,6 @@ enum {
>  
>  enum {
>  SIGNAL_WINDOW_ADDED,
> -SIGNAL_WINDOW_REMOVED,
>  SIGNAL_LAST,
>  };
>  
> @@ -1046,8 +1045,6 @@ static void
> virt_viewer_app_remove_nth_window(VirtViewerApp *self,
>  g_debug("Remove window %d %p", nth, win);
>  self->priv->windows = g_list_remove(self->priv->windows, win);
>  
> -g_signal_emit(self, signals[SIGNAL_WINDOW_REMOVED], 0, win);
> -
>  g_object_unref(win);
>  }
>  
> @@ -2003,17 +2000,6 @@ virt_viewer_app_class_init (VirtViewerAppClass *klass)
>   G_TYPE_NONE,
>   1,
>   G_TYPE_OBJECT);
> -
> -signals[SIGNAL_WINDOW_REMOVED] =
> -g_signal_new("window-removed",
> - G_OBJECT_CLASS_TYPE(object_class),
> - G_SIGNAL_RUN_LAST,
> - G_STRUCT_OFFSET(VirtViewerAppClass, window_removed),
> - NULL, NULL,
> - g_cclosure_marshal_VOID__OBJECT,
> - G_TYPE_NONE,
> - 1,
> - G_TYPE_OBJECT);
>  }
>  
>  void
> diff --git a/src/virt-viewer-app.h b/src/virt-viewer-app.h
> index bbbc9b4..7aa315d 100644
> --- a/src/virt-viewer-app.h
> +++ b/src/virt-viewer-app.h
> @@ -48,7 +48,6 @@ typedef struct {
>  
>  /* signals */
>  void (*window_added) (VirtViewerApp *self, VirtViewerWindow *window);
> -void (*window_removed) (VirtViewerApp *self, VirtViewerWindow *window);
>  
>  /*< private >*/
>  gboolean (*start) (VirtViewerApp *self, GError **error);

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

[virt-tools-list] [PATCH 1/2] Remove unused 'window-removed' signal

[Eduardo Lima (Etrunko)]

Signed-off-by: Eduardo Lima (Etrunko) 
---
 src/virt-viewer-app.c | 14 --
 src/virt-viewer-app.h |  1 -
 2 files changed, 15 deletions(-)

diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index 653b30c..b14b509 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -176,7 +176,6 @@ enum {
 
 enum {
 SIGNAL_WINDOW_ADDED,
-SIGNAL_WINDOW_REMOVED,
 SIGNAL_LAST,
 };
 
@@ -1046,8 +1045,6 @@ static void 
virt_viewer_app_remove_nth_window(VirtViewerApp *self,
 g_debug("Remove window %d %p", nth, win);
 self->priv->windows = g_list_remove(self->priv->windows, win);
 
-g_signal_emit(self, signals[SIGNAL_WINDOW_REMOVED], 0, win);
-
 g_object_unref(win);
 }
 
@@ -2003,17 +2000,6 @@ virt_viewer_app_class_init (VirtViewerAppClass *klass)
  G_TYPE_NONE,
  1,
  G_TYPE_OBJECT);
-
-signals[SIGNAL_WINDOW_REMOVED] =
-g_signal_new("window-removed",
- G_OBJECT_CLASS_TYPE(object_class),
- G_SIGNAL_RUN_LAST,
- G_STRUCT_OFFSET(VirtViewerAppClass, window_removed),
- NULL, NULL,
- g_cclosure_marshal_VOID__OBJECT,
- G_TYPE_NONE,
- 1,
- G_TYPE_OBJECT);
 }
 
 void
diff --git a/src/virt-viewer-app.h b/src/virt-viewer-app.h
index bbbc9b4..7aa315d 100644
--- a/src/virt-viewer-app.h
+++ b/src/virt-viewer-app.h
@@ -48,7 +48,6 @@ typedef struct {
 
 /* signals */
 void (*window_added) (VirtViewerApp *self, VirtViewerWindow *window);
-void (*window_removed) (VirtViewerApp *self, VirtViewerWindow *window);
 
 /*< private >*/
 gboolean (*start) (VirtViewerApp *self, GError **error);
-- 
2.5.0

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list