Re: [virt-tools-list] [virt-manager PATCH] storagebrowse: refresh storage pool when open browse window or selecting a new item
-Original Message- From: Cole Robinson [mailto:crobi...@redhat.com] Sent: Saturday, January 10, 2015 1:04 AM To: Chen, Hanxiao/陈 晗霄; virt-tools-list@redhat.com Subject: Re: [virt-tools-list] [virt-manager PATCH] storagebrowse: refresh storage pool when open browse window or selecting a new item Please read this email I sent regarding refreshing pools: http://www.redhat.com/archives/virt-tools-list/2014-December/msg00036.html On 12/22/2014 10:59 PM, Chen Hanxiao wrote: do a refresh operation when: a) open 'Locate or create storage volume' window b) select a new item in 'Storage Pools' list refresh is supposed to be a potentially long running operation, so performing it every time a pool is selected is not acceptable. There's an explicit refresh button, people need to use that. Performing a refresh when launching the 'create volume' dialog should be okay, but stick it in createvol.py so it covers all cases I didn't follow that thread, sorry for the noise. BTW, do we have a search website for virt-tools mail archive? Thanks, - Chen ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [virt-manager PATCH] storagebrowse: refresh storage pool when open browse window or selecting a new item
On 01/13/2015 03:25 AM, Chen, Hanxiao wrote: -Original Message- From: Cole Robinson [mailto:crobi...@redhat.com] Sent: Saturday, January 10, 2015 1:04 AM To: Chen, Hanxiao/陈 晗霄; virt-tools-list@redhat.com Subject: Re: [virt-tools-list] [virt-manager PATCH] storagebrowse: refresh storage pool when open browse window or selecting a new item Please read this email I sent regarding refreshing pools: http://www.redhat.com/archives/virt-tools-list/2014-December/msg00036.html On 12/22/2014 10:59 PM, Chen Hanxiao wrote: do a refresh operation when: a) open 'Locate or create storage volume' window b) select a new item in 'Storage Pools' list refresh is supposed to be a potentially long running operation, so performing it every time a pool is selected is not acceptable. There's an explicit refresh button, people need to use that. Performing a refresh when launching the 'create volume' dialog should be okay, but stick it in createvol.py so it covers all cases I didn't follow that thread, sorry for the noise. BTW, do we have a search website for virt-tools mail archive? I'd just use google and do: site:redhat.com/archives mysearch or +virt-tools-list mysearch - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [virt-manager PATCH] storagebrowse: refresh storage pool when open browse window or selecting a new item
Please read this email I sent regarding refreshing pools: http://www.redhat.com/archives/virt-tools-list/2014-December/msg00036.html On 12/22/2014 10:59 PM, Chen Hanxiao wrote: do a refresh operation when: a) open 'Locate or create storage volume' window b) select a new item in 'Storage Pools' list refresh is supposed to be a potentially long running operation, so performing it every time a pool is selected is not acceptable. There's an explicit refresh button, people need to use that. Performing a refresh when launching the 'create volume' dialog should be okay, but stick it in createvol.py so it covers all cases - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [virt-manager PATCH] storagebrowse: refresh storage pool when open browse window or selecting a new item
ping -Original Message- From: virt-tools-list-boun...@redhat.com [mailto:virt-tools-list-boun...@redhat.com] On Behalf Of Chen Hanxiao Sent: Tuesday, December 23, 2014 12:00 PM To: virt-tools-list@redhat.com Subject: [virt-tools-list] [virt-manager PATCH] storagebrowse: refresh storage pool when open browse window or selecting a new item do a refresh operation when: a) open 'Locate or create storage volume' window b) select a new item in 'Storage Pools' list Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com --- virtManager/storagebrowse.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/virtManager/storagebrowse.py b/virtManager/storagebrowse.py index d4bd672..b69abb3 100644 --- a/virtManager/storagebrowse.py +++ b/virtManager/storagebrowse.py @@ -300,6 +300,8 @@ class vmmStorageBrowser(vmmGObjectUI): # Listeners def pool_selected(self, src_ignore=None): pool = self.current_pool() +if pool: +pool.refresh() can_new_vol = False tt = @@ -320,6 +322,7 @@ class vmmStorageBrowser(vmmGObjectUI): canchoose = bool(vol and vol[5]) self.widget(choose-volume).set_sensitive(canchoose) self.widget(vol-delete).set_sensitive(canchoose) +self.pool_refresh(vol) def refresh_current_pool(self, createvol=None): cp = self.current_pool() -- 1.9.3 ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
