[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number
On Tue, 4 Apr 2023 02:33:15 -0400 "Michael S. Tsirkin" wrote: > On Mon, Apr 03, 2023 at 10:57:35PM -0400, Parav Pandit wrote: > > > Both solutions are equally consistent in themselves, but I > > > argue the latter is better because: > > > * it is more consistent with historic usage > > Well index/vqn has mixed up anyway now. > > For historic reason, I agree that index is right. > > But it is too late now. > > Comments have not come on time. > > Why, is there a deadline? Is this blocking some other feature? For > something that is supposedly a cleanup we might as well get this right. > If you guys both agree index is better, and at this point it sounds > convincing, why not do it? It's more or less a machanical replacement. > It's not like there's a lot of word smithing going on here except for > 8/8 which really works with index just as well. I agree. Regards, Halil - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number
On Tue, Apr 04 2023, Halil Pasic wrote: > On Tue, 4 Apr 2023 03:07:26 -0400 > "Michael S. Tsirkin" wrote: > >> > 3. Once interrupt moderation series is merged, rename vqn to vq_index. >> > (really vqn reads better even though history say vq index). >> > Because votes is completed and voting period ended for the important >> > feature. >> >> interrupt moderation voting is still ongoing, isn't it? > > Yes it is. But not for very long. Close date is today. I > won't change my vote because of the index vs number discussion. I believe > we can include that patch in the cleanup if push comes to shove. But > I wouldn't have anything against that ballot getting withdrawn either. > I'm Cc-ing Heng Qi. ...it has actually closed right now. But I don't really see including it as a show stopper. - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
