Re: [Virtio-fs] [PATCH] virtiofsd: Remove fuse.h and struct fuse_module

2020-02-21 Thread Philippe Mathieu-Daudé

On 2/21/20 7:55 AM, Xiao Yang wrote:

All code in fuse.h and struct fuse_module are not used by virtiofsd
so removing them is safe.

Signed-off-by: Xiao Yang 
---
  tools/virtiofsd/fuse.h   | 1229 --
  tools/virtiofsd/fuse_i.h |   16 -
  2 files changed, 1245 deletions(-)
  delete mode 100644 tools/virtiofsd/fuse.h


Reviewed-by: Philippe Mathieu-Daudé 


___
Virtio-fs mailing list
Virtio-fs@redhat.com
https://www.redhat.com/mailman/listinfo/virtio-fs



Re: [Virtio-fs] [PATCH] virtiofsd: Remove fuse.h and struct fuse_module

2020-02-21 Thread Stefan Hajnoczi
On Fri, Feb 21, 2020 at 02:55:15PM +0800, Xiao Yang wrote:
> All code in fuse.h and struct fuse_module are not used by virtiofsd
> so removing them is safe.
> 
> Signed-off-by: Xiao Yang 
> ---
>  tools/virtiofsd/fuse.h   | 1229 --
>  tools/virtiofsd/fuse_i.h |   16 -
>  2 files changed, 1245 deletions(-)
>  delete mode 100644 tools/virtiofsd/fuse.h

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature
___
Virtio-fs mailing list
Virtio-fs@redhat.com
https://www.redhat.com/mailman/listinfo/virtio-fs


[Virtio-fs] [PATCH] virtiofsd: Remove fuse.h and struct fuse_module

2020-02-20 Thread Xiao Yang
All code in fuse.h and struct fuse_module are not used by virtiofsd
so removing them is safe.

Signed-off-by: Xiao Yang 
---
 tools/virtiofsd/fuse.h   | 1229 --
 tools/virtiofsd/fuse_i.h |   16 -
 2 files changed, 1245 deletions(-)
 delete mode 100644 tools/virtiofsd/fuse.h

diff --git a/tools/virtiofsd/fuse.h b/tools/virtiofsd/fuse.h
deleted file mode 100644
index aba13fef2d..00
--- a/tools/virtiofsd/fuse.h
+++ /dev/null
@@ -1,1229 +0,0 @@
-/*
- * FUSE: Filesystem in Userspace
- * Copyright (C) 2001-2007  Miklos Szeredi 
- *
- * This program can be distributed under the terms of the GNU LGPLv2.
- * See the file COPYING.LIB.
- */
-
-#ifndef FUSE_H_
-#define FUSE_H_
-
-/*
- *
- * This file defines the library interface of FUSE
- *
- * IMPORTANT: you should define FUSE_USE_VERSION before including this header.
- */
-
-#include "fuse_common.h"
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-/*
- * Basic FUSE API
- */
-
-/** Handle for a FUSE filesystem */
-struct fuse;
-
-/**
- * Readdir flags, passed to ->readdir()
- */
-enum fuse_readdir_flags {
-/**
- * "Plus" mode.
- *
- * The kernel wants to prefill the inode cache during readdir.  The
- * filesystem may honour this by filling in the attributes and setting
- * FUSE_FILL_DIR_FLAGS for the filler function.  The filesystem may also
- * just ignore this flag completely.
- */
-FUSE_READDIR_PLUS = (1 << 0),
-};
-
-enum fuse_fill_dir_flags {
-/**
- * "Plus" mode: all file attributes are valid
- *
- * The attributes are used by the kernel to prefill the inode cache
- * during a readdir.
- *
- * It is okay to set FUSE_FILL_DIR_PLUS if FUSE_READDIR_PLUS is not set
- * and vice versa.
- */
-FUSE_FILL_DIR_PLUS = (1 << 1),
-};
-
-/**
- * Function to add an entry in a readdir() operation
- *
- * The *off* parameter can be any non-zero value that enables the
- * filesystem to identify the current point in the directory
- * stream. It does not need to be the actual physical position. A
- * value of zero is reserved to indicate that seeking in directories
- * is not supported.
- *
- * @param buf the buffer passed to the readdir() operation
- * @param name the file name of the directory entry
- * @param stat file attributes, can be NULL
- * @param off offset of the next entry or zero
- * @param flags fill flags
- * @return 1 if buffer is full, zero otherwise
- */
-typedef int (*fuse_fill_dir_t)(void *buf, const char *name,
-   const struct stat *stbuf, off_t off,
-   enum fuse_fill_dir_flags flags);
-/**
- * Configuration of the high-level API
- *
- * This structure is initialized from the arguments passed to
- * fuse_new(), and then passed to the file system's init() handler
- * which should ensure that the configuration is compatible with the
- * file system implementation.
- */
-struct fuse_config {
-/**
- * If `set_gid` is non-zero, the st_gid attribute of each file
- * is overwritten with the value of `gid`.
- */
-int set_gid;
-unsigned int gid;
-
-/**
- * If `set_uid` is non-zero, the st_uid attribute of each file
- * is overwritten with the value of `uid`.
- */
-int set_uid;
-unsigned int uid;
-
-/**
- * If `set_mode` is non-zero, the any permissions bits set in
- * `umask` are unset in the st_mode attribute of each file.
- */
-int set_mode;
-unsigned int umask;
-
-/**
- * The timeout in seconds for which name lookups will be
- * cached.
- */
-double entry_timeout;
-
-/**
- * The timeout in seconds for which a negative lookup will be
- * cached. This means, that if file did not exist (lookup
- * retuned ENOENT), the lookup will only be redone after the
- * timeout, and the file/directory will be assumed to not
- * exist until then. A value of zero means that negative
- * lookups are not cached.
- */
-double negative_timeout;
-
-/**
- * The timeout in seconds for which file/directory attributes
- * (as returned by e.g. the `getattr` handler) are cached.
- */
-double attr_timeout;
-
-/**
- * Allow requests to be interrupted
- */
-int intr;
-
-/**
- * Specify which signal number to send to the filesystem when
- * a request is interrupted.  The default is hardcoded to
- * USR1.
- */
-int intr_signal;
-
-/**
- * Normally, FUSE assigns inodes to paths only for as long as
- * the kernel is aware of them. With this option inodes are
- * instead remembered for at least this many seconds.  This
- * will require more memory, but may be necessary when using
- * applications that make use of inode numbers.
- *
- * A number of -1 means that inodes will be remembered for the
- * entire life-time of the file-system process.
- */
-int remember;
-
-/**
-