[PATCH 16/25] Staging: hv: Make msg_dpc a global variable

2011-04-26 Thread K. Y. Srinivasan 
In preparation for cleaning up (getting rid of) of the hv_bus structure,
make msg_dpc a global variable.

Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Signed-off-by: Abhishek Kane v-abk...@microsoft.com
Signed-off-by: Hank Janssen hjans...@microsoft.com
---
 drivers/staging/hv/vmbus_drv.c |7 ---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
index f779d4e..028051d 100644
--- a/drivers/staging/hv/vmbus_drv.c
+++ b/drivers/staging/hv/vmbus_drv.c
@@ -42,10 +42,11 @@
 
 static struct pci_dev *hv_pci_dev;
 
+static struct tasklet_struct msg_dpc;
+
 /* Main vmbus driver data structure */
 struct hv_bus {
struct bus_type bus;
-   struct tasklet_struct msg_dpc;
struct tasklet_struct event_dpc;
 };
 
@@ -517,7 +518,7 @@ static irqreturn_t vmbus_isr(int irq, void *dev_id)
/* Schedules a dpc if necessary */
if (ret  0) {
if (test_bit(0, (unsigned long *)ret))
-   tasklet_schedule(hv_bus.msg_dpc);
+   tasklet_schedule(msg_dpc);
 
if (test_bit(1, (unsigned long *)ret))
tasklet_schedule(hv_bus.event_dpc);
@@ -552,7 +553,7 @@ static int vmbus_bus_init(struct pci_dev *pdev)
hv_bus.bus.name = driver_name;
 
/* Initialize the bus context */
-   tasklet_init(hv_bus.msg_dpc, vmbus_on_msg_dpc, 0);
+   tasklet_init(msg_dpc, vmbus_on_msg_dpc, 0);
tasklet_init(hv_bus.event_dpc, vmbus_on_event, 0);
 
/* Now, register the bus  with LDM */
-- 
1.7.4.1

___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH 16/25] Staging: hv: Make msg_dpc a global variable

2011-04-26 Thread Greg KH 
On Tue, Apr 26, 2011 at 09:20:33AM -0700, K. Y. Srinivasan wrote:
 In preparation for cleaning up (getting rid of) of the hv_bus structure,
 make msg_dpc a global variable.

It's static.  Ah, you mean for the whole bus.  Yeah, that's true,
wierd choice of words I guess...

thanks,

greg k-h
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization