Re: [PATCH net v2 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them
On Wed, Mar 23, 2022 at 09:22:02AM -0400, Michael S. Tsirkin wrote: On Wed, Mar 23, 2022 at 09:49:51AM +0100, Stefano Garzarella wrote: The first patch fixes a virtio-spec violation. The other two patches complete the driver configuration before using the VQs in the probe. The patch order should simplify backporting in stable branches. Ok but I think the order is wrong. It should be 2-3-1, otherwise bisect can pick just 1 and it will have the issues previous reviw pointed out. Right, I prioritized simplifying the backport, but obviously bisectability is priority! I'll send v3 changing the order in 2-3-1 Thanks, Stefano ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net v2 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them
On Wed, Mar 23, 2022 at 09:49:51AM +0100, Stefano Garzarella wrote: > The first patch fixes a virtio-spec violation. The other two patches > complete the driver configuration before using the VQs in the probe. > > The patch order should simplify backporting in stable branches. Ok but I think the order is wrong. It should be 2-3-1, otherwise bisect can pick just 1 and it will have the issues previous reviw pointed out. > v2: > - patch 1 is not changed from v1 > - added 2 patches to complete the driver configuration before using the > VQs in the probe [MST] > > v1: https://lore.kernel.org/netdev/20220322103823.83411-1-sgarz...@redhat.com/ > > Stefano Garzarella (3): > vsock/virtio: enable VQs early on probe > vsock/virtio: initialize vdev->priv before using VQs > vsock/virtio: read the negotiated features before using VQs > > net/vmw_vsock/virtio_transport.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > -- > 2.35.1 ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[PATCH net v2 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them
The first patch fixes a virtio-spec violation. The other two patches complete the driver configuration before using the VQs in the probe. The patch order should simplify backporting in stable branches. v2: - patch 1 is not changed from v1 - added 2 patches to complete the driver configuration before using the VQs in the probe [MST] v1: https://lore.kernel.org/netdev/20220322103823.83411-1-sgarz...@redhat.com/ Stefano Garzarella (3): vsock/virtio: enable VQs early on probe vsock/virtio: initialize vdev->priv before using VQs vsock/virtio: read the negotiated features before using VQs net/vmw_vsock/virtio_transport.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.35.1 ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization