Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On 08/08/2011 06:01 AM, Steven Rostedt wrote: > On Sat, 2011-08-06 at 11:22 -0700, Jeremy Fitzhardinge wrote: >> On 08/05/2011 06:58 PM, Konrad Rzeszutek Wilk wrote: >>> On Fri, Aug 05, 2011 at 11:14:23PM +0200, Ingo Molnar wrote: * Ingo Molnar wrote: > * Randy Dunlap wrote: > >> On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote: >>> On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote: >>> These build failures are still triggering upstream: >>> >>> arch/x86/xen/trace.c:44:2: error: array index in initializer not >>> of integer type >>> arch/x86/xen/trace.c:44:2: error: (near initialization for >>> ‘xen_hypercall_names’) >>> arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared >>> here (not in a function) >>> arch/x86/xen/trace.c:45:2: error: array index in initializer not >>> of integer type >>> arch/x86/xen/trace.c:45:2: error: (near initialization for >>> ‘xen_hypercall_names’) >> Oh, that I haven't seen. Can you send me the .config for that please. > You can't be trying very hard then. I see lots of these (but no, Ah, I am getting it now. Thanks for reporting it. >>> This should do the trick: >> Acked-by: Randy Dunlap > That patch did the trick here too: > > Acked-by: Ingo Molnar Except that i'm still seeing the occasional build failure - see the error log below. Config attached. >>> Much appreciate for the report. I believe this fix (which I think hit >>> linux-next yesterday?) should do that: >>> >>> commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd >>> Author: Jeremy Fitzhardinge >>> Date: Wed Aug 3 09:43:44 2011 -0700 >>> >>> xen/tracing: it looks like we wanted CONFIG_FTRACE >>> >>> Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER. >>> >>> Reported-by: Sander Eikelenboom >>> Tested-by: Sander Eikelenboom >>> Signed-off-by: Jeremy Fitzhardinge >>> Signed-off-by: Konrad Rzeszutek Wilk >>> >>> diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile >>> index 45e94ac..3326204 100644 >>> --- a/arch/x86/xen/Makefile >>> +++ b/arch/x86/xen/Makefile >>> @@ -15,7 +15,7 @@ obj-y := enlighten.o setup.o multicalls.o >>> mmu.o irq.o \ >>> grant-table.o suspend.o platform-pci-unplug.o \ >>> p2m.o >>> >>> -obj-$(CONFIG_FUNCTION_TRACER) += trace.o >>> +obj-$(CONFIG_FTRACE) += trace.o >>> >> I'm not sure this is correct either. Maybe it should be >> CONFIG_TRACEPOINTS? Steven? > Actually, I believe the correct answer is: > > CONFIG_EVENT_TRACING OK, thanks. J ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On Sat, 2011-08-06 at 11:22 -0700, Jeremy Fitzhardinge wrote: > On 08/05/2011 06:58 PM, Konrad Rzeszutek Wilk wrote: > > On Fri, Aug 05, 2011 at 11:14:23PM +0200, Ingo Molnar wrote: > >> * Ingo Molnar wrote: > >> > >>> * Randy Dunlap wrote: > >>> > On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote: > > On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote: > > These build failures are still triggering upstream: > > > > arch/x86/xen/trace.c:44:2: error: array index in initializer not > > of integer type > > arch/x86/xen/trace.c:44:2: error: (near initialization for > > ‘xen_hypercall_names’) > > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared > > here (not in a function) > > arch/x86/xen/trace.c:45:2: error: array index in initializer not > > of integer type > > arch/x86/xen/trace.c:45:2: error: (near initialization for > > ‘xen_hypercall_names’) > Oh, that I haven't seen. Can you send me the .config for that please. > >>> You can't be trying very hard then. I see lots of these (but no, > >> Ah, I am getting it now. Thanks for reporting it. > > This should do the trick: > Acked-by: Randy Dunlap > >>> That patch did the trick here too: > >>> > >>> Acked-by: Ingo Molnar > >> Except that i'm still seeing the occasional build failure - see the > >> error log below. Config attached. > > Much appreciate for the report. I believe this fix (which I think hit > > linux-next yesterday?) should do that: > > > > commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd > > Author: Jeremy Fitzhardinge > > Date: Wed Aug 3 09:43:44 2011 -0700 > > > > xen/tracing: it looks like we wanted CONFIG_FTRACE > > > > Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER. > > > > Reported-by: Sander Eikelenboom > > Tested-by: Sander Eikelenboom > > Signed-off-by: Jeremy Fitzhardinge > > Signed-off-by: Konrad Rzeszutek Wilk > > > > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile > > index 45e94ac..3326204 100644 > > --- a/arch/x86/xen/Makefile > > +++ b/arch/x86/xen/Makefile > > @@ -15,7 +15,7 @@ obj-y := enlighten.o setup.o multicalls.o > > mmu.o irq.o \ > > grant-table.o suspend.o platform-pci-unplug.o \ > > p2m.o > > > > -obj-$(CONFIG_FUNCTION_TRACER) += trace.o > > +obj-$(CONFIG_FTRACE) += trace.o > > > > I'm not sure this is correct either. Maybe it should be > CONFIG_TRACEPOINTS? Steven? Actually, I believe the correct answer is: CONFIG_EVENT_TRACING -- Steve ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On 08/05/2011 06:58 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Aug 05, 2011 at 11:14:23PM +0200, Ingo Molnar wrote: >> * Ingo Molnar wrote: >> >>> * Randy Dunlap wrote: >>> On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote: > On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote: > These build failures are still triggering upstream: > > arch/x86/xen/trace.c:44:2: error: array index in initializer not of > integer type > arch/x86/xen/trace.c:44:2: error: (near initialization for > ‘xen_hypercall_names’) > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared > here (not in a function) > arch/x86/xen/trace.c:45:2: error: array index in initializer not of > integer type > arch/x86/xen/trace.c:45:2: error: (near initialization for > ‘xen_hypercall_names’) Oh, that I haven't seen. Can you send me the .config for that please. >>> You can't be trying very hard then. I see lots of these (but no, >> Ah, I am getting it now. Thanks for reporting it. > This should do the trick: Acked-by: Randy Dunlap >>> That patch did the trick here too: >>> >>> Acked-by: Ingo Molnar >> Except that i'm still seeing the occasional build failure - see the >> error log below. Config attached. > Much appreciate for the report. I believe this fix (which I think hit > linux-next yesterday?) should do that: > > commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd > Author: Jeremy Fitzhardinge > Date: Wed Aug 3 09:43:44 2011 -0700 > > xen/tracing: it looks like we wanted CONFIG_FTRACE > > Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER. > > Reported-by: Sander Eikelenboom > Tested-by: Sander Eikelenboom > Signed-off-by: Jeremy Fitzhardinge > Signed-off-by: Konrad Rzeszutek Wilk > > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile > index 45e94ac..3326204 100644 > --- a/arch/x86/xen/Makefile > +++ b/arch/x86/xen/Makefile > @@ -15,7 +15,7 @@ obj-y := enlighten.o setup.o multicalls.o > mmu.o irq.o \ > grant-table.o suspend.o platform-pci-unplug.o \ > p2m.o > > -obj-$(CONFIG_FUNCTION_TRACER) += trace.o > +obj-$(CONFIG_FTRACE) += trace.o > I'm not sure this is correct either. Maybe it should be CONFIG_TRACEPOINTS? Steven? Thanks, J ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
Hi Konrad, On Fri, 5 Aug 2011 21:58:16 -0400 Konrad Rzeszutek Wilk wrote: > > Much appreciate for the report. I believe this fix (which I think hit > linux-next yesterday?) should do that: Yes, it is in next-20110805. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgpj4uvNNVAzv.pgp Description: PGP signature ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On Fri, Aug 05, 2011 at 11:14:23PM +0200, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > * Randy Dunlap wrote: > > > > > On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote: > > > > On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote: > > > > These build failures are still triggering upstream: > > > > > > > > arch/x86/xen/trace.c:44:2: error: array index in initializer not > > > > of integer type > > > > arch/x86/xen/trace.c:44:2: error: (near initialization for > > > > ‘xen_hypercall_names’) > > > > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared > > > > here (not in a function) > > > > arch/x86/xen/trace.c:45:2: error: array index in initializer not > > > > of integer type > > > > arch/x86/xen/trace.c:45:2: error: (near initialization for > > > > ‘xen_hypercall_names’) > > > > > > Oh, that I haven't seen. Can you send me the .config for that please. > > > >>> > > > >>> You can't be trying very hard then. I see lots of these (but no, > > > >> > > > >> Ah, I am getting it now. Thanks for reporting it. > > > > > > > > This should do the trick: > > > > > > Acked-by: Randy Dunlap > > > > That patch did the trick here too: > > > > Acked-by: Ingo Molnar > > Except that i'm still seeing the occasional build failure - see the > error log below. Config attached. Much appreciate for the report. I believe this fix (which I think hit linux-next yesterday?) should do that: commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd Author: Jeremy Fitzhardinge Date: Wed Aug 3 09:43:44 2011 -0700 xen/tracing: it looks like we wanted CONFIG_FTRACE Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER. Reported-by: Sander Eikelenboom Tested-by: Sander Eikelenboom Signed-off-by: Jeremy Fitzhardinge Signed-off-by: Konrad Rzeszutek Wilk diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile index 45e94ac..3326204 100644 --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile @@ -15,7 +15,7 @@ obj-y := enlighten.o setup.o multicalls.o mmu.o irq.o \ grant-table.o suspend.o platform-pci-unplug.o \ p2m.o -obj-$(CONFIG_FUNCTION_TRACER) += trace.o +obj-$(CONFIG_FTRACE) += trace.o obj-$(CONFIG_SMP) += smp.o obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o Planning to send all of the bug-fixes in my branch to Linus tomorrow - just leaving it in linux-next for the full 24-hrs at least to make sure nothing else goes haywire. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
* Randy Dunlap wrote: > On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote: > > On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote: > > These build failures are still triggering upstream: > > > > arch/x86/xen/trace.c:44:2: error: array index in initializer not of > > integer type > > arch/x86/xen/trace.c:44:2: error: (near initialization for > > ‘xen_hypercall_names’) > > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared > > here (not in a function) > > arch/x86/xen/trace.c:45:2: error: array index in initializer not of > > integer type > > arch/x86/xen/trace.c:45:2: error: (near initialization for > > ‘xen_hypercall_names’) > > Oh, that I haven't seen. Can you send me the .config for that please. > >>> > >>> You can't be trying very hard then. I see lots of these (but no, > >> > >> Ah, I am getting it now. Thanks for reporting it. > > > > This should do the trick: > > Acked-by: Randy Dunlap That patch did the trick here too: Acked-by: Ingo Molnar Thanks, Ingo ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote:
> On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote:
> These build failures are still triggering upstream:
>
> arch/x86/xen/trace.c:44:2: error: array index in initializer not of
> integer type
> arch/x86/xen/trace.c:44:2: error: (near initialization for
> ‘xen_hypercall_names’)
> arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here
> (not in a function)
> arch/x86/xen/trace.c:45:2: error: array index in initializer not of
> integer type
> arch/x86/xen/trace.c:45:2: error: (near initialization for
> ‘xen_hypercall_names’)
Oh, that I haven't seen. Can you send me the .config for that please.
>>>
>>> You can't be trying very hard then. I see lots of these (but no,
>>
>> Ah, I am getting it now. Thanks for reporting it.
>
> This should do the trick:
Acked-by: Randy Dunlap
Thanks.
> diff --git a/arch/x86/xen/trace.c b/arch/x86/xen/trace.c
> index 734beba..520022d 100644
> --- a/arch/x86/xen/trace.c
> +++ b/arch/x86/xen/trace.c
> @@ -1,4 +1,5 @@
> #include
> +#include
>
> #define N(x) [__HYPERVISOR_##x] = "("#x")"
> static const char *xen_hypercall_names[] = {
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On Thu, 4 Aug 2011 18:40:20 -0400 Konrad Rzeszutek Wilk wrote:
> On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote:
> > > > > These build failures are still triggering upstream:
> > > > >
> > > > > arch/x86/xen/trace.c:44:2: error: array index in initializer not of
> > > > > integer type
> > > > > arch/x86/xen/trace.c:44:2: error: (near initialization for
> > > > > ‘xen_hypercall_names’)
> > > > > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared
> > > > > here (not in a function)
> > > > > arch/x86/xen/trace.c:45:2: error: array index in initializer not of
> > > > > integer type
> > > > > arch/x86/xen/trace.c:45:2: error: (near initialization for
> > > > > ‘xen_hypercall_names’)
> > > >
> > > > Oh, that I haven't seen. Can you send me the .config for that please.
> > >
> > > You can't be trying very hard then. I see lots of these (but no,
> >
> > Ah, I am getting it now. Thanks for reporting it.
>
> This should do the trick:
OK, I have it building now. Will do a few builds before I report
back on it.
Thanks.
>
> diff --git a/arch/x86/xen/trace.c b/arch/x86/xen/trace.c
> index 734beba..520022d 100644
> --- a/arch/x86/xen/trace.c
> +++ b/arch/x86/xen/trace.c
> @@ -1,4 +1,5 @@
> #include
> +#include
>
> #define N(x) [__HYPERVISOR_##x] = "("#x")"
> static const char *xen_hypercall_names[] = {
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On Thu, 4 Aug 2011 18:30:18 -0400 Konrad Rzeszutek Wilk wrote: > > > Do you have a manual of how you guys run your workflow? > > > > I just run 30-50 randconfigs per night (cron job). > > Ok, do you have an mailing list where you send the output too? I don't report 100% of what I see. What I do report goes to linux-next, lkml, & any other relevant mailing list, and sometimes to individuals as well. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote:
> > > > These build failures are still triggering upstream:
> > > >
> > > > arch/x86/xen/trace.c:44:2: error: array index in initializer not of
> > > > integer type
> > > > arch/x86/xen/trace.c:44:2: error: (near initialization for
> > > > ‘xen_hypercall_names’)
> > > > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared
> > > > here (not in a function)
> > > > arch/x86/xen/trace.c:45:2: error: array index in initializer not of
> > > > integer type
> > > > arch/x86/xen/trace.c:45:2: error: (near initialization for
> > > > ‘xen_hypercall_names’)
> > >
> > > Oh, that I haven't seen. Can you send me the .config for that please.
> >
> > You can't be trying very hard then. I see lots of these (but no,
>
> Ah, I am getting it now. Thanks for reporting it.
This should do the trick:
diff --git a/arch/x86/xen/trace.c b/arch/x86/xen/trace.c
index 734beba..520022d 100644
--- a/arch/x86/xen/trace.c
+++ b/arch/x86/xen/trace.c
@@ -1,4 +1,5 @@
#include
+#include
#define N(x) [__HYPERVISOR_##x] = "("#x")"
static const char *xen_hypercall_names[] = {
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
> > > These build failures are still triggering upstream: > > > > > > arch/x86/xen/trace.c:44:2: error: array index in initializer not of > > > integer type > > > arch/x86/xen/trace.c:44:2: error: (near initialization for > > > ‘xen_hypercall_names’) > > > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here > > > (not in a function) > > > arch/x86/xen/trace.c:45:2: error: array index in initializer not of > > > integer type > > > arch/x86/xen/trace.c:45:2: error: (near initialization for > > > ‘xen_hypercall_names’) > > > > Oh, that I haven't seen. Can you send me the .config for that please. > > You can't be trying very hard then. I see lots of these (but no, Ah, I am getting it now. Thanks for reporting it. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
> > > arch/x86/xen/trace.c:44:2: error: array index in initializer not of > > > integer type > > > arch/x86/xen/trace.c:44:2: error: (near initialization for > > > ‘xen_hypercall_names’) > > > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here > > > (not in a function) > > > arch/x86/xen/trace.c:45:2: error: array index in initializer not of > > > integer type > > > arch/x86/xen/trace.c:45:2: error: (near initialization for > > > ‘xen_hypercall_names’) > > > > Oh, that I haven't seen. Can you send me the .config for that please. > > You can't be trying very hard then. I see lots of these (but no, Hm, It is not obvious to me what is causing that compile failure. Any ideas? > I haven't reported them. One can grow weary of reporting xen bugs.) > > > > > even after: > > > > > > b3c4b9825075: xen/tracing: fix compile errors when tracing is disabled. > > > > > > Btw., that the heck is going on with the commit that introduced the > > > build failure: > > > > > > commit bd9ddc875b6659f9f74dcfd285c472bc58041abd > > > Author: Jeremy Fitzhardinge > > > AuthorDate: Mon Jun 20 17:52:13 2011 -0700 > > > Commit: Jeremy Fitzhardinge > > > CommitDate: Mon Jul 18 15:43:46 2011 -0700 > > > > > > It was apparently rebased shortly before the merge window and sent to > > > > Well, the rebase I get - it was done on top of the merge that introduced > > the new functionality. > > > > > Linus 3 days later, with little to no linux-next testing ... > > > > It did fix the compile problem.. albeit it created another one. > > > > > > I'm absolutely unhappy about how the Xen tree is being run. It's > > > using a sloppy, crappy workflow and it is producing crap. > > > > Do you have a manual of how you guys run your workflow? > > I just run 30-50 randconfigs per night (cron job). Ok, do you have an mailing list where you send the output too? ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On Thu, 4 Aug 2011 15:55:39 -0400 Konrad Rzeszutek Wilk wrote: > On Thu, Aug 04, 2011 at 09:35:34PM +0200, Ingo Molnar wrote: > > > > * Randy Dunlap wrote: > > > > > On Mon, 25 Jul 2011 16:25:42 +1000 Stephen Rothwell wrote: > > > > > > > Hi all, > > > > > > xen has lots of build errors and warnings (all on x86_64). > > Hm, I have a fix in my linux-next (and stable/bug.fixes) for this that I was > thinking > to send in a couple of days .. > > > commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd > Author: Jeremy Fitzhardinge > Date: Wed Aug 3 09:43:44 2011 -0700 > > xen/tracing: it looks like we wanted CONFIG_FTRACE > > Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER. > > Reported-by: Sander Eikelenboom > Tested-by: Sander Eikelenboom > Signed-off-by: Jeremy Fitzhardinge > Signed-off-by: Konrad Rzeszutek Wilk > > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile > index 45e94ac..3326204 100644 > --- a/arch/x86/xen/Makefile > +++ b/arch/x86/xen/Makefile > @@ -15,7 +15,7 @@ obj-y := enlighten.o setup.o multicalls.o > mmu.o irq.o \ > grant-table.o suspend.o platform-pci-unplug.o \ > p2m.o > > -obj-$(CONFIG_FUNCTION_TRACER) += trace.o > +obj-$(CONFIG_FTRACE) += trace.o > > obj-$(CONFIG_SMP)+= smp.o > obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o > > .. snip of the long compile error.. > > > These build failures are still triggering upstream: > > > > arch/x86/xen/trace.c:44:2: error: array index in initializer not of > > integer type > > arch/x86/xen/trace.c:44:2: error: (near initialization for > > ‘xen_hypercall_names’) > > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here > > (not in a function) > > arch/x86/xen/trace.c:45:2: error: array index in initializer not of > > integer type > > arch/x86/xen/trace.c:45:2: error: (near initialization for > > ‘xen_hypercall_names’) > > Oh, that I haven't seen. Can you send me the .config for that please. You can't be trying very hard then. I see lots of these (but no, I haven't reported them. One can grow weary of reporting xen bugs.) > > even after: > > > > b3c4b9825075: xen/tracing: fix compile errors when tracing is disabled. > > > > Btw., that the heck is going on with the commit that introduced the > > build failure: > > > > commit bd9ddc875b6659f9f74dcfd285c472bc58041abd > > Author: Jeremy Fitzhardinge > > AuthorDate: Mon Jun 20 17:52:13 2011 -0700 > > Commit: Jeremy Fitzhardinge > > CommitDate: Mon Jul 18 15:43:46 2011 -0700 > > > > It was apparently rebased shortly before the merge window and sent to > > Well, the rebase I get - it was done on top of the merge that introduced > the new functionality. > > > Linus 3 days later, with little to no linux-next testing ... > > It did fix the compile problem.. albeit it created another one. > > > > I'm absolutely unhappy about how the Xen tree is being run. It's > > using a sloppy, crappy workflow and it is producing crap. > > Do you have a manual of how you guys run your workflow? I just run 30-50 randconfigs per night (cron job). --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
On Thu, Aug 04, 2011 at 09:35:34PM +0200, Ingo Molnar wrote: > > * Randy Dunlap wrote: > > > On Mon, 25 Jul 2011 16:25:42 +1000 Stephen Rothwell wrote: > > > > > Hi all, > > > > xen has lots of build errors and warnings (all on x86_64). Hm, I have a fix in my linux-next (and stable/bug.fixes) for this that I was thinking to send in a couple of days .. commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd Author: Jeremy Fitzhardinge Date: Wed Aug 3 09:43:44 2011 -0700 xen/tracing: it looks like we wanted CONFIG_FTRACE Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER. Reported-by: Sander Eikelenboom Tested-by: Sander Eikelenboom Signed-off-by: Jeremy Fitzhardinge Signed-off-by: Konrad Rzeszutek Wilk diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile index 45e94ac..3326204 100644 --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile @@ -15,7 +15,7 @@ obj-y := enlighten.o setup.o multicalls.o mmu.o irq.o \ grant-table.o suspend.o platform-pci-unplug.o \ p2m.o -obj-$(CONFIG_FUNCTION_TRACER) += trace.o +obj-$(CONFIG_FTRACE) += trace.o obj-$(CONFIG_SMP) += smp.o obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o .. snip of the long compile error.. > These build failures are still triggering upstream: > > arch/x86/xen/trace.c:44:2: error: array index in initializer not of integer > type > arch/x86/xen/trace.c:44:2: error: (near initialization for > ‘xen_hypercall_names’) > arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here (not > in a function) > arch/x86/xen/trace.c:45:2: error: array index in initializer not of integer > type > arch/x86/xen/trace.c:45:2: error: (near initialization for > ‘xen_hypercall_names’) Oh, that I haven't seen. Can you send me the .config for that please. > > even after: > > b3c4b9825075: xen/tracing: fix compile errors when tracing is disabled. > > Btw., that the heck is going on with the commit that introduced the > build failure: > > commit bd9ddc875b6659f9f74dcfd285c472bc58041abd > Author: Jeremy Fitzhardinge > AuthorDate: Mon Jun 20 17:52:13 2011 -0700 > Commit: Jeremy Fitzhardinge > CommitDate: Mon Jul 18 15:43:46 2011 -0700 > > It was apparently rebased shortly before the merge window and sent to Well, the rebase I get - it was done on top of the merge that introduced the new functionality. > Linus 3 days later, with little to no linux-next testing ... It did fix the compile problem.. albeit it created another one. > > I'm absolutely unhappy about how the Xen tree is being run. It's > using a sloppy, crappy workflow and it is producing crap. Do you have a manual of how you guys run your workflow? ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
