Re: [PATCH] virtio-balloon: correct the comment of virtballoon_migratepage()

[Xuan Zhuo]

On Sun, 13 Aug 2023 22:07:09 +0800, Xueshi Hu  wrote:
> After commit 68f2736a8583 ("mm: Convert all PageMovable users to
> movable_operations"), the execution path has been changed to
>
> move_to_new_folio
>   movable_operations->migrate_page
>   balloon_page_migrate
>   balloon_page_migrate->balloon_page_migrate
>   balloon_page_migrate
>
> Correct the outdated comment.
>
> Signed-off-by: Xueshi Hu 

Reviewed-by: Xuan Zhuo 

> ---
>  drivers/virtio/virtio_balloon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 5b15936a5214..f5aac6cf3aa9 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -741,7 +741,7 @@ static void report_free_page_func(struct work_struct 
> *work)
>   *  2) update the host about the old page removed from vb->pages list;
>   *
>   * This function preforms the balloon page migration task.
> - * Called through balloon_mapping->a_ops->migratepage
> + * Called through movable_operations->migrate_page
>   */
>  static int virtballoon_migratepage(struct balloon_dev_info *vb_dev_info,
>   struct page *newpage, struct page *page, enum migrate_mode mode)
> --
> 2.40.1
>
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] virtio-balloon: correct the comment of virtballoon_migratepage()

[David Hildenbrand]

On 13.08.23 16:07, Xueshi Hu wrote:

After commit 68f2736a8583 ("mm: Convert all PageMovable users to
movable_operations"), the execution path has been changed to

move_to_new_folio
movable_operations->migrate_page
balloon_page_migrate
balloon_page_migrate->balloon_page_migrate
balloon_page_migrate

Correct the outdated comment.

Signed-off-by: Xueshi Hu 
---
  drivers/virtio/virtio_balloon.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 5b15936a5214..f5aac6cf3aa9 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -741,7 +741,7 @@ static void report_free_page_func(struct work_struct *work)
   *  2) update the host about the old page removed from vb->pages list;
   *
   * This function preforms the balloon page migration task.
- * Called through balloon_mapping->a_ops->migratepage
+ * Called through movable_operations->migrate_page
   */
  static int virtballoon_migratepage(struct balloon_dev_info *vb_dev_info,
struct page *newpage, struct page *page, enum migrate_mode mode)


Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb

___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization