Re: [PATCH 1/6] lguest: host code tidyups

2007-05-15 Thread Stephen Rothwell 
On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell [EMAIL PROTECTED] wrote:

 @@ -420,7 +421,7 @@ static int __init init(void)
   lock_cpu_hotplug();
   if (cpu_has_pge) { /* We have a broader idea of global. */
   cpu_had_pge = 1;
 - on_each_cpu(adjust_pge, 0, 0, 1);
 + on_each_cpu(adjust_pge, (void *)0, 0, 1);

Sorry?  What ever happened to a simple NULL?

--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgpADcZrfSlqy.pgp
Description: PGP signature
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/6] lguest: host code tidyups

2007-05-15 Thread Stephen Rothwell 
On Tue, 15 May 2007 21:42:35 +1000 Stephen Rothwell [EMAIL PROTECTED] wrote:

 On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell [EMAIL PROTECTED] wrote:
 
  @@ -420,7 +421,7 @@ static int __init init(void)
  lock_cpu_hotplug();
  if (cpu_has_pge) { /* We have a broader idea of global. */
  cpu_had_pge = 1;
  -   on_each_cpu(adjust_pge, 0, 0, 1);
  +   on_each_cpu(adjust_pge, (void *)0, 0, 1);

 Sorry?  What ever happened to a simple NULL?

Oh, I guess that is an explicit (numeric) 0 (of some type) caste to
void * because of the prototype - rather than not passing anything?

--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgpwkwL73W3sn.pgp
Description: PGP signature
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/6] lguest: host code tidyups

2007-05-15 Thread Rusty Russell 
On Tue, 2007-05-15 at 21:47 +1000, Stephen Rothwell wrote:
 On Tue, 15 May 2007 21:42:35 +1000 Stephen Rothwell [EMAIL PROTECTED] wrote:
 
  On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell [EMAIL PROTECTED] wrote:
   - on_each_cpu(adjust_pge, 0, 0, 1);
   + on_each_cpu(adjust_pge, (void *)0, 0, 1);
 
  Sorry?  What ever happened to a simple NULL?
 
 Oh, I guess that is an explicit (numeric) 0 (of some type) caste to
 void * because of the prototype - rather than not passing anything?

Indeed.  We really want to pass a bool, but on_each_cpu uses a void *.
Hence the clearest solution seemed (void *)0 and (void *)1 in the
callers.

Thanks,
Rusty.


___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization