Re: [PATCH 12/21] Staging: hv: Cleanup irq management
On Thu, 10 Mar 2011, K. Y. Srinivasan wrote: Now that vmbus_driver is a platform pci driver, cleanup the irq allocation mess by using the standard irq allocation mechanisms. Note that this patch generates an error when the checkpatch script is run because of the IRQF_SAMPLE_RANDOM flag used in request_irq() function. This interrupt is the only external event this VM will get and consequently if this flag (IRQF_SAMPLE_RANDOM) is not specified, experimentally we have shown that the entropy in the VM will very very low. Fair enough. We need to come up with some way to work around this though. } - vector = VMBUS_IRQ_VECTOR; - DPRINT_INFO(VMBUS_DRV, irq 0x%x vector 0x%x, vmbus_irq, vector); + vector = IRQ0_VECTOR + pdev-irq; + DPRINT_INFO(VMBUS_DRV, irq 0x%x vector 0x%x, pdev-irq, + IRQ0_VECTOR + pdev-irq); Why evaluating vector first and then not using it for that debug print thingy? Btw, are you going to replace that DPRINT_* stuff as well ? Thanks, tglx ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [PATCH 12/21] Staging: hv: Cleanup irq management
On Mar 10, 2011, at 14:46, Thomas Gleixner t...@linutronix.de wrote: } -vector = VMBUS_IRQ_VECTOR; -DPRINT_INFO(VMBUS_DRV, irq 0x%x vector 0x%x, vmbus_irq, vector); +vector = IRQ0_VECTOR + pdev-irq; +DPRINT_INFO(VMBUS_DRV, irq 0x%x vector 0x%x, pdev-irq, +IRQ0_VECTOR + pdev-irq); Why evaluating vector first and then not using it for that debug print thingy? Btw, are you going to replace that DPRINT_* stuff as well ? Thanks, Yes, that is in my next set of patches. Hank ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
RE: [PATCH 12/21] Staging: hv: Cleanup irq management
-Original Message- From: Hank Janssen Sent: Thursday, March 10, 2011 5:54 PM To: Thomas Gleixner Cc: KY Srinivasan; gre...@suse.de; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org; Haiyang Zhang; Mike Sterling; Abhishek Kane (Mindtree Consulting PVT LTD) Subject: Re: [PATCH 12/21] Staging: hv: Cleanup irq management On Mar 10, 2011, at 14:46, Thomas Gleixner t...@linutronix.de wrote: } -vector = VMBUS_IRQ_VECTOR; -DPRINT_INFO(VMBUS_DRV, irq 0x%x vector 0x%x, vmbus_irq, vector); +vector = IRQ0_VECTOR + pdev-irq; +DPRINT_INFO(VMBUS_DRV, irq 0x%x vector 0x%x, pdev-irq, +IRQ0_VECTOR + pdev-irq); Why evaluating vector first and then not using it for that debug print thingy? Good point; I will fix this before Hank gets rid of the DPRINT_INFO altogether. Regards, K. Y ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
