Re: [vpp-dev] HQoS

2019-05-08 Thread Abeeha Aqeel 
Hi Hongjun,

Yes, sure. I will try the patch and share my results as soon as possible.


Regards,
 
Abeeha Aqeel
Network Design Engineer
Xflow Research Inc.
+923245062309 (GMT+5)
abeeha.aq...@xflowresearch.com
www.xflowresearch.com



From: Ni, Hongjun
Sent: Tuesday, May 7, 2019 6:40 PM
To: Abeeha Aqeel; Singh, Jasvinder
Cc: b...@xflowresearch.com; vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] HQoS

Hi Abeeha,

There is a patch submitted to fix the API change.   
https://gerrit.fd.io/r/#/c/16839/
Could you help to give it a try?

Thanks,
Hongjun

From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Abeeha Aqeel
Sent: Monday, May 6, 2019 6:32 PM
To: Ni, Hongjun 
Cc: b...@xflowresearch.com; vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] HQoS

Hi Hongjun,

I have tested the HQoS Plugin with iperf3. Below is a simple topology I have 
implemented:
 

First, I tested the default profile (profile 0) provided by VPP and assigned it 
to all 4096 pipes (users) which should give approximately 2MB (10G/4096) to 
each user. It worked fine for 5 users i.e. each user was assigned 2MB but for 
an increased number of users it didn’t work the same way. I changed the token 
bucket rate, token bucket size and tc_period parameters in the hqos.c code 
which didn’t give me any concrete results. I have attached results for 10  
clients with different combinations of token bucket size, token bucket rate and 
tc_period.

Any ideas what the problem might be ? 

Also, in what proportion should the tb_rate, tb_size , tc_rate and tc_period  
be assigned? 


S#
Rate (Bytes per second)
Token Bucket Size (Bytes)
TC Period (ms)
Total no of PPPoE sessions
Expected Result (Cumulative average bandwidth in Mbps)
Actual Result (Cumulative average bandwidth in Mbps)
Comments

Subport
Pipe
Subport 
Pipe
Subport
Pipe




1
125000
305175
100
100
10
40
10
24.4
8.1
vpp remains stable
2
125000
305175
100
100
10
60
10
24.4
12.72
vpp remains stable
3
125000
305175
100
100
10
100
10
24.4
11.4
vpp remains stable
4
125000
305175
100
1000
10
40
10
24.4
12.1
vpp remains stable
5
125000
305175
1000
1000
10
40
10
24.4
12.03
vpp remains stable
6
125000
305175
1000
1000
10
100
10
24.4
2.21
vpp crashes after a few seconds
7
125000
305175
100
100
10
60
10
24.4
12.1
vpp remains stable



Regards,
 
Abeeha Aqeel
Network Design Engineer
Xflow Research Inc.
+923245062309 (GMT+5)
abeeha.aq...@xflowresearch.com
www.xflowresearch.com



From: Ni, Hongjun
Sent: Monday, May 6, 2019 12:52 PM
Subject: RE: [vpp-dev] HQoS

Hi Abeeha,

For downstream bandwidth limiting, we leveraged HQos plugin in OpenBRAS 
solution.
In our previous integration test, it could support 64K subscribers with HQos.

Thanks,
Hongjun

From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Abeeha Aqeel
Sent: Monday, May 6, 2019 3:28 PM
To: Ni, Hongjun 
Cc: b...@xflowresearch.com; vpp-dev@lists.fd.io
Subject: [vpp-dev] HQoS

Hi Hongjun,  

I have been trying to implement downstream bandwidth limiting using HQoS plugin 
in vpp. It works fine for a certain number of clients (less than 5) but doesn’t 
assign proper bandwidth for larger number of clients. 

Can you please elaborate which method is being used in the OpenBRAS solution 
for band limiting traffic? Are you using the token-bucket algorithm as well?


Regards,
 
Abeeha Aqeel
Network Design Engineer
Xflow Research Inc.
+923245062309 (GMT+5)
abeeha.aq...@xflowresearch.com
www.xflowresearch.com





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12961): https://lists.fd.io/g/vpp-dev/message/12961
Mute This Topic: https://lists.fd.io/mt/31517544/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Introducing vpptop - real-time viewer for VPP stats using dynamic terminal user interface #govpp

2019-05-08 Thread Jerome Tollet via Lists.Fd.Io 
Hi Andrej,
I  didn’t try it but video is really great!
Jerome

De :  au nom de "Ondrej Fabry -X (ofabry - PANTHEON 
TECHNOLOGIES at Cisco) via Lists.Fd.Io" 
Répondre à : "Ondrej Fabry -X (ofabry - PANTHEON TECHNOLOGIES at Cisco)" 

Date : mercredi 8 mai 2019 à 19:05
À : "vpp-dev@lists.fd.io" 
Cc : "vpp-dev@lists.fd.io" 
Objet : [vpp-dev] Introducing vpptop - real-time viewer for VPP stats using 
dynamic terminal user interface #govpp

Hey vpp-devs,

I'd like to introduce vpptop project that was just open sourced by 
Pantheon.TECH.
https://github.com/PantheonTechnologies/vpptop

What is vpptop?
The vpptop is a Go implementation of real-time viewer for VPP metrics provided 
by dynamic terminal user interface.

Here's short demo preview of vpptop in action.
https://asciinema.org/a/NHODZM2ebcwWFPEEPcja8X19R

Find more information in the README file.

Regards,
Ondrej Fabry
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12960): https://lists.fd.io/g/vpp-dev/message/12960
Mute This Topic: https://lists.fd.io/mt/31545571/21656
Mute #govpp: https://lists.fd.io/mk?hashtag=govpp=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Introducing vpptop - real-time viewer for VPP stats using dynamic terminal user interface #govpp

2019-05-08 Thread Ondrej Fabry -X (ofabry - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io 
Hey vpp-devs,

I'd like to introduce *vpptop* project that was just open sourced by 
Pantheon.TECH.
https://github.com/PantheonTechnologies/vpptop

What is *vpptop?
* The vpptop is a Go implementation of real-time viewer for VPP metrics 
provided by dynamic terminal user interface. *
*
Here's short *demo preview* of vpptop in action.
https://asciinema.org/a/NHODZM2ebcwWFPEEPcja8X19R *
*
Find more information in the README file.

Regards,
Ondrej Fabry
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12959): https://lists.fd.io/g/vpp-dev/message/12959
Mute This Topic: https://lists.fd.io/mt/31545571/21656
Mute #govpp: https://lists.fd.io/mk?hashtag=govpp=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] centos ninja failures

2019-05-08 Thread Ed Kern via Lists.Fd.Io 


On May 8, 2019, at 8:36 AM, Thomas F Herbert 
mailto:therb...@redhat.com>> wrote:


OK,  ninja build failures are intermittent?


ok..havent splinted way back in build history intermittent is not the word I 
would choose.


Other changes are not hitting this issue at all..

This specific change
https://gerrit.fd.io/r/#/c/19350/

seems to have a 100% hit rate.



I am trying to understand how to isolate the problem.

Can it be triggered by doing retest while a current build is in progress?

not clear to me what you mean here since there is no make test running for 
centos here…


Ed



--Tom

On 05/08/2019 10:25 AM, Ed Kern via Lists.Fd.Io wrote:

starting new thread because it really has nothing to do with previous thread…

So I am not going to write:
a.  its related to your code
b. its not the build infra


But I will say there have been good centos verify runs…

BEFORE your patches
BETWEEN various revisions of your changes
BETWEEN retries of your changes
AFTER you stopped trying to retry your changes

With multiple different patches…

So not really having anything to track on the build infra side (nor is this a 
voting issue)  Im starting
a new thread and including tom to see if he has any centos guesses on why we 
are only seeing
problems on centos.

Ed





On May 8, 2019, at 2:46 AM, Yu, Ping 
 wrote:

Recently centOS build always fail and patch review is blocked even retrying 
several times.


16:17:11 -- Configuring done
16:17:12 -- Generating done
16:17:12 -- Build files have been written to: 
/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root/build-vpp-native/vpp
16:17:12 ninja: error: manifest 'build.ninja' still dirty after 100 tries
16:17:12
16:17:12 make[4]: *** [Makefile:695: vpp-build] Error 1
16:17:12 make[4]: Leaving directory 
'/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root'
16:17:12 make[3]: *** [Makefile:931: install-packages] Error 1
16:17:12 make[3]: Leaving directory 
'/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root'
16:17:12 error: Bad exit status from /var/tmp/rpm-tmp.8TtZeQ (%build)
16:17:12
16:17:12
16:17:12 RPM build errors:
16:17:12 Bad exit status from /var/tmp/rpm-tmp.8TtZeQ (%build)
16:17:12 make[2]: *** [RPM] Error 1
16:17:12 make[2]: Leaving directory 
`/w/workspace/vpp-verify-master-centos7/extras/rpm'
16:17:12 make[1]: *** [pkg-rpm] Error 2
16:17:12 make[1]: Leaving directory `/w/workspace/vpp-verify-master-centos7'
16:17:12 make: *** [verify] Error 2
16:17:12 Build step 'Execute shell' marked build as failure


-Original Message-
From: vpp-dev@lists.fd.io 
[mailto:vpp-dev@lists.fd.io] On Behalf Of Vratko Polak -X (vrpolak - PANTHEON 
TECHNOLOGIES at Cisco) via Lists.Fd.Io
Sent: Tuesday, May 7, 2019 4:21 PM
To: Ed Kern (ejk) ; Klement Sekera -X 
(ksekera - PANTHEON TECHNOLOGIES at Cisco) 

Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] false verified + 1 for gerrit jobs



reduce the number of retries (or possibly completely)


+1 for completely.

Vratko.

-Original Message-
From: vpp-dev@lists.fd.io 
 On Behalf Of Ed Kern via 
Lists.Fd.Io
Sent: Tuesday, 2019-May-07 00:34
To: Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) 

Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] false verified + 1 for gerrit jobs

This is a known issue with how the retry mechanic interacts (badly) with gerrit 
occasionally.  This odds of this happening were a bit higher over the last
couple of days specific to centos retries.   This is tied to the JNLP changes
made to csit and how the initial connection is made.   While the change
has improved JNLP issues across the board there are a couple new nits
that ill have to debug.

At this point though I’m not going to touch/debug further until the csit 
jobs/reports are completed.

Im actually hopeful that ill be able to reduce the number of retries (or 
possibly completely) in the long run with the HAProxy bypass in place.

Ed






On May 6, 2019, at 11:18 AM, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES 
at Cisco)  wrote:

Hi all,

I noticed a job getting a +1 even though some of the builds failed ...

https://gerrit.fd.io/r/#/c/18444/

please note patch set 9 

fd.io JJB
Patch Set 9: Verified-1 Build Failed
https://jenkins.fd.io/job/vpp-arm-verify-master-ubuntu1804/2459/ :
FAILURE No problems were identified. If you know why this problem
occurred, please add a suitable Cause for it. (
https://jenkins.fd.io/job/vpp-arm-verify-master-ubuntu1804/2459/ )
Logs:
https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-arm-verify-mas
ter-ubuntu1804/2459
https://jenkins.fd.io/job/vpp-beta-verify-master-ubuntu1804/6891/ :
FAILURE No problems

Re: [vpp-dev] centos ninja failures

2019-05-08 Thread Thomas F Herbert 

OK,  ninja build failures are intermittent?

I am trying to understand how to isolate the problem.

Can it be triggered by doing retest while a current build is in progress?

--Tom

On 05/08/2019 10:25 AM, Ed Kern via Lists.Fd.Io wrote:

starting new thread because it really has nothing to do with previous thread…

So I am not going to write:
a.  its related to your code
b. its not the build infra


But I will say there have been good centos verify runs…

BEFORE your patches
BETWEEN various revisions of your changes
BETWEEN retries of your changes
AFTER you stopped trying to retry your changes

With multiple different patches…

So not really having anything to track on the build infra side (nor is this a 
voting issue)  Im starting
a new thread and including tom to see if he has any centos guesses on why we 
are only seeing
problems on centos.

Ed




On May 8, 2019, at 2:46 AM, Yu, Ping  wrote:

Recently centOS build always fail and patch review is blocked even retrying 
several times.


16:17:11 -- Configuring done
16:17:12 -- Generating done
16:17:12 -- Build files have been written to: 
/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root/build-vpp-native/vpp
16:17:12 ninja: error: manifest 'build.ninja' still dirty after 100 tries
16:17:12
16:17:12 make[4]: *** [Makefile:695: vpp-build] Error 1
16:17:12 make[4]: Leaving directory 
'/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root'
16:17:12 make[3]: *** [Makefile:931: install-packages] Error 1
16:17:12 make[3]: Leaving directory 
'/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root'
16:17:12 error: Bad exit status from /var/tmp/rpm-tmp.8TtZeQ (%build)
16:17:12
16:17:12
16:17:12 RPM build errors:
16:17:12 Bad exit status from /var/tmp/rpm-tmp.8TtZeQ (%build)
16:17:12 make[2]: *** [RPM] Error 1
16:17:12 make[2]: Leaving directory 
`/w/workspace/vpp-verify-master-centos7/extras/rpm'
16:17:12 make[1]: *** [pkg-rpm] Error 2
16:17:12 make[1]: Leaving directory `/w/workspace/vpp-verify-master-centos7'
16:17:12 make: *** [verify] Error 2
16:17:12 Build step 'Execute shell' marked build as failure


-Original Message-
From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Vratko 
Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io
Sent: Tuesday, May 7, 2019 4:21 PM
To: Ed Kern (ejk) ; Klement Sekera -X (ksekera - PANTHEON 
TECHNOLOGIES at Cisco) 
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] false verified + 1 for gerrit jobs


reduce the number of retries (or possibly completely)

+1 for completely.

Vratko.

-Original Message-
From: vpp-dev@lists.fd.io  On Behalf Of Ed Kern via 
Lists.Fd.Io
Sent: Tuesday, 2019-May-07 00:34
To: Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) 

Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] false verified + 1 for gerrit jobs

This is a known issue with how the retry mechanic interacts (badly) with gerrit 
occasionally.  This odds of this happening were a bit higher over the last
couple of days specific to centos retries.   This is tied to the JNLP changes
made to csit and how the initial connection is made.   While the change
has improved JNLP issues across the board there are a couple new nits
that ill have to debug.

At this point though I’m not going to touch/debug further until the csit 
jobs/reports are completed.

Im actually hopeful that ill be able to reduce the number of retries (or 
possibly completely) in the long run with the HAProxy bypass in place.

Ed





On May 6, 2019, at 11:18 AM, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at 
Cisco)  wrote:

Hi all,

I noticed a job getting a +1 even though some of the builds failed ...

https://gerrit.fd.io/r/#/c/18444/

please note patch set 9 

fd.io JJB
Patch Set 9: Verified-1 Build Failed
https://jenkins.fd.io/job/vpp-arm-verify-master-ubuntu1804/2459/ :
FAILURE No problems were identified. If you know why this problem
occurred, please add a suitable Cause for it. (
https://jenkins.fd.io/job/vpp-arm-verify-master-ubuntu1804/2459/ )
Logs:
https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-arm-verify-mas
ter-ubuntu1804/2459
https://jenkins.fd.io/job/vpp-beta-verify-master-ubuntu1804/6891/ :
FAILURE No problems were identified. If you know why this problem
occurred, please add a suitable Cause for it. (
https://jenkins.fd.io/job/vpp-beta-verify-master-ubuntu1804/6891/ )
Logs:
https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-beta-verify-ma
ster-ubuntu1804/6891
https://jenkins.fd.io/job/vpp-csit-verify-device-master-1n-skx/788/ :
SUCCESS (skipped) Logs:
https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-csit-verify-de
vice-master-1n-skx/788
https://jenkins.fd.io/job/vpp-make-test-docs-verify-master/13041/ :
SUCCESS Logs:
https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-make-test-docs
-verify-master/13041
https://jenkins.fd.io/job/vpp-verify-master-ubuntu1604/19027/ :
SUCCESS Logs:

[vpp-dev] centos ninja failures

2019-05-08 Thread Ed Kern via Lists.Fd.Io 
starting new thread because it really has nothing to do with previous thread…

So I am not going to write:
a.  its related to your code
b. its not the build infra


But I will say there have been good centos verify runs…

BEFORE your patches
BETWEEN various revisions of your changes
BETWEEN retries of your changes
AFTER you stopped trying to retry your changes

With multiple different patches…

So not really having anything to track on the build infra side (nor is this a 
voting issue)  Im starting
a new thread and including tom to see if he has any centos guesses on why we 
are only seeing
problems on centos.

Ed



> On May 8, 2019, at 2:46 AM, Yu, Ping  wrote:
> 
> Recently centOS build always fail and patch review is blocked even retrying 
> several times. 
> 
> 
> 16:17:11 -- Configuring done
> 16:17:12 -- Generating done
> 16:17:12 -- Build files have been written to: 
> /w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root/build-vpp-native/vpp
> 16:17:12 ninja: error: manifest 'build.ninja' still dirty after 100 tries
> 16:17:12 
> 16:17:12 make[4]: *** [Makefile:695: vpp-build] Error 1
> 16:17:12 make[4]: Leaving directory 
> '/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root'
> 16:17:12 make[3]: *** [Makefile:931: install-packages] Error 1
> 16:17:12 make[3]: Leaving directory 
> '/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root'
> 16:17:12 error: Bad exit status from /var/tmp/rpm-tmp.8TtZeQ (%build)
> 16:17:12 
> 16:17:12 
> 16:17:12 RPM build errors:
> 16:17:12 Bad exit status from /var/tmp/rpm-tmp.8TtZeQ (%build)
> 16:17:12 make[2]: *** [RPM] Error 1
> 16:17:12 make[2]: Leaving directory 
> `/w/workspace/vpp-verify-master-centos7/extras/rpm'
> 16:17:12 make[1]: *** [pkg-rpm] Error 2
> 16:17:12 make[1]: Leaving directory `/w/workspace/vpp-verify-master-centos7'
> 16:17:12 make: *** [verify] Error 2
> 16:17:12 Build step 'Execute shell' marked build as failure
> 
> 
> -Original Message-
> From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Vratko 
> Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io
> Sent: Tuesday, May 7, 2019 4:21 PM
> To: Ed Kern (ejk) ; Klement Sekera -X (ksekera - PANTHEON 
> TECHNOLOGIES at Cisco) 
> Cc: vpp-dev@lists.fd.io
> Subject: Re: [vpp-dev] false verified + 1 for gerrit jobs
> 
>> reduce the number of retries (or possibly completely)
> 
> +1 for completely.
> 
> Vratko.
> 
> -Original Message-
> From: vpp-dev@lists.fd.io  On Behalf Of Ed Kern via 
> Lists.Fd.Io
> Sent: Tuesday, 2019-May-07 00:34
> To: Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) 
> 
> Cc: vpp-dev@lists.fd.io
> Subject: Re: [vpp-dev] false verified + 1 for gerrit jobs
> 
> This is a known issue with how the retry mechanic interacts (badly) with 
> gerrit occasionally.  This odds of this happening were a bit higher over the 
> last
> couple of days specific to centos retries.   This is tied to the JNLP changes
> made to csit and how the initial connection is made.   While the change
> has improved JNLP issues across the board there are a couple new nits
> that ill have to debug.
> 
> At this point though I’m not going to touch/debug further until the csit 
> jobs/reports are completed.
> 
> Im actually hopeful that ill be able to reduce the number of retries (or 
> possibly completely) in the long run with the HAProxy bypass in place.
> 
> Ed
> 
> 
> 
> 
>> On May 6, 2019, at 11:18 AM, Klement Sekera -X (ksekera - PANTHEON 
>> TECHNOLOGIES at Cisco)  wrote:
>> 
>> Hi all,
>> 
>> I noticed a job getting a +1 even though some of the builds failed ...
>> 
>> https://gerrit.fd.io/r/#/c/18444/
>> 
>> please note patch set 9 
>> 
>> fd.io JJB
>> Patch Set 9: Verified-1 Build Failed
>> https://jenkins.fd.io/job/vpp-arm-verify-master-ubuntu1804/2459/ :
>> FAILURE No problems were identified. If you know why this problem 
>> occurred, please add a suitable Cause for it. ( 
>> https://jenkins.fd.io/job/vpp-arm-verify-master-ubuntu1804/2459/ )
>> Logs:
>> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-arm-verify-mas
>> ter-ubuntu1804/2459
>> https://jenkins.fd.io/job/vpp-beta-verify-master-ubuntu1804/6891/ :
>> FAILURE No problems were identified. If you know why this problem 
>> occurred, please add a suitable Cause for it. ( 
>> https://jenkins.fd.io/job/vpp-beta-verify-master-ubuntu1804/6891/ )
>> Logs:
>> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-beta-verify-ma
>> ster-ubuntu1804/6891
>> https://jenkins.fd.io/job/vpp-csit-verify-device-master-1n-skx/788/ :
>> SUCCESS (skipped) Logs:
>> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-csit-verify-de
>> vice-master-1n-skx/788
>> https://jenkins.fd.io/job/vpp-make-test-docs-verify-master/13041/ :
>> SUCCESS Logs:
>> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-make-test-docs
>> -verify-master/13041
>>

Re: [vpp-dev] Weird Error Number

2019-05-08 Thread Ole Troan 
Hi Jon,

> So I was reading src/vnet/api_errno.h, as you do, and I noticed
> this weird line:
> 
> _(IN_PROGRESS, 10, "Operation in progress") \
> 
> That's right, an error number that is positive.  It just doesn't sound 
> right...
> And I don't think it is simply missing a negative sign as there is also this 
> line:
> 
> _(INVALID_SW_IF_INDEX_2, -10, "Invalid sw_if_index #2") \
> 
> So, digging some:
> 
> jdl $ git grep VNET_API_ERROR_IN_PROGRESS
> src/plugins/nat/nat_ha.c:return VNET_API_ERROR_IN_PROGRESS;
> 
> Which is here:
> 
> int
> nat44_ha_resync (u32 client_index, u32 pid,
>  nat_ha_resync_event_cb_t event_callback)
> {
>   nat_ha_main_t *ha = _ha_main;
>   snat_main_t *sm = _main;
>   snat_session_t *ses;
>   snat_main_per_thread_data_t *tsm;
> 
>   if (ha->in_resync)
> return VNET_API_ERROR_IN_PROGRESS;
> 
> But then this too:
> 
> jdl $ git grep nat44_ha_resync
> src/plugins/nat/nat_ha.c:nat44_ha_resync (u32 client_index, u32 pid,
> 
> So it appears that it may not even be being used...?
> 
> Can anyone shed some light here?

I guess the purpose of a positive value is to indicate that you can try again 
with the same arguments and get a different response,
as opposed to a negative value.

I would be in favour of removing that error from api_errno.h.
Especially for these corner cases I'd much rather want a documented separate 
error number space for the module / message.

Best regards,
Ole





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12955): https://lists.fd.io/g/vpp-dev/message/12955
Mute This Topic: https://lists.fd.io/mt/31521527/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] false verified + 1 for gerrit jobs

2019-05-08 Thread Yu, Ping 
Recently centOS build always fail and patch review is blocked even retrying 
several times. 


16:17:11 -- Configuring done
16:17:12 -- Generating done
16:17:12 -- Build files have been written to: 
/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root/build-vpp-native/vpp
16:17:12 ninja: error: manifest 'build.ninja' still dirty after 100 tries
16:17:12 
16:17:12 make[4]: *** [Makefile:695: vpp-build] Error 1
16:17:12 make[4]: Leaving directory 
'/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root'
16:17:12 make[3]: *** [Makefile:931: install-packages] Error 1
16:17:12 make[3]: Leaving directory 
'/w/workspace/vpp-verify-master-centos7/build-root/rpmbuild/vpp-19.08/build-root'
16:17:12 error: Bad exit status from /var/tmp/rpm-tmp.8TtZeQ (%build)
16:17:12 
16:17:12 
16:17:12 RPM build errors:
16:17:12 Bad exit status from /var/tmp/rpm-tmp.8TtZeQ (%build)
16:17:12 make[2]: *** [RPM] Error 1
16:17:12 make[2]: Leaving directory 
`/w/workspace/vpp-verify-master-centos7/extras/rpm'
16:17:12 make[1]: *** [pkg-rpm] Error 2
16:17:12 make[1]: Leaving directory `/w/workspace/vpp-verify-master-centos7'
16:17:12 make: *** [verify] Error 2
16:17:12 Build step 'Execute shell' marked build as failure


-Original Message-
From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Vratko 
Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io
Sent: Tuesday, May 7, 2019 4:21 PM
To: Ed Kern (ejk) ; Klement Sekera -X (ksekera - PANTHEON 
TECHNOLOGIES at Cisco) 
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] false verified + 1 for gerrit jobs

> reduce the number of retries (or possibly completely)

+1 for completely.

Vratko.

-Original Message-
From: vpp-dev@lists.fd.io  On Behalf Of Ed Kern via 
Lists.Fd.Io
Sent: Tuesday, 2019-May-07 00:34
To: Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) 

Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] false verified + 1 for gerrit jobs

This is a known issue with how the retry mechanic interacts (badly) with gerrit 
occasionally.  This odds of this happening were a bit higher over the last
couple of days specific to centos retries.   This is tied to the JNLP changes
made to csit and how the initial connection is made.   While the change
has improved JNLP issues across the board there are a couple new nits
that ill have to debug.

At this point though I’m not going to touch/debug further until the csit 
jobs/reports are completed.

Im actually hopeful that ill be able to reduce the number of retries (or 
possibly completely) in the long run with the HAProxy bypass in place.

Ed




> On May 6, 2019, at 11:18 AM, Klement Sekera -X (ksekera - PANTHEON 
> TECHNOLOGIES at Cisco)  wrote:
> 
> Hi all,
> 
> I noticed a job getting a +1 even though some of the builds failed ...
> 
> https://gerrit.fd.io/r/#/c/18444/
> 
> please note patch set 9 
> 
> fd.io JJB
> Patch Set 9: Verified-1 Build Failed
> https://jenkins.fd.io/job/vpp-arm-verify-master-ubuntu1804/2459/ :
> FAILURE No problems were identified. If you know why this problem 
> occurred, please add a suitable Cause for it. ( 
> https://jenkins.fd.io/job/vpp-arm-verify-master-ubuntu1804/2459/ )
> Logs:
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-arm-verify-mas
> ter-ubuntu1804/2459
> https://jenkins.fd.io/job/vpp-beta-verify-master-ubuntu1804/6891/ :
> FAILURE No problems were identified. If you know why this problem 
> occurred, please add a suitable Cause for it. ( 
> https://jenkins.fd.io/job/vpp-beta-verify-master-ubuntu1804/6891/ )
> Logs:
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-beta-verify-ma
> ster-ubuntu1804/6891
> https://jenkins.fd.io/job/vpp-csit-verify-device-master-1n-skx/788/ :
> SUCCESS (skipped) Logs:
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-csit-verify-de
> vice-master-1n-skx/788
> https://jenkins.fd.io/job/vpp-make-test-docs-verify-master/13041/ :
> SUCCESS Logs:
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-make-test-docs
> -verify-master/13041
> https://jenkins.fd.io/job/vpp-verify-master-ubuntu1604/19027/ :
> SUCCESS Logs:
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-verify-master-
> ubuntu1604/19027
> https://jenkins.fd.io/job/vpp-verify-master-clang/6731/ : SUCCESS
> Logs:
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-verify-master-
> clang/6731 https://jenkins.fd.io/job/vpp-docs-verify-master/15343/ : 
> SUCCESS
> Logs:
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-docs-verify-ma
> ster/15343 https://jenkins.fd.io/job/vpp-verify-master-centos7/18764/
> : NOT_BUILT
> Logs:
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-verify-master-
> centos7/18764
> 7:11 PM
> fd.io JJB
> Patch Set 9: Verified+1 Build Successful 
> https://jenkins.fd.io/job/vpp-verify-master-centos7/18764/ : SUCCESS
> Logs:
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-verify-master-
> centos7/18764
> 7:15 PM
> 
>

Re: [vpp-dev] [csit-dev] how to know data type mapping between *.api.json with PYTHON API ?

2019-05-08 Thread Ole Troan 
Hi again,

> Thanks for you kindly help.  Now I know the data type mapping, and I have 
> another question,
> When I pass parameters to a python api, the api excuted successfully,  no 
> error reported,  but the final result is not what I want to get, 
> So I want to debug to know where the issue existed,  Does python api have 
> debug mode to step in an python api internal to know the parameter
> that pass to the api is valid ?

You can enable logging in the Python mode that gives quite a bit of 
information. Feel free to add to that btw.
There is also API tracing on the VPP side you can enable. And of course you can 
run both the Python side and the VPP side in debuggers.

But yes, any suggestions for how debuggability of developing new API messages 
are welcome.

Cheers,
Ole

> -Original Message-
> From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Ole Troan
> Sent: Tuesday, May 7, 2019 3:20 PM
> To: Pei, Yulong 
> Cc: vpp-dev@lists.fd.io; csit-...@lists.fd.io; Ni, Hongjun 
> ; Liu, Yu Y ; Kinsella, Ray 
> 
> Subject: Re: [vpp-dev] [csit-dev] how to know data type mapping between 
> *.api.json with PYTHON API ?
> 
> Hi Yulong,
> 
> Good question. That has been on my list of things to document for a while.
> Does 
> https://gerrit.fd.io/r/#/c/19389/
> 
> answer your question?
> Please suggest improvements and improve the text as you notice gaps.
> 
> Best regards,
> Ole
> 
> 
>> On 7 May 2019, at 07:49, Pei, Yulong  wrote:
>> 
>> Hello vpp-dev & csit-dev,
>> 
>> I  have a question about how to know data type mapping between  *.api.json 
>> with PYTHON API ?
>> 
>> Let me use “./src/vnet/ip/ip.api” as example,  as I know,   vppapigen will 
>> autogenerate  “ip.api.json” from “ip.api”
>> 
>> And then vpp_papi can autogenerate  its python api from “ip.api.json”, is 
>> there any way to know data type mapping between  *.api.json with PYTHON API ?
>> 
>> For example:
>> 
>> In “./src/vnet/ip/ip.api”,
>> 
>> define ip6_fib_details
>> {
>>  u32 context;
>>  u32 table_id;
>>  u8  table_name[64];
>>  u8  address_length;
>>  u8  address[16];
>>  u32 count;
>>  u32 stats_index;
>>  vl_api_fib_path_t path[count];
>> };
>> 
>> Then in   “ip.api.json”, I  got,
>> 
>>[
>>"ip6_fib_details",
>>[
>>"u16",
>>"_vl_msg_id"
>>],
>>[
>>"u32",
>>"context"
>>],
>>[
>>"u32",
>>"table_id"
>>],
>>[
>>"u8",
>>"table_name",
>>64
>>],
>>[
>>"u8",
>>"address_length"
>>],
>>[
>>"u8",
>>"address",
>>16
>>],
>>[
>>"u32",
>>"count"
>>],
>>[
>>"u32",
>>"stats_index"
>>],
>>[
>>"vl_api_fib_path_t",
>>"path",
>>0,
>>"count"
>>],
>>{
>>"crc": "0xef11e94d"
>>}
>>],
>> 
>> My question is that which kind of python data type can be used to map below 
>> json types ?
>>[
>>"u8",
>>"table_name",
>>64
>>],
>> 
>>[
>>"u8",
>>"address",
>>16
>>],
>> 
>>[
>>"vl_api_fib_path_t",
>>"path",
>>0,
>>"count"
>>],
>> 
>> Best Regards
>> Yulong Pei
>> 
>> 
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> 
>> View/Reply Online (#3484): https://lists.fd.io/g/csit-dev/message/3484
>> Mute This Topic: https://lists.fd.io/mt/31529209/675193
>> Group Owner: csit-dev+ow...@lists.fd.io
>> Unsubscribe: https://lists.fd.io/g/csit-dev/unsub  [otr...@employees.org]
>> -=-=-=-=-=-=-=-=-=-=-=-
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12953): https://lists.fd.io/g/vpp-dev/message/12953
Mute This Topic: https://lists.fd.io/mt/31529576/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] [csit-dev] how to know data type mapping between *.api.json with PYTHON API ?

2019-05-08 Thread Pei, Yulong 
Hi Ole,

Thanks for you kindly help.  Now I know the data type mapping, and I have 
another question,
When I pass parameters to a python api, the api excuted successfully,  no error 
reported,  but the final result is not what I want to get, 
So I want to debug to know where the issue existed,  Does python api have debug 
mode to step in an python api internal to know the parameter
that pass to the api is valid ?

Best Regards
Yulong Pei

-Original Message-
From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Ole Troan
Sent: Tuesday, May 7, 2019 3:20 PM
To: Pei, Yulong 
Cc: vpp-dev@lists.fd.io; csit-...@lists.fd.io; Ni, Hongjun 
; Liu, Yu Y ; Kinsella, Ray 

Subject: Re: [vpp-dev] [csit-dev] how to know data type mapping between 
*.api.json with PYTHON API ?

Hi Yulong,

Good question. That has been on my list of things to document for a while.
Does 
https://gerrit.fd.io/r/#/c/19389/

answer your question?
Please suggest improvements and improve the text as you notice gaps.

Best regards,
Ole


> On 7 May 2019, at 07:49, Pei, Yulong  wrote:
> 
> Hello vpp-dev & csit-dev,
>  
> I  have a question about how to know data type mapping between  *.api.json 
> with PYTHON API ?
>  
> Let me use “./src/vnet/ip/ip.api” as example,  as I know,   vppapigen will 
> autogenerate  “ip.api.json” from “ip.api”
>  
> And then vpp_papi can autogenerate  its python api from “ip.api.json”, is 
> there any way to know data type mapping between  *.api.json with PYTHON API ?
>  
> For example:
>  
> In “./src/vnet/ip/ip.api”,
>  
> define ip6_fib_details
> {
>   u32 context;
>   u32 table_id;
>   u8  table_name[64];
>   u8  address_length;
>   u8  address[16];
>   u32 count;
>   u32 stats_index;
>   vl_api_fib_path_t path[count];
> };
>  
> Then in   “ip.api.json”, I  got,
>  
> [
> "ip6_fib_details",
> [
> "u16",
> "_vl_msg_id"
> ],
> [
> "u32",
> "context"
> ],
> [
> "u32",
> "table_id"
> ],
> [
> "u8",
> "table_name",
> 64
> ],
> [
> "u8",
> "address_length"
> ],
> [
> "u8",
> "address",
> 16
> ],
> [
> "u32",
> "count"
> ],
> [
> "u32",
> "stats_index"
> ],
> [
> "vl_api_fib_path_t",
> "path",
> 0,
> "count"
> ],
> {
> "crc": "0xef11e94d"
> }
> ],
>  
> My question is that which kind of python data type can be used to map below 
> json types ?
> [
> "u8",
> "table_name",
> 64
> ],
>  
> [
> "u8",
> "address",
> 16
> ],
>  
> [
> "vl_api_fib_path_t",
> "path",
> 0,
> "count"
> ],
>  
> Best Regards
> Yulong Pei
>  
>  
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#3484): https://lists.fd.io/g/csit-dev/message/3484
> Mute This Topic: https://lists.fd.io/mt/31529209/675193
> Group Owner: csit-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/csit-dev/unsub  [otr...@employees.org]
> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12952): https://lists.fd.io/g/vpp-dev/message/12952
Mute This Topic: https://lists.fd.io/mt/31529576/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-