[vpp-dev] make: yamllint: Command not found

[Pei, Yulong]

Hello vpp-dev & csit-dev,


https://jenkins.fd.io/job/vpp-checkstyle-verify-master/12407/console

16:56:10 ***
16:56:10 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED
16:56:10 ***
16:56:10 yamllint /w/workspace/vpp-checkstyle-verify-master/src
16:56:10 make: yamllint: Command not found
16:56:10 Makefile:561: recipe for target 'checkstyle' failed
16:56:10 make: *** [checkstyle] Error 127
16:56:10 Build step 'Execute shell' marked build as failure

It seems that the server that scheduled by Jenkins lack the command `yamllint`  
that caused  vpp checkstyle failure,
Who can help install `yamllint` on the servers to fix the issue ?

Best Regards
Yulong Pei

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14592): https://lists.fd.io/g/vpp-dev/message/14592
Mute This Topic: https://lists.fd.io/mt/57093164/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

[Satya Murthy]

Thanks a lot Dave for offering the help.

The change would be of great help for us.
Please let us know, once you have a patch, so that we can selectively take that 
patch and import.

--
Thanks & Regards,
Murthy
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14591): https://lists.fd.io/g/vpp-dev/message/14591
Mute This Topic: https://lists.fd.io/mt/55586364/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

[Paul Vinciguerra]

How do people feel about managing the CI where possible via the Makefile by
testing for JENKINS_URL?

On Wed, Nov 13, 2019 at 10:11 AM Dave Wallace  wrote:

> Status update:
>
> Florin fixed 'make checkstyle' with [1]  (Thanks Florin! :)
>
> Ed Kern has added 'make install-dep' to the checkstyle verify build
> executors.
>
> The revert of my ci-management patch [2] will be abandoned.
>
> Florin's patch will be reverted once the new build executors are available
> and verified that yamllint is available.
>
> Sorry for the bog-up.
>
> Thanks,
> -daw-
>
> [1] https://gerrit.fd.io/r/c/vpp/+/23391
> [2] https://gerrit.fd.io/r/c/ci-management/+/23410
>
> On 11/13/2019 8:58 AM, Dave Wallace via Lists.Fd.Io wrote:
>
> Dave,
>
> My bad.  I had Vanessa merge a patch to ci-management [0] which I tested
> locally, but forgot that the build executors don't run 'make install-dep'.
>
> Unfortunately the ci-management verify jobs don't actually run any of the
> CI jobs to ensure that the system still works with the patch being
> submitted...
>
> I'm in the process of reverting the patch until the build executors can be
> upgraded.
>
> Thanks,
> -daw-
> [0] https://gerrit.fd.io/r/c/ci-management/+/23364
>
> On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io wrote:
>
> I wonder where “yamllint” went? Multiple patches affected...
>
>
>
> 07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
>
> 07:28:24 HEAD detached at dce8b380a
>
> 07:28:24 nothing to commit, working tree clean
>
> 07:28:24
> ***
>
> 07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED
>
> 07:28:24
> ***
>
> 07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src
>
> 07:28:24 make: yamllint: Command not found
>
> 07:28:24 Makefile:561: recipe for target 'checkstyle' failed
>
> 07:28:24 make: *** [checkstyle] Error 127
>
> 07:28:24 Build step 'Execute shell' marked build as failure
>
>
>
> FWIW... Dave
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#14579): https://lists.fd.io/g/vpp-dev/message/14579
> Mute This Topic: https://lists.fd.io/mt/55791974/675079
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dwallac...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583
> Mute This Topic: https://lists.fd.io/mt/55791974/675079
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dwallac...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#14589): https://lists.fd.io/g/vpp-dev/message/14589
> Mute This Topic: https://lists.fd.io/mt/55791974/1594641
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [
> pvi...@vinciconsulting.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14590): https://lists.fd.io/g/vpp-dev/message/14590
Mute This Topic: https://lists.fd.io/mt/55791974/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

[Dave Wallace]

Status update:

Florin fixed 'make checkstyle' with [1]  (Thanks Florin! :)

Ed Kern has added 'make install-dep' to the checkstyle verify build 
executors.


The revert of my ci-management patch [2] will be abandoned.

Florin's patch will be reverted once the new build executors are 
available and verified that yamllint is available.


Sorry for the bog-up.

Thanks,
-daw-

[1] https://gerrit.fd.io/r/c/vpp/+/23391
[2] https://gerrit.fd.io/r/c/ci-management/+/23410

On 11/13/2019 8:58 AM, Dave Wallace via Lists.Fd.Io wrote:

Dave,

My bad.  I had Vanessa merge a patch to ci-management [0] which I 
tested locally, but forgot that the build executors don't run 'make 
install-dep'.


Unfortunately the ci-management verify jobs don't actually run any of 
the CI jobs to ensure that the system still works with the patch being 
submitted...


I'm in the process of reverting the patch until the build executors 
can be upgraded.


Thanks,
-daw-
[0] https://gerrit.fd.io/r/c/ci-management/+/23364

On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io wrote:


I wonder where “yamllint” went? Multiple patches affected...

07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)

07:28:24 HEAD detached at dce8b380a

07:28:24 nothing to commit, working tree clean

07:28:24 
***


07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED

07:28:24 
***


07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src

07:28:24 make: yamllint: Command not found

07:28:24 Makefile:561: recipe for target 'checkstyle' failed

07:28:24 make: *** [checkstyle] Error 127

07:28:24 Build step 'Execute shell' marked build as failure

FWIW... Dave


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14579):https://lists.fd.io/g/vpp-dev/message/14579
Mute This Topic:https://lists.fd.io/mt/55791974/675079
Group Owner:vpp-dev+ow...@lists.fd.io
Unsubscribe:https://lists.fd.io/g/vpp-dev/unsub   [dwallac...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583
Mute This Topic: https://lists.fd.io/mt/55791974/675079
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dwallac...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14589): https://lists.fd.io/g/vpp-dev/message/14589
Mute This Topic: https://lists.fd.io/mt/55791974/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

[Dave Barach via Lists.Fd.Io]

If you use an rx pthread to tickle your main thread [via eventfd if you like] – 
and to do nothing else – I don’t see why you’d need to lock anything.

We’d want to make a couple of very simple changes to 
.../src/vlibmemory/memory_client.c so folks can use any rx pthread function 
they like, instead of the default function.

If you’re interested, I can make those changes.

FWIW... Dave

From: vpp-dev@lists.fd.io  On Behalf Of Satya Murthy
Sent: Wednesday, November 13, 2019 8:43 AM
To: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

Thanks Dave for the quick reply.

Main problem we are seeing with having RX thread is:

1) Our application sends VPP-API-request in main thread and stores the Request 
and context information in a list
2) If the response comes in the RX thread, we need to access the context 
information list in this thread which may force us to have locks across these 
data structures to clear contention between main and RX thread.
We are worried abt performance degradation in control plane due to these locks 
when we have thousands of FIB entries ( in the order of 50K ).

--
Thanks & Regards,
Murthy
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14588): https://lists.fd.io/g/vpp-dev/message/14588
Mute This Topic: https://lists.fd.io/mt/55586364/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Two potential bugs in nat/out2in

[Raj]

Hello All,

I want to share two observations I had while chasing a crash in VPP.

To the best of my knowledge, this is what happens in
src/plugins/nat/nat_det_out2in.c:icmp_match_out2in_det()
- First it will lookup the destination addr and get the snat_det_map if found.
- If no mapping found, check whether that destination address is an
Interface addr
- if not:
   nat_log_info ("unknown dst address:  %U",
format_ip4_address, >dst_address);
  goto out;

In this case we are not setting the 'dont_translate' flag to true. Is
there any specific reason for not doing so? Could this be a bug?


In src/plugins/nat/out2in.c:icmp_out2in ()

Here 'snat_session_key_t sm0' is not initialized before it is used.

Since 'snat_session_key_t sm0' is not initialized and dont_translate
flag is false in the icmp_match_out2in_det() callback function,
address, port, protocol and fib_index will be set to uninitialized
values, which could be garbage.

This leads to packets being routed to unexpected locations, if
fib_index happens to be a  valid value and vpp crashes
(assert(pool_elt_at_index(ip4_main.v4_fibs, index)) while trying to
fetch the pool with the garbage fib_index.

Is leaving snat_session_key_t sm0 uninitialized intentional, or should
it be initialized?

Thanks and Regards,

Raj
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14587): https://lists.fd.io/g/vpp-dev/message/14587
Mute This Topic: https://lists.fd.io/mt/55922440/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Coverity run FAILED as of 2019-11-13 14:07:31 UTC

[Noreply Jenkins]

Coverity run failed today.

Current number of outstanding issues are 5
Newly detected: 0
Eliminated: 0
More details can be found at  
https://scan.coverity.com/projects/fd-io-vpp/view_defects
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14586): https://lists.fd.io/g/vpp-dev/message/14586
Mute This Topic: https://lists.fd.io/mt/55882478/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

[Satya Murthy]

Thanks Ole for the response.
We will weigh between performance of "unix domain sockets" vs "lock contention 
with rx thread" approached and go accordingly.

--
Thanks & Regards,
Murthy
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14585): https://lists.fd.io/g/vpp-dev/message/14585
Mute This Topic: https://lists.fd.io/mt/55586364/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

[Paul Vinciguerra]

Can you leave it?  The change in the makefile was backed out.
Can we work on automating new containers when the makefile is updated?

On Wed, Nov 13, 2019 at 8:58 AM Dave Wallace  wrote:

> Dave,
>
> My bad.  I had Vanessa merge a patch to ci-management [0] which I tested
> locally, but forgot that the build executors don't run 'make install-dep'.
>
> Unfortunately the ci-management verify jobs don't actually run any of the
> CI jobs to ensure that the system still works with the patch being
> submitted...
>
> I'm in the process of reverting the patch until the build executors can be
> upgraded.
>
> Thanks,
> -daw-
> [0] https://gerrit.fd.io/r/c/ci-management/+/23364
>
> On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io wrote:
>
> I wonder where “yamllint” went? Multiple patches affected...
>
>
>
> 07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
>
> 07:28:24 HEAD detached at dce8b380a
>
> 07:28:24 nothing to commit, working tree clean
>
> 07:28:24
> ***
>
> 07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED
>
> 07:28:24
> ***
>
> 07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src
>
> 07:28:24 make: yamllint: Command not found
>
> 07:28:24 Makefile:561: recipe for target 'checkstyle' failed
>
> 07:28:24 make: *** [checkstyle] Error 127
>
> 07:28:24 Build step 'Execute shell' marked build as failure
>
>
>
> FWIW... Dave
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#14579): https://lists.fd.io/g/vpp-dev/message/14579
> Mute This Topic: https://lists.fd.io/mt/55791974/675079
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dwallac...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583
> Mute This Topic: https://lists.fd.io/mt/55791974/1594641
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [
> pvi...@vinciconsulting.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14584): https://lists.fd.io/g/vpp-dev/message/14584
Mute This Topic: https://lists.fd.io/mt/55791974/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

[Dave Wallace]

Dave,

My bad.  I had Vanessa merge a patch to ci-management [0] which I tested 
locally, but forgot that the build executors don't run 'make install-dep'.


Unfortunately the ci-management verify jobs don't actually run any of 
the CI jobs to ensure that the system still works with the patch being 
submitted...


I'm in the process of reverting the patch until the build executors can 
be upgraded.


Thanks,
-daw-
[0] https://gerrit.fd.io/r/c/ci-management/+/23364

On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io wrote:


I wonder where “yamllint” went? Multiple patches affected...

07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)

07:28:24 HEAD detached at dce8b380a

07:28:24 nothing to commit, working tree clean

07:28:24 
***


07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED

07:28:24 
***


07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src

07:28:24 make: yamllint: Command not found

07:28:24 Makefile:561: recipe for target 'checkstyle' failed

07:28:24 make: *** [checkstyle] Error 127

07:28:24 Build step 'Execute shell' marked build as failure

FWIW... Dave


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14579): https://lists.fd.io/g/vpp-dev/message/14579
Mute This Topic: https://lists.fd.io/mt/55791974/675079
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dwallac...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583
Mute This Topic: https://lists.fd.io/mt/55791974/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

[Ole Troan]

Satya,

> Main problem we are seeing with having RX thread is:
> 
> 1) Our application sends VPP-API-request in main thread and stores the 
> Request and context information in a list
> 2) If the response comes in the RX thread, we need to access the context 
> information list in this thread which may force us to have locks across these 
> data structures to clear contention between main and RX thread.
> We are worried abt performance degradation in control plane due to these 
> locks when we have thousands of FIB entries ( in the order of 50K ).

You could of course use the Unix domain socket instead of shared memory for API 
transport.
The performace characteristics of that is of course different.

Best regards,
Ole-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14582): https://lists.fd.io/g/vpp-dev/message/14582
Mute This Topic: https://lists.fd.io/mt/55586364/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

[Satya Murthy]

Thanks Dave for the quick reply.

Main problem we are seeing with having RX thread is:

1) Our application sends VPP-API-request in main thread and stores the Request 
and context information in a list
2) If the response comes in the RX thread, we need to access the context 
information list in this thread which may force us to have locks across these 
data structures to clear contention between main and RX thread.
We are worried abt performance degradation in control plane due to these locks 
when we have thousands of FIB entries ( in the order of 50K ).

--
Thanks & Regards,
Murthy
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14581): https://lists.fd.io/g/vpp-dev/message/14581
Mute This Topic: https://lists.fd.io/mt/55586364/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

[Dave Barach via Lists.Fd.Io]

Wouldn’t be hard given that all of the relevant mechanisms are present in the 
underlying svm_queue code.

The question becomes one of performance. Mutex/condvar signaling is 
lightweight, and the vpp graph dispatcher is perfectly set up to poll vpp’s 
main input queue.

What’s the argument against creating an rx pthread in the usual way? You could, 
for example, use it to pop an eventfd local to your application...

D.

From: vpp-dev@lists.fd.io  On Behalf Of Satya Murthy
Sent: Wednesday, November 13, 2019 4:31 AM
To: vpp-dev@lists.fd.io
Subject: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

Hi,

We are trying to come up with VPP-API-CLIENT module that has no special RX 
thread.
As we dont have no RX thread, we are planning to read messages from shared 
memory from our main dispatcher.
To do this, we want to poll on an FD to check if any message arrived in the SHM 
queue.
I was looking for some eventfd over this shared memory which indicates a 
message arrival. However, I dont see an eventfd getting flagged by VPP.
This will make the client purely asynchronous without RX thread.

I see some eventfd code in src/vnet/session/* code. But this does not seems to 
be used by general VPP API server code.
Any inputs on how to achieve this pls ?

--
Thanks & Regards,
Murthy
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14580): https://lists.fd.io/g/vpp-dev/message/14580
Mute This Topic: https://lists.fd.io/mt/55586364/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Multiple patch validation failures: yamllint AWOL

[Dave Barach via Lists.Fd.Io]

I wonder where "yamllint" went? Multiple patches affected...

07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
07:28:24 HEAD detached at dce8b380a
07:28:24 nothing to commit, working tree clean
07:28:24 ***
07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED
07:28:24 ***
07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src
07:28:24 make: yamllint: Command not found
07:28:24 Makefile:561: recipe for target 'checkstyle' failed
07:28:24 make: *** [checkstyle] Error 127
07:28:24 Build step 'Execute shell' marked build as failure

FWIW... Dave
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14579): https://lists.fd.io/g/vpp-dev/message/14579
Mute This Topic: https://lists.fd.io/mt/55791974/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] TAP interface rx strange behavior #vpp

[Dimitar Ivanov]

Thank You.

Now mactime node is visited in both cases - before and after set bridge-domain.

W/o bridge-domain:
root@ucpe-vpp:~# vppctl show trace
--- Start of thread 0 vpp_main ---
Packet 1

00:03:50:074475: virtio-input
  virtio: hw_if_index 16 next-index 7 vring 0 len 42
hdr: flags 0x00 gso_type 0x00 hdr_len 0 gso_size 0 csum_start 0
csum_offset 0 num_buffers 1
00:03:50:075224: mactime
  MACTIME: src mac be:d8:8a:f6:b8:c5 device mac-be:d8:8a:f6:b8:c5 result pass

00:03:50:075230: ethernet-input
  ARP: be:d8:8a:f6:b8:c5 -> ff:ff:ff:ff:ff:ff
00:03:50:075237: arp-input
  request, type ethernet/IP4, address size 6/4
  be:d8:8a:f6:b8:c5/12.12.12.1 -> 00:00:00:00:00:00/12.12.12.2
00:03:50:075243: arp-disabled
  request, type ethernet/IP4, address size 6/4
  be:d8:8a:f6:b8:c5/12.12.12.1 -> 00:00:00:00:00:00/12.12.12.2
00:03:50:075244: error-drop
  rx:tap0
00:03:50:075247: drop
  arp-disabled: ARP Disabled on this interface

With bridge-domain:
root@ucpe-vpp:~# vppctl show trace
--- Start of thread 0 vpp_main ---
Packet 1

00:06:12:831357: virtio-input
  virtio: hw_if_index 16 next-index 7 vring 0 len 42
hdr: flags 0x00 gso_type 0x00 hdr_len 0 gso_size 0 csum_start 0
csum_offset 0 num_buffers 1
00:06:12:832003: mactime
  MACTIME: src mac be:d8:8a:f6:b8:c5 device mac-be:d8:8a:f6:b8:c5 result pass

00:06:12:832008: ethernet-input
  ARP: be:d8:8a:f6:b8:c5 -> ff:ff:ff:ff:ff:ff
00:06:12:832012: l2-input
  l2-input: sw_if_index 16 dst ff:ff:ff:ff:ff:ff src be:d8:8a:f6:b8:c5
00:06:12:832014: l2-learn
  l2-learn: sw_if_index 16 dst ff:ff:ff:ff:ff:ff src be:d8:8a:f6:b8:c5
bd_index 12
00:06:12:832020: error-drop
  rx:tap0
00:06:12:832023: drop
  l2-flood: L2 replication complete


On Wed, Nov 13, 2019 at 11:15 AM Damjan Marion  wrote:
>
>
> Good finding, this may help you:
>
> https://gerrit.fd.io/r/c/vpp/+/23396
>
> —
> Damjan
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14578): https://lists.fd.io/g/vpp-dev/message/14578
Mute This Topic: https://lists.fd.io/mt/54144964/21656
Mute #vpp: https://lists.fd.io/mk?hashtag=vpp=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

[Satya Murthy]

Hi,

We are trying to come up with VPP-API-CLIENT module that has no special RX 
thread.
As we dont have no RX thread, we are planning to read messages from shared 
memory from our main dispatcher.
To do this, we want to poll on an FD to check if any message arrived in the SHM 
queue.
I was looking for some eventfd over this shared memory which indicates a 
message arrival. However, I dont see an eventfd getting flagged by VPP.
This will make the client purely asynchronous without RX thread.

I see some eventfd code in src/vnet/session/* code. But this does not seems to 
be used by general VPP API server code.
Any inputs on how to achieve this pls ?

--
Thanks & Regards,
Murthy
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14577): https://lists.fd.io/g/vpp-dev/message/14577
Mute This Topic: https://lists.fd.io/mt/55586364/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] TAP interface rx strange behavior #vpp

[Damjan Marion via Lists.Fd.Io]

Good finding, this may help you:

https://gerrit.fd.io/r/c/vpp/+/23396

— 
Damjan

> On 12 Nov 2019, at 17:02, Dimitar Ivanov  wrote:
> 
> All this happen in case where tap interface is set to some bridge-domain ! If 
> i create tap interface and set mactime on it, 
> vnet_feature_start_device_input_x1 is hit and next node is correct
> 
> root@ucpe-vpp:~# vppctl show trace
> --- Start of thread 0 vpp_main ---
> Packet 1
> 
> 00:06:51:715004: virtio-input
>   virtio: hw_if_index 16 next-index 6 vring 0 len 42
> hdr: flags 0x00 gso_type 0x00 hdr_len 0 gso_size 0 csum_start 0 
> csum_offset 0 num_buffers 1
> 00:06:51:715033: mactime
>   MACTIME: src mac 3e:61:12:f3:46:9d device mac-3e:61:12:f3:46:9d result pass
> 
> 00:06:51:715039: ethernet-input
>   ARP: 3e:61:12:f3:46:9d -> ff:ff:ff:ff:ff:ff
> 00:06:51:715044: arp-input
>   request, type ethernet/IP4, address size 6/4
>   3e:61:12:f3:46:9d/12.12.12.1  -> 
> 00:00:00:00:00:00/12.12.12.2 
> 00:06:51:715049: arp-disabled
>   request, type ethernet/IP4, address size 6/4
>   3e:61:12:f3:46:9d/12.12.12.1  -> 
> 00:00:00:00:00:00/12.12.12.2 
> 00:06:51:715051: error-drop
>   rx:tap0
> 00:06:51:715054: drop
>   arp-disabled: ARP Disabled on this interface
> 
> But when assign interface to bridge-domain X,  
> vnet_feature_start_device_input_x1 still is hit but next node simply skip 
> mactime
> 
> vpp# show trace 
> --- Start of thread 0 vpp_main ---
> Packet 1
> 
> 00:09:01:266614: virtio-input
>   virtio: hw_if_index 16 next-index 4 vring 0 len 42
> hdr: flags 0x00 gso_type 0x00 hdr_len 0 gso_size 0 csum_start 0 
> csum_offset 0 num_buffers 1
> 00:09:01:266621: ethernet-input
>   ARP: 3e:61:12:f3:46:9d -> ff:ff:ff:ff:ff:ff
> 00:09:01:266624: l2-input
>   l2-input: sw_if_index 16 dst ff:ff:ff:ff:ff:ff src 3e:61:12:f3:46:9d
> 00:09:01:266626: l2-learn
>   l2-learn: sw_if_index 16 dst ff:ff:ff:ff:ff:ff src 3e:61:12:f3:46:9d 
> bd_index 12
> 00:09:01:266631: error-drop
>   rx:tap0
> 00:09:01:266635: drop
>   l2-flood: L2 replication complete
> 
> Display of features of tap0 still shows that mactime is on device-input
> 
> 
> 
> On Tue, Nov 12, 2019 at 11:31 AM Damjan Marion  > wrote:
> 
> 
> > On 12 Nov 2019, at 10:19, Dimitar Ivanov  > > wrote:
> > 
> > Sorry for missing post to vpp-dev.
> > So i'm using correct TAP interface.
> 
> yes, Looks like a bug. Somebidy will need to debug it.
> If you have time and gdb skills, try to find out if 
> vnet_feature_start_device_input_x1 in src/vnet/devices/virtio/node.c is hit…
> 
> From the trace you can see that next-index is 4.
> 
> "show node virtio-input" will likely tell you that next-index 4 is 
> ethernet-input.
> 
> vnet_feature_start_device_input_x1 i supposed to change next-index to 
> whatever next-index for mactime is…
> 
> 
> > Here is some trace with activated mactime on tap0
> > 
> > vpp# show trace
> > Limiting display to 50 packets. To display more specify max.
> > --- Start of thread 0 vpp_main ---
> > Packet 1
> > 
> > 00:02:42:141421: virtio-input
> >  virtio: hw_if_index 2 next-index 4 vring 0 len 98
> >hdr: flags 0x00 gso_type 0x00 hdr_len 0 gso_size 0 csum_start 0
> > csum_offset 0 num_buffers 1
> > 00:02:42:141425: ethernet-input
> >  IP4: 52:54:00:30:80:22 -> 74:d4:35:9d:21:ac
> > 00:02:42:141426: l2-input
> >  l2-input: sw_if_index 2 dst 74:d4:35:9d:21:ac src 52:54:00:30:80:22
> > 00:02:42:141427: l2-learn
> >  l2-learn: sw_if_index 2 dst 74:d4:35:9d:21:ac src 52:54:00:30:80:22 
> > bd_index 1
> > 00:02:42:141428: l2-fwd
> >  l2-fwd:   sw_if_index 2 dst 74:d4:35:9d:21:ac src 52:54:00:30:80:22
> > bd_index 1 result [0x10001, 1] none
> > 00:02:42:141430: l2-output
> >  l2-output: sw_if_index 1 dst 74:d4:35:9d:21:ac src 52:54:00:30:80:22
> > data 08 00 45 00 00 54 37 57 00 00 40 01
> > 00:02:42:141430: host-data0-output
> >  host-data0 l2_hdr_offset_valid l3_hdr_offset_valid
> >  IP4: 52:54:00:30:80:22 -> 74:d4:35:9d:21:ac
> >  ICMP: 10.3.72.59 -> 10.3.72.254
> >tos 0x00, ttl 64, length 84, checksum 0x9e13
> >fragment id 0x3757
> >  ICMP echo_reply checksum 0x1f49
> > 
> > Packet 2
> > 
> > 00:02:43:142927: virtio-input
> >  virtio: hw_if_index 2 next-index 4 vring 0 len 98
> >hdr: flags 0x00 gso_type 0x00 hdr_len 0 gso_size 0 csum_start 0 
> > csum_offset
> > 0 num_buffers 1
> > 00:02:43:142931: ethernet-input
> >  IP4: 52:54:00:30:80:22 -> 74:d4:35:9d:21:ac
> > 00:02:43:142932: l2-input
> >  l2-input: sw_if_index 2 dst 74:d4:35:9d:21:ac src 52:54:00:30:80:22
> > 00:02:43:142934: l2-learn
> >  l2-learn: sw_if_index 2 dst 74:d4:35:9d:21:ac src 52:54:00:30:80:22 
> > bd_index 1
> > 00:02:43:142935: l2-fwd
> >  l2-fwd:   sw_if_index 2 dst 74:d4:35:9d:21:ac src 52:54:00:30:80:22 
> > bd_index 1
> > result [0x10001, 1] none
> > 00:02:43:142936: