Re: [vpp-dev] VPP lb plugin NAT4 patch #vpp #nat #lb
Hi, Cheers! Sorry too later! I'll commit as soon as! :) I'm using lb plugin in cloud loadbalance testing! and very interesting for your plugin-cnat! KANG --Original-- From: "Nathan Skrzypczak";https://wiki.fd.io/view/DEV/Setting_up_Gerrit [1] https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Setting_up_Gerrit Ledim. 24 janv. 2021 à06:45, -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18641): https://lists.fd.io/g/vpp-dev/message/18641 Mute This Topic: https://lists.fd.io/mt/80073171/21656 Mute #vpp:https://lists.fd.io/g/vpp-dev/mutehashtag/vpp Mute #nat:https://lists.fd.io/g/vpp-dev/mutehashtag/nat Mute #lb:https://lists.fd.io/g/vpp-dev/mutehashtag/lb Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master
Ole, Auto-abandon is not auto-delete. Abandoned patches remain accessible in gerrit and the 600+ patches which would be auto-abandoned would continue to exist in virtually the same state as they do today. Viewable by all and available to anyone interested in utilizing them (i.e. restoring, rebasing, retesting). In my experience, mentally processing auto-abandon is similar to getting used to someone commenting with '-1' on a patch. It is not meant to be a rejection of one's submission, but a means of communicating that someone has suggested an improvement. If an Auto-abandon notification is viewed as a reminder to rebase one's patch and re-engage with the community committers, then it can be welcomed as a positive part of the contribution process and not a negative rejection of one's work. Thanks, -daw- On 2/1/2021 9:38 AM, otr...@employees.org wrote: Dave, To be perfectly honest, other than Andrew's proposal to tweak the auto-abandon parameters, I have not heard another solution that solves the problem of cleaning up the current queue and limiting the size of the queue in the future. Is anyone going to volunteer to manually review/abandon 600+ gerrit changes? Auto-assigning maintainers to gerrit changes is a separate issue. Please make a proposal to fix that in its own thread and I will help to get that implemented. What do you intend to happen with those 600+ abandonded changes in the future? Assuming there is gold in quite a few of them. Ole -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18640): https://lists.fd.io/g/vpp-dev/message/18640 Mute This Topic: https://lists.fd.io/mt/80169540/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master
@Ole, > What do you intend to happen with those 600+ abandonded changes in the future? Clicking in gerrit on "restore" button, if you find a gold in there ;) Peter Mikus Engineer – Software Cisco Systems Limited From: vpp-dev@lists.fd.io on behalf of Ole Troan Sent: Monday, February 1, 2021 15:38 To: Dave Wallace Cc: Paul Vinciguerra; Andrew Yourtchenko; vpp-dev Subject: Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master Dave, > To be perfectly honest, other than Andrew's proposal to tweak the > auto-abandon parameters, I have not heard another solution that solves the > problem of cleaning up the current queue and limiting the size of the queue > in the future. Is anyone going to volunteer to manually review/abandon 600+ > gerrit changes? Auto-assigning maintainers to gerrit changes is a separate > issue. Please make a proposal to fix that in its own thread and I will help > to get that implemented. What do you intend to happen with those 600+ abandonded changes in the future? Assuming there is gold in quite a few of them. Ole -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18639): https://lists.fd.io/g/vpp-dev/message/18639 Mute This Topic: https://lists.fd.io/mt/80169540/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] RFC: Enabling Gerrit Auto-Abandon job on VPP master
Dave, > To be perfectly honest, other than Andrew's proposal to tweak the > auto-abandon parameters, I have not heard another solution that solves the > problem of cleaning up the current queue and limiting the size of the queue > in the future. Is anyone going to volunteer to manually review/abandon 600+ > gerrit changes? Auto-assigning maintainers to gerrit changes is a separate > issue. Please make a proposal to fix that in its own thread and I will help > to get that implemented. What do you intend to happen with those 600+ abandonded changes in the future? Assuming there is gold in quite a few of them. Ole signature.asc Description: Message signed with OpenPGP -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18638): https://lists.fd.io/g/vpp-dev/message/18638 Mute This Topic: https://lists.fd.io/mt/80169540/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [tsc] [vpp-dev] Scapy license in VPP
On Fri, Jan 29, 2021 at 6:09 PM Vratko Polak -X (vrpolak - PANTHEON
TECHNOLOGIES at Cisco) via lists.fd.io
wrote:
> > Why do you say that vpp_papi need to be dual licensed?
>
>
>
> I think e-mail reply would be long,
>
> and I will need to address comments anyway,
>
> so I respond via a Gerrit change [1].
>
Hi Vratko
Combining Apache 2.0 and GPLv2 projects together is a difficult task
that several large projects have faced in the past and solved with
different solutions.
I did not follow the unfolding of the discussion in this list about fd.io
requirements
to end up with double licensing, so I may have limited visibility on the
long term goal.
You may have discussed this already so I may be late. Apologies for that.
I remember following the beginning of the discussion some time ago only.
Nevertheless, you are right that this is a topic for lawyer but
- some lawyers think that Apache 2.0 and GPLv2 are compatible
- some lawyers do not think that Apache 2.0 and GPLv2 are compatible
- the issue has not been tested in court
Moreover the authors of both licenses are not in agreement: the Apache
foundation
and the Free software foundation.
I'm not a lawyer but I've found myself in an intricate situation and I've
had the FSF
position very clearly stated by Eben Moglen in person.
According to FSF's viewpoint GPLv2 should contaminate the entire software
including PAPI.
LLVM for instance has not chosen that path and instead has opted to an
Apache 2.0 license
across the code they develop with the addition of exceptions to the binary
distribution.
You can find the text of the exception at the end of the file below right
after the end
of the Apache 2.0 license text.
https://releases.llvm.org/10.0.0/LICENSE.TXT
which I report below for people's convenience
LLVM Exceptions to the Apache 2.0 License
As an exception, if, as a result of your compiling your source code, portions
of this Software are embedded into an Object form of such source code, you
may redistribute such embedded portions in such Object form without complying
with the conditions of Sections 4(a), 4(b) and 4(d) of the License.
In addition, if you combine or link compiled forms of this Software with
software that is licensed under the GPLv2 ("Combined Software") and if a
court of competent jurisdiction determines that the patent provision (Section
3), the indemnity provision (Section 9) or other Section of the License
conflicts with the conditions of the GPLv2, you may retroactively and
prospectively choose to deem waived or otherwise exclude such Section(s) of
the License, but only in their entirety and only with respect to the Combined
Software.
---
Luca
>
>
> Vratko.
>
>
>
> [1] https://gerrit.fd.io/r/c/vpp/+/31025
>
>
>
> *From:* Paul Vinciguerra
> *Sent:* Friday, 2021-January-29 15:29
> *To:* Vratko Polak -X (vrpolak - PANTHEON TECH SRO at Cisco) <
> vrpo...@cisco.com>
> *Cc:* t...@lists.fd.io; Kinsella, Ray ;
> vpp-dev@lists.fd.io
> *Subject:* Re: [vpp-dev] Scapy license in VPP
>
>
>
> Why do you say that vpp_papi need to be dual licensed?
>
>
>
> On Thu, Jan 28, 2021 at 12:43 PM Vratko Polak -X (vrpolak - PANTHEON
> TECHNOLOGIES at Cisco) via lists.fd.io
> wrote:
>
> First draft created [0] for the change that will switch
>
> licenses for Python files used together with Scapy.
>
>
>
> For some files, I was not sure whether they are used together with Scapy.
>
> One big detail is that vpp_papi needs to have dual license,
>
> as test framework integrates with it (and with scapy).
>
> If I understand the licensing logic correctly,
>
> CSIT tests can still choose to use vpp_papi under Apache license option.
>
> But we may need to discuss that with lawyers.
>
>
>
> Ray, you may need to upgrade your contributor-finding shell pipeline
>
> to cover all files I added the new license into.
>
>
>
> Vratko.
>
>
>
> [0] https://gerrit.fd.io/r/c/vpp/+/30998
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18637): https://lists.fd.io/g/vpp-dev/message/18637
Mute This Topic: https://lists.fd.io/mt/80286623/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Has anyone able to run AddressSanitizer with VPP, successfully ?
Hi Murthy, I am running with ASan on a regular basis and the vpp-debug-verify-master CI job also runs it on per-commit basis, but as it is not a voting job, things tend to deteriorate slowly until I picked it up again. I'd welcome any help Can you check whether the issue is still present in VPP master? Note that you will have to revert https://gerrit.fd.io/r/c/vpp/+/30228 1st. Best Ben > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of Satya Murthy > Sent: lundi 1 février 2021 08:50 > To: vpp-dev@lists.fd.io > Subject: [vpp-dev] Has anyone able to run AddressSanitizer with VPP, > successfully ? > > Hi All, > > Has anyone able to run the AddressSanitizer with basic VPP-APIs being run > on VPP. > > As soon a VPP-API message lands onto the VPP, it is crashing with ASAN > detecting an error. > Due to this, we are not able to use ASAN for any other functional testing. > > The ASAN error is happening inside VPP infra and hence not able to get any > hints on why this would happen. > > > ==17226==ERROR: AddressSanitizer: use-after-poison on address > 0x7fffc519aa5f at pc 0x76e9d67d bp 0x7fffb70318b0 sp 0x7fffb7031058 > WRITE of size 61 at 0x7fffc519aa5f thread T0 (vpp_main) > #0 0x76e9d67c (/lib64/libasan.so.5+0x9367c) > #1 0x76b90682 in vl_socket_read_ready > /fdio.2005/src/vlibmemory/socket_api.c:240 > #2 0x73358cf6 in linux_epoll_input_inline > /fdio.2005/src/vlib/unix/input.c:322 > #3 0x7335959c in linux_epoll_input > /fdio.2005/src/vlib/unix/input.c:372 > #4 0x7326b690 in dispatch_node /fdio.2005/src/vlib/main.c:1271 > #5 0x7327073b in vlib_main_or_worker_loop > /fdio.2005/src/vlib/main.c:1958 > #6 0x732724f7 in vlib_main_loop /fdio.2005/src/vlib/main.c:2141 > #7 0x73273bdb in vlib_main /fdio.2005/src/vlib/main.c:2387 > #8 0x7335e22b in thread0 /fdio.2005/src/vlib/unix/main.c:673 > #9 0x727010b7 (/fdio.2005/build-root/install-vpp_debug- > native/vpp/lib/libvppinfra.so.20.05.1+0xc90b7) > -- > Thanks & Regards, > Murthy -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18636): https://lists.fd.io/g/vpp-dev/message/18636 Mute This Topic: https://lists.fd.io/mt/80279607/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] fix: ping: don't abort on non-keypress events
Hi folks, right now it's rather hard to use the "ping" command over e.g. govpp as it aborts immediately most of the time, usually upon receiving SOCKET_READ_EVENT. I've made a patch that makes ping stop only on UNIX_CLI_PROCESS_EVENT_READ_READY / UNIX_CLI_PROCESS_EVENT_QUIT event, so it does stop upon keypress, but not upon unrelated events: https://gerrit.fd.io/r/c/vpp/+/31035 -- Ivan Shvedunov ;; My GPG fingerprint is: 2E61 0748 8E12 BB1A 5AB9 F7D0 613E C0F8 0BC5 2807 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18635): https://lists.fd.io/g/vpp-dev/message/18635 Mute This Topic: https://lists.fd.io/mt/80282262/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [tsc] [vpp-dev] Scapy license in VPP
Vratko, > > Why do you say that vpp_papi need to be dual licensed? > > I think e-mail reply would be long, > and I will need to address comments anyway, > so I respond via a Gerrit change [1]. I didn't understand the argument made in that patch. Two points for originality regarding choice of tool for discussion. I prefer to keep it in email. The VPP Python binding (VPP PAPI) is independent of the test framework. The test framework is one of multiple uses of the Python binding. If you argument is that PAPI should accommodate its license because of one of the uses of it... that seems backwards. Best regards, Ole signature.asc Description: Message signed with OpenPGP -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18634): https://lists.fd.io/g/vpp-dev/message/18634 Mute This Topic: https://lists.fd.io/mt/80281371/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
