Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10

[Pei, Yulong]

Hi Andrew,

cherry-pick for stable/2210:   https://gerrit.fd.io/r/c/vpp/+/37413

Thanks
Yulong Pei

From: Andrew 👽 Yourtchenko 
Sent: Tuesday, October 18, 2022 1:58 PM
To: Pei, Yulong 
Cc: vpp-dev@lists.fd.io; Andrew Yourtchenko (ayourtch) ; 
Ji, Kai ; Zhang, Roy Fan ; Oginski, 
GabrielX 
Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10

Hi Yulong,

Cool, thanks! Then could you please make a cherry-pick into stable/2210 branch, 
and add me as a reviewer ? I will merge it.
--a


On 18 Oct 2022, at 03:51, Pei, Yulong 
mailto:yulong@intel.com>> wrote:

Hi Andrew,

I have been working on CSIT IPSec test for a long time, CSIT IPSec test use VPP 
python API for configuration,
“SSWAN plugin https://gerrit.fd.io/r/c/vpp/+/36552”  have no impact for CSIT 
IPSec test since it is only plugin for strongswan,  and it do not build by 
defaut when building VPP,
Also it located at vpp/extra dir,  So it is no risk for VPP 22.10.

Best Regards
Yulong Pei

From: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Andrew 
Yourtchenko
Sent: Friday, October 14, 2022 6:04 PM
To: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10

Hi Kai,

Having a second look at it - the plugin is offloading IPSec;

So I would like some of the CSIT folks/IPSec maintainers to chime in with 
confirmation that they are comfortable with this… I think I might need to 
rescind the previous “no risk” assessment.

--a



On 14 Oct 2022, at 11:50, Ji, Kai mailto:kai...@intel.com>> 
wrote:

Hi Andrew,

Thank you for the reply, I’m agree with you, the 
https://gerrit.fd.io/r/c/vpp/+/36183 is way too big and risky for stable 22.10 
now.

In this case, can I kindly to ask you consider to merge VPP SSWAN plugin 
(https://gerrit.fd.io/r/c/vpp/+/36552) for 22.10 stable ?
This patches only update the plugin and test script itself, and no dependences 
on vlibapi refactor and library fix.

Regards

Kai

From: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Andrew 
Yourtchenko
Sent: Friday, October 14, 2022 9:57 AM
To: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10

Kaj,

*release manager hat on*

we are past RC2 milestone - which means only critical fixes for CSIT tests go 
in.

if the commit was just the plugin itself, in principle might be possible to 
entertain the idea, since a separate plugin is relatively low risk.

But https://gerrit.fd.io/r/c/vpp/+/36183 is *far* too much risk to back port at 
this point in time, and is again not a fix per se. So unfortunately I will have 
to say “no” on this one.

--a




On 14 Oct 2022, at 10:43, Ji, Kai mailto:kai...@intel.com>> 
wrote:

Hello

We recently added fix plugin for vpp-sswan 
(https://gerrit.fd.io/r/c/vpp/+/36552) and I wonder if is it too late for this 
patch to be picked to stable 22.10 ?

To make things more complicate,  there is also a fix linked library patch for 
vpp-sswan https://gerrit.fd.io/r/c/vpp/+/37388 where need to be applied on top 
of vlibapi refactor (https://gerrit.fd.io/r/c/vpp/+/36183).
Otherwise,  the fix patch is no longer required if the vlibapi refactor is out 
of scope of stable 22.10.

Regards

Kai Ji
-
Intel Research and Development Ireland Ltd
Co. Reg. #308263
Collinstown Industrial Park, Leixlip,
County Kildare, Ireland









-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22047): https://lists.fd.io/g/vpp-dev/message/22047
Mute This Topic: https://lists.fd.io/mt/94322720/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10

[Andrew Yourtchenko]

Hi Yulong,

Cool, thanks! Then could you please make a cherry-pick into stable/2210 branch, 
and add me as a reviewer ? I will merge it. 

--a

> On 18 Oct 2022, at 03:51, Pei, Yulong  wrote:
> 
> 
> Hi Andrew,
>  
> I have been working on CSIT IPSec test for a long time, CSIT IPSec test use 
> VPP python API for configuration,
> “SSWAN plugin https://gerrit.fd.io/r/c/vpp/+/36552”  have no impact for CSIT 
> IPSec test since it is only plugin for strongswan,  and it do not build by 
> defaut when building VPP,
> Also it located at vpp/extra dir,  So it is no risk for VPP 22.10.
>  
> Best Regards
> Yulong Pei
>  
> From: vpp-dev@lists.fd.io  On Behalf Of Andrew 
> Yourtchenko
> Sent: Friday, October 14, 2022 6:04 PM
> To: vpp-dev@lists.fd.io
> Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10
>  
> Hi Kai,
>  
> Having a second look at it - the plugin is offloading IPSec;
>  
> So I would like some of the CSIT folks/IPSec maintainers to chime in with 
> confirmation that they are comfortable with this… I think I might need to 
> rescind the previous “no risk” assessment.
>  
> --a
> 
> 
> On 14 Oct 2022, at 11:50, Ji, Kai  wrote:
> 
> 
> Hi Andrew,
>  
> Thank you for the reply, I’m agree with you, the 
> https://gerrit.fd.io/r/c/vpp/+/36183 is way too big and risky for stable 
> 22.10 now.
>  
> In this case, can I kindly to ask you consider to merge VPP SSWAN plugin 
> (https://gerrit.fd.io/r/c/vpp/+/36552) for 22.10 stable ?
> This patches only update the plugin and test script itself, and no 
> dependences on vlibapi refactor and library fix.
>  
> Regards
>  
> Kai
>  
> From: vpp-dev@lists.fd.io  On Behalf Of Andrew 
> Yourtchenko
> Sent: Friday, October 14, 2022 9:57 AM
> To: vpp-dev@lists.fd.io
> Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10
>  
> Kaj,
>  
> *release manager hat on*
>  
> we are past RC2 milestone - which means only critical fixes for CSIT tests go 
> in.
>  
> if the commit was just the plugin itself, in principle might be possible to 
> entertain the idea, since a separate plugin is relatively low risk.
>  
> But https://gerrit.fd.io/r/c/vpp/+/36183 is *far* too much risk to back port 
> at this point in time, and is again not a fix per se. So unfortunately I will 
> have to say “no” on this one.  
>  
> --a
> 
> 
> 
> On 14 Oct 2022, at 10:43, Ji, Kai  wrote:
> 
> 
> Hello
>  
> We recently added fix plugin for vpp-sswan 
> (https://gerrit.fd.io/r/c/vpp/+/36552) and I wonder if is it too late for 
> this patch to be picked to stable 22.10 ?
>  
> To make things more complicate,  there is also a fix linked library patch for 
> vpp-sswan https://gerrit.fd.io/r/c/vpp/+/37388 where need to be applied on 
> top of vlibapi refactor (https://gerrit.fd.io/r/c/vpp/+/36183).
> Otherwise,  the fix patch is no longer required if the vlibapi refactor is 
> out of scope of stable 22.10.
>  
> Regards
>  
> Kai Ji
> -
> Intel Research and Development Ireland Ltd
> Co. Reg. #308263
> Collinstown Industrial Park, Leixlip,
> County Kildare, Ireland
>  
> 
> 
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22046): https://lists.fd.io/g/vpp-dev/message/22046
Mute This Topic: https://lists.fd.io/mt/94322720/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Move VNET features to plugins

[Neale Ranns]

Hi Dave,

I fully support pluginification 😊
Is it fair though to say that if the remaining functions of vnet have a 
dependency on one of the modules below then that module is not a good candidate 
to move to a plugin?

I thinking about the dependency between IPIP and TEIB. Some of the IPIP 
functionality (i.e. p2p tunnels) can be provided without TEIB but some cannot 
(i.e. p2mp tunnels).

  *   Any thoughts on infrastructure to ease plugin on plugin dependencies. For 
example I seem to recall a system that used a ‘registry’ that the producer 
would populate and the consumer would invoke and that invocation would be sane 
in the absence of a producer.
  *   How do we [unit] test the various combinations of loaded plugins? Perhaps 
the default is not to load any plugins and the test-case specifies which set to 
load.


/neale

From: vpp-dev@lists.fd.io  on behalf of Dave Wallace via 
lists.fd.io 
Date: Tuesday, 18 October 2022 at 08:57
To: vpp-dev 
Subject: [vpp-dev] Move VNET features to plugins
Folks,

There has been a long standing chore to move VNET features to plugins
for which I've created a Jira ticket [0] to coordinate getting this work
done for VPP 23.02 release.

Can the maintainers of the VNET features [1] please sign up for the
associated subtask in [0] and complete the work before the 23.02 RC1
milestone (01/18/2023).  It would be great to get this done before the
end of 2022 to avoid a large influx of changes in early January.

Thanks in advance for your help!
-daw-

[0] 
https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fjira.fd.io%2Fbrowse%2FVPP-2040&data=05%7C01%7Cneale%40graphiant.com%7C888ed5dcf8744e783a0708dab08a892d%7C162101cdceb34e62ab2e3abc7aeede47%7C0%7C0%7C638016406459814597%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qtN1mKiFVnGYzcW3lAsg7%2FSFLd5%2Bl8NICwMuqrG0m1M%3D&reserved=0

[1] Current set of VNET features to be moved:
 BFD
 BIER
 CRYPTO
 GRE
 IPFIX-EXPORT
 IPIP
 IPSEC
 LAWFUL-INTERCEPT
 MPLS
 OSI
 POLICER
 PPP
 QOS
 SRMPLS
 SRV6
 TEIB
 TLS
 VXLAN
 VXLAN-GPE
 DEVICES:
 AF_PACKET
 PIPE
 TAP
 VIRTIO


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22045): https://lists.fd.io/g/vpp-dev/message/22045
Mute This Topic: https://lists.fd.io/mt/94396253/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10

[Pei, Yulong]

Hi Andrew,

I have been working on CSIT IPSec test for a long time, CSIT IPSec test use VPP 
python API for configuration,
“SSWAN plugin https://gerrit.fd.io/r/c/vpp/+/36552”  have no impact for CSIT 
IPSec test since it is only plugin for strongswan,  and it do not build by 
defaut when building VPP,
Also it located at vpp/extra dir,  So it is no risk for VPP 22.10.

Best Regards
Yulong Pei

From: vpp-dev@lists.fd.io  On Behalf Of Andrew Yourtchenko
Sent: Friday, October 14, 2022 6:04 PM
To: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10

Hi Kai,

Having a second look at it - the plugin is offloading IPSec;

So I would like some of the CSIT folks/IPSec maintainers to chime in with 
confirmation that they are comfortable with this… I think I might need to 
rescind the previous “no risk” assessment.

--a


On 14 Oct 2022, at 11:50, Ji, Kai mailto:kai...@intel.com>> 
wrote:

Hi Andrew,

Thank you for the reply, I’m agree with you, the 
https://gerrit.fd.io/r/c/vpp/+/36183 is way too big and risky for stable 22.10 
now.

In this case, can I kindly to ask you consider to merge VPP SSWAN plugin 
(https://gerrit.fd.io/r/c/vpp/+/36552) for 22.10 stable ?
This patches only update the plugin and test script itself, and no dependences 
on vlibapi refactor and library fix.

Regards

Kai

From: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Andrew 
Yourtchenko
Sent: Friday, October 14, 2022 9:57 AM
To: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10

Kaj,

*release manager hat on*

we are past RC2 milestone - which means only critical fixes for CSIT tests go 
in.

if the commit was just the plugin itself, in principle might be possible to 
entertain the idea, since a separate plugin is relatively low risk.

But https://gerrit.fd.io/r/c/vpp/+/36183 is *far* too much risk to back port at 
this point in time, and is again not a fix per se. So unfortunately I will have 
to say “no” on this one.

--a



On 14 Oct 2022, at 10:43, Ji, Kai mailto:kai...@intel.com>> 
wrote:

Hello

We recently added fix plugin for vpp-sswan 
(https://gerrit.fd.io/r/c/vpp/+/36552) and I wonder if is it too late for this 
patch to be picked to stable 22.10 ?

To make things more complicate,  there is also a fix linked library patch for 
vpp-sswan https://gerrit.fd.io/r/c/vpp/+/37388 where need to be applied on top 
of vlibapi refactor (https://gerrit.fd.io/r/c/vpp/+/36183).
Otherwise,  the fix patch is no longer required if the vlibapi refactor is out 
of scope of stable 22.10.

Regards

Kai Ji
-
Intel Research and Development Ireland Ltd
Co. Reg. #308263
Collinstown Industrial Park, Leixlip,
County Kildare, Ireland







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22044): https://lists.fd.io/g/vpp-dev/message/22044
Mute This Topic: https://lists.fd.io/mt/94322720/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] pcap_write error: bad address

[aihua1980]

hi Dave：
I have been  gdb before，  vl(pm->pcap_data)    =   2,806,013,189， 
pm->n_pcap_data_written  = 0.
int  is 32 bits,size_t  is 64 bits.  n=0xA740 5D05   cast to size_t  is  0x 
 A740 5D05.
we can't use  n for   write  param.

code  fragment：

int n = vec_len (pm->pcap_data) - pm->n_pcap_data_written;

n = write (pm->file_descriptor,
vec_elt_at_index (pm->pcap_data, pm->n_pcap_data_written),
n);

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22043): https://lists.fd.io/g/vpp-dev/message/22043
Mute This Topic: https://lists.fd.io/mt/94377467/21656
Mute #pcap:https://lists.fd.io/g/vpp-dev/mutehashtag/pcap
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Move VNET features to plugins

[Dave Wallace]

Folks,

There has been a long standing chore to move VNET features to plugins 
for which I've created a Jira ticket [0] to coordinate getting this work 
done for VPP 23.02 release.


Can the maintainers of the VNET features [1] please sign up for the 
associated subtask in [0] and complete the work before the 23.02 RC1 
milestone (01/18/2023).  It would be great to get this done before the 
end of 2022 to avoid a large influx of changes in early January.


Thanks in advance for your help!
-daw-

[0] https://jira.fd.io/browse/VPP-2040

[1] Current set of VNET features to be moved:
    BFD
    BIER
    CRYPTO
    GRE
    IPFIX-EXPORT
    IPIP
    IPSEC
    LAWFUL-INTERCEPT
    MPLS
    OSI
    POLICER
    PPP
    QOS
    SRMPLS
    SRV6
    TEIB
    TLS
    VXLAN
    VXLAN-GPE
    DEVICES:
        AF_PACKET
        PIPE
        TAP
        VIRTIO



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22042): https://lists.fd.io/g/vpp-dev/message/22042
Mute This Topic: https://lists.fd.io/mt/94396253/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] pcap_write error: bad address #pcap

[Dave Barach]

Use gdb to inspect the pcap_main_t. In particular, determine 
vec_len(pm->pcap_data) [“(gdb) vl(pm->pcap_data)”] and pm->n_pcap_data_written. 
For reasonable N pcap_write(...) is known to work.

 

D. 

 

From: vpp-dev@lists.fd.io  On Behalf Of aihua1...@163.com
Sent: Sunday, October 16, 2022 11:23 PM
To: vpp-dev@lists.fd.io
Subject: [vpp-dev] pcap_write error: bad address #pcap

 

dear all:
pcap_write,use type int n;
if  n is negative。  int n = vec_len (pm->pcap_data) - 
pm->n_pcap_data_written;
write func will failed，errno = 14.
n = write (pm->file_descriptor, 

 vec_elt_at_index (pm->pcap_data, pm->n_pcap_data_written),

n); 
int   cast   to  size_t  may case  some overflow？ 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22041): https://lists.fd.io/g/vpp-dev/message/22041
Mute This Topic: https://lists.fd.io/mt/94377467/21656
Mute #pcap:https://lists.fd.io/g/vpp-dev/mutehashtag/pcap
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-