Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-10-07 Thread Damjan Marion via lists.fd.io

ok, then just don’t do it until problem is properly addressed in i40e.

—
Damjan



On 07.10.2021., at 14:03, Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco) 
mailto:pmi...@cisco.com>> wrote:

vpp_device, a.k.a functional per patch testing in volume.

Peter Mikus
Engineer – Software
Cisco Systems Limited


From: Damjan Marion (damarion) mailto:damar...@cisco.com>>
Sent: Thursday, October 7, 2021 14:02
To: Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco)
Cc: Juraj Linkeš; vpp-dev; Lijian Zhang
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN 
with newer i40e drivers


I don't think using vlans in performance testbeds is good idea.
I would simply avoid using it…

—
Damjan



On 07.10.2021., at 13:58, Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco) 
mailto:pmi...@cisco.com>> wrote:

This effectively means to me decommission of vpp_device testing on Fortville, 
due to absent of support (API, switch, whatever...).
Vlan is fundamental feature of isolating the traffic into VFs in multitenant 
environments. It is clear from [0]

//quote
If you have applications that require Virtual Functions (VFs) to receive
packets with VLAN tags, you can disable VLAN tag stripping for the VF. The
Physical Function (PF) processes requests issued from the VF to enable or
disable VLAN tag stripping. Note that if the PF has assigned a VLAN to a VF,
then requests from that VF to set VLAN tag stripping will be ignored.

So unless this is a bug, then it means that application should not enforce the 
behavior.

Juraj. Does this detection works on DPDK testpmd? 
https://doc.dpdk.org/dts/test_plans/vlan_test_plan.html
If this is indeed unsupported on new driver level and firmware, then removing 
700 series is the only option to me.

To me this is as simple as to:
 =  disable_vlan_stripping()
if error:
  vlan_cannot_stripped_flag == 1 # ignore the error.

Thoughts?

[0] https://downloadmirror.intel.com/24693/eng/readme_4.2.7.txt

Peter Mikus
Engineer – Software
Cisco Systems Limited


From: Damjan Marion (damarion) 
mailto:damar...@cisco.com>>
Sent: Thursday, October 7, 2021 13:36
To: Juraj Linkeš
Cc: vpp-dev; Lijian Zhang; Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco)
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN 
with newer i40e drivers



On 07.10.2021., at 13:22, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>>
 wrote:



-Original Message-
From: 
vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> 
On Behalf Of Juraj Linkeš
Sent: Tuesday, September 28, 2021 11:43 AM
To: damar...@cisco.com
Cc: vpp-dev 
mailto:vpp-dev@lists.fd.io>>; 
Lijian Zhang 
mailto:lijian.zh...@arm.com>>
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN
with newer i40e drivers



-Original Message-
From: 
vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> 
On Behalf Of Damjan
Marion via lists.fd.io
Sent: Wednesday, September 15, 2021 5:54 PM
To: Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>>
Cc: vpp-dev 
mailto:vpp-dev@lists.fd.io>>; 
Lijian Zhang 
mailto:lijian.zh...@arm.com>>
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
configured VLAN with newer i40e drivers



On 10.09.2021., at 08:53, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>>
 wrote:



From: 
vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> 
On Behalf Of Damjan
Marion via lists.fd.io
Sent: Thursday, September 9, 2021 12:01 PM
To: Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>>
Cc: vpp-dev 
mailto:vpp-dev@lists.fd.io>>; 
Lijian Zhang
mailto:lijian.zh...@arm.com>>
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
configured VLAN with newer i40e drivers


On 09.09.2021., at 09:14, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>>
 wrote:

Hi Damjan, vpp devs,

Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes
AVF
interface creation on VFs with configured VLANs fail:
2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues:
num_queue_pairs 1
2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1
minor
1
2021/08/30 09:15:27:444 debug avf :91:04.1: 

Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-10-07 Thread Peter Mikus via lists.fd.io
vpp_device, a.k.a functional per patch testing in volume.

Peter Mikus
Engineer – Software
Cisco Systems Limited


From: Damjan Marion (damarion) 
Sent: Thursday, October 7, 2021 14:02
To: Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco)
Cc: Juraj Linkeš; vpp-dev; Lijian Zhang
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN 
with newer i40e drivers


I don't think using vlans in performance testbeds is good idea.
I would simply avoid using it…

—
Damjan



On 07.10.2021., at 13:58, Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco) 
mailto:pmi...@cisco.com>> wrote:

This effectively means to me decommission of vpp_device testing on Fortville, 
due to absent of support (API, switch, whatever...).
Vlan is fundamental feature of isolating the traffic into VFs in multitenant 
environments. It is clear from [0]

//quote
If you have applications that require Virtual Functions (VFs) to receive
packets with VLAN tags, you can disable VLAN tag stripping for the VF. The
Physical Function (PF) processes requests issued from the VF to enable or
disable VLAN tag stripping. Note that if the PF has assigned a VLAN to a VF,
then requests from that VF to set VLAN tag stripping will be ignored.

So unless this is a bug, then it means that application should not enforce the 
behavior.

Juraj. Does this detection works on DPDK testpmd? 
https://doc.dpdk.org/dts/test_plans/vlan_test_plan.html
If this is indeed unsupported on new driver level and firmware, then removing 
700 series is the only option to me.

To me this is as simple as to:
 =  disable_vlan_stripping()
if error:
   vlan_cannot_stripped_flag == 1 # ignore the error.

Thoughts?

[0] https://downloadmirror.intel.com/24693/eng/readme_4.2.7.txt

Peter Mikus
Engineer – Software
Cisco Systems Limited


From: Damjan Marion (damarion) mailto:damar...@cisco.com>>
Sent: Thursday, October 7, 2021 13:36
To: Juraj Linkeš
Cc: vpp-dev; Lijian Zhang; Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco)
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN 
with newer i40e drivers



On 07.10.2021., at 13:22, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>> wrote:



-Original Message-
From: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Juraj Linkeš
Sent: Tuesday, September 28, 2021 11:43 AM
To: damar...@cisco.com
Cc: vpp-dev mailto:vpp-dev@lists.fd.io>>; Lijian Zhang 
mailto:lijian.zh...@arm.com>>
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN
with newer i40e drivers



-Original Message-
From: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Damjan
Marion via lists.fd.io
Sent: Wednesday, September 15, 2021 5:54 PM
To: Juraj Linkeš mailto:juraj.lin...@pantheon.tech>>
Cc: vpp-dev mailto:vpp-dev@lists.fd.io>>; Lijian Zhang 
mailto:lijian.zh...@arm.com>>
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
configured VLAN with newer i40e drivers



On 10.09.2021., at 08:53, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>> wrote:



From: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Damjan
Marion via lists.fd.io
Sent: Thursday, September 9, 2021 12:01 PM
To: Juraj Linkeš mailto:juraj.lin...@pantheon.tech>>
Cc: vpp-dev mailto:vpp-dev@lists.fd.io>>; Lijian Zhang
mailto:lijian.zh...@arm.com>>
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
configured VLAN with newer i40e drivers


On 09.09.2021., at 09:14, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>> wrote:

Hi Damjan, vpp devs,

Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes
AVF
interface creation on VFs with configured VLANs fail:
2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues:
num_queue_pairs 1
2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1
minor
1
2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources:
bitmap 0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan
rx-polling rss-pf offload-adv-rss-pf offload-fdir-pf)
2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources:
num_vsis 1 num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags
0xb0081 (l2 adv-link-speed vlan rx-polling rss-pf) rss_key_size 52
rss_lut_size 64
2021/08/30 09:15:27:445 debug avf :91:04.1:
get_vf_resources_vsi[0]: vsi_id 27 num_queue_pairs 1 vsi_type 6
qset_handle 21 default_mac_addr ba:dc:0f:fe:02:11
2021/08/30 09:15:27:445 debug avf :91:04.1:
disable_vlan_stripping
2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf:
error [v_opcode = 28, v_retval -5] from avf_create_if: pci-addr
:91:04.1

Syslog reveals a bit more:
Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci
:91:04.1: enabling device ( -> 0002) Aug 30 09:15:27

Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-10-07 Thread Damjan Marion via lists.fd.io

I don't think using vlans in performance testbeds is good idea.
I would simply avoid using it…

—
Damjan



On 07.10.2021., at 13:58, Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco) 
mailto:pmi...@cisco.com>> wrote:

This effectively means to me decommission of vpp_device testing on Fortville, 
due to absent of support (API, switch, whatever...).
Vlan is fundamental feature of isolating the traffic into VFs in multitenant 
environments. It is clear from [0]

//quote
If you have applications that require Virtual Functions (VFs) to receive
packets with VLAN tags, you can disable VLAN tag stripping for the VF. The
Physical Function (PF) processes requests issued from the VF to enable or
disable VLAN tag stripping. Note that if the PF has assigned a VLAN to a VF,
then requests from that VF to set VLAN tag stripping will be ignored.

So unless this is a bug, then it means that application should not enforce the 
behavior.

Juraj. Does this detection works on DPDK testpmd? 
https://doc.dpdk.org/dts/test_plans/vlan_test_plan.html
If this is indeed unsupported on new driver level and firmware, then removing 
700 series is the only option to me.

To me this is as simple as to:
 =  disable_vlan_stripping()
if error:
   vlan_cannot_stripped_flag == 1 # ignore the error.

Thoughts?

[0] https://downloadmirror.intel.com/24693/eng/readme_4.2.7.txt

Peter Mikus
Engineer – Software
Cisco Systems Limited


From: Damjan Marion (damarion) mailto:damar...@cisco.com>>
Sent: Thursday, October 7, 2021 13:36
To: Juraj Linkeš
Cc: vpp-dev; Lijian Zhang; Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco)
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN 
with newer i40e drivers



On 07.10.2021., at 13:22, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>> wrote:



-Original Message-
From: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Juraj Linkeš
Sent: Tuesday, September 28, 2021 11:43 AM
To: damar...@cisco.com
Cc: vpp-dev mailto:vpp-dev@lists.fd.io>>; Lijian Zhang 
mailto:lijian.zh...@arm.com>>
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN
with newer i40e drivers



-Original Message-
From: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Damjan
Marion via lists.fd.io
Sent: Wednesday, September 15, 2021 5:54 PM
To: Juraj Linkeš mailto:juraj.lin...@pantheon.tech>>
Cc: vpp-dev mailto:vpp-dev@lists.fd.io>>; Lijian Zhang 
mailto:lijian.zh...@arm.com>>
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
configured VLAN with newer i40e drivers



On 10.09.2021., at 08:53, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>> wrote:



From: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> On Behalf Of Damjan
Marion via lists.fd.io
Sent: Thursday, September 9, 2021 12:01 PM
To: Juraj Linkeš mailto:juraj.lin...@pantheon.tech>>
Cc: vpp-dev mailto:vpp-dev@lists.fd.io>>; Lijian Zhang
mailto:lijian.zh...@arm.com>>
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
configured VLAN with newer i40e drivers


On 09.09.2021., at 09:14, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>> wrote:

Hi Damjan, vpp devs,

Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes
AVF
interface creation on VFs with configured VLANs fail:
2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues:
num_queue_pairs 1
2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1
minor
1
2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources:
bitmap 0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan
rx-polling rss-pf offload-adv-rss-pf offload-fdir-pf)
2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources:
num_vsis 1 num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags
0xb0081 (l2 adv-link-speed vlan rx-polling rss-pf) rss_key_size 52
rss_lut_size 64
2021/08/30 09:15:27:445 debug avf :91:04.1:
get_vf_resources_vsi[0]: vsi_id 27 num_queue_pairs 1 vsi_type 6
qset_handle 21 default_mac_addr ba:dc:0f:fe:02:11
2021/08/30 09:15:27:445 debug avf :91:04.1:
disable_vlan_stripping
2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf:
error [v_opcode = 28, v_retval -5] from avf_create_if: pci-addr
:91:04.1

Syslog reveals a bit more:
Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci
:91:04.1: enabling device ( -> 0002) Aug 30 09:15:27
s55-t13-sut1 kernel: [352170.140729] i40e :91:00.0: Cannot
disable vlan stripping when port VLAN is set Aug 30 09:15:27
s55-t13-sut1
kernel: [352170.140737] i40e :91:00.0: VF 17 failed opcode 28,
retval: -5

It looks like this feature (vlan stripping on VFs with VLANs) was
removed in
later versions of the driver. I don't know what the proper solution
here is, but adding a configuration option to not disable vlan

Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-10-07 Thread Peter Mikus via lists.fd.io
This effectively means to me decommission of vpp_device testing on Fortville, 
due to absent of support (API, switch, whatever...).
Vlan is fundamental feature of isolating the traffic into VFs in multitenant 
environments. It is clear from [0]

//quote
If you have applications that require Virtual Functions (VFs) to receive
packets with VLAN tags, you can disable VLAN tag stripping for the VF. The
Physical Function (PF) processes requests issued from the VF to enable or
disable VLAN tag stripping. Note that if the PF has assigned a VLAN to a VF,
then requests from that VF to set VLAN tag stripping will be ignored.

So unless this is a bug, then it means that application should not enforce the 
behavior.

Juraj. Does this detection works on DPDK testpmd? 
https://doc.dpdk.org/dts/test_plans/vlan_test_plan.html
If this is indeed unsupported on new driver level and firmware, then removing 
700 series is the only option to me.

To me this is as simple as to:
 =  disable_vlan_stripping()
if error:
vlan_cannot_stripped_flag == 1 # ignore the error.

Thoughts?

[0] https://downloadmirror.intel.com/24693/eng/readme_4.2.7.txt

Peter Mikus
Engineer – Software
Cisco Systems Limited


From: Damjan Marion (damarion) 
Sent: Thursday, October 7, 2021 13:36
To: Juraj Linkeš
Cc: vpp-dev; Lijian Zhang; Peter Mikus -X (pmikus - PANTHEON TECH SRO at Cisco)
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN 
with newer i40e drivers



> On 07.10.2021., at 13:22, Juraj Linkeš  wrote:
>
>
>
>> -Original Message-
>> From: vpp-dev@lists.fd.io  On Behalf Of Juraj Linkeš
>> Sent: Tuesday, September 28, 2021 11:43 AM
>> To: damar...@cisco.com
>> Cc: vpp-dev ; Lijian Zhang 
>> Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured 
>> VLAN
>> with newer i40e drivers
>>
>>
>>
>>> -Original Message-
>>> From: vpp-dev@lists.fd.io  On Behalf Of Damjan
>>> Marion via lists.fd.io
>>> Sent: Wednesday, September 15, 2021 5:54 PM
>>> To: Juraj Linkeš 
>>> Cc: vpp-dev ; Lijian Zhang 
>>> Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
>>> configured VLAN with newer i40e drivers
>>>
>>>
>>>
 On 10.09.2021., at 08:53, Juraj Linkeš  wrote:



 From: vpp-dev@lists.fd.io  On Behalf Of Damjan
 Marion via lists.fd.io
 Sent: Thursday, September 9, 2021 12:01 PM
 To: Juraj Linkeš 
 Cc: vpp-dev ; Lijian Zhang
 
 Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
 configured VLAN with newer i40e drivers


 On 09.09.2021., at 09:14, Juraj Linkeš  wrote:

 Hi Damjan, vpp devs,

 Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes
 AVF
>>> interface creation on VFs with configured VLANs fail:
 2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues:
 num_queue_pairs 1
 2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1
 minor
 1
 2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources:
 bitmap 0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan
 rx-polling rss-pf offload-adv-rss-pf offload-fdir-pf)
 2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources:
 num_vsis 1 num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags
 0xb0081 (l2 adv-link-speed vlan rx-polling rss-pf) rss_key_size 52
 rss_lut_size 64
 2021/08/30 09:15:27:445 debug avf :91:04.1:
 get_vf_resources_vsi[0]: vsi_id 27 num_queue_pairs 1 vsi_type 6
 qset_handle 21 default_mac_addr ba:dc:0f:fe:02:11
 2021/08/30 09:15:27:445 debug avf :91:04.1:
 disable_vlan_stripping
 2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf:
 error [v_opcode = 28, v_retval -5] from avf_create_if: pci-addr
 :91:04.1

 Syslog reveals a bit more:
 Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci
 :91:04.1: enabling device ( -> 0002) Aug 30 09:15:27
 s55-t13-sut1 kernel: [352170.140729] i40e :91:00.0: Cannot
 disable vlan stripping when port VLAN is set Aug 30 09:15:27
 s55-t13-sut1
 kernel: [352170.140737] i40e :91:00.0: VF 17 failed opcode 28,
 retval: -5

 It looks like this feature (vlan stripping on VFs with VLANs) was
 removed in
>>> later versions of the driver. I don't know what the proper solution
>>> here is, but adding a configuration option to not disable vlan
>>> stripping when creating AVF interface sound good to me.

 I've documented this in https://jira.fd.io/browse/VPP-1995.

 Can you try with 2.16.11 and report back same outputs?

 I've updated https://jira.fd.io/browse/VPP-1995 with 2.16.11 outputs
 and
>>> they're pretty much the same, except the last syslog line is missing.
>>>
>>> OK, I was hoping new version of driver supports VLAN v2 offload APIs
>>> which allows us to know if stripping is supported or not on the

Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-10-07 Thread Damjan Marion via lists.fd.io


> On 07.10.2021., at 13:22, Juraj Linkeš  wrote:
> 
> 
> 
>> -Original Message-
>> From: vpp-dev@lists.fd.io  On Behalf Of Juraj Linkeš
>> Sent: Tuesday, September 28, 2021 11:43 AM
>> To: damar...@cisco.com
>> Cc: vpp-dev ; Lijian Zhang 
>> Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured 
>> VLAN
>> with newer i40e drivers
>> 
>> 
>> 
>>> -Original Message-
>>> From: vpp-dev@lists.fd.io  On Behalf Of Damjan
>>> Marion via lists.fd.io
>>> Sent: Wednesday, September 15, 2021 5:54 PM
>>> To: Juraj Linkeš 
>>> Cc: vpp-dev ; Lijian Zhang 
>>> Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
>>> configured VLAN with newer i40e drivers
>>> 
>>> 
>>> 
 On 10.09.2021., at 08:53, Juraj Linkeš  wrote:
 
 
 
 From: vpp-dev@lists.fd.io  On Behalf Of Damjan
 Marion via lists.fd.io
 Sent: Thursday, September 9, 2021 12:01 PM
 To: Juraj Linkeš 
 Cc: vpp-dev ; Lijian Zhang
 
 Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
 configured VLAN with newer i40e drivers
 
 
 On 09.09.2021., at 09:14, Juraj Linkeš  wrote:
 
 Hi Damjan, vpp devs,
 
 Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes
 AVF
>>> interface creation on VFs with configured VLANs fail:
 2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues:
 num_queue_pairs 1
 2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1
 minor
 1
 2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources:
 bitmap 0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan
 rx-polling rss-pf offload-adv-rss-pf offload-fdir-pf)
 2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources:
 num_vsis 1 num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags
 0xb0081 (l2 adv-link-speed vlan rx-polling rss-pf) rss_key_size 52
 rss_lut_size 64
 2021/08/30 09:15:27:445 debug avf :91:04.1:
 get_vf_resources_vsi[0]: vsi_id 27 num_queue_pairs 1 vsi_type 6
 qset_handle 21 default_mac_addr ba:dc:0f:fe:02:11
 2021/08/30 09:15:27:445 debug avf :91:04.1:
 disable_vlan_stripping
 2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf:
 error [v_opcode = 28, v_retval -5] from avf_create_if: pci-addr
 :91:04.1
 
 Syslog reveals a bit more:
 Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci
 :91:04.1: enabling device ( -> 0002) Aug 30 09:15:27
 s55-t13-sut1 kernel: [352170.140729] i40e :91:00.0: Cannot
 disable vlan stripping when port VLAN is set Aug 30 09:15:27
 s55-t13-sut1
 kernel: [352170.140737] i40e :91:00.0: VF 17 failed opcode 28,
 retval: -5
 
 It looks like this feature (vlan stripping on VFs with VLANs) was
 removed in
>>> later versions of the driver. I don't know what the proper solution
>>> here is, but adding a configuration option to not disable vlan
>>> stripping when creating AVF interface sound good to me.
 
 I've documented this in https://jira.fd.io/browse/VPP-1995.
 
 Can you try with 2.16.11 and report back same outputs?
 
 I've updated https://jira.fd.io/browse/VPP-1995 with 2.16.11 outputs
 and
>>> they're pretty much the same, except the last syslog line is missing.
>>> 
>>> OK, I was hoping new version of driver supports VLAN v2 offload APIs
>>> which allows us to know if stripping is supported or not on the
>>> specific interface. V2 API is already supported on ice driver (E810
>>> NICs) and we have code to deal with that.
>>> 
>>> So not sure what we can do here. I don’t see a way to know if
>>> stripping is supported or not.
>> 
>> If there isn't an API for this, then we'll have to get this information from 
>> the
>> user, right?
>> 
>> Or we could try enabling stripping but not fail the interface initialization 
>> if it's not
>> successful.
>> 
>> Thoughts?
>> Juraj
>> 
> 
> Hi Damjan,
> 
> Just pinging to get your thoughts. I really seems like we should introduce 
> some sort of switch in the absence of an API.

Or simply declare it as unsupported until intel introduces V2 api in the i40e.

— 
Damjan



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#20295): https://lists.fd.io/g/vpp-dev/message/20295
Mute This Topic: https://lists.fd.io/mt/85479187/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-10-07 Thread Juraj Linkeš


> -Original Message-
> From: vpp-dev@lists.fd.io  On Behalf Of Juraj Linkeš
> Sent: Tuesday, September 28, 2021 11:43 AM
> To: damar...@cisco.com
> Cc: vpp-dev ; Lijian Zhang 
> Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured 
> VLAN
> with newer i40e drivers
> 
> 
> 
> > -Original Message-
> > From: vpp-dev@lists.fd.io  On Behalf Of Damjan
> > Marion via lists.fd.io
> > Sent: Wednesday, September 15, 2021 5:54 PM
> > To: Juraj Linkeš 
> > Cc: vpp-dev ; Lijian Zhang 
> > Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
> > configured VLAN with newer i40e drivers
> >
> >
> >
> > > On 10.09.2021., at 08:53, Juraj Linkeš  wrote:
> > >
> > >
> > >
> > > From: vpp-dev@lists.fd.io  On Behalf Of Damjan
> > > Marion via lists.fd.io
> > > Sent: Thursday, September 9, 2021 12:01 PM
> > > To: Juraj Linkeš 
> > > Cc: vpp-dev ; Lijian Zhang
> > > 
> > > Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
> > > configured VLAN with newer i40e drivers
> > >
> > >
> > > On 09.09.2021., at 09:14, Juraj Linkeš  wrote:
> > >
> > > Hi Damjan, vpp devs,
> > >
> > > Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes
> > > AVF
> > interface creation on VFs with configured VLANs fail:
> > > 2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues:
> > > num_queue_pairs 1
> > > 2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1
> > > minor
> > > 1
> > > 2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources:
> > > bitmap 0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan
> > > rx-polling rss-pf offload-adv-rss-pf offload-fdir-pf)
> > > 2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources:
> > > num_vsis 1 num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags
> > > 0xb0081 (l2 adv-link-speed vlan rx-polling rss-pf) rss_key_size 52
> > > rss_lut_size 64
> > > 2021/08/30 09:15:27:445 debug avf :91:04.1:
> > > get_vf_resources_vsi[0]: vsi_id 27 num_queue_pairs 1 vsi_type 6
> > > qset_handle 21 default_mac_addr ba:dc:0f:fe:02:11
> > > 2021/08/30 09:15:27:445 debug avf :91:04.1:
> > > disable_vlan_stripping
> > > 2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf:
> > > error [v_opcode = 28, v_retval -5] from avf_create_if: pci-addr
> > > :91:04.1
> > >
> > > Syslog reveals a bit more:
> > > Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci
> > > :91:04.1: enabling device ( -> 0002) Aug 30 09:15:27
> > > s55-t13-sut1 kernel: [352170.140729] i40e :91:00.0: Cannot
> > > disable vlan stripping when port VLAN is set Aug 30 09:15:27
> > > s55-t13-sut1
> > > kernel: [352170.140737] i40e :91:00.0: VF 17 failed opcode 28,
> > > retval: -5
> > >
> > > It looks like this feature (vlan stripping on VFs with VLANs) was
> > > removed in
> > later versions of the driver. I don't know what the proper solution
> > here is, but adding a configuration option to not disable vlan
> > stripping when creating AVF interface sound good to me.
> > >
> > > I've documented this in https://jira.fd.io/browse/VPP-1995.
> > >
> > > Can you try with 2.16.11 and report back same outputs?
> > >
> > > I've updated https://jira.fd.io/browse/VPP-1995 with 2.16.11 outputs
> > > and
> > they're pretty much the same, except the last syslog line is missing.
> >
> > OK, I was hoping new version of driver supports VLAN v2 offload APIs
> > which allows us to know if stripping is supported or not on the
> > specific interface. V2 API is already supported on ice driver (E810
> > NICs) and we have code to deal with that.
> >
> > So not sure what we can do here. I don’t see a way to know if
> > stripping is supported or not.
> 
> If there isn't an API for this, then we'll have to get this information from 
> the
> user, right?
> 
> Or we could try enabling stripping but not fail the interface initialization 
> if it's not
> successful.
> 
> Thoughts?
> Juraj
> 

Hi Damjan,

Just pinging to get your thoughts. I really seems like we should introduce some 
sort of switch in the absence of an API.

Juraj

> >
> > —
> > Damjan
> >
> >
> > Not sure
> >
> 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#20294): https://lists.fd.io/g/vpp-dev/message/20294
Mute This Topic: https://lists.fd.io/mt/85479187/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-09-28 Thread Juraj Linkeš


> -Original Message-
> From: vpp-dev@lists.fd.io  On Behalf Of Damjan Marion
> via lists.fd.io
> Sent: Wednesday, September 15, 2021 5:54 PM
> To: Juraj Linkeš 
> Cc: vpp-dev ; Lijian Zhang 
> Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured 
> VLAN
> with newer i40e drivers
> 
> 
> 
> > On 10.09.2021., at 08:53, Juraj Linkeš  wrote:
> >
> >
> >
> > From: vpp-dev@lists.fd.io  On Behalf Of Damjan
> > Marion via lists.fd.io
> > Sent: Thursday, September 9, 2021 12:01 PM
> > To: Juraj Linkeš 
> > Cc: vpp-dev ; Lijian Zhang 
> > Subject: Re: [vpp-dev] AVF interface creation fails on VFs with
> > configured VLAN with newer i40e drivers
> >
> >
> > On 09.09.2021., at 09:14, Juraj Linkeš  wrote:
> >
> > Hi Damjan, vpp devs,
> >
> > Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes AVF
> interface creation on VFs with configured VLANs fail:
> > 2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues:
> > num_queue_pairs 1
> > 2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1 minor
> > 1
> > 2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources:
> > bitmap 0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan rx-polling
> > rss-pf offload-adv-rss-pf offload-fdir-pf)
> > 2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources:
> > num_vsis 1 num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags
> > 0xb0081 (l2 adv-link-speed vlan rx-polling rss-pf) rss_key_size 52
> > rss_lut_size 64
> > 2021/08/30 09:15:27:445 debug avf :91:04.1:
> > get_vf_resources_vsi[0]: vsi_id 27 num_queue_pairs 1 vsi_type 6
> > qset_handle 21 default_mac_addr ba:dc:0f:fe:02:11
> > 2021/08/30 09:15:27:445 debug avf :91:04.1: disable_vlan_stripping
> > 2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf:
> > error [v_opcode = 28, v_retval -5] from avf_create_if: pci-addr
> > :91:04.1
> >
> > Syslog reveals a bit more:
> > Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci
> > :91:04.1: enabling device ( -> 0002) Aug 30 09:15:27
> > s55-t13-sut1 kernel: [352170.140729] i40e :91:00.0: Cannot disable
> > vlan stripping when port VLAN is set Aug 30 09:15:27 s55-t13-sut1
> > kernel: [352170.140737] i40e :91:00.0: VF 17 failed opcode 28,
> > retval: -5
> >
> > It looks like this feature (vlan stripping on VFs with VLANs) was removed in
> later versions of the driver. I don't know what the proper solution here is, 
> but
> adding a configuration option to not disable vlan stripping when creating AVF
> interface sound good to me.
> >
> > I've documented this in https://jira.fd.io/browse/VPP-1995.
> >
> > Can you try with 2.16.11 and report back same outputs?
> >
> > I've updated https://jira.fd.io/browse/VPP-1995 with 2.16.11 outputs and
> they're pretty much the same, except the last syslog line is missing.
> 
> OK, I was hoping new version of driver supports VLAN v2 offload APIs which
> allows us to know if stripping is supported or not on the specific interface. 
> V2
> API is already supported on ice driver (E810 NICs) and we have code to deal 
> with
> that.
> 
> So not sure what we can do here. I don’t see a way to know if stripping is
> supported or not.

If there isn't an API for this, then we'll have to get this information from 
the user, right?

Or we could try enabling stripping but not fail the interface initialization if 
it's not successful.

Thoughts?
Juraj

> 
> —
> Damjan
> 
> 
> Not sure
> 



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#20213): https://lists.fd.io/g/vpp-dev/message/20213
Mute This Topic: https://lists.fd.io/mt/85479187/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-09-15 Thread Damjan Marion via lists.fd.io


> On 10.09.2021., at 08:53, Juraj Linkeš  wrote:
> 
>  
>  
> From: vpp-dev@lists.fd.io  On Behalf Of Damjan Marion 
> via lists.fd.io
> Sent: Thursday, September 9, 2021 12:01 PM
> To: Juraj Linkeš 
> Cc: vpp-dev ; Lijian Zhang 
> Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured 
> VLAN with newer i40e drivers
>  
> 
> On 09.09.2021., at 09:14, Juraj Linkeš  wrote:
>  
> Hi Damjan, vpp devs,
>  
> Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes AVF 
> interface creation on VFs with configured VLANs fail:
> 2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues: 
> num_queue_pairs 1
> 2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1 minor 1
> 2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources: bitmap 
> 0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan rx-polling rss-pf 
> offload-adv-rss-pf offload-fdir-pf)
> 2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources: num_vsis 1 
> num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags 0xb0081 (l2 
> adv-link-speed vlan rx-polling rss-pf) rss_key_size 52 rss_lut_size 64
> 2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources_vsi[0]: 
> vsi_id 27 num_queue_pairs 1 vsi_type 6 qset_handle 21 default_mac_addr 
> ba:dc:0f:fe:02:11
> 2021/08/30 09:15:27:445 debug avf :91:04.1: disable_vlan_stripping
> 2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf: error 
> [v_opcode = 28, v_retval -5]
> from avf_create_if: pci-addr :91:04.1
>  
> Syslog reveals a bit more:
> Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci :91:04.1: 
> enabling device ( -> 0002)
> Aug 30 09:15:27 s55-t13-sut1 kernel: [352170.140729] i40e :91:00.0: 
> Cannot disable vlan stripping when port VLAN is set
> Aug 30 09:15:27 s55-t13-sut1 kernel: [352170.140737] i40e :91:00.0: VF 17 
> failed opcode 28, retval: -5
>  
> It looks like this feature (vlan stripping on VFs with VLANs) was removed in 
> later versions of the driver. I don't know what the proper solution here is, 
> but adding a configuration option to not disable vlan stripping when creating 
> AVF interface sound good to me.
>  
> I've documented this in https://jira.fd.io/browse/VPP-1995.
>  
> Can you try with 2.16.11 and report back same outputs?
>  
> I've updated https://jira.fd.io/browse/VPP-1995 with 2.16.11 outputs and 
> they're pretty much the same, except the last syslog line is missing.

OK, I was hoping new version of driver supports VLAN v2 offload APIs which 
allows us to know if stripping is supported or not on the specific interface. 
V2 API is already supported on ice driver (E810 NICs) and we have code to deal 
with that.

So not sure what we can do here. I don’t see a way to know if stripping is 
supported or not.

— 
Damjan

 
Not sure 



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#20138): https://lists.fd.io/g/vpp-dev/message/20138
Mute This Topic: https://lists.fd.io/mt/85479187/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-09-10 Thread Juraj Linkeš


From: vpp-dev@lists.fd.io  On Behalf Of Damjan Marion via 
lists.fd.io
Sent: Thursday, September 9, 2021 12:01 PM
To: Juraj Linkeš 
Cc: vpp-dev ; Lijian Zhang 
Subject: Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN 
with newer i40e drivers


On 09.09.2021., at 09:14, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>> wrote:

Hi Damjan, vpp devs,

Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes AVF 
interface creation on VFs with configured VLANs fail:
2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues: num_queue_pairs 
1
2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1 minor 1
2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources: bitmap 
0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan rx-polling rss-pf 
offload-adv-rss-pf offload-fdir-pf)
2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources: num_vsis 1 
num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags 0xb0081 (l2 
adv-link-speed vlan rx-polling rss-pf) rss_key_size 52 rss_lut_size 64
2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources_vsi[0]: vsi_id 
27 num_queue_pairs 1 vsi_type 6 qset_handle 21 default_mac_addr 
ba:dc:0f:fe:02:11
2021/08/30 09:15:27:445 debug avf :91:04.1: disable_vlan_stripping
2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf: error 
[v_opcode = 28, v_retval -5]
from avf_create_if: pci-addr :91:04.1

Syslog reveals a bit more:
Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci :91:04.1: 
enabling device ( -> 0002)
Aug 30 09:15:27 s55-t13-sut1 kernel: [352170.140729] i40e :91:00.0: Cannot 
disable vlan stripping when port VLAN is set
Aug 30 09:15:27 s55-t13-sut1 kernel: [352170.140737] i40e :91:00.0: VF 17 
failed opcode 28, retval: -5

It looks like this feature (vlan stripping on VFs with VLANs) was removed in 
later versions of the driver. I don't know what the proper solution here is, 
but adding a configuration option to not disable vlan stripping when creating 
AVF interface sound good to me.

I've documented this in https://jira.fd.io/browse/VPP-1995.

Can you try with 2.16.11 and report back same outputs?

I've updated https://jira.fd.io/browse/VPP-1995 with 2.16.11 outputs and 
they're pretty much the same, except the last syslog line is missing.

I just updated https://github.com/dmarion/deb-i40e in case you are using it…

Thanks, we're currently using the intel download pages, but it may be easier to 
use your repo, so we'll keep it in mind for the future.

Juraj

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#20112): https://lists.fd.io/g/vpp-dev/message/20112
Mute This Topic: https://lists.fd.io/mt/85479187/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-09-09 Thread Damjan Marion via lists.fd.io

On 09.09.2021., at 09:14, Juraj Linkeš 
mailto:juraj.lin...@pantheon.tech>> wrote:

Hi Damjan, vpp devs,

Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes AVF 
interface creation on VFs with configured VLANs fail:
2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues: num_queue_pairs 
1
2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1 minor 1
2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources: bitmap 
0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan rx-polling rss-pf 
offload-adv-rss-pf offload-fdir-pf)
2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources: num_vsis 1 
num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags 0xb0081 (l2 
adv-link-speed vlan rx-polling rss-pf) rss_key_size 52 rss_lut_size 64
2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources_vsi[0]: vsi_id 
27 num_queue_pairs 1 vsi_type 6 qset_handle 21 default_mac_addr 
ba:dc:0f:fe:02:11
2021/08/30 09:15:27:445 debug avf :91:04.1: disable_vlan_stripping
2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf: error 
[v_opcode = 28, v_retval -5]
from avf_create_if: pci-addr :91:04.1

Syslog reveals a bit more:
Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci :91:04.1: 
enabling device ( -> 0002)
Aug 30 09:15:27 s55-t13-sut1 kernel: [352170.140729] i40e :91:00.0: Cannot 
disable vlan stripping when port VLAN is set
Aug 30 09:15:27 s55-t13-sut1 kernel: [352170.140737] i40e :91:00.0: VF 17 
failed opcode 28, retval: -5

It looks like this feature (vlan stripping on VFs with VLANs) was removed in 
later versions of the driver. I don't know what the proper solution here is, 
but adding a configuration option to not disable vlan stripping when creating 
AVF interface sound good to me.

I've documented this in https://jira.fd.io/browse/VPP-1995.

Can you try with 2.16.11 and report back same outputs?

I just updated https://github.com/dmarion/deb-i40e in case you are using it…

—
Damjan



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#20108): https://lists.fd.io/g/vpp-dev/message/20108
Mute This Topic: https://lists.fd.io/mt/85479187/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[vpp-dev] AVF interface creation fails on VFs with configured VLAN with newer i40e drivers

2021-09-09 Thread Juraj Linkeš
Hi Damjan, vpp devs,

Upgrading to 2.15.9 i40e driver in CI (from Ubuntu's 2.8.20-k) makes AVF 
interface creation on VFs with configured VLANs fail:
2021/08/30 09:15:27:343 debug avf :91:04.1: request_queues: num_queue_pairs 
1
2021/08/30 09:15:27:434 debug avf :91:04.1: version: major 1 minor 1
2021/08/30 09:15:27:444 debug avf :91:04.1: get_vf_resources: bitmap 
0x180b80a1 (l2 wb-on-itr adv-link-speed vlan-v2 vlan rx-polling rss-pf 
offload-adv-rss-pf offload-fdir-pf)
2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources: num_vsis 1 
num_queue_pairs 1 max_vectors 5 max_mtu 0 vf_cap_flags 0xb0081 (l2 
adv-link-speed vlan rx-polling rss-pf) rss_key_size 52 rss_lut_size 64
2021/08/30 09:15:27:445 debug avf :91:04.1: get_vf_resources_vsi[0]: vsi_id 
27 num_queue_pairs 1 vsi_type 6 qset_handle 21 default_mac_addr 
ba:dc:0f:fe:02:11
2021/08/30 09:15:27:445 debug avf :91:04.1: disable_vlan_stripping
2021/08/30 09:15:27:559 error avf :00:00.0: error: avf_send_to_pf: error 
[v_opcode = 28, v_retval -5]
from avf_create_if: pci-addr :91:04.1

Syslog reveals a bit more:
Aug 30 09:15:27 s55-t13-sut1 kernel: [352169.781206] vfio-pci :91:04.1: 
enabling device ( -> 0002)
Aug 30 09:15:27 s55-t13-sut1 kernel: [352170.140729] i40e :91:00.0: Cannot 
disable vlan stripping when port VLAN is set
Aug 30 09:15:27 s55-t13-sut1 kernel: [352170.140737] i40e :91:00.0: VF 17 
failed opcode 28, retval: -5

It looks like this feature (vlan stripping on VFs with VLANs) was removed in 
later versions of the driver. I don't know what the proper solution here is, 
but adding a configuration option to not disable vlan stripping when creating 
AVF interface sound good to me.

I've documented this in https://jira.fd.io/browse/VPP-1995.

Thanks,
Juraj

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#20101): https://lists.fd.io/g/vpp-dev/message/20101
Mute This Topic: https://lists.fd.io/mt/85479187/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-