Re: [vpp-dev] NAT bugix related to in2out/out2in handoff node index
I have cherry-picked this to stable/2001 [0] and will merge it once it has been verified. Thanks, -daw- [0] https://gerrit.fd.io/r/c/vpp/+/25861 On 3/13/2020 10:25 AM, Dave Barach via Lists.Fd.Io wrote: Merged, thanks for this one... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Filip Varga via Lists.Fd.Io Sent: Friday, March 13, 2020 10:08 AM To: Elias Rudberg ; vpp-dev@lists.fd.io Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] NAT bugix related to in2out/out2in handoff node index Hello, Thank you for your contribution Elias. Best regards, Filip -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Elias Rudberg Sent: Friday, March 13, 2020 3:00 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] NAT bugix related to in2out/out2in handoff node index Hello, While working on moving from VPP 19.08 to 20.01 we found that NAT was no longer working and it seems to be due to a bug in src/plugins/nat/nat.c for the dynamic endpoint-independent case, here: sm->handoff_out2in_index = snat_in2out_node.index; sm->handoff_in2out_index = snat_out2in_node.index; As I understand it, handoff_out2in_index is supposed to be the node index of the out2in node, but it is set to the in2out node index instead. And the other way around, in2out/in2out are mixed up in those two lines. I pushed a fix to gerrit, it's just those two lines that are changed: https://gerrit.fd.io/r/c/vpp/+/25856 If you agree, can this fix please be accepted into master and also into the stable/2001 branch? Best regards, Elias -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#15779): https://lists.fd.io/g/vpp-dev/message/15779 Mute This Topic: https://lists.fd.io/mt/71926127/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] NAT bugix related to in2out/out2in handoff node index
Hello, Thank you for your contribution Elias. Best regards, Filip -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Elias Rudberg Sent: Friday, March 13, 2020 3:00 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] NAT bugix related to in2out/out2in handoff node index Hello, While working on moving from VPP 19.08 to 20.01 we found that NAT was no longer working and it seems to be due to a bug in src/plugins/nat/nat.c for the dynamic endpoint-independent case, here: sm->handoff_out2in_index = snat_in2out_node.index; sm->handoff_in2out_index = snat_out2in_node.index; As I understand it, handoff_out2in_index is supposed to be the node index of the out2in node, but it is set to the in2out node index instead. And the other way around, in2out/in2out are mixed up in those two lines. I pushed a fix to gerrit, it's just those two lines that are changed: https://gerrit.fd.io/r/c/vpp/+/25856 If you agree, can this fix please be accepted into master and also into the stable/2001 branch? Best regards, Elias -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#15774): https://lists.fd.io/g/vpp-dev/message/15774 Mute This Topic: https://lists.fd.io/mt/71926127/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] NAT bugix related to in2out/out2in handoff node index
Hello, While working on moving from VPP 19.08 to 20.01 we found that NAT was no longer working and it seems to be due to a bug in src/plugins/nat/nat.c for the dynamic endpoint-independent case, here: sm->handoff_out2in_index = snat_in2out_node.index; sm->handoff_in2out_index = snat_out2in_node.index; As I understand it, handoff_out2in_index is supposed to be the node index of the out2in node, but it is set to the in2out node index instead. And the other way around, in2out/in2out are mixed up in those two lines. I pushed a fix to gerrit, it's just those two lines that are changed: https://gerrit.fd.io/r/c/vpp/+/25856 If you agree, can this fix please be accepted into master and also into the stable/2001 branch? Best regards, Elias -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#15772): https://lists.fd.io/g/vpp-dev/message/15772 Mute This Topic: https://lists.fd.io/mt/71926127/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
