Re: [vpp-dev] PSA: host stack active opens from first worker

2022-12-02 Thread Dave Wallace

Florin,

Most Excellent -- very nice work on improving the VPP Hoststack! :D

Thanks,
-daw-

On 12/1/22 18:17, Florin Coras wrote:

Hi folks,

It’s been many months and patches at this point but once [1] is 
merged, session layer will accept connects from both main, with worker 
barrier, and first worker. Preference is now for the latter, 
especially if CPS performance is critical.


There should be no need to change existing apps. In particular, vcl 
applications will transparently leverage this improvement while 
builtin applications should still work even if they rely on main 
thread for the connects.


The reason why this is a PSA is because in spite of all testing, 
there’s still a chance some corner case are not supported, some 
transports might be buggy now or just plain old bugs might’ve slipped 
in. Should you hit any issues, or have any additional comments, feel 
free to reach out via this thread or directly.


Benefits of this improvement are:
- no more main thread polling under heavy connect load. Under certain 
circumstances, main can still be used to perform the connects but this 
should be the exception not the norm.

- higher CPS performance.

And to be precise, regarding the CPS performance, on my skylake 
testbed using 40Gbps nics:
o) prior to [2], albeit note that several other changes that might’ve 
affected performance have already gone in:

- 1 worker vpp, pre-warmup: 80k post warmup: 105k
- 4 worker vpp, pre-warmup: 135k post-warmup: 230k
o) after change:
- 1 worker vpp, pre-warmup: 110k, post warmup: 165k
- 4 worker vpp, pre-warmup: 150k, post warmup: 360k

You can try to reproduce these results using this [2].

Regards,
Florin

[1] https://gerrit.fd.io/r/c/vpp/+/35713/
[2] 
https://wiki.fd.io/view/VPP/HostStack/EchoClientServer#TCP_CPS_measurement








-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22271): https://lists.fd.io/g/vpp-dev/message/22271
Mute This Topic: https://lists.fd.io/mt/95395667/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[vpp-dev] PSA: host stack active opens from first worker

2022-12-01 Thread Florin Coras
Hi folks, 

It’s been many months and patches at this point but once [1] is merged, session 
layer will accept connects from both main, with worker barrier, and first 
worker. Preference is now for the latter, especially if CPS performance is 
critical. 

There should be no need to change existing apps. In particular, vcl 
applications will transparently leverage this improvement while builtin 
applications should still work even if they rely on main thread for the 
connects. 

The reason why this is a PSA is because in spite of all testing, there’s still 
a chance some corner case are not supported, some transports might be buggy now 
or just plain old bugs might’ve slipped in. Should you hit any issues, or have 
any additional comments, feel free to reach out via this thread or directly.

Benefits of this improvement are:
- no more main thread polling under heavy connect load. Under certain 
circumstances, main can still be used to perform the connects but this should 
be the exception not the norm. 
- higher CPS performance.

And to be precise, regarding the CPS performance, on my skylake testbed using 
40Gbps nics:
o) prior to [2], albeit note that several other changes that might’ve affected 
performance have already gone in: 
- 1 worker vpp, pre-warmup: 80k post warmup: 105k
- 4 worker vpp, pre-warmup: 135k post-warmup: 230k 
o) after change:
- 1 worker vpp, pre-warmup: 110k, post warmup: 165k 
- 4 worker vpp, pre-warmup: 150k, post warmup: 360k

You can try to reproduce these results using this [2].

Regards, 
Florin

[1] https://gerrit.fd.io/r/c/vpp/+/35713/
[2] https://wiki.fd.io/view/VPP/HostStack/EchoClientServer#TCP_CPS_measurement


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22267): https://lists.fd.io/g/vpp-dev/message/22267
Mute This Topic: https://lists.fd.io/mt/95395667/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-