Re: [vpp-dev] help with review
Hi, I saw the change but had not had time to review it yet. Hopefully I'll be able to do so in the coming days. We are already in RC2 for 23.02 so I do not think it will be part of it as it does not seem to be a critical bug fix. Best ben > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of Pei, Yulong > Sent: Thursday, February 9, 2023 3:41 > To: Benoit Ganne (bganne) > Cc: vpp-dev@lists.fd.io; Dave Wallace (dwallace) > Subject: Re: [vpp-dev] help with review > > Hi Benoit and vpp-dev,What is your opinion about this patch > https://gerrit.fd.io/r/c/vpp/+/38135 ? Could it be merged in FD.io 23.02 > ? > > Best Regards > Yulong Pei > > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of Pei, Yulong > Sent: Tuesday, February 7, 2023 10:10 PM > To: Benoit Ganne (bganne) > Cc: vpp-dev@lists.fd.io > Subject: Re: [vpp-dev] help with review > > Hi Benoit, A new one also need your help to review > https://gerrit.fd.io/r/c/vpp/+/38135 , thanks a lot. > > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of Benoit Ganne > (bganne) via lists.fd.io > Sent: Thursday, February 2, 2023 6:37 PM > To: vpp-dev@lists.fd.io > Subject: Re: [vpp-dev] help with review > > Hi, thanks for the head's up. > > > Please help to review below patches again, all your comments were > > addressed. Thanks a lot. > > https://gerrit.fd.io/r/c/vpp/+/38008 > > Merged! > > > https://gerrit.fd.io/r/c/vpp/+/38009 > > A few minor comments left on that one, but then we should be good to > merge. > > Thanks, > ben -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22570): https://lists.fd.io/g/vpp-dev/message/22570 Mute This Topic: https://lists.fd.io/mt/96695094/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] help with review
Hi Benoit and vpp-dev,What is your opinion about this patch https://gerrit.fd.io/r/c/vpp/+/38135 ? Could it be merged in FD.io 23.02 ? Best Regards Yulong Pei -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Pei, Yulong Sent: Tuesday, February 7, 2023 10:10 PM To: Benoit Ganne (bganne) Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] help with review Hi Benoit, A new one also need your help to review https://gerrit.fd.io/r/c/vpp/+/38135 , thanks a lot. -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Benoit Ganne (bganne) via lists.fd.io Sent: Thursday, February 2, 2023 6:37 PM To: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] help with review Hi, thanks for the head's up. > Please help to review below patches again, all your comments were > addressed. Thanks a lot. > https://gerrit.fd.io/r/c/vpp/+/38008 Merged! > https://gerrit.fd.io/r/c/vpp/+/38009 A few minor comments left on that one, but then we should be good to merge. Thanks, ben -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22569): https://lists.fd.io/g/vpp-dev/message/22569 Mute This Topic: https://lists.fd.io/mt/96695094/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] help with review
Hi Benoit, A new one also need your help to review https://gerrit.fd.io/r/c/vpp/+/38135 , thanks a lot. -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Benoit Ganne (bganne) via lists.fd.io Sent: Thursday, February 2, 2023 6:37 PM To: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] help with review Hi, thanks for the head's up. > Please help to review below patches again, all your comments were > addressed. Thanks a lot. > https://gerrit.fd.io/r/c/vpp/+/38008 Merged! > https://gerrit.fd.io/r/c/vpp/+/38009 A few minor comments left on that one, but then we should be good to merge. Thanks, ben -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22558): https://lists.fd.io/g/vpp-dev/message/22558 Mute This Topic: https://lists.fd.io/mt/96695094/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] help with review
Hi, thanks for the head's up. > Please help to review below patches again, all your comments > were addressed. Thanks a lot. > https://gerrit.fd.io/r/c/vpp/+/38008 Merged! > https://gerrit.fd.io/r/c/vpp/+/38009 A few minor comments left on that one, but then we should be good to merge. Thanks, ben -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22538): https://lists.fd.io/g/vpp-dev/message/22538 Mute This Topic: https://lists.fd.io/mt/96695094/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] help with review
Hi Benoit, Please help to review below patches again, all your comments were addressed. Thanks a lot. https://gerrit.fd.io/r/c/vpp/+/38008 https://gerrit.fd.io/r/c/vpp/+/38009 From: vpp-dev@lists.fd.io On Behalf Of Pei, Yulong Sent: Thursday, January 12, 2023 8:42 PM To: vpp-dev ; Benoit Ganne (bganne) Subject: [vpp-dev] help review for patch about update af_xdp plugin to depend on libxdp Hi Benoit and vpp-dev, Could you help review for patch about update af_xdp plugin to depend on libxdp https://gerrit.fd.io/r/c/vpp/+/37869 . -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22535): https://lists.fd.io/g/vpp-dev/message/22535 Mute This Topic: https://lists.fd.io/mt/96695094/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] help with review
Looks good to me. Merged.
Best regards,
Ole
> On 24 Jan 2023, at 08:55, Stanislav Zaikin wrote:
>
> Hello folks,
>
> Any help with review is much appreciated. Both patches are waiting for quite
> a long time.
>
> - https://gerrit.fd.io/r/c/vpp/+/36721
> Short description: "autoendian" was broken for streLaming message types like:
> service {
> rpc lcp_itf_pair_get returns lcp_itf_pair_get_reply
> stream lcp_itf_pair_details;
> };
> vppapigen_c.py isn't generating boilerplate (endian handler, json handler,
> format handler, erc) for such types (both for vpp side and for vapi).
> There's currently also no support for streaming services in VAPI/C++, I have
> a patch for that, I will send it after this one will be merged (if it will be
> merged in the end).
>
> - https://gerrit.fd.io/r/c/vpp/+/36110
> Short description: there is a fast path in "ethernet-input" for whole frames
> with ETH_INPUT_FRAME_F_SINGLE_SW_IF_IDX flag. The rest input nodes have this
> snippet to allocate a frame per interface when receiving the packets (at
> least in dpdk-input and memif-input). I thought it'd be useful to have this
> fast path for tap interfaces. Theoretically it can be even measured with csit
> but I didn't succeed at that :)
>
> --
> Best regards
> Stanislav Zaikin
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22497): https://lists.fd.io/g/vpp-dev/message/22497
Mute This Topic: https://lists.fd.io/mt/96493146/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] help with review
Hello folks,
Any help with review is much appreciated. Both patches are waiting for
quite a long time.
- https://gerrit.fd.io/r/c/vpp/+/36721
Short description: "autoendian" was broken for streaming message types like:
service {
rpc lcp_itf_pair_get returns lcp_itf_pair_get_reply
*stream lcp_itf_pair_details*;
};
vppapigen_c.py isn't generating boilerplate (endian handler, json handler,
format handler, erc) for such types (both for vpp side and for vapi).
There's currently also no support for streaming services in VAPI/C++, I
have a patch for that, I will send it after this one will be merged (if it
will be merged in the end).
- https://gerrit.fd.io/r/c/vpp/+/36110
Short description: there is a fast path in "ethernet-input" for whole
frames with ETH_INPUT_FRAME_F_SINGLE_SW_IF_IDX flag. The rest input nodes
have this snippet to allocate a frame per interface when receiving the
packets (at least in dpdk-input and memif-input). I thought it'd be useful
to have this fast path for tap interfaces. Theoretically it can be even
measured with csit but I didn't succeed at that :)
--
Best regards
Stanislav Zaikin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22496): https://lists.fd.io/g/vpp-dev/message/22496
Mute This Topic: https://lists.fd.io/mt/96493146/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
