Re: [vpp-dev] not_last parameter of ip_add_del_route from ip.api
Remember to bump the API version number. I take it this is a backwards incompatible change. Cheers, Ole > On 18 Oct 2017, at 13:36, Neale Ranns (nranns) wrote: > > Hi Marek, > > It can be removed. > > /neale > >> From: "Dave Barach (dbarach)" >> Date: Wednesday, 18 October 2017 at 13:30 >> To: "Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco)" >> , "vpp-dev@lists.fd.io" , "Neale >> Ranns (nranns)" >> Subject: RE: not_last parameter of ip_add_del_route from ip.api >> >> Adding Neale for further comment, but I believe it’s a FIB 1.0 historical >> artifact which has no obvious reason to exist at this point. >> >> Thanks… Dave >> >> From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On >> Behalf Of Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) >> Sent: Wednesday, October 18, 2017 5:59 AM >> To: vpp-dev@lists.fd.io >> Subject: [vpp-dev] not_last parameter of ip_add_del_route from ip.api >> >> Hi, >> >> while working on adding MPLS support to HC, >> I noticed that ‘not_last’ param of ip_add_del_route >> is ignored by the message handler in ip_api.c: >> https://gerrit.fd.io/r/#/c/8826/ >> >> Could it be removed or I missed something? >> >> Regards, >> Marek >> > ___ > vpp-dev mailing list > vpp-dev@lists.fd.io > https://lists.fd.io/mailman/listinfo/vpp-dev signature.asc Description: Message signed with OpenPGP ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] not_last parameter of ip_add_del_route from ip.api
Hi Marek, It can be removed. /neale From: "Dave Barach (dbarach)" Date: Wednesday, 18 October 2017 at 13:30 To: "Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco)" , "vpp-dev@lists.fd.io" , "Neale Ranns (nranns)" Subject: RE: not_last parameter of ip_add_del_route from ip.api Adding Neale for further comment, but I believe it’s a FIB 1.0 historical artifact which has no obvious reason to exist at this point. Thanks… Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) Sent: Wednesday, October 18, 2017 5:59 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] not_last parameter of ip_add_del_route from ip.api Hi, while working on adding MPLS support to HC, I noticed that ‘not_last’ param of ip_add_del_route is ignored by the message handler in ip_api.c: https://gerrit.fd.io/r/#/c/8826/ Could it be removed or I missed something? Regards, Marek ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] not_last parameter of ip_add_del_route from ip.api
Adding Neale for further comment, but I believe it's a FIB 1.0 historical artifact which has no obvious reason to exist at this point. Thanks... Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) Sent: Wednesday, October 18, 2017 5:59 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] not_last parameter of ip_add_del_route from ip.api Hi, while working on adding MPLS support to HC, I noticed that 'not_last' param of ip_add_del_route is ignored by the message handler in ip_api.c: https://gerrit.fd.io/r/#/c/8826/ Could it be removed or I missed something? Regards, Marek ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
[vpp-dev] not_last parameter of ip_add_del_route from ip.api
Hi, while working on adding MPLS support to HC, I noticed that 'not_last' param of ip_add_del_route is ignored by the message handler in ip_api.c: https://gerrit.fd.io/r/#/c/8826/ Could it be removed or I missed something? Regards, Marek ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
