Re: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized
OK, thanks. I must have just missed it... -Steve From: Yichen Wang (yicwang) Sent: Friday, September 25, 2020 4:09 PM To: Heckman, Steve ; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized You need this: https://gerrit.fd.io/r/c/vpp/+/29084, and merged in stable/2009 already. Regards, Yichen External (yicw...@cisco.com<mailto:yicw...@cisco.com>) Report This Email<https://shared.outlook.inky.com/report?id=Y29tbXNjb3BlL3N0ZXZlLmhlY2ttYW5AY29tbXNjb3BlLmNvbS9iMGE1MDlmMGY0NjY5NTQ3MjQwMGZkMmRmZDM0ZDcxNy8xNjAxMDY0NTg4Ljc3#key=825100f1fa719c46237f0cc0fcca5363> FAQ<https://www.inky.com/banner-faq/> Protection by INKY<https://www.inky.com> You need this: https://gerrit.fd.io/r/c/vpp/+/29084<https://secure-web.cisco.com/1ojF4qPTcFtND1ZWoENtU1KYHwV82OK9ABUZtPisdPy5G8bsO6l_rVNMPbC5gH55LREkFvH58yx1DMI287t0s4EUCJ2RGgsO35wZUUC-Sqc8ADEH12mgyjNGF81mzW8Ra-Qh9izCSPBM8Ba-M08WXChCCR0OKwiQuIbZ2iV7_OdCrWGqnSfIm_va80J6YEbyMckBHe6lls6NQ-3YZ_NdszURelAR3PRbUzq_nntUTqgO9dwkNKr_rS67V_eoj6kRDgW8FBIIjgItc9d9FvHZvLghGbcqruEL2dsNqkMQfktC_rPSprVgHhgqnEcefPulU/https%3A%2F%2Fgerrit.fd.io%2Fr%2Fc%2Fvpp%2F%2B%2F29084>, and merged in stable/2009 already. Regards, Yichen From: on behalf of "Heckman, Steve" Date: Friday, September 25, 2020 at 1:04 PM To: "vpp-dev@lists.fd.io" Subject: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized I had been building in the master branch fine for a while. We need 20.09, so I saw that the branch was available and checked it out. I ran onto this building on Ubuntu Focal (20.04): $ git fetch remote: Enumerating objects: 60, done. remote: Counting objects: 100% (55/55), done. remote: Compressing objects: 100% (28/28), done. remote: Total 30 (delta 26), reused 6 (delta 2), pack-reused 0 Unpacking objects: 100% (30/30), 3.05 KiB | 283.00 KiB/s, done. From https://github.com/FDio/vpp 561ae5d17..277d402be master -> origin/master df143bf70..a26b40af9 stable/2009 -> origin/stable/2009 $ make pkg-deb make[1]: Entering directory '/home/labuser/Development/git/vpp/build-root' Arch for platform 'vpp' is native Finding source for external Makefile fragment found in /home/labuser/Development/git/vpp/build-data/packages/external.mk Source found in /home/labuser/Development/git/vpp/build Arch for platform 'vpp' is native Finding source for vpp Makefile fragment found in /home/labuser/Development/git/vpp/build-data/packages/vpp.mk Source found in /home/labuser/Development/git/vpp/src Configuring external: nothing to do Building external: nothing to do Installing external: nothing to do Configuring vpp: nothing to do Building vpp in /home/labuser/Development/git/vpp/build-root/build-vpp-native/vpp [11/18] Building C object plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o FAILED: plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o ccache /usr/lib/ccache/gcc-9 -DHAVE_FCNTL64 -DHAVE_GETCPU -DHAVE_MEMFD_CREATE -Dwireguard_plugin_EXPORTS -I/home/labuser/Development/git/vpp/src -I. -Iinclude -I/home/labuser/Development/git/vpp/src/plugins -Iplugins -Wno-address-of-packed-member -g -fPIC -Werror -Wall -march=corei7 -mtune=corei7-avx -O2 -fstack-protector -DFORTIFY_SOURCE=2 -fno-common -fPIC -MD -MT plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o -MF plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o.d -o plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o -c /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c: In function 'wg_handshake_handoff_fn': /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized in this function [-Werror=maybe-uninitialized] 112 |t->peer = peeri; |^~~ /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:82:15: note: 'peeri' was declared here 82 | index_t peeri; | ^ cc1: all warnings being treated as errors [12/18] Linking C shared library lib/libvnet.so.20.09 ninja: build stopped: subcommand failed. make[1]: *** [Makefile:693: vpp-build] Error 1 make[1]: Leaving directory '/home/labuser/Development/git/vpp/build-root' make: *** [Makefile:560: pkg-deb] Error 2 Anyone else see that? Thanks, Steve Heckman Distinguished Software Engineer Commscope, Inc. Lowell, Ma -=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized
You need this: https://gerrit.fd.io/r/c/vpp/+/29084, and merged in stable/2009 already. Regards, Yichen From: on behalf of "Heckman, Steve" Date: Friday, September 25, 2020 at 1:04 PM To: "vpp-dev@lists.fd.io" Subject: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized I had been building in the master branch fine for a while. We need 20.09, so I saw that the branch was available and checked it out. I ran onto this building on Ubuntu Focal (20.04): $ git fetch remote: Enumerating objects: 60, done. remote: Counting objects: 100% (55/55), done. remote: Compressing objects: 100% (28/28), done. remote: Total 30 (delta 26), reused 6 (delta 2), pack-reused 0 Unpacking objects: 100% (30/30), 3.05 KiB | 283.00 KiB/s, done. From https://github.com/FDio/vpp 561ae5d17..277d402be master -> origin/master df143bf70..a26b40af9 stable/2009 -> origin/stable/2009 $ make pkg-deb make[1]: Entering directory '/home/labuser/Development/git/vpp/build-root' Arch for platform 'vpp' is native Finding source for external Makefile fragment found in /home/labuser/Development/git/vpp/build-data/packages/external.mk Source found in /home/labuser/Development/git/vpp/build Arch for platform 'vpp' is native Finding source for vpp Makefile fragment found in /home/labuser/Development/git/vpp/build-data/packages/vpp.mk Source found in /home/labuser/Development/git/vpp/src Configuring external: nothing to do Building external: nothing to do Installing external: nothing to do Configuring vpp: nothing to do Building vpp in /home/labuser/Development/git/vpp/build-root/build-vpp-native/vpp [11/18] Building C object plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o FAILED: plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o ccache /usr/lib/ccache/gcc-9 -DHAVE_FCNTL64 -DHAVE_GETCPU -DHAVE_MEMFD_CREATE -Dwireguard_plugin_EXPORTS -I/home/labuser/Development/git/vpp/src -I. -Iinclude -I/home/labuser/Development/git/vpp/src/plugins -Iplugins -Wno-address-of-packed-member -g -fPIC -Werror -Wall -march=corei7 -mtune=corei7-avx -O2 -fstack-protector -DFORTIFY_SOURCE=2 -fno-common -fPIC -MD -MT plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o -MF plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o.d -o plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o -c /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c: In function 'wg_handshake_handoff_fn': /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized in this function [-Werror=maybe-uninitialized] 112 |t->peer = peeri; |^~~ /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:82:15: note: 'peeri' was declared here 82 | index_t peeri; | ^ cc1: all warnings being treated as errors [12/18] Linking C shared library lib/libvnet.so.20.09 ninja: build stopped: subcommand failed. make[1]: *** [Makefile:693: vpp-build] Error 1 make[1]: Leaving directory '/home/labuser/Development/git/vpp/build-root' make: *** [Makefile:560: pkg-deb] Error 2 Anyone else see that? Thanks, Steve Heckman Distinguished Software Engineer Commscope, Inc. Lowell, Ma -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#17531): https://lists.fd.io/g/vpp-dev/message/17531 Mute This Topic: https://lists.fd.io/mt/77124338/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized
I had been building in the master branch fine for a while. We need 20.09, so I saw that the branch was available and checked it out. I ran onto this building on Ubuntu Focal (20.04): $ git fetch remote: Enumerating objects: 60, done. remote: Counting objects: 100% (55/55), done. remote: Compressing objects: 100% (28/28), done. remote: Total 30 (delta 26), reused 6 (delta 2), pack-reused 0 Unpacking objects: 100% (30/30), 3.05 KiB | 283.00 KiB/s, done. >From https://github.com/FDio/vpp 561ae5d17..277d402be master -> origin/master df143bf70..a26b40af9 stable/2009 -> origin/stable/2009 $ make pkg-deb make[1]: Entering directory '/home/labuser/Development/git/vpp/build-root' Arch for platform 'vpp' is native Finding source for external Makefile fragment found in /home/labuser/Development/git/vpp/build-data/packages/external.mk Source found in /home/labuser/Development/git/vpp/build Arch for platform 'vpp' is native Finding source for vpp Makefile fragment found in /home/labuser/Development/git/vpp/build-data/packages/vpp.mk Source found in /home/labuser/Development/git/vpp/src Configuring external: nothing to do Building external: nothing to do Installing external: nothing to do Configuring vpp: nothing to do Building vpp in /home/labuser/Development/git/vpp/build-root/build-vpp-native/vpp [11/18] Building C object plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o FAILED: plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o ccache /usr/lib/ccache/gcc-9 -DHAVE_FCNTL64 -DHAVE_GETCPU -DHAVE_MEMFD_CREATE -Dwireguard_plugin_EXPORTS -I/home/labuser/Development/git/vpp/src -I. -Iinclude -I/home/labuser/Development/git/vpp/src/plugins -Iplugins -Wno-address-of-packed-member -g -fPIC -Werror -Wall -march=corei7 -mtune=corei7-avx -O2 -fstack-protector -DFORTIFY_SOURCE=2 -fno-common -fPIC -MD -MT plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o -MF plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o.d -o plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o -c /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c: In function 'wg_handshake_handoff_fn': /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized in this function [-Werror=maybe-uninitialized] 112 |t->peer = peeri; |^~~ /home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:82:15: note: 'peeri' was declared here 82 | index_t peeri; | ^ cc1: all warnings being treated as errors [12/18] Linking C shared library lib/libvnet.so.20.09 ninja: build stopped: subcommand failed. make[1]: *** [Makefile:693: vpp-build] Error 1 make[1]: Leaving directory '/home/labuser/Development/git/vpp/build-root' make: *** [Makefile:560: pkg-deb] Error 2 Anyone else see that? Thanks, Steve Heckman Distinguished Software Engineer Commscope, Inc. Lowell, Ma -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#17530): https://lists.fd.io/g/vpp-dev/message/17530 Mute This Topic: https://lists.fd.io/mt/77124338/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
