Re: [Warzone-dev] [Warzone 2100 Trac] #605: You are asking too much power assert failure
#605: You are asking too much power assert failure
-+--
Reporter: Per | Owner: gerard_
Type: defect | Status: new
Priority: blocker | Milestone: 2.3
Component: Engine: Resource Management |Version: svn/trunk
Keywords: power| Operating_system: All/Non-Specific
Blockedby: | Blocking:
-+--
Comment(by toy):
Replying to [comment:1 Per]:
Also see ticket:629
I might be experiencing a similar problem:
{{{
never |12:49:29: [proj_checkBurnDamage] Burn damage of 13 to object
161968, player 0
attack |12:49:29: [structureDamage] structure 161968, body 243, armour
20, damage: 13
attack |12:49:29: [objDamage] objDamage(161968): body 243 armour 20
damage: 13
error |12:49:29: [usePower] not enough power
error |12:49:29: [usePower] Assert in Warzone:
/Users/toyl/warzone/macosx/../src/power.c:156
(asPower[player].currentPower = quantity), last script event: 'everySec'
/Users/toyl/warzone/macosx/../src/power.c:156: failed assertion
`asPower[player].currentPower = quantity'
Program received signal SIGABRT, Aborted.
0x96fa9e42 in __kill ()
(gdb) bt
#0 0x96fa9e42 in __kill ()
#1 0x96fa9e34 in kill$UNIX2003 ()
#2 0x9701c23a in raise ()
#3 0x97028679 in abort ()
#4 0x002a90dd in __eprintf (string=0x0, expression=0x0, line=0,
filename=0x0) at /var/tmp/gcc/gcc-5493~1/src/gcc/libgcc2.c:1838
#5 0x0016e2fc in usePower (player=0, quantity=450) at
/Users/toyl/warzone/macosx/../src/power.c:156
#6 0x0015775a in recvResearch () at
/Users/toyl/warzone/macosx/../src/multiplay.c:824
#7 0x0015730b in recvMessage () at
/Users/toyl/warzone/macosx/../src/multiplay.c:669
#8 0x00156550 in multiPlayerLoop () at
/Users/toyl/warzone/macosx/../src/multiplay.c:262
#9 0x0011fb9d in gameLoop () at
/Users/toyl/warzone/macosx/../src/loop.c:264
#10 0x0012270f in runGameLoop () at
/Users/toyl/warzone/macosx/../src/main.c:654
#11 0x00122c9f in mainLoop () at
/Users/toyl/warzone/macosx/../src/main.c:842
#12 0x0012354b in SDL_main (argc=1, argv=0x130e450) at
/Users/toyl/warzone/macosx/../src/main.c:1077
#13 0x002a8dbd in -[SDLMain applicationDidFinishLaunching:]
(self=0x132b6b0, _cmd=0x9658c944, note=0x131d290) at
/Users/toyl/warzone/macosx/external/SDL/src/main/macosx/SDLMain.m:302
}}}
--
Ticket URL: http://developer.wz2100.net/ticket/605#comment:2
Warzone 2100 Trac http://developer.wz2100.net/
The Warzone 2100 Resurrection Project
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] [Warzone 2100 Trac] #605: You are asking too much power assert failure
#605: You are asking too much power assert failure
-+--
Reporter: Per | Owner: gerard_
Type: defect | Status: new
Priority: blocker | Milestone: 2.3
Component: Engine: Resource Management |Version: svn/trunk
Keywords: power| Operating_system: All/Non-Specific
Blockedby: | Blocking:
-+--
Comment(by toy):
Replying to [comment:2 toy]:
Replying to [comment:1 Per]:
Also see ticket:629
I might be experiencing a similar problem:
An ok fix?
{{{
Index: src/multiplay.c
===
--- src/multiplay.c (revision 7892)
+++ src/multiplay.c (working copy)
@@ -821,7 +821,10 @@
// Take off the power if available
pResearch = asResearch + index;
- usePower(player, pResearch-researchPower);
+ if(checkPower(player, pResearch-researchPower))
+ {
+ usePower(player, pResearch-researchPower);
+ }
}
// Update allies research accordingly
}}}
--
Ticket URL: http://developer.wz2100.net/ticket/605#comment:3
Warzone 2100 Trac http://developer.wz2100.net/
The Warzone 2100 Resurrection Project
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] [Warzone 2100 Trac] #688: Mod loading patch!
#688: Mod loading patch! ---+ Reporter: Zarel | Owner: Zarel Type: defect | Status: accepted Priority: blocker| Milestone: 2.2.2 Component: Engine: other |Version: svn/trunk Keywords: mods | Operating_system: All/Non-Specific Blockedby: | Blocking: ---+ Comment(by Buginator): Replying to [comment:2 Per]: IIRC the reason we removed autoload was that it generated lots of bogus bug reports when people forgot to mention (to other players, and in bug reports) that they played with them in online games. Before we re-enable this functionality, we need to prevent players from being able to join a game with the wrong mods, and add the list of mods used to the crash dump report. IMHO. We also need a way to check it is the same mod, so perhaps some CRC check or something along those lines, and we should transfer the mod like we do maps, in case the person don't got it. -- Ticket URL: http://developer.wz2100.net/ticket/688#comment:6 Warzone 2100 Trac http://developer.wz2100.net/ The Warzone 2100 Resurrection Project ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] [Warzone 2100 Trac] #605: You are asking too much power assert failure
#605: You are asking too much power assert failure -+-- Reporter: Per | Owner: gerard_ Type: defect | Status: new Priority: blocker | Milestone: 2.3 Component: Engine: Resource Management |Version: svn/trunk Keywords: power| Operating_system: All/Non-Specific Blockedby: | Blocking: -+-- Comment(by toy): Replying to [comment:4 Zarel]: Erm, no, that's completely the wrong way to go about it. usePower() should be rewritten not to assert when too much power is being asked for. Why? What's checkPower() written for then? Sorry, I don't know how all the stats should be kept... but the comment // Take off the power if available kinda suggest that it's ok to not take power if it's not available (i.e. if it doesn't pass checkPower()). -- Ticket URL: http://developer.wz2100.net/ticket/605#comment:5 Warzone 2100 Trac http://developer.wz2100.net/ The Warzone 2100 Resurrection Project ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
[Warzone-dev] Just a few comments about a few commits
Revision: 7842
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7842view=rev
Author: zarelsl
Date: 2009-07-13 21:10:49 + (Mon, 13 Jul 2009)
2.2: Fix possible buffer overflow in missionFlyTransportersIn and
getLandingX/Y.
How does this fix anything?
These should be asserts (so we can find the real cause), and this code
fragment in getLandingX() and getLandingY() is just wrong:
if ((unsigned int) iPlayer 8)
{
iPlayer = 8;
}
You can't make that assumption, and you are possibly introducing more
bugs with that.
Revision: 7887
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7887view=rev
Author: zarelsl
Date: 2009-07-19 22:26:54 + (Sun, 19 Jul 2009)
2.2: Stop rotation when Continue is pressed after winning a
multiplayer/skirmish game.
IIRC, the whole reason behind this, was so you can't 'continue' the
game as normal, ie, it is mainly to fire the fireworks, to show you,
you won, or lost. This could introduce more bugs, since your screwing
with the original design, and you haven't modified any of the scripts
for the win/loss stuff.
Which means, that in the least, I would add a info(Game has ended),
or perhaps a addDumpInfo(Game has ended), so we can weed out crash
reports when people continue after a win/loss.
Revision: 7891
http://warzone2100.svn.sourceforge.net/warzone2100/?rev=7891view=rev
Author: zarelsl
Date: 2009-07-22 22:12:41 + (Wed, 22 Jul 2009)
Index terrain textures (~68 MB - ~22 MB); idea suggested by i-NoD.
... I thought any big data changes should be brought to the attention
of the ML for comments. True, in this case, since most everyone is
away, it wouldn't have made a difference, but it would have been nice.
I also don't think this was required per se, perhaps when we would
have branched 2.3...
This is just the commits that caught my attention so far...
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev
