Re: [Warzone-dev] r514 - /trunk/win32/warzone2100.rc

2006-12-02 Thread Dennis Schridde 
Am Freitag, 1. Dezember 2006 22:18 schrieb Giel van Schijndel:
 Giel van Schijndel schreef:
  Dennis Schridde schreef:
  Author: devurandom
  Date: Fri Dec  1 17:57:52 2006
  New Revision: 514
 
  URL: http://svn.gna.org/viewcvs/warzone?rev=514view=rev
  Log:
  Revised warzone2100.rc with help from MSVC.
 
  Modified:
  trunk/win32/warzone2100.rc   (contents, props changed)
 
  All very nice, except for one tiny detail. The fact that you changed `1
  VERSIONINFO' into `VS_VERSION_INFO VERSIONINFO' causes the version
  information to simply disappear (icon is still displayed, the version
  info however isn't displayed in the properties window from the
  executable anymore). If I simply change that line back (into `1
  VERSIONINFO' that is) it works out well. I'm guessing this is because
  VS_VERSION_INFO is some kind of MS preprocessor macro which isn't
  defined in windres (MinGW's resource compiler). The change of `2 ICON'
  to `1 ICON' might have to be reverted as well if VERSIONINFO is
  reverted, however I didn't do so and it did work out well.

 Oh and forgot to mention that these changes have some funny results as
 well: -BLOCK 040904B0
 +BLOCK 040704b0
 and:
 -VALUE Translation, 0x0409, 0x04B0
 +VALUE Translation, 0x0407, 0x04b0

 Number 0x0407 presents German, so this just changed the language to
 German. (0x0409 the original represents English). The BLOCK part is just
 a concatenation of the TRANSLATION part.

 So I suggest the attached patch to fix these problems.
Fixed in r516.


pgpqVJadTf1xv.pgp
Description: PGP signature
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev

Re: [Warzone-dev] r514 - /trunk/win32/warzone2100.rc

2006-12-01 Thread Giel van Schijndel 
Giel van Schijndel schreef:
 Dennis Schridde schreef:
   
 Author: devurandom
 Date: Fri Dec  1 17:57:52 2006
 New Revision: 514

 URL: http://svn.gna.org/viewcvs/warzone?rev=514view=rev
 Log:
 Revised warzone2100.rc with help from MSVC.

 Modified:
 trunk/win32/warzone2100.rc   (contents, props changed)
 
 All very nice, except for one tiny detail. The fact that you changed `1
 VERSIONINFO' into `VS_VERSION_INFO VERSIONINFO' causes the version
 information to simply disappear (icon is still displayed, the version
 info however isn't displayed in the properties window from the
 executable anymore). If I simply change that line back (into `1
 VERSIONINFO' that is) it works out well. I'm guessing this is because
 VS_VERSION_INFO is some kind of MS preprocessor macro which isn't
 defined in windres (MinGW's resource compiler). The change of `2 ICON'
 to `1 ICON' might have to be reverted as well if VERSIONINFO is
 reverted, however I didn't do so and it did work out well.
   
Oh and forgot to mention that these changes have some funny results as well:
-BLOCK 040904B0
+BLOCK 040704b0
and:
-VALUE Translation, 0x0409, 0x04B0
+VALUE Translation, 0x0407, 0x04b0

Number 0x0407 presents German, so this just changed the language to
German. (0x0409 the original represents English). The BLOCK part is just
a concatenation of the TRANSLATION part.

So I suggest the attached patch to fix these problems.

--
Giel
Index: win32/warzone2100.rc
===
--- win32/warzone2100.rc(revision 514)
+++ win32/warzone2100.rc(working copy)
@@ -3,7 +3,7 @@
 // Version
 //
 
-VS_VERSION_INFO VERSIONINFO
+1 VERSIONINFO
  FILEVERSION 9,9,9,9
  PRODUCTVERSION 9,9,9,9
  FILEFLAGSMASK 0x0L
@@ -18,7 +18,7 @@
 BEGIN
BLOCK StringFileInfo
BEGIN
-   BLOCK 040704b0
+   BLOCK 040904b0
BEGIN
VALUE CompanyName, Warzone Resurrection Project
VALUE FileDescription, Warzone 2100
@@ -32,7 +32,7 @@
END
BLOCK VarFileInfo
BEGIN
-   VALUE Translation, 0x0407, 0x04b0
+   VALUE Translation, 0x0409, 0x04b0
END
 END
 

Property changes on: win32\warzone2100.rc
___
Name: svn:mime-type
   + text/plain



signature.asc
Description: OpenPGP digital signature
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev