Re: [warzone2100-dev] [Warzone2100-commits] SF.net SVN: warzone2100:[11671] trunk/lib/ivis_common/tex.h

2010-09-16 Thread Per Inge Mathisen
On Wed, Sep 15, 2010 at 9:08 PM,  muggen...@users.sourceforge.net wrote:
 Log Message:
 ---
 Replace #ifdef(APPLE) #include $path/gl.h sections with SDL_opengl.h 
 which handles this already

Please do not mess around too much with SDL related stuff, if you do
not strictly need to, since it breaks Qt branch.

  - Per

___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev


Re: [warzone2100-dev] [Warzone2100-commits] SF.net SVN: warzone2100:[11671] trunk/lib/ivis_common/tex.h

2010-09-16 Thread Giel van Schijndel
On Thu, Sep 16, 2010 at 09:51:38AM +0200, Per Inge Mathisen wrote:
 On Wed, Sep 15, 2010 at 9:08 PM,  muggen...@users.sourceforge.net wrote:
 Log Message:
 ---
 Replace #ifdef(APPLE) #include $path/gl.h sections with SDL_opengl.h 
 which handles this already
 
 Please do not mess around too much with SDL related stuff, if you do
 not strictly need to, since it breaks Qt branch.

Right, understood.  The reason for that ^^ change was to get rid of the
#ifdef APPLE-stuff when including gl.h and glu.h.  This is already
dealt with by SDL_opengl.h, thus my reason for using that header.

Considering that most places we use SDL_opengl.h we only use it to
properly include gl.h and glu.h we could probably take that part
from SDL_opengl.h (which is independent of SDL) and move that into a
wrapper header in lib/framework/ or lib/ivis_opengl/.  That would
additionally make porting to GLESv2 (OpenGL ES 2.0) slightly easier by
requiring the addition of preprocessor conditionals to only that header.

How would you feel about that approach?  I'm reasonably sure it will
even reduce the Qt branch's breakability with respect to the GL/SDL
combination.

-- 
Giel
--
There are two major products that come out of Berkeley: LSD and UNIX.
 We don't believe this to be a coincidence.
  -- Jeremy S. Anderson


signature.asc
Description: Digital signature
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev