Re: [Warzone2100-project] [Warzone2100-commits] [Warzone2100/warzone2100] 3e48f5: Hideous indeed.
On Tue, Jul 28, 2015 at 12:13:37AM +0200, Kreuvf wrote: > > Yes, I _could_, but I rather look at commits, because the commit message > sparked > my interest, not because it puzzled me. > > > But, you mean, you rather me type something like... > > "We don't want negative players, WZ has enough of them as it is."? ;) > > > > Making it say "Fix issue where player value could be negative" is > > basically the same thing. > > I prefer "Fix issue where player value could be negative". I'm with Kreuf here. The summary line should describe what the commit does. Clever stuff can go in the commit msg body. Having to look at the code to decipher the meaning is Fail. S. -- Stephen Swaney sswa...@centurytel.net 231-313-2492skype: sswaney (GMT-4) -- ___ Warzone2100-project mailing list Warzone2100-project@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/warzone2100-project
Re: [Warzone2100-project] [Warzone2100-commits] [Warzone2100/warzone2100] 3e48f5: Hideous indeed.
On 07/27/2015 04:14 AM, vexed wrote: > On Sun, Jul 26, 2015 at 2:32 PM, Kreuvf wrote: >> On 07/26/2015 04:27 AM, vexed wrote: >>> >>> Log Message: >>> --- >>> Hideous indeed. >>> Bad things happen when player < 6. >> >> Is this a case of https://xkcd.com/1296/? Please be more descriptive in your >> commit messages, there are people who actually read them :) >> >> Best regards >> - Kreuvf > > That *was* being descriptive though... if player's value was less than > 6, then, we spam errors. > You could also look at the commit in question, and see that all that > was removed was, "- 6", then think, yeah, I understand. Yes, I _could_, but I rather look at commits, because the commit message sparked my interest, not because it puzzled me. > But, you mean, you rather me type something like... > "We don't want negative players, WZ has enough of them as it is."? ;) > > Making it say "Fix issue where player value could be negative" is > basically the same thing. I prefer "Fix issue where player value could be negative". Best regards - Kreuvf signature.asc Description: OpenPGP digital signature -- ___ Warzone2100-project mailing list Warzone2100-project@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/warzone2100-project
Re: [Warzone2100-project] [Warzone2100-commits] [Warzone2100/warzone2100] 3e48f5: Hideous indeed.
On Sun, Jul 26, 2015 at 2:32 PM, Kreuvf wrote: > On 07/26/2015 04:27 AM, vexed wrote: >> >> Log Message: >> --- >> Hideous indeed. >> Bad things happen when player < 6. > > Is this a case of https://xkcd.com/1296/? Please be more descriptive in your > commit messages, there are people who actually read them :) > > Best regards > - Kreuvf That *was* being descriptive though... if player's value was less than 6, then, we spam errors. You could also look at the commit in question, and see that all that was removed was, "- 6", then think, yeah, I understand. But, you mean, you rather me type something like... "We don't want negative players, WZ has enough of them as it is."? ;) Making it say "Fix issue where player value could be negative" is basically the same thing. -- ___ Warzone2100-project mailing list Warzone2100-project@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/warzone2100-project
Re: [Warzone2100-project] [Warzone2100-commits] [Warzone2100/warzone2100] 3e48f5: Hideous indeed.
On 07/26/2015 04:27 AM, vexed wrote: > Branch: refs/heads/master > Home: https://github.com/Warzone2100/warzone2100 > Commit: 3e48f5526d1d2b2fe7ffdfb5f0e606214efb11fa > > https://github.com/Warzone2100/warzone2100/commit/3e48f5526d1d2b2fe7ffdfb5f0e606214efb11fa > Author: vexed > Date: 2015-07-25 (Sat, 25 Jul 2015) > > Changed paths: > M src/component.cpp > > Log Message: > --- > Hideous indeed. > Bad things happen when player < 6. Is this a case of https://xkcd.com/1296/? Please be more descriptive in your commit messages, there are people who actually read them :) Best regards - Kreuvf signature.asc Description: OpenPGP digital signature -- ___ Warzone2100-project mailing list Warzone2100-project@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/warzone2100-project
