[Wayland-bugs] [Bug 765181] [Wayland] After renaming a file/folder, caret navigation and cursor is broken

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765181

Christian Stadelmann  changed:

   What|Removed |Added

 CC||r...@robster.org.uk,
   ||wayland-bugs@lists.freedesk
   ||top.org
  Component|general |Backend: Wayland
Product|nautilus|gtk+
   Target Milestone|3.22|---

--- Comment #6 from Christian Stadelmann  ---
I finally managed to reproduce this issue in gnome-builder:
1. open any project
2. open any file
3. rename any file in your opened project
4. put your mouse cursor into the editor

What happens:
The mouse cursor "default" is still present. It still changes from "default"
arrow to "text" and back. The vertical blinking line, also called cursor, is
not visible any more when editing the file.
When selecting a new file in left panel and pressing "F2", nothing happens.
Caret navigation in left panel is broken.

What should happen:
blinking text cursor should not hide.
Breaking focus for keyboard shortcuts and caret navigation should not happen.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765477] Wayland: Popover(menus?) don't show keyboard focus

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765477

--- Comment #2 from Timm Bäder  ---

Very likely related, yes. Not sure if a direct dupe or not. That's more your
call than it's mine ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765565] Wayland: Inspector GtkLabel drag'n'drop crashes client

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765565

Jonas Ådahl  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Jonas Ådahl  ---
Attachment 326726 pushed as 1a4f000 - gdk/dnd: Don't use default display when
getting cursor

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765565] Wayland: Inspector GtkLabel drag'n'drop crashes client

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765565

Jonas Ådahl  changed:

   What|Removed |Added

 Attachment #326726|accepted-commit_now |committed
 status||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765565] Wayland: Inspector GtkLabel drag'n'drop crashes client

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765565

Matthias Clasen  changed:

   What|Removed |Added

 Attachment #326726|reviewed|accepted-commit_now
 status||

--- Comment #4 from Matthias Clasen  ---
Review of attachment 326726:

Looks right to me

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 92838] easy access to applications menu

2016-04-26 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=92838

Pekka Paalanen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Pekka Paalanen  ---
I think this won't be implemented in Weston per se. However, once we have
libweston out the door the first time, a third-party compositor built on
libweston could do it.

This is our policy upstream to not clutter weston with end-user features, but
we are going to offer libweston instead. It is a long-term plan.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 754716] [wayland] tooltips are placed outside of monitor

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=754716

--- Comment #3 from Jonas Ådahl  ---
It is not really solved. It just happens to be a code path in that arbitrarily
moves popup menus within screen as it sees fit. It's not the correct way, and
it won't work on any other compositor. The proper fix is in progress, and
depends on xdg_shell v6 and bug 756579.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

Matthias Clasen  changed:

   What|Removed |Added

 Attachment #326724|accepted-commit_now |committed
 status||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

Matthias Clasen  changed:

   What|Removed |Added

 Attachment #326725|accepted-commit_now |committed
 status||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

Matthias Clasen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||mcla...@redhat.com
 Resolution|--- |FIXED

--- Comment #9 from Matthias Clasen  ---
Attachment 326724 pushed as cb73bec - wayland: Clean up naming of
GdkWaylandDisplay pointers
Attachment 326725 pushed as 145b626 - wayland: Track orphaned dialogs per
display

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765477] Wayland: Popover(menus?) don't show keyboard focus

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765477

Olivier Fourdan  changed:

   What|Removed |Added

 CC||ofour...@redhat.com

--- Comment #1 from Olivier Fourdan  ---
Dupe of or simply related to bug 762756 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765565] Wayland: Inspector GtkLabel drag'n'drop crashes client

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765565

Carlos Garnacho  changed:

   What|Removed |Added

 CC||carl...@gnome.org
 Attachment #326726|none|reviewed
 status||

--- Comment #3 from Carlos Garnacho  ---
Comment on attachment 326726
  --> https://bugzilla.gnome.org/attachment.cgi?id=326726
gdk/dnd: Don't use default display when getting cursor

At least the common/x11/wayland bits look alright to me. The changes in
win32/quartz seem indeed correct and harmless, but like you I can't tell for
sure.

I'll refrain the a-c-n for now, but I'd be surprised if this broke anything.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

Carlos Garnacho  changed:

   What|Removed |Added

 CC||carl...@gnome.org
 Attachment #326725|none|accepted-commit_now
 status||

--- Comment #7 from Carlos Garnacho  ---
Comment on attachment 326725
  --> https://bugzilla.gnome.org/attachment.cgi?id=326725
wayland: Track orphaned dialogs per display

Makes sense.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 754716] [wayland] tooltips are placed outside of monitor

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=754716

--- Comment #2 from Christian Stadelmann  ---
The off-screen-popup placement issue is solved in current Gnome (3.20) and
wayland (1.10) releases. Any progress on the tooltip issue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 761651] [Wayland] glade previewer is resizing windows until it crashes gnome-shell

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=761651

Olivier Fourdan  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Olivier Fourdan  ---
Thanks, closing then (I see you cherry-picked it in branch gtk-3-20 as commit
115af7c)

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

--- Comment #6 from Timm Bäder  ---
(In reply to Olivier Fourdan from comment #1)
> Created attachment 326722 [details]
> C code
> 
> I am not very familiar with vala (I think I even disable vala at build time
> because of some issues in the past) so I tried with this C code instead
> (which I reckon should be similar)

Sorry, that test case resulted as part of a much more complex one in vala,
I should have written a small C sample. That would've been similar to your C
code, yes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765565] Wayland: Inspector GtkLabel drag'n'drop crashes client

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765565

--- Comment #2 from Jonas Ådahl  ---
Note that I have not build tested the win32 and quartz patches, as I have no
such systems to test build on.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765565] Wayland: Inspector GtkLabel drag'n'drop crashes client

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765565

--- Comment #1 from Jonas Ådahl  ---
Created attachment 326726
  --> https://bugzilla.gnome.org/attachment.cgi?id=326726=edit
gdk/dnd: Don't use default display when getting cursor

Always associate a drag context with a GdkDisplay and use that when
getting a cursor for a given action.

If we don't do this, dragging on a window that doesn't use the default
display will make us use cursors from the wrong display.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

--- Comment #5 from Jonas Ådahl  ---
Created attachment 326725
  --> https://bugzilla.gnome.org/attachment.cgi?id=326725=edit
wayland: Track orphaned dialogs per display

Don't track all orphaned dialogs globally, as mixing them up with each
other would in most cases trigger errors when we try to pass bogus
values to Wayland requests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

--- Comment #3 from Jonas Ådahl  ---
(In reply to Olivier Fourdan from comment #1)
> Created attachment 326722 [details]
> C code
> 
> I am not very familiar with vala (I think I even disable vala at build time
> because of some issues in the past) so I tried with this C code instead
> (which I reckon should be similar), when started with:
> 
>   GTK_DEBUG=interactive ./dialog
> 
> I get:
> 
>   (dialog:8492): Gdk-WARNING **: Error 22 (Invalid argument) dispatching to
> Wayland display.
> 
> Is that the same problem you have?

Yes indeed. I have a fix; one moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

--- Comment #4 from Jonas Ådahl  ---
Created attachment 326724
  --> https://bugzilla.gnome.org/attachment.cgi?id=326724=edit
wayland: Clean up naming of GdkWaylandDisplay pointers

The naming of pointers to GdkWaylandDisplay's were inconsistent.
Running the following commands in gtk+/gdk/wayland illustrate the
inconsistency:

$ grep -r '\' *.[ch] | wc -l
195
$ grep -r '\' *.[ch] | wc -l
81

This patch renames all occurrences of "wayland_display" to
"display_wayland". This is also consistent with naming in the X11
backend. A couple of whitespace changes were done as well in places
where the rename was already done, that added line breaks to long lines
that stood out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

--- Comment #2 from Olivier Fourdan  ---
mutter (rightfully) complains because it doesn't "know" that object:

(gnome-shell:7781): mutter-WARNING **: WL: unknown object (26), message
set_parent(?o)

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 765474] Wayland: Dialogs without transient parent crash the inspector

2016-04-26 Thread gtk+ 
https://bugzilla.gnome.org/show_bug.cgi?id=765474

Olivier Fourdan  changed:

   What|Removed |Added

 CC||ofour...@redhat.com

--- Comment #1 from Olivier Fourdan  ---
Created attachment 326722
  --> https://bugzilla.gnome.org/attachment.cgi?id=326722=edit
C code

I am not very familiar with vala (I think I even disable vala at build time
because of some issues in the past) so I tried with this C code instead (which
I reckon should be similar), when started with:

  GTK_DEBUG=interactive ./dialog

I get:

  (dialog:8492): Gdk-WARNING **: Error 22 (Invalid argument) dispatching to
Wayland display.

Is that the same problem you have?

If so, it's a protocol error:

[1238417.613] xdg_surface@26.configure(957, 547, array, 121)
[1238417.634]  -> xdg_surface@26.set_window_geometry(26, 23, 957, 547)
[1238417.650]  -> xdg_surface@26.ack_configure(121)
[1238417.657]  -> xdg_surface@28.set_parent(xdg_surface@26)
[1238417.666] wl_keyboard@22.modifiers(123, 64, 0, 0, 0)
[1238417.690] wl_keyboard@22.enter(123, wl_surface@20, array)
[1238417.706] wl_data_device@18.selection(nil)
[1238417.717] gtk_primary_selection_device@17.selection(nil)
[1238417.967] wl_display@1.error(wl_display@1, 1, "invalid arguments for
xdg_surface@28.set_parent")

(dialog:8595): Gdk-WARNING **: Error 22 (Invalid argument) dispatching to
Wayland display.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs