[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-16 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771112

--- Comment #12 from Michael Catanzaro  ---
(In reply to Kai Willadsen from comment #11)
> Pushing this issue on to applications by suggesting that they've been doing
> something unsupported this whole time is not a very reasonable position to
> take.

Stuff like this has been par for the course for GTK+ 3 thus far. It just needs
a docs update.

But see:
https://blog.gtk.org/2016/09/01/versioning-and-long-term-stability-promise-in-gtk/

TL;DR GTK+ 3.22 will be stable LTS, and breaking changes like this will no
longer be allowed in GTK+ 3... starting next week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771112] some applications windows to grow on startup (with CSD)

2016-09-16 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771112

Kai Willadsen  changed:

   What|Removed |Added

 CC||kai.willad...@gmail.com

--- Comment #11 from Kai Willadsen  ---
(In reply to Emmanuele Bassi (:ebassi) from comment #7)
> Querying the window size and then setting it with GtkWindow API is perfectly
> fine.
> 
> Querying the window size with GtkWidget API and then setting it with
> GtkWindow API, *or* querying the window size with GtkWindow API and then
> setting it with GtkWidget API, is *not* okay, and only worked up until now
> with server-side decorations only on X11.

In the current GtkWindow docs for gtk_window_get_size(), the second and fourth
notes directly contradict each other, and I'm pretty sure the first paragraph
is now also incorrect. I don't know what these other apps do, but Meld's
implementation here listens for configure-event and uses those sizes, which is
pretty much exactly what the first note there tells you to do.

Pushing this issue on to applications by suggesting that they've been doing
something unsupported this whole time is not a very reasonable position to
take.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771553] Shrinking window generates a black patch when gl is used

2016-09-16 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771553

--- Comment #1 from Gustavo Noronha (kov)  ---
Created attachment 335733
  --> https://bugzilla.gnome.org/attachment.cgi?id=335733=edit
Patch that works around or fixes the problem

This patch fixes the issue for me. I am not sure it is the best solution,
though, I'm uploading it in hopes someone more acquainted to the code can
propose or help me figure out the best solution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771553] New: Shrinking window generates a black patch when gl is used

2016-09-16 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771553

Bug ID: 771553
   Summary: Shrinking window generates a black patch when gl is
used
Classification: Platform
   Product: gtk+
   Version: 3.21.x
OS: Linux
Status: NEW
  Severity: normal
  Priority: Normal
 Component: Backend: Wayland
  Assignee: gtk-b...@gtk.org
  Reporter: g...@gnome.org
QA Contact: gtk-b...@gtk.org
CC: r...@robster.org.uk, wayland-bugs@lists.freedesktop.org
 GNOME version: ---

Created attachment 335732
  --> https://bugzilla.gnome.org/attachment.cgi?id=335732=edit
Screenshot showing the problem

I am not sure why this does not affect the GLArea widget. In the WebKitGTK+
test browser, when we use gdk_cairo_draw_from_gl to paint the final rendering
to GTK+, we get this weird behaviour.

My investigation points to the tracking of the opaque region. The opaque region
is properly set on the GdkWindowWayland, but never synced. When using the
glReadPixels codepath in WebKitGTK+, the opaque region is synced for every
frame.

The reason seems to be pending_commit is never true (except for a few early
frames), so the call to sync_opaque_region is never reached:

static void
on_frame_clock_after_paint (GdkFrameClock *clock,
GdkWindow *window)
{
  GdkWindowImplWayland *impl = GDK_WINDOW_IMPL_WAYLAND (window->impl);
  struct wl_callback *callback;

  if (!impl->pending_commit)
return;
…
  gdk_wayland_window_sync_margin (window);
  gdk_wayland_window_sync_opaque_region (window);
  gdk_wayland_window_sync_input_region (window);

The reason why pending_commit is never true is it is only updated when
current_paint.use_gl is not true:

static void
gdk_window_impl_wayland_end_paint (GdkWindow *window)
{
  GdkWindowImplWayland *impl = GDK_WINDOW_IMPL_WAYLAND (window->impl);
  cairo_rectangle_int_t rect;
  int i, n;

  if (!window->current_paint.use_gl &&
  !cairo_region_is_empty (window->current_paint.region))
{
…
  impl->pending_commit = TRUE;
}
}

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97828] wayland-scanner.pc.in: wayland_scanner variable does not prepend ${pc_sysrootdir}, potentially breaking cross-compilation

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97828

Joe Konno  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97828] wayland-scanner.pc.in: wayland_scanner variable does not prepend ${pc_sysrootdir}, potentially breaking cross-compilation

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97828

Joe Konno  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Joe Konno  ---
Arnaud's feedback was really good, thanks so much:

"""
I believe your patch is not right, as pq says the sysroot normally contains
the code compiled for the target, which might not be compatible with the
host.

I think the proper way to do this is to compile wayland for the host
separately, and use ${CHOST}-pkg-config instead of pkg-config to get the
wayland-scanner path. In practice you would call
x86_64-linux-gnu-pkg-config --variable=wayland_scanner. The
x86_64-linux-gnu-pkg-config utility will look for pkgconfig files in the
host sysroot, instead of the target sysroot, allowing this use case to work.

Unfortunately not many packages do this correctly...
"""

I'll go ahead and close this bug as invalid. Thanks again for the reviews and
feedback!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97828] wayland-scanner.pc.in: wayland_scanner variable does not prepend ${pc_sysrootdir}, potentially breaking cross-compilation

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97828

--- Comment #2 from Joe Konno  ---
Thanks for the feedback, Pekka. As stated on the mailing list, I'll reply once
I convince myself this is the right (or wrong) approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97771] Huion DWH69 not working with libinput 1.4.2 and xf86-input-libinput 0.19

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97771

--- Comment #36 from ngoo...@gmail.com ---
(In reply to Benjamin Tissoires from comment #28)
> (In reply to ngoonee from comment #26)
> > There's no #if LINUX_VERSION_CODE anywhere in the digimend-kernel-drivers-6
> > files, though, so I'm not sure what you're referring to.
> 
> File hid-uclogic.c, line 750:
> https://github.com/DIGImend/digimend-kernel-drivers/blob/master/hid-uclogic.
> c#L750

Right, I'm not sure why I assumed -6 was the latest. Cloned the repo and now it
builds (no changes needed). Much easier than recompiling the kernel, and same
effect from my testing (according to what has been requested so far in this bug
report).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97771] Huion DWH69 not working with libinput 1.4.2 and xf86-input-libinput 0.19

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97771

--- Comment #35 from ngoo...@gmail.com ---
(In reply to Benjamin Tissoires from comment #34)
> thanks for the logs.
> 
> That looks good to me. Buttons are handled in their own device, and the pen
> is not interfering. I'll let Peter check if there are some libinput errors

You're welcome. Did notice at various points in other testing (not logged here)
that you're right about the proximity never going 'off'. At some point (and I
couldn't reliably reproduce) this meant my mouse button was stuck 'down', and
until I unplugged the tablet I could not click on anything with my 'real'
mouse.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97771] Huion DWH69 not working with libinput 1.4.2 and xf86-input-libinput 0.19

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97771

--- Comment #34 from Benjamin Tissoires  ---
thanks for the logs.

That looks good to me. Buttons are handled in their own device, and the pen is
not interfering. I'll let Peter check if there are some libinput errors

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97771] Huion DWH69 not working with libinput 1.4.2 and xf86-input-libinput 0.19

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97771

--- Comment #33 from ngoo...@gmail.com ---
Created attachment 126579
  --> https://bugs.freedesktop.org/attachment.cgi?id=126579=edit
libinput-debug-events

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97771] Huion DWH69 not working with libinput 1.4.2 and xf86-input-libinput 0.19

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97771

--- Comment #32 from ngoo...@gmail.com ---
Created attachment 126578
  --> https://bugs.freedesktop.org/attachment.cgi?id=126578=edit
evemu-record output for Pad device

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97771] Huion DWH69 not working with libinput 1.4.2 and xf86-input-libinput 0.19

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97771

--- Comment #31 from ngoo...@gmail.com ---
Created attachment 126577
  --> https://bugs.freedesktop.org/attachment.cgi?id=126577=edit
evemu-record output for Pen device

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97771] Huion DWH69 not working with libinput 1.4.2 and xf86-input-libinput 0.19

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97771

--- Comment #30 from ngoo...@gmail.com ---
Once again for the record this is the actions I'm recording:-

1. Bringing pen into proximity
2. Pressing pen in to full pressure
3. Release pen but keeping it in proximity
4. Pressing the pen's buttons (nearer-to-nib followed by further-from-nib
5. Taking pen away from proximity
6. Pressing the 8 frame capacitive buttons (pen not in proximity)
7. Bringing pen into proximity and pressing the 8 frame capacitive buttons
again
8. Taking pen away from proximity

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 97771] Huion DWH69 not working with libinput 1.4.2 and xf86-input-libinput 0.19

2016-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97771

--- Comment #29 from ngoo...@gmail.com ---
(In reply to Peter Hutterer from comment #27)
> (In reply to ngoonee from comment #26)
> > Installing the patched kernel (and uninstalling xf86-input-evdev) means the
> > device stops working (in other words, doesn't work with 
> > xf86-input-libinput).
> 
> use libinput-debug-events first to make sure it works, no need to remove
> evdev or restart X

libinput error: libinput bug: Device 'PenTablet Keyboard' does not meet tablet
criteria. Ignoring this device.
libinput error: libinput bug: Device 'PenTablet System Control' does not meet
tablet criteria. Ignoring this device.
libinput error: libinput bug: Device 'PenTablet Consumer Control' does not meet
tablet criteria. Ignoring this device.
libinput error: libinput bug: Device 'PenTablet Mouse' does not meet tablet
criteria. Ignoring this device.
event16 DEVICE_ADDED PenTablet Pad seat0 default
group10 cap:P buttons:8 strips:0 rings:0 mode groups:1
event15 DEVICE_ADDED PenTablet Pen seat0 default
group10 cap:T  size 229.30/143.31mm

I assume this means the patch applies successfully at least?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 771516] wayland: Only 'moved-to-rect' if move_to_rect() was used

2016-09-16 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=771516

--- Comment #1 from Jonas Ådahl  ---
Created attachment 335677
  --> https://bugzilla.gnome.org/attachment.cgi?id=335677=edit
wayland: Only 'moved-to-rect' if move_to_rect() was used

Don't emit the 'moved-to-rect' signal if move_to_rect() was used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs