[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104828

--- Comment #15 from Daniel van Vugt  ---
(In reply to Hi-Angel from comment #14)

> libinput does have a detection code — otherwise how could it "remove"
> wobbling.

I think that's wrong. It doesn't detect wobbling. It _assumes_ from the
beginning that the touchpad is wobbly and only turns off hysteresis later,
after deciding that it's not wobbling.

The wobble "removal" is the hysteresis algorithm, which is ON by default. The
bug here is that the stillness detection algorithm has gone wrong and turned
hysteresis OFF too early.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104828

--- Comment #16 from Hi-Angel  ---
(In reply to Daniel van Vugt from comment #15)
> (In reply to Hi-Angel from comment #14)
> 
> > libinput does have a detection code — otherwise how could it "remove"
> > wobbling.
> 
> I think that's wrong. It doesn't detect wobbling. It _assumes_ from the
> beginning that the touchpad is wobbly and only turns off hysteresis later,
> after deciding that it's not wobbling.
> 
> The wobble "removal" is the hysteresis algorithm, which is ON by default.
> The bug here is that the stillness detection algorithm has gone wrong and
> turned hysteresis OFF too early.

Yeah, but the algorithm is the code of libinput that, basically, detects if
there's any motion that gotta get cancelled :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104828

--- Comment #14 from Hi-Angel  ---
(In reply to Daniel van Vugt from comment #10)
> (In reply to Hi-Angel from comment #9)
> > until a person just keeps the finger still on the touchpad (e.g.
> > tries to focus something), and then check if we see wobbling.
> 
> I think Peter probably considered that already and it sounds like that might
> be impossible. You can't ask the person "are you trying to keep your finger
> still?". You can only see what the touchpad reports, and the touchpad
> "wobbling" with a still finger looks the same as a non-wobbly touchpad with
> a wobbling finger :)

libinput does have a detection code — otherwise how could it "remove" wobbling.
Per my understanding it's detection of a bunch of micromovements — ones that
very quick and very close.

By "keeping finger still" I don't necessarily mean having it really still, I
rather opposing it to a very quick stroke across the touchpad, which, I'm
guessing, indeed might not wobble.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104828

--- Comment #13 from Daniel van Vugt  ---
Although the algorithm described in comment #12 is basically equivalent to
always having hysteresis ON with just a smaller radius.

Presently hysteresis feels like it's about 5mm, which I think might be the real
bug. A math error somewhere (since it's meant to be half a millimetre).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104828

--- Comment #12 from Daniel van Vugt  ---
Although to say anything is impossible is just asking to be proven wrong :)

One way you could have hysteresis disabled by default is to try and tell the
difference between hardware jitter and finger movement... If you see a lot of
1-2 unit movement that _cancels_itself_out_ (ie. goes up-down-up-down, or
left-right-left-right) and has a small overall radius of movement then you
could plausibly call that hardware jitter and decide to turn on hysteresis
later.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104828

--- Comment #11 from Daniel van Vugt  ---
Correction: Hysteresis is *enabled* by default already.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104828

--- Comment #10 from Daniel van Vugt  ---
(In reply to Hi-Angel from comment #9)

Hysteresis is disabled by default already.

> until a person just keeps the finger still on the touchpad (e.g.
> tries to focus something), and then check if we see wobbling.

I think Peter probably considered that already and it sounds like that might be
impossible. You can't ask the person "are you trying to keep your finger
still?". You can only see what the touchpad reports, and the touchpad
"wobbling" with a still finger looks the same as a non-wobbly touchpad with a
wobbling finger :)

>From what I understand this is why the current approach does and must enable
hysteresis first. And then disables it when it thinks there is no hardware
"wobble".

The only bug here is that the current approach is disabling hysteresis too soon
by accident (only waiting for 80ms of stillness whereas it should be something
like 100ms or a slightly different algorithm).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104828] Wobbly AlpsPS/2 ALPS DualPoint TouchPad

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104828

--- Comment #9 from Hi-Angel  ---
(In reply to Peter Hutterer from comment #6)
> no the touchpad is just terrible. it wobbles along for ages, then has one
> event frame that is delayed by enough to turn off the hysteresis. Looks like
> we need something smarter than our current approach.

How about reversing the approach: basically, waiting for some strokes, and if
wobbling is detected, assume touchpad needs hysteresis. Otherwise disable it.

I can imagine some modifications of this approach: for example, wait not a
stroke, but until a person just keeps the finger still on the touchpad (e.g.
tries to focus something), and then check if we see wobbling. Or, to exclude
broken a broken touchpad missing a frame, use a bit more alike patterns, and
see if at least one of them does wobble.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104939] Tablet tools without ABS_Z cause a crash when updating rotation

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104939

Peter Hutterer  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Peter Hutterer  ---
commit cbb4ec1e3e76b64ec53c25036976e0374aaf41de
Author: Peter Hutterer 
Date:   Mon Feb 5 09:11:42 2018 +1000

tablet: don't set rotation on a tool if we don't have ABS_Z

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104911] Fake BTN_TOOL_PEN on tablets that don't send it

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104911
Bug 104911 depends on bug 104939, which changed state.

Bug 104939 Summary: Tablet tools without ABS_Z cause a crash when updating 
rotation
https://bugs.freedesktop.org/show_bug.cgi?id=104939

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104990] XPS13 L322X touchpad laggy

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104990

--- Comment #2 from Daniel van Vugt  ---
Please clarify which version is laggy.

Above you mention "1.9.4-2" however on Launchpad it was said "1.9.4-2ubuntu1"
[https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1746740/comments/18]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104990] XPS13 L322X touchpad laggy

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104990

Daniel van Vugt  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 104990] XPS13 L322X touchpad laggy

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104990

Daniel van Vugt  changed:

   What|Removed |Added

Summary|touchpad laggy  |XPS13 L322X touchpad laggy

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 98770] kernel: Elantech 3320KD-3100 Touchpad behind [ASUS T300CHI DOCKING] Bluetooth not recognised

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98770

--- Comment #31 from er453r  ---
Added the log, most of it are pinching interactions.

And you where right, libinput debug-events indeed correctly show the gesture as
pinch, only no xorg app supports it.

I've looked how is pinch-to-zoom handled from the screen digitizer (which works
correctly in xorg apps - Chromimium for example) - but it only emits multiple
touch events, which are probably then interpreted by the apps as pinching
gesture.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 98770] kernel: Elantech 3320KD-3100 Touchpad behind [ASUS T300CHI DOCKING] Bluetooth not recognised

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98770

--- Comment #30 from er453r  ---
Created attachment 137235
  --> https://bugs.freedesktop.org/attachment.cgi?id=137235&action=edit
4.15 ketnel pinch interaction

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs