[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

Zbigniew Jedrzejewski-Szmek  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |FIXED

--- Comment #12 from Zbigniew Jedrzejewski-Szmek  ---
https://github.com/systemd/systemd/pull/8388 was merged. Please test.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

--- Comment #10 from quantumphoton...@gmail.com ---
Sorry for the confusion. The one with synaptics_intertouch=0 crashes, but the
other one doesn't.

$ sudo modprobe -r psmouse; sudo modprobe psmouse synaptics_intertouch=0
$ touchpad-edge-detector 108x61 /dev/input/event16
Touchpad SynPS/2 Synaptics TouchPad on /dev/input/event16
Move one finger around the touchpad to detect the actual edges
Kernel says:x [1268..5674], y [1098..4754]
Touchpad sends: x [1268..5675], y [1101..4792] 

Touchpad size as listed by the kernel: 100x53mm
User-specified touchpad size: 108x61mm
Calculated ranges: 4407/3691

Suggested udev rule:
# Dell Inspiron 3537
evdev:name:SynPS/2 Synaptics
TouchPad:dmi:bvnDellInc.:bvrA09:bd08/25/2016:svnDellInc.:pnInspiron3537:pvrA09:rvnDellInc.:rn:rvr:cvnDellInc.:ct8:cvrA09:*
 EVDEV_ABS_00=1268:5675:41
 EVDEV_ABS_01=1101:4792:61
 EVDEV_ABS_35=1268:5675:41
 EVDEV_ABS_36=1101:4792:61

---

$ sudo modprobe -r psmouse; sudo modprobe psmouse synaptics_intertouch=1
$ touchpad-edge-detector 108x61 /dev/input/event16
Touchpad Synaptics TM2382-001 on /dev/input/event16
Move one finger around the touchpad to detect the actual edges
Kernel says:x [0..2560], y [0..2048]
Touchpad sends: x [0..2560], y [0..2048] 

Touchpad size as listed by the kernel: 98x53mm
User-specified touchpad size: 108x61mm
Calculated ranges: 2560/2048

Suggested udev rule:
# Dell Inspiron 3537
evdev:name:Synaptics
TM2382-001:dmi:bvnDellInc.:bvrA09:bd08/25/2016:svnDellInc.:pnInspiron3537:pvrA09:rvnDellInc.:rn:rvr:cvnDellInc.:ct8:cvrA09:*
 EVDEV_ABS_00=0:2560:24
 EVDEV_ABS_01=0:2048:34
 EVDEV_ABS_35=0:2560:24
 EVDEV_ABS_36=0:2048:34

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

--- Comment #9 from Peter Hutterer  ---
the edge detector shows the device as Synaptics TM2382-001 but the evemu log
shows it as "SynPS/2 Synaptics TouchPad". did you update your kernel since that
you now have the RMI4 device?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

--- Comment #8 from quantumphoton...@gmail.com ---
Hi,
Apologies :). I didn't think the command would spit more output on Ctrl+C.


Touchpad size as listed by the kernel: 98x53mm
User-specified touchpad size: 108x61mm
Calculated ranges: 2560/2048

Suggested udev rule:
# Dell Inspiron 3537
evdev:name:Synaptics
TM2382-001:dmi:bvnDellInc.:bvrA09:bd08/25/2016:svnDellInc.:pnInspiron3537:pvrA09:rvnDellInc.:rn:rvr:cvnDellInc.:ct8:cvrA09:*
 EVDEV_ABS_00=0:2560:24
 EVDEV_ABS_01=0:2048:34
 EVDEV_ABS_35=0:2560:24
 EVDEV_ABS_36=0:2048:34

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

--- Comment #7 from Peter Hutterer  ---
I need the full output please, you cut off exactly the bits we need :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

--- Comment #6 from quantumphoton...@gmail.com ---
(In reply to Peter Hutterer from comment #4)
> Looks like a dupe of bug 105258. There's still a bug warning replaying this
> but it doesn't crash after 440d94be57.
> 
> > Physical Dimension of touchpad (the actual area, without including buttons)
> > Width = 10.8 cm
> > Height = 6.1 cm
> 
> please run the touchpad-edge-detector, this needs to be fixed in a hwdb
> entry.
> 

$ touchpad-edge-detector 108x61 /dev/input/event16
Touchpad Synaptics TM2382-001 on /dev/input/event16
Move one finger around the touchpad to detect the actual edges
Kernel says:x [0..2560], y [0..2048]
Touchpad sends: x [0..2560], y [0..2048]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

--- Comment #5 from Peter Hutterer  ---
This one fixes the bug warning:

commit 2ab233857d42d942eb322888e2d87ba3b7f7b264
Author: Peter Hutterer <>
Date:   Wed Mar 7 10:58:17 2018 +1000

 touchpad: handle a palm down in the tapped state

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

Peter Hutterer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||peter.hutte...@who-t.net

--- Comment #4 from Peter Hutterer  ---
Looks like a dupe of bug 105258. There's still a bug warning replaying this but
it doesn't crash after 440d94be57.

> Physical Dimension of touchpad (the actual area, without including buttons)
> Width = 10.8 cm
> Height = 6.1 cm

please run the touchpad-edge-detector, this needs to be fixed in a hwdb entry.

> For a newbie, how would I go about patching this issue? What steps do you 
> usually follow with the log and evemu log?

basically: 
in one terminal: sudo evemu-play evemu.log file
in the other terminal: sudo ./build/libinput-debug-events --enalbe-tap

hit enter for evemu-play, watch libinput crash, warn, or sail along smoothly.
If the former, run in gdb to get an idea of what the context is (if needed, in
this case it's easy enough).

Isolate the event sequence that triggers the crash (where needed/possible).
Then stare at the evemu log long enough until it's clear why the crash happens.
Write a test case for libinput, then keep failing that until the bug is fixed
or a goat needs to be sacrificed [1], whichever happens earlier.


[1] no animals were harmed in the making of this software

*** This bug has been marked as a duplicate of bug 105258 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

--- Comment #3 from quantumphoton...@gmail.com ---
I believe this commit adds the assertion -
01a633b6ebea514cc26bb00f2bf85789fe5409e3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

--- Comment #2 from quantumphoton...@gmail.com ---
For a newbie, how would I go about patching this issue? What steps do you
usually follow with the log and evemu log?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

--- Comment #1 from quantumphoton...@gmail.com ---
Created attachment 137830
  --> https://bugs.freedesktop.org/attachment.cgi?id=137830=edit
evemu log (during crash)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

quantumphoton...@gmail.com changed:

   What|Removed |Added

   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105370] Dragging the palm across touchpad crashes : Assertion `tp->tap.nfingers_down >= 1' failed.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105370

Bug ID: 105370
   Summary: Dragging the palm across touchpad crashes : Assertion
`tp->tap.nfingers_down >= 1' failed.
   Product: Wayland
   Version: unspecified
  Hardware: All
OS: Linux (All)
Status: NEW
  Severity: major
  Priority: medium
 Component: libinput
  Assignee: wayland-bugs@lists.freedesktop.org
  Reporter: quantumphoton...@gmail.com

Created attachment 137829
  --> https://bugs.freedesktop.org/attachment.cgi?id=137829=edit
Stacktrace of crash

I dragged my palm across the touchpad and X crashed. I have attached what X
printed as `err.log`. Simply stating,
`../libinput-1.10.1/src/evdev-mt-touchpad-tap.c:1028: tp_tap_handle_state:
Assertion `tp->tap.nfingers_down >= 1' failed`. 

The weird thing is, when I `modprobe psmouse synaptics_intertouch=1`, this
crash doesn't occur however weird I try dragging my palm across the touchpad.
But on unloading and `modprobe psmouse synaptics_intertouch=0` and then
dragging my palm across, this crash happens.

$ udevadm info /sys/class/input/event16
P: /devices/rmi4-00/input/input18/event16
N: input/event16
E: DEVNAME=/dev/input/event16
E: DEVPATH=/devices/rmi4-00/input/input18/event16
E: ID_BUS=rmi
E: ID_INPUT=1
E: ID_INPUT_HEIGHT_MM=53
E: ID_INPUT_TOUCHPAD=1
E: ID_INPUT_TOUCHPAD_INTEGRATION=internal
E: ID_INPUT_WIDTH_MM=98
E: ID_SERIAL=noserial
E: LIBINPUT_DEVICE_GROUP=1d/6cb/0:rmi4-00
E: MAJOR=13
E: MINOR=80
E: SUBSYSTEM=input
E: USEC_INITIALIZED=15414239

$ libinput --version
1.10.1

Vendor : Dell Inspiron 3537
$ cat /sys/class/dmi/id/modalias 
dmi:bvnDellInc.:bvrA09:bd08/25/2016:svnDellInc.:pnInspiron3537:pvrA09:rvnDellInc.:rn:rvr:cvnDellInc.:ct8:cvrA09:

Physical Dimension of touchpad (the actual area, without including buttons)
Width = 10.8 cm
Height = 6.1 cm

The touchpad has two physical buttons (L, R)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs