[libinput] AC_PROG_CXX missing in libinput/configure.ac

2014-03-29 Thread William Di Luigi
Currently in libinput/configure.ac there are these lines:

# Check for programs
AC_PROG_CC_C99

In order to make the configure phase of jhbuild work, they should become:

# Check for programs
AC_PROG_CC_C99
AC_PROG_CXX
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel


Re: [libinput] AC_PROG_CXX missing in libinput/configure.ac

2014-03-29 Thread Jonas Ådahl
On Sat, Mar 29, 2014 at 12:59:18PM +0100, William Di Luigi wrote:
 Currently in libinput/configure.ac there are these lines:
 
 # Check for programs
 AC_PROG_CC_C99
 
 In order to make the configure phase of jhbuild work, they should become:
 
 # Check for programs
 AC_PROG_CC_C99
 AC_PROG_CXX

AC_PROG_CXX should only be needed if tests are built, and its checked
only in that case here[0]. Is that not working for you?

[0] http://cgit.freedesktop.org/wayland/libinput/tree/configure.ac#n79


 ___
 wayland-devel mailing list
 wayland-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/wayland-devel

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel


Re: [libinput] AC_PROG_CXX missing in libinput/configure.ac

2014-03-29 Thread William Di Luigi
On Sat, Mar 29, 2014 at 1:59 PM, Jonas Ådahl jad...@gmail.com wrote:

 On Sat, Mar 29, 2014 at 12:59:18PM +0100, William Di Luigi wrote:
  Currently in libinput/configure.ac there are these lines:
 
  # Check for programs
  AC_PROG_CC_C99
 
  In order to make the configure phase of jhbuild work, they should become:
 
  # Check for programs
  AC_PROG_CC_C99
  AC_PROG_CXX

 AC_PROG_CXX should only be needed if tests are built, and its checked
 only in that case here[0]. Is that not working for you?

 [0] http://cgit.freedesktop.org/wayland/libinput/tree/configure.ac#n79


That won't work, if tests are disabled: automake sees that c++ is available
through the trace, and assumes the macro is called unconditionally, so if
one does not enable tests the build fails.

William
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel


Re: [libinput] AC_PROG_CXX missing in libinput/configure.ac

2014-03-29 Thread Jonas Ådahl
On Sat, Mar 29, 2014 at 02:23:52PM +0100, William Di Luigi wrote:
 On Sat, Mar 29, 2014 at 1:59 PM, Jonas Ådahl jad...@gmail.com wrote:
 
  On Sat, Mar 29, 2014 at 12:59:18PM +0100, William Di Luigi wrote:
   Currently in libinput/configure.ac there are these lines:
  
   # Check for programs
   AC_PROG_CC_C99
  
   In order to make the configure phase of jhbuild work, they should become:
  
   # Check for programs
   AC_PROG_CC_C99
   AC_PROG_CXX
 
  AC_PROG_CXX should only be needed if tests are built, and its checked
  only in that case here[0]. Is that not working for you?
 
  [0] http://cgit.freedesktop.org/wayland/libinput/tree/configure.ac#n79
 
 
 That won't work, if tests are disabled: automake sees that c++ is available
 through the trace, and assumes the macro is called unconditionally, so if
 one does not enable tests the build fails.

Ah, thats unfortunate. I pushed a commit that unconditionally invokes
A_PROG_CXX now. Thanks for the report.

Jonas

 
 William
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel


Re: [libinput] AC_PROG_CXX missing in libinput/configure.ac

2014-03-29 Thread Jonas Ådahl
On Sat, Mar 29, 2014 at 06:57:40PM +0100, Sylvain BERTRAND wrote:
 On Sat, Mar 29, 2014 at 02:44:13PM +0100, Jonas Ådahl wrote:
  Ah, thats unfortunate. I pushed a commit that unconditionally invokes
  A_PROG_CXX now. Thanks for the report.
 
 Does it mean a c++ compiler is now mandatory in any case?

Yes, for now at least.

 
 regards,
 
 -- 
 Sylvain
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel


Re: [libinput] AC_PROG_CXX missing in libinput/configure.ac

2014-03-29 Thread Sylvain BERTRAND
On Sat, Mar 29, 2014 at 06:59:12PM +0100, Jonas Ådahl wrote:
 Yes, for now at least.

Sad.

But till there is no crazy code generator, it should be easy
to write a makefile/shell script to by-pass the autotools and
build the lib.
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel


Re: [libinput] AC_PROG_CXX missing in libinput/configure.ac

2014-03-29 Thread Sylvain BERTRAND
On Sat, Mar 29, 2014 at 02:44:13PM +0100, Jonas Ådahl wrote:
 Ah, thats unfortunate. I pushed a commit that unconditionally invokes
 A_PROG_CXX now. Thanks for the report.

Does it mean a c++ compiler is now mandatory in any case?

regards,

-- 
Sylvain
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel