date:20160609

[PATCH libinput] touchpad: don't warn about kernel jumps on semi-mt devices

2016-06-09 Thread Peter Hutterer

These devices are all over the place anyway, no need to spam the log, just
silently discard the jumps.

https://bugs.freedesktop.org/show_bug.cgi?id=96275

Signed-off-by: Peter Hutterer 
---
 src/evdev-mt-touchpad.c | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index 56760dc..d01461c 100644
--- a/src/evdev-mt-touchpad.c
+++ b/src/evdev-mt-touchpad.c
@@ -1002,10 +1002,11 @@ tp_process_state(struct tp_dispatch *tp, uint64_t time)
tp_motion_history_reset(t);
 
if (tp_detect_jumps(tp, t)) {
-   log_bug_kernel(tp_libinput_context(tp),
-  "Touch jump detected and discarded.\n"
-  "See %stouchpad_jumping_cursor.html for 
details\n",
-  HTTP_DOC_LINK);
+   if (!tp->semi_mt)
+   log_bug_kernel(tp_libinput_context(tp),
+  "Touch jump detected and 
discarded.\n"
+  "See 
%stouchpad_jumping_cursor.html for details\n",
+  HTTP_DOC_LINK);
tp_motion_history_reset(t);
}
 
-- 
2.7.4

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston v2 0/2] Separate Weston from libweston

2016-06-09 Thread Bryce Harrington

On Thu, Jun 09, 2016 at 03:20:35PM +0300, Pekka Paalanen wrote:
> From: Pekka Paalanen 
> 
> After these two patches, we have weston-the-compositor sources in compositor/,
> and libweston sources in libweston/.
> 
> Since these patches have been generated with git format-patch -M and so
> probably cannot be applied from email, I made the branch available at:
> https://git.collabora.com/cgit/user/pq/weston.git/log/?h=migrate2
> 
> v2: move screen-share.c and note weston-launch.

This seems fine, although there's a number of pending patches for weston
that this will obviously break.  Since the rename can be done
mechanically for the most part, what would you think if we make an
effort to get all the weston patches prior to, say, June 1st, reviewed
and either landed or sent back with requests to update them to the new
layout?  I seem to recall a number of the pending patches we felt might
be landable post-release, so might be nice to clear the slate of those.

Bryce
 
> Thanks,
> pq
> 
> Pekka Paalanen (2):
>   Move weston source to compositor/
>   Rename src/ to libweston/
> 
>  Makefile.am | 208 
> ++--
>  README  |   7 +-
>  clients/cliptest.c  |   2 +-
>  {src => compositor}/cms-colord.c|   0
>  {src => compositor}/cms-helper.c|   0
>  {src => compositor}/cms-helper.h|   0
>  {src => compositor}/cms-static.c|   0
>  {src => compositor}/main.c  |   0
>  {src => compositor}/screen-share.c  |   0
>  {src => compositor}/systemd-notify.c|   0
>  {src => compositor}/text-backend.c  |   0
>  {src => compositor}/weston-screenshooter.c  |   0
>  {src => compositor}/weston.desktop  |   0
>  {src => compositor}/weston.h|   0
>  {src => compositor}/weston.pc.in|   0
>  configure.ac|   4 +-
>  desktop-shell/shell.c   |   2 +-
>  ivi-shell/hmi-controller.c  |   2 +-
>  ivi-shell/ivi-layout.c  |   2 +-
>  ivi-shell/ivi-shell.c   |   2 +-
>  {src => libweston}/animation.c  |   0
>  {src => libweston}/bindings.c   |   0
>  {src => libweston}/clipboard.c  |   0
>  {src => libweston}/compositor-drm.c |   0
>  {src => libweston}/compositor-drm.h |   0
>  {src => libweston}/compositor-fbdev.c   |   0
>  {src => libweston}/compositor-fbdev.h   |   0
>  {src => libweston}/compositor-headless.c|   0
>  {src => libweston}/compositor-headless.h|   0
>  {src => libweston}/compositor-rdp.c |   0
>  {src => libweston}/compositor-rdp.h |   0
>  {src => libweston}/compositor-wayland.c |   0
>  {src => libweston}/compositor-wayland.h |   0
>  {src => libweston}/compositor-x11.c |   0
>  {src => libweston}/compositor-x11.h |   0
>  {src => libweston}/compositor.c |   0
>  {src => libweston}/compositor.h |   0
>  {src => libweston}/data-device.c|   0
>  {src => libweston}/dbus.c   |   0
>  {src => libweston}/dbus.h   |   0
>  {src => libweston}/gl-renderer.c|   0
>  {src => libweston}/gl-renderer.h|   0
>  {src => libweston}/input.c  |   0
>  {src => libweston}/launcher-direct.c|   0
>  {src => libweston}/launcher-impl.h  |   0
>  {src => libweston}/launcher-logind.c|   0
>  {src => libweston}/launcher-util.c  |   0
>  {src => libweston}/launcher-util.h  |   0
>  {src => libweston}/launcher-weston-launch.c |   0
>  {src => libweston}/libbacklight.c   |   0
>  {src => libweston}/libbacklight.h   |   0
>  {src => libweston}/libinput-device.c|   0
>  {src => libweston}/libinput-device.h|   0
>  {src => libweston}/libinput-seat.c  |   0
>  {src => libweston}/libinput-seat.h  |   0
>  {src => libweston}/libweston.pc.in  |   0
>  {src => libweston}/linux-dmabuf.c   |   0
>  {src => libweston}/linux-dmabuf.h   |   0
>  {src => libweston}/log.c|   0
>  {src => libweston}/noop-renderer.c  |   0
>  {src => libweston}/pixman-renderer.c|   0
>  {src => libweston}/pixman-renderer.h|   0
>  {src => libweston}/screenshooter.c  |   0
>  {src => libweston}/spring-tool.c|   0
>  {src => libweston}/timeline-object.h|   0
>  {src => libweston}/timeline.c   |   0
>  {src => libweston}/timeline.h   |   0
>  {src => libweston}/vaapi-recorder.c |   0
>  {src => libweston}/vaapi-recorder.h |   0
>  {src => libweston}/version.h.in |   0
>  {src => libweston}/vertex-clipping.c|   0
>  {src => libweston}/vertex-clipping.h|   0
>

[PATCH] desktop-shell: resize background and panel surfaces on output resize v4

2016-06-09 Thread David Fort

When an output is resized (permanent mode switch), we should also notify the
shell client so that the panel and background fits to the new screen dimensions.

Signed-off-by: David Fort 
---
 desktop-shell/shell.c | 80 +++
 desktop-shell/shell.h |  7 +
 2 files changed, 87 insertions(+)

diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
index b1fb2fa..79cf8dd 100644
--- a/desktop-shell/shell.c
+++ b/desktop-shell/shell.c
@@ -4365,6 +4365,20 @@ configure_static_view(struct weston_view *ev, struct 
weston_layer *layer)
}
 }
 
+
+static struct shell_output *
+find_shell_output_from_weston_output(struct desktop_shell *shell, struct 
weston_output *output)
+{
+   struct shell_output *shell_output;
+
+   wl_list_for_each(shell_output, >output_list, link) {
+   if (shell_output->output == output)
+   return shell_output;
+   }
+
+   return NULL;
+}
+
 static int
 background_get_label(struct weston_surface *surface, char *buf, size_t len)
 {
@@ -4384,6 +4398,16 @@ background_configure(struct weston_surface *es, int32_t 
sx, int32_t sy)
 }
 
 static void
+handle_background_surface_destroy(struct wl_listener *listener, void *data)
+{
+   struct shell_output *output =
+   container_of(listener, struct shell_output, 
background_surface_listener);
+
+   weston_log("background surface gone\n");
+   output->background_surface = NULL;
+}
+
+static void
 desktop_shell_set_background(struct wl_client *client,
 struct wl_resource *resource,
 struct wl_resource *output_resource,
@@ -4392,6 +4416,7 @@ desktop_shell_set_background(struct wl_client *client,
struct desktop_shell *shell = wl_resource_get_user_data(resource);
struct weston_surface *surface =
wl_resource_get_user_data(surface_resource);
+   struct shell_output *sh_output;
struct weston_view *view, *next;
 
if (surface->configure) {
@@ -4414,6 +4439,12 @@ desktop_shell_set_background(struct wl_client *client,
surface_resource,
surface->output->width,
surface->output->height);
+
+   sh_output = find_shell_output_from_weston_output(shell, 
surface->output);
+   sh_output->background_surface = surface;
+
+   sh_output->background_surface_listener.notify = 
handle_background_surface_destroy;
+   wl_signal_add(>destroy_signal, 
_output->background_surface_listener);
 }
 
 static int
@@ -4435,6 +4466,17 @@ panel_configure(struct weston_surface *es, int32_t sx, 
int32_t sy)
 }
 
 static void
+handle_panel_surface_destroy(struct wl_listener *listener, void *data)
+{
+   struct shell_output *output =
+   container_of(listener, struct shell_output, panel_surface_listener);
+
+   weston_log("panel surface gone\n");
+   output->panel_surface = NULL;
+}
+
+
+static void
 desktop_shell_set_panel(struct wl_client *client,
struct wl_resource *resource,
struct wl_resource *output_resource,
@@ -,6 +4486,7 @@ desktop_shell_set_panel(struct wl_client *client,
struct weston_surface *surface =
wl_resource_get_user_data(surface_resource);
struct weston_view *view, *next;
+   struct shell_output *sh_output;
 
if (surface->configure) {
wl_resource_post_error(surface_resource,
@@ -4465,6 +4508,12 @@ desktop_shell_set_panel(struct wl_client *client,
surface_resource,
surface->output->width,
surface->output->height);
+
+   sh_output = find_shell_output_from_weston_output(shell, 
surface->output);
+   sh_output->panel_surface = surface;
+
+   sh_output->panel_surface_listener.notify = handle_panel_surface_destroy;
+   wl_signal_add(>destroy_signal, 
_output->panel_surface_listener);
 }
 
 static int
@@ -6382,6 +6431,33 @@ handle_output_destroy(struct wl_listener *listener, void 
*data)
 }
 
 static void
+shell_resize_surface_to_output(struct desktop_shell *shell,
+   struct weston_surface *surface,
+   const struct weston_output *output)
+{
+   if (!surface)
+   return;
+
+   weston_desktop_shell_send_configure(shell->child.desktop_shell, 0,
+   surface->resource,
+   output->width,
+   output->height);
+}
+
+
+static void
+handle_output_resized(struct wl_listener *listener, void *data)
+{
+   struct desktop_shell *shell =
+   container_of(listener, struct desktop_shell, resized_listener);
+   struct

[PATCH weston v2 2/2] Rename src/ to libweston/

2016-06-09 Thread Pekka Paalanen

From: Pekka Paalanen 

This clarifies what is supposed to be the libweston code.

v2: screen-share.c is already in compositor/ instead.

Signed-off-by: Pekka Paalanen 
---
 Makefile.am | 182 ++--
 clients/cliptest.c  |   2 +-
 configure.ac|   4 +-
 {src => libweston}/animation.c  |   0
 {src => libweston}/bindings.c   |   0
 {src => libweston}/clipboard.c  |   0
 {src => libweston}/compositor-drm.c |   0
 {src => libweston}/compositor-drm.h |   0
 {src => libweston}/compositor-fbdev.c   |   0
 {src => libweston}/compositor-fbdev.h   |   0
 {src => libweston}/compositor-headless.c|   0
 {src => libweston}/compositor-headless.h|   0
 {src => libweston}/compositor-rdp.c |   0
 {src => libweston}/compositor-rdp.h |   0
 {src => libweston}/compositor-wayland.c |   0
 {src => libweston}/compositor-wayland.h |   0
 {src => libweston}/compositor-x11.c |   0
 {src => libweston}/compositor-x11.h |   0
 {src => libweston}/compositor.c |   0
 {src => libweston}/compositor.h |   0
 {src => libweston}/data-device.c|   0
 {src => libweston}/dbus.c   |   0
 {src => libweston}/dbus.h   |   0
 {src => libweston}/gl-renderer.c|   0
 {src => libweston}/gl-renderer.h|   0
 {src => libweston}/input.c  |   0
 {src => libweston}/launcher-direct.c|   0
 {src => libweston}/launcher-impl.h  |   0
 {src => libweston}/launcher-logind.c|   0
 {src => libweston}/launcher-util.c  |   0
 {src => libweston}/launcher-util.h  |   0
 {src => libweston}/launcher-weston-launch.c |   0
 {src => libweston}/libbacklight.c   |   0
 {src => libweston}/libbacklight.h   |   0
 {src => libweston}/libinput-device.c|   0
 {src => libweston}/libinput-device.h|   0
 {src => libweston}/libinput-seat.c  |   0
 {src => libweston}/libinput-seat.h  |   0
 {src => libweston}/libweston.pc.in  |   0
 {src => libweston}/linux-dmabuf.c   |   0
 {src => libweston}/linux-dmabuf.h   |   0
 {src => libweston}/log.c|   0
 {src => libweston}/noop-renderer.c  |   0
 {src => libweston}/pixman-renderer.c|   0
 {src => libweston}/pixman-renderer.h|   0
 {src => libweston}/screenshooter.c  |   0
 {src => libweston}/spring-tool.c|   0
 {src => libweston}/timeline-object.h|   0
 {src => libweston}/timeline.c   |   0
 {src => libweston}/timeline.h   |   0
 {src => libweston}/vaapi-recorder.c |   0
 {src => libweston}/vaapi-recorder.h |   0
 {src => libweston}/version.h.in |   0
 {src => libweston}/vertex-clipping.c|   0
 {src => libweston}/vertex-clipping.h|   0
 {src => libweston}/weston-egl-ext.h |   0
 {src => libweston}/weston-launch.c  |   0
 {src => libweston}/weston-launch.h  |   0
 {src => libweston}/zoom.c   |   0
 tests/ivi_layout-internal-test.c|   2 +-
 tests/ivi_layout-test-plugin.c  |   2 +-
 tests/surface-global-test.c |   2 +-
 tests/surface-test.c|   2 +-
 tests/vertex-clip-test.c|   2 +-
 tests/weston-test.c |   4 +-
 65 files changed, 101 insertions(+), 101 deletions(-)
 rename {src => libweston}/animation.c (100%)
 rename {src => libweston}/bindings.c (100%)
 rename {src => libweston}/clipboard.c (100%)
 rename {src => libweston}/compositor-drm.c (100%)
 rename {src => libweston}/compositor-drm.h (100%)
 rename {src => libweston}/compositor-fbdev.c (100%)
 rename {src => libweston}/compositor-fbdev.h (100%)
 rename {src => libweston}/compositor-headless.c (100%)
 rename {src => libweston}/compositor-headless.h (100%)
 rename {src => libweston}/compositor-rdp.c (100%)
 rename {src => libweston}/compositor-rdp.h (100%)
 rename {src => libweston}/compositor-wayland.c (100%)
 rename {src => libweston}/compositor-wayland.h (100%)
 rename {src => libweston}/compositor-x11.c (100%)
 rename {src => libweston}/compositor-x11.h (100%)
 rename {src => libweston}/compositor.c (100%)
 rename {src => libweston}/compositor.h (100%)
 rename {src => libweston}/data-device.c (100%)
 rename {src => libweston}/dbus.c (100%)
 rename {src => libweston}/dbus.h (100%)
 rename {src => libweston}/gl-renderer.c (100%)
 rename {src => libweston}/gl-renderer.h (100%)
 rename {src => libweston}/input.c (100%)
 rename {src => libweston}/launcher-direct.c (100%)
 rename {src => libweston}/launcher-impl.h (100%)
 rename {src => libweston}/launcher-logind.c (100%)
 rename {src => libweston}/launcher-util.c (100%)

[PATCH weston v2 1/2] Move weston source to compositor/

2016-06-09 Thread Pekka Paalanen

From: Pekka Paalanen 

This is the start of separating weston-the-compositor source files from
libweston source files.

This is moving all the files related to the 'weston' binary. Also the
CMS and systemd plugins are moved.

xwayland plugin is not moved, because it will be turned into a
libweston feature.

To avoid breaking the build, #includes for weston.h are fixed to use
compositor/weston.h. This serves as a reminder that such files may need
further attention: moving to the right directory, or maybe using the
proper -I flags instead.

v2: Move also screen-share.c, and add a note about weston-launch.

Signed-off-by: Pekka Paalanen 
---
 Makefile.am| 28 ++--
 README |  7 ++-
 {src => compositor}/cms-colord.c   |  0
 {src => compositor}/cms-helper.c   |  0
 {src => compositor}/cms-helper.h   |  0
 {src => compositor}/cms-static.c   |  0
 {src => compositor}/main.c |  0
 {src => compositor}/screen-share.c |  0
 {src => compositor}/systemd-notify.c   |  0
 {src => compositor}/text-backend.c |  0
 {src => compositor}/weston-screenshooter.c |  0
 {src => compositor}/weston.desktop |  0
 {src => compositor}/weston.h   |  0
 {src => compositor}/weston.pc.in   |  0
 configure.ac   |  2 +-
 desktop-shell/shell.c  |  2 +-
 ivi-shell/hmi-controller.c |  2 +-
 ivi-shell/ivi-layout.c |  2 +-
 ivi-shell/ivi-shell.c  |  2 +-
 tests/ivi_layout-test-plugin.c |  2 +-
 tests/weston-test.c|  2 +-
 xwayland/launcher.c|  2 +-
 xwayland/xwayland.h|  2 +-
 23 files changed, 29 insertions(+), 24 deletions(-)
 rename {src => compositor}/cms-colord.c (100%)
 rename {src => compositor}/cms-helper.c (100%)
 rename {src => compositor}/cms-helper.h (100%)
 rename {src => compositor}/cms-static.c (100%)
 rename {src => compositor}/main.c (100%)
 rename {src => compositor}/screen-share.c (100%)
 rename {src => compositor}/systemd-notify.c (100%)
 rename {src => compositor}/text-backend.c (100%)
 rename {src => compositor}/weston-screenshooter.c (100%)
 rename {src => compositor}/weston.desktop (100%)
 rename {src => compositor}/weston.h (100%)
 rename {src => compositor}/weston.pc.in (100%)

diff --git a/Makefile.am b/Makefile.am
index 8466a5f..0d0334a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -113,7 +113,7 @@ systemd_notify_la_CFLAGS =  \
$(PIXMAN_CFLAGS)\
$(AM_CFLAGS)
 systemd_notify_la_SOURCES =\
-   src/systemd-notify.c\
+   compositor/systemd-notify.c \
shared/helpers.h\
shared/zalloc.h \
src/compositor.h
@@ -148,9 +148,9 @@ weston_LDADD = $(COMPOSITOR_LIBS) $(LIBUNWIND_LIBS) \
-lm libshared.la libweston.la
 
 weston_SOURCES =   \
-   src/main.c  \
-   src/weston-screenshooter.c  \
-   src/text-backend.c
+   compositor/main.c   \
+   compositor/weston-screenshooter.c   \
+   compositor/text-backend.c
 
 # Track this dependency explicitly instead of using BUILT_SOURCES.  We
 # add BUILT_SOURCES to CLEANFILES, but we want to keep git-version.h
@@ -220,10 +220,10 @@ endif
 endif # BUILD_WESTON_LAUNCH
 
 pkgconfigdir = $(libdir)/pkgconfig
-pkgconfig_DATA = src/weston.pc src/libweston-${LIBWESTON_ABI_VERSION}.pc
+pkgconfig_DATA = compositor/weston.pc src/libweston-${LIBWESTON_ABI_VERSION}.pc
 
 wayland_sessiondir = $(datadir)/wayland-sessions
-dist_wayland_session_DATA = src/weston.desktop
+dist_wayland_session_DATA = compositor/weston.desktop
 
 libwestonincludedir = $(includedir)/libweston-${LIBWESTON_ABI_VERSION}
 libwestoninclude_HEADERS = \
@@ -242,7 +242,7 @@ libwestoninclude_HEADERS =  \
shared/platform.h
 
 westonincludedir = $(includedir)/weston
-westoninclude_HEADERS = src/weston.h
+westoninclude_HEADERS = compositor/weston.h
 
 if ENABLE_IVI_SHELL
 westoninclude_HEADERS +=   \
@@ -401,9 +401,9 @@ cms_static_la_LDFLAGS = -module -avoid-version
 cms_static_la_LIBADD = $(COMPOSITOR_LIBS) $(LCMS_LIBS) libshared.la
 cms_static_la_CFLAGS = $(AM_CFLAGS) $(COMPOSITOR_CFLAGS) $(LCMS_CFLAGS)
 cms_static_la_SOURCES =\
-   src/cms-static.c\
-   src/cms-helper.c\
-   src/cms-helper.h\
+   compositor/cms-static.c

[PATCH weston v2 0/2] Separate Weston from libweston

2016-06-09 Thread Pekka Paalanen

From: Pekka Paalanen 

After these two patches, we have weston-the-compositor sources in compositor/,
and libweston sources in libweston/.

Since these patches have been generated with git format-patch -M and so
probably cannot be applied from email, I made the branch available at:
https://git.collabora.com/cgit/user/pq/weston.git/log/?h=migrate2

v2: move screen-share.c and note weston-launch.


Thanks,
pq

Pekka Paalanen (2):
  Move weston source to compositor/
  Rename src/ to libweston/

 Makefile.am | 208 ++--
 README  |   7 +-
 clients/cliptest.c  |   2 +-
 {src => compositor}/cms-colord.c|   0
 {src => compositor}/cms-helper.c|   0
 {src => compositor}/cms-helper.h|   0
 {src => compositor}/cms-static.c|   0
 {src => compositor}/main.c  |   0
 {src => compositor}/screen-share.c  |   0
 {src => compositor}/systemd-notify.c|   0
 {src => compositor}/text-backend.c  |   0
 {src => compositor}/weston-screenshooter.c  |   0
 {src => compositor}/weston.desktop  |   0
 {src => compositor}/weston.h|   0
 {src => compositor}/weston.pc.in|   0
 configure.ac|   4 +-
 desktop-shell/shell.c   |   2 +-
 ivi-shell/hmi-controller.c  |   2 +-
 ivi-shell/ivi-layout.c  |   2 +-
 ivi-shell/ivi-shell.c   |   2 +-
 {src => libweston}/animation.c  |   0
 {src => libweston}/bindings.c   |   0
 {src => libweston}/clipboard.c  |   0
 {src => libweston}/compositor-drm.c |   0
 {src => libweston}/compositor-drm.h |   0
 {src => libweston}/compositor-fbdev.c   |   0
 {src => libweston}/compositor-fbdev.h   |   0
 {src => libweston}/compositor-headless.c|   0
 {src => libweston}/compositor-headless.h|   0
 {src => libweston}/compositor-rdp.c |   0
 {src => libweston}/compositor-rdp.h |   0
 {src => libweston}/compositor-wayland.c |   0
 {src => libweston}/compositor-wayland.h |   0
 {src => libweston}/compositor-x11.c |   0
 {src => libweston}/compositor-x11.h |   0
 {src => libweston}/compositor.c |   0
 {src => libweston}/compositor.h |   0
 {src => libweston}/data-device.c|   0
 {src => libweston}/dbus.c   |   0
 {src => libweston}/dbus.h   |   0
 {src => libweston}/gl-renderer.c|   0
 {src => libweston}/gl-renderer.h|   0
 {src => libweston}/input.c  |   0
 {src => libweston}/launcher-direct.c|   0
 {src => libweston}/launcher-impl.h  |   0
 {src => libweston}/launcher-logind.c|   0
 {src => libweston}/launcher-util.c  |   0
 {src => libweston}/launcher-util.h  |   0
 {src => libweston}/launcher-weston-launch.c |   0
 {src => libweston}/libbacklight.c   |   0
 {src => libweston}/libbacklight.h   |   0
 {src => libweston}/libinput-device.c|   0
 {src => libweston}/libinput-device.h|   0
 {src => libweston}/libinput-seat.c  |   0
 {src => libweston}/libinput-seat.h  |   0
 {src => libweston}/libweston.pc.in  |   0
 {src => libweston}/linux-dmabuf.c   |   0
 {src => libweston}/linux-dmabuf.h   |   0
 {src => libweston}/log.c|   0
 {src => libweston}/noop-renderer.c  |   0
 {src => libweston}/pixman-renderer.c|   0
 {src => libweston}/pixman-renderer.h|   0
 {src => libweston}/screenshooter.c  |   0
 {src => libweston}/spring-tool.c|   0
 {src => libweston}/timeline-object.h|   0
 {src => libweston}/timeline.c   |   0
 {src => libweston}/timeline.h   |   0
 {src => libweston}/vaapi-recorder.c |   0
 {src => libweston}/vaapi-recorder.h |   0
 {src => libweston}/version.h.in |   0
 {src => libweston}/vertex-clipping.c|   0
 {src => libweston}/vertex-clipping.h|   0
 {src => libweston}/weston-egl-ext.h |   0
 {src => libweston}/weston-launch.c  |   0
 {src => libweston}/weston-launch.h  |   0
 {src => libweston}/zoom.c   |   0
 tests/ivi_layout-internal-test.c|   2 +-
 tests/ivi_layout-test-plugin.c  |   4 +-
 tests/surface-global-test.c |   2 +-
 tests/surface-test.c|   2 +-
 tests/vertex-clip-test.c|   2 +-
 tests/weston-test.c |   6 +-
 xwayland/launcher.c |   2 +-
 xwayland/xwayland.h |   2 +-
 84 files changed, 128 insertions(+), 123 deletions(-)
 rename {src => compositor}/cms-colord.c (100%)
 rename

Re: [PATCH libinput] evdev: check model flags for actual booleans

2016-06-09 Thread Hans de Goede


Hi,

On 09-06-16 02:53, Peter Hutterer wrote:

The hwdb doesn't allow unsetting a property so once we start nesting model
flags it'll become important to be able to be able to unset one as well (by
assigning it to 0).

So rather than checking for existence, check whether the property is actually
set to something resembling a boolean.

Signed-off-by: Peter Hutterer 


patch looks good to me:

Reviewed-by: Hans de Goede 

Regards,

Hans



---
 src/evdev.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/evdev.c b/src/evdev.c
index 0227f51..e0923cd 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1813,10 +1813,12 @@ evdev_read_model_flags(struct evdev_device *device)
};
const struct model_map *m = model_map;
uint32_t model_flags = 0;
+   const char *val;

while (m->property) {
-   if (!!udev_device_get_property_value(device->udev_device,
-m->property)) {
+   val = udev_device_get_property_value(device->udev_device,
+m->property);
+   if (val && !streq(val, "0")) {
log_debug(device->base.seat->libinput,
  "%s: tagged as %s\n",
  evdev_device_get_sysname(device),


___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-06-09 Thread Carlos Garnacho

Hi Jan Arne!,

Chiming in, and kinda late at that... hopefully we'll get this moving :).

First of all, I'm aware that some of my comments are directed towards
stuff that's unchanged between v1 and v2, so please bear with me, I
hope the feedback is useful.

On Mon, May 30, 2016 at 11:41 AM, Jan Arne Petersen  wrote:
> There were some shortcomings in the first version of the protocol which
> makes it not really useful in real world applications. It is not really
> possible to fix them in a compatible way so introduce a new v2 of the
> protocol.
>
> Fixes some shortcomings of the first version:
>
> * Use only one wp_text_input per wl_seat (client side should be
>   handled by client toolkit)
> * Allow focus tracking without wl_keyboard present
> * Improve update state handling and better define state handling
> ---
> Changes to v6:
> * Fix some typos
>
>  Makefile.am|   1 +
>  unstable/text-input/text-input-unstable-v2.xml | 480 
> +
>  2 files changed, 481 insertions(+)
>  create mode 100644 unstable/text-input/text-input-unstable-v2.xml
>
> diff --git a/Makefile.am b/Makefile.am
> index 71d2632..cc8d531 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -3,6 +3,7 @@ unstable_protocols =  
>   \
> unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml
>   \
> unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
>   \
> unstable/text-input/text-input-unstable-v1.xml
>   \
> +   unstable/text-input/text-input-unstable-v2.xml
>   \
> unstable/input-method/input-method-unstable-v1.xml
>   \
> unstable/xdg-shell/xdg-shell-unstable-v5.xml  
>   \
> unstable/relative-pointer/relative-pointer-unstable-v1.xml
>   \
> diff --git a/unstable/text-input/text-input-unstable-v2.xml 
> b/unstable/text-input/text-input-unstable-v2.xml
> new file mode 100644
> index 000..ea35d9b
> --- /dev/null
> +++ b/unstable/text-input/text-input-unstable-v2.xml
> @@ -0,0 +1,480 @@
> +
> +
> +
> +  
> +Copyright © 2012, 2013 Intel Corporation
> +Copyright © 2015, 2016 Jan Arne Petersen
> +
> +Permission to use, copy, modify, distribute, and sell this
> +software and its documentation for any purpose is hereby granted
> +without fee, provided that the above copyright notice appear in
> +all copies and that both that copyright notice and this permission
> +notice appear in supporting documentation, and that the name of
> +the copyright holders not be used in advertising or publicity
> +pertaining to distribution of the software without specific,
> +written prior permission.  The copyright holders make no
> +representations about the suitability of this software for any
> +purpose.  It is provided "as is" without express or implied
> +warranty.
> +
> +THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS
> +SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
> +FITNESS, IN NO EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY
> +SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
> +WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN
> +AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,
> +ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
> +THIS SOFTWARE.
> +  
> +
> +  
> +
> +  The zwp_text_input_v2 interface represents text input and input methods
> +  associated with a seat. It provides enter/leave events to follow the
> +  text input focus for a seat.
> +
> +  Requests are used to enable/disable the text-input object and set
> +  state information like surrounding and selected text or the content 
> type.
> +  The information about the entered text is sent to the text-input object
> +  via the pre-edit and commit events. Using this interface removes the 
> need
> +  for applications to directly process hardware key events and compose 
> text
> +  out of them.
> +
> +  Text is valid UTF-8 encoded, indices and lengths are in bytes. Indices
> +  have to always point to the first byte of an UTF-8 encoded code point.
> +  Lengths are not allowed to contain just a part of an UTF-8 encoded code
> +  point.
> +
> +  State is sent by the state requests (set_surrounding_text,
> +  set_content_type, set_cursor_rectangle and set_preferred_language) and
> +  an update_state request. After an enter or an input_method_change event
> +  all state information is invalidated and needs to be resent from the
> +  client. A reset or entering a new widget on client side also
> +  invalidates all current state information.
> +
> +
> +
> +  
> +   Destroy the wp_text_input object. Also

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-09 Thread Pekka Paalanen

On Mon, 6 Jun 2016 16:01:03 +0300
Giulio Camuffo  wrote:

> 2016-06-06 15:52 GMT+03:00 Pekka Paalanen :
> > On Sun, 5 Jun 2016 21:50:33 +0300
> > Giulio Camuffo  wrote:
> >  
> >> 2016-06-03 17:33 GMT+03:00 Pekka Paalanen :  
> >> > From: Pekka Paalanen 
> >> >
> >> > This is the start of separating weston-the-compositor source files from
> >> > libweston source files.
> >> >
> >> > This is moving all the files related to the 'weston' binary. Also the
> >> > CMS and systemd plugins are moved.
> >> >
> >> > xwayland plugin is not moved, because it will be turned into a
> >> > libweston feature.
> >> >
> >> > To avoid breaking the build, #includes for weston.h are fixed to use
> >> > compositor/weston.h. This serves as a reminder that such files may need
> >> > further attention: moving to the right directory, or maybe using the
> >> > proper -I flags instead.  
> >>
> >> I guess you should move weston-launch too, since it currently cannot
> >> be used by other compositors.  
> >
> > That's true. OTOH, would we like to make it usable for others?
> > Should it be installed with libweston, perhaps under a generic name?  
> 
> I think we should...
> 
> >
> > But can it even be safely made usable for launching arbitrary programs?
> > By design, it would offer the user access to input and DRM devices as
> > root. If it can offer the services to any program, a malicious program
> > can use it to start listening on input devices.  
> 
> but indeed this is the question, and i don't know. I will try to think
> of a way but until then i think it makes sense to keep it with weston.
> On the other hand maybe it's just unnecessary noise if we want to move
> it back later...

Right. IMHO, let's not move it yet but add a note in the README about it.

> >
> > Yes, I suppose I should move it. However, launcher-util has code
> > specific to weston-launch. I could move weston-launch.c but not
> > weston-launch.h.
> >
> > Other opinions on moving weston-launch.c to compositor/?
> >
> > Should I also move screen-share.c to compositor/?

I'll also move screen-share.c to compositor/.

Will re-post the move.


Thanks,
pq


pgptDDzMZ7aFz.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 2/2] weston-launch: Allow the user to use her login shell

2016-06-09 Thread Pekka Paalanen

On Sun, 29 May 2016 13:59:15 +0200
Quentin Glidic  wrote:

> From: Quentin Glidic 
> 

Hi,

could you please explain in the commit message why we want this again?

The below does not get into the commit message.

> Signed-off-by: Quentin Glidic 
> ---
> 
> This patch is just there to restore and old feature which I introduced and was
> removed later because fish doesn’t support the $SHELL -l -c "weston \"$@\"" 
> syntax.
> 
> It is fully optional and even I do not use that feature any more, so feel 
> free to ignore
> it unless it brings you a feature you wanted.

Right.

Would anyone make use of this feature?

I don't think we should add it if no-one votes for it. It's a
setuid-root program.


Thanks,
pq

>  src/weston-launch.c | 29 +++--
>  1 file changed, 19 insertions(+), 10 deletions(-)
> 
> diff --git a/src/weston-launch.c b/src/weston-launch.c
> index d731ed8..3003dd5 100644
> --- a/src/weston-launch.c
> +++ b/src/weston-launch.c
> @@ -108,6 +108,7 @@ struct weston_launch {
>   pid_t child;
>   int verbose;
>   char *new_user;
> + int use_user_shell;
>  };
>  
>  union cmsg_data { unsigned char b[4]; int fd; };
> @@ -613,7 +614,10 @@ setup_session(struct weston_launch *wl, char 
> *child_argv[MAX_ARGV_SIZE])
>* We open a new session, so it makes sense
>* to run a new login shell
>*/
> - child_argv[0] = "/bin/sh";
> + if (wl->use_user_shell)
> + child_argv[0] = wl->pw->pw_shell;
> + else
> + child_argv[0] = "/bin/sh";
>   child_argv[1] = "-l";
>   child_argv[2] = "-c";
>   child_argv[3] = BINDIR "/weston \"$@\"";
> @@ -675,10 +679,11 @@ static void
>  help(const char *name)
>  {
>   fprintf(stderr, "Usage: %s [args...] [-- [weston args..]]\n", name);
> - fprintf(stderr, "  -u, --user  Start session as specified 
> username\n");
> - fprintf(stderr, "  -t, --tty   Start session on alternative tty\n");
> - fprintf(stderr, "  -v, --verbose   Be verbose\n");
> - fprintf(stderr, "  -h, --help  Display this help message\n");
> + fprintf(stderr, "  -u, --user  Start session as specified 
> username\n");
> + fprintf(stderr, "  -s, --use-user-shellUse the user login shell 
> (from PAM) instead of /bin/sh, only has effect with --user\n");
> + fprintf(stderr, "  -t, --tty   Start session on alternative 
> tty\n");
> + fprintf(stderr, "  -v, --verbose   Be verbose\n");
> + fprintf(stderr, "  -h, --help  Display this help 
> message\n");
>  }
>  
>  int
> @@ -688,11 +693,12 @@ main(int argc, char *argv[])
>   int i, c;
>   char *tty = NULL;
>   struct option opts[] = {
> - { "user",required_argument, NULL, 'u' },
> - { "tty", required_argument, NULL, 't' },
> - { "verbose", no_argument,   NULL, 'v' },
> - { "help",no_argument,   NULL, 'h' },
> - { 0, 0, NULL,  0  }
> + { "user",   required_argument, NULL, 'u' },
> + { "use-user-shell", no_argument,   NULL, 's' },
> + { "tty",required_argument, NULL, 't' },
> + { "verbose",no_argument,   NULL, 'v' },
> + { "help",   no_argument,   NULL, 'h' },
> + { 0,0, NULL,  0  }
>   };
>  
>   memset(, 0, sizeof wl);
> @@ -704,6 +710,9 @@ main(int argc, char *argv[])
>   if (getuid() != 0)
>   error(1, 0, "Permission denied. -u allowed for 
> root only");
>   break;
> + case 's':
> + wl.use_user_shell = 1;
> + break;
>   case 't':
>   tty = optarg;
>   break;



pgpTtfEGGWoXS.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 1/2] weston-launch: Only run a login shell for new sessions

2016-06-09 Thread Pekka Paalanen

On Sun, 29 May 2016 13:59:14 +0200
Quentin Glidic  wrote:

> From: Quentin Glidic 
> 
> This way, the environment is correctly preserved for weston. Since
> commit 636156d5f693ac5b01cec6a2937d2b6cd4237ea9, clearenv() is only
> called when we open a new PAM session, so it makes sense to only use a
> login shell in that case.
> 
> Signed-off-by: Quentin Glidic 
> ---
>  src/weston-launch.c | 34 ++
>  1 file changed, 22 insertions(+), 12 deletions(-)
> 
> diff --git a/src/weston-launch.c b/src/weston-launch.c
> index b8dfb17..d731ed8 100644
> --- a/src/weston-launch.c
> +++ b/src/weston-launch.c
> @@ -577,8 +577,8 @@ setup_tty(struct weston_launch *wl, const char *tty)
>   return 0;
>  }
>  
> -static void
> -setup_session(struct weston_launch *wl)
> +static int
> +setup_session(struct weston_launch *wl, char *child_argv[MAX_ARGV_SIZE])

Hi,

that is an array to char-pointer as a function parameter. I never pass
arrays as parameters like that, so can you explain, does it correspond
to char** or is the function operating on a copy of the array which
would be wrong?

Because I even have to ask the question for this setuid-root program is
an indication that it would probably be better formulated so that I
don't even have to think about it.

>  {
>   char **env;
>   char *term;
> @@ -608,6 +608,17 @@ setup_session(struct weston_launch *wl)
>   }
>   free(env);
>   }
> +
> + /*
> +  * We open a new session, so it makes sense
> +  * to run a new login shell
> +  */
> + child_argv[0] = "/bin/sh";
> + child_argv[1] = "-l";
> + child_argv[2] = "-c";
> + child_argv[3] = BINDIR "/weston \"$@\"";
> + child_argv[4] = "weston";
> + return 5;
>  }
>  
>  static void
> @@ -626,12 +637,19 @@ launch_compositor(struct weston_launch *wl, int argc, 
> char *argv[])
>  {
>   char *child_argv[MAX_ARGV_SIZE];
>   sigset_t mask;
> - int i;
> + int o, i;
>  
>   if (wl->verbose)
>   printf("weston-launch: spawned weston with pid: %d\n", 
> getpid());
>   if (wl->new_user)

Braces needed now because the else has them.

> - setup_session(wl);
> + o = setup_session(wl, child_argv);
> + else {
> + child_argv[0] = BINDIR "/weston";
> + o = 1;
> + }
> + for (i = 0; i < argc; ++i)
> + child_argv[o + i] = argv[i];
> + child_argv[o + i] = NULL;
>  
>   if (geteuid() == 0)
>   drop_privileges(wl);
> @@ -648,14 +666,6 @@ launch_compositor(struct weston_launch *wl, int argc, 
> char *argv[])
>   sigaddset(, SIGINT);
>   sigprocmask(SIG_UNBLOCK, , NULL);
>  
> - child_argv[0] = "/bin/sh";
> - child_argv[1] = "-l";
> - child_argv[2] = "-c";
> - child_argv[3] = BINDIR "/weston \"$@\"";
> - child_argv[4] = "weston";
> - for (i = 0; i < argc; ++i)
> - child_argv[5 + i] = argv[i];
> - child_argv[5 + i] = NULL;
>  
>   execv(child_argv[0], child_argv);
>   error(1, errno, "exec failed");

The change looks good to me in principle, but we need two R-bs and
would like a Tested-by for both paths: with and without new_user.
My R-b is pending on the two issues mentioned above.

You could list the ways you tested it with in the commit message.


Thanks,
pq


pgp4BqUmcBqJf.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston v3 7/8] Define the screensaver inhibitor client interface

2016-06-09 Thread Pekka Paalanen

On Thu, 9 Jun 2016 10:31:20 +0300
Pekka Paalanen  wrote:

> On Wed, 8 Jun 2016 13:59:36 -0700
> Bryce Harrington  wrote:
> 
> > On Thu, May 26, 2016 at 06:02:09PM +0300, Pekka Paalanen wrote:  
> > > On Thu,  7 Apr 2016 16:44:22 -0700
> > > Bryce Harrington  wrote:
> > > 
> > > > Hook up the API defined in wayland-protocols to allow client screensaver
> > > > inhibition requests.
> > > > 
> > > > Signed-off-by: Bryce Harrington 
> > > > ---
> > > > v2: Update for protocol rename
> > > > 
> > > >  Makefile.am  |  9 +++--
> > > >  clients/simple-shm.c | 28 
> > > >  2 files changed, 31 insertions(+), 6 deletions(-)
> > > 
> > > Hi,
> > > 
> > > I would really wish we didn't add any more stuff into simple-shm, or
> > > any of the simple-* clients, unless it is essential to them.
> > > 
> > > Something like the subsurfaces demo would be more suitable, that would
> > > allow you to test the inhibi... hmm, wait, no, all subsurfaces there
> > > are still inside the parent. I think you need a new test client that
> > > creates a subsurface outside of the main surface, so you can test the
> > > inhibitor inheritance.
> > 
> > Given the subsurfaces stuff seems to still be a source of disagreement,
> > and evidently is something I totally am not grokking, I don't want to
> > get into implementing subsurface support.  The typical client won't be
> > using subsurfaces, so a simpler demo would be more relevant for them.
> > For clients that *do* use subsurfaces, well it sounds like they could
> > have quite a diverse range of behavioral needs regarding inhibition, so
> > making a good subsurface demo sounds like it could get rather involved.  
> 
> Right.
> 
> > I do understand your point about wanting to avoid shoehorning more
> > features into the simple-* clients; they're already kind of a hodge
> > podge.  So I'll look at creating a new client like simple-shm that is
> > boiled down to just showing off the inhibit feature with a single top
> > level surface.  
> 
> Cool.
> 
> I do not think they are that hodge-podge. If you want, I can list and
> justify all features in each of them, I believe.

Oh, how about adding an inhibitor option to clients/presentation-shm.c?

That's a animated demo for presentation and I think idle-inhibitor
would fit well in the scope. It also does not seem to use toytoolkit, so
you don't have to deal with that.


Thanks,
pq


pgpQpX0kDO1cG.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter

2016-06-09 Thread Pekka Paalanen

On Tue, 7 Jun 2016 15:20:51 +0300
Pekka Paalanen  wrote:

> On Tue, 10 May 2016 12:56:41 +0300
> Pekka Paalanen  wrote:
> 
> > On Fri, 6 May 2016 15:07:19 +0300
> > Pekka Paalanen  wrote:
> >   
> > > On Thu, 5 May 2016 15:46:46 -0700
> > > Bryce Harrington  wrote:
> > > 
> > > > On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote:  
> > > > > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote:   
> > > > >  
> > > > > > From: Pekka Paalanen 
> > > > > > 
> > > > > > Hi,
> > > > > > 
> > > > > > here is the v3 of the stabilization series, which I hope to the 
> > > > > > final to be
> > > > > > merged.
> > > > > > 
> > > > > > The wayland-protocols patches are essentially the same as v2, 
> > > > > > except few
> > > > > > cosmetic changes as suggested by review comments. There are 
> > > > > > mentioned in the
> > > > > > review log in each patch, if there were any.
> > > > > > 
> > > > > > The weston patches are v3 too, though v2 was never posted. The 
> > > > > > changes to v1
> > > > > > are:
> > > > > > - patches 6-7 are new (simple preparation)
> > > > > > - patches 8-12 are the same as v1
> > > > > > - patches 13-17 are new, accounting for the spec changes from
> > > > > >   wayland-protocols v1
> > > > > > 
> > > > > > Note, that there are now tests for the wp_viewporter API. \o/
> > > > > > 
> > > > > > 
> > > > > > Wayland-protocols:
> > > > > > 
> > > > > > Pekka Paalanen (5):
> > > > > >   stable: add viewporter draft
> > > > > >   stable/viewporter: remove wp_viewport.set request
> > > > > >   stable/viewporter: rename and build
> > > > > >   stable/viewporter: rephrase a wp_viewport paragraph
> > > > > >   stable/viewporter: add more error cases
> > > > > > 
> > > > > >  Makefile.am  |   1 +
> > > > > >  stable/viewporter/README |   7 ++
> > > > > >  stable/viewporter/viewporter.xml | 189 
> > > > > > +++
> > > > > >  3 files changed, 197 insertions(+)
> > > > > >  create mode 100644 stable/viewporter/README
> > > > > >  create mode 100644 stable/viewporter/viewporter.xml
> > > > > 
> > > > > For landing these 5 wayland-protocol patches, either as stable or
> > > > > unstable, as Jonas decides:
> > > > > 
> > > > >   Acked-by: Bryce Harrington   
> > > 
> > > Recorded.
> > 
> > Hi,
> > 
> > the wayland-protocols patches are now pushed:
> >cc276df..83bdaa5  master -> master
> > 
> > Now we just need a wayland-protocols release. We should have a couple
> > of days for the last minute "oops" just in case.
> > 
> >   
> > > > >
> > > > > > Weston:
> > > > > > 
> > > > > > Pekka Paalanen (12):
> > > > > >   compositor: constify weston_surface_build_buffer_matrix()
> > > > > >   compositor: refactor into convert_size_by_transform_scale()
> > > > > >   compositor: migrate to stable viewporter.xml
> > > > > >   compositor: rename scaler to viewport(er)
> > > > > >   clients/scaler: migrate to wp_viewporter
> > > > > >   clients/simple-damage: migrate to wp_viewporter
> > > > > >   protocol: remove scaler.xml
> > > > > >   compositor: fix wp_viewport use after free
> > > > > >   compositor: check viewport source rect validity
> > > > > >   compositor: check viewport dst size validity
> > > > > >   compositor: fix wp_viewport.set_source errors
> > > > > >   tests: add wp_viewporter tests
> > > > 
> > > > The first two patches in this set don't depend on the protocol and look
> > > > fine to land during beta.  The rest I'm not sure about, they're a bit
> > > > more than a mere rename of the protocol and add functionality.  I don't
> > > > have anything against them but wouldn't want to land them on my R-b
> > > > alone, and unless they're particularly urgent it would be much more
> > > > comfortable to land them post-release.  I reviewed all the patches and
> > > > aside from the nitpicks already mentioned, for purposes of landing post
> > > > release you can consider them:
> > > > 
> > > > Reviewed-by: Bryce Harrington   
> > > 
> > > Recorded.
> > > 
> > > Yes, they missed 1.11 now, will be for 1.12, expect the first two I
> > > already pushed with your reviews.
> > 
> > This still holds, weston patches won't land until 1.11 is out.  
> 
> Hi all,
> 
> patches 8 - 17 are still in the queue. They apply to master today as
> is, the only thing I think that needs fixing is to update the
> wayland-protocols dependency, IIRC.
> 
> If I understood right, they already have:
> Reviewed-by: Bryce Harrington 
> Reviewed-by: Yong Bakos 
> 
> Hmm, Yong, did you give R-b for pathes 8-17? I'm not quite sure if "v3
> is Reviewed-by" means that.
> 
> Anyone else want to ack/nack?
> 
> If no-one replies, I'll push these patches on, say, Thursday with both
> Yong and

Re: [PATCH weston v3 7/8] Define the screensaver inhibitor client interface

2016-06-09 Thread Pekka Paalanen

On Wed, 8 Jun 2016 13:59:36 -0700
Bryce Harrington  wrote:

> On Thu, May 26, 2016 at 06:02:09PM +0300, Pekka Paalanen wrote:
> > On Thu,  7 Apr 2016 16:44:22 -0700
> > Bryce Harrington  wrote:
> >   
> > > Hook up the API defined in wayland-protocols to allow client screensaver
> > > inhibition requests.
> > > 
> > > Signed-off-by: Bryce Harrington 
> > > ---
> > > v2: Update for protocol rename
> > > 
> > >  Makefile.am  |  9 +++--
> > >  clients/simple-shm.c | 28 
> > >  2 files changed, 31 insertions(+), 6 deletions(-)  
> > 
> > Hi,
> > 
> > I would really wish we didn't add any more stuff into simple-shm, or
> > any of the simple-* clients, unless it is essential to them.
> > 
> > Something like the subsurfaces demo would be more suitable, that would
> > allow you to test the inhibi... hmm, wait, no, all subsurfaces there
> > are still inside the parent. I think you need a new test client that
> > creates a subsurface outside of the main surface, so you can test the
> > inhibitor inheritance.  
> 
> Given the subsurfaces stuff seems to still be a source of disagreement,
> and evidently is something I totally am not grokking, I don't want to
> get into implementing subsurface support.  The typical client won't be
> using subsurfaces, so a simpler demo would be more relevant for them.
> For clients that *do* use subsurfaces, well it sounds like they could
> have quite a diverse range of behavioral needs regarding inhibition, so
> making a good subsurface demo sounds like it could get rather involved.

Right.

> I do understand your point about wanting to avoid shoehorning more
> features into the simple-* clients; they're already kind of a hodge
> podge.  So I'll look at creating a new client like simple-shm that is
> boiled down to just showing off the inhibit feature with a single top
> level surface.

Cool.

I do not think they are that hodge-podge. If you want, I can list and
justify all features in each of them, I believe.


Thanks,
pq


pgpu5aRM710sH.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

2016-06-09 Thread Pekka Paalanen

On Wed, 8 Jun 2016 13:37:34 -0700
Bryce Harrington  wrote:

> On Wed, Jun 08, 2016 at 12:02:14PM +0300, Pekka Paalanen wrote:

> >
> > I stick to my simplest suggestion:
> > - inherit inhibition for sub-surfaces (by effectiveness, not by
> >   pretending the child has its own copy of the inhibitor to be
> >   evaluated separately)
> > - do not forbid inhibitors based on surface role
> > 
> > Otherwise we could discuss this to the death.  
> 
> We seem to already be doing this.
> 
> Frankly, I don't care one way or the other whether subsurfaces is even
> addressed in the protocol.  I included it at your request, in hopes it
> would make the protocol more landable, but honestly have never really
> understood what the point of it is for - thus my pushing for getting a
> tangible use case defined.  If that use case is so far from validity,
> then it really makes me think maybe this version of the protocol should
> just sidestep the question of subsurface behavior and leave it as follow
> up work, particularly after seeing the variety of questions and opinions
> that have been popping up.
> 
> But if you feel strongly that subsurfaces *must* be addressed in the
> protocol, then let me request this - provide me with *exact* text to
> paste in to replace that last paragraph.

Ok, let's go your way. FWIW, Quentin agrees with you even though he
didn't want to say it on the mailing list.

I will not object ignoring sub-surfaces any longer.

The concern raised in
https://lists.freedesktop.org/archives/wayland-devel/2016-March/027667.html
is theoretical so far. You can adress them when they actually arise.


Thanks,
pq


pgpYy5jR9X9VE.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH libinput] touchpad: don't warn about kernel jumps on semi-mt devices

Re: [PATCH weston v2 0/2] Separate Weston from libweston

[PATCH] desktop-shell: resize background and panel surfaces on output resize v4

[PATCH weston v2 2/2] Rename src/ to libweston/

[PATCH weston v2 1/2] Move weston source to compositor/

[PATCH weston v2 0/2] Separate Weston from libweston

Re: [PATCH libinput] evdev: check model flags for actual booleans

Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

Re: [PATCH weston 1/2] Move weston source to compositor/

Re: [PATCH weston 2/2] weston-launch: Allow the user to use her login shell

Re: [PATCH weston 1/2] weston-launch: Only run a login shell for new sessions

Re: [PATCH weston v3 7/8] Define the screensaver inhibitor client interface

Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter

Re: [PATCH weston v3 7/8] Define the screensaver inhibitor client interface

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

15 matches

Site Navigation

Mail list logo

Footer information