[PATCH libinput] touchpad: Allow larger palm sizes.

[Ronald Tschalär]

On MBP13,3 the touch areas are quite large, and a thumb size easily gets
to 1000+. Hence need to be able to set palm sizes > 1024 (using 1200
currently).
---
 src/libinput-util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libinput-util.c b/src/libinput-util.c
index c7cb2b4..48cb718 100644
--- a/src/libinput-util.c
+++ b/src/libinput-util.c
@@ -450,7 +450,7 @@ parse_palm_size_property(const char *prop)
if (!prop)
return 0;
 
-   if (!safe_atoi(prop, ) || thr < 0 || thr > 1024)
+   if (!safe_atoi(prop, ) || thr < 0 || thr > 2028)
return 0;
 
 return thr;
-- 
2.13.3

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 1/2] text-backend: Allow client hiding of input panel

[janarne]

On Sat, 2017-06-24 at 16:03 -0500, Joshua Watt wrote:
> Previously, the hide_input_panel and show_input_panel messages for
> the text
> input protocol were limited to specific cases, such as showing the
> panel on
> activation, or making the panel visible after activation. Now,
> clients are
> allowed to toggle the panel visiblity at will as long as they are the
> currently
> active client
> 
> Signed-off-by: Joshua Watt 

Thanks, both patches are improving the implementation in the right way:

Reviewed-by: Jan Arne Petersen 

> ---
>  compositor/text-backend.c | 22 --
>  1 file changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/compositor/text-backend.c b/compositor/text-backend.c
> index bf5c45c..6add101 100644
> --- a/compositor/text-backend.c
> +++ b/compositor/text-backend.c
> @@ -64,7 +64,7 @@ struct text_input_manager {
>   struct wl_global *text_input_manager_global;
>   struct wl_listener destroy_listener;
>  
> - struct text_input *current_panel;
> + struct text_input *current_text_input;
>  
>   struct weston_compositor *ec;
>  };
> @@ -140,11 +140,15 @@ deactivate_input_method(struct input_method
> *input_method)
>   input_method->context = NULL;
>  
>   if (wl_list_empty(_input->input_methods) &&
> - text_input->input_panel_visible) {
> + text_input->input_panel_visible &&
> + text_input->manager->current_text_input == text_input) {
>   wl_signal_emit(>hide_input_panel_signal, ec);
>   text_input->input_panel_visible = false;
> - text_input->manager->current_panel = NULL;
>   }
> +
> + if (text_input->manager->current_text_input == text_input)
> + text_input->manager->current_text_input = NULL;
> +
>   zwp_text_input_v1_send_leave(text_input->resource);
>  }
>  
> @@ -206,12 +210,11 @@ text_input_activate(struct wl_client *client,
>  
>   input_method_context_create(text_input, input_method);
>  
> - current = text_input->manager->current_panel;
> + current = text_input->manager->current_text_input;
>  
>   if (current && current != text_input) {
>   current->input_panel_visible = false;
>   wl_signal_emit(>hide_input_panel_signal, ec);
> - text_input->manager->current_panel = NULL;
>   }
>  
>   if (text_input->input_panel_visible) {
> @@ -219,8 +222,8 @@ text_input_activate(struct wl_client *client,
>  text_input->surface);
>   wl_signal_emit(>update_input_panel_signal,
>  _input->cursor_rectangle);
> - text_input->manager->current_panel = text_input;
>   }
> + text_input->manager->current_text_input = text_input;
>  
>   zwp_text_input_v1_send_enter(text_input->resource,
>text_input->surface->resource);
> @@ -335,7 +338,8 @@ text_input_show_input_panel(struct wl_client
> *client,
>  
>   text_input->input_panel_visible = true;
>  
> - if (!wl_list_empty(_input->input_methods)) {
> + if (!wl_list_empty(_input->input_methods) &&
> + text_input == text_input->manager->current_text_input) {
>   wl_signal_emit(>show_input_panel_signal,
>  text_input->surface);
>   wl_signal_emit(>update_input_panel_signal,
> @@ -353,10 +357,8 @@ text_input_hide_input_panel(struct wl_client
> *client,
>   text_input->input_panel_visible = false;
>  
>   if (!wl_list_empty(_input->input_methods) &&
> - text_input == text_input->manager->current_panel) {
> - text_input->manager->current_panel = NULL;
> + text_input == text_input->manager->current_text_input)
>   wl_signal_emit(>hide_input_panel_signal, ec);
> - }
>  }
>  
>  static void
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 1/2] text-backend: Allow client hiding of input panel

[Joshua Watt]

On Wed, 2017-07-19 at 17:48 +0200, Silvan Jegen wrote:
> On Wed, Jul 19, 2017 at 3:49 PM, Joshua Watt 
> wrote:
> > On Sun, 2017-07-09 at 21:26 +0200, Silvan Jegen wrote:
> > > Hi Joshua
> > > 
> > > On Wed, Jul 05, 2017 at 08:58:51AM -0500, Joshua Watt wrote:
> > > > On Sat, 2017-06-24 at 16:03 -0500, Joshua Watt wrote:
> > > > > Previously, the hide_input_panel and show_input_panel
> > > > > messages
> > > > > for
> > > > > the text
> > > > > input protocol were limited to specific cases, such as
> > > > > showing
> > > > > the
> > > > > panel on
> > > > > activation, or making the panel visible after activation.
> > > > > Now,
> > > > > clients are
> > > > > allowed to toggle the panel visiblity at will as long as they
> > > > > are
> > > > > the
> > > > > currently
> > > > > active client
> > > > > 
> > > > > Signed-off-by: Joshua Watt 
> > > > > ---
> > > > >  compositor/text-backend.c | 22 --
> > > > >  1 file changed, 12 insertions(+), 10 deletions(-)
> > > > > 
> > > > 
> > > > Ping?
> > > 
> > > I have tested your two patches locally and can confirm that they
> > > compile
> > > and run.
> > > 
> > > Letting the user toggle the visibility of the input panel with a
> > > click
> > > (in the --click-to-show case) seems like a good change to me. I
> > > doubt
> > > that there are any strong opinions on this though...
> > 
> > Any further updates on this?
> 
> We will have to wait for somebody with commit rights to chime in :)
> 
> I would be really interested in the next version of the
> text*protocols
> as well but development of them seems to have stalled for now,
> unfortunately. There was a new version forthcoming that is pending
> some changes. They have been pending for more than a year now though.

Any other comments?

> 
> 
> Cheers,
> 
> Silvan

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH] Use sysroot prefix for pkgdatadir variable

[Tomek Bury]

The pc_sysroot is automatically added to cflags and libs but not
to 'pkg-config --variable'
---
 wayland-protocols.pc.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/wayland-protocols.pc.in b/wayland-protocols.pc.in
index a26744c..379be06 100644
--- a/wayland-protocols.pc.in
+++ b/wayland-protocols.pc.in
@@ -1,6 +1,6 @@
 prefix=@prefix@
 datarootdir=@datarootdir@
-pkgdatadir=@datadir@/@PACKAGE@
+pkgdatadir=${pc_sysrootdir}@datadir@/@PACKAGE@
 
 Name: Wayland Protocols
 Description: Wayland protocol files
-- 
2.7.4

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH] Use sysroot prefix for pkgdatadir variable

[Tomek Bury]

From: Tomek Bury 

The pc_sysroot is automatically added to cflags and libs but not
to 'pkg-config --variable'
---
 wayland-protocols.pc.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/wayland-protocols.pc.in b/wayland-protocols.pc.in
index a26744c..379be06 100644
--- a/wayland-protocols.pc.in
+++ b/wayland-protocols.pc.in
@@ -1,6 +1,6 @@
 prefix=@prefix@
 datarootdir=@datarootdir@
-pkgdatadir=@datadir@/@PACKAGE@
+pkgdatadir=${pc_sysrootdir}@datadir@/@PACKAGE@
 
 Name: Wayland Protocols
 Description: Wayland protocol files
-- 
2.7.4

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols] sysroot prefix

[Tomek Bury]

Sorry for a delay, broke my leg :(

I'll send a patch without the extra "/" using git send-mail as soon as I
got that one configured.

Cheers,
Tomek


On Thu, Jul 20, 2017 at 10:45 AM Quentin Glidic <
sardemff7+wayl...@sardemff7.net> wrote:

> On 7/20/17 11:25 AM, Daniel Stone wrote:
> > Hi,
> >
> > On 20 July 2017 at 10:14, Quentin Glidic
> >  wrote:
> >> Using ${pc_sysrootdir} sounds like the correct thing to do. However,
> your
> >> patch introduces a triple / when PKG_CONFIG_SYSROOT_DIR is not set.
> >> Having two / is already trouble on some platform (though the one we
> >> currently work on should be fine, I think), three / would break even
> more.
> >> Please just use "${pc_sysrootdir}@datadir@".
> >
> > Yeah, this all LGTM, and gets my:
> > Reviewed-by: Daniel Stone 
> >
> >> Also, using this variable should be in prefix=, IMO, since all the paths
> >> should be fixed.
> >
> > I'm wary of doing that, if only because it establishes a pattern. It's
> > fine for wayland-protocols itself, but when doing sysroot builds,
> > includedir/libdir/etc already get prefixed by the compiler/linker. So
> > I wouldn't want anyone to look at wayland-protocols and blindly copy
> > the prepend to prefix. Containing it to just variables we know will be
> > used and queried directly seems more safe.
>
> pkg-config already prepends PKG_CONFIG_SYSROOT_DIR to --cflags and
> --libs (and properly handle it if you put it in prefix, i.e. no
> dublicate), so it is completely safe to have in all variables.
>
> --
>
> Quentin “Sardem FF7” Glidic
>
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[ANNOUNCE] libxkbcommon 0.7.2

[Ran Benita]

libxkbcommon 0.7.2
==

- Added a Meson build system as an alternative to existing autotools build
  system.

  The intent is to remove the autotools build in one of the next releases.
  Please try to convert to it and report any problems.

  See http://mesonbuild.com/Quick-guide.html for basic usage, the
  meson_options.txt for the project-specific configuration options,
  and the PACKAGING file for more details.

  There are some noteworthy differences compared to the autotools build:

  - Feature auto-detection is not performed. By default, all features are
enabled (currently: docs, x11, wayland). The build fails if any of
the required dependencies are not available. To disable a feature,
pass -Denable-=false to meson.

  - The libraries are either installed as shared or static, as specified
by the -Ddefault_library=shared/static option. With autotools, both
versions are installed by default.

  - xorg-util-macros is not used.

  - A parser generator (bison/byacc) is always required - there is no
fallback to pre-generated output bundled in the tarball, as there is
in autotools.

- Removed Android.mk support.

- Removed the *-uninstalled.pc pkgconfig files.

- Ported the interactive-wayland demo program to v6 of the xdg-shell
  protocol.

- Added new keysym definitions from xproto.

- New API:
  XKB_KEY_XF86Keyboard
  XKB_KEY_XF86WWAN
  XKB_KEY_XF86RFKill
  XKB_KEY_XF86AudioPreset


Tarballs:


git tag: xkbcommon-0.7.2

https://xkbcommon.org/download/libxkbcommon-0.7.2.tar.xz
MD5:f53fa65beb5ae4b6a6b7f08f9dedabc4  libxkbcommon-0.7.2.tar.xz
SHA1:   782c8eab3f5daaccc151e2a9f234456997b57d04  libxkbcommon-0.7.2.tar.xz
SHA256: 28a4dc2735863bec2dba238de07fcdff28c5dd2300ae9dfdb47282206cd9b9d8  
libxkbcommon-0.7.2.tar.xz


Ran
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel