[PATCH v7 wayland-protocols] virtual-keyboard: Add new virtual keyboard protocol

2019-09-27 Thread Dorota Czaplejewicz
Provides the ability to emulate keyboards by applications. Complementary to 
input-method protocol.

The interface is a mirror copy of wl_keyboard, with removed serials, and added 
seat binding.

Signed-off-by: Dorota Czaplejewicz 
---
Hello,

I've updated this patch with feedback from Petter Hutterer. The only changes 
are in the descriptions.

Regards,
Dorota Czaplejewicz

 Makefile.am   |   1 +
 unstable/virtual-keyboard/README  |   2 +
 .../virtual-keyboard-unstable-v1.xml  | 114 ++
 3 files changed, 117 insertions(+)
 create mode 100644 unstable/virtual-keyboard/README
 create mode 100644 unstable/virtual-keyboard/virtual-keyboard-unstable-v1.xml

diff --git a/Makefile.am b/Makefile.am
index 345ae6a..d62c380 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -20,6 +20,7 @@ unstable_protocols =  
\

unstable/keyboard-shortcuts-inhibit/keyboard-shortcuts-inhibit-unstable-v1.xml \
unstable/xdg-output/xdg-output-unstable-v1.xml  
\
unstable/input-timestamps/input-timestamps-unstable-v1.xml  \
+   unstable/virtual-keyboard/virtual-keyboard-unstable-v1.xml  \
unstable/xdg-decoration/xdg-decoration-unstable-v1.xml  \

unstable/linux-explicit-synchronization/linux-explicit-synchronization-unstable-v1.xml
 \
unstable/primary-selection/primary-selection-unstable-v1.xml
\
diff --git a/unstable/virtual-keyboard/README b/unstable/virtual-keyboard/README
new file mode 100644
index 000..a2c646d
--- /dev/null
+++ b/unstable/virtual-keyboard/README
@@ -0,0 +1,2 @@
+Virtual keyboard protocol
+
diff --git a/unstable/virtual-keyboard/virtual-keyboard-unstable-v1.xml 
b/unstable/virtual-keyboard/virtual-keyboard-unstable-v1.xml
new file mode 100644
index 000..9eae804
--- /dev/null
+++ b/unstable/virtual-keyboard/virtual-keyboard-unstable-v1.xml
@@ -0,0 +1,114 @@
+
+
+  
+Copyright © 2008-2011  Kristian Høgsberg
+Copyright © 2010-2013  Intel Corporation
+Copyright © 2012-2013  Collabora, Ltd.
+Copyright © 2018   Purism SPC
+
+Permission is hereby granted, free of charge, to any person obtaining a
+copy of this software and associated documentation files (the "Software"),
+to deal in the Software without restriction, including without limitation
+the rights to use, copy, modify, merge, publish, distribute, sublicense,
+and/or sell copies of the Software, and to permit persons to whom the
+Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice (including the next
+paragraph) shall be included in all copies or substantial portions of the
+Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+DEALINGS IN THE SOFTWARE.
+  
+
+  
+
+  The virtual keyboard provides an application with requests which emulate
+  the behaviour of a physical keyboard.
+
+  This interface can be used by clients on its own to provide raw input
+  events, or it can accompany the input method protocol.
+
+
+
+  
+Provide a file descriptor to the compositor which can be memory-mapped
+to provide a keyboard mapping description.
+  
+  
+  
+  
+
+
+
+  
+
+
+
+  
+A key was pressed or released.
+
+The time argument is a timestamp with millisecond granularity, with an
+undefined base. All requests regarding a single object must share the
+same clock.
+
+Keymap must be set before issuing this request.
+  
+  
+  
+  
+
+
+
+  
+Notifies the compositor that the modifier and/or group state has
+changed, and it should update state.
+
+Keymap must be set before issuing this request.
+  
+  
+  
+  
+  
+
+
+
+  
+
+  
+
+  
+
+  A virtual keyboard manager allows an application to provide keyboard
+  input events as if they came from a physical keyboard.
+
+  If the compositor enables a keyboard to perform arbitrary actions, it
+  should prevent untrusted clients from using this interface.
+
+
+
+  
+Creates a new virtual keyboard associated to a seat.
+  
+  
+  
+
+
+
+  
+Destroys the virtual keyboard manager.
+
+Existing zwp_virtual_keyboard_v1 objects remain valid.
+  
+
+  
+
-- 
2.20.1


Re: [PATCH wayland-protocols] xdg-shell: Add support for synchronized popup moving

2019-09-27 Thread Jonas Ådahl
On Tue, Aug 27, 2019 at 11:47:25PM +0100, David Edmundson wrote:
> set_reactive
> 
> Everything about this part makes sense.
> +1
> 
> 
> -
> 
> move request + moved
> 
> Concept of having explicit updating makes sense.
> Might be worth considering calling it xdg_popup.reposition as
> xdg_toplevel.move is very different

"reposition" sounds like a good name, thanks!

Maybe it should be "repositioned" too then.

> 
> Would it be valid to re-use the same positioner object each time?

I think so. A positioner is just a dump container of numbers and what
not, and when it's used, the contents are copied. Whether the client
want to reuse or destroy should be fine IMO.

> 
> Could we repurpose wl_display.sync as an alternative for the moved
> signal? Simply for code re-use.

I don't think so; the sync is replied to immediately by
libwayland-server, while a move may go through various hoops before
being processed.

> It slightly reverses the logic, but after your callback a client knows
> it definitely has the latest configure event for your move request.

The problem is consecutive reposition requests, where the compositor may
ignore one if another came after. Tying it to the configure_ack serial
helps dealing with all that.

> 
> -
> 
> sync_with_popup
> 
> In example A
> 
>  --> xdg_toplevel.configure(200, 600)
>  --> xdg_popup_surface.configure(3)
>  <-- xdg_popup_surface.ack_configure(3)
>  <-- xdg_popup_surface.sync_with_popup(xdg_popup)
> 
> Should this be xdg_toplevel_surface?

Yes, indeed. Well spotted.


Jonas
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel