Re: [PATCH 0/3] Add wl_output name event
On Wed, 19 Mar 2014 12:01:42 -0500 Jason Ekstrand ja...@jlekstrand.net wrote: Quaxian, I looked over the latest versions, and I think they all look good now from a technical perspective. I'm still not 100% sure that this is needed, but I think I'm ok with it. --Jason Ekstrand Hi, yeah, seems good to me, too. I might like to change the wording slightly so that the name event is guaranteed to be sent, and not only may be sent. I assume it is also supposed to belong to the set of state that is ended with the 'done' event, I guess that could be more clear, too. I imagine this would be useful also, if a client wants to show a menu with options to maximize or fullscreen onto a specific output. Listing the outputs by name would let the user know which is which. I guess presentation applications might like that to put something on the projector. Thanks, pq On Wed, Mar 19, 2014 at 12:30 AM, Quanxian Wang quanxian.w...@intel.comwrote: This event contains a human-readable name of output. It may be sent after binding the output object. It is intended that the client can use this output name as a parameter or display it in logs. For example, in weston randr application, output name can be a parameter in command line to stand for an output. Quanxian Wang (3): wayland: Add wl_output name event shell: Add wl_output name event weston:Add wl_output name event Wayland: protocol/wayland.xml | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) Shell: clients/desktop-shell.c | 12 ++-- clients/window.c| 12 ++-- 2 files changed, 20 insertions(+), 4 deletions(-) Weston: src/compositor.c| 7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) -- 1.8.1.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH 0/3] Add wl_output name event
Quaxian, I looked over the latest versions, and I think they all look good now from a technical perspective. I'm still not 100% sure that this is needed, but I think I'm ok with it. --Jason Ekstrand On Wed, Mar 19, 2014 at 12:30 AM, Quanxian Wang quanxian.w...@intel.comwrote: This event contains a human-readable name of output. It may be sent after binding the output object. It is intended that the client can use this output name as a parameter or display it in logs. For example, in weston randr application, output name can be a parameter in command line to stand for an output. Quanxian Wang (3): wayland: Add wl_output name event shell: Add wl_output name event weston:Add wl_output name event Wayland: protocol/wayland.xml | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) Shell: clients/desktop-shell.c | 12 ++-- clients/window.c| 12 ++-- 2 files changed, 20 insertions(+), 4 deletions(-) Weston: src/compositor.c| 7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) -- 1.8.1.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
RE: [PATCH 0/3] Add wl_output name event
From: Jason Ekstrand [mailto:ja...@jlekstrand.net] Sent: Thursday, March 20, 2014 1:02 AM To: Wang, Quanxian Cc: wayland-devel@lists.freedesktop.org; Bryce Harrington Subject: Re: [PATCH 0/3] Add wl_output name event Quaxian, I looked over the latest versions, and I think they all look good now from a technical perspective. I'm still not 100% sure that this is needed, but I think I'm ok with it. --Jason Ekstrand [Wang, Quanxian] That is fine. Thanks On Wed, Mar 19, 2014 at 12:30 AM, Quanxian Wang quanxian.w...@intel.commailto:quanxian.w...@intel.com wrote: This event contains a human-readable name of output. It may be sent after binding the output object. It is intended that the client can use this output name as a parameter or display it in logs. For example, in weston randr application, output name can be a parameter in command line to stand for an output. Quanxian Wang (3): wayland: Add wl_output name event shell: Add wl_output name event weston:Add wl_output name event Wayland: protocol/wayland.xml | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) Shell: clients/desktop-shell.c | 12 ++-- clients/window.c| 12 ++-- 2 files changed, 20 insertions(+), 4 deletions(-) Weston: src/compositor.c| 7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) -- 1.8.1.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH 0/3] Add wl_output name event
Apart from my phrasing suggestions on the first patch, the series looks good now, so feel free to add: Reviewed-by: Bryce Harrington b.harring...@samsung.com On Mon, Mar 17, 2014 at 11:34:49AM +0800, Quanxian Wang wrote: This event contains name of output. It may be sent after binding the output object. It is intended that client could input a character output name as a parameter or for log output. Mainly for client, provide a sensible character name instead of object. Quanxian Wang (3): wayland: Add wl_output name event shell: Add wl_output name event weston:Add wl_output name event Wayland: protocol/wayland.xml | 11 +++ 1 file changed, 11 insertions(+) Shell: clients/desktop-shell.c | 10 +- clients/window.c| 10 +- 2 files changed, 18 insertions(+), 2 deletions(-) Weston: src/compositor.c| 3 +++ 1 files changed, 3 insertions(+) -- 1.8.1.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
[PATCH 0/3] Add wl_output name event
This event contains a human-readable name of output. It may be sent after binding the output object. It is intended that the client can use this output name as a parameter or display it in logs. For example, in weston randr application, output name can be a parameter in command line to stand for an output. Quanxian Wang (3): wayland: Add wl_output name event shell: Add wl_output name event weston:Add wl_output name event Wayland: protocol/wayland.xml | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) Shell: clients/desktop-shell.c | 12 ++-- clients/window.c| 12 ++-- 2 files changed, 20 insertions(+), 4 deletions(-) Weston: src/compositor.c| 7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) -- 1.8.1.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
[PATCH 0/3] Add wl_output name event
This event contains name of output. It may be sent after binding the output object. It is intended that client could input a character output name as a parameter or for log output. Mainly for client, provide a sensible character name instead of object. Quanxian Wang (3): wayland: Add wl_output name event shell: Add wl_output name event weston:Add wl_output name event Wayland: protocol/wayland.xml | 11 +++ 1 file changed, 11 insertions(+) Shell: clients/desktop-shell.c | 10 +- clients/window.c| 10 +- 2 files changed, 18 insertions(+), 2 deletions(-) Weston: src/compositor.c| 3 +++ 1 files changed, 3 insertions(+) -- 1.8.1.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
[PATCH 0/3] Add wl_output name event
This event contains name of output. It may be sent after binding the output object. It is intended that client could input a character output name as a parameter or for log info. Mainly for client, provide a sensible character name instead of object. Quanxian Wang (3): wayland: Add wl_output name event shell: Add wl_output name event weston:Add wl_output name event Wayland: protocol/wayland.xml | 11 +++ 1 file changed, 11 insertions(+) Shell: clients/desktop-shell.c | 10 +- clients/window.c| 10 +- 2 files changed, 18 insertions(+), 2 deletions(-) Weston: src/compositor.c| 3 +++ 1 files changed, 3 insertions(+) -- 1.8.1.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
