Re: [PATCH wayland] protocol: Add note about per version requirements to wl_data_device_manager

2016-02-01 Thread Bryce Harrington 
On Mon, Jan 18, 2016 at 01:03:48PM +0100, Carlos Garnacho wrote:
> Hey Jonas,
> 
> On Mon, Jan 18, 2016 at 11:18 AM, Jonas Ådahl  wrote:
> > Add a note to the wl_data_device_manager global interface about the
> > different requirements for operating the objects created from the bound
> > global.
> >
> > Signed-off-by: Jonas Ådahl 
> > ---
> >
> > Pekka suggested we should add a note about the per version requirements
> > (wl_data_source.set_actions, wl_data_offer.accept and wl_data_offer.finish
> > during DND), see here is such a paragraph.
> 
> Oh indeed. Makes sense to mention this in wl_data_device_manager docs,
> 
> Reviewed-by: Carlos Garnacho 

Thanks, pushed:
To ssh://git.freedesktop.org/git/wayland/wayland
   ac36082..ed68095  master -> master

 
> Cheers,
>   Carlos
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH wayland] protocol: Add note about per version requirements to wl_data_device_manager

2016-01-18 Thread Jonas Ådahl 
Add a note to the wl_data_device_manager global interface about the
different requirements for operating the objects created from the bound
global.

Signed-off-by: Jonas Ådahl 
---

Pekka suggested we should add a note about the per version requirements
(wl_data_source.set_actions, wl_data_offer.accept and wl_data_offer.finish
during DND), see here is such a paragraph.


Jonas


 protocol/wayland.xml | 5 +
 1 file changed, 5 insertions(+)

diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index b223bb4..8739cd3 100644
--- a/protocol/wayland.xml
+++ b/protocol/wayland.xml
@@ -910,6 +910,11 @@
   copy-and-paste and drag-and-drop.  These mechanisms are tied to
   a wl_seat and this interface lets a client get a wl_data_device
   corresponding to a wl_seat.
+
+  Depending on the version bound, the objects created from the bound
+  wl_data_device_manager object will have different requirements for
+  functioning properly. See wl_data_source.set_actions,
+  wl_data_offer.accept and wl_data_offer.finish for details.
 
 
 
-- 
2.4.3

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland] protocol: Add note about per version requirements to wl_data_device_manager

2016-01-18 Thread Carlos Garnacho 
Hey Jonas,

On Mon, Jan 18, 2016 at 11:18 AM, Jonas Ådahl  wrote:
> Add a note to the wl_data_device_manager global interface about the
> different requirements for operating the objects created from the bound
> global.
>
> Signed-off-by: Jonas Ådahl 
> ---
>
> Pekka suggested we should add a note about the per version requirements
> (wl_data_source.set_actions, wl_data_offer.accept and wl_data_offer.finish
> during DND), see here is such a paragraph.

Oh indeed. Makes sense to mention this in wl_data_device_manager docs,

Reviewed-by: Carlos Garnacho 

Cheers,
  Carlos
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel