Re: [PATCH wayland] protocol: indentation fixes

[Daniel Stone]

Hi Bryce,

On 18 November 2016 at 00:42, Bryce Harrington  wrote:
> The patch isn't applying as of change 66a26aeb (remove inconsistent line
> breaks), but in generating a whitespace patch myself using emacs with
> the Wayland style rules, I am getting a similar looking set of changes.
> While whitespace changes are trivial, having these fixed would make
> automatic style tools a bit better able to detect and fix whitespace
> issues in the future.

How about http://editorconfig.org so it works in every editor?

Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland] protocol: indentation fixes

[Daniel Stone]

Hi Peter,

On 10 November 2016 at 05:02, Peter Hutterer  wrote:
> 8 spaces changed to one tab

Can't say I'm a massive fan of it personally, but that ship's already
sailed, so have applied this; well, manually reconstructed with sed
and taken your commit message / etc.

To ssh://git.freedesktop.org/git/wayland/wayland
   a2cbdef..a26ed09  master -> master

Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland] protocol: indentation fixes

[Peter Hutterer]

On Thu, Nov 17, 2016 at 04:42:07PM -0800, Bryce Harrington wrote:
> On Thu, Nov 10, 2016 at 03:02:06PM +1000, Peter Hutterer wrote:
> > 8 spaces changed to one tab
> > 
> > Signed-off-by: Peter Hutterer 
> 
> The patch isn't applying as of change 66a26aeb (remove inconsistent line
> breaks), but in generating a whitespace patch myself using emacs with
> the Wayland style rules, I am getting a similar looking set of changes.
> While whitespace changes are trivial, having these fixed would make
> automatic style tools a bit better able to detect and fix whitespace
> issues in the future.

do we have any plans for using those? The simplest case, detecting 8 spaces
where there should be a tab is a 3-line hack in the Makefile.am

Cheers,
   Peter

> 
> Acked-by: Bryce Harrington 
> 
> > ---
> >  protocol/wayland.xml | 100 
> > +--
> >  1 file changed, 50 insertions(+), 50 deletions(-)
> > 
> > diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> > index 6c6d078..bcc228f 100644
> > --- a/protocol/wayland.xml
> > +++ b/protocol/wayland.xml
> > @@ -129,7 +129,7 @@
> >  
> >
> > Binds a new, client-created object to the server using the
> > -specified name as the identifier.
> > +   specified name as the identifier.
> >
> >
> >
> > @@ -139,9 +139,9 @@
> >
> > Notify the client of global objects.
> >  
> > -The event notifies the client that a global object with
> > -the given name is now available, and it implements the
> > -given version of the given interface.
> > +   The event notifies the client that a global object with
> > +   the given name is now available, and it implements the
> > +   given version of the given interface.
> >
> >
> >
> > @@ -152,10 +152,10 @@
> >
> > Notify the client of removed global objects.
> >  
> > -This event notifies the client that the global identified
> > -by name is no longer available.  If the client bound to
> > -the global using the bind request, the client should now
> > -destroy that object.
> > +   This event notifies the client that the global identified
> > +   by name is no longer available.  If the client bound to
> > +   the global using the bind request, the client should now
> > +   destroy that object.
> >  
> > The object remains valid and requests to the object will be
> > ignored until the client destroys it, to avoid races between
> > @@ -357,7 +357,7 @@
> >  
> > The pool can be used to create shared memory based buffer
> > objects.  The server will mmap size bytes of the passed file
> > -descriptor, to use as backing memory for the pool.
> > +   descriptor, to use as backing memory for the pool.
> >
> >  
> >
> > @@ -924,14 +924,14 @@
> >  
> >  
> >
> > -Create a new data source.
> > +   Create a new data source.
> >
> > > summary="data source to create"/>
> >  
> >  
> >  
> >
> > -Create a new data device for a given seat.
> > +   Create a new data device for a given seat.
> >
> > > summary="data device to create"/>
> >
> > @@ -1320,7 +1320,7 @@
> >  
> >  
> >
> > -These errors can be emitted in response to wl_surface requests.
> > +   These errors can be emitted in response to wl_surface requests.
> >
> >
> >
> > @@ -1679,8 +1679,8 @@
> >  
> >  
> >
> > -This is a bitmask of capabilities this seat has; if a member is
> > -set, then it is present on the seat.
> > +   This is a bitmask of capabilities this seat has; if a member is
> > +   set, then it is present on the seat.
> >
> >
> >
> > @@ -1878,7 +1878,7 @@
> >  
> >  
> >
> > -Describes the physical state of a button that produced the button
> > +   Describes the physical state of a button that produced the button
> > event.
> >
> >
> > @@ -1891,8 +1891,8 @@
> >  
> > The location of the click is given by the last motion or
> > enter event.
> > -The time argument is a timestamp with millisecond
> > -granularity, with an undefined base.
> > +   The time argument is a timestamp with millisecond
> > +   granularity, with an undefined base.
> >
> >  
> >
> > @@ -2106,7 +2106,7 @@
> > >  summary="no keymap; client must understand how to interpret the 
> > raw keycode"/>
> > > - summary="libxkbcommon compatible; to determine the xkb 
> > keycode, clients must add 8 to the key event keycode"/>
> > +summary="libxkbcommon compatible; to determine the xkb keycode, 
> > clients must add 8 to the key event keycode"/>
> >  
> >  
> >  
> > @@ -2152,8 +2152,8 @@
> >  
> >
> > A key was pressed or 

Re: [PATCH wayland] protocol: indentation fixes

[Bryce Harrington]

On Thu, Nov 10, 2016 at 03:02:06PM +1000, Peter Hutterer wrote:
> 8 spaces changed to one tab
> 
> Signed-off-by: Peter Hutterer 

The patch isn't applying as of change 66a26aeb (remove inconsistent line
breaks), but in generating a whitespace patch myself using emacs with
the Wayland style rules, I am getting a similar looking set of changes.
While whitespace changes are trivial, having these fixed would make
automatic style tools a bit better able to detect and fix whitespace
issues in the future.

Acked-by: Bryce Harrington 

> ---
>  protocol/wayland.xml | 100 
> +--
>  1 file changed, 50 insertions(+), 50 deletions(-)
> 
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index 6c6d078..bcc228f 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -129,7 +129,7 @@
>  
>
>   Binds a new, client-created object to the server using the
> -specified name as the identifier.
> + specified name as the identifier.
>
>
>
> @@ -139,9 +139,9 @@
>
>   Notify the client of global objects.
>  
> -The event notifies the client that a global object with
> -the given name is now available, and it implements the
> -given version of the given interface.
> + The event notifies the client that a global object with
> + the given name is now available, and it implements the
> + given version of the given interface.
>
>
>
> @@ -152,10 +152,10 @@
>
>   Notify the client of removed global objects.
>  
> -This event notifies the client that the global identified
> -by name is no longer available.  If the client bound to
> -the global using the bind request, the client should now
> -destroy that object.
> + This event notifies the client that the global identified
> + by name is no longer available.  If the client bound to
> + the global using the bind request, the client should now
> + destroy that object.
>  
>   The object remains valid and requests to the object will be
>   ignored until the client destroys it, to avoid races between
> @@ -357,7 +357,7 @@
>  
>   The pool can be used to create shared memory based buffer
>   objects.  The server will mmap size bytes of the passed file
> -descriptor, to use as backing memory for the pool.
> + descriptor, to use as backing memory for the pool.
>
>  
>
> @@ -924,14 +924,14 @@
>  
>  
>
> -Create a new data source.
> + Create a new data source.
>
>
>  
>  
>  
>
> -Create a new data device for a given seat.
> + Create a new data device for a given seat.
>
>
>
> @@ -1320,7 +1320,7 @@
>  
>  
>
> -These errors can be emitted in response to wl_surface requests.
> + These errors can be emitted in response to wl_surface requests.
>
>
>
> @@ -1679,8 +1679,8 @@
>  
>  
>
> -This is a bitmask of capabilities this seat has; if a member is
> -set, then it is present on the seat.
> + This is a bitmask of capabilities this seat has; if a member is
> + set, then it is present on the seat.
>
>
>
> @@ -1878,7 +1878,7 @@
>  
>  
>
> -Describes the physical state of a button that produced the button
> + Describes the physical state of a button that produced the button
>   event.
>
>
> @@ -1891,8 +1891,8 @@
>  
>   The location of the click is given by the last motion or
>   enter event.
> -The time argument is a timestamp with millisecond
> -granularity, with an undefined base.
> + The time argument is a timestamp with millisecond
> + granularity, with an undefined base.
>
>  
>
> @@ -2106,7 +2106,7 @@
>summary="no keymap; client must understand how to interpret the 
> raw keycode"/>
> - summary="libxkbcommon compatible; to determine the xkb keycode, 
> clients must add 8 to the key event keycode"/>
> +  summary="libxkbcommon compatible; to determine the xkb keycode, 
> clients must add 8 to the key event keycode"/>
>  
>  
>  
> @@ -2152,8 +2152,8 @@
>  
>
>   A key was pressed or released.
> -The time argument is a timestamp with millisecond
> -granularity, with an undefined base.
> + The time argument is a timestamp with millisecond
> + granularity, with an undefined base.
>
>  
>
> @@ -2185,24 +2185,24 @@
>  
>  
>
> -Informs the client about the keyboard's repeat rate and delay.
> + Informs the client about the keyboard's repeat rate and delay.
>  
> -This event is sent as soon as the wl_keyboard object has been 
> 

[PATCH wayland] protocol: indentation fixes

[Peter Hutterer]

8 spaces changed to one tab

Signed-off-by: Peter Hutterer 
---
 protocol/wayland.xml | 100 +--
 1 file changed, 50 insertions(+), 50 deletions(-)

diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 6c6d078..bcc228f 100644
--- a/protocol/wayland.xml
+++ b/protocol/wayland.xml
@@ -129,7 +129,7 @@
 
   
Binds a new, client-created object to the server using the
-specified name as the identifier.
+   specified name as the identifier.
   
   
   
@@ -139,9 +139,9 @@
   
Notify the client of global objects.
 
-The event notifies the client that a global object with
-the given name is now available, and it implements the
-given version of the given interface.
+   The event notifies the client that a global object with
+   the given name is now available, and it implements the
+   given version of the given interface.
   
   
   
@@ -152,10 +152,10 @@
   
Notify the client of removed global objects.
 
-This event notifies the client that the global identified
-by name is no longer available.  If the client bound to
-the global using the bind request, the client should now
-destroy that object.
+   This event notifies the client that the global identified
+   by name is no longer available.  If the client bound to
+   the global using the bind request, the client should now
+   destroy that object.
 
The object remains valid and requests to the object will be
ignored until the client destroys it, to avoid races between
@@ -357,7 +357,7 @@
 
The pool can be used to create shared memory based buffer
objects.  The server will mmap size bytes of the passed file
-descriptor, to use as backing memory for the pool.
+   descriptor, to use as backing memory for the pool.
   
 
   
@@ -924,14 +924,14 @@
 
 
   
-Create a new data source.
+   Create a new data source.
   
   
 
 
 
   
-Create a new data device for a given seat.
+   Create a new data device for a given seat.
   
   
   
@@ -1320,7 +1320,7 @@
 
 
   
-These errors can be emitted in response to wl_surface requests.
+   These errors can be emitted in response to wl_surface requests.
   
   
   
@@ -1679,8 +1679,8 @@
 
 
   
-This is a bitmask of capabilities this seat has; if a member is
-set, then it is present on the seat.
+   This is a bitmask of capabilities this seat has; if a member is
+   set, then it is present on the seat.
   
   
   
@@ -1878,7 +1878,7 @@
 
 
   
-Describes the physical state of a button that produced the button
+   Describes the physical state of a button that produced the button
event.
   
   
@@ -1891,8 +1891,8 @@
 
The location of the click is given by the last motion or
enter event.
-The time argument is a timestamp with millisecond
-granularity, with an undefined base.
+   The time argument is a timestamp with millisecond
+   granularity, with an undefined base.
   
 
   
@@ -2106,7 +2106,7 @@
   
   
+summary="libxkbcommon compatible; to determine the xkb keycode, 
clients must add 8 to the key event keycode"/>
 
 
 
@@ -2152,8 +2152,8 @@
 
   
A key was pressed or released.
-The time argument is a timestamp with millisecond
-granularity, with an undefined base.
+   The time argument is a timestamp with millisecond
+   granularity, with an undefined base.
   
 
   
@@ -2185,24 +2185,24 @@
 
 
   
-Informs the client about the keyboard's repeat rate and delay.
+   Informs the client about the keyboard's repeat rate and delay.
 
-This event is sent as soon as the wl_keyboard object has been created,
-and is guaranteed to be received by the client before any key press
-event.
+   This event is sent as soon as the wl_keyboard object has been created,
+   and is guaranteed to be received by the client before any key press
+   event.
 
-Negative values for either rate or delay are illegal. A rate of zero
-will disable any repeating (regardless of the value of delay).
+   Negative values for either rate or delay are illegal. A rate of zero
+   will disable any repeating (regardless of the value of delay).
 
-This event can be sent later on as well with a new value if necessary,
-so clients should continue listening for the event past the creation
-of wl_keyboard.
+   This event can be sent later on as well with a new value if necessary,
+   so clients should continue listening for the event past the creation
+   of wl_keyboard.