Re: [PATCH weston] zunitc: remove `break` after `return`

2016-04-05 Thread Bryce Harrington
On Sat, Apr 02, 2016 at 05:02:41PM +0100, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom 

Reviewed-by: Bryce Harrington 

Pushed:
   c49aa5a..f8cdb24  master -> master


> ---
>  tools/zunitc/src/zuc_base_logger.c |  6 --
>  tools/zunitc/src/zunitc_impl.c | 11 ---
>  2 files changed, 17 deletions(-)
> 
> diff --git a/tools/zunitc/src/zuc_base_logger.c 
> b/tools/zunitc/src/zuc_base_logger.c
> index 1beb60d..cdbd9ea 100644
> --- a/tools/zunitc/src/zuc_base_logger.c
> +++ b/tools/zunitc/src/zuc_base_logger.c
> @@ -310,22 +310,16 @@ zuc_get_opstr(enum zuc_check_op op)
>   switch (op) {
>   case ZUC_OP_EQ:
>   return "=";
> - break;
>   case ZUC_OP_NE:
>   return "!=";
> - break;
>   case ZUC_OP_GE:
>   return ">=";
> - break;
>   case ZUC_OP_GT:
>   return ">";
> - break;
>   case ZUC_OP_LE:
>   return "<=";
> - break;
>   case ZUC_OP_LT:
>   return "<";
> - break;
>   default:
>   return "???";
>   }
> diff --git a/tools/zunitc/src/zunitc_impl.c b/tools/zunitc/src/zunitc_impl.c
> index 6f591f0..58a5b17 100644
> --- a/tools/zunitc/src/zunitc_impl.c
> +++ b/tools/zunitc/src/zunitc_impl.c
> @@ -1066,7 +1066,6 @@ spawn_test(struct zuc_test *test, void *test_data,
>  
>   zuc_cleanup();
>   exit(rc);
> - break;
>   }
>   default: { /* parent */
>   ssize_t rc = 0;
> @@ -1519,40 +1518,30 @@ get_pred2(enum zuc_check_op op, enum 
> zuc_check_valtype valtype)
>   switch (op) {
>   case ZUC_OP_TRUE:
>   return pred2_true;
> - break;
>   case ZUC_OP_FALSE:
>   return pred2_false;
> - break;
>   case ZUC_OP_NULL:
>   return pred2_false;
> - break;
>   case ZUC_OP_NOT_NULL:
>   return pred2_true;
> - break;
>   case ZUC_OP_EQ:
>   if (valtype == ZUC_VAL_CSTR)
>   return pred2_streq;
>   else
>   return pred2_eq;
> - break;
>   case ZUC_OP_NE:
>   if (valtype == ZUC_VAL_CSTR)
>   return pred2_strne;
>   else
>   return pred2_ne;
> - break;
>   case ZUC_OP_GE:
>   return pred2_ge;
> - break;
>   case ZUC_OP_GT:
>   return pred2_gt;
> - break;
>   case ZUC_OP_LE:
>   return pred2_le;
> - break;
>   case ZUC_OP_LT:
>   return pred2_lt;
> - break;
>   default:
>   return pred2_unknown;
>   }
> -- 
> 2.8.0
> 
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel


[PATCH weston] zunitc: remove `break` after `return`

2016-04-04 Thread Eric Engestrom
Signed-off-by: Eric Engestrom 
---
 tools/zunitc/src/zuc_base_logger.c |  6 --
 tools/zunitc/src/zunitc_impl.c | 11 ---
 2 files changed, 17 deletions(-)

diff --git a/tools/zunitc/src/zuc_base_logger.c 
b/tools/zunitc/src/zuc_base_logger.c
index 1beb60d..cdbd9ea 100644
--- a/tools/zunitc/src/zuc_base_logger.c
+++ b/tools/zunitc/src/zuc_base_logger.c
@@ -310,22 +310,16 @@ zuc_get_opstr(enum zuc_check_op op)
switch (op) {
case ZUC_OP_EQ:
return "=";
-   break;
case ZUC_OP_NE:
return "!=";
-   break;
case ZUC_OP_GE:
return ">=";
-   break;
case ZUC_OP_GT:
return ">";
-   break;
case ZUC_OP_LE:
return "<=";
-   break;
case ZUC_OP_LT:
return "<";
-   break;
default:
return "???";
}
diff --git a/tools/zunitc/src/zunitc_impl.c b/tools/zunitc/src/zunitc_impl.c
index 6f591f0..58a5b17 100644
--- a/tools/zunitc/src/zunitc_impl.c
+++ b/tools/zunitc/src/zunitc_impl.c
@@ -1066,7 +1066,6 @@ spawn_test(struct zuc_test *test, void *test_data,
 
zuc_cleanup();
exit(rc);
-   break;
}
default: { /* parent */
ssize_t rc = 0;
@@ -1519,40 +1518,30 @@ get_pred2(enum zuc_check_op op, enum zuc_check_valtype 
valtype)
switch (op) {
case ZUC_OP_TRUE:
return pred2_true;
-   break;
case ZUC_OP_FALSE:
return pred2_false;
-   break;
case ZUC_OP_NULL:
return pred2_false;
-   break;
case ZUC_OP_NOT_NULL:
return pred2_true;
-   break;
case ZUC_OP_EQ:
if (valtype == ZUC_VAL_CSTR)
return pred2_streq;
else
return pred2_eq;
-   break;
case ZUC_OP_NE:
if (valtype == ZUC_VAL_CSTR)
return pred2_strne;
else
return pred2_ne;
-   break;
case ZUC_OP_GE:
return pred2_ge;
-   break;
case ZUC_OP_GT:
return pred2_gt;
-   break;
case ZUC_OP_LE:
return pred2_le;
-   break;
case ZUC_OP_LT:
return pred2_lt;
-   break;
default:
return pred2_unknown;
}
-- 
2.8.0

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel