subject:"\[PATCH weston 1\/2\] Move weston source to compositor\/"

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-09 Thread Pekka Paalanen

On Mon, 6 Jun 2016 16:01:03 +0300
Giulio Camuffo  wrote:

> 2016-06-06 15:52 GMT+03:00 Pekka Paalanen :
> > On Sun, 5 Jun 2016 21:50:33 +0300
> > Giulio Camuffo  wrote:
> >  
> >> 2016-06-03 17:33 GMT+03:00 Pekka Paalanen :  
> >> > From: Pekka Paalanen 
> >> >
> >> > This is the start of separating weston-the-compositor source files from
> >> > libweston source files.
> >> >
> >> > This is moving all the files related to the 'weston' binary. Also the
> >> > CMS and systemd plugins are moved.
> >> >
> >> > xwayland plugin is not moved, because it will be turned into a
> >> > libweston feature.
> >> >
> >> > To avoid breaking the build, #includes for weston.h are fixed to use
> >> > compositor/weston.h. This serves as a reminder that such files may need
> >> > further attention: moving to the right directory, or maybe using the
> >> > proper -I flags instead.  
> >>
> >> I guess you should move weston-launch too, since it currently cannot
> >> be used by other compositors.  
> >
> > That's true. OTOH, would we like to make it usable for others?
> > Should it be installed with libweston, perhaps under a generic name?  
> 
> I think we should...
> 
> >
> > But can it even be safely made usable for launching arbitrary programs?
> > By design, it would offer the user access to input and DRM devices as
> > root. If it can offer the services to any program, a malicious program
> > can use it to start listening on input devices.  
> 
> but indeed this is the question, and i don't know. I will try to think
> of a way but until then i think it makes sense to keep it with weston.
> On the other hand maybe it's just unnecessary noise if we want to move
> it back later...

Right. IMHO, let's not move it yet but add a note in the README about it.

> >
> > Yes, I suppose I should move it. However, launcher-util has code
> > specific to weston-launch. I could move weston-launch.c but not
> > weston-launch.h.
> >
> > Other opinions on moving weston-launch.c to compositor/?
> >
> > Should I also move screen-share.c to compositor/?

I'll also move screen-share.c to compositor/.

Will re-post the move.


Thanks,
pq


pgptDDzMZ7aFz.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-06 Thread Giulio Camuffo

2016-06-06 15:52 GMT+03:00 Pekka Paalanen :
> On Sun, 5 Jun 2016 21:50:33 +0300
> Giulio Camuffo  wrote:
>
>> 2016-06-03 17:33 GMT+03:00 Pekka Paalanen :
>> > From: Pekka Paalanen 
>> >
>> > This is the start of separating weston-the-compositor source files from
>> > libweston source files.
>> >
>> > This is moving all the files related to the 'weston' binary. Also the
>> > CMS and systemd plugins are moved.
>> >
>> > xwayland plugin is not moved, because it will be turned into a
>> > libweston feature.
>> >
>> > To avoid breaking the build, #includes for weston.h are fixed to use
>> > compositor/weston.h. This serves as a reminder that such files may need
>> > further attention: moving to the right directory, or maybe using the
>> > proper -I flags instead.
>>
>> I guess you should move weston-launch too, since it currently cannot
>> be used by other compositors.
>
> That's true. OTOH, would we like to make it usable for others?
> Should it be installed with libweston, perhaps under a generic name?

I think we should...

>
> But can it even be safely made usable for launching arbitrary programs?
> By design, it would offer the user access to input and DRM devices as
> root. If it can offer the services to any program, a malicious program
> can use it to start listening on input devices.

but indeed this is the question, and i don't know. I will try to think
of a way but until then i think it makes sense to keep it with weston.
On the other hand maybe it's just unnecessary noise if we want to move
it back later...

>
> Yes, I suppose I should move it. However, launcher-util has code
> specific to weston-launch. I could move weston-launch.c but not
> weston-launch.h.
>
> Other opinions on moving weston-launch.c to compositor/?
>
> Should I also move screen-share.c to compositor/?
>
>
> Thanks,
> pq
>
>> >
>> > Signed-off-by: Pekka Paalanen 
>> > ---
>> >  Makefile.am| 26 +-
>> >  {src => compositor}/cms-colord.c   |  0
>> >  {src => compositor}/cms-helper.c   |  0
>> >  {src => compositor}/cms-helper.h   |  0
>> >  {src => compositor}/cms-static.c   |  0
>> >  {src => compositor}/main.c |  0
>> >  {src => compositor}/systemd-notify.c   |  0
>> >  {src => compositor}/text-backend.c |  0
>> >  {src => compositor}/weston-screenshooter.c |  0
>> >  {src => compositor}/weston.desktop |  0
>> >  {src => compositor}/weston.h   |  0
>> >  {src => compositor}/weston.pc.in   |  0
>> >  configure.ac   |  2 +-
>> >  desktop-shell/shell.c  |  2 +-
>> >  ivi-shell/hmi-controller.c |  2 +-
>> >  ivi-shell/ivi-layout.c |  2 +-
>> >  ivi-shell/ivi-shell.c  |  2 +-
>> >  tests/ivi_layout-test-plugin.c |  2 +-
>> >  tests/weston-test.c|  2 +-
>> >  xwayland/launcher.c|  2 +-
>> >  xwayland/xwayland.h|  2 +-
>> >  21 files changed, 22 insertions(+), 22 deletions(-)
>> >  rename {src => compositor}/cms-colord.c (100%)
>> >  rename {src => compositor}/cms-helper.c (100%)
>> >  rename {src => compositor}/cms-helper.h (100%)
>> >  rename {src => compositor}/cms-static.c (100%)
>> >  rename {src => compositor}/main.c (100%)
>> >  rename {src => compositor}/systemd-notify.c (100%)
>> >  rename {src => compositor}/text-backend.c (100%)
>> >  rename {src => compositor}/weston-screenshooter.c (100%)
>> >  rename {src => compositor}/weston.desktop (100%)
>> >  rename {src => compositor}/weston.h (100%)
>> >  rename {src => compositor}/weston.pc.in (100%)
>> >
>> > diff --git a/Makefile.am b/Makefile.am
>> > index d1d2178..bdb929c 100644
>> > --- a/Makefile.am
>> > +++ b/Makefile.am
>> > @@ -113,7 +113,7 @@ systemd_notify_la_CFLAGS =  \
>> > $(PIXMAN_CFLAGS)\
>> > $(AM_CFLAGS)
>> >  systemd_notify_la_SOURCES =\
>> > -   src/systemd-notify.c\
>> > +   compositor/systemd-notify.c \
>> > shared/helpers.h\
>> > shared/zalloc.h \
>> > src/compositor.h
>> > @@ -148,9 +148,9 @@ weston_LDADD = $(COMPOSITOR_LIBS) $(LIBUNWIND_LIBS) \
>> > -lm libshared.la libweston.la
>> >
>> >  weston_SOURCES =   \
>> > -   src/main.c  \
>> > -   src/weston-screenshooter.c  \
>> > -   src/text-backend.c
>> > +   compositor/main.c   \
>> > +   compositor/weston-screenshooter.c   \
>> > +   compositor/text-backend.c
>> >
>> >  # Track this dependency explicitly

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-06 Thread Pekka Paalanen

On Sun, 5 Jun 2016 21:50:33 +0300
Giulio Camuffo  wrote:

> 2016-06-03 17:33 GMT+03:00 Pekka Paalanen :
> > From: Pekka Paalanen 
> >
> > This is the start of separating weston-the-compositor source files from
> > libweston source files.
> >
> > This is moving all the files related to the 'weston' binary. Also the
> > CMS and systemd plugins are moved.
> >
> > xwayland plugin is not moved, because it will be turned into a
> > libweston feature.
> >
> > To avoid breaking the build, #includes for weston.h are fixed to use
> > compositor/weston.h. This serves as a reminder that such files may need
> > further attention: moving to the right directory, or maybe using the
> > proper -I flags instead.  
> 
> I guess you should move weston-launch too, since it currently cannot
> be used by other compositors.

That's true. OTOH, would we like to make it usable for others?
Should it be installed with libweston, perhaps under a generic name?

But can it even be safely made usable for launching arbitrary programs?
By design, it would offer the user access to input and DRM devices as
root. If it can offer the services to any program, a malicious program
can use it to start listening on input devices.

Yes, I suppose I should move it. However, launcher-util has code
specific to weston-launch. I could move weston-launch.c but not
weston-launch.h.

Other opinions on moving weston-launch.c to compositor/?

Should I also move screen-share.c to compositor/?


Thanks,
pq

> >
> > Signed-off-by: Pekka Paalanen 
> > ---
> >  Makefile.am| 26 +-
> >  {src => compositor}/cms-colord.c   |  0
> >  {src => compositor}/cms-helper.c   |  0
> >  {src => compositor}/cms-helper.h   |  0
> >  {src => compositor}/cms-static.c   |  0
> >  {src => compositor}/main.c |  0
> >  {src => compositor}/systemd-notify.c   |  0
> >  {src => compositor}/text-backend.c |  0
> >  {src => compositor}/weston-screenshooter.c |  0
> >  {src => compositor}/weston.desktop |  0
> >  {src => compositor}/weston.h   |  0
> >  {src => compositor}/weston.pc.in   |  0
> >  configure.ac   |  2 +-
> >  desktop-shell/shell.c  |  2 +-
> >  ivi-shell/hmi-controller.c |  2 +-
> >  ivi-shell/ivi-layout.c |  2 +-
> >  ivi-shell/ivi-shell.c  |  2 +-
> >  tests/ivi_layout-test-plugin.c |  2 +-
> >  tests/weston-test.c|  2 +-
> >  xwayland/launcher.c|  2 +-
> >  xwayland/xwayland.h|  2 +-
> >  21 files changed, 22 insertions(+), 22 deletions(-)
> >  rename {src => compositor}/cms-colord.c (100%)
> >  rename {src => compositor}/cms-helper.c (100%)
> >  rename {src => compositor}/cms-helper.h (100%)
> >  rename {src => compositor}/cms-static.c (100%)
> >  rename {src => compositor}/main.c (100%)
> >  rename {src => compositor}/systemd-notify.c (100%)
> >  rename {src => compositor}/text-backend.c (100%)
> >  rename {src => compositor}/weston-screenshooter.c (100%)
> >  rename {src => compositor}/weston.desktop (100%)
> >  rename {src => compositor}/weston.h (100%)
> >  rename {src => compositor}/weston.pc.in (100%)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index d1d2178..bdb929c 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -113,7 +113,7 @@ systemd_notify_la_CFLAGS =  \
> > $(PIXMAN_CFLAGS)\
> > $(AM_CFLAGS)
> >  systemd_notify_la_SOURCES =\
> > -   src/systemd-notify.c\
> > +   compositor/systemd-notify.c \
> > shared/helpers.h\
> > shared/zalloc.h \
> > src/compositor.h
> > @@ -148,9 +148,9 @@ weston_LDADD = $(COMPOSITOR_LIBS) $(LIBUNWIND_LIBS) \
> > -lm libshared.la libweston.la
> >
> >  weston_SOURCES =   \
> > -   src/main.c  \
> > -   src/weston-screenshooter.c  \
> > -   src/text-backend.c
> > +   compositor/main.c   \
> > +   compositor/weston-screenshooter.c   \
> > +   compositor/text-backend.c
> >
> >  # Track this dependency explicitly instead of using BUILT_SOURCES.  We
> >  # add BUILT_SOURCES to CLEANFILES, but we want to keep git-version.h
> > @@ -220,10 +220,10 @@ endif
> >  endif # BUILD_WESTON_LAUNCH
> >
> >  pkgconfigdir = $(libdir)/pkgconfig
> > -pkgconfig_DATA = src/weston.pc src/libweston-${LIBWESTON_ABI_VERSION}.pc
> > +pkgconfig_DATA = compositor/weston.pc 
> > src/libweston-${LIBWESTON_ABI_VERSION}.pc
> >
> >  wayland_sessiondir =

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-05 Thread Giulio Camuffo

2016-06-03 17:33 GMT+03:00 Pekka Paalanen :
> From: Pekka Paalanen 
>
> This is the start of separating weston-the-compositor source files from
> libweston source files.
>
> This is moving all the files related to the 'weston' binary. Also the
> CMS and systemd plugins are moved.
>
> xwayland plugin is not moved, because it will be turned into a
> libweston feature.
>
> To avoid breaking the build, #includes for weston.h are fixed to use
> compositor/weston.h. This serves as a reminder that such files may need
> further attention: moving to the right directory, or maybe using the
> proper -I flags instead.

I guess you should move weston-launch too, since it currently cannot
be used by other compositors.

Cheers,
Giulio

>
> Signed-off-by: Pekka Paalanen 
> ---
>  Makefile.am| 26 +-
>  {src => compositor}/cms-colord.c   |  0
>  {src => compositor}/cms-helper.c   |  0
>  {src => compositor}/cms-helper.h   |  0
>  {src => compositor}/cms-static.c   |  0
>  {src => compositor}/main.c |  0
>  {src => compositor}/systemd-notify.c   |  0
>  {src => compositor}/text-backend.c |  0
>  {src => compositor}/weston-screenshooter.c |  0
>  {src => compositor}/weston.desktop |  0
>  {src => compositor}/weston.h   |  0
>  {src => compositor}/weston.pc.in   |  0
>  configure.ac   |  2 +-
>  desktop-shell/shell.c  |  2 +-
>  ivi-shell/hmi-controller.c |  2 +-
>  ivi-shell/ivi-layout.c |  2 +-
>  ivi-shell/ivi-shell.c  |  2 +-
>  tests/ivi_layout-test-plugin.c |  2 +-
>  tests/weston-test.c|  2 +-
>  xwayland/launcher.c|  2 +-
>  xwayland/xwayland.h|  2 +-
>  21 files changed, 22 insertions(+), 22 deletions(-)
>  rename {src => compositor}/cms-colord.c (100%)
>  rename {src => compositor}/cms-helper.c (100%)
>  rename {src => compositor}/cms-helper.h (100%)
>  rename {src => compositor}/cms-static.c (100%)
>  rename {src => compositor}/main.c (100%)
>  rename {src => compositor}/systemd-notify.c (100%)
>  rename {src => compositor}/text-backend.c (100%)
>  rename {src => compositor}/weston-screenshooter.c (100%)
>  rename {src => compositor}/weston.desktop (100%)
>  rename {src => compositor}/weston.h (100%)
>  rename {src => compositor}/weston.pc.in (100%)
>
> diff --git a/Makefile.am b/Makefile.am
> index d1d2178..bdb929c 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -113,7 +113,7 @@ systemd_notify_la_CFLAGS =  \
> $(PIXMAN_CFLAGS)\
> $(AM_CFLAGS)
>  systemd_notify_la_SOURCES =\
> -   src/systemd-notify.c\
> +   compositor/systemd-notify.c \
> shared/helpers.h\
> shared/zalloc.h \
> src/compositor.h
> @@ -148,9 +148,9 @@ weston_LDADD = $(COMPOSITOR_LIBS) $(LIBUNWIND_LIBS) \
> -lm libshared.la libweston.la
>
>  weston_SOURCES =   \
> -   src/main.c  \
> -   src/weston-screenshooter.c  \
> -   src/text-backend.c
> +   compositor/main.c   \
> +   compositor/weston-screenshooter.c   \
> +   compositor/text-backend.c
>
>  # Track this dependency explicitly instead of using BUILT_SOURCES.  We
>  # add BUILT_SOURCES to CLEANFILES, but we want to keep git-version.h
> @@ -220,10 +220,10 @@ endif
>  endif # BUILD_WESTON_LAUNCH
>
>  pkgconfigdir = $(libdir)/pkgconfig
> -pkgconfig_DATA = src/weston.pc src/libweston-${LIBWESTON_ABI_VERSION}.pc
> +pkgconfig_DATA = compositor/weston.pc 
> src/libweston-${LIBWESTON_ABI_VERSION}.pc
>
>  wayland_sessiondir = $(datadir)/wayland-sessions
> -dist_wayland_session_DATA = src/weston.desktop
> +dist_wayland_session_DATA = compositor/weston.desktop
>
>  libwestonincludedir = $(includedir)/libweston-${LIBWESTON_ABI_VERSION}
>  libwestoninclude_HEADERS = \
> @@ -242,7 +242,7 @@ libwestoninclude_HEADERS =  \
> shared/platform.h
>
>  westonincludedir = $(includedir)/weston
> -westoninclude_HEADERS = src/weston.h
> +westoninclude_HEADERS = compositor/weston.h
>
>  if ENABLE_IVI_SHELL
>  westoninclude_HEADERS +=   \
> @@ -401,9 +401,9 @@ cms_static_la_LDFLAGS = -module -avoid-version
>  cms_static_la_LIBADD = $(COMPOSITOR_LIBS) $(LCMS_LIBS) libshared.la
>  cms_static_la_CFLAGS = $(AM_CFLAGS) $(COMPOSITOR_CFLAGS) $(LCMS_CFLAGS)
>  cms_static_la_SOURCES =\
> -   src/cms-static.c\
> -

[PATCH weston 1/2] Move weston source to compositor/

2016-06-03 Thread Pekka Paalanen

From: Pekka Paalanen 

This is the start of separating weston-the-compositor source files from
libweston source files.

This is moving all the files related to the 'weston' binary. Also the
CMS and systemd plugins are moved.

xwayland plugin is not moved, because it will be turned into a
libweston feature.

To avoid breaking the build, #includes for weston.h are fixed to use
compositor/weston.h. This serves as a reminder that such files may need
further attention: moving to the right directory, or maybe using the
proper -I flags instead.

Signed-off-by: Pekka Paalanen 
---
 Makefile.am| 26 +-
 {src => compositor}/cms-colord.c   |  0
 {src => compositor}/cms-helper.c   |  0
 {src => compositor}/cms-helper.h   |  0
 {src => compositor}/cms-static.c   |  0
 {src => compositor}/main.c |  0
 {src => compositor}/systemd-notify.c   |  0
 {src => compositor}/text-backend.c |  0
 {src => compositor}/weston-screenshooter.c |  0
 {src => compositor}/weston.desktop |  0
 {src => compositor}/weston.h   |  0
 {src => compositor}/weston.pc.in   |  0
 configure.ac   |  2 +-
 desktop-shell/shell.c  |  2 +-
 ivi-shell/hmi-controller.c |  2 +-
 ivi-shell/ivi-layout.c |  2 +-
 ivi-shell/ivi-shell.c  |  2 +-
 tests/ivi_layout-test-plugin.c |  2 +-
 tests/weston-test.c|  2 +-
 xwayland/launcher.c|  2 +-
 xwayland/xwayland.h|  2 +-
 21 files changed, 22 insertions(+), 22 deletions(-)
 rename {src => compositor}/cms-colord.c (100%)
 rename {src => compositor}/cms-helper.c (100%)
 rename {src => compositor}/cms-helper.h (100%)
 rename {src => compositor}/cms-static.c (100%)
 rename {src => compositor}/main.c (100%)
 rename {src => compositor}/systemd-notify.c (100%)
 rename {src => compositor}/text-backend.c (100%)
 rename {src => compositor}/weston-screenshooter.c (100%)
 rename {src => compositor}/weston.desktop (100%)
 rename {src => compositor}/weston.h (100%)
 rename {src => compositor}/weston.pc.in (100%)

diff --git a/Makefile.am b/Makefile.am
index d1d2178..bdb929c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -113,7 +113,7 @@ systemd_notify_la_CFLAGS =  \
$(PIXMAN_CFLAGS)\
$(AM_CFLAGS)
 systemd_notify_la_SOURCES =\
-   src/systemd-notify.c\
+   compositor/systemd-notify.c \
shared/helpers.h\
shared/zalloc.h \
src/compositor.h
@@ -148,9 +148,9 @@ weston_LDADD = $(COMPOSITOR_LIBS) $(LIBUNWIND_LIBS) \
-lm libshared.la libweston.la
 
 weston_SOURCES =   \
-   src/main.c  \
-   src/weston-screenshooter.c  \
-   src/text-backend.c
+   compositor/main.c   \
+   compositor/weston-screenshooter.c   \
+   compositor/text-backend.c
 
 # Track this dependency explicitly instead of using BUILT_SOURCES.  We
 # add BUILT_SOURCES to CLEANFILES, but we want to keep git-version.h
@@ -220,10 +220,10 @@ endif
 endif # BUILD_WESTON_LAUNCH
 
 pkgconfigdir = $(libdir)/pkgconfig
-pkgconfig_DATA = src/weston.pc src/libweston-${LIBWESTON_ABI_VERSION}.pc
+pkgconfig_DATA = compositor/weston.pc src/libweston-${LIBWESTON_ABI_VERSION}.pc
 
 wayland_sessiondir = $(datadir)/wayland-sessions
-dist_wayland_session_DATA = src/weston.desktop
+dist_wayland_session_DATA = compositor/weston.desktop
 
 libwestonincludedir = $(includedir)/libweston-${LIBWESTON_ABI_VERSION}
 libwestoninclude_HEADERS = \
@@ -242,7 +242,7 @@ libwestoninclude_HEADERS =  \
shared/platform.h
 
 westonincludedir = $(includedir)/weston
-westoninclude_HEADERS = src/weston.h
+westoninclude_HEADERS = compositor/weston.h
 
 if ENABLE_IVI_SHELL
 westoninclude_HEADERS +=   \
@@ -401,9 +401,9 @@ cms_static_la_LDFLAGS = -module -avoid-version
 cms_static_la_LIBADD = $(COMPOSITOR_LIBS) $(LCMS_LIBS) libshared.la
 cms_static_la_CFLAGS = $(AM_CFLAGS) $(COMPOSITOR_CFLAGS) $(LCMS_CFLAGS)
 cms_static_la_SOURCES =\
-   src/cms-static.c\
-   src/cms-helper.c\
-   src/cms-helper.h\
+   compositor/cms-static.c \
+   compositor/cms-helper.c \
+   compositor/cms-helper.h \
shared/helpers.h
 if ENABLE_COLORD
 module_LTLIBRARIES += cms-colord.la
@@ -411,9 +411,9 @@

Re: [PATCH weston 1/2] Move weston source to compositor/

Re: [PATCH weston 1/2] Move weston source to compositor/

Re: [PATCH weston 1/2] Move weston source to compositor/

Re: [PATCH weston 1/2] Move weston source to compositor/

[PATCH weston 1/2] Move weston source to compositor/

5 matches

Site Navigation

Mail list logo

Footer information