Re: [PATCH weston 1/2] automake: list the the builddir include before the srcdir
On 5 July 2016 at 13:16, Quentin Glidic wrote: > On 04/07/2016 15:57, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Otherwise we'll pick up the stale (in-tree) generated source(s) over the >> fresh (out-of-tree) ones. >> >> Signed-off-by: Emil Velikov >> --- >> It's quite a corner case, although it could save you a lot of time >> debugging. >> --- > > > If the source directory is in a configured state, the configure script will > refuse to configure an out-of-tree build. That means these files are > leftovers from either a previous build or the dist tarball, I guess. > In both cases, they should be added to CLEANFILES or DISTCLEANFILES. > > In the meantime, this fix is not bad: > Reviewed-by: Quentin Glidic > The issue is present when working with git as well: - Attempt/do an in-tree build or otherwise generate the files. - Forget that the files are around and attempt and out-of tree build. - Boom. Whether to add them to CLEANFILES or DISTCLEANFILES depends on the policy adopted by the project. I've seen some which prefer to _keep_ all the generated files on make clean. Others do that only for release tarballs, while others... > In the meantime, this fix is not bad: > Reviewed-by: Quentin Glidic > Hope that's the British definition of "not bad" :-) Thanks Emil ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH weston 1/2] automake: list the the builddir include before the srcdir
On 04/07/2016 15:57, Emil Velikov wrote: From: Emil Velikov Otherwise we'll pick up the stale (in-tree) generated source(s) over the fresh (out-of-tree) ones. Signed-off-by: Emil Velikov --- It's quite a corner case, although it could save you a lot of time debugging. --- If the source directory is in a configured state, the configure script will refuse to configure an out-of-tree build. That means these files are leftovers from either a previous build or the dist tarball, I guess. In both cases, they should be added to CLEANFILES or DISTCLEANFILES. In the meantime, this fix is not bad: Reviewed-by: Quentin Glidic Cheers, -- Quentin “Sardem FF7” Glidic ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
[PATCH weston 1/2] automake: list the the builddir include before the srcdir
From: Emil Velikov Otherwise we'll pick up the stale (in-tree) generated source(s) over the fresh (out-of-tree) ones. Signed-off-by: Emil Velikov --- It's quite a corner case, although it could save you a lot of time debugging. --- Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index 436bb1b..60d3bc1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -44,8 +44,8 @@ all-local : weston.ini ivi-shell/weston.ini AM_CFLAGS = $(GCC_CFLAGS) AM_CPPFLAGS = \ - -I$(top_srcdir)/libweston \ -I$(top_builddir)/libweston \ + -I$(top_srcdir)/libweston \ -I$(top_builddir)/clients \ -I$(top_builddir)/tests \ -I$(top_srcdir)/shared \ @@ -842,8 +842,8 @@ module_LTLIBRARIES += desktop-shell.la desktop_shell_la_CPPFLAGS =\ -I$(top_builddir)/protocol \ -I$(top_srcdir)/shared \ - -I$(top_srcdir)/libweston \ -I$(top_builddir)/libweston \ + -I$(top_srcdir)/libweston \ -I$(top_builddir)/desktop-shell \ -DDATADIR='"$(datadir)"'\ -DMODULEDIR='"$(moduledir)"'\ @@ -875,8 +875,8 @@ module_LTLIBRARIES += fullscreen-shell.la fullscreen_shell_la_CPPFLAGS = \ -I$(top_builddir)/protocol \ -I$(top_srcdir)/shared \ - -I$(top_srcdir)/libweston \ -I$(top_builddir)/libweston \ + -I$(top_srcdir)/libweston \ -DIN_WESTON fullscreen_shell_la_LDFLAGS = -module -avoid-version @@ -965,8 +965,8 @@ libweston_module_LTLIBRARIES += xwayland.la xwayland_la_CPPFLAGS = \ -I$(top_builddir)/protocol \ -I$(top_srcdir)/shared \ - -I$(top_srcdir)/libweston \ -I$(top_builddir)/libweston \ + -I$(top_srcdir)/libweston \ -I$(top_builddir)/xwayland \ -DDATADIR='"$(datadir)"'\ -DMODULEDIR='"$(moduledir)"'\ -- 2.8.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
