Re: Patchwork to require git-send-email formatted patches?

[Damien Lespiau]

On Thu, Nov 12, 2015 at 06:40:48PM -0800, Bryce Harrington wrote:
> On Thu, Nov 12, 2015 at 09:38:48AM +, Ucan, Emre (ADITG/SW1) wrote:
> > Hi,
> > 
> > I personally create the patches with git format-patch and then copy to the 
> > email.
> > Because I have to use windows and outlook for my company email.
> 
> This might be more trouble than worth for you, but for a while I was in
> a similar boat at Samsung, which is all MS Exchange based, and for me
> copying the patches in email was beyond my tolerance threshold.  I was
> able to interface with it using DavMail.  It was a bit clunky but worked
> adequately for me.  YMMV.

I have in mind a 'git pw submit' command that would work like git
send-email but would send the git-format patches to an HTTP/REST end
point. Patchwork would, then, send the emails to the ml on behalf of the
author. It would help people that are in these situations.

I'd also love if that command could take care of sending successive
revisions for me (either with --in-reply-to or full series depending how
much has changed).

But that's all handy wavy and I may not have time to reach that point.

-- 
Damien
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

RE: Patchwork to require git-send-email formatted patches?

[Ucan, Emre (ADITG/SW1)]

Hi,

I personally create the patches with git format-patch and then copy to the 
email.
Because I have to use windows and outlook for my company email.

Best regards

Emre Ucan
Software Group I (ADITG/SW1)

Tel. +49 5121 49 6937

> -Original Message-
> From: wayland-devel [mailto:wayland-devel-
> boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen
> Sent: Mittwoch, 11. November 2015 13:02
> To: wayland-devel@lists.freedesktop.org
> Cc: Damien Lespiau
> Subject: Patchwork to require git-send-email formatted patches?
> 
> On Tue, 10 Nov 2015 11:35:35 +
> Damien Lespiau <damien.lesp...@intel.com> wrote:
> 
> > Something else I noticed on this thead:
> >
> > In the reply 20151019013047.GA8175@jelly.local from Peter, there's a
> > diff put there for reference, picked up as a patch by patchwork:
> >
> >
> >
> http://patchwork.freedesktop.org/patch/msgid/20151019013047.GA8175@j
> el
> > ly.local
> >
> > If you want patchwork to not consider those kind of diffs as real
> > patches, there's a per-project option I can activate: only consider
> > git send-email mails as potential patches.
> 
> Hi all,
> 
> I think we could turn that on. What do others think?
> 
> How is a git-send-email patch recognized? Would we miss patches that are
> formatted with git-format-patch but sent by other means than git-send-
> email?
> 
> 
> Thanks,
> pq
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Patchwork to require git-send-email formatted patches?

[Pekka Paalanen]

On Thu, 12 Nov 2015 11:59:17 +
Damien Lespiau  wrote:

> On Wed, Nov 11, 2015 at 02:01:38PM +0200, Pekka Paalanen wrote:
> > On Tue, 10 Nov 2015 11:35:35 +
> > Damien Lespiau  wrote:
> > 
> > > Something else I noticed on this thead:
> > > 
> > > In the reply 20151019013047.GA8175@jelly.local from Peter, there's a
> > > diff put there for reference, picked up as a patch by patchwork:
> > > 
> > >   
> > > http://patchwork.freedesktop.org/patch/msgid/20151019013047.GA8175@jelly.local
> > > 
> > > If you want patchwork to not consider those kind of diffs as real
> > > patches, there's a per-project option I can activate: only consider git
> > > send-email mails as potential patches.
> > 
> > Hi all,
> > 
> > I think we could turn that on. What do others think?
> > 
> > How is a git-send-email patch recognized? Would we miss patches that
> > are formatted with git-format-patch but sent by other means than
> > git-send-email?
> 
> git send-email patches are recognized by their X-Mailer header:
> 
>   is_git_send_email = mail.get('X-Mailer', '').startswith('git-send-email')
> 
> It does mean any diff inlined in an email will be skipped if sent
> "manually", even it they actually are from git format-patch. I took some
> care to not cull git format-patch files sent as attachments though, so
> those should still work with that option enabled.

Hi,

looks like Emre's emails do not even have X-Mailer header, and if he
had, it wouldn't be git. So I don't think we can enable this filtering
after all.

I suppose there are also other people who for one reason or another
don't use git-send-email.

IMHO, it is less of a burden to prune accidental patches from Patchwork
than cause people grief by rejecting legitimate patches. Or does that
screw up the patch revision or series tracking?


Thanks,
pq


signature.asc
Description: PGP signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Patchwork to require git-send-email formatted patches?

[Damien Lespiau]

On Wed, Nov 11, 2015 at 02:01:38PM +0200, Pekka Paalanen wrote:
> On Tue, 10 Nov 2015 11:35:35 +
> Damien Lespiau  wrote:
> 
> > Something else I noticed on this thead:
> > 
> > In the reply 20151019013047.GA8175@jelly.local from Peter, there's a
> > diff put there for reference, picked up as a patch by patchwork:
> > 
> >   
> > http://patchwork.freedesktop.org/patch/msgid/20151019013047.GA8175@jelly.local
> > 
> > If you want patchwork to not consider those kind of diffs as real
> > patches, there's a per-project option I can activate: only consider git
> > send-email mails as potential patches.
> 
> Hi all,
> 
> I think we could turn that on. What do others think?
> 
> How is a git-send-email patch recognized? Would we miss patches that
> are formatted with git-format-patch but sent by other means than
> git-send-email?

git send-email patches are recognized by their X-Mailer header:

  is_git_send_email = mail.get('X-Mailer', '').startswith('git-send-email')

It does mean any diff inlined in an email will be skipped if sent
"manually", even it they actually are from git format-patch. I took some
care to not cull git format-patch files sent as attachments though, so
those should still work with that option enabled.

HTH,

-- 
Damien
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Patchwork to require git-send-email formatted patches?

[Peter Hutterer]

On Thu, Nov 12, 2015 at 02:20:01PM +0200, Pekka Paalanen wrote:
> On Thu, 12 Nov 2015 11:59:17 +
> Damien Lespiau  wrote:
> 
> > On Wed, Nov 11, 2015 at 02:01:38PM +0200, Pekka Paalanen wrote:
> > > On Tue, 10 Nov 2015 11:35:35 +
> > > Damien Lespiau  wrote:
> > > 
> > > > Something else I noticed on this thead:
> > > > 
> > > > In the reply 20151019013047.GA8175@jelly.local from Peter, there's a
> > > > diff put there for reference, picked up as a patch by patchwork:
> > > > 
> > > >   
> > > > http://patchwork.freedesktop.org/patch/msgid/20151019013047.GA8175@jelly.local
> > > > 
> > > > If you want patchwork to not consider those kind of diffs as real
> > > > patches, there's a per-project option I can activate: only consider git
> > > > send-email mails as potential patches.
> > > 
> > > Hi all,
> > > 
> > > I think we could turn that on. What do others think?
> > > 
> > > How is a git-send-email patch recognized? Would we miss patches that
> > > are formatted with git-format-patch but sent by other means than
> > > git-send-email?
> > 
> > git send-email patches are recognized by their X-Mailer header:
> > 
> >   is_git_send_email = mail.get('X-Mailer', '').startswith('git-send-email')
> > 
> > It does mean any diff inlined in an email will be skipped if sent
> > "manually", even it they actually are from git format-patch. I took some
> > care to not cull git format-patch files sent as attachments though, so
> > those should still work with that option enabled.
> 
> Hi,
> 
> looks like Emre's emails do not even have X-Mailer header, and if he
> had, it wouldn't be git. So I don't think we can enable this filtering
> after all.
> 
> I suppose there are also other people who for one reason or another
> don't use git-send-email.
> 
> IMHO, it is less of a burden to prune accidental patches from Patchwork
> than cause people grief by rejecting legitimate patches. Or does that
> screw up the patch revision or series tracking?

fwiw, I use mutt -H for single patches, it's faster than git-send-email
which I use for patch series only.

Cheers,
   Peter
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Patchwork to require git-send-email formatted patches?

[Damien Lespiau]

On Thu, Nov 12, 2015 at 02:20:01PM +0200, Pekka Paalanen wrote:
> IMHO, it is less of a burden to prune accidental patches from Patchwork
> than cause people grief by rejecting legitimate patches. Or does that
> screw up the patch revision or series tracking?

That should work, if not, it's probably a bug.

-- 
Damien
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Patchwork to require git-send-email formatted patches?

[Bryce Harrington]

On Thu, Nov 12, 2015 at 09:38:48AM +, Ucan, Emre (ADITG/SW1) wrote:
> Hi,
> 
> I personally create the patches with git format-patch and then copy to the 
> email.
> Because I have to use windows and outlook for my company email.

This might be more trouble than worth for you, but for a while I was in
a similar boat at Samsung, which is all MS Exchange based, and for me
copying the patches in email was beyond my tolerance threshold.  I was
able to interface with it using DavMail.  It was a bit clunky but worked
adequately for me.  YMMV.

Bryce

> Best regards
> 
> Emre Ucan
> Software Group I (ADITG/SW1)
> 
> Tel. +49 5121 49 6937
> 
> > -Original Message-
> > From: wayland-devel [mailto:wayland-devel-
> > boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen
> > Sent: Mittwoch, 11. November 2015 13:02
> > To: wayland-devel@lists.freedesktop.org
> > Cc: Damien Lespiau
> > Subject: Patchwork to require git-send-email formatted patches?
> > 
> > On Tue, 10 Nov 2015 11:35:35 +
> > Damien Lespiau <damien.lesp...@intel.com> wrote:
> > 
> > > Something else I noticed on this thead:
> > >
> > > In the reply 20151019013047.GA8175@jelly.local from Peter, there's a
> > > diff put there for reference, picked up as a patch by patchwork:
> > >
> > >
> > >
> > http://patchwork.freedesktop.org/patch/msgid/20151019013047.GA8175@j
> > el
> > > ly.local
> > >
> > > If you want patchwork to not consider those kind of diffs as real
> > > patches, there's a per-project option I can activate: only consider
> > > git send-email mails as potential patches.
> > 
> > Hi all,
> > 
> > I think we could turn that on. What do others think?
> > 
> > How is a git-send-email patch recognized? Would we miss patches that are
> > formatted with git-format-patch but sent by other means than git-send-
> > email?
> > 
> > 
> > Thanks,
> > pq
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Patchwork to require git-send-email formatted patches?

[Pekka Paalanen]

On Tue, 10 Nov 2015 11:35:35 +
Damien Lespiau  wrote:

> Something else I noticed on this thead:
> 
> In the reply 20151019013047.GA8175@jelly.local from Peter, there's a
> diff put there for reference, picked up as a patch by patchwork:
> 
>   
> http://patchwork.freedesktop.org/patch/msgid/20151019013047.GA8175@jelly.local
> 
> If you want patchwork to not consider those kind of diffs as real
> patches, there's a per-project option I can activate: only consider git
> send-email mails as potential patches.

Hi all,

I think we could turn that on. What do others think?

How is a git-send-email patch recognized? Would we miss patches that
are formatted with git-format-patch but sent by other means than
git-send-email?


Thanks,
pq


signature.asc
Description: PGP signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Patchwork to require git-send-email formatted patches?

[Bryce Harrington]

On Wed, Nov 11, 2015 at 02:01:38PM +0200, Pekka Paalanen wrote:
> On Tue, 10 Nov 2015 11:35:35 +
> Damien Lespiau  wrote:
> 
> > Something else I noticed on this thead:
> > 
> > In the reply 20151019013047.GA8175@jelly.local from Peter, there's a
> > diff put there for reference, picked up as a patch by patchwork:
> > 
> >   
> > http://patchwork.freedesktop.org/patch/msgid/20151019013047.GA8175@jelly.local
> > 
> > If you want patchwork to not consider those kind of diffs as real
> > patches, there's a per-project option I can activate: only consider git
> > send-email mails as potential patches.
> 
> Hi all,
> 
> I think we could turn that on. What do others think?

+1

Only concern is to have some way for the submitter to understand why
their patch didn't get recognized by the system if/when they intended it
to be.

Bryce
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel