Re: [PATCH v3] xdg-shell: use case to change the app ID at runtime
On Wed, Jul 17, 2019 at 12:12:37PM +0200, Jan-Marek Glogowski wrote: > Am 15.07.19 um 16:20 schrieb glo...@fbihome.de: > > From: Jan-Marek Glogowski > > > > LibreOffice is one big binary with explicit brandings for different > > application modules. This is represented in X11 by a different > > WM_CLASS setting for a window. The WM_CLASS is changed based on the > > loaded document at runtime. As a result LibreOffice already offers > > multiple desktop files with different icons, StartupWMClass > > entries and application names. > > > > This amendment of the set_app_id request just explicitly specifies > > the use case to change a surfaces' app ID at runtime, so a compositor > > implementor is made aware of it. Just as the WM_CLASS, a change of > > the app ID should result in an update of the propertes of a surface > > depending on the app ID, like the window icon specified in the > > desktop file or a re-grouping of the surfaces in a task manager. > > Signed-off-by: Jan-Marek Glogowski Thanks, this has now landed. Jonas > ___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH v3] xdg-shell: use case to change the app ID at runtime
Am 15.07.19 um 16:20 schrieb glo...@fbihome.de: > From: Jan-Marek Glogowski > > LibreOffice is one big binary with explicit brandings for different > application modules. This is represented in X11 by a different > WM_CLASS setting for a window. The WM_CLASS is changed based on the > loaded document at runtime. As a result LibreOffice already offers > multiple desktop files with different icons, StartupWMClass > entries and application names. > > This amendment of the set_app_id request just explicitly specifies > the use case to change a surfaces' app ID at runtime, so a compositor > implementor is made aware of it. Just as the WM_CLASS, a change of > the app ID should result in an update of the propertes of a surface > depending on the app ID, like the window icon specified in the > desktop file or a re-grouping of the surfaces in a task manager. Signed-off-by: Jan-Marek Glogowski ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH v3] xdg-shell: use case to change the app ID at runtime
On Mon, Jul 15, 2019 at 04:20:10PM +0200, glo...@fbihome.de wrote: > From: Jan-Marek Glogowski > > LibreOffice is one big binary with explicit brandings for different > application modules. This is represented in X11 by a different > WM_CLASS setting for a window. The WM_CLASS is changed based on the > loaded document at runtime. As a result LibreOffice already offers > multiple desktop files with different icons, StartupWMClass > entries and application names. > > This amendment of the set_app_id request just explicitly specifies > the use case to change a surfaces' app ID at runtime, so a compositor > implementor is made aware of it. Just as the WM_CLASS, a change of > the app ID should result in an update of the propertes of a surface > depending on the app ID, like the window icon specified in the > desktop file or a re-grouping of the surfaces in a task manager. Just noted this is missing Signed-off-by. Mind if I help you add it? Jonas > --- > stable/xdg-shell/xdg-shell.xml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml > index 2e420c6..3a87a9e 100644 > --- a/stable/xdg-shell/xdg-shell.xml > +++ b/stable/xdg-shell/xdg-shell.xml > @@ -604,6 +604,9 @@ > For example, "org.freedesktop.FooViewer" where the .desktop file is > "org.freedesktop.FooViewer.desktop". > > + Like other properties, a set_app_id request can be sent after the > + xdg_toplevel has been mapped to update the property. > + > See the desktop-entry specification [0] for more details on > application identifiers and how they relate to well-known D-Bus > names and .desktop files. > -- > 2.20.1 > ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH v3] xdg-shell: use case to change the app ID at runtime
On Monday, July 15, 2019 5:20 PM, wrote: > From: Jan-Marek Glogowski glo...@fbihome.de > > LibreOffice is one big binary with explicit brandings for different > application modules. This is represented in X11 by a different > WM_CLASS setting for a window. The WM_CLASS is changed based on the > loaded document at runtime. As a result LibreOffice already offers > multiple desktop files with different icons, StartupWMClass > entries and application names. > > This amendment of the set_app_id request just explicitly specifies > the use case to change a surfaces' app ID at runtime, so a compositor > implementor is made aware of it. Just as the WM_CLASS, a change of > the app ID should result in an update of the propertes of a surface > depending on the app ID, like the window icon specified in the > desktop file or a re-grouping of the surfaces in a task manager. This LGTM. Reviewed-by: Simon Ser Thanks! ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH v3] xdg-shell: use case to change the app ID at runtime
On Mon, Jul 15, 2019 at 04:20:10PM +0200, glo...@fbihome.de wrote: > From: Jan-Marek Glogowski > > LibreOffice is one big binary with explicit brandings for different > application modules. This is represented in X11 by a different > WM_CLASS setting for a window. The WM_CLASS is changed based on the > loaded document at runtime. As a result LibreOffice already offers > multiple desktop files with different icons, StartupWMClass > entries and application names. > > This amendment of the set_app_id request just explicitly specifies > the use case to change a surfaces' app ID at runtime, so a compositor > implementor is made aware of it. Just as the WM_CLASS, a change of > the app ID should result in an update of the propertes of a surface > depending on the app ID, like the window icon specified in the > desktop file or a re-grouping of the surfaces in a task manager. Reviewed-by: Jonas Ådahl Jonas > --- > stable/xdg-shell/xdg-shell.xml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml > index 2e420c6..3a87a9e 100644 > --- a/stable/xdg-shell/xdg-shell.xml > +++ b/stable/xdg-shell/xdg-shell.xml > @@ -604,6 +604,9 @@ > For example, "org.freedesktop.FooViewer" where the .desktop file is > "org.freedesktop.FooViewer.desktop". > > + Like other properties, a set_app_id request can be sent after the > + xdg_toplevel has been mapped to update the property. > + > See the desktop-entry specification [0] for more details on > application identifiers and how they relate to well-known D-Bus > names and .desktop files. > -- > 2.20.1 > ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel