Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
Alec,
could you replace the pipe with another character (i.e. !) and see what
happens?
Il giorno giovedì 21 giugno 2012 06:13:01 UTC+2, Alec Taylor ha scritto:
Confirmed.
That pipe code is definitely there (just under the a class=brand
href=#web2pytrade;nbsp;/a line).
On Thu, Jun 21, 2012 at 5:00 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
please double check that in views/layout.html exists this code (note
the
pipe in separators):
div id=navbar{{='auth' in globals() and auth.navbar(separators=('
',' |
','')) or ''}}/div
You should find it at line 90 in last trunk.
Il giorno mercoledì 20 giugno 2012 12:59:56 UTC+2, Alec Taylor ha
scritto:
Okay, finally got around to testing it.
Not getting any pipes.
The right of my navbar is one long string all of the same colour:
Welcome username Logout
--
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
Confirmed, problem still exists.
Here is the navbar code directly from the source generated
(post-processing to prettify only):
http://jsfiddle.net/ucYGN/
On Thu, Jun 21, 2012 at 7:58 PM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
could you replace the pipe with another character (i.e. !) and see what
happens?
Il giorno giovedì 21 giugno 2012 06:13:01 UTC+2, Alec Taylor ha scritto:
Confirmed.
That pipe code is definitely there (just under the a class=brand
href=#web2pytrade;nbsp;/a line).
On Thu, Jun 21, 2012 at 5:00 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
please double check that in views/layout.html exists this code (note
the
pipe in separators):
div id=navbar{{='auth' in globals() and auth.navbar(separators=('
',' |
','')) or ''}}/div
You should find it at line 90 in last trunk.
Il giorno mercoledì 20 giugno 2012 12:59:56 UTC+2, Alec Taylor ha
scritto:
Okay, finally got around to testing it.
Not getting any pipes.
The right of my navbar is one long string all of the same colour:
Welcome username Logout
--
--
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
Alec,
it seems that you aren't using last trunk.
For example #navbar missed classes. In last trunk, indeed, we have:
div class=nav pull-right id=navbar
span class=auth_navbarWelcome paolo
a
href=/welcome/default/user/logout?_next=/welcome/default/indexhttp://127.0.0.1:8000/welcome/default/user/logout?_next=/welcome/default/index
Logout/a |
a
href=/welcome/default/user/profile?_next=/welcome/default/indexhttp://127.0.0.1:8000/welcome/default/user/profile?_next=/welcome/default/index
Profile/a |
a href=
/welcome/default/user/change_password?_next=/welcome/default/indexhttp://127.0.0.1:8000/welcome/default/user/change_password?_next=/welcome/default/index
Password/a
/span
/div
please download last trunk and try again.
Il giorno giovedì 21 giugno 2012 17:53:55 UTC+2, Alec Taylor ha scritto:
Confirmed, problem still exists.
Here is the navbar code directly from the source generated
(post-processing to prettify only):
http://jsfiddle.net/ucYGN/
On Thu, Jun 21, 2012 at 7:58 PM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
could you replace the pipe with another character (i.e. !) and see
what
happens?
Il giorno giovedì 21 giugno 2012 06:13:01 UTC+2, Alec Taylor ha scritto:
Confirmed.
That pipe code is definitely there (just under the a class=brand
href=#web2pytrade;nbsp;/a line).
On Thu, Jun 21, 2012 at 5:00 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
please double check that in views/layout.html exists this code
(note
the
pipe in separators):
div id=navbar{{='auth' in globals() and auth.navbar(separators=('
',' |
','')) or ''}}/div
You should find it at line 90 in last trunk.
Il giorno mercoledì 20 giugno 2012 12:59:56 UTC+2, Alec Taylor ha
scritto:
Okay, finally got around to testing it.
Not getting any pipes.
The right of my navbar is one long string all of the same colour:
Welcome username Logout
--
--
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
Reading your code example highlights the problem.
There is no | after Welcome paolo
On Fri, Jun 22, 2012 at 2:32 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
it seems that you aren't using last trunk.
For example #navbar missed classes. In last trunk, indeed, we have:
div class=nav pull-right id=navbar
span class=auth_navbarWelcome paolo
a
href=/welcome/default/user/logout?_next=/welcome/default/indexLogout/a
|
a
href=/welcome/default/user/profile?_next=/welcome/default/indexProfile/a
|
a
href=/welcome/default/user/change_password?_next=/welcome/default/indexPassword/a
/span
/div
please download last trunk and try again.
Il giorno giovedì 21 giugno 2012 17:53:55 UTC+2, Alec Taylor ha scritto:
Confirmed, problem still exists.
Here is the navbar code directly from the source generated
(post-processing to prettify only):
http://jsfiddle.net/ucYGN/
On Thu, Jun 21, 2012 at 7:58 PM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
could you replace the pipe with another character (i.e. !) and see
what
happens?
Il giorno giovedì 21 giugno 2012 06:13:01 UTC+2, Alec Taylor ha scritto:
Confirmed.
That pipe code is definitely there (just under the a class=brand
href=#web2pytrade;nbsp;/a line).
On Thu, Jun 21, 2012 at 5:00 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
please double check that in views/layout.html exists this code
(note
the
pipe in separators):
div id=navbar{{='auth' in globals() and auth.navbar(separators=('
',' |
','')) or ''}}/div
You should find it at line 90 in last trunk.
Il giorno mercoledì 20 giugno 2012 12:59:56 UTC+2, Alec Taylor ha
scritto:
Okay, finally got around to testing it.
Not getting any pipes.
The right of my navbar is one long string all of the same colour:
Welcome username Logout
--
--
--
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
So you could modify #navbar in layout.html
For example:
div id=navbar
{{if auth.user_id:}}
{{=auth.navbar(separators=(', ' , ' | ' , ''))}}
{{else:}}
{{='auth' in globals() and auth.navbar(separators=('' , ' | ' , '')) or
''}}
{{pass}}
/div
When the user is logged in, after his/her name there will be a comma + 1
space
Il giorno giovedì 21 giugno 2012 18:54:25 UTC+2, Alec Taylor ha scritto:
Reading your code example highlights the problem.
There is no | after Welcome paolo
On Fri, Jun 22, 2012 at 2:32 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
it seems that you aren't using last trunk.
For example #navbar missed classes. In last trunk, indeed, we have:
div class=nav pull-right id=navbar
span class=auth_navbarWelcome paolo
a
href=/welcome/default/user/logout?_next=/welcome/default/indexLogout/a
|
a
href=/welcome/default/user/profile?_next=/welcome/default/indexProfile/a
|
a
href=/welcome/default/user/change_password?_next=/welcome/default/indexPassword/a
/span
/div
please download last trunk and try again.
Il giorno giovedì 21 giugno 2012 17:53:55 UTC+2, Alec Taylor ha scritto:
Confirmed, problem still exists.
Here is the navbar code directly from the source generated
(post-processing to prettify only):
http://jsfiddle.net/ucYGN/
On Thu, Jun 21, 2012 at 7:58 PM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
could you replace the pipe with another character (i.e. !) and see
what
happens?
Il giorno giovedì 21 giugno 2012 06:13:01 UTC+2, Alec Taylor ha
scritto:
Confirmed.
That pipe code is definitely there (just under the a class=brand
href=#web2pytrade;nbsp;/a line).
On Thu, Jun 21, 2012 at 5:00 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
please double check that in views/layout.html exists this code
(note
the
pipe in separators):
div id=navbar{{='auth' in globals() and
auth.navbar(separators=('
',' |
','')) or ''}}/div
You should find it at line 90 in last trunk.
Il giorno mercoledì 20 giugno 2012 12:59:56 UTC+2, Alec Taylor ha
scritto:
Okay, finally got around to testing it.
Not getting any pipes.
The right of my navbar is one long string all of the same colour:
Welcome username Logout
--
--
--
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
Thanks, I'll make those changes.
But did you think it would also be a good change to commit to trunk?
On Fri, Jun 22, 2012 at 4:26 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
So you could modify #navbar in layout.html
For example:
div id=navbar
{{if auth.user_id:}}
{{=auth.navbar(separators=(', ' , ' | ' , ''))}}
{{else:}}
{{='auth' in globals() and auth.navbar(separators=('' , ' | ' , '')) or
''}}
{{pass}}
/div
When the user is logged in, after his/her name there will be a comma + 1
space
Il giorno giovedì 21 giugno 2012 18:54:25 UTC+2, Alec Taylor ha scritto:
Reading your code example highlights the problem.
There is no | after Welcome paolo
On Fri, Jun 22, 2012 at 2:32 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
it seems that you aren't using last trunk.
For example #navbar missed classes. In last trunk, indeed, we have:
div class=nav pull-right id=navbar
span class=auth_navbarWelcome paolo
a
href=/welcome/default/user/logout?_next=/welcome/default/indexLogout/a
|
a
href=/welcome/default/user/profile?_next=/welcome/default/indexProfile/a
|
a
href=/welcome/default/user/change_password?_next=/welcome/default/indexPassword/a
/span
/div
please download last trunk and try again.
Il giorno giovedì 21 giugno 2012 17:53:55 UTC+2, Alec Taylor ha scritto:
Confirmed, problem still exists.
Here is the navbar code directly from the source generated
(post-processing to prettify only):
http://jsfiddle.net/ucYGN/
On Thu, Jun 21, 2012 at 7:58 PM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
could you replace the pipe with another character (i.e. !) and see
what
happens?
Il giorno giovedì 21 giugno 2012 06:13:01 UTC+2, Alec Taylor ha
scritto:
Confirmed.
That pipe code is definitely there (just under the a class=brand
href=#web2pytrade;nbsp;/a line).
On Thu, Jun 21, 2012 at 5:00 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
please double check that in views/layout.html exists this code
(note
the
pipe in separators):
div id=navbar{{='auth' in globals() and
auth.navbar(separators=('
',' |
','')) or ''}}/div
You should find it at line 90 in last trunk.
Il giorno mercoledì 20 giugno 2012 12:59:56 UTC+2, Alec Taylor ha
scritto:
Okay, finally got around to testing it.
Not getting any pipes.
The right of my navbar is one long string all of the same colour:
Welcome username Logout
--
--
--
--
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
Okay, finally got around to testing it. Not getting any pipes. The right of my navbar is one long string all of the same colour: Welcome username Logout
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
Alec,
please double check that in views/layout.html exists this code (note the
pipe in separators):
div id=navbar{{='auth' in globals() and auth.navbar(separators=(' ',' |
','')) or ''}}/div
You should find it at line 90 in last trunk.
Il giorno mercoledì 20 giugno 2012 12:59:56 UTC+2, Alec Taylor ha scritto:
Okay, finally got around to testing it.
Not getting any pipes.
The right of my navbar is one long string all of the same colour:
Welcome username Logout
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
Confirmed.
That pipe code is definitely there (just under the a class=brand
href=#web2pytrade;nbsp;/a line).
On Thu, Jun 21, 2012 at 5:00 AM, Paolo Caruccio
paolo.carucci...@gmail.com wrote:
Alec,
please double check that in views/layout.html exists this code (note the
pipe in separators):
div id=navbar{{='auth' in globals() and auth.navbar(separators=(' ',' |
','')) or ''}}/div
You should find it at line 90 in last trunk.
Il giorno mercoledì 20 giugno 2012 12:59:56 UTC+2, Alec Taylor ha scritto:
Okay, finally got around to testing it.
Not getting any pipes.
The right of my navbar is one long string all of the same colour:
Welcome username Logout
--
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
b 1
Also, make it contrast with the background, e.g.: white text colour
On Mon, Jun 18, 2012 at 6:30 PM, Andrew awillima...@gmail.com wrote:
Looks Great to me !
On Monday, June 18, 2012 4:38:09 PM UTC+12, Massimo Di Pierro wrote:
Check what's in trunk now. Let me know if you think it needs improvement.
On Sunday, 17 June 2012 15:45:41 UTC-5, Cliff Kachinske wrote:
I agree that the old look, with dividers, looks better.
I also think the buttons are easier to find on the page, so I would like
to optionally use them.
Would you take a patch with the option?
On Saturday, June 16, 2012 11:30:04 PM UTC-4, Andrew wrote:
A week or two ago a change was made to the nav bar to give the auth
buttons for Login, Register, etc a button look. This was part of the
fix
to the dropdown menus to get them to work with bootstrap. Another change
was made to revert back to the old look (but only as an attachment to a
previous post in this list).
There are two screen shots, current welcome app, and with the buttons
reverted to the old look.
Credit to Paolo for making both changes. Given that the buttons have
been in trunk for a while, it is worth getting a consensus to keep it or
revert it. So:
Vote:
A) KEEP THE BUTTON LOOK
B) REVERT TO THE OLD LOOK
if B)
B.1) Revert to the Pipe separator between the options (as shown)
B.2) Don't include the Pipe separator.
B.1) involves updating a recent patch to layout.html:
div id=navbar{{='auth' in globals() and auth.navbar(separators=('
',' | ','')) or ''}}/div
A patch for B.1) has already been sent to Massimo (that's my vote :) ) ,
but let's see what the general feeling is.
Thanks
Re: [web2py] Re: Users Poll: To keep the button look for the welcome app's auth options, or not ?
+1 option to use them!
Richard
On Sun, Jun 17, 2012 at 4:45 PM, Cliff Kachinske cjk...@gmail.com wrote:
I agree that the old look, with dividers, *looks* better.
I also think the buttons are easier to find on the page, so I would like
to optionally use them.
Would you take a patch with the option?
On Saturday, June 16, 2012 11:30:04 PM UTC-4, Andrew wrote:
A week or two ago a change was made to the nav bar to give the auth
buttons for Login, Register, etc a button look. This was part of the
fix to the dropdown menus to get them to work with bootstrap. Another
change was made to revert back to the old look (but only as an attachment
to a previous post in this list).
There are two screen shots, current welcome app, and with the buttons
reverted to the old look.
Credit to Paolo for making both changes. Given that the buttons have
been in trunk for a while, it is worth getting a consensus to keep it or
revert it. So:
*Vote:*
*A) KEEP THE BUTTON LOOK*
*B) REVERT TO THE OLD LOOK*
*
*
*if B) *
*
*
*B.1) Revert to the Pipe separator between the options (as shown)*
*B.2) Don't include the Pipe separator.*
B.1) involves updating a recent patch to layout.html:
div id=navbar{{='auth' in globals() and auth.navbar(separators=(' ','
| ','')) or ''}}/div
A patch for B.1) has already been sent to Massimo (that's my vote :) ) ,
but let's see what the general feeling is.
Thanks
