[webkit-changes] [159914] releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Title: [159914] releases/WebKitGTK/webkit-2.2/Source/_javascript_Core Revision 159914 Author carlo...@webkit.org Date 2013-12-02 00:59:22 -0800 (Mon, 02 Dec 2013) Log Message Merge r158687 - Fix register allocation inside control flow in GetByVal String https://bugs.webkit.org/show_bug.cgi?id=123816 Reviewed by Geoffrey Garen. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileGetByValOnString): Modified Paths releases/WebKitGTK/webkit-2.2/Source/_javascript_Core/ChangeLog releases/WebKitGTK/webkit-2.2/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp Diff Modified: releases/WebKitGTK/webkit-2.2/Source/_javascript_Core/ChangeLog (159913 => 159914) --- releases/WebKitGTK/webkit-2.2/Source/_javascript_Core/ChangeLog 2013-12-02 07:48:48 UTC (rev 159913) +++ releases/WebKitGTK/webkit-2.2/Source/_javascript_Core/ChangeLog 2013-12-02 08:59:22 UTC (rev 159914) @@ -1,3 +1,13 @@ +2013-11-05 Filip Pizlo fpi...@apple.com + +Fix register allocation inside control flow in GetByVal String +https://bugs.webkit.org/show_bug.cgi?id=123816 + +Reviewed by Geoffrey Garen. + +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::compileGetByValOnString): + 2013-09-17 Mark Hahnenberg mhahnenb...@apple.com DFG doesn't properly keep scope alive for op_put_to_scope Modified: releases/WebKitGTK/webkit-2.2/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (159913 => 159914) --- releases/WebKitGTK/webkit-2.2/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2013-12-02 07:48:48 UTC (rev 159913) +++ releases/WebKitGTK/webkit-2.2/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2013-12-02 08:59:22 UTC (rev 159914) @@ -2097,17 +2097,9 @@ // 8 bit string values don't need the isASCII check. cont8Bit.link(m_jit); -#if CPU(X86) -// Don't have enough register, construct our own indexed address and load. -m_jit.lshift32(MacroAssembler::TrustedImm32(2), scratchReg); +m_jit.lshift32(MacroAssembler::TrustedImm32(sizeof(void*) == 4 ? 2 : 3), scratchReg); m_jit.addPtr(MacroAssembler::TrustedImmPtr(m_jit.vm()-smallStrings.singleCharacterStrings()), scratchReg); m_jit.loadPtr(scratchReg, scratchReg); -#else -GPRTemporary smallStrings(this); -GPRReg smallStringsReg = smallStrings.gpr(); -m_jit.move(MacroAssembler::TrustedImmPtr(m_jit.vm()-smallStrings.singleCharacterStrings()), smallStringsReg); -m_jit.loadPtr(MacroAssembler::BaseIndex(smallStringsReg, scratchReg, MacroAssembler::ScalePtr, 0), scratchReg); -#endif addSlowPathGenerator( slowPathCall( ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159915] trunk/Source/WebCore
Title: [159915] trunk/Source/WebCore
Revision 159915
Author commit-qu...@webkit.org
Date 2013-12-02 01:08:31 -0800 (Mon, 02 Dec 2013)
Log Message
HTML5 required attribute validation messages implemented.
https://bugs.webkit.org/show_bug.cgi?id=125003
Patch by Attila Dusnoki adusn...@inf.u-szeged.hu on 2013-12-02
Reviewed by Gyuyoung Kim.
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageBadInputForNumberText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (159914 => 159915)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 08:59:22 UTC (rev 159914)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 09:08:31 UTC (rev 159915)
@@ -1,3 +1,20 @@
+2013-12-02 Attila Dusnoki adusn...@inf.u-szeged.hu
+
+HTML5 required attribute validation messages implemented.
+https://bugs.webkit.org/show_bug.cgi?id=125003
+
+Reviewed by Gyuyoung Kim.
+
+* platform/efl/LocalizedStringsEfl.cpp:
+(WebCore::validationMessagePatternMismatchText):
+(WebCore::validationMessageValueMissingText):
+(WebCore::validationMessageValueMissingForCheckboxText):
+(WebCore::validationMessageValueMissingForFileText):
+(WebCore::validationMessageValueMissingForMultipleFileText):
+(WebCore::validationMessageValueMissingForRadioText):
+(WebCore::validationMessageValueMissingForSelectText):
+(WebCore::validationMessageBadInputForNumberText):
+
2013-12-01 Andreas Kling akl...@apple.com
SVG: Intersection/enclosure checks should use RenderElement.
Modified: trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp (159914 => 159915)
--- trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp 2013-12-02 08:59:22 UTC (rev 159914)
+++ trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp 2013-12-02 09:08:31 UTC (rev 159915)
@@ -528,7 +528,7 @@
String validationMessagePatternMismatchText()
{
-return String::fromUTF8(pattern mismatch);
+return ASCIILiteral(Please match the requested format:);
}
String validationMessageRangeOverflowText(const String maximum)
@@ -573,43 +573,37 @@
String validationMessageValueMissingText()
{
-return String::fromUTF8(value missing);
+return ASCIILiteral(Please fill out this field.);
}
String validationMessageValueMissingForCheckboxText()
{
-notImplemented();
-return validationMessageValueMissingText();
+return ASCIILiteral(Please check this box if you want to proceed.);
}
String validationMessageValueMissingForFileText()
{
-notImplemented();
-return validationMessageValueMissingText();
+return ASCIILiteral(Please select a file.);
}
String validationMessageValueMissingForMultipleFileText()
{
-notImplemented();
-return validationMessageValueMissingText();
+return ASCIILiteral(Please select one or more files.);
}
String validationMessageValueMissingForRadioText()
{
-notImplemented();
-return validationMessageValueMissingText();
+return ASCIILiteral(Please select one of these options.);
}
String validationMessageValueMissingForSelectText()
{
-notImplemented();
-return validationMessageValueMissingText();
+return ASCIILiteral(Please select an item in the list.);
}
String validationMessageBadInputForNumberText()
{
-notImplemented();
-return validationMessageTypeMismatchText();
+return ASCIILiteral(Please enter a number.);
}
String missingPluginText()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159916] releases/WebKitGTK/webkit-2.2/Source/WebCore
Title: [159916] releases/WebKitGTK/webkit-2.2/Source/WebCore
Revision 159916
Author carlo...@webkit.org
Date 2013-12-02 01:15:10 -0800 (Mon, 02 Dec 2013)
Log Message
Merge r159572 - [GTK] Remove Chromium as user agent and claim to be Safari in OS X
https://bugs.webkit.org/show_bug.cgi?id=124229
Reviewed by Martin Robinson.
http://www.duolingo.com/ doesn't get render correctly because it uses
Chrome/Chromium specific variables, added after it was forked. Because
of this, it is necessary to remove the Chrome/Chromium identification
in the user agent. Also, from now on, by default, The GTK+ port will
claim to be Safari in OS X to avoid loading wrong resources.
* platform/gtk/UserAgentGtk.cpp:
(WebCore::standardUserAgent):
Modified Paths
releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/UserAgentGtk.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog (159915 => 159916)
--- releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog 2013-12-02 09:08:31 UTC (rev 159915)
+++ releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog 2013-12-02 09:15:10 UTC (rev 159916)
@@ -1,3 +1,19 @@
+2013-11-20 Víctor Manuel Jáquez Leal vjaq...@igalia.com
+
+[GTK] Remove Chromium as user agent and claim to be Safari in OS X
+https://bugs.webkit.org/show_bug.cgi?id=124229
+
+Reviewed by Martin Robinson.
+
+http://www.duolingo.com/ doesn't get render correctly because it uses
+Chrome/Chromium specific variables, added after it was forked. Because
+of this, it is necessary to remove the Chrome/Chromium identification
+in the user agent. Also, from now on, by default, The GTK+ port will
+claim to be Safari in OS X to avoid loading wrong resources.
+
+* platform/gtk/UserAgentGtk.cpp:
+(WebCore::standardUserAgent):
+
2013-09-24 Lorenzo Tilve lti...@igalia.com
[GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
Modified: releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/UserAgentGtk.cpp (159915 => 159916)
--- releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/UserAgentGtk.cpp 2013-12-02 09:08:31 UTC (rev 159915)
+++ releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/UserAgentGtk.cpp 2013-12-02 09:15:10 UTC (rev 159916)
@@ -36,6 +36,21 @@
namespace WebCore {
+#if OS(DARWIN) || OS(UNIX)
+static const char* cpuDescriptionForUAString()
+{
+#if CPU(PPC) || CPU(PPC64)
+return PPC;
+#elif CPU(X86) || CPU(X86_64)
+return Intel;
+#elif CPU(ARM) || CPU(ARM64)
+return ARM;
+#else
+return Unknown;
+#endif
+}
+#endif
+
static const char* platformForUAString()
{
#if PLATFORM(X11)
@@ -59,19 +74,11 @@
#if OS(WINDOWS)
uaOSVersion = windowsVersionForUAString();
-#elif OS(DARWIN)
-#if CPU(X86) || CPU(X86_64)
-uaOSVersion = Intel Mac OS X;
+#elif OS(DARWIN) || OS(UNIX)
+// We will always claim to be Safari in Mac OS X, since Safari in Linux triggers the iOS path on
+// some websites.
+uaOSVersion = String::format(%s Mac OS X, cpuDescriptionForUAString());
#else
-uaOSVersion = PPC Mac OS X;
-#endif
-#elif OS(UNIX)
-struct utsname name;
-if (uname(name) != -1)
-uaOSVersion = String::format(%s %s, name.sysname, name.machine);
-else
-uaOSVersion = String(Unknown);
-#else
uaOSVersion = String(Unknown);
#endif
return uaOSVersion;
@@ -79,17 +86,16 @@
String standardUserAgent(const String applicationName, const String applicationVersion)
{
-// Create a default user agent string with a liberal interpretation of
+// Create a default user agent string with a liberal interpretation of
// https://developer.mozilla.org/en-US/docs/User_Agent_Strings_Reference
//
// Forming a functional user agent is really difficult. We must mention Safari, because some
// sites check for that when detecting WebKit browsers. Additionally some sites assume that
-// browsers that are Safari but not running on OS X are the Safari iOS browser, so we
-// also claim to be Chromium. Getting this wrong can cause sites to load the wrong _javascript_,
-// CSS, or custom fonts. In some cases sites won't load resources at all.
+// browsers that are Safari but not running on OS X are the Safari iOS browse. Getting this
+// wrong can cause sites to load the wrong _javascript_, CSS, or custom fonts. In some cases
+// sites won't load resources at all.
DEFINE_STATIC_LOCAL(const CString, uaVersion, (String::format(%i.%i, USER_AGENT_GTK_MAJOR_VERSION, USER_AGENT_GTK_MINOR_VERSION).utf8()));
-DEFINE_STATIC_LOCAL(const String, staticUA, (String::format(Mozilla/5.0 (%s; %s) AppleWebKit/%s (KHTML, like Gecko)
-Chromium/25.0.1349.2 Chrome/25.0.1349.2 Safari/%s,
+DEFINE_STATIC_LOCAL(const String, staticUA, (String::format(Mozilla/5.0 (%s; %s)
[webkit-changes] [159917] releases/WebKitGTK/webkit-2.2/LayoutTests
Title: [159917] releases/WebKitGTK/webkit-2.2/LayoutTests Revision 159917 Author carlo...@webkit.org Date 2013-12-02 01:18:15 -0800 (Mon, 02 Dec 2013) Log Message Merge r159686 - Unreviewed GTK gardening. Adding failure expectations for tests that regressed with r159572. * platform/gtk/TestExpectations: Modified Paths releases/WebKitGTK/webkit-2.2/LayoutTests/ChangeLog releases/WebKitGTK/webkit-2.2/LayoutTests/platform/gtk/TestExpectations Diff Modified: releases/WebKitGTK/webkit-2.2/LayoutTests/ChangeLog (159916 => 159917) --- releases/WebKitGTK/webkit-2.2/LayoutTests/ChangeLog 2013-12-02 09:15:10 UTC (rev 159916) +++ releases/WebKitGTK/webkit-2.2/LayoutTests/ChangeLog 2013-12-02 09:18:15 UTC (rev 159917) @@ -1,3 +1,10 @@ +2013-11-22 Zan Dobersek zdober...@igalia.com + +Unreviewed GTK gardening. +Adding failure expectations for tests that regressed with r159572. + +* platform/gtk/TestExpectations: + 2013-08-28 Chris Curtis chris_cur...@apple.com https://bugs.webkit.org/show_bug.cgi?id=119548 Modified: releases/WebKitGTK/webkit-2.2/LayoutTests/platform/gtk/TestExpectations (159916 => 159917) --- releases/WebKitGTK/webkit-2.2/LayoutTests/platform/gtk/TestExpectations 2013-12-02 09:15:10 UTC (rev 159916) +++ releases/WebKitGTK/webkit-2.2/LayoutTests/platform/gtk/TestExpectations 2013-12-02 09:18:15 UTC (rev 159917) @@ -1410,6 +1410,14 @@ webkit.org/b/120203 http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html [ Failure ] +webkit.org/b/124770 fast/forms/ValidityState-valueMissing-002.html [ Failure ] +webkit.org/b/124770 fast/forms/access-key-for-all-elements.html [ Failure ] +webkit.org/b/124770 fast/forms/access-key.html [ Failure ] +webkit.org/b/124770 fast/forms/focus-selection-input.html [ Failure ] +webkit.org/b/124770 fast/forms/focus-selection-textarea.html [ Failure ] +webkit.org/b/124770 fast/forms/legend-access-key.html [ Failure ] +webkit.org/b/124770 fast/forms/select-accesskey.html [ Failure ] + # # End of Tests failing # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159918] releases/WebKitGTK/webkit-2.2/Source/WebKit2
Title: [159918] releases/WebKitGTK/webkit-2.2/Source/WebKit2 Revision 159918 Author carlo...@webkit.org Date 2013-12-02 01:20:05 -0800 (Mon, 02 Dec 2013) Log Message Merge r159811 - [GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing https://bugs.webkit.org/show_bug.cgi?id=124924 Reviewed by Carlos Garcia Campos. 'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit' substrings should be checked for. * UIProcess/API/gtk/tests/TestWebKitSettings.cpp: (testWebKitSettingsUserAgent): Modified Paths releases/WebKitGTK/webkit-2.2/Source/WebKit2/ChangeLog releases/WebKitGTK/webkit-2.2/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp Diff Modified: releases/WebKitGTK/webkit-2.2/Source/WebKit2/ChangeLog (159917 => 159918) --- releases/WebKitGTK/webkit-2.2/Source/WebKit2/ChangeLog 2013-12-02 09:18:15 UTC (rev 159917) +++ releases/WebKitGTK/webkit-2.2/Source/WebKit2/ChangeLog 2013-12-02 09:20:05 UTC (rev 159918) @@ -1,3 +1,17 @@ +2013-11-27 Zan Dobersek zdober...@igalia.com + +[GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing +https://bugs.webkit.org/show_bug.cgi?id=124924 + +Reviewed by Carlos Garcia Campos. + +'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit +test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit' +substrings should be checked for. + +* UIProcess/API/gtk/tests/TestWebKitSettings.cpp: +(testWebKitSettingsUserAgent): + 2013-11-11 Carlos Garcia Campos cgar...@igalia.com [GTK] Crash when printing via _javascript_ in WebKit2 Modified: releases/WebKitGTK/webkit-2.2/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp (159917 => 159918) --- releases/WebKitGTK/webkit-2.2/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp 2013-12-02 09:18:15 UTC (rev 159917) +++ releases/WebKitGTK/webkit-2.2/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp 2013-12-02 09:20:05 UTC (rev 159918) @@ -293,9 +293,8 @@ CString defaultUserAgent = webkit_settings_get_user_agent(settings.get()); webkit_web_view_set_settings(test-m_webView, settings.get()); +g_assert(g_strstr_len(defaultUserAgent.data(), -1, AppleWebKit)); g_assert(g_strstr_len(defaultUserAgent.data(), -1, Safari)); -g_assert(g_strstr_len(defaultUserAgent.data(), -1, Chromium)); -g_assert(g_strstr_len(defaultUserAgent.data(), -1, Chrome)); webkit_settings_set_user_agent(settings.get(), 0); g_assert_cmpstr(defaultUserAgent.data(), ==, webkit_settings_get_user_agent(settings.get())); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159919] releases/WebKitGTK/webkit-2.2/Source/WebCore
Title: [159919] releases/WebKitGTK/webkit-2.2/Source/WebCore
Revision 159919
Author carlo...@webkit.org
Date 2013-12-02 01:24:13 -0800 (Mon, 02 Dec 2013)
Log Message
Merge r159615 - [GTK] Cannot scroll in option menu when it larger than the screen
https://bugs.webkit.org/show_bug.cgi?id=124671
Reviewed by Martin Robinson.
The problem is that the popup menu is not resized to fit in the
screen, so it doesn't scroll and some of the items are offscreen
so they can't be selected either. GTK+ automatically resizes the
popup menus to fit in the work area, but only when the menu is
already positioned.
* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
menu right after showing it once it has a position.
Modified Paths
releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/GtkPopupMenu.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog (159918 => 159919)
--- releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog 2013-12-02 09:20:05 UTC (rev 159918)
+++ releases/WebKitGTK/webkit-2.2/Source/WebCore/ChangeLog 2013-12-02 09:24:13 UTC (rev 159919)
@@ -1,3 +1,20 @@
+2013-11-21 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Cannot scroll in option menu when it larger than the screen
+https://bugs.webkit.org/show_bug.cgi?id=124671
+
+Reviewed by Martin Robinson.
+
+The problem is that the popup menu is not resized to fit in the
+screen, so it doesn't scroll and some of the items are offscreen
+so they can't be selected either. GTK+ automatically resizes the
+popup menus to fit in the work area, but only when the menu is
+already positioned.
+
+* platform/gtk/GtkPopupMenu.cpp:
+(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
+menu right after showing it once it has a position.
+
2013-11-20 Víctor Manuel Jáquez Leal vjaq...@igalia.com
[GTK] Remove Chromium as user agent and claim to be Safari in OS X
Modified: releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/GtkPopupMenu.cpp (159918 => 159919)
--- releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/GtkPopupMenu.cpp 2013-12-02 09:20:05 UTC (rev 159918)
+++ releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/GtkPopupMenu.cpp 2013-12-02 09:24:13 UTC (rev 159919)
@@ -86,17 +86,17 @@
#else
gtk_widget_get_preferred_size(m_popup.get(), requisition, 0);
#endif
-
gtk_widget_set_size_request(m_popup.get(), std::max(menuSize.width(), requisition.width), -1);
-GList* children = gtk_container_get_children(GTK_CONTAINER(m_popup.get()));
-GList* p = children;
if (itemCount) {
-for (int i = 0; i itemCount; i++) {
+GOwnPtrGList children(gtk_container_get_children(GTK_CONTAINER(m_popup.get(;
+int i;
+GList* child;
+for (i = 0, child = children.get(); i itemCount; i++, child = g_list_next(child)) {
if (i selectedItem)
break;
-GtkWidget* item = reinterpret_castGtkWidget*(p-data);
+GtkWidget* item = GTK_WIDGET(child-data);
GtkRequisition itemRequisition;
#ifdef GTK_API_VERSION_2
gtk_widget_get_child_requisition(item, itemRequisition);
@@ -104,31 +104,23 @@
gtk_widget_get_preferred_size(item, itemRequisition, 0);
#endif
m_menuPosition.setY(m_menuPosition.y() - itemRequisition.height);
-
-p = g_list_next(p);
}
} else {
// Center vertically the empty popup in the combo box area.
m_menuPosition.setY(m_menuPosition.y() - menuSize.height() / 2);
}
-g_list_free(children);
-guint button;
-guint32 activateTime;
-if (event) {
-button = event-type == GDK_BUTTON_PRESS ? event-button.button : 1;
-activateTime = gdk_event_get_time(event);
-} else {
-button = 1;
-activateTime = GDK_CURRENT_TIME;
-}
-
+guint button = event event-type == GDK_BUTTON_PRESS ? event-button.button : 1;
+guint32 activateTime = event ? gdk_event_get_time(event) : GDK_CURRENT_TIME;
#ifdef GTK_API_VERSION_2
gtk_menu_popup(GTK_MENU(m_popup.get()), 0, 0, reinterpret_castGtkMenuPositionFunc(menuPositionFunction), this, button, activateTime);
#else
gtk_menu_popup_for_device(GTK_MENU(m_popup.get()), event ? gdk_event_get_device(event) : 0, 0, 0,
- reinterpret_castGtkMenuPositionFunc(menuPositionFunction), this, 0, button, activateTime);
+reinterpret_castGtkMenuPositionFunc(menuPositionFunction), this, 0, button, activateTime);
#endif
+
+// Now that the menu has a position, schedule a resize to make sure it's resized to fit vertically in the work area.
+gtk_widget_queue_resize(m_popup.get());
}
void GtkPopupMenu::popDown()
___
webkit-changes mailing
[webkit-changes] [159920] releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk
Title: [159920] releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk
Revision 159920
Author carlo...@webkit.org
Date 2013-12-02 01:28:05 -0800 (Mon, 02 Dec 2013)
Log Message
Merge r159843 - REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
https://bugs.webkit.org/show_bug.cgi?id=124954
Patch by Gustavo Noronha Silva gustavo.noro...@collabora.com on 2013-11-28
Reviewed by Carlos Garcia Campos.
* tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.
Modified Paths
releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/tests/testwebview.c
releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/webkit/webkitwebview.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/ChangeLog (159919 => 159920)
--- releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/ChangeLog 2013-12-02 09:24:13 UTC (rev 159919)
+++ releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/ChangeLog 2013-12-02 09:28:05 UTC (rev 159920)
@@ -1,3 +1,14 @@
+2013-11-28 Gustavo Noronha Silva gustavo.noro...@collabora.com
+
+REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
+https://bugs.webkit.org/show_bug.cgi?id=124954
+
+Reviewed by Carlos Garcia Campos.
+
+* tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
+* webkit/webkitwebview.cpp:
+(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.
+
2013-11-11 Carlos Garcia Campos cgar...@igalia.com
Unreviewed. Update NEWS and Versions.m4 for 2.2.2 release.
Modified: releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/tests/testwebview.c (159919 => 159920)
--- releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/tests/testwebview.c 2013-12-02 09:24:13 UTC (rev 159919)
+++ releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/tests/testwebview.c 2013-12-02 09:28:05 UTC (rev 159920)
@@ -687,6 +687,27 @@
gtk_widget_destroy(window);
}
+static void test_webkit_web_view_source_mode()
+{
+GtkWidget* web_view;
+
+web_view = webkit_web_view_new();
+
+webkit_web_view_load_string(WEBKIT_WEB_VIEW(web_view), htmlbody/body/html, NULL, NULL, NULL);
+
+g_assert(!webkit_web_view_get_view_source_mode(WEBKIT_WEB_VIEW(web_view)));
+
+webkit_web_view_set_view_source_mode(WEBKIT_WEB_VIEW(web_view), TRUE);
+
+g_assert(webkit_web_view_get_view_source_mode(WEBKIT_WEB_VIEW(web_view)));
+
+webkit_web_view_set_view_source_mode(WEBKIT_WEB_VIEW(web_view), FALSE);
+
+g_assert(!webkit_web_view_get_view_source_mode(WEBKIT_WEB_VIEW(web_view)));
+
+gtk_widget_destroy(web_view);
+}
+
int main(int argc, char** argv)
{
SoupServer* server;
@@ -719,6 +740,7 @@
g_test_add_data_func(/webkit/webview/fullscreen, GINT_TO_POINTER(FALSE), test_webkit_web_view_fullscreen);
g_test_add_data_func(/webkit/webview/fullscreen-blocked, GINT_TO_POINTER(TRUE), test_webkit_web_view_fullscreen);
g_test_add_func(/webkit/webview/file-chooser, test_webkit_web_view_file_chooser);
+g_test_add_func(/webkit/webview/source-mode, test_webkit_web_view_source_mode);
return g_test_run ();
}
Modified: releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/webkit/webkitwebview.cpp (159919 => 159920)
--- releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/webkit/webkitwebview.cpp 2013-12-02 09:24:13 UTC (rev 159919)
+++ releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/webkit/webkitwebview.cpp 2013-12-02 09:28:05 UTC (rev 159920)
@@ -5191,9 +5191,7 @@
{
g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), FALSE);
-core(webView)-mainFrame().inViewSourceMode();
-
-return FALSE;
+return core(webView)-mainFrame().inViewSourceMode();
}
// Internal subresource management
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159921] trunk/Source/WebCore
Title: [159921] trunk/Source/WebCore Revision 159921 Author commit-qu...@webkit.org Date 2013-12-02 01:58:55 -0800 (Mon, 02 Dec 2013) Log Message Fix build warning in EventHandler.cpp https://bugs.webkit.org/show_bug.cgi?id=125010 Patch by Tibor Meszaros mti...@inf.u-szeged.hu on 2013-12-02 Reviewed by Csaba Osztrogonác. * page/EventHandler.cpp: (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/EventHandler.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (159920 => 159921) --- trunk/Source/WebCore/ChangeLog 2013-12-02 09:28:05 UTC (rev 159920) +++ trunk/Source/WebCore/ChangeLog 2013-12-02 09:58:55 UTC (rev 159921) @@ -1,3 +1,13 @@ +2013-12-02 Tibor Meszaros mti...@inf.u-szeged.hu + +Fix build warning in EventHandler.cpp +https://bugs.webkit.org/show_bug.cgi?id=125010 + +Reviewed by Csaba Osztrogonác. + +* page/EventHandler.cpp: +(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult): + 2013-12-02 Attila Dusnoki adusn...@inf.u-szeged.hu HTML5 required attribute validation messages implemented. Modified: trunk/Source/WebCore/page/EventHandler.cpp (159920 => 159921) --- trunk/Source/WebCore/page/EventHandler.cpp 2013-12-02 09:28:05 UTC (rev 159920) +++ trunk/Source/WebCore/page/EventHandler.cpp 2013-12-02 09:58:55 UTC (rev 159921) @@ -3336,6 +3336,7 @@ #if PLATFORM(MAC) || PLATFORM(EFL) return EventHandler::isKeyboardOptionTab(event); #else +UNUSED_PARAM(event); return false; #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159923] trunk/Source/WebCore
Title: [159923] trunk/Source/WebCore
Revision 159923
Author seo...@webkit.org
Date 2013-12-02 02:12:04 -0800 (Mon, 02 Dec 2013)
Log Message
Web Inspector: Remove unused functions from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=125061
Reviewed by Antoine Quint.
Get rid of unused functions, redundant inclusion and forward declaration.
No new tests, no behavior changes.
* inspector/InspectorAgent.cpp:
* inspector/InspectorAgent.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorAgent.cpp
trunk/Source/WebCore/inspector/InspectorAgent.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (159922 => 159923)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 10:04:21 UTC (rev 159922)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 10:12:04 UTC (rev 159923)
@@ -1,3 +1,17 @@
+2013-12-02 Seokju Kwon seo...@webkit.org
+
+Web Inspector: Remove unused functions from InspectorAgent
+https://bugs.webkit.org/show_bug.cgi?id=125061
+
+Reviewed by Antoine Quint.
+
+Get rid of unused functions, redundant inclusion and forward declaration.
+
+No new tests, no behavior changes.
+
+* inspector/InspectorAgent.cpp:
+* inspector/InspectorAgent.h:
+
2013-12-02 Tibor Meszaros mti...@inf.u-szeged.hu
Fix build warning in EventHandler.cpp
Modified: trunk/Source/WebCore/inspector/InspectorAgent.cpp (159922 => 159923)
--- trunk/Source/WebCore/inspector/InspectorAgent.cpp 2013-12-02 10:04:21 UTC (rev 159922)
+++ trunk/Source/WebCore/inspector/InspectorAgent.cpp 2013-12-02 10:12:04 UTC (rev 159923)
@@ -162,18 +162,6 @@
m_pendingInspectData.second = hints;
}
-URL InspectorAgent::inspectedURL() const
-{
-return m_inspectedPage-mainFrame().document()-url();
-}
-
-URL InspectorAgent::inspectedURLWithoutFragment() const
-{
-URL url = ""
-url.removeFragmentIdentifier();
-return url;
-}
-
bool InspectorAgent::developerExtrasEnabled() const
{
if (!m_inspectedPage)
Modified: trunk/Source/WebCore/inspector/InspectorAgent.h (159922 => 159923)
--- trunk/Source/WebCore/inspector/InspectorAgent.h 2013-12-02 10:04:21 UTC (rev 159922)
+++ trunk/Source/WebCore/inspector/InspectorAgent.h 2013-12-02 10:12:04 UTC (rev 159923)
@@ -31,11 +31,9 @@
#define InspectorAgent_h
#include InspectorBaseAgent.h
-#include wtf/Forward.h
#include wtf/HashMap.h
#include wtf/PassOwnPtr.h
#include wtf/Vector.h
-#include wtf/text/WTFString.h
namespace WebCore {
@@ -46,7 +44,6 @@
class InspectorInspectorFrontendDispatcher;
class InspectorObject;
class InstrumentingAgents;
-class URL;
class Page;
typedef String ErrorString;
@@ -67,9 +64,6 @@
void enable(ErrorString*);
void disable(ErrorString*);
-URL inspectedURL() const;
-URL inspectedURLWithoutFragment() const;
-
virtual void didCreateFrontendAndBackend(InspectorFrontendChannel*, InspectorBackendDispatcher*) OVERRIDE;
virtual void willDestroyFrontendAndBackend() OVERRIDE;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159924] trunk/Tools
Title: [159924] trunk/Tools Revision 159924 Author zandober...@gmail.com Date 2013-12-02 02:24:29 -0800 (Mon, 02 Dec 2013) Log Message Unreviewed GTK gardening. * Scripts/run-gtk-tests: (TestRunner): Skip two unit tests that are causing the subsequent test to crash. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (159923 => 159924) --- trunk/Tools/ChangeLog 2013-12-02 10:12:04 UTC (rev 159923) +++ trunk/Tools/ChangeLog 2013-12-02 10:24:29 UTC (rev 159924) @@ -1,3 +1,10 @@ +2013-12-02 Zan Dobersek zdober...@igalia.com + +Unreviewed GTK gardening. + +* Scripts/run-gtk-tests: +(TestRunner): Skip two unit tests that are causing the subsequent test to crash. + 2013-12-01 Dan Bernstein m...@apple.com [Mac] Transition MiniBrowser to the Cocoa API: policy delegate Modified: trunk/Tools/Scripts/run-gtk-tests (159923 => 159924) --- trunk/Tools/Scripts/run-gtk-tests 2013-12-02 10:12:04 UTC (rev 159923) +++ trunk/Tools/Scripts/run-gtk-tests 2013-12-02 10:24:29 UTC (rev 159924) @@ -83,6 +83,8 @@ SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.ResizeReversePaginatedWebView, Test fails, 120305), SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.ScrollPinningBehaviors, Test fails, 120306), SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.TerminateTwice, Test causes crash on the next test, 121970), +SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.GeolocationTransitionToHighAccuracy, Test causes crash on the next test, 125068), +SkippedTest(TestWebKitAPI/TestWebKit2, WebKit2.GeolocationTransitionToLowAccuracy, Test causes crash on the next test, 125068), SkippedTest(WebKit2APITests/TestInspectorServer, SkippedTest.ENTIRE_SUITE, Timing out on the bot, 122571), ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159925] trunk
Title: [159925] trunk Revision 159925 Author commit-qu...@webkit.org Date 2013-12-02 02:40:07 -0800 (Mon, 02 Dec 2013) Log Message [ATK] Support active state for listbox elements. https://bugs.webkit.org/show_bug.cgi?id=125009 Patch by Andrzej Badowski a.badow...@samsung.com on 2013-12-02 Reviewed by Chris Fleizach. Source/WebCore: Added support for ATK_STATE_ACTIVE for listbox elements. * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: (setAtkStateSetFromCoreObject): Tools: Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive. * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (AccessibilityUIElement::isSelectedOptionActive): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::isSelectedOptionActive): * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::isSelectedOptionActive): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::isSelectedOptionActive): LayoutTests: Establish expectations for the test (all PASS). * accessibility/multiselect-list-reports-active-option-expected.txt: Added. * platform/efl-wk1/TestExpectations: * platform/efl-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk1/TestExpectations trunk/LayoutTests/platform/efl-wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm Added Paths trunk/LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (159924 => 159925) --- trunk/LayoutTests/ChangeLog 2013-12-02 10:24:29 UTC (rev 159924) +++ trunk/LayoutTests/ChangeLog 2013-12-02 10:40:07 UTC (rev 159925) @@ -1,3 +1,16 @@ +2013-12-02 Andrzej Badowski a.badow...@samsung.com + +[ATK] Support active state for listbox elements. +https://bugs.webkit.org/show_bug.cgi?id=125009 + +Reviewed by Chris Fleizach. + +Establish expectations for the test (all PASS). + +* accessibility/multiselect-list-reports-active-option-expected.txt: Added. +* platform/efl-wk1/TestExpectations: +* platform/efl-wk2/TestExpectations: + 2013-11-29 Michał Pakuła vel Rutka m.pak...@samsung.com Unreviewed EFL gardening Added: trunk/LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt (0 => 159925) --- trunk/LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt (rev 0) +++ trunk/LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt 2013-12-02 10:40:07 UTC (rev 159925) @@ -0,0 +1,27 @@ + +This tests that navigating in a multiselect list updates selection and the active selected option and sends a notification. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS accessibleOne.isSelected is true +PASS accessibleOne.isSelectedOptionActive is true +PASS accessibleTwo.isSelected is false +PASS accessibleTwo.isSelectedOptionActive is false +PASS accessibleThree.isSelected is false +PASS accessibleThree.isSelectedOptionActive is false +PASS accessibleOne.isSelected is false +PASS accessibleOne.isSelectedOptionActive is false +PASS accessibleTwo.isSelected is true +PASS accessibleTwo.isSelectedOptionActive is true +PASS accessibleThree.isSelected is false +PASS accessibleThree.isSelectedOptionActive is false +PASS accessibleOne.isSelected is false +PASS accessibleOne.isSelectedOptionActive is false +PASS accessibleTwo.isSelected is true +PASS accessibleTwo.isSelectedOptionActive is false +PASS accessibleThree.isSelected is true +PASS accessibleThree.isSelectedOptionActive is true + +TEST COMPLETE + Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (159924 => 159925) --- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-12-02 10:24:29 UTC (rev 159924) +++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-12-02 10:40:07 UTC (rev 159925) @@ -136,7 +136,6 @@ accessibility/deleting-iframe-destroys-axcache.html [ Skip ] accessibility/img-fallsback-to-title.html [ Skip ] accessibility/internal-link-anchors2.html [ Skip ] -accessibility/multiselect-list-reports-active-option.html [ Skip ] accessibility/radio-button-group-members.html [ Skip ]
[webkit-changes] [159926] trunk/Source/WebKit/gtk
Title: [159926] trunk/Source/WebKit/gtk
Revision 159926
Author g...@gnome.org
Date 2013-12-02 02:44:53 -0800 (Mon, 02 Dec 2013)
Log Message
[GTK] GTK2 paint code path does not render AC layers
https://bugs.webkit.org/show_bug.cgi?id=124967
Patch by Gustavo Noronha Silva gustavo.noro...@collabora.com on 2013-12-02
Reviewed by Carlos Garcia Campos.
* webkit/webkitwebview.cpp:
(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (159925 => 159926)
--- trunk/Source/WebKit/gtk/ChangeLog 2013-12-02 10:40:07 UTC (rev 159925)
+++ trunk/Source/WebKit/gtk/ChangeLog 2013-12-02 10:44:53 UTC (rev 159926)
@@ -1,3 +1,14 @@
+2013-12-02 Gustavo Noronha Silva gustavo.noro...@collabora.com
+
+[GTK] GTK2 paint code path does not render AC layers
+https://bugs.webkit.org/show_bug.cgi?id=124967
+
+Reviewed by Carlos Garcia Campos.
+
+* webkit/webkitwebview.cpp:
+(webkit_web_view_expose_event): also paint AC layers when painting the widget,
+when AC is on.
+
2013-11-28 Gustavo Noronha Silva gustavo.noro...@collabora.com
REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (159925 => 159926)
--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2013-12-02 10:40:07 UTC (rev 159925)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2013-12-02 10:44:53 UTC (rev 159926)
@@ -671,6 +671,17 @@
gdk_region_get_rectangles(event-region, rects.outPtr(), rectCount);
RefPtrcairo_t cr = adoptRef(gdk_cairo_create(event-window));
+
+WebKitWebViewPrivate* priv = WEBKIT_WEB_VIEW(widget)-priv;
+#if USE(TEXTURE_MAPPER)
+GdkRectangle clipRect;
+gdk_region_get_clipbox(event-region, clipRect);
+if (priv-acceleratedCompositingContext-renderLayersToWindow(cr.get(), clipRect)) {
+GTK_WIDGET_CLASS(webkit_web_view_parent_class)-expose_event(widget, event);
+return FALSE;
+}
+#endif
+
for (int i = 0; i rectCount; i++) {
copyRectFromCairoSurfaceToContext(WEBKIT_WEB_VIEW(widget)-priv-backingStore-cairoSurface(),
cr.get(), IntSize(), IntRect(rects.get()[i]));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159927] releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk
Title: [159927] releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk
Revision 159927
Author carlo...@webkit.org
Date 2013-12-02 02:47:57 -0800 (Mon, 02 Dec 2013)
Log Message
Merge r159926 - [GTK] GTK2 paint code path does not render AC layers
https://bugs.webkit.org/show_bug.cgi?id=124967
Patch by Gustavo Noronha Silva gustavo.noro...@collabora.com on 2013-12-02
Reviewed by Carlos Garcia Campos.
* webkit/webkitwebview.cpp:
(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.
Modified Paths
releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/webkit/webkitwebview.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/ChangeLog (159926 => 159927)
--- releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/ChangeLog 2013-12-02 10:44:53 UTC (rev 159926)
+++ releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/ChangeLog 2013-12-02 10:47:57 UTC (rev 159927)
@@ -1,3 +1,14 @@
+2013-12-02 Gustavo Noronha Silva gustavo.noro...@collabora.com
+
+[GTK] GTK2 paint code path does not render AC layers
+https://bugs.webkit.org/show_bug.cgi?id=124967
+
+Reviewed by Carlos Garcia Campos.
+
+* webkit/webkitwebview.cpp:
+(webkit_web_view_expose_event): also paint AC layers when painting the widget,
+when AC is on.
+
2013-11-28 Gustavo Noronha Silva gustavo.noro...@collabora.com
REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
Modified: releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/webkit/webkitwebview.cpp (159926 => 159927)
--- releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/webkit/webkitwebview.cpp 2013-12-02 10:44:53 UTC (rev 159926)
+++ releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk/webkit/webkitwebview.cpp 2013-12-02 10:47:57 UTC (rev 159927)
@@ -669,6 +669,17 @@
gdk_region_get_rectangles(event-region, rects.outPtr(), rectCount);
RefPtrcairo_t cr = adoptRef(gdk_cairo_create(event-window));
+
+WebKitWebViewPrivate* priv = WEBKIT_WEB_VIEW(widget)-priv;
+#if USE(TEXTURE_MAPPER)
+GdkRectangle clipRect;
+gdk_region_get_clipbox(event-region, clipRect);
+if (priv-acceleratedCompositingContext-renderLayersToWindow(cr.get(), clipRect)) {
+GTK_WIDGET_CLASS(webkit_web_view_parent_class)-expose_event(widget, event);
+return FALSE;
+}
+#endif
+
for (int i = 0; i rectCount; i++) {
copyRectFromCairoSurfaceToContext(WEBKIT_WEB_VIEW(widget)-priv-backingStore-cairoSurface(),
cr.get(), IntSize(), IntRect(rects.get()[i]));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159928] trunk
Title: [159928] trunk Revision 159928 Author commit-qu...@webkit.org Date 2013-12-02 03:27:09 -0800 (Mon, 02 Dec 2013) Log Message [GTK] Remove unneeded autoconf macros https://bugs.webkit.org/show_bug.cgi?id=125044 Compilers that do not support const/inline/volatile and systems with pre-C89-headers are anyway not supported. Patch by Adrian Bunk b...@stusta.de on 2013-12-02 Reviewed by Gustavo Noronha Silva. * Source/autotools/CheckSystemAndBasicDependencies.m4: Modified Paths trunk/ChangeLog trunk/Source/autotools/CheckSystemAndBasicDependencies.m4 Diff Modified: trunk/ChangeLog (159927 => 159928) --- trunk/ChangeLog 2013-12-02 10:47:57 UTC (rev 159927) +++ trunk/ChangeLog 2013-12-02 11:27:09 UTC (rev 159928) @@ -1,3 +1,15 @@ +2013-12-02 Adrian Bunk b...@stusta.de + +[GTK] Remove unneeded autoconf macros +https://bugs.webkit.org/show_bug.cgi?id=125044 + +Compilers that do not support const/inline/volatile and +systems with pre-C89-headers are anyway not supported. + +Reviewed by Gustavo Noronha Silva. + +* Source/autotools/CheckSystemAndBasicDependencies.m4: + 2013-11-29 Laszlo Vidacs l...@inf.u-szeged.hu [cmake] Fix cmake warning: Argument not separated from preceding token by whitespace Modified: trunk/Source/autotools/CheckSystemAndBasicDependencies.m4 (159927 => 159928) --- trunk/Source/autotools/CheckSystemAndBasicDependencies.m4 2013-12-02 10:47:57 UTC (rev 159927) +++ trunk/Source/autotools/CheckSystemAndBasicDependencies.m4 2013-12-02 11:27:09 UTC (rev 159928) @@ -135,11 +135,5 @@ CXXFLAGS=$OLD_CXXFLAGS fi -# C/C++ Language Features -AC_C_CONST -AC_C_INLINE -AC_C_VOLATILE - # C/C++ Headers -AC_HEADER_STDC AC_HEADER_STDBOOL ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159930] trunk/LayoutTests
Title: [159930] trunk/LayoutTests Revision 159930 Author zandober...@gmail.com Date 2013-12-02 03:34:58 -0800 (Mon, 02 Dec 2013) Log Message Unreviewed GTK gardening. * platform/gtk/TestExpectations: Adding failure expectations for the fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html reftest. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (159929 => 159930) --- trunk/LayoutTests/ChangeLog 2013-12-02 11:30:51 UTC (rev 159929) +++ trunk/LayoutTests/ChangeLog 2013-12-02 11:34:58 UTC (rev 159930) @@ -1,3 +1,10 @@ +2013-12-02 Zan Dobersek zdober...@igalia.com + +Unreviewed GTK gardening. + +* platform/gtk/TestExpectations: Adding failure expectations for the +fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html reftest. + 2013-12-02 Gyuyoung Kim gyuyoung@samsung.com Unreviewed, EFL rebaseline since r159915. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (159929 => 159930) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-02 11:30:51 UTC (rev 159929) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-02 11:34:58 UTC (rev 159930) @@ -1510,6 +1510,8 @@ webkit.org/b/124835 fast/repaint/repaint-regions-overflow.html [ Failure ] +webkit.org/b/125071 fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html [ ImageOnlyFailure ] + # # End of Tests failing # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159931] trunk/Source/WebCore
Title: [159931] trunk/Source/WebCore
Revision 159931
Author commit-qu...@webkit.org
Date 2013-12-02 05:58:39 -0800 (Mon, 02 Dec 2013)
Log Message
Fix a crash in the webaudio source provider when the audio track is going away.
https://bugs.webkit.org/show_bug.cgi?id=124975
Patch by Nick Diego Yamane nick.yam...@openbossa.org on 2013-12-02
Reviewed by Philippe Normand.
Merged https://chromium.googlesource.com/chromium/blink/+/b21838b32bf11b1a972dfc449ddde71115490c23
Before this patch, it was hitting a use-after-free crash when the audio
track in the media stream is going away and the webaudio mediastreamsourcenode
is still running.
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource): Passing audio track
pointer to MediaStreamAudioSourceNode constructor.
* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
* Modules/webaudio/MediaStreamAudioSourceNode.h: Added
MediaStreamTrack class variable and change the constructor to receive
it as parameter.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp
trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp
trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (159930 => 159931)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 11:34:58 UTC (rev 159930)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 13:58:39 UTC (rev 159931)
@@ -1,3 +1,26 @@
+2013-12-02 Nick Diego Yamane nick.yam...@openbossa.org
+
+Fix a crash in the webaudio source provider when the audio track is going away.
+https://bugs.webkit.org/show_bug.cgi?id=124975
+
+Reviewed by Philippe Normand.
+
+Merged https://chromium.googlesource.com/chromium/blink/+/b21838b32bf11b1a972dfc449ddde71115490c23
+
+Before this patch, it was hitting a use-after-free crash when the audio
+track in the media stream is going away and the webaudio mediastreamsourcenode
+is still running.
+
+* Modules/webaudio/AudioContext.cpp:
+(WebCore::AudioContext::createMediaStreamSource): Passing audio track
+pointer to MediaStreamAudioSourceNode constructor.
+* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
+(WebCore::MediaStreamAudioSourceNode::create):
+(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
+* Modules/webaudio/MediaStreamAudioSourceNode.h: Added
+MediaStreamTrack class variable and change the constructor to receive
+it as parameter.
+
2013-12-02 Andrzej Badowski a.badow...@samsung.com
[ATK] Support active state for listbox elements.
Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp (159930 => 159931)
--- trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp 2013-12-02 11:34:58 UTC (rev 159930)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp 2013-12-02 13:58:39 UTC (rev 159931)
@@ -417,20 +417,21 @@
AudioSourceProvider* provider = 0;
VectorRefPtrMediaStreamTrack audioTracks = mediaStream-getAudioTracks();
+RefPtrMediaStreamTrack audioTrack;
+
// FIXME: get a provider for non-local MediaStreams (like from a remote peer).
for (size_t i = 0; i audioTracks.size(); ++i) {
-RefPtrMediaStreamTrack localAudio = audioTracks[i];
-if (!localAudio-source()-isAudioStreamSource())
-continue;
-
-MediaStreamAudioSource* source = static_castMediaStreamAudioSource*(localAudio-source());
-ASSERT(!source-deviceId().isEmpty());
-destination()-enableInput(source-deviceId());
-provider = destination()-localAudioInputProvider();
-break;
+audioTrack = audioTracks[i];
+if (audioTrack-source()-isAudioStreamSource()) {
+auto source = static_castMediaStreamAudioSource*(audioTrack-source());
+ASSERT(!source-deviceId().isEmpty());
+destination()-enableInput(source-deviceId());
+provider = destination()-localAudioInputProvider();
+break;
+}
}
-RefPtrMediaStreamAudioSourceNode node = MediaStreamAudioSourceNode::create(this, mediaStream, provider);
+RefPtrMediaStreamAudioSourceNode node = MediaStreamAudioSourceNode::create(this, mediaStream, audioTrack.get(), provider);
// FIXME: Only stereo streams are supported right now. We should be able to accept multi-channel streams.
node-setFormat(2, sampleRate());
Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp (159930 => 159931)
--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp 2013-12-02 11:34:58 UTC (rev 159930)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp 2013-12-02 13:58:39 UTC (rev 159931)
@@ -35,14 +35,15 @@
namespace WebCore {
[webkit-changes] [159932] trunk
Title: [159932] trunk
Revision 159932
Author cfleiz...@apple.com
Date 2013-12-02 06:19:10 -0800 (Mon, 02 Dec 2013)
Log Message
AX: Crash at WebCore::commonTreeScope
https://bugs.webkit.org/show_bug.cgi?id=125042
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When an AX text marker that references a node in a detached document is used to create a text marker range, a crash occurs
because the method to determine commonTreeScopes does not account for when there are no common tree scopes.
Test: platform/mac/accessibility/ordered-textmarker-crash.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions):
* dom/TreeScope.cpp:
(WebCore::commonTreeScope):
LayoutTests:
* platform/mac/accessibility/ordered-textmarker-crash-expected.txt: Added.
* platform/mac/accessibility/ordered-textmarker-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/dom/TreeScope.cpp
Added Paths
trunk/LayoutTests/platform/mac/accessibility/ordered-textmarker-crash-expected.txt
trunk/LayoutTests/platform/mac/accessibility/ordered-textmarker-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (159931 => 159932)
--- trunk/LayoutTests/ChangeLog 2013-12-02 13:58:39 UTC (rev 159931)
+++ trunk/LayoutTests/ChangeLog 2013-12-02 14:19:10 UTC (rev 159932)
@@ -1,3 +1,13 @@
+2013-12-02 Chris Fleizach cfleiz...@apple.com
+
+AX: Crash at WebCore::commonTreeScope
+https://bugs.webkit.org/show_bug.cgi?id=125042
+
+Reviewed by Mario Sanchez Prada.
+
+* platform/mac/accessibility/ordered-textmarker-crash-expected.txt: Added.
+* platform/mac/accessibility/ordered-textmarker-crash.html: Added.
+
2013-12-02 Zan Dobersek zdober...@igalia.com
Unreviewed GTK gardening.
Added: trunk/LayoutTests/platform/mac/accessibility/ordered-textmarker-crash-expected.txt (0 => 159932)
--- trunk/LayoutTests/platform/mac/accessibility/ordered-textmarker-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/ordered-textmarker-crash-expected.txt 2013-12-02 14:19:10 UTC (rev 159932)
@@ -0,0 +1,7 @@
+
+This tests that comparing text markers that have no common tree scope won't crash
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+
Added: trunk/LayoutTests/platform/mac/accessibility/ordered-textmarker-crash.html (0 => 159932)
--- trunk/LayoutTests/platform/mac/accessibility/ordered-textmarker-crash.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/ordered-textmarker-crash.html 2013-12-02 14:19:10 UTC (rev 159932)
@@ -0,0 +1,50 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body id=body _onload_=setTimeout('runTest();', 1)
+
+div id=content1
+iframe src=""
+/div
+
+div role=group id=console/div
+
+script
+
+description(This tests that comparing text markers that have no common tree scope won't crash);
+
+if (window.accessibilityController window.testRunner) {
+window.testRunner.waitUntilDone();
+window.jsTestIsAsync = true;
+}
+
+function runTest() {
+
+// Get a text marker inside the frame we will remove.
+var text1 = accessibilityController.accessibleElementById(content1).childAtIndex(0).childAtIndex(0).childAtIndex(0).childAtIndex(0);
+var range1 = text1.textMarkerRangeForElement(text1);
+marker1 = text1.startTextMarkerForTextMarkerRange(range1);
+
+// Get a marker for the main frame.
+var text2 = accessibilityController.rootElement.childAtIndex(0).childAtIndex(0);
+var range2 = text2.textMarkerRangeForElement(text2);
+marker2 = text2.startTextMarkerForTextMarkerRange(range2);
+
+// Remove the child frame that we have a reference to the text marker from.
+var content1 = document.getElementById(content1).childNodes[0];
+content1.parentNode.removeChild(content1);
+
+// Ask for the text marker range with the markers in a different tree.
+// This should NOT crash!
+var range = accessibilityController.rootElement.childAtIndex(0).textMarkerRangeForMarkers(marker1, marker2);
+window.testRunner.notifyDone();
+finishJSTest();
+}
+
+/script
+
+script src=""
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (159931 => 159932)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 13:58:39 UTC (rev 159931)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 14:19:10 UTC (rev 159932)
@@ -1,3 +1,20 @@
+2013-12-02 Chris Fleizach cfleiz...@apple.com
+
+AX: Crash at WebCore::commonTreeScope
+https://bugs.webkit.org/show_bug.cgi?id=125042
+
+Reviewed by Mario Sanchez Prada.
+
+When an AX text marker that references a node in a detached document is used to create a text marker range, a
[webkit-changes] [159933] trunk/Source/JavaScriptCore
Title: [159933] trunk/Source/_javascript_Core Revision 159933 Author commit-qu...@webkit.org Date 2013-12-02 07:36:06 -0800 (Mon, 02 Dec 2013) Log Message JSC does not build if OPCODE_STATS is enabled. https://bugs.webkit.org/show_bug.cgi?id=125011 Patch by László Langó la...@inf.u-szeged.hu on 2013-12-02 Reviewed by Filip Pizlo. * bytecode/Opcode.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/Opcode.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (159932 => 159933) --- trunk/Source/_javascript_Core/ChangeLog 2013-12-02 14:19:10 UTC (rev 159932) +++ trunk/Source/_javascript_Core/ChangeLog 2013-12-02 15:36:06 UTC (rev 159933) @@ -1,3 +1,12 @@ +2013-12-02 László Langó la...@inf.u-szeged.hu + +JSC does not build if OPCODE_STATS is enabled. +https://bugs.webkit.org/show_bug.cgi?id=125011 + +Reviewed by Filip Pizlo. + +* bytecode/Opcode.cpp: + 2013-11-29 Filip Pizlo fpi...@apple.com Finally remove those DFG_ENABLE things Modified: trunk/Source/_javascript_Core/bytecode/Opcode.cpp (159932 => 159933) --- trunk/Source/_javascript_Core/bytecode/Opcode.cpp 2013-12-02 14:19:10 UTC (rev 159932) +++ trunk/Source/_javascript_Core/bytecode/Opcode.cpp 2013-12-02 15:36:06 UTC (rev 159933) @@ -31,7 +31,7 @@ #include Opcode.h #if ENABLE(OPCODE_STATS) -#include stdio.h +#include wtf/DataLog.h #include wtf/FixedArray.h #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159934] trunk/Source/JavaScriptCore
Title: [159934] trunk/Source/_javascript_Core
Revision 159934
Author commit-qu...@webkit.org
Date 2013-12-02 08:38:58 -0800 (Mon, 02 Dec 2013)
Log Message
jsc: implement a native readFile function
https://bugs.webkit.org/show_bug.cgi?id=125059
Patch by Brian J. Burg b...@cs.washington.edu on 2013-12-02
Reviewed by Filip Pizlo.
This adds a native readFile() function to jsc, used to slurp
an entire file into a _javascript_ string.
* jsc.cpp:
(GlobalObject::finishCreation): Add readFile() to globals.
(functionReadFile): Added.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (159933 => 159934)
--- trunk/Source/_javascript_Core/ChangeLog 2013-12-02 15:36:06 UTC (rev 159933)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-12-02 16:38:58 UTC (rev 159934)
@@ -1,3 +1,17 @@
+2013-12-02 Brian J. Burg b...@cs.washington.edu
+
+jsc: implement a native readFile function
+https://bugs.webkit.org/show_bug.cgi?id=125059
+
+Reviewed by Filip Pizlo.
+
+This adds a native readFile() function to jsc, used to slurp
+an entire file into a _javascript_ string.
+
+* jsc.cpp:
+(GlobalObject::finishCreation): Add readFile() to globals.
+(functionReadFile): Added.
+
2013-12-02 László Langó la...@inf.u-szeged.hu
JSC does not build if OPCODE_STATS is enabled.
Modified: trunk/Source/_javascript_Core/jsc.cpp (159933 => 159934)
--- trunk/Source/_javascript_Core/jsc.cpp 2013-12-02 15:36:06 UTC (rev 159933)
+++ trunk/Source/_javascript_Core/jsc.cpp 2013-12-02 16:38:58 UTC (rev 159934)
@@ -108,6 +108,7 @@
static EncodedJSValue JSC_HOST_CALL functionVersion(ExecState*);
static EncodedJSValue JSC_HOST_CALL functionRun(ExecState*);
static EncodedJSValue JSC_HOST_CALL functionLoad(ExecState*);
+static EncodedJSValue JSC_HOST_CALL functionReadFile(ExecState*);
static EncodedJSValue JSC_HOST_CALL functionCheckSyntax(ExecState*);
static EncodedJSValue JSC_HOST_CALL functionReadline(ExecState*);
static EncodedJSValue JSC_HOST_CALL functionPreciseTime(ExecState*);
@@ -226,6 +227,7 @@
addFunction(vm, version, functionVersion, 1);
addFunction(vm, run, functionRun, 1);
addFunction(vm, load, functionLoad, 1);
+addFunction(vm, readFile, functionReadFile, 1);
addFunction(vm, checkSyntax, functionCheckSyntax, 1);
addFunction(vm, jscStack, functionJSCStack, 1);
addFunction(vm, readline, functionReadline, 0);
@@ -421,6 +423,16 @@
return JSValue::encode(result);
}
+EncodedJSValue JSC_HOST_CALL functionReadFile(ExecState* exec)
+{
+String fileName = exec-argument(0).toString(exec)-value(exec);
+Vectorchar script;
+if (!fillBufferWithContentsOfFile(fileName, script))
+return JSValue::encode(exec-vm().throwException(exec, createError(exec, Could not open file.)));
+
+return JSValue::encode(jsString(exec, stringFromUTF(script.data(;
+}
+
EncodedJSValue JSC_HOST_CALL functionCheckSyntax(ExecState* exec)
{
String fileName = exec-argument(0).toString(exec)-value(exec);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159935] trunk/Source/JavaScriptCore
Title: [159935] trunk/Source/_javascript_Core Revision 159935 Author commit-qu...@webkit.org Date 2013-12-02 08:41:33 -0800 (Mon, 02 Dec 2013) Log Message [MIPS] Small stack frame causes regressions. https://bugs.webkit.org/show_bug.cgi?id=124945 Patch by Balazs Kilvady kilva...@homejinni.com on 2013-12-02 Reviewed by Michael Saboff. Fix stack space for LLInt on MIPS. * llint/LowLevelInterpreter32_64.asm: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm Diff Modified: trunk/Source/_javascript_Core/ChangeLog (159934 => 159935) --- trunk/Source/_javascript_Core/ChangeLog 2013-12-02 16:38:58 UTC (rev 159934) +++ trunk/Source/_javascript_Core/ChangeLog 2013-12-02 16:41:33 UTC (rev 159935) @@ -1,3 +1,14 @@ +2013-12-02 Balazs Kilvady kilva...@homejinni.com + +[MIPS] Small stack frame causes regressions. +https://bugs.webkit.org/show_bug.cgi?id=124945 + +Reviewed by Michael Saboff. + +Fix stack space for LLInt on MIPS. + +* llint/LowLevelInterpreter32_64.asm: + 2013-12-02 Brian J. Burg b...@cs.washington.edu jsc: implement a native readFile function Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (159934 => 159935) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2013-12-02 16:38:58 UTC (rev 159934) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2013-12-02 16:41:33 UTC (rev 159935) @@ -190,8 +190,8 @@ const entry = a0 const newCallFrame = a1 elsif MIPS -const extraStackSpace = 20 -const previousCFR = t2 +const extraStackSpace = 36 +const previousCFR = t2 const previousPC = lr const entry = a0 const newCallFrame = a1 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159936] trunk/Source/JavaScriptCore
Title: [159936] trunk/Source/_javascript_Core
Revision 159936
Author commit-qu...@webkit.org
Date 2013-12-02 08:51:07 -0800 (Mon, 02 Dec 2013)
Log Message
Unused include files when building without JIT.
https://bugs.webkit.org/show_bug.cgi?id=125062
Patch by László Langó la...@inf.u-szeged.hu on 2013-12-02
Reviewed by Michael Saboff.
We should organize the includes, and guard JIT methods
in ValueRecovery.
* bytecode/ValueRecovery.cpp: Guard include files.
* bytecode/ValueRecovery.h: Guard JIT methods.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/ValueRecovery.cpp
trunk/Source/_javascript_Core/bytecode/ValueRecovery.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (159935 => 159936)
--- trunk/Source/_javascript_Core/ChangeLog 2013-12-02 16:41:33 UTC (rev 159935)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-12-02 16:51:07 UTC (rev 159936)
@@ -1,3 +1,16 @@
+2013-12-02 László Langó la...@inf.u-szeged.hu
+
+Unused include files when building without JIT.
+https://bugs.webkit.org/show_bug.cgi?id=125062
+
+Reviewed by Michael Saboff.
+
+We should organize the includes, and guard JIT methods
+in ValueRecovery.
+
+* bytecode/ValueRecovery.cpp: Guard include files.
+* bytecode/ValueRecovery.h: Guard JIT methods.
+
2013-12-02 Balazs Kilvady kilva...@homejinni.com
[MIPS] Small stack frame causes regressions.
Modified: trunk/Source/_javascript_Core/bytecode/ValueRecovery.cpp (159935 => 159936)
--- trunk/Source/_javascript_Core/bytecode/ValueRecovery.cpp 2013-12-02 16:41:33 UTC (rev 159935)
+++ trunk/Source/_javascript_Core/bytecode/ValueRecovery.cpp 2013-12-02 16:51:07 UTC (rev 159936)
@@ -60,6 +60,8 @@
}
}
+#if ENABLE(JIT)
+
void ValueRecovery::dumpInContext(PrintStream out, DumpContext* context) const
{
switch (technique()) {
@@ -130,6 +132,7 @@
{
dumpInContext(out, 0);
}
+#endif // ENABLE(JIT)
} // namespace JSC
Modified: trunk/Source/_javascript_Core/bytecode/ValueRecovery.h (159935 => 159936)
--- trunk/Source/_javascript_Core/bytecode/ValueRecovery.h 2013-12-02 16:41:33 UTC (rev 159935)
+++ trunk/Source/_javascript_Core/bytecode/ValueRecovery.h 2013-12-02 16:51:07 UTC (rev 159936)
@@ -27,12 +27,13 @@
#define ValueRecovery_h
#include DataFormat.h
+#if ENABLE(JIT)
#include GPRInfo.h
#include FPRInfo.h
+#endif
#include JSCJSValue.h
#include MacroAssembler.h
#include VirtualRegister.h
-#include stdio.h
#include wtf/Platform.h
namespace JSC {
@@ -246,8 +247,10 @@
JSValue recover(ExecState*) const;
+#if ENABLE(JIT)
void dumpInContext(PrintStream out, DumpContext* context) const;
void dump(PrintStream out) const;
+#endif
private:
ValueRecoveryTechnique m_technique;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159937] trunk/Source/JavaScriptCore
Title: [159937] trunk/Source/_javascript_Core
Revision 159937
Author commit-qu...@webkit.org
Date 2013-12-02 09:14:37 -0800 (Mon, 02 Dec 2013)
Log Message
Remove stdio.h from JSC files.
https://bugs.webkit.org/show_bug.cgi?id=125066
Patch by László Langó la...@inf.u-szeged.hu on 2013-12-02
Reviewed by Michael Saboff.
Remove stdio.h, when it is not necessary to be included.
* bytecode/CodeBlock.cpp:
* bytecode/StructureSet.h:
* profiler/LegacyProfiler.cpp:
* profiler/Profile.cpp:
* profiler/ProfileNode.cpp:
* yarr/YarrInterpreter.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/StructureSet.h
trunk/Source/_javascript_Core/profiler/LegacyProfiler.cpp
trunk/Source/_javascript_Core/profiler/Profile.cpp
trunk/Source/_javascript_Core/profiler/ProfileNode.cpp
trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (159936 => 159937)
--- trunk/Source/_javascript_Core/ChangeLog 2013-12-02 16:51:07 UTC (rev 159936)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-12-02 17:14:37 UTC (rev 159937)
@@ -1,5 +1,21 @@
2013-12-02 László Langó la...@inf.u-szeged.hu
+Remove stdio.h from JSC files.
+https://bugs.webkit.org/show_bug.cgi?id=125066
+
+Reviewed by Michael Saboff.
+
+Remove stdio.h, when it is not necessary to be included.
+
+* bytecode/CodeBlock.cpp:
+* bytecode/StructureSet.h:
+* profiler/LegacyProfiler.cpp:
+* profiler/Profile.cpp:
+* profiler/ProfileNode.cpp:
+* yarr/YarrInterpreter.cpp:
+
+2013-12-02 László Langó la...@inf.u-szeged.hu
+
Unused include files when building without JIT.
https://bugs.webkit.org/show_bug.cgi?id=125062
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (159936 => 159937)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2013-12-02 16:51:07 UTC (rev 159936)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2013-12-02 17:14:37 UTC (rev 159937)
@@ -53,7 +53,6 @@
#include Repatch.h
#include RepatchBuffer.h
#include SlotVisitorInlines.h
-#include stdio.h
#include wtf/BagToHashMap.h
#include wtf/CommaPrinter.h
#include wtf/StringExtras.h
Modified: trunk/Source/_javascript_Core/bytecode/StructureSet.h (159936 => 159937)
--- trunk/Source/_javascript_Core/bytecode/StructureSet.h 2013-12-02 16:51:07 UTC (rev 159936)
+++ trunk/Source/_javascript_Core/bytecode/StructureSet.h 2013-12-02 17:14:37 UTC (rev 159937)
@@ -30,7 +30,6 @@
#include SpeculatedType.h
#include Structure.h
#include DumpContext.h
-#include stdio.h
#include wtf/CommaPrinter.h
#include wtf/Vector.h
Modified: trunk/Source/_javascript_Core/profiler/LegacyProfiler.cpp (159936 => 159937)
--- trunk/Source/_javascript_Core/profiler/LegacyProfiler.cpp 2013-12-02 16:51:07 UTC (rev 159936)
+++ trunk/Source/_javascript_Core/profiler/LegacyProfiler.cpp 2013-12-02 17:14:37 UTC (rev 159937)
@@ -40,7 +40,6 @@
#include Profile.h
#include ProfileGenerator.h
#include ProfileNode.h
-#include stdio.h
namespace JSC {
Modified: trunk/Source/_javascript_Core/profiler/Profile.cpp (159936 => 159937)
--- trunk/Source/_javascript_Core/profiler/Profile.cpp 2013-12-02 16:51:07 UTC (rev 159936)
+++ trunk/Source/_javascript_Core/profiler/Profile.cpp 2013-12-02 17:14:37 UTC (rev 159937)
@@ -27,7 +27,6 @@
#include Profile.h
#include ProfileNode.h
-#include stdio.h
#include wtf/DataLog.h
namespace JSC {
Modified: trunk/Source/_javascript_Core/profiler/ProfileNode.cpp (159936 => 159937)
--- trunk/Source/_javascript_Core/profiler/ProfileNode.cpp 2013-12-02 16:51:07 UTC (rev 159936)
+++ trunk/Source/_javascript_Core/profiler/ProfileNode.cpp 2013-12-02 17:14:37 UTC (rev 159937)
@@ -30,7 +30,6 @@
#include ProfileNode.h
#include LegacyProfiler.h
-#include stdio.h
#include wtf/DateMath.h
#include wtf/DataLog.h
#include wtf/text/StringHash.h
Modified: trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp (159936 => 159937)
--- trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp 2013-12-02 16:51:07 UTC (rev 159936)
+++ trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp 2013-12-02 17:14:37 UTC (rev 159937)
@@ -34,10 +34,6 @@
#include wtf/text/CString.h
#include wtf/text/WTFString.h
-#ifndef NDEBUG
-#include stdio.h
-#endif
-
using namespace WTF;
namespace JSC { namespace Yarr {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159939] trunk/Source/WebCore
Title: [159939] trunk/Source/WebCore Revision 159939 Author commit-qu...@webkit.org Date 2013-12-02 09:49:08 -0800 (Mon, 02 Dec 2013) Log Message [GTK] Fails to build with freetype 2.5.1 https://bugs.webkit.org/show_bug.cgi?id=125074 Patch by Andres Gomez ago...@igalia.com on 2013-12-02 Reviewed by Carlos Garcia Campos. FreeType specifies a canonical way of including their own headers. Now, we are following this recommendation so the compilation won't be broken again due to an upgrade in FeeType's including paths. * platform/graphics/freetype/FontPlatformDataFreeType.cpp: * platform/graphics/freetype/SimpleFontDataFreeType.cpp: * platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (159938 => 159939) --- trunk/Source/WebCore/ChangeLog 2013-12-02 17:20:52 UTC (rev 159938) +++ trunk/Source/WebCore/ChangeLog 2013-12-02 17:49:08 UTC (rev 159939) @@ -1,3 +1,19 @@ +2013-12-02 Andres Gomez ago...@igalia.com + +[GTK] Fails to build with freetype 2.5.1 +https://bugs.webkit.org/show_bug.cgi?id=125074 + +Reviewed by Carlos Garcia Campos. + +FreeType specifies a canonical way of including their own +headers. Now, we are following this recommendation so the +compilation won't be broken again due to an upgrade in FeeType's +including paths. + +* platform/graphics/freetype/FontPlatformDataFreeType.cpp: +* platform/graphics/freetype/SimpleFontDataFreeType.cpp: +* platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp: + 2013-12-02 Chris Fleizach cfleiz...@apple.com AX: Crash at WebCore::commonTreeScope Modified: trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp (159938 => 159939) --- trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp 2013-12-02 17:20:52 UTC (rev 159938) +++ trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp 2013-12-02 17:49:08 UTC (rev 159939) @@ -29,7 +29,8 @@ #include cairo-ft.h #include cairo.h #include fontconfig/fcfreetype.h -#include freetype/tttables.h +#include ft2build.h +#include FT_TRUETYPE_TABLES_H #include wtf/text/WTFString.h #if !PLATFORM(EFL) !PLATFORM(NIX) Modified: trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp (159938 => 159939) --- trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp 2013-12-02 17:20:52 UTC (rev 159938) +++ trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp 2013-12-02 17:49:08 UTC (rev 159939) @@ -44,8 +44,9 @@ #include cairo-ft.h #include cairo.h #include fontconfig/fcfreetype.h -#include freetype/tttables.h -#include freetype/tttags.h +#include ft2build.h +#include FT_TRUETYPE_TABLES_H +#include FT_TRUETYPE_TAGS_H #include unicode/normlzr.h #include wtf/MathExtras.h #include wtf/unicode/Unicode.h Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp (159938 => 159939) --- trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp 2013-12-02 17:20:52 UTC (rev 159938) +++ trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp 2013-12-02 17:49:08 UTC (rev 159939) @@ -39,8 +39,9 @@ #include TextEncoding.h #include cairo-ft.h #include cairo.h -#include freetype/freetype.h -#include freetype/tttables.h +#include ft2build.h +#include FT_FREETYPE_H +#include FT_TRUETYPE_TABLES_H #include hb.h #include wtf/text/CString.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159940] trunk/Source/JavaScriptCore
Title: [159940] trunk/Source/_javascript_Core
Revision 159940
Author commit-qu...@webkit.org
Date 2013-12-02 10:23:45 -0800 (Mon, 02 Dec 2013)
Log Message
[JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
https://bugs.webkit.org/show_bug.cgi?id=125075
Patch by Nick Diego Yamane nick.yam...@openbossa.org on 2013-12-02
Reviewed by Michael Saboff.
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall): added UNUSED_PARAM(pc).
(JSC::LLInt::setUpCall): Doesn't pass 'pc' to LLINT_CALL macros.
(JSC::LLInt::LLINT_SLOW_PATH_DECL): Ditto.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (159939 => 159940)
--- trunk/Source/_javascript_Core/ChangeLog 2013-12-02 17:49:08 UTC (rev 159939)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-12-02 18:23:45 UTC (rev 159940)
@@ -1,3 +1,15 @@
+2013-12-02 Nick Diego Yamane nick.yam...@openbossa.org
+
+[JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
+https://bugs.webkit.org/show_bug.cgi?id=125075
+
+Reviewed by Michael Saboff.
+
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::handleHostCall): added UNUSED_PARAM(pc).
+(JSC::LLInt::setUpCall): Doesn't pass 'pc' to LLINT_CALL macros.
+(JSC::LLInt::LLINT_SLOW_PATH_DECL): Ditto.
+
2013-12-02 László Langó la...@inf.u-szeged.hu
Remove stdio.h from JSC files.
Modified: trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp (159939 => 159940)
--- trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp 2013-12-02 17:49:08 UTC (rev 159939)
+++ trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp 2013-12-02 18:23:45 UTC (rev 159940)
@@ -142,7 +142,7 @@
#define LLINT_CALL_END_IMPL(exec, callTarget) LLINT_RETURN_TWO((callTarget), (exec))
-#define LLINT_CALL_THROW(exec, pc, exceptionToThrow) do { \
+#define LLINT_CALL_THROW(exec, exceptionToThrow) do { \
ExecState* __ct_exec = (exec); \
vm.throwException(__ct_exec, exceptionToThrow); \
LLINT_CALL_END_IMPL(__ct_exec, callToThrow(__ct_exec)); \
@@ -154,7 +154,7 @@
LLINT_CALL_END_IMPL(__cce_exec, callToThrow(__cce_exec)); \
} while (false)
-#define LLINT_CALL_RETURN(exec, pc, callTarget) do {\
+#define LLINT_CALL_RETURN(exec, callTarget) do {\
ExecState* __cr_exec = (exec); \
void* __cr_callTarget = (callTarget); \
LLINT_CALL_CHECK_EXCEPTION(__cr_exec-callerFrame()); \
@@ -963,6 +963,8 @@
static SlowPathReturnType handleHostCall(ExecState* execCallee, Instruction* pc, JSValue callee, CodeSpecializationKind kind)
{
+UNUSED_PARAM(pc);
+
#if LLINT_SLOW_PATH_TRACING
dataLog(Performing host call.\n);
#endif
@@ -985,7 +987,7 @@
execCallee-setCallee(asObject(callee));
vm.hostCallReturnValue = JSValue::decode(callData.native.function(execCallee));
-LLINT_CALL_RETURN(execCallee, pc, LLInt::getCodePtr(getHostCallReturnValue));
+LLINT_CALL_RETURN(execCallee, LLInt::getCodePtr(getHostCallReturnValue));
}
#if LLINT_SLOW_PATH_TRACING
@@ -993,7 +995,7 @@
#endif
ASSERT(callType == CallTypeNone);
-LLINT_CALL_THROW(exec, pc, createNotAFunctionError(exec, callee));
+LLINT_CALL_THROW(exec, createNotAFunctionError(exec, callee));
}
ASSERT(kind == CodeForConstruct);
@@ -1008,7 +1010,7 @@
execCallee-setCallee(asObject(callee));
vm.hostCallReturnValue = JSValue::decode(constructData.native.function(execCallee));
-LLINT_CALL_RETURN(execCallee, pc, LLInt::getCodePtr(getHostCallReturnValue));
+LLINT_CALL_RETURN(execCallee, LLInt::getCodePtr(getHostCallReturnValue));
}
#if LLINT_SLOW_PATH_TRACING
@@ -1016,7 +1018,7 @@
#endif
ASSERT(constructType == ConstructTypeNone);
-LLINT_CALL_THROW(exec, pc, createNotAConstructorError(exec, callee));
+LLINT_CALL_THROW(exec, createNotAConstructorError(exec, callee));
}
inline SlowPathReturnType setUpCall(ExecState* execCallee, Instruction* pc, CodeSpecializationKind kind, JSValue calleeAsValue, LLIntCallLinkInfo* callLinkInfo = 0)
@@ -1043,7 +1045,7 @@
FunctionExecutable* functionExecutable = static_castFunctionExecutable*(executable);
JSObject* error = functionExecutable-prepareForExecution(execCallee, callee-scope(), kind);
if (error)
-LLINT_CALL_THROW(execCallee-callerFrame(), pc, error);
+LLINT_CALL_THROW(execCallee-callerFrame(), error);
codeBlock = functionExecutable-codeBlockFor(kind);
ASSERT(codeBlock);
if (execCallee-argumentCountIncludingThis()
[webkit-changes] [159941] trunk/Source/WebKit
Title: [159941] trunk/Source/WebKit Revision 159941 Author bfulg...@apple.com Date 2013-12-02 10:47:01 -0800 (Mon, 02 Dec 2013) Log Message [Win] WebKit Project doesn't copy resource bundle https://bugs.webkit.org/show_bug.cgi?id=125078 Reviewed by Jer Noble. * WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Correct post-build step to copy WebKit.resources to build target. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKitPostBuild.cmd Diff Modified: trunk/Source/WebKit/ChangeLog (159940 => 159941) --- trunk/Source/WebKit/ChangeLog 2013-12-02 18:23:45 UTC (rev 159940) +++ trunk/Source/WebKit/ChangeLog 2013-12-02 18:47:01 UTC (rev 159941) @@ -1,3 +1,13 @@ +2013-12-02 Brent Fulgham bfulg...@apple.com + +[Win] WebKit Project doesn't copy resource bundle +https://bugs.webkit.org/show_bug.cgi?id=125078 + +Reviewed by Jer Noble. + +* WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Correct post-build step +to copy WebKit.resources to build target. + 2013-11-28 Thiago de Barros Lacerda thiago.lace...@openbossa.org Building EFL Webkit again with mediastream enabled Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKitPostBuild.cmd (159940 => 159941) --- trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKitPostBuild.cmd 2013-12-02 18:23:45 UTC (rev 159940) +++ trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKitPostBuild.cmd 2013-12-02 18:47:01 UTC (rev 159941) @@ -1,5 +1,7 @@ mkdir 2NUL %CONFIGURATIONBUILDDIR%\include\WebKit +set ResourcesDirectory=%CONFIGURATIONBUILDDIR%\bin32\WebKit.resources + xcopy /y /d %PROJECTDIR%\..\..\win\WebLocalizableStrings.h %CONFIGURATIONBUILDDIR%\include\WebKit xcopy /y /d %PROJECTDIR%\..\..\win\WebKitGraphics.h %CONFIGURATIONBUILDDIR%\include\WebKit xcopy /y /d %PROJECTDIR%\..\..\win\WebKitCOMAPI.h %CONFIGURATIONBUILDDIR%\include\WebKit @@ -11,6 +13,10 @@ xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\npruntime_internal.h %CONFIGURATIONBUILDDIR%\include\WebKit xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\nptypes.h %CONFIGURATIONBUILDDIR%\include\WebKit +echo Copying resources... +mkdir %ResourcesDirectory% 2NUL +xcopy /y /d %PROJECTDIR%\..\..\win\WebKit.resources\* %ResourcesDirectory% NUL + if exist %WEBKIT_LIBRARIES%\tools\VersionStamper\VersionStamper.exe %WEBKIT_LIBRARIES%\tools\VersionStamper\VersionStamper.exe --verbose %TARGETPATH% if exist %CONFIGURATIONBUILDDIR%\buildfailed del %CONFIGURATIONBUILDDIR%\buildfailed ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159942] trunk/Source/JavaScriptCore
Title: [159942] trunk/Source/_javascript_Core
Revision 159942
Author fpi...@apple.com
Date 2013-12-02 11:09:15 -0800 (Mon, 02 Dec 2013)
Log Message
Instead of watchpointing activation allocation, we should watchpoint entry into functions that have captured variables
https://bugs.webkit.org/show_bug.cgi?id=125052
Reviewed by Mark Hahnenberg.
This makes us watch function entry rather than activation creation. We only incur the
costs of doing so for functions that have captured variables, and only on the first two
entries into the function. This means that closure variable constant inference will
naturally work even for local uses of the captured variable, like:
(function(){
var blah = 42;
... // stuff
function () { ... blah /* we can fold this to 42 */ }
... blah // we can also fold this to 42.
})();
Previously, only the nested use would have been foldable.
* bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecode/Watchpoint.h:
(JSC::WatchpointSet::touch):
(JSC::InlineWatchpointSet::touch):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFGexecuteEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasSymbolTable):
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGWatchpointCollectionPhase.cpp:
(JSC::DFG::WatchpointCollectionPhase::handle):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_touch_entry):
* llint/LowLevelInterpreter.asm:
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
* runtime/CommonSlowPaths.h:
* runtime/JSActivation.h:
(JSC::JSActivation::create):
* runtime/SymbolTable.cpp:
(JSC::SymbolTable::SymbolTable):
* runtime/SymbolTable.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/BytecodeLivenessAnalysis.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/Opcode.h
trunk/Source/_javascript_Core/bytecode/Watchpoint.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCapabilities.cpp
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/dfg/DFGWatchpointCollectionPhase.cpp
trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.h
trunk/Source/_javascript_Core/runtime/JSActivation.h
trunk/Source/_javascript_Core/runtime/SymbolTable.cpp
trunk/Source/_javascript_Core/runtime/SymbolTable.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (159941 => 159942)
--- trunk/Source/_javascript_Core/ChangeLog 2013-12-02 18:47:01 UTC (rev 159941)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-12-02 19:09:15 UTC (rev 159942)
@@ -1,3 +1,78 @@
+2013-12-02 Filip Pizlo fpi...@apple.com
+
+Instead of watchpointing activation allocation, we should watchpoint entry into functions that have captured variables
+https://bugs.webkit.org/show_bug.cgi?id=125052
+
+Reviewed by Mark Hahnenberg.
+
+This makes us watch function entry rather than activation creation. We only incur the
+costs of doing so for functions that have captured variables, and only on the first two
+entries into the function. This means that closure variable constant inference will
+
[webkit-changes] [159945] trunk/Source/WebCore
Title: [159945] trunk/Source/WebCore
Revision 159945
Author vjaq...@igalia.com
Date 2013-12-02 11:55:30 -0800 (Mon, 02 Dec 2013)
Log Message
Simplify MediaPlayerPrivateGStreamerBase::createVideoSink()
https://bugs.webkit.org/show_bug.cgi?id=125077
Remove the method's unused parameter.
Remove the GStreamer 0.10.22 run-time validation, since we are using
GStreamer 1.0 officially.
Remove the creation of a spurious Bin for the video sink, since
either the fpssink or the webkitsink are valid sink elements.
Change fpsink to a GRefPtr.
Now, createVideoSink() returns a simple pointer to the created sink
element.
Reviewed by Philippe Normand.
No new tests, no behavior changes.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (159944 => 159945)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 19:50:51 UTC (rev 159944)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 19:55:30 UTC (rev 159945)
@@ -1,3 +1,30 @@
+2013-12-02 Víctor Manuel Jáquez Leal vjaq...@igalia.com
+
+Simplify MediaPlayerPrivateGStreamerBase::createVideoSink()
+https://bugs.webkit.org/show_bug.cgi?id=125077
+
+Remove the method's unused parameter.
+Remove the GStreamer 0.10.22 run-time validation, since we are using
+GStreamer 1.0 officially.
+Remove the creation of a spurious Bin for the video sink, since
+either the fpssink or the webkitsink are valid sink elements.
+Change fpsink to a GRefPtr.
+
+Now, createVideoSink() returns a simple pointer to the created sink
+element.
+
+Reviewed by Philippe Normand.
+
+No new tests, no behavior changes.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
+(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
+(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
2013-12-02 Alexey Proskuryakov a...@apple.com
Add support for WebCrypto RSA-OAEP
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (159944 => 159945)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2013-12-02 19:50:51 UTC (rev 159944)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2013-12-02 19:55:30 UTC (rev 159945)
@@ -1890,10 +1890,8 @@
}
#endif
-createVideoSink(m_playBin.get());
+g_object_set(m_playBin.get(), video-sink, createVideoSink(), nullptr);
-g_object_set(m_playBin.get(), video-sink, m_videoSinkBin.get(), nullptr);
-
GRefPtrGstPad videoSinkPad = adoptGRef(gst_element_get_static_pad(m_webkitVideoSink.get(), sink));
if (videoSinkPad)
g_signal_connect(videoSinkPad.get(), notify::caps, G_CALLBACK(mediaPlayerPrivateVideoSinkCapsChangedCallback), this);
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (159944 => 159945)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2013-12-02 19:50:51 UTC (rev 159944)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2013-12-02 19:55:30 UTC (rev 159945)
@@ -462,57 +462,41 @@
return currentCaps;
}
-void MediaPlayerPrivateGStreamerBase::createVideoSink(GstElement* pipeline)
+GstElement* MediaPlayerPrivateGStreamerBase::createVideoSink()
{
-if (!initializeGStreamer())
-return;
+ASSERT(initializeGStreamer());
-UNUSED_PARAM(pipeline);
+GstElement* videoSink = nullptr;
m_webkitVideoSink = webkitVideoSinkNew();
m_repaintHandler = g_signal_connect(m_webkitVideoSink.get(), repaint-requested, G_CALLBACK(mediaPlayerPrivateRepaintCallback), this);
-m_videoSinkBin = gst_bin_new(nullptr);
-
-GstElement* videoSink = nullptr;
m_fpsSink = gst_element_factory_make(fpsdisplaysink, sink);
if (m_fpsSink) {
-// The verbose property has been added in -bad 0.10.22. Making
-// this
[webkit-changes] [159946] trunk/Source/WebInspectorUI
Title: [159946] trunk/Source/WebInspectorUI
Revision 159946
Author grao...@apple.com
Date 2013-12-02 11:55:52 -0800 (Mon, 02 Dec 2013)
Log Message
Web Inspector: add a method to add padding around a WebInspector.Rect
https://bugs.webkit.org/show_bug.cgi?id=125072
Reviewed by Joseph Pecoraro.
Add a new WebInspector.Rect.prototype.pad() method which does not alter
the rectangle it's called and returns a new rect much like .inset(). I've
checked all call sites and there was no reuse of the rectangle that was
padded so this patch won't have any side effects.
* UserInterface/Breakpoint.js:
(WebInspector.Breakpoint.prototype._showEditBreakpointPopover):
* UserInterface/CSSStyleDeclarationTextEditor.js:
* UserInterface/Geometry.js:
(WebInspector.Rect.prototype.pad):
* UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._updatePopoverForSelectedNode):
* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._showPopover):
* UserInterface/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js
trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js
trunk/Source/WebInspectorUI/UserInterface/Geometry.js
trunk/Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js
trunk/Source/WebInspectorUI/UserInterface/TimelineDataGrid.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (159945 => 159946)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-12-02 19:55:52 UTC (rev 159946)
@@ -1,3 +1,27 @@
+2013-12-02 Antoine Quint grao...@apple.com
+
+Web Inspector: add a method to add padding around a WebInspector.Rect
+https://bugs.webkit.org/show_bug.cgi?id=125072
+
+Reviewed by Joseph Pecoraro.
+
+Add a new WebInspector.Rect.prototype.pad() method which does not alter
+the rectangle it's called and returns a new rect much like .inset(). I've
+checked all call sites and there was no reuse of the rectangle that was
+padded so this patch won't have any side effects.
+
+* UserInterface/Breakpoint.js:
+(WebInspector.Breakpoint.prototype._showEditBreakpointPopover):
+* UserInterface/CSSStyleDeclarationTextEditor.js:
+* UserInterface/Geometry.js:
+(WebInspector.Rect.prototype.pad):
+* UserInterface/LayerTreeSidebarPanel.js:
+(WebInspector.LayerTreeSidebarPanel.prototype._updatePopoverForSelectedNode):
+* UserInterface/SourceCodeTextEditor.js:
+(WebInspector.SourceCodeTextEditor.prototype._showPopover):
+* UserInterface/TimelineDataGrid.js:
+(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
+
2013-11-26 Antoine Quint grao...@apple.com
Web Inspector: Allow showing a context menu on all mouse events.
Modified: trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js (159945 => 159946)
--- trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/UserInterface/Breakpoint.js 2013-12-02 19:55:52 UTC (rev 159946)
@@ -480,18 +480,12 @@
_showEditBreakpointPopover: function(boundingClientRect)
{
-const padding = 2;
var bounds = WebInspector.Rect.rectFromClientRect(boundingClientRect);
-
bounds.origin.x -= 1; // Move the anchor left one pixel so it looks more centered.
-bounds.origin.x -= padding;
-bounds.origin.y -= padding;
-bounds.size.width += padding * 2;
-bounds.size.height += padding * 2;
this._popover = this._popover || new WebInspector.Popover(this);
this._popover.content = this._editBreakpointPopoverContentElement();
-this._popover.present(bounds, [WebInspector.RectEdge.MAX_Y]);
+this._popover.present(bounds.pad(2), [WebInspector.RectEdge.MAX_Y]);
if (!this._keyboardShortcutEsc) {
this._keyboardShortcutEsc = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.Escape);
Modified: trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js (159945 => 159946)
--- trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js 2013-12-02 19:55:30 UTC (rev 159945)
+++ trunk/Source/WebInspectorUI/UserInterface/CSSStyleDeclarationTextEditor.js 2013-12-02 19:55:52 UTC (rev 159946)
@@ -750,14 +750,9 @@
}.bind(this));
var bounds = WebInspector.Rect.rectFromClientRect(swatch.getBoundingClientRect());
-const padding = 2;
-bounds.origin.x -= padding;
-bounds.origin.y -= padding;
-bounds.size.width += padding * 2;
-bounds.size.height += padding *
[webkit-changes] [159947] trunk/Source/WebCore
Title: [159947] trunk/Source/WebCore Revision 159947 Author vjaq...@igalia.com Date 2013-12-02 11:58:32 -0800 (Mon, 02 Dec 2013) Log Message [Gstreamer] update webkitvideosink metadata https://bugs.webkit.org/show_bug.cgi?id=125082 Reviewed by Philippe Normand. No new tests, no behavior changes. * platform/graphics/gstreamer/VideoSinkGStreamer.cpp: (webkit_video_sink_class_init): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (159946 => 159947) --- trunk/Source/WebCore/ChangeLog 2013-12-02 19:55:52 UTC (rev 159946) +++ trunk/Source/WebCore/ChangeLog 2013-12-02 19:58:32 UTC (rev 159947) @@ -1,3 +1,15 @@ +2013-12-02 Victor Jaquez vjaq...@igalia.com + +[Gstreamer] update webkitvideosink metadata +https://bugs.webkit.org/show_bug.cgi?id=125082 + +Reviewed by Philippe Normand. + +No new tests, no behavior changes. + +* platform/graphics/gstreamer/VideoSinkGStreamer.cpp: +(webkit_video_sink_class_init): + 2013-12-02 Víctor Manuel Jáquez Leal vjaq...@igalia.com Simplify MediaPlayerPrivateGStreamerBase::createVideoSink() Modified: trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp (159946 => 159947) --- trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp 2013-12-02 19:55:52 UTC (rev 159946) +++ trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp 2013-12-02 19:58:32 UTC (rev 159947) @@ -377,7 +377,7 @@ GstElementClass* elementClass = GST_ELEMENT_CLASS(klass); gst_element_class_add_pad_template(elementClass, gst_static_pad_template_get(s_sinkTemplate)); -gst_element_class_set_metadata(elementClass, WebKit video sink, Sink/Video, Sends video data from a GStreamer pipeline to a Cairo surface, Alp Toker a...@atoker.com); +gst_element_class_set_metadata(elementClass, WebKit video sink, Sink/Video, Sends video data from a GStreamer pipeline to WebKit, Igalia, Alp Toker a...@atoker.com); g_type_class_add_private(klass, sizeof(WebKitVideoSinkPrivate)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159948] trunk/Source/WebKit2
Title: [159948] trunk/Source/WebKit2
Revision 159948
Author timothy_hor...@apple.com
Date 2013-12-02 12:00:13 -0800 (Mon, 02 Dec 2013)
Log Message
Remote Layer Tree: Disable direct image compositing
https://bugs.webkit.org/show_bug.cgi?id=124875
rdar://problem/15446024
Reviewed by Simon Fraser.
* WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
Image-as-layer-contents is not implemented for the remote layer tree.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159947 => 159948)
--- trunk/Source/WebKit2/ChangeLog 2013-12-02 19:58:32 UTC (rev 159947)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-02 20:00:13 UTC (rev 159948)
@@ -1,3 +1,14 @@
+2013-12-02 Tim Horton timothy_hor...@apple.com
+
+Remote Layer Tree: Disable direct image compositing
+https://bugs.webkit.org/show_bug.cgi?id=124875
+rdar://problem/15446024
+
+Reviewed by Simon Fraser.
+
+* WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
+Image-as-layer-contents is not implemented for the remote layer tree.
+
2013-12-01 ChangSeok Oh changseok...@collabora.com
Unreviewed Gtk port Build fix after r159903
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.h (159947 => 159948)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.h 2013-12-02 19:58:32 UTC (rev 159947)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.h 2013-12-02 20:00:13 UTC (rev 159948)
@@ -56,6 +56,9 @@
// No accelerated animations for now.
virtual bool addAnimation(const WebCore::KeyframeValueList, const WebCore::IntSize, const WebCore::Animation*, const String, double) OVERRIDE { return false; }
+// PlatformCALayerRemote can't currently proxy directly composited image contents, so opt out of this optimization.
+virtual bool shouldDirectlyCompositeImage(WebCore::Image*) const OVERRIDE { return false; }
+
RemoteLayerTreeContext* m_context;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159949] trunk/Source/WebCore
Title: [159949] trunk/Source/WebCore
Revision 159949
Author a...@apple.com
Date 2013-12-02 12:05:26 -0800 (Mon, 02 Dec 2013)
Log Message
Add support for WebCrypto RSA-OAEP
https://bugs.webkit.org/show_bug.cgi?id=125084
Build fix.
* WebCore.xcodeproj/project.pbxproj: Fix an automatic merge failure by re-adding
CryptoAlgorithmRsaOaepParams.h.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (159948 => 159949)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 20:00:13 UTC (rev 159948)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 20:05:26 UTC (rev 159949)
@@ -1,3 +1,13 @@
+2013-12-02 Alexey Proskuryakov a...@apple.com
+
+Add support for WebCrypto RSA-OAEP
+https://bugs.webkit.org/show_bug.cgi?id=125084
+
+Build fix.
+
+* WebCore.xcodeproj/project.pbxproj: Fix an automatic merge failure by re-adding
+CryptoAlgorithmRsaOaepParams.h.
+
2013-12-02 Victor Jaquez vjaq...@igalia.com
[Gstreamer] update webkitvideosink metadata
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (159948 => 159949)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2013-12-02 20:00:13 UTC (rev 159948)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2013-12-02 20:05:26 UTC (rev 159949)
@@ -5730,10 +5730,10 @@
E1FE136718343A1000892F13 /* CryptoDigest.h in Headers */ = {isa = PBXBuildFile; fileRef = E1FE136618343A1000892F13 /* CryptoDigest.h */; };
E1FE136A183FE1AB00892F13 /* CryptoAlgorithmRSA_OAEP.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1FE1368183FE1AB00892F13 /* CryptoAlgorithmRSA_OAEP.cpp */; };
E1FE136B183FE1AB00892F13 /* CryptoAlgorithmRSA_OAEP.h in Headers */ = {isa = PBXBuildFile; fileRef = E1FE1369183FE1AB00892F13 /* CryptoAlgorithmRSA_OAEP.h */; };
- E1FE136D183FE21D00892F13 /* CryptoAlgorithmRsaOaepParams.h in Headers */ = {isa = PBXBuildFile; fileRef = E1FE136C183FE21D00892F13 /* CryptoAlgorithmRsaOaepParams.h */; };
E1FE1370183FECF000892F13 /* CryptoAlgorithmRSA_OAEPMac.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1FE136E183FECF000892F13 /* CryptoAlgorithmRSA_OAEPMac.cpp */; };
E1FE137418402A6700892F13 /* CommonCryptoUtilities.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1FE137218402A6700892F13 /* CommonCryptoUtilities.cpp */; };
E1FE137518402A6700892F13 /* CommonCryptoUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = E1FE137318402A6700892F13 /* CommonCryptoUtilities.h */; };
+ E1FE1377184D1E3300892F13 /* CryptoAlgorithmRsaOaepParams.h in Headers */ = {isa = PBXBuildFile; fileRef = E1FE1376184D1E3300892F13 /* CryptoAlgorithmRsaOaepParams.h */; };
E1FF57A30F01255B00891EBB /* ThreadGlobalData.h in Headers */ = {isa = PBXBuildFile; fileRef = E1FF57A20F01255B00891EBB /* ThreadGlobalData.h */; settings = {ATTRIBUTES = (Private, ); }; };
E1FF57A60F01256B00891EBB /* ThreadGlobalData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1FF57A50F01256B00891EBB /* ThreadGlobalData.cpp */; };
E1FF8F5F1807442100132674 /* SubtleCrypto.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E1FF8F5D1807442100132674 /* SubtleCrypto.cpp */; };
@@ -12856,10 +12856,10 @@
E1FE136618343A1000892F13 /* CryptoDigest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CryptoDigest.h; sourceTree = group; };
E1FE1368183FE1AB00892F13 /* CryptoAlgorithmRSA_OAEP.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CryptoAlgorithmRSA_OAEP.cpp; sourceTree = group; };
E1FE1369183FE1AB00892F13 /* CryptoAlgorithmRSA_OAEP.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CryptoAlgorithmRSA_OAEP.h; sourceTree = group; };
- E1FE136C183FE21D00892F13 /* CryptoAlgorithmRsaOaepParams.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = CryptoAlgorithmRsaOaepParams.h; path = parameters/CryptoAlgorithmRsaOaepParams.h; sourceTree = group; };
E1FE136E183FECF000892F13 /* CryptoAlgorithmRSA_OAEPMac.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = CryptoAlgorithmRSA_OAEPMac.cpp; path = mac/CryptoAlgorithmRSA_OAEPMac.cpp; sourceTree = group; };
E1FE137218402A6700892F13 /* CommonCryptoUtilities.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CommonCryptoUtilities.cpp; sourceTree = group; };
E1FE137318402A6700892F13 /* CommonCryptoUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CommonCryptoUtilities.h; sourceTree = group; };
+ E1FE1376184D1E3300892F13 /* CryptoAlgorithmRsaOaepParams.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = CryptoAlgorithmRsaOaepParams.h; path = parameters/CryptoAlgorithmRsaOaepParams.h; sourceTree = group; };
[webkit-changes] [159950] trunk
Title: [159950] trunk
Revision 159950
Author commit-qu...@webkit.org
Date 2013-12-02 12:11:27 -0800 (Mon, 02 Dec 2013)
Log Message
Use GenericEventQueue in TrackListBase and reduce code duplication with scheduleTrackEvent()
https://bugs.webkit.org/show_bug.cgi?id=124811
Patch by Brendan Long b.l...@cablelabs.com on 2013-12-02
Reviewed by Eric Carlson.
Source/WebCore:
No new tests because this is just refactoring.
* html/track/TrackListBase.cpp:
(TrackListBase::TrackListBase): Replace event code with a GenericEventQueue.
(TrackListBase::scheduleTrackEvent): Factor out duplicate code in schedule{Add,Remove}TrackEvent functions.
(TrackListBase::scheduleAddTrackEvent): Same.
(TrackListBase::scheduleRemoveTrackEvent): Same.
(TrackListBase::scheduleChangeEvent): Use GenericEventQueue.
* html/track/TrackListBase.h: Replace event code with GenericEventQueue.
LayoutTests:
* platform/mac/TestExpectations: Unskip onremovetrack test which was fixed a long time ago.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/TrackListBase.cpp
trunk/Source/WebCore/html/track/TrackListBase.h
Diff
Modified: trunk/LayoutTests/ChangeLog (159949 => 159950)
--- trunk/LayoutTests/ChangeLog 2013-12-02 20:05:26 UTC (rev 159949)
+++ trunk/LayoutTests/ChangeLog 2013-12-02 20:11:27 UTC (rev 159950)
@@ -1,3 +1,12 @@
+2013-12-02 Brendan Long b.l...@cablelabs.com
+
+Use GenericEventQueue in TrackListBase and reduce code duplication with scheduleTrackEvent()
+https://bugs.webkit.org/show_bug.cgi?id=124811
+
+Reviewed by Eric Carlson.
+
+* platform/mac/TestExpectations: Unskip onremovetrack test which was fixed a long time ago.
+
2013-12-02 Alexey Proskuryakov a...@apple.com
Add support for WebCrypto RSA-OAEP
Modified: trunk/LayoutTests/platform/mac/TestExpectations (159949 => 159950)
--- trunk/LayoutTests/platform/mac/TestExpectations 2013-12-02 20:05:26 UTC (rev 159949)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2013-12-02 20:11:27 UTC (rev 159950)
@@ -375,7 +375,6 @@
webkit.org/b/103926 media/track/opera/interfaces/TextTrackCue/vertical.html [ Skip ]
webkit.org/b/103926 media/track/opera/interfaces/TextTrackCueList/getter.html [ Skip ]
webkit.org/b/103926 media/track/opera/interfaces/TextTrackList/getter.html [ Skip ]
-webkit.org/b/103926 media/track/opera/interfaces/TextTrackList/onremovetrack.html [ Skip ]
webkit.org/b/103926 media/track/opera/track/track-element/cloneNode.html [ Skip ]
webkit.org/b/103926 media/track/opera/track/track-element/src-clear-cues.html [ Skip ]
webkit.org/b/103926 media/track/opera/track/webvtt/parsing/001.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (159949 => 159950)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 20:05:26 UTC (rev 159949)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 20:11:27 UTC (rev 159950)
@@ -1,3 +1,20 @@
+2013-12-02 Brendan Long b.l...@cablelabs.com
+
+Use GenericEventQueue in TrackListBase and reduce code duplication with scheduleTrackEvent()
+https://bugs.webkit.org/show_bug.cgi?id=124811
+
+Reviewed by Eric Carlson.
+
+No new tests because this is just refactoring.
+
+* html/track/TrackListBase.cpp:
+(TrackListBase::TrackListBase): Replace event code with a GenericEventQueue.
+(TrackListBase::scheduleTrackEvent): Factor out duplicate code in schedule{Add,Remove}TrackEvent functions.
+(TrackListBase::scheduleAddTrackEvent): Same.
+(TrackListBase::scheduleRemoveTrackEvent): Same.
+(TrackListBase::scheduleChangeEvent): Use GenericEventQueue.
+* html/track/TrackListBase.h: Replace event code with GenericEventQueue.
+
2013-12-02 Alexey Proskuryakov a...@apple.com
Add support for WebCrypto RSA-OAEP
Modified: trunk/Source/WebCore/html/track/TrackListBase.cpp (159949 => 159950)
--- trunk/Source/WebCore/html/track/TrackListBase.cpp 2013-12-02 20:05:26 UTC (rev 159949)
+++ trunk/Source/WebCore/html/track/TrackListBase.cpp 2013-12-02 20:11:27 UTC (rev 159950)
@@ -39,8 +39,7 @@
TrackListBase::TrackListBase(HTMLMediaElement* element, ScriptExecutionContext* context)
: m_context(context)
, m_element(element)
-, m_pendingEventTimer(this, TrackListBase::asyncEventTimerFired)
-, m_dispatchingEvents(0)
+, m_asyncEventQueue(*this)
{
ASSERT(context-isDocument());
}
@@ -79,6 +78,16 @@
return m_inbandTracks.find(track) != notFound;
}
+void TrackListBase::scheduleTrackEvent(const AtomicString eventName, PassRefPtrTrackBase track)
+{
+TrackEventInit initializer;
+initializer.track = track;
+initializer.bubbles = false;
+initializer.cancelable = false;
+
+m_asyncEventQueue.enqueueEvent(TrackEvent::create(eventName, initializer));
+}
+
void TrackListBase::scheduleAddTrackEvent(PassRefPtrTrackBase track)
{
// 4.8.10.5 Loading the media
[webkit-changes] [159951] trunk/Source/WebCore
Title: [159951] trunk/Source/WebCore
Revision 159951
Author a...@apple.com
Date 2013-12-02 12:28:54 -0800 (Mon, 02 Dec 2013)
Log Message
Add support for WebCrypto RSA-OAEP
https://bugs.webkit.org/show_bug.cgi?id=125084
Build fix.
* crypto/CommonCryptoUtilities.h:
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
* crypto/mac/CryptoKeyRSAMac.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/crypto/CommonCryptoUtilities.h
trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp
trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (159950 => 159951)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 20:11:27 UTC (rev 159950)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 20:28:54 UTC (rev 159951)
@@ -1,3 +1,14 @@
+2013-12-02 Alexey Proskuryakov a...@apple.com
+
+Add support for WebCrypto RSA-OAEP
+https://bugs.webkit.org/show_bug.cgi?id=125084
+
+Build fix.
+
+* crypto/CommonCryptoUtilities.h:
+* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
+* crypto/mac/CryptoKeyRSAMac.cpp:
+
2013-12-02 Brendan Long b.l...@cablelabs.com
Use GenericEventQueue in TrackListBase and reduce code duplication with scheduleTrackEvent()
Modified: trunk/Source/WebCore/crypto/CommonCryptoUtilities.h (159950 => 159951)
--- trunk/Source/WebCore/crypto/CommonCryptoUtilities.h 2013-12-02 20:11:27 UTC (rev 159950)
+++ trunk/Source/WebCore/crypto/CommonCryptoUtilities.h 2013-12-02 20:28:54 UTC (rev 159951)
@@ -30,6 +30,8 @@
#include CryptoAlgorithmIdentifier.h
+#include CommonCrypto/CommonCryptor.h
+
#if defined(__has_include)
#if __has_include(CommonCrypto/CommonRSACryptor.h)
#include CommonCrypto/CommonRSACryptor.h
@@ -73,6 +75,7 @@
extern const CCRandomRef kCCRandomDefault;
extern C int CCRandomCopyBytes(CCRandomRef rnd, void *bytes, size_t count);
+typedef struct _CCRSACryptor *CCRSACryptorRef;
extern C CCCryptorStatus CCRSACryptorEncrypt(CCRSACryptorRef publicKey, CCAsymmetricPadding padding, const void *plainText, size_t plainTextLen, void *cipherText, size_t *cipherTextLen, const void *tagData, size_t tagDataLen, CCDigestAlgorithm digestType);
extern C CCCryptorStatus CCRSACryptorDecrypt(CCRSACryptorRef privateKey, CCAsymmetricPadding padding, const void *cipherText, size_t cipherTextLen, void *plainText, size_t *plainTextLen, const void *tagData, size_t tagDataLen, CCDigestAlgorithm digestType);
extern C CCCryptorStatus CCRSACryptorSign(CCRSACryptorRef privateKey, CCAsymmetricPadding padding, const void *hashToSign, size_t hashSignLen, CCDigestAlgorithm digestType, size_t saltLen, void *signedData, size_t *signedDataLen);
Modified: trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp (159950 => 159951)
--- trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp 2013-12-02 20:11:27 UTC (rev 159950)
+++ trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp 2013-12-02 20:28:54 UTC (rev 159951)
@@ -33,7 +33,6 @@
#include CryptoDigest.h
#include CryptoKeyRSA.h
#include ExceptionCode.h
-#include CommonCrypto/CommonCryptor.h
namespace WebCore {
Modified: trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp (159950 => 159951)
--- trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2013-12-02 20:11:27 UTC (rev 159950)
+++ trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2013-12-02 20:28:54 UTC (rev 159951)
@@ -33,7 +33,6 @@
#include CryptoAlgorithmRegistry.h
#include CryptoKeyDataRSAComponents.h
#include CryptoKeyPair.h
-#include CommonCrypto/CommonCryptor.h
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159952] trunk/Source/WebInspectorUI
Title: [159952] trunk/Source/WebInspectorUI
Revision 159952
Author grao...@apple.com
Date 2013-12-02 12:40:58 -0800 (Mon, 02 Dec 2013)
Log Message
Web Inspector: popover can overlap target frame
https://bugs.webkit.org/show_bug.cgi?id=125069
Reviewed by Joseph Pecoraro.
Fix a regression introduced in http://trac.webkit.org/changeset/159286. We should only
offset the frame of the popover in the y-axis if the target edge is on the x-axis, and
vice versa. We also remove the needsToDrawBackground check since it incorrectly disregarded
the anchor point. We now always draw the background which is a lot safer and guarantees
we'll always draw an adequate frame and anchor point.
* UserInterface/Popover.js:
(WebInspector.Popover.prototype._update):
(WebInspector.Popover.prototype._bestMetricsForEdge):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Popover.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (159951 => 159952)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-12-02 20:28:54 UTC (rev 159951)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-12-02 20:40:58 UTC (rev 159952)
@@ -1,5 +1,22 @@
2013-12-02 Antoine Quint grao...@apple.com
+Web Inspector: popover can overlap target frame
+https://bugs.webkit.org/show_bug.cgi?id=125069
+
+Reviewed by Joseph Pecoraro.
+
+Fix a regression introduced in http://trac.webkit.org/changeset/159286. We should only
+offset the frame of the popover in the y-axis if the target edge is on the x-axis, and
+vice versa. We also remove the needsToDrawBackground check since it incorrectly disregarded
+the anchor point. We now always draw the background which is a lot safer and guarantees
+we'll always draw an adequate frame and anchor point.
+
+* UserInterface/Popover.js:
+(WebInspector.Popover.prototype._update):
+(WebInspector.Popover.prototype._bestMetricsForEdge):
+
+2013-12-02 Antoine Quint grao...@apple.com
+
Web Inspector: add a method to add padding around a WebInspector.Rect
https://bugs.webkit.org/show_bug.cgi?id=125072
Modified: trunk/Source/WebInspectorUI/UserInterface/Popover.js (159951 => 159952)
--- trunk/Source/WebInspectorUI/UserInterface/Popover.js 2013-12-02 20:28:54 UTC (rev 159951)
+++ trunk/Source/WebInspectorUI/UserInterface/Popover.js 2013-12-02 20:40:58 UTC (rev 159952)
@@ -232,8 +232,6 @@
var anchorPoint;
var bestFrame = bestMetrics.frame;
-var needsToDrawBackground = !this._frame.size.equals(bestFrame.size) || this._edge !== bestEdge;
-
this.frame = bestFrame;
this._edge = bestEdge;
@@ -258,8 +256,7 @@
this._element.classList.add(this._cssClassNameForEdge());
-if (needsToDrawBackground)
-this._drawBackground(bestEdge, anchorPoint);
+this._drawBackground(bestEdge, anchorPoint);
// Make sure content is centered in case either of the dimension is smaller than the minimal bounds.
if (this._preferredSize.width WebInspector.Popover.MinWidth || this._preferredSize.height WebInspector.Popover.MinHeight)
@@ -394,14 +391,17 @@
break;
}
-if (x containerFrame.minX())
-x = containerFrame.minX();
-if (y containerFrame.minY())
-y = containerFrame.minY();
-if (x + width containerFrame.maxX())
-x += containerFrame.maxX() - (x + width);
-if (y + height containerFrame.maxY())
-y += containerFrame.maxY() - (y + height);
+if (edge === WebInspector.RectEdge.MIN_X || edge === WebInspector.RectEdge.MAX_X) {
+if (y containerFrame.minY())
+y = containerFrame.minY();
+if (y + height containerFrame.maxY())
+y = containerFrame.maxY() - height;
+} else {
+if (x containerFrame.minX())
+x = containerFrame.minX();
+if (x + width containerFrame.maxX())
+x = containerFrame.maxX() - width;
+}
var preferredFrame = new WebInspector.Rect(x, y, width, height);
var bestFrame = preferredFrame.intersectionWithRect(containerFrame);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159953] branches/safari-537.60-branch/Source/WebKit
Title: [159953] branches/safari-537.60-branch/Source/WebKit Revision 159953 Author bfulg...@apple.com Date 2013-12-02 12:44:17 -0800 (Mon, 02 Dec 2013) Log Message Merge r159941. 2013-12-02 Brent Fulgham bfulg...@apple.com [Win] WebKit Project doesn't copy resource bundle https://bugs.webkit.org/show_bug.cgi?id=125078 Reviewed by Jer Noble. * WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Modified Paths branches/safari-537.60-branch/Source/WebKit/ChangeLog branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKitPostBuild.cmd Diff Modified: branches/safari-537.60-branch/Source/WebKit/ChangeLog (159952 => 159953) --- branches/safari-537.60-branch/Source/WebKit/ChangeLog 2013-12-02 20:40:58 UTC (rev 159952) +++ branches/safari-537.60-branch/Source/WebKit/ChangeLog 2013-12-02 20:44:17 UTC (rev 159953) @@ -1,3 +1,16 @@ +2013-12-02 Brent Fulgham bfulg...@apple.com + +Merge r159941. + +2013-12-02 Brent Fulgham bfulg...@apple.com + +[Win] WebKit Project doesn't copy resource bundle +https://bugs.webkit.org/show_bug.cgi?id=125078 + +Reviewed by Jer Noble. + +* WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: + 2013-11-07 Roger Fong roger_f...@apple.com Unreviewed. Windows WebKit makefile fixes. Modified: branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKitPostBuild.cmd (159952 => 159953) --- branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKitPostBuild.cmd 2013-12-02 20:40:58 UTC (rev 159952) +++ branches/safari-537.60-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKitPostBuild.cmd 2013-12-02 20:44:17 UTC (rev 159953) @@ -1,16 +1,22 @@ -mkdir 2NUL %CONFIGURATIONBUILDDIR%\include\WebKit - -xcopy /y /d %PROJECTDIR%\..\..\win\WebLocalizableStrings.h %CONFIGURATIONBUILDDIR%\include\WebKit -xcopy /y /d %PROJECTDIR%\..\..\win\WebKitGraphics.h %CONFIGURATIONBUILDDIR%\include\WebKit -xcopy /y /d %PROJECTDIR%\..\..\win\WebKitCOMAPI.h %CONFIGURATIONBUILDDIR%\include\WebKit -xcopy /y /d %PROJECTDIR%\..\..\win\WebPreferenceKeysPrivate.h %CONFIGURATIONBUILDDIR%\include\WebKit - -xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\npapi.h %CONFIGURATIONBUILDDIR%\include\WebKit -xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\npfunctions.h %CONFIGURATIONBUILDDIR%\include\WebKit -xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\npruntime.h %CONFIGURATIONBUILDDIR%\include\WebKit -xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\npruntime_internal.h %CONFIGURATIONBUILDDIR%\include\WebKit -xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\nptypes.h %CONFIGURATIONBUILDDIR%\include\WebKit - -if exist %WEBKIT_LIBRARIES%\tools\VersionStamper\VersionStamper.exe %WEBKIT_LIBRARIES%\tools\VersionStamper\VersionStamper.exe --verbose %TARGETPATH% - -if exist %CONFIGURATIONBUILDDIR%\buildfailed del %CONFIGURATIONBUILDDIR%\buildfailed +mkdir 2NUL %CONFIGURATIONBUILDDIR%\include\WebKit + +set ResourcesDirectory=%CONFIGURATIONBUILDDIR%\bin32\WebKit.resources + +xcopy /y /d %PROJECTDIR%\..\..\win\WebLocalizableStrings.h %CONFIGURATIONBUILDDIR%\include\WebKit +xcopy /y /d %PROJECTDIR%\..\..\win\WebKitGraphics.h %CONFIGURATIONBUILDDIR%\include\WebKit +xcopy /y /d %PROJECTDIR%\..\..\win\WebKitCOMAPI.h %CONFIGURATIONBUILDDIR%\include\WebKit +xcopy /y /d %PROJECTDIR%\..\..\win\WebPreferenceKeysPrivate.h %CONFIGURATIONBUILDDIR%\include\WebKit + +xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\npapi.h %CONFIGURATIONBUILDDIR%\include\WebKit +xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\npfunctions.h %CONFIGURATIONBUILDDIR%\include\WebKit +xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\npruntime.h %CONFIGURATIONBUILDDIR%\include\WebKit +xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\npruntime_internal.h %CONFIGURATIONBUILDDIR%\include\WebKit +xcopy /y /d %CONFIGURATIONBUILDDIR%\include\WebCore\nptypes.h %CONFIGURATIONBUILDDIR%\include\WebKit + +echo Copying resources... +mkdir %ResourcesDirectory% 2NUL +xcopy /y /d %PROJECTDIR%\..\..\win\WebKit.resources\* %ResourcesDirectory% NUL + +if exist %WEBKIT_LIBRARIES%\tools\VersionStamper\VersionStamper.exe %WEBKIT_LIBRARIES%\tools\VersionStamper\VersionStamper.exe --verbose %TARGETPATH% + +if exist %CONFIGURATIONBUILDDIR%\buildfailed del %CONFIGURATIONBUILDDIR%\buildfailed ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159955] trunk/Tools
Title: [159955] trunk/Tools
Revision 159955
Author mhahnenb...@apple.com
Date 2013-12-02 12:55:28 -0800 (Mon, 02 Dec 2013)
Log Message
run-jsc-stress-tests should be able to package its tests and move them places
https://bugs.webkit.org/show_bug.cgi?id=124549
Reviewed by Filip Pizlo.
* Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
of grep -i -q
* Scripts/run-_javascript_core-tests: Pass through the --tarball flag.
* Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
We now also copy whatever VM was specified, along with its associated framework, into this directory.
All of the generated scripts now are completely relative within the results directory. This allows
run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
tarball of the generated results directory. Also refactored several portions of the script into
separate functions to make it easier to run them conditionally depending on which mode we're running in.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
trunk/Tools/Scripts/run-jsc-stress-tests
Removed Paths
trunk/Tools/Scripts/jsc-stress-test-helpers/check-mozilla-failure
Diff
Modified: trunk/Tools/ChangeLog (159954 => 159955)
--- trunk/Tools/ChangeLog 2013-12-02 20:52:11 UTC (rev 159954)
+++ trunk/Tools/ChangeLog 2013-12-02 20:55:28 UTC (rev 159955)
@@ -1,3 +1,20 @@
+2013-12-02 Mark Hahnenberg mhahnenb...@apple.com
+
+run-jsc-stress-tests should be able to package its tests and move them places
+https://bugs.webkit.org/show_bug.cgi?id=124549
+
+Reviewed by Filip Pizlo.
+
+* Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
+of grep -i -q
+* Scripts/run-_javascript_core-tests: Pass through the --tarball flag.
+* Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
+We now also copy whatever VM was specified, along with its associated framework, into this directory.
+All of the generated scripts now are completely relative within the results directory. This allows
+run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
+tarball of the generated results directory. Also refactored several portions of the script into
+separate functions to make it easier to run them conditionally depending on which mode we're running in.
+
2013-12-02 Andrzej Badowski a.badow...@samsung.com
[ATK] Support active state for listbox elements.
Deleted: trunk/Tools/Scripts/jsc-stress-test-helpers/check-mozilla-failure (159954 => 159955)
--- trunk/Tools/Scripts/jsc-stress-test-helpers/check-mozilla-failure 2013-12-02 20:52:11 UTC (rev 159954)
+++ trunk/Tools/Scripts/jsc-stress-test-helpers/check-mozilla-failure 2013-12-02 20:55:28 UTC (rev 159955)
@@ -1,34 +0,0 @@
-#!/usr/bin/env ruby
-
-# Copyright (C) 2013 Apple Inc. All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-#
-# 1. Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# 2. Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY
-# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
-# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
-# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
-# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-File.open(ARGV[0], r) {
-| inp |
-inp.each_line {
-| line |
-exit 0 if line =~ /failed!/i
-}
-}
-
-exit 1
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (159954 => 159955)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2013-12-02 20:52:11 UTC (rev 159954)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2013-12-02 20:55:28 UTC (rev 159955)
@@ -79,6 +79,8 @@
my $enableFTL = 0;
+my $createTarball = 0;
+
my $programName = basename($0);
my $buildJSCDefault = $buildJSC ? will check : will not check;
my $testapiDefault = $runTestAPI ?
[webkit-changes] [159956] trunk/Source/WebKit2
Title: [159956] trunk/Source/WebKit2
Revision 159956
Author timothy_hor...@apple.com
Date 2013-12-02 12:56:13 -0800 (Mon, 02 Dec 2013)
Log Message
Remote Layer Tree: Hook up setLayerTreeStateIsFrozen
https://bugs.webkit.org/show_bug.cgi?id=124872
Reviewed by Brent Fulgham.
setLayerTreeStateIsFrozen is the mechanism used to ensure that
layer property changes (including new backing store) aren't committed
while e.g. the page is reconfigured for printing.
* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::flushLayers):
(WebKit::RemoteLayerTreeContext::setIsFlushingSuspended):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159955 => 159956)
--- trunk/Source/WebKit2/ChangeLog 2013-12-02 20:55:28 UTC (rev 159955)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-02 20:56:13 UTC (rev 159956)
@@ -1,5 +1,25 @@
2013-12-02 Tim Horton timothy_hor...@apple.com
+Remote Layer Tree: Hook up setLayerTreeStateIsFrozen
+https://bugs.webkit.org/show_bug.cgi?id=124872
+
+Reviewed by Brent Fulgham.
+
+setLayerTreeStateIsFrozen is the mechanism used to ensure that
+layer property changes (including new backing store) aren't committed
+while e.g. the page is reconfigured for printing.
+
+* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
+* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
+(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
+(WebKit::RemoteLayerTreeContext::flushLayers):
+(WebKit::RemoteLayerTreeContext::setIsFlushingSuspended):
+* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
+* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
+(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
+
+2013-12-02 Tim Horton timothy_hor...@apple.com
+
Remote Layer Tree: Disable direct image compositing
https://bugs.webkit.org/show_bug.cgi?id=124875
rdar://problem/15446024
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.h (159955 => 159956)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.h 2013-12-02 20:55:28 UTC (rev 159955)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.h 2013-12-02 20:56:13 UTC (rev 159956)
@@ -56,6 +56,8 @@
LayerHostingMode layerHostingMode() const { return m_webPage-layerHostingMode(); }
+void setIsFlushingSuspended(bool);
+
private:
// WebCore::GraphicsLayerFactory
virtual std::unique_ptrWebCore::GraphicsLayer createGraphicsLayer(WebCore::GraphicsLayerClient*) OVERRIDE;
@@ -71,6 +73,9 @@
VectorRemoteLayerTreeTransaction::LayerCreationProperties m_createdLayers;
VectorRemoteLayerTreeTransaction::LayerID m_destroyedLayers;
+
+bool m_isFlushingSuspended;
+bool m_hasDeferredFlush;
};
} // namespace WebKit
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm (159955 => 159956)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm 2013-12-02 20:55:28 UTC (rev 159955)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm 2013-12-02 20:56:13 UTC (rev 159956)
@@ -43,6 +43,8 @@
RemoteLayerTreeContext::RemoteLayerTreeContext(WebPage* webPage)
: m_webPage(webPage)
, m_layerFlushTimer(this, RemoteLayerTreeContext::layerFlushTimerFired)
+, m_isFlushingSuspended(false)
+, m_hasDeferredFlush(false)
{
}
@@ -114,6 +116,11 @@
if (!m_rootLayer)
return;
+if (m_isFlushingSuspended) {
+m_hasDeferredFlush = true;
+return;
+}
+
RemoteLayerTreeTransaction transaction;
transaction.setRootLayerID(m_rootLayer-layerID());
@@ -131,4 +138,17 @@
m_webPage-send(Messages::RemoteLayerTreeHost::Commit(transaction));
}
+void RemoteLayerTreeContext::setIsFlushingSuspended(bool isFrozen)
+{
+if (m_isFlushingSuspended == isFrozen)
+return;
+
+m_isFlushingSuspended = isFrozen;
+
+if (!m_isFlushingSuspended m_hasDeferredFlush) {
+m_hasDeferredFlush = false;
+scheduleLayerFlush();
+}
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h (159955 => 159956)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h 2013-12-02 20:55:28 UTC
[webkit-changes] [159957] trunk/Tools
Title: [159957] trunk/Tools
Revision 159957
Author mhahnenb...@apple.com
Date 2013-12-02 13:15:47 -0800 (Mon, 02 Dec 2013)
Log Message
Build fix after r159955
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (159956 => 159957)
--- trunk/Tools/ChangeLog 2013-12-02 20:56:13 UTC (rev 159956)
+++ trunk/Tools/ChangeLog 2013-12-02 21:15:47 UTC (rev 159957)
@@ -1,5 +1,11 @@
2013-12-02 Mark Hahnenberg mhahnenb...@apple.com
+Build fix after r159955
+
+* Scripts/run-jsc-stress-tests:
+
+2013-12-02 Mark Hahnenberg mhahnenb...@apple.com
+
run-jsc-stress-tests should be able to package its tests and move them places
https://bugs.webkit.org/show_bug.cgi?id=124549
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (159956 => 159957)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2013-12-02 20:56:13 UTC (rev 159956)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2013-12-02 21:15:47 UTC (rev 159957)
@@ -166,7 +166,7 @@
$jscPath = $frameworkPath + Resources + jsc
if frameworkPath
-FileUtils.cp_r frameworkPath, vmDir
+FileUtils.cp_r frameworkPath, $outputDir + .vm
else
Dir.chdir($outputDir) {
FileUtils.mkdir_p $jscPath.dirname
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159958] trunk/Source/WebCore
Title: [159958] trunk/Source/WebCore
Revision 159958
Author commit-qu...@webkit.org
Date 2013-12-02 13:41:18 -0800 (Mon, 02 Dec 2013)
Log Message
[MediaStream] Use iterator-based loops instead of index-based loops
https://bugs.webkit.org/show_bug.cgi?id=125021
Patch by Roger Zanoni rogerzan...@gmail.com on 2013-12-02
Reviewed by Eric Carlson.
Also, changing iterator variable names from iter to it and
initializing an 'end' variable in each loop instead of evaluating
'collection.end()' multiple times.
No new tests, covered by existing ones.
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::trackDidEnd):
(WebCore::MediaStream::scheduledEventTimerFired):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (159957 => 159958)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 21:15:47 UTC (rev 159957)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 21:41:18 UTC (rev 159958)
@@ -1,3 +1,23 @@
+2013-12-02 Roger Zanoni rogerzan...@gmail.com
+
+[MediaStream] Use iterator-based loops instead of index-based loops
+https://bugs.webkit.org/show_bug.cgi?id=125021
+
+Reviewed by Eric Carlson.
+
+Also, changing iterator variable names from iter to it and
+initializing an 'end' variable in each loop instead of evaluating
+'collection.end()' multiple times.
+
+No new tests, covered by existing ones.
+
+* Modules/mediastream/MediaStream.cpp:
+(WebCore::MediaStream::cloneMediaStreamTrackVector):
+(WebCore::MediaStream::haveTrackWithSource):
+(WebCore::MediaStream::getTrackById):
+(WebCore::MediaStream::trackDidEnd):
+(WebCore::MediaStream::scheduledEventTimerFired):
+
2013-12-02 Rob Buis rob.b...@samsung.com
[css shapes] Parse new ellipse shape syntax
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp (159957 => 159958)
--- trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp 2013-12-02 21:15:47 UTC (rev 159957)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp 2013-12-02 21:41:18 UTC (rev 159958)
@@ -137,8 +137,8 @@
void MediaStream::cloneMediaStreamTrackVector(VectorRefPtrMediaStreamTrack destination, const VectorRefPtrMediaStreamTrack source)
{
-for (unsigned i = 0; i source.size(); i++)
-destination.append(source[i]-clone());
+for (auto it = source.begin(), end = source.end(); it != end; ++it)
+destination.append((*it)-clone());
}
void MediaStream::addTrack(PassRefPtrMediaStreamTrack prpTrack, ExceptionCode ec)
@@ -217,15 +217,15 @@
bool MediaStream::haveTrackWithSource(PassRefPtrMediaStreamSource source)
{
if (source-type() == MediaStreamSource::Audio) {
-for (auto iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) {
-if ((*iter)-source() == source.get())
+for (auto it = m_audioTracks.begin(), end = m_audioTracks.end(); it != end; ++it) {
+if ((*it)-source() == source.get())
return true;
}
return false;
}
-for (auto iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) {
-if ((*iter)-source() == source.get())
+for (auto it = m_videoTracks.begin(), end = m_videoTracks.end(); it != end; ++it) {
+if ((*it)-source() == source.get())
return true;
}
@@ -234,14 +234,14 @@
MediaStreamTrack* MediaStream::getTrackById(String id)
{
-for (auto iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) {
-if ((*iter)-id() == id)
-return (*iter).get();
+for (auto it = m_audioTracks.begin(), end = m_audioTracks.end(); it != end; ++it) {
+if ((*it)-id() == id)
+return (*it).get();
}
-for (auto iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) {
-if ((*iter)-id() == id)
-return (*iter).get();
+for (auto it = m_videoTracks.begin(), end = m_videoTracks.end(); it != end; ++it) {
+if ((*it)-id() == id)
+return (*it).get();
}
return nullptr;
@@ -249,14 +249,15 @@
void MediaStream::trackDidEnd()
{
-for (size_t i = 0; i m_audioTracks.size(); ++i)
-if (!m_audioTracks[i]-ended())
+for (auto it = m_audioTracks.begin(), end = m_audioTracks.end(); it != end; ++it) {
+if (!(*it)-ended())
return;
-
-for (size_t i = 0; i m_videoTracks.size(); ++i)
-if (!m_videoTracks[i]-ended())
+}
+for (auto it = m_videoTracks.begin(), end = m_videoTracks.end(); it != end; ++it) {
+if (!(*it)-ended())
return;
-
+}
+
setEnded();
}
@@ -351,8 +352,7 @@
VectorRefPtrEvent events;
events.swap(m_scheduledEvents);
-
[webkit-changes] [159959] tags/Safari-537.60.8/
Title: [159959] tags/Safari-537.60.8/ Revision 159959 Author bshaf...@apple.com Date 2013-12-02 13:44:07 -0800 (Mon, 02 Dec 2013) Log Message New tag. Added Paths tags/Safari-537.60.8/ Diff Property changes: tags/Safari-537.60.8 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159960] trunk/Source
Title: [159960] trunk/Source
Revision 159960
Author bda...@apple.com
Date 2013-12-02 13:53:17 -0800 (Mon, 02 Dec 2013)
Log Message
Add a setting to opt into a mode where the background extends and fixed elements
don't move on rubber-band
https://bugs.webkit.org/show_bug.cgi?id=124745
Reviewed by Tim Horton.
Source/WebCore:
New setting backgroundShouldExtendBeyondPage() will cause the tile cache to have a
margin, and it will also cause fixed elements and backgrounds to stick to the
viewport on scroll instead of sticking to the document.
* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::scrollBehaviorForFixedElements):
* page/Settings.in:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
Source/WebKit:
Keep Windows happy.
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit2:
Add SPI to enable the new setting.
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetBackgroundShouldExtendBeyondPage):
(WKPreferencesGetBackgroundShouldExtendBeyondPage):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (159959 => 159960)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 21:44:07 UTC (rev 159959)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 21:53:17 UTC (rev 159960)
@@ -1,3 +1,22 @@
+2013-12-02 Beth Dakin bda...@apple.com
+
+Add a setting to opt into a mode where the background extends and fixed elements
+don't move on rubber-band
+https://bugs.webkit.org/show_bug.cgi?id=124745
+
+Reviewed by Tim Horton.
+
+New setting backgroundShouldExtendBeyondPage() will cause the tile cache to have a
+margin, and it will also cause fixed elements and backgrounds to stick to the
+viewport on scroll instead of sticking to the document.
+
+* WebCore.exp.in:
+* page/FrameView.cpp:
+(WebCore::FrameView::scrollBehaviorForFixedElements):
+* page/Settings.in:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::RenderLayerBacking):
+
2013-12-02 Roger Zanoni rogerzan...@gmail.com
[MediaStream] Use iterator-based loops instead of index-based loops
Modified: trunk/Source/WebCore/page/FrameView.cpp (159959 => 159960)
--- trunk/Source/WebCore/page/FrameView.cpp 2013-12-02 21:44:07 UTC (rev 159959)
+++ trunk/Source/WebCore/page/FrameView.cpp 2013-12-02 21:53:17 UTC (rev 159960)
@@ -4178,8 +4178,7 @@
ScrollBehaviorForFixedElements FrameView::scrollBehaviorForFixedElements() const
{
-// FIXME: Implement. This should consult a setting that does not yet exist.
-return StickToDocumentBounds;
+return frame().settings().backgroundShouldExtendBeyondPage() ? StickToViewportBounds : StickToDocumentBounds;
}
RenderView* FrameView::renderView() const
Modified: trunk/Source/WebCore/page/Settings.in (159959 => 159960)
--- trunk/Source/WebCore/page/Settings.in 2013-12-02 21:44:07 UTC (rev 159959)
+++ trunk/Source/WebCore/page/Settings.in 2013-12-02 21:53:17 UTC (rev 159960)
@@ -212,3 +212,5 @@
simpleLineLayoutEnabled initial=true, setNeedsStyleRecalcInAllFrames=1
simpleLineLayoutDebugBordersEnabled initial=false, setNeedsStyleRecalcInAllFrames=1
+
+backgroundShouldExtendBeyondPage initial=false
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (159959 => 159960)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2013-12-02 21:44:07 UTC (rev 159959)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2013-12-02 21:53:17 UTC (rev 159960)
@@ -136,8 +136,11 @@
tiledBacking-setIsInWindow(page-isInWindow());
-if (m_isMainFrameRenderViewLayer)
+if (m_isMainFrameRenderViewLayer) {
tiledBacking-setUnparentsOffscreenTiles(true);
+if (page-settings().backgroundShouldExtendBeyondPage())
+tiledBacking-setTileMargins(512, 512, 512, 512);
+}
tiledBacking-setScrollingPerformanceLoggingEnabled(page-settings().scrollingPerformanceLoggingEnabled());
adjustTiledBackingCoverage();
Modified: trunk/Source/WebKit/ChangeLog (159959 => 159960)
--- trunk/Source/WebKit/ChangeLog 2013-12-02 21:44:07 UTC (rev 159959)
+++ trunk/Source/WebKit/ChangeLog 2013-12-02 21:53:17 UTC (rev 159960)
@@ -1,3 +1,15 @@
+2013-12-02 Beth
[webkit-changes] [159961] trunk/Tools
Title: [159961] trunk/Tools
Revision 159961
Author bfulg...@apple.com
Date 2013-12-02 14:21:41 -0800 (Mon, 02 Dec 2013)
Log Message
[Win] Port run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=124801
Reviewed by Filip Pizlo.
* Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
command on Windows so that stress tests can run.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (159960 => 159961)
--- trunk/Tools/ChangeLog 2013-12-02 21:53:17 UTC (rev 159960)
+++ trunk/Tools/ChangeLog 2013-12-02 22:21:41 UTC (rev 159961)
@@ -1,3 +1,13 @@
+2013-12-02 Brent Fulgham bfulg...@apple.com
+
+[Win] Port run-jsc-stress-tests
+https://bugs.webkit.org/show_bug.cgi?id=124801
+
+Reviewed by Filip Pizlo.
+
+* Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
+command on Windows so that stress tests can run.
+
2013-12-02 Mark Hahnenberg mhahnenb...@apple.com
Build fix after r159955
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (159960 => 159961)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2013-12-02 21:53:17 UTC (rev 159960)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2013-12-02 22:21:41 UTC (rev 159961)
@@ -72,7 +72,12 @@
raise Command failed: #{$?.inspect} unless system(*cmd)
end
-$numProcessors = `sysctl -n hw.activecpu`.to_i
+begin
+$numProcessors = `sysctl -n hw.activecpu`.to_i
+rescue
+$numProcessors = 0
+end
+
if $numProcessors == 0
$numProcessors = `nproc --all 2/dev/null`.to_i
end
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159962] branches/safari-537.60-branch/Source
Title: [159962] branches/safari-537.60-branch/Source Revision 159962 Author bshaf...@apple.com Date 2013-12-02 14:25:02 -0800 (Mon, 02 Dec 2013) Log Message Versioning. Modified Paths branches/safari-537.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-537.60-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-537.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-537.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-537.60-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-537.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig (159961 => 159962) --- branches/safari-537.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2013-12-02 22:21:41 UTC (rev 159961) +++ branches/safari-537.60-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2013-12-02 22:25:02 UTC (rev 159962) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 60; -TINY_VERSION = 8; +TINY_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.60-branch/Source/WebCore/Configurations/Version.xcconfig (159961 => 159962) --- branches/safari-537.60-branch/Source/WebCore/Configurations/Version.xcconfig 2013-12-02 22:21:41 UTC (rev 159961) +++ branches/safari-537.60-branch/Source/WebCore/Configurations/Version.xcconfig 2013-12-02 22:25:02 UTC (rev 159962) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 60; -TINY_VERSION = 8; +TINY_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (159961 => 159962) --- branches/safari-537.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2013-12-02 22:21:41 UTC (rev 159961) +++ branches/safari-537.60-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2013-12-02 22:25:02 UTC (rev 159962) @@ -1,6 +1,6 @@ MAJOR_VERSION = 537; MINOR_VERSION = 60; -TINY_VERSION = 8; +TINY_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-537.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig (159961 => 159962) --- branches/safari-537.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2013-12-02 22:21:41 UTC (rev 159961) +++ branches/safari-537.60-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2013-12-02 22:25:02 UTC (rev 159962) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 60; -TINY_VERSION = 8; +TINY_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.60-branch/Source/WebKit2/Configurations/Version.xcconfig (159961 => 159962) --- branches/safari-537.60-branch/Source/WebKit2/Configurations/Version.xcconfig 2013-12-02 22:21:41 UTC (rev 159961) +++ branches/safari-537.60-branch/Source/WebKit2/Configurations/Version.xcconfig 2013-12-02 22:25:02 UTC (rev 159962) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 60; -TINY_VERSION = 8; +TINY_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159963] trunk/Source/WebKit
Title: [159963] trunk/Source/WebKit Revision 159963 Author bda...@apple.com Date 2013-12-02 14:31:59 -0800 (Mon, 02 Dec 2013) Log Message Attempted build fix. I think this is no longer needed. * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in Diff Modified: trunk/Source/WebKit/ChangeLog (159962 => 159963) --- trunk/Source/WebKit/ChangeLog 2013-12-02 22:25:02 UTC (rev 159962) +++ trunk/Source/WebKit/ChangeLog 2013-12-02 22:31:59 UTC (rev 159963) @@ -1,5 +1,11 @@ 2013-12-02 Beth Dakin bda...@apple.com +Attempted build fix. I think this is no longer needed. + +* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: + +2013-12-02 Beth Dakin bda...@apple.com + Add a setting to opt into a mode where the background extends and fixed elements don't move on rubber-band https://bugs.webkit.org/show_bug.cgi?id=124745 Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in (159962 => 159963) --- trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in 2013-12-02 22:25:02 UTC (rev 159962) +++ trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in 2013-12-02 22:31:59 UTC (rev 159963) @@ -456,7 +456,6 @@ symbolWithPointer(?cursiveFontFamily@Settings@WebCore@@QBEABVAtomicString@WTF@@W4UScriptCode@@@Z, ?cursiveFontFamily@Settings@WebCore@@QEBAAEBVAtomicString@WTF@@W4UScriptCode@@@Z) symbolWithPointer(?setSimpleLineLayoutEnabled@Settings@WebCore@@QAEX_N@Z, ?setSimpleLineLayoutEnabled@Settings@WebCore@@QEAAX_N@Z) symbolWithPointer(?setSimpleLineLayoutDebugBordersEnabled@Settings@WebCore@@QAEX_N@Z, ?setSimpleLineLayoutDebugBordersEnabled@Settings@WebCore@@QEAAX_N@Z) -symbolWithPointer(?setBackgroundShouldExtendBeyondPage@Settings@WebCore@@QAEX_N@Z, ?setBackgroundShouldExtendBeyondPage@Settings@WebCore@@QEAAX_N@Z) symbolWithPointer(?storeUpdatedQuotaForOrigin@ApplicationCacheStorage@WebCore@@QAE_NPBVSecurityOrigin@2@_J@Z, ?storeUpdatedQuotaForOrigin@ApplicationCacheStorage@WebCore@@QEAA_NPEBVSecurityOrigin@2@_J@Z) symbolWithPointer(?cacheStorage@WebCore@@YAAAVApplicationCacheStorage@1@XZ, ?cacheStorage@WebCore@@YAAEAVApplicationCacheStorage@1@XZ) symbolWithPointer(?setDefaultOriginQuota@ApplicationCacheStorage@WebCore@@QAEX_J@Z, ?setDefaultOriginQuota@ApplicationCacheStorage@WebCore@@QEAAX_J@Z) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159964] trunk/Tools
Title: [159964] trunk/Tools
Revision 159964
Author mhahnenb...@apple.com
Date 2013-12-02 14:33:31 -0800 (Mon, 02 Dec 2013)
Log Message
run-jsc-stress-tests always copies the VM
https://bugs.webkit.org/show_bug.cgi?id=125092
Reviewed by Filip Pizlo.
This can be slow, especially with full debug builds. It should just symlink the VM into the
bundle by default and do a full copy only when asked.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (159963 => 159964)
--- trunk/Tools/ChangeLog 2013-12-02 22:31:59 UTC (rev 159963)
+++ trunk/Tools/ChangeLog 2013-12-02 22:33:31 UTC (rev 159964)
@@ -1,3 +1,15 @@
+2013-12-02 Mark Hahnenberg mhahnenb...@apple.com
+
+run-jsc-stress-tests always copies the VM
+https://bugs.webkit.org/show_bug.cgi?id=125092
+
+Reviewed by Filip Pizlo.
+
+This can be slow, especially with full debug builds. It should just symlink the VM into the
+bundle by default and do a full copy only when asked.
+
+* Scripts/run-jsc-stress-tests:
+
2013-12-02 Brent Fulgham bfulg...@apple.com
[Win] Port run-jsc-stress-tests
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (159963 => 159964)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2013-12-02 22:31:59 UTC (rev 159963)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2013-12-02 22:33:31 UTC (rev 159964)
@@ -91,6 +91,7 @@
$verbosity = 0
$bundle = nil
$tarball = false
+$copyVM = false
def usage
puts run-jsc-stress-tests -j shell path collections path [collections path ...]
@@ -111,6 +112,7 @@
['--output-dir', '-o', GetoptLong::REQUIRED_ARGUMENT],
['--run-bundle', GetoptLong::REQUIRED_ARGUMENT],
['--tarball', GetoptLong::NO_ARGUMENT],
+ ['--force-vm-copy', GetoptLong::NO_ARGUMENT],
['--verbose', '-v', GetoptLong::NO_ARGUMENT]).each {
| opt, arg |
case opt
@@ -128,6 +130,9 @@
$bundle = Pathname.new(arg)
when '--tarball'
$tarball = true
+$copyVM = true
+when '--force-vm-copy'
+$copyVM = true
end
}
@@ -171,13 +176,28 @@
$jscPath = $frameworkPath + Resources + jsc
if frameworkPath
-FileUtils.cp_r frameworkPath, $outputDir + .vm
+source = frameworkPath
+destination = Pathname.new(.vm)
else
+source = jscPath
+destination = $jscPath
+
Dir.chdir($outputDir) {
FileUtils.mkdir_p $jscPath.dirname
-FileUtils.cp jscPath, $jscPath
}
end
+
+Dir.chdir($outputDir) {
+if $copyVM
+FileUtils.cp_r source, destination
+else
+begin
+FileUtils.ln_s source, destination
+rescue
+FileUtils.cp_r source, destination
+end
+end
+}
end
def copyVMToBundle
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159967] trunk/Source/WebKit2
Title: [159967] trunk/Source/WebKit2 Revision 159967 Author timothy_hor...@apple.com Date 2013-12-02 14:42:34 -0800 (Mon, 02 Dec 2013) Log Message Remote Layer Tree: Support cloning layers https://bugs.webkit.org/show_bug.cgi?id=124874 rdar://problem/15349468 Reviewed by Simon Fraser. We use PlatformCALayer::clone for CSS reflections, so implement it. Also, since many reflections testcases also use masks, working on this revealed that masks weren't working, because we weren't flushing mask layers. * Shared/mac/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): * Shared/mac/RemoteLayerTreeTransaction.mm: (WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties): (WebKit::RemoteLayerTreeTransaction::LayerProperties::encode): (WebKit::RemoteLayerTreeTransaction::LayerProperties::decode): Rename maskLayer-maskLayerID since it's a LayerID. * UIProcess/mac/RemoteLayerTreeHost.mm: (WebKit::RemoteLayerTreeHost::commit): Don't try to look up the layer if it's null. * Shared/mac/RemoteLayerTreeTransaction.h: (WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged): * Shared/mac/RemoteLayerTreeTransaction.mm: (WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties): Keep track of all properties that have ever been changed on a layer. * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: (PlatformCALayerRemote::create): (PlatformCALayerRemote::PlatformCALayerRemote): (PlatformCALayerRemote::clone): Copy all of the layer properties from the original to the clone, and mark all properties that have ever been modified as needing to be flushed to the UI process. (PlatformCALayerRemote::recursiveBuildTransaction): Flush our mask layer, if we have one. (PlatformCALayerRemote::setMask): * WebProcess/WebPage/mac/PlatformCALayerRemote.h: Store the mask layer we're given. Our owning GraphicsLayer will hold on to it for us. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h Diff Modified: trunk/Source/WebKit2/ChangeLog (159966 => 159967) --- trunk/Source/WebKit2/ChangeLog 2013-12-02 22:36:07 UTC (rev 159966) +++ trunk/Source/WebKit2/ChangeLog 2013-12-02 22:42:34 UTC (rev 159967) @@ -1,3 +1,51 @@ +2013-12-02 Tim Horton timothy_hor...@apple.com + +Remote Layer Tree: Support cloning layers +https://bugs.webkit.org/show_bug.cgi?id=124874 +rdar://problem/15349468 + +Reviewed by Simon Fraser. + +We use PlatformCALayer::clone for CSS reflections, so implement it. + +Also, since many reflections testcases also use masks, +working on this revealed that masks weren't working, because +we weren't flushing mask layers. + +* Shared/mac/RemoteLayerTreePropertyApplier.mm: +(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): +* Shared/mac/RemoteLayerTreeTransaction.mm: +(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties): +(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode): +(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode): +Rename maskLayer-maskLayerID since it's a LayerID. + +* UIProcess/mac/RemoteLayerTreeHost.mm: +(WebKit::RemoteLayerTreeHost::commit): +Don't try to look up the layer if it's null. + +* Shared/mac/RemoteLayerTreeTransaction.h: +(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged): +* Shared/mac/RemoteLayerTreeTransaction.mm: +(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties): +Keep track of all properties that have ever been changed on a layer. + +* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: +(PlatformCALayerRemote::create): +(PlatformCALayerRemote::PlatformCALayerRemote): +(PlatformCALayerRemote::clone): +Copy all of the layer properties from the original to the clone, +and mark all properties that have ever been modified as +needing to be flushed to the UI process. + +(PlatformCALayerRemote::recursiveBuildTransaction): +Flush our mask layer, if we have one. + +(PlatformCALayerRemote::setMask): +* WebProcess/WebPage/mac/PlatformCALayerRemote.h: +Store the mask layer we're given. Our owning GraphicsLayer will +hold on to it for us. + 2013-12-02 Anders Carlsson ander...@apple.com WKPageLoaderClient should be versioned Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm (159966 => 159967) ---
[webkit-changes] [159969] trunk/Tools
Title: [159969] trunk/Tools Revision 159969 Author commit-qu...@webkit.org Date 2013-12-02 14:53:15 -0800 (Mon, 02 Dec 2013) Log Message Add _javascript_ style checker and teach checker.py about .js files https://bugs.webkit.org/show_bug.cgi?id=125049 Patch by Brian J. Burg b...@cs.washington.edu on 2013-12-02 Reviewed by Joseph Pecoraro. Add a _javascript_ file type, extension, and checker (JSChecker). Use TextChecker for _javascript_ tests, libraries, website resources, etc. and use JSChecker for files within WebInspectorUI/UserInterface. Amended tests for TextChecker to reflect the rule above. * Scripts/webkitpy/style/checker.py: (_all_categories): Add categories defined by JSChecker. (FileType): Add file type for JS and re-number the enum. (CheckerDispatcher._file_type): Detect .js files as _javascript_. (CheckerDispatcher._create_checker): Create a JSChecker or TextChecker depending on the file's path. * Scripts/webkitpy/style/checker_unittest.py: (CheckerDispatcherDispatchTest.assert_checker_js): Added. (CheckerDispatcherDispatchTest.test_js_paths): Added. (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths that end in .js but should be checked with TextChecker. * Scripts/webkitpy/style/checkers/js.py: Added. (JSChecker): (JSChecker.__init__): (JSChecker.check): * Scripts/webkitpy/style/checkers/js_unittest.py: Added. (JSTestCase): (JSTestCase.assertNoError): (JSTestCase.assertNoError.error_for_test): (JSTestCase.assertError): (JSTestCase.assertError.error_for_test): (JSTestCase.test_no_error): (JSTestCase.test_error): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/style/checker.py trunk/Tools/Scripts/webkitpy/style/checker_unittest.py Added Paths trunk/Tools/Scripts/webkitpy/style/checkers/js.py trunk/Tools/Scripts/webkitpy/style/checkers/js_unittest.py Diff Modified: trunk/Tools/ChangeLog (159968 => 159969) --- trunk/Tools/ChangeLog 2013-12-02 22:48:54 UTC (rev 159968) +++ trunk/Tools/ChangeLog 2013-12-02 22:53:15 UTC (rev 159969) @@ -1,3 +1,41 @@ +2013-12-02 Brian J. Burg b...@cs.washington.edu + +Add _javascript_ style checker and teach checker.py about .js files +https://bugs.webkit.org/show_bug.cgi?id=125049 + +Reviewed by Joseph Pecoraro. + +Add a _javascript_ file type, extension, and checker (JSChecker). +Use TextChecker for _javascript_ tests, libraries, website resources, +etc. and use JSChecker for files within WebInspectorUI/UserInterface. + +Amended tests for TextChecker to reflect the rule above. + +* Scripts/webkitpy/style/checker.py: +(_all_categories): Add categories defined by JSChecker. +(FileType): Add file type for JS and re-number the enum. +(CheckerDispatcher._file_type): Detect .js files as _javascript_. +(CheckerDispatcher._create_checker): +Create a JSChecker or TextChecker depending on the file's path. + +* Scripts/webkitpy/style/checker_unittest.py: +(CheckerDispatcherDispatchTest.assert_checker_js): Added. +(CheckerDispatcherDispatchTest.test_js_paths): Added. +(CheckerDispatcherDispatchTest.test_text_paths): Add new test paths +that end in .js but should be checked with TextChecker. +* Scripts/webkitpy/style/checkers/js.py: Added. +(JSChecker): +(JSChecker.__init__): +(JSChecker.check): +* Scripts/webkitpy/style/checkers/js_unittest.py: Added. +(JSTestCase): +(JSTestCase.assertNoError): +(JSTestCase.assertNoError.error_for_test): +(JSTestCase.assertError): +(JSTestCase.assertError.error_for_test): +(JSTestCase.test_no_error): +(JSTestCase.test_error): + 2013-12-02 Mark Hahnenberg mhahnenb...@apple.com run-jsc-stress-tests always copies the VM Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (159968 => 159969) --- trunk/Tools/Scripts/webkitpy/style/checker.py 2013-12-02 22:48:54 UTC (rev 159968) +++ trunk/Tools/Scripts/webkitpy/style/checker.py 2013-12-02 22:53:15 UTC (rev 159969) @@ -41,6 +41,7 @@ from checkers.changelog import ChangeLogChecker from checkers.cpp import CppChecker from checkers.cmake import CMakeChecker +from checkers.js import JSChecker from checkers.jsonchecker import JSONChecker from checkers.png import PNGChecker from checkers.python import PythonChecker @@ -263,6 +264,8 @@ 'h', ] +_JS_FILE_EXTENSION = 'js' + _JSON_FILE_EXTENSION = 'json' _PYTHON_FILE_EXTENSION = 'py' @@ -279,7 +282,6 @@ 'html', 'idl', 'in', -'js', 'mm', 'php', 'pl', @@ -350,6 +352,7 @@ Return the set of all categories used by check-webkit-style. # Take the union across all checkers. categories = CommonCategories.union(CppChecker.categories) +categories = categories.union(JSChecker.categories) categories = categories.union(JSONChecker.categories) categories =
[webkit-changes] [159970] trunk/Source/WebCore
Title: [159970] trunk/Source/WebCore
Revision 159970
Author beid...@apple.com
Date 2013-12-02 14:56:01 -0800 (Mon, 02 Dec 2013)
Log Message
Add more CachedPage null checks
https://bugs.webkit.org/show_bug.cgi?id=125106
Reviewed by Sam Weinig.
Only some functions in PageCache.cpp null-check the CachedPages in HistoryItems.
Every part that manipulates the CachedPage should.
* history/PageCache.cpp:
(WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
(WebCore::PageCache::markPagesForCaptionPreferencesChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/PageCache.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (159969 => 159970)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 22:53:15 UTC (rev 159969)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 22:56:01 UTC (rev 159970)
@@ -1,3 +1,20 @@
+2013-12-02 Brady Eidson beid...@apple.com
+
+Add more CachedPage null checks
+https://bugs.webkit.org/show_bug.cgi?id=125106
+
+Reviewed by Sam Weinig.
+
+Only some functions in PageCache.cpp null-check the CachedPages in HistoryItems.
+
+Every part that manipulates the CachedPage should.
+
+* history/PageCache.cpp:
+(WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
+(WebCore::PageCache::markPagesForFullStyleRecalc):
+(WebCore::PageCache::markPagesForDeviceScaleChanged):
+(WebCore::PageCache::markPagesForCaptionPreferencesChanged):
+
2013-12-02 Zoltan Horvath zol...@webkit.org
[CSS Shapes] Support inset parsing
Modified: trunk/Source/WebCore/history/PageCache.cpp (159969 => 159970)
--- trunk/Source/WebCore/history/PageCache.cpp 2013-12-02 22:53:15 UTC (rev 159969)
+++ trunk/Source/WebCore/history/PageCache.cpp 2013-12-02 22:56:01 UTC (rev 159970)
@@ -390,15 +390,17 @@
void PageCache::markPagesForVistedLinkStyleRecalc()
{
-for (HistoryItem* current = m_head; current; current = current-m_next)
-current-m_cachedPage-markForVistedLinkStyleRecalc();
+for (HistoryItem* current = m_head; current; current = current-m_next) {
+if (current-m_cachedPage)
+current-m_cachedPage-markForVistedLinkStyleRecalc();
+}
}
void PageCache::markPagesForFullStyleRecalc(Page* page)
{
for (HistoryItem* current = m_head; current; current = current-m_next) {
CachedPage* cachedPage = current-m_cachedPage.get();
-if (page-mainFrame() == cachedPage-cachedMainFrame()-view()-frame())
+if (cachedPage page-mainFrame() == cachedPage-cachedMainFrame()-view()-frame())
cachedPage-markForFullStyleRecalc();
}
}
@@ -409,7 +411,7 @@
{
for (HistoryItem* current = m_head; current; current = current-m_next) {
CachedPage* cachedPage = current-m_cachedPage.get();
-if (page-mainFrame() == cachedPage-cachedMainFrame()-view()-frame())
+if (cachedPage page-mainFrame() == cachedPage-cachedMainFrame()-view()-frame())
cachedPage-markForDeviceScaleChanged();
}
}
@@ -418,8 +420,10 @@
#if ENABLE(VIDEO_TRACK)
void PageCache::markPagesForCaptionPreferencesChanged()
{
-for (HistoryItem* current = m_head; current; current = current-m_next)
-current-m_cachedPage-markForCaptionPreferencesChanged();
+for (HistoryItem* current = m_head; current; current = current-m_next) {
+if (current-m_cachedPage)
+current-m_cachedPage-markForCaptionPreferencesChanged();
+}
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159971] trunk/Source/Platform
Title: [159971] trunk/Source/Platform Revision 159971 Author commit-qu...@webkit.org Date 2013-12-02 14:59:05 -0800 (Mon, 02 Dec 2013) Log Message Nix Upstream: Updating Platform files https://bugs.webkit.org/show_bug.cgi?id=124982 Patch by Thiago de Barros Lacerda thiago.lace...@openbossa.org on 2013-12-02 Reviewed by Benjamin Poulain. Adding new Platform files that are missing in the trunk. * PlatformNix.cmake: * nix/public/AudioDestinationConsumer.h: Added. (Nix::AudioDestinationConsumer::~AudioDestinationConsumer): * nix/public/MediaConstraints.h: Added. * nix/public/MediaStream.h: Added. * nix/public/MediaStreamAudioSource.h: Added. * nix/public/MediaStreamCenter.h: Added. * nix/public/MediaStreamSource.h: Added. * nix/public/PrivatePtr.h: Added. Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/PlatformNix.cmake Added Paths trunk/Source/Platform/nix/public/AudioDestinationConsumer.h trunk/Source/Platform/nix/public/MediaConstraints.h trunk/Source/Platform/nix/public/MediaStream.h trunk/Source/Platform/nix/public/MediaStreamAudioSource.h trunk/Source/Platform/nix/public/MediaStreamCenter.h trunk/Source/Platform/nix/public/MediaStreamSource.h trunk/Source/Platform/nix/public/PrivatePtr.h Diff Modified: trunk/Source/Platform/ChangeLog (159970 => 159971) --- trunk/Source/Platform/ChangeLog 2013-12-02 22:56:01 UTC (rev 159970) +++ trunk/Source/Platform/ChangeLog 2013-12-02 22:59:05 UTC (rev 159971) @@ -1,3 +1,22 @@ +2013-12-02 Thiago de Barros Lacerda thiago.lace...@openbossa.org + +Nix Upstream: Updating Platform files +https://bugs.webkit.org/show_bug.cgi?id=124982 + +Reviewed by Benjamin Poulain. + +Adding new Platform files that are missing in the trunk. + +* PlatformNix.cmake: +* nix/public/AudioDestinationConsumer.h: Added. +(Nix::AudioDestinationConsumer::~AudioDestinationConsumer): +* nix/public/MediaConstraints.h: Added. +* nix/public/MediaStream.h: Added. +* nix/public/MediaStreamAudioSource.h: Added. +* nix/public/MediaStreamCenter.h: Added. +* nix/public/MediaStreamSource.h: Added. +* nix/public/PrivatePtr.h: Added. + 2013-11-26 Marcelo Lira marcelo.l...@openbossa.org Nix upstreaming - Adding build files and supporting scripts Modified: trunk/Source/Platform/PlatformNix.cmake (159970 => 159971) --- trunk/Source/Platform/PlatformNix.cmake 2013-12-02 22:56:01 UTC (rev 159970) +++ trunk/Source/Platform/PlatformNix.cmake 2013-12-02 22:59:05 UTC (rev 159971) @@ -6,6 +6,7 @@ ) set(Platform_HEADERS +nix/public/AudioDestinationConsumer.h nix/public/AudioDevice.h nix/public/Canvas.h nix/public/Color.h @@ -13,9 +14,15 @@ nix/public/FFTFrame.h nix/public/Gamepad.h nix/public/Gamepads.h +nix/public/MediaConstraints.h nix/public/MediaPlayer.h +nix/public/MediaStream.h +nix/public/MediaStreamAudioSource.h +nix/public/MediaStreamCenter.h +nix/public/MediaStreamSource.h nix/public/MultiChannelPCMData.h nix/public/Platform.h +nix/public/PrivatePtr.h nix/public/Rect.h nix/public/Size.h nix/public/ThemeEngine.h Added: trunk/Source/Platform/nix/public/AudioDestinationConsumer.h (0 => 159971) --- trunk/Source/Platform/nix/public/AudioDestinationConsumer.h (rev 0) +++ trunk/Source/Platform/nix/public/AudioDestinationConsumer.h 2013-12-02 22:59:05 UTC (rev 159971) @@ -0,0 +1,48 @@ +/* + * Copyright (C) 2012 Google Inc. All rights reserved. + * Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies). + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#ifndef
[webkit-changes] [159972] trunk/Source/WebKit2
Title: [159972] trunk/Source/WebKit2
Revision 159972
Author commit-qu...@webkit.org
Date 2013-12-02 15:03:53 -0800 (Mon, 02 Dec 2013)
Log Message
[WK2] Improve readability of 'generate_message_handler' function
https://bugs.webkit.org/show_bug.cgi?id=125085
Patch by Nick Diego Yamane nick.yam...@openbossa.org on 2013-12-02
Reviewed by Sam Weinig.
* Scripts/webkit2/messages.py:
(generate_message_handler):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Scripts/webkit2/messages.py
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159971 => 159972)
--- trunk/Source/WebKit2/ChangeLog 2013-12-02 22:59:05 UTC (rev 159971)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-02 23:03:53 UTC (rev 159972)
@@ -1,3 +1,13 @@
+2013-12-02 Nick Diego Yamane nick.yam...@openbossa.org
+
+[WK2] Improve readability of 'generate_message_handler' function
+https://bugs.webkit.org/show_bug.cgi?id=125085
+
+Reviewed by Sam Weinig.
+
+* Scripts/webkit2/messages.py:
+(generate_message_handler):
+
2013-12-02 Tim Horton timothy_hor...@apple.com
Remote Layer Tree: Support cloning layers
Modified: trunk/Source/WebKit2/Scripts/webkit2/messages.py (159971 => 159972)
--- trunk/Source/WebKit2/Scripts/webkit2/messages.py 2013-12-02 22:59:05 UTC (rev 159971)
+++ trunk/Source/WebKit2/Scripts/webkit2/messages.py 2013-12-02 23:03:53 UTC (rev 159972)
@@ -461,7 +461,7 @@
def generate_message_handler(file):
receiver = parser.parse(file)
-headers = {
+header_conditions = {
'%s' % messages_header_filename(receiver): [None],
'HandleMessage.h': [None],
'MessageDecoder.h': [None],
@@ -482,15 +482,15 @@
argument_encoder_headers = argument_coder_headers_for_type(type)
if argument_encoder_headers:
for header in argument_encoder_headers:
-if header not in headers:
-headers[header] = []
-headers[header].extend(conditions)
+if header not in header_conditions:
+header_conditions[header] = []
+header_conditions[header].extend(conditions)
type_headers = headers_for_type(type)
for header in type_headers:
-if header not in headers:
-headers[header] = []
-headers[header].extend(conditions)
+if header not in header_conditions:
+header_conditions[header] = []
+header_conditions[header].extend(conditions)
for message in receiver.messages:
if message.reply_parameters is not None:
@@ -499,15 +499,15 @@
argument_encoder_headers = argument_coder_headers_for_type(type)
if argument_encoder_headers:
for header in argument_encoder_headers:
-if header not in headers:
-headers[header] = []
-headers[header].append(message.condition)
+if header not in header_conditions:
+header_conditions[header] = []
+header_conditions[header].append(message.condition)
type_headers = headers_for_type(type)
for header in type_headers:
-if header not in headers:
-headers[header] = []
-headers[header].append(message.condition)
+if header not in header_conditions:
+header_conditions[header] = []
+header_conditions[header].append(message.condition)
result = []
@@ -520,13 +520,13 @@
result.append('#if %s\n\n' % receiver.condition)
result.append('#include %s.h\n\n' % receiver.name)
-for headercondition in sorted(headers):
-if headers[headercondition] and not None in headers[headercondition]:
-result.append('#if %s\n' % ' || '.join(set(headers[headercondition])))
-result += ['#include %s\n' % headercondition]
+for header in sorted(header_conditions):
+if header_conditions[header] and not None in header_conditions[header]:
+result.append('#if %s\n' % ' || '.join(set(header_conditions[header])))
+result += ['#include %s\n' % header]
result.append('#endif\n')
else:
-result += ['#include %s\n' % headercondition]
+result += ['#include %s\n' % header]
result.append('\n')
sync_delayed_messages = []
@@ -542,7 +542,7 @@
if message.condition:
result.append('#if %s\n\n' % message.condition)
-
+
result.append('%s::DelayedReply::DelayedReply(PassRefPtrCoreIPC::Connection connection, std::unique_ptrCoreIPC::MessageEncoder encoder)\n' % message.name)
result.append(': m_connection(connection)\n')
result.append(',
[webkit-changes] [159973] trunk/Source/JavaScriptCore
Title: [159973] trunk/Source/_javascript_Core
Revision 159973
Author fpi...@apple.com
Date 2013-12-02 15:17:53 -0800 (Mon, 02 Dec 2013)
Log Message
Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
https://bugs.webkit.org/show_bug.cgi?id=125107
Reviewed by Mark Hahnenberg.
Just killing dead code.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_div):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_div):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_strcat):
(JSC::JIT::emitSlow_op_get_callee):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emitSlow_op_get_callee):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITArithmetic.cpp
trunk/Source/_javascript_Core/jit/JITArithmetic32_64.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (159972 => 159973)
--- trunk/Source/_javascript_Core/ChangeLog 2013-12-02 23:03:53 UTC (rev 159972)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-12-02 23:17:53 UTC (rev 159973)
@@ -1,3 +1,59 @@
+2013-12-02 Filip Pizlo fpi...@apple.com
+
+Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
+https://bugs.webkit.org/show_bug.cgi?id=125107
+
+Reviewed by Mark Hahnenberg.
+
+Just killing dead code.
+
+* jit/JITArithmetic.cpp:
+(JSC::JIT::emitSlow_op_negate):
+(JSC::JIT::emitSlow_op_lshift):
+(JSC::JIT::emitSlow_op_rshift):
+(JSC::JIT::emitSlow_op_urshift):
+(JSC::JIT::emitSlow_op_bitand):
+(JSC::JIT::emitSlow_op_inc):
+(JSC::JIT::emitSlow_op_dec):
+(JSC::JIT::emitSlow_op_mod):
+(JSC::JIT::emit_op_mod):
+(JSC::JIT::compileBinaryArithOpSlowCase):
+(JSC::JIT::emitSlow_op_div):
+* jit/JITArithmetic32_64.cpp:
+(JSC::JIT::emitSlow_op_negate):
+(JSC::JIT::emitSlow_op_lshift):
+(JSC::JIT::emitRightShiftSlowCase):
+(JSC::JIT::emitSlow_op_bitand):
+(JSC::JIT::emitSlow_op_bitor):
+(JSC::JIT::emitSlow_op_bitxor):
+(JSC::JIT::emitSlow_op_inc):
+(JSC::JIT::emitSlow_op_dec):
+(JSC::JIT::emitSlow_op_add):
+(JSC::JIT::emitSlow_op_sub):
+(JSC::JIT::emitSlow_op_mul):
+(JSC::JIT::emitSlow_op_div):
+* jit/JITOpcodes.cpp:
+(JSC::JIT::emit_op_strcat):
+(JSC::JIT::emitSlow_op_get_callee):
+(JSC::JIT::emitSlow_op_create_this):
+(JSC::JIT::emitSlow_op_to_this):
+(JSC::JIT::emitSlow_op_to_primitive):
+(JSC::JIT::emitSlow_op_not):
+(JSC::JIT::emitSlow_op_bitxor):
+(JSC::JIT::emitSlow_op_bitor):
+(JSC::JIT::emitSlow_op_stricteq):
+(JSC::JIT::emitSlow_op_nstricteq):
+(JSC::JIT::emitSlow_op_to_number):
+* jit/JITOpcodes32_64.cpp:
+(JSC::JIT::emitSlow_op_to_primitive):
+(JSC::JIT::emitSlow_op_not):
+(JSC::JIT::emitSlow_op_stricteq):
+(JSC::JIT::emitSlow_op_nstricteq):
+(JSC::JIT::emitSlow_op_to_number):
+(JSC::JIT::emitSlow_op_get_callee):
+(JSC::JIT::emitSlow_op_create_this):
+(JSC::JIT::emitSlow_op_to_this):
+
2013-12-01 Filip Pizlo fpi...@apple.com
Stores to local captured variables should be intercepted
Modified: trunk/Source/_javascript_Core/jit/JITArithmetic.cpp (159972 => 159973)
--- trunk/Source/_javascript_Core/jit/JITArithmetic.cpp 2013-12-02 23:03:53 UTC (rev 159972)
+++ trunk/Source/_javascript_Core/jit/JITArithmetic.cpp 2013-12-02 23:17:53 UTC (rev 159973)
@@ -220,14 +220,11 @@
void JIT::emitSlow_op_negate(Instruction* currentInstruction, VectorSlowCaseEntry::iterator iter)
{
-int result =
[webkit-changes] [159974] trunk/Source/WebCore
Title: [159974] trunk/Source/WebCore Revision 159974 Author beid...@apple.com Date 2013-12-02 15:30:53 -0800 (Mon, 02 Dec 2013) Log Message Possible crash in ProgressTracker::progressHeartbeatTimerFired(TimerProgressTracker*) https://bugs.webkit.org/show_bug.cgi?id=125110 Reviewed by Darin Adler. It’s possible to have a null m_originatingProgressFrame when the heartbeat timer fires. On the surface this seems impossible because the only time m_originatingProgressFrame is cleared out the heartbeat timer is also stopped. But there’s likely still a race condition in multi-threaded environments. There’s no harm in null-checking m_originatingProgressFrame before accessing its loader. * loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressHeartbeatTimerFired): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/ProgressTracker.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (159973 => 159974) --- trunk/Source/WebCore/ChangeLog 2013-12-02 23:17:53 UTC (rev 159973) +++ trunk/Source/WebCore/ChangeLog 2013-12-02 23:30:53 UTC (rev 159974) @@ -1,5 +1,24 @@ 2013-12-02 Brady Eidson beid...@apple.com +Possible crash in ProgressTracker::progressHeartbeatTimerFired(TimerProgressTracker*) +https://bugs.webkit.org/show_bug.cgi?id=125110 + +Reviewed by Darin Adler. + +It’s possible to have a null m_originatingProgressFrame when the heartbeat timer fires. + +On the surface this seems impossible because the only time m_originatingProgressFrame is cleared +out the heartbeat timer is also stopped. + +But there’s likely still a race condition in multi-threaded environments. + +There’s no harm in null-checking m_originatingProgressFrame before accessing its loader. + +* loader/ProgressTracker.cpp: +(WebCore::ProgressTracker::progressHeartbeatTimerFired): + +2013-12-02 Brady Eidson beid...@apple.com + Add more CachedPage null checks https://bugs.webkit.org/show_bug.cgi?id=125106 Modified: trunk/Source/WebCore/loader/ProgressTracker.cpp (159973 => 159974) --- trunk/Source/WebCore/loader/ProgressTracker.cpp 2013-12-02 23:17:53 UTC (rev 159973) +++ trunk/Source/WebCore/loader/ProgressTracker.cpp 2013-12-02 23:30:53 UTC (rev 159974) @@ -295,7 +295,8 @@ m_totalBytesReceivedBeforePreviousHeartbeat = m_totalBytesReceived; -m_originatingProgressFrame-loader().loadProgressingStatusChanged(); +if (m_originatingProgressFrame) +m_originatingProgressFrame-loader().loadProgressingStatusChanged(); if (m_progressValue = finalProgressValue) m_progressHeartbeatTimer.stop(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159975] trunk
Title: [159975] trunk
Revision 159975
Author a...@apple.com
Date 2013-12-02 15:43:01 -0800 (Mon, 02 Dec 2013)
Log Message
WebCrypto HMAC doesn't check key algorithm's hash
https://bugs.webkit.org/show_bug.cgi?id=125114
Reviewed by Anders Carlsson.
Source/WebCore:
Test: crypto/subtle/hmac-check-algorithm.html
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches): Check it.
LayoutTests:
* crypto/subtle/hmac-check-algorithm-expected.txt: Added.
* crypto/subtle/hmac-check-algorithm.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.cpp
Added Paths
trunk/LayoutTests/crypto/subtle/hmac-check-algorithm-expected.txt
trunk/LayoutTests/crypto/subtle/hmac-check-algorithm.html
Diff
Modified: trunk/LayoutTests/ChangeLog (159974 => 159975)
--- trunk/LayoutTests/ChangeLog 2013-12-02 23:30:53 UTC (rev 159974)
+++ trunk/LayoutTests/ChangeLog 2013-12-02 23:43:01 UTC (rev 159975)
@@ -1,3 +1,13 @@
+2013-12-02 Alexey Proskuryakov a...@apple.com
+
+WebCrypto HMAC doesn't check key algorithm's hash
+https://bugs.webkit.org/show_bug.cgi?id=125114
+
+Reviewed by Anders Carlsson.
+
+* crypto/subtle/hmac-check-algorithm-expected.txt: Added.
+* crypto/subtle/hmac-check-algorithm.html: Added.
+
2013-12-02 Zoltan Horvath zol...@webkit.org
[CSS Shapes] Support inset parsing
Added: trunk/LayoutTests/crypto/subtle/hmac-check-algorithm-expected.txt (0 => 159975)
--- trunk/LayoutTests/crypto/subtle/hmac-check-algorithm-expected.txt (rev 0)
+++ trunk/LayoutTests/crypto/subtle/hmac-check-algorithm-expected.txt 2013-12-02 23:43:01 UTC (rev 159975)
@@ -0,0 +1,12 @@
+Test that HMAC operations only work when hash functions match between invocation and key.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Importing a raw HMAC SHA-1 key from string literal...
+PASS crypto.subtle.sign({name: 'hmac', hash: {name: 'sha-256'}}, key, asciiToUint8Array('foo')) threw exception Error: NotSupportedError: DOM Exception 9.
+PASS crypto.subtle.verify({name: 'hmac', hash: {name: 'sha-256'}}, key, asciiToUint8Array('fake signature'), asciiToUint8Array('foo')) threw exception Error: NotSupportedError: DOM Exception 9.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/crypto/subtle/hmac-check-algorithm-expected.txt
___
Added: svn:mime-type
Added: svn:eol-style
Added: trunk/LayoutTests/crypto/subtle/hmac-check-algorithm.html (0 => 159975)
--- trunk/LayoutTests/crypto/subtle/hmac-check-algorithm.html (rev 0)
+++ trunk/LayoutTests/crypto/subtle/hmac-check-algorithm.html 2013-12-02 23:43:01 UTC (rev 159975)
@@ -0,0 +1,36 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+
+script
+description(Test that HMAC operations only work when hash functions match between invocation and key.);
+
+jsTestIsAsync = true;
+
+var hmacKey = asciiToUint8Array('a');
+var extractable = true;
+
+debug(Importing a raw HMAC SHA-1 key from string literal...);
+crypto.subtle.importKey(raw, hmacKey, {name: 'hmac', hash: {name: 'sha-1'}}, extractable, [sign, verify]).then(function(result) {
+debug(Done);
+key = result;
+
+shouldNotThrow(crypto.subtle.sign({name: 'hmac', hash: {name: 'sha-1'}}, key, asciiToUint8Array('foo')));
+shouldThrow(crypto.subtle.sign({name: 'hmac', hash: {name: 'sha-256'}}, key, asciiToUint8Array('foo')));
+
+shouldNotThrow(crypto.subtle.verify({name: 'hmac', hash: {name: 'sha-1'}}, key, asciiToUint8Array('fake signature'), asciiToUint8Array('foo')));
+shouldThrow(crypto.subtle.verify({name: 'hmac', hash: {name: 'sha-256'}}, key, asciiToUint8Array('fake signature'), asciiToUint8Array('foo')));
+
+finishJSTest();
+});
+/script
+
+script src=""
+/body
+/html
Property changes on: trunk/LayoutTests/crypto/subtle/hmac-check-algorithm.html
___
Added: svn:mime-type
Modified: trunk/Source/WebCore/ChangeLog (159974 => 159975)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 23:30:53 UTC (rev 159974)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 23:43:01 UTC (rev 159975)
@@ -1,3 +1,15 @@
+2013-12-02 Alexey Proskuryakov a...@apple.com
+
+WebCrypto HMAC doesn't check key algorithm's hash
+https://bugs.webkit.org/show_bug.cgi?id=125114
+
+Reviewed by Anders Carlsson.
+
+Test: crypto/subtle/hmac-check-algorithm.html
+
+* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
+(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches): Check it.
+
2013-12-02 Brady Eidson beid...@apple.com
Possible crash in ProgressTracker::progressHeartbeatTimerFired(TimerProgressTracker*)
[webkit-changes] [159977] trunk/Tools
Title: [159977] trunk/Tools Revision 159977 Author commit-qu...@webkit.org Date 2013-12-02 15:52:34 -0800 (Mon, 02 Dec 2013) Log Message Remove the stderr_write attribute from StyleProcessorConfiguration https://bugs.webkit.org/show_bug.cgi?id=124703 Patch by László Langó la...@inf.u-szeged.hu on 2013-12-02 Reviewed by Ryosuke Niwa. Remove the stderr_write attribute from this class in checker and replace its use with calls to a logging module logger. We Should use logging module instead of writing to stderr directly. * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger. (check_webkit_style_configuration): (CheckerDispatcher.dispatch): Remove FIXME comment. (StyleProcessorConfiguration): (StyleProcessorConfiguration.__init__): (StyleProcessorConfiguration.write_style_error): * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification. There is an ERROR prefix in log messiges from now. (StyleProcessorConfigurationTest): (StyleProcessorConfigurationTest._style_checker_configuration): (StyleProcessorConfigurationTest.test_init): (StyleProcessorConfigurationTest.test_write_style_error_emacs): (StyleProcessorConfigurationTest.test_write_style_error_vs7): (StyleProcessor_EndToEndTest.with): (StyleProcessor_EndToEndTest.test_init): (StyleProcessor_EndToEndTest.test_process): (StyleProcessor_CodeCoverageTest.setUp): * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger. (DefaultStyleErrorHandler.__call__): * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification. There is an ERROR prefix in log messiges from now. (DefaultStyleErrorHandlerTest): (DefaultStyleErrorHandlerTest.setUp): (DefaultStyleErrorHandlerTest._mock_increment_error_count): (DefaultStyleErrorHandlerTest._style_checker_configuration): (DefaultStyleErrorHandlerTest._check_initialized): (DefaultStyleErrorHandlerTest.test_non_reportable_error): (DefaultStyleErrorHandlerTest.test_max_reports_per_category): (DefaultStyleErrorHandlerTest.test_line_numbers): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/style/checker.py trunk/Tools/Scripts/webkitpy/style/checker_unittest.py trunk/Tools/Scripts/webkitpy/style/error_handlers.py trunk/Tools/Scripts/webkitpy/style/error_handlers_unittest.py Diff Modified: trunk/Tools/ChangeLog (159976 => 159977) --- trunk/Tools/ChangeLog 2013-12-02 23:48:35 UTC (rev 159976) +++ trunk/Tools/ChangeLog 2013-12-02 23:52:34 UTC (rev 159977) @@ -1,3 +1,44 @@ +2013-12-02 László Langó la...@inf.u-szeged.hu + +Remove the stderr_write attribute from StyleProcessorConfiguration +https://bugs.webkit.org/show_bug.cgi?id=124703 + +Reviewed by Ryosuke Niwa. + +Remove the stderr_write attribute from this class in checker and +replace its use with calls to a logging module logger. We Should +use logging module instead of writing to stderr directly. + +* Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger. +(check_webkit_style_configuration): +(CheckerDispatcher.dispatch): Remove FIXME comment. +(StyleProcessorConfiguration): +(StyleProcessorConfiguration.__init__): +(StyleProcessorConfiguration.write_style_error): +* Scripts/webkitpy/style/checker_unittest.py: Update test to the modification. +There is an ERROR prefix in log messiges from now. +(StyleProcessorConfigurationTest): +(StyleProcessorConfigurationTest._style_checker_configuration): +(StyleProcessorConfigurationTest.test_init): +(StyleProcessorConfigurationTest.test_write_style_error_emacs): +(StyleProcessorConfigurationTest.test_write_style_error_vs7): +(StyleProcessor_EndToEndTest.with): +(StyleProcessor_EndToEndTest.test_init): +(StyleProcessor_EndToEndTest.test_process): +(StyleProcessor_CodeCoverageTest.setUp): +* Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger. +(DefaultStyleErrorHandler.__call__): +* Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification. +There is an ERROR prefix in log messiges from now. +(DefaultStyleErrorHandlerTest): +(DefaultStyleErrorHandlerTest.setUp): +(DefaultStyleErrorHandlerTest._mock_increment_error_count): +(DefaultStyleErrorHandlerTest._style_checker_configuration): +(DefaultStyleErrorHandlerTest._check_initialized): +(DefaultStyleErrorHandlerTest.test_non_reportable_error): +(DefaultStyleErrorHandlerTest.test_max_reports_per_category): +(DefaultStyleErrorHandlerTest.test_line_numbers): + 2013-12-02 Brian J. Burg b...@cs.washington.edu Add _javascript_ style checker and teach checker.py about .js files Modified:
[webkit-changes] [159978] trunk/Tools
Title: [159978] trunk/Tools Revision 159978 Author commit-qu...@webkit.org Date 2013-12-02 15:55:06 -0800 (Mon, 02 Dec 2013) Log Message Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py https://bugs.webkit.org/show_bug.cgi?id=124714 Patch by Dániel Bátyai batyai.dan...@stud.u-szeged.hu on 2013-12-02 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (write_test_result): * Scripts/webkitpy/layout_tests/models/test_failures.py: (TestFailure.write_failure): (FailureText): (FailureText.write_failure): (FailureAudio): (FailureAudio.write_failure): (FailureCrash.write_failure): (FailureMissingResult): (FailureTextMismatch): (FailureMissingImageHash.write_failure): (FailureMissingImage.write_failure): (FailureImageHashMismatch.write_failure): (FailureReftestMismatch.write_failure): (FailureReftestMismatchDidNotOccur.write_failure): (FailureMissingAudio): (FailureAudioMismatch): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py Diff Modified: trunk/Tools/ChangeLog (159977 => 159978) --- trunk/Tools/ChangeLog 2013-12-02 23:52:34 UTC (rev 159977) +++ trunk/Tools/ChangeLog 2013-12-02 23:55:06 UTC (rev 159978) @@ -1,3 +1,29 @@ +2013-12-02 Dániel Bátyai batyai.dan...@stud.u-szeged.hu + +Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py +https://bugs.webkit.org/show_bug.cgi?id=124714 + +Reviewed by Ryosuke Niwa. + +* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: +(write_test_result): +* Scripts/webkitpy/layout_tests/models/test_failures.py: +(TestFailure.write_failure): +(FailureText): +(FailureText.write_failure): +(FailureAudio): +(FailureAudio.write_failure): +(FailureCrash.write_failure): +(FailureMissingResult): +(FailureTextMismatch): +(FailureMissingImageHash.write_failure): +(FailureMissingImage.write_failure): +(FailureImageHashMismatch.write_failure): +(FailureReftestMismatch.write_failure): +(FailureReftestMismatchDidNotOccur.write_failure): +(FailureMissingAudio): +(FailureAudioMismatch): + 2013-12-02 László Langó la...@inf.u-szeged.hu Remove the stderr_write attribute from StyleProcessorConfiguration Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py (159977 => 159978) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py 2013-12-02 23:52:34 UTC (rev 159977) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py 2013-12-02 23:55:06 UTC (rev 159978) @@ -45,44 +45,8 @@ writer.write_stderr(driver_output.error) for failure in failures: -# FIXME: Instead of this long 'if' block, each failure class might -# have a responsibility for writing a test result. -if isinstance(failure, (test_failures.FailureMissingResult, -test_failures.FailureTextMismatch)): -writer.write_text_files(driver_output.text, expected_driver_output.text) -writer.create_text_diff_and_write_result(driver_output.text, expected_driver_output.text) -elif isinstance(failure, test_failures.FailureMissingImage): -writer.write_image_files(driver_output.image, expected_image=None) -elif isinstance(failure, test_failures.FailureMissingImageHash): -writer.write_image_files(driver_output.image, expected_driver_output.image) -elif isinstance(failure, test_failures.FailureImageHashMismatch): -writer.write_image_files(driver_output.image, expected_driver_output.image) -writer.write_image_diff_files(driver_output.image_diff) -elif isinstance(failure, (test_failures.FailureAudioMismatch, - test_failures.FailureMissingAudio)): -writer.write_audio_files(driver_output.audio, expected_driver_output.audio) -elif isinstance(failure, test_failures.FailureCrash): -crashed_driver_output = expected_driver_output if failure.is_reftest else driver_output -writer.write_crash_log(crashed_driver_output.crash_log) -elif isinstance(failure, test_failures.FailureReftestMismatch): -writer.write_image_files(driver_output.image, expected_driver_output.image) -# FIXME: This work should be done earlier in the pipeline (e.g., when we compare images for non-ref tests). -# FIXME: We should always have 2 images here. -if driver_output.image and expected_driver_output.image: -diff_image, diff_percent, err_str = port.diff_image(expected_driver_output.image, driver_output.image,
[webkit-changes] [159982] trunk/Source/WebKit2
Title: [159982] trunk/Source/WebKit2
Revision 159982
Author wei...@apple.com
Date 2013-12-02 16:43:27 -0800 (Mon, 02 Dec 2013)
Log Message
WebPageGroups should keep track of what processes they are being used by
https://bugs.webkit.org/show_bug.cgi?id=124556
Reviewed by Anders Carlsson.
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::addProcess):
(WebKit::WebPageGroup::disconnectProcess):
* UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::webPageGroup):
(WebKit::WebProcessProxy::addWebPageGroup):
* UIProcess/WebProcessProxy.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContextUserMessageCoders.h
trunk/Source/WebKit2/UIProcess/WebPageGroup.cpp
trunk/Source/WebKit2/UIProcess/WebPageGroup.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.h
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159981 => 159982)
--- trunk/Source/WebKit2/ChangeLog 2013-12-03 00:40:33 UTC (rev 159981)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-03 00:43:27 UTC (rev 159982)
@@ -1,3 +1,28 @@
+2013-12-02 Sam Weinig s...@webkit.org
+
+WebPageGroups should keep track of what processes they are being used by
+https://bugs.webkit.org/show_bug.cgi?id=124556
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/WebContextUserMessageCoders.h:
+(WebKit::WebContextUserMessageEncoder::encode):
+(WebKit::WebContextUserMessageDecoder::decode):
+* UIProcess/WebPageGroup.cpp:
+(WebKit::WebPageGroup::addProcess):
+(WebKit::WebPageGroup::disconnectProcess):
+* UIProcess/WebPageGroup.h:
+(WebKit::WebPageGroup::sendToAllProcessesInGroup):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::initializeWebPage):
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::disconnect):
+(WebKit::WebProcessProxy::webPageGroup):
+(WebKit::WebProcessProxy::addWebPageGroup):
+* UIProcess/WebProcessProxy.h:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::webPageGroup):
+
2013-12-02 Anders Carlsson ander...@apple.com
Add versioned structs for all clients except the ones in WKContext.h
Modified: trunk/Source/WebKit2/UIProcess/WebContextUserMessageCoders.h (159981 => 159982)
--- trunk/Source/WebKit2/UIProcess/WebContextUserMessageCoders.h 2013-12-03 00:40:33 UTC (rev 159981)
+++ trunk/Source/WebKit2/UIProcess/WebContextUserMessageCoders.h 2013-12-03 00:43:27 UTC (rev 159982)
@@ -76,6 +76,8 @@
}
case API::Object::Type::PageGroup: {
WebPageGroup* pageGroup = static_castWebPageGroup*(m_root);
+if (pageGroup-addProcess(m_process))
+m_process.addWebPageGroup(*pageGroup);
encoder pageGroup-data();
break;
}
@@ -145,7 +147,7 @@
uint64_t pageGroupID;
if (!decoder.decode(pageGroupID))
return false;
-coder.m_root = WebPageGroup::get(pageGroupID);
+coder.m_root = coder.m_process.webPageGroup(pageGroupID);
break;
}
#if PLATFORM(MAC)
Modified: trunk/Source/WebKit2/UIProcess/WebPageGroup.cpp (159981 => 159982)
--- trunk/Source/WebKit2/UIProcess/WebPageGroup.cpp 2013-12-03 00:40:33 UTC (rev 159981)
+++ trunk/Source/WebKit2/UIProcess/WebPageGroup.cpp 2013-12-03 00:43:27 UTC (rev 159982)
@@ -194,4 +194,14 @@
sendToAllProcessesInGroup(Messages::WebPageGroupProxy::RemoveAllUserContent(), m_data.pageGroupID);
}
+bool WebPageGroup::addProcess(WebProcessProxy process)
+{
+return m_processes.add(process).isNewEntry;
+}
+
+void WebPageGroup::disconnectProcess(WebProcessProxy process)
+{
+m_processes.remove(process);
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/WebPageGroup.h (159981 => 159982)
--- trunk/Source/WebKit2/UIProcess/WebPageGroup.h 2013-12-03 00:40:33 UTC (rev 159981)
+++ trunk/Source/WebKit2/UIProcess/WebPageGroup.h 2013-12-03 00:43:27 UTC (rev 159982)
@@ -65,26 +65,24 @@
void removeAllUserScripts();
void removeAllUserContent();
+bool addProcess(WebProcessProxy);
+void disconnectProcess(WebProcessProxy);
+
private:
templatetypename T void sendToAllProcessesInGroup(const T, uint64_t destinationID);
WebPageGroupData m_data;
mutable RefPtrWebPreferences m_preferences;
HashSetWebPageProxy* m_pages;
+HashSetWebProcessProxy* m_processes;
};
[webkit-changes] [159983] trunk/Source/WebKit2
Title: [159983] trunk/Source/WebKit2
Revision 159983
Author ander...@apple.com
Date 2013-12-02 16:54:12 -0800 (Mon, 02 Dec 2013)
Log Message
Move WKContext clients to separate files
https://bugs.webkit.org/show_bug.cgi?id=125121
Reviewed by Andreas Kling.
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKContextConnectionClient.h: Added.
* UIProcess/API/C/WKContextDownloadClient.h: Added.
* UIProcess/API/C/WKContextHistoryClient.h: Added.
* UIProcess/API/C/WKContextInjectedBundleClient.h: Added.
* WebKit2.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit2/UIProcess/API/C/WKContextConnectionClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKContextDownloadClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKContextHistoryClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKContextInjectedBundleClient.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159982 => 159983)
--- trunk/Source/WebKit2/ChangeLog 2013-12-03 00:43:27 UTC (rev 159982)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-03 00:54:12 UTC (rev 159983)
@@ -1,3 +1,17 @@
+2013-12-02 Anders Carlsson ander...@apple.com
+
+Move WKContext clients to separate files
+https://bugs.webkit.org/show_bug.cgi?id=125121
+
+Reviewed by Andreas Kling.
+
+* UIProcess/API/C/WKContext.h:
+* UIProcess/API/C/WKContextConnectionClient.h: Added.
+* UIProcess/API/C/WKContextDownloadClient.h: Added.
+* UIProcess/API/C/WKContextHistoryClient.h: Added.
+* UIProcess/API/C/WKContextInjectedBundleClient.h: Added.
+* WebKit2.xcodeproj/project.pbxproj:
+
2013-12-02 Sam Weinig s...@webkit.org
WebPageGroups should keep track of what processes they are being used by
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (159982 => 159983)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2013-12-03 00:43:27 UTC (rev 159982)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2013-12-03 00:54:12 UTC (rev 159983)
@@ -27,6 +27,10 @@
#define WKContext_h
#include WebKit2/WKBase.h
+#include WebKit2/WKContextConnectionClient.h
+#include WebKit2/WKContextDownloadClient.h
+#include WebKit2/WKContextHistoryClient.h
+#include WebKit2/WKContextInjectedBundleClient.h
#ifdef __cplusplus
extern C {
@@ -57,90 +61,6 @@
enum { kWKContextClientCurrentVersion = 0 };
-// Injected Bundle Client
-typedef void (*WKContextDidReceiveMessageFromInjectedBundleCallback)(WKContextRef page, WKStringRef messageName, WKTypeRef messageBody, const void *clientInfo);
-typedef void (*WKContextDidReceiveSynchronousMessageFromInjectedBundleCallback)(WKContextRef page, WKStringRef messageName, WKTypeRef messageBody, WKTypeRef* returnData, const void *clientInfo);
-typedef WKTypeRef (*WKContextGetInjectedBundleInitializationUserDataCallback)(WKContextRef context, const void *clientInfo);
-
-struct WKContextInjectedBundleClient {
-int version;
-const void *clientInfo;
-
-// Version 0.
-WKContextDidReceiveMessageFromInjectedBundleCallbackdidReceiveMessageFromInjectedBundle;
-WKContextDidReceiveSynchronousMessageFromInjectedBundleCallback didReceiveSynchronousMessageFromInjectedBundle;
-
-// Version 1.
-WKContextGetInjectedBundleInitializationUserDataCallbackgetInjectedBundleInitializationUserData;
-};
-typedef struct WKContextInjectedBundleClient WKContextInjectedBundleClient;
-
-enum { kWKContextInjectedBundleClientCurrentVersion = 1 };
-
-// History Client
-typedef void (*WKContextDidNavigateWithNavigationDataCallback)(WKContextRef context, WKPageRef page, WKNavigationDataRef navigationData, WKFrameRef frame, const void *clientInfo);
-typedef void (*WKContextDidPerformClientRedirectCallback)(WKContextRef context, WKPageRef page, WKURLRef sourceURL, WKURLRef destinationURL, WKFrameRef frame, const void *clientInfo);
-typedef void (*WKContextDidPerformServerRedirectCallback)(WKContextRef context, WKPageRef page, WKURLRef sourceURL, WKURLRef destinationURL, WKFrameRef frame, const void *clientInfo);
-typedef void (*WKContextDidUpdateHistoryTitleCallback)(WKContextRef context, WKPageRef page, WKStringRef title, WKURLRef URL, WKFrameRef frame, const void *clientInfo);
-typedef void (*WKContextPopulateVisitedLinksCallback)(WKContextRef context, const void *clientInfo);
-
-struct WKContextHistoryClient {
-int version;
-const void *clientInfo;
-WKContextDidNavigateWithNavigationDataCallback didNavigateWithNavigationData;
-WKContextDidPerformClientRedirectCallback didPerformClientRedirect;
-
[webkit-changes] [159984] trunk/Source/WebKit2
Title: [159984] trunk/Source/WebKit2
Revision 159984
Author ander...@apple.com
Date 2013-12-02 17:11:47 -0800 (Mon, 02 Dec 2013)
Log Message
Add versioned structs for the remaining clients
https://bugs.webkit.org/show_bug.cgi?id=125123
Reviewed by Andreas Kling.
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKContextConnectionClient.h:
* UIProcess/API/C/WKContextDownloadClient.h:
* UIProcess/API/C/WKContextHistoryClient.h:
* UIProcess/API/C/WKContextInjectedBundleClient.h:
* UIProcess/API/C/WKOriginDataManager.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/UIProcess/API/C/WKContextConnectionClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKContextDownloadClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKContextHistoryClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKContextInjectedBundleClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKOriginDataManager.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159983 => 159984)
--- trunk/Source/WebKit2/ChangeLog 2013-12-03 00:54:12 UTC (rev 159983)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-03 01:11:47 UTC (rev 159984)
@@ -1,5 +1,19 @@
2013-12-02 Anders Carlsson ander...@apple.com
+Add versioned structs for the remaining clients
+https://bugs.webkit.org/show_bug.cgi?id=125123
+
+Reviewed by Andreas Kling.
+
+* UIProcess/API/C/WKContext.h:
+* UIProcess/API/C/WKContextConnectionClient.h:
+* UIProcess/API/C/WKContextDownloadClient.h:
+* UIProcess/API/C/WKContextHistoryClient.h:
+* UIProcess/API/C/WKContextInjectedBundleClient.h:
+* UIProcess/API/C/WKOriginDataManager.h:
+
+2013-12-02 Anders Carlsson ander...@apple.com
+
Move WKContext clients to separate files
https://bugs.webkit.org/show_bug.cgi?id=125121
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (159983 => 159984)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2013-12-03 00:54:12 UTC (rev 159983)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2013-12-03 01:11:47 UTC (rev 159984)
@@ -48,19 +48,32 @@
typedef void (*WKContextNetworkProcessDidCrashCallback)(WKContextRef context, const void *clientInfo);
typedef void (*WKContextPlugInInformationBecameAvailableCallback)(WKContextRef context, WKArrayRef plugIn, const void *clientInfo);
-struct WKContextClient {
+typedef struct WKContextClientBase {
int version;
const void *clientInfo;
+} WKContextClientBase;
+typedef struct WKContextClientV0 {
+WKContextClientBase base;
+
// Version 0.
WKContextPlugInAutoStartOriginHashesChangedCallback plugInAutoStartOriginHashesChanged;
WKContextNetworkProcessDidCrashCallback networkProcessDidCrash;
WKContextPlugInInformationBecameAvailableCallback plugInInformationBecameAvailable;
-};
-typedef struct WKContextClient WKContextClient;
+} WKContextClientV0;
+// FIXME: Deprecate.
enum { kWKContextClientCurrentVersion = 0 };
+typedef struct WKContextClient {
+int version;
+const void *clientInfo;
+// Version 0.
+WKContextPlugInAutoStartOriginHashesChangedCallback plugInAutoStartOriginHashesChanged;
+WKContextNetworkProcessDidCrashCallback networkProcessDidCrash;
+WKContextPlugInInformationBecameAvailableCallback plugInInformationBecameAvailable;
+} WKContextClient;
+
enum {
kWKProcessModelSharedSecondaryProcess = 0,
kWKProcessModelMultipleSecondaryProcesses = 1
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContextConnectionClient.h (159983 => 159984)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContextConnectionClient.h 2013-12-03 00:54:12 UTC (rev 159983)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContextConnectionClient.h 2013-12-03 01:11:47 UTC (rev 159984)
@@ -30,14 +30,26 @@
typedef void (*WKContextDidCreateConnection)(WKContextRef context, WKConnectionRef connection, const void* clientInfo);
-struct WKContextConnectionClient {
+typedef struct WKContextConnectionClientBase {
int version;
const void *clientInfo;
+} WKContextConnectionClientBase;
+
+typedef struct WKContextConnectionClientV0 {
+WKContextConnectionClientBase base;
+
+// Version 0.
WKContextDidCreateConnectiondidCreateConnection;
-};
-typedef struct WKContextConnectionClient WKContextConnectionClient;
+} WKContextConnectionClientV0;
+// FIXME:
[webkit-changes] [159986] trunk/Source/WebCore
Title: [159986] trunk/Source/WebCore
Revision 159986
Author beid...@apple.com
Date 2013-12-02 17:27:06 -0800 (Mon, 02 Dec 2013)
Log Message
Possible crash in ProgressTracker::progressHeartbeatTimerFired(TimerProgressTracker*)
https://bugs.webkit.org/show_bug.cgi?id=125110
Reviewed by Darin Adler.
FrameLoader::loadProgressingStatusChanged() might be called while the Frame has a null FrameView.
It’s unclear how to reproduce, but there’s no harm in a null check.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (159985 => 159986)
--- trunk/Source/WebCore/ChangeLog 2013-12-03 01:12:51 UTC (rev 159985)
+++ trunk/Source/WebCore/ChangeLog 2013-12-03 01:27:06 UTC (rev 159986)
@@ -81,6 +81,20 @@
Reviewed by Darin Adler.
+FrameLoader::loadProgressingStatusChanged() might be called while the Frame has a null FrameView.
+
+It’s unclear how to reproduce, but there’s no harm in a null check.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::loadProgressingStatusChanged):
+
+2013-12-02 Brady Eidson beid...@apple.com
+
+Possible crash in ProgressTracker::progressHeartbeatTimerFired(TimerProgressTracker*)
+https://bugs.webkit.org/show_bug.cgi?id=125110
+
+Reviewed by Darin Adler.
+
It’s possible to have a null m_originatingProgressFrame when the heartbeat timer fires.
On the surface this seems impossible because the only time m_originatingProgressFrame is cleared
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (159985 => 159986)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2013-12-03 01:12:51 UTC (rev 159985)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2013-12-03 01:27:06 UTC (rev 159986)
@@ -3380,6 +3380,9 @@
void FrameLoader::loadProgressingStatusChanged()
{
FrameView* view = m_frame.mainFrame().view();
+if (!view)
+return;
+
view-updateLayerFlushThrottlingInAllFrames();
view-adjustTiledBackingCoverage();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159987] trunk/Source
Title: [159987] trunk/Source Revision 159987 Author mark@apple.com Date 2013-12-02 17:32:43 -0800 (Mon, 02 Dec 2013) Log Message Build failure when disabling JIT, YARR_JIT, and ASSEMBLER. https://bugs.webkit.org/show_bug.cgi?id=123809. Reviewed by Geoffrey Garen. Source/_javascript_Core: Also fixed build when disabling the DISASSEMBLER. Added some needed #if's and some comments. * assembler/LinkBuffer.cpp: (JSC::LinkBuffer::finalizeCodeWithDisassembly): * dfg/DFGDisassembler.cpp: * dfg/DFGDisassembler.h: (JSC::DFG::Disassembler::Disassembler): (JSC::DFG::Disassembler::setStartOfCode): (JSC::DFG::Disassembler::setForBlockIndex): (JSC::DFG::Disassembler::setForNode): (JSC::DFG::Disassembler::setEndOfMainPath): (JSC::DFG::Disassembler::setEndOfCode): (JSC::DFG::Disassembler::dump): (JSC::DFG::Disassembler::reportToProfiler): * disassembler/Disassembler.cpp: * disassembler/X86Disassembler.cpp: * jit/FPRInfo.h: * jit/GPRInfo.h: * jit/JITDisassembler.cpp: * jit/JITDisassembler.h: (JSC::JITDisassembler::JITDisassembler): (JSC::JITDisassembler::setStartOfCode): (JSC::JITDisassembler::setForBytecodeMainPath): (JSC::JITDisassembler::setForBytecodeSlowPath): (JSC::JITDisassembler::setEndOfSlowPath): (JSC::JITDisassembler::setEndOfCode): (JSC::JITDisassembler::dump): (JSC::JITDisassembler::reportToProfiler): Source/WTF: * wtf/Platform.h: - Ensure that the ASSEMBLER is enabled when the DISASSEMBLER is enabled. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp trunk/Source/_javascript_Core/dfg/DFGDisassembler.cpp trunk/Source/_javascript_Core/dfg/DFGDisassembler.h trunk/Source/_javascript_Core/disassembler/Disassembler.cpp trunk/Source/_javascript_Core/disassembler/X86Disassembler.cpp trunk/Source/_javascript_Core/jit/FPRInfo.h trunk/Source/_javascript_Core/jit/GPRInfo.h trunk/Source/_javascript_Core/jit/JITDisassembler.cpp trunk/Source/_javascript_Core/jit/JITDisassembler.h trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (159986 => 159987) --- trunk/Source/_javascript_Core/ChangeLog 2013-12-03 01:27:06 UTC (rev 159986) +++ trunk/Source/_javascript_Core/ChangeLog 2013-12-03 01:32:43 UTC (rev 159987) @@ -1,3 +1,40 @@ +2013-12-02 Mark Lam mark@apple.com + +Build failure when disabling JIT, YARR_JIT, and ASSEMBLER. +https://bugs.webkit.org/show_bug.cgi?id=123809. + +Reviewed by Geoffrey Garen. + +Also fixed build when disabling the DISASSEMBLER. +Added some needed #if's and some comments. + +* assembler/LinkBuffer.cpp: +(JSC::LinkBuffer::finalizeCodeWithDisassembly): +* dfg/DFGDisassembler.cpp: +* dfg/DFGDisassembler.h: +(JSC::DFG::Disassembler::Disassembler): +(JSC::DFG::Disassembler::setStartOfCode): +(JSC::DFG::Disassembler::setForBlockIndex): +(JSC::DFG::Disassembler::setForNode): +(JSC::DFG::Disassembler::setEndOfMainPath): +(JSC::DFG::Disassembler::setEndOfCode): +(JSC::DFG::Disassembler::dump): +(JSC::DFG::Disassembler::reportToProfiler): +* disassembler/Disassembler.cpp: +* disassembler/X86Disassembler.cpp: +* jit/FPRInfo.h: +* jit/GPRInfo.h: +* jit/JITDisassembler.cpp: +* jit/JITDisassembler.h: +(JSC::JITDisassembler::JITDisassembler): +(JSC::JITDisassembler::setStartOfCode): +(JSC::JITDisassembler::setForBytecodeMainPath): +(JSC::JITDisassembler::setForBytecodeSlowPath): +(JSC::JITDisassembler::setEndOfSlowPath): +(JSC::JITDisassembler::setEndOfCode): +(JSC::JITDisassembler::dump): +(JSC::JITDisassembler::reportToProfiler): + 2013-12-02 Filip Pizlo fpi...@apple.com Baseline JIT calls to CommonSlowPaths shouldn't restore the last result Modified: trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp (159986 => 159987) --- trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp 2013-12-03 01:27:06 UTC (rev 159986) +++ trunk/Source/_javascript_Core/assembler/LinkBuffer.cpp 2013-12-03 01:32:43 UTC (rev 159987) @@ -49,7 +49,8 @@ ASSERT(Options::showDisassembly() || Options::showDFGDisassembly()); CodeRef result = finalizeCodeWithoutDisassembly(); - + +#if ENABLE(DISASSEMBLER) dataLogF(Generated JIT code for ); va_list argList; va_start(argList, format); @@ -59,6 +60,9 @@ dataLogF(Code at [%p, %p):\n, result.code().executableAddress(), static_castchar*(result.code().executableAddress()) + result.size()); disassemble(result.code(), m_size, , WTF::dataFile()); +#else +UNUSED_PARAM(format); +#endif // ENABLE(DISASSEMBLER) return result; } Modified: trunk/Source/_javascript_Core/dfg/DFGDisassembler.cpp (159986 => 159987) --- trunk/Source/_javascript_Core/dfg/DFGDisassembler.cpp 2013-12-03 01:27:06 UTC (rev 159986) +++
[webkit-changes] [159989] trunk/Source/WebCore
Title: [159989] trunk/Source/WebCore
Revision 159989
Author akl...@apple.com
Date 2013-12-02 19:19:08 -0800 (Mon, 02 Dec 2013)
Log Message
Avoid setting style twice for generated image content.
https://webkit.org/b/125128
Take care of a FIXME I added in r158097 and avoid redundant work in
ImageContentData::createRenderer().
I changed the inheritance helper RenderImage::setPseudoStyle() into
a new createStyleInheritingFromPseudoStyle() function instead so it
can be used from both PseudoElement and ImageContentData.
Reviewed by Antti Koivisto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/PseudoElement.cpp
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebCore/rendering/RenderImage.h
trunk/Source/WebCore/rendering/style/ContentData.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (159988 => 159989)
--- trunk/Source/WebCore/ChangeLog 2013-12-03 02:36:08 UTC (rev 159988)
+++ trunk/Source/WebCore/ChangeLog 2013-12-03 03:19:08 UTC (rev 159989)
@@ -1,3 +1,17 @@
+2013-12-02 Andreas Kling akl...@apple.com
+
+Avoid setting style twice for generated image content.
+https://webkit.org/b/125128
+
+Take care of a FIXME I added in r158097 and avoid redundant work in
+ImageContentData::createRenderer().
+
+I changed the inheritance helper RenderImage::setPseudoStyle() into
+a new createStyleInheritingFromPseudoStyle() function instead so it
+can be used from both PseudoElement and ImageContentData.
+
+Reviewed by Antti Koivisto.
+
2013-12-02 Samuel White samuel_wh...@apple.com
AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
Modified: trunk/Source/WebCore/dom/PseudoElement.cpp (159988 => 159989)
--- trunk/Source/WebCore/dom/PseudoElement.cpp 2013-12-03 02:36:08 UTC (rev 159988)
+++ trunk/Source/WebCore/dom/PseudoElement.cpp 2013-12-03 03:19:08 UTC (rev 159989)
@@ -114,7 +114,7 @@
// We only manage the style for the generated content which must be images or text.
if (!child-isImage())
continue;
-toRenderImage(child)-setPseudoStyle(renderer-style());
+toRenderImage(*child).setStyle(RenderImage::createStyleInheritingFromPseudoStyle(renderer-style()));
}
}
Modified: trunk/Source/WebCore/rendering/RenderImage.cpp (159988 => 159989)
--- trunk/Source/WebCore/rendering/RenderImage.cpp 2013-12-03 02:36:08 UTC (rev 159988)
+++ trunk/Source/WebCore/rendering/RenderImage.cpp 2013-12-03 03:19:08 UTC (rev 159989)
@@ -74,17 +74,16 @@
m_imageResource-shutdown();
}
-
-void RenderImage::setPseudoStyle(PassRefPtrRenderStyle pseudoStyle)
+PassRefRenderStyle RenderImage::createStyleInheritingFromPseudoStyle(const RenderStyle pseudoStyle)
{
-ASSERT(pseudoStyle-styleType() == BEFORE || pseudoStyle-styleType() == AFTER);
+ASSERT(pseudoStyle.styleType() == BEFORE || pseudoStyle.styleType() == AFTER);
// Images are special and must inherit the pseudoStyle so the width and height of
// the pseudo element doesn't change the size of the image. In all other cases we
// can just share the style.
auto style = RenderStyle::create();
-style.get().inheritFrom(pseudoStyle.get());
-setStyle(std::move(style));
+style.get().inheritFrom(pseudoStyle);
+return style;
}
void RenderImage::setImageResource(PassOwnPtrRenderImageResource imageResource)
Modified: trunk/Source/WebCore/rendering/RenderImage.h (159988 => 159989)
--- trunk/Source/WebCore/rendering/RenderImage.h 2013-12-03 02:36:08 UTC (rev 159988)
+++ trunk/Source/WebCore/rendering/RenderImage.h 2013-12-03 03:19:08 UTC (rev 159989)
@@ -39,8 +39,8 @@
explicit RenderImage(Document, PassRefRenderStyle);
virtual ~RenderImage();
-// Set the style of the object if it's generated content.
-void setPseudoStyle(PassRefPtrRenderStyle);
+// Create a RenderStyle for generated content by inheriting from a pseudo style.
+static PassRefRenderStyle createStyleInheritingFromPseudoStyle(const RenderStyle);
void setImageResource(PassOwnPtrRenderImageResource);
Modified: trunk/Source/WebCore/rendering/style/ContentData.cpp (159988 => 159989)
--- trunk/Source/WebCore/rendering/style/ContentData.cpp 2013-12-03 02:36:08 UTC (rev 159988)
+++ trunk/Source/WebCore/rendering/style/ContentData.cpp 2013-12-03 03:19:08 UTC (rev 159989)
@@ -49,9 +49,8 @@
RenderObject* ImageContentData::createRenderer(Document document, RenderStyle pseudoStyle) const
{
-// FIXME: We should find a way to avoid setting the style twice here.
-RenderImage* image = new RenderImage(document, pseudoStyle);
-image-setPseudoStyle(pseudoStyle);
+RenderImage* image = new RenderImage(document, RenderImage::createStyleInheritingFromPseudoStyle(pseudoStyle));
+image-initializeStyle();
image-setAltText(altText());
if (m_image)
image-setImageResource(RenderImageResourceStyleImage::create(*m_image));
[webkit-changes] [159990] trunk/Tools
Title: [159990] trunk/Tools
Revision 159990
Author fpi...@apple.com
Date 2013-12-02 20:19:07 -0800 (Mon, 02 Dec 2013)
Log Message
run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
https://bugs.webkit.org/show_bug.cgi?id=125130
Reviewed by Geoffrey Garen.
* Scripts/run-jsc-stress-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
Diff
Modified: trunk/Tools/ChangeLog (159989 => 159990)
--- trunk/Tools/ChangeLog 2013-12-03 03:19:08 UTC (rev 159989)
+++ trunk/Tools/ChangeLog 2013-12-03 04:19:07 UTC (rev 159990)
@@ -1,3 +1,12 @@
+2013-12-02 Filip Pizlo fpi...@apple.com
+
+run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
+https://bugs.webkit.org/show_bug.cgi?id=125130
+
+Reviewed by Geoffrey Garen.
+
+* Scripts/run-jsc-stress-tests:
+
2013-12-02 Samuel White samuel_wh...@apple.com
AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (159989 => 159990)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2013-12-03 03:19:08 UTC (rev 159989)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2013-12-03 04:19:07 UTC (rev 159990)
@@ -810,7 +810,11 @@
prepareCollection($collectionName)
Dir.chdir($outputDir) {
-allJSFiles($collection).each {
+directoryToSearch = $collection
+if entry[tests]
+directoryToSearch += entry[tests]
+end
+allJSFiles(directoryToSearch).each {
| path |
$benchmark = path.basename
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159994] trunk/Source/WebKit2
Title: [159994] trunk/Source/WebKit2 Revision 159994 Author zandober...@gmail.com Date 2013-12-03 00:01:17 -0800 (Tue, 03 Dec 2013) Log Message Build fixes for GCC-using ports after r159965 and later https://bugs.webkit.org/show_bug.cgi?id=125136 GCC doesn't process API::ClientTraits template instantiations unless they're done inside the API namespace. * Shared/WebConnectionClient.h: * UIProcess/Notifications/WebNotificationProvider.h: * UIProcess/WebContextClient.h: * UIProcess/WebContextConnectionClient.h: * UIProcess/WebContextInjectedBundleClient.h: * UIProcess/WebCookieManagerProxyClient.h: * UIProcess/WebDatabaseManagerProxyClient.h: * UIProcess/WebDownloadClient.h: * UIProcess/WebFindClient.h: * UIProcess/WebFormClient.h: * UIProcess/WebGeolocationProvider.h: * UIProcess/WebHistoryClient.h: * UIProcess/WebIconDatabaseClient.h: * UIProcess/WebLoaderClient.h: * UIProcess/WebOriginDataManagerProxyChangeClient.h: * UIProcess/WebPageContextMenuClient.h: * UIProcess/WebPolicyClient.h: * UIProcess/WebUIClient.h: * WebProcess/InjectedBundle/InjectedBundleClient.h: * WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h: * WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h: * WebProcess/InjectedBundle/InjectedBundlePageFormClient.h: * WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h: * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h: * WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: * WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h: * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebConnectionClient.h trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationProvider.h trunk/Source/WebKit2/UIProcess/WebContextClient.h trunk/Source/WebKit2/UIProcess/WebContextConnectionClient.h trunk/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.h trunk/Source/WebKit2/UIProcess/WebCookieManagerProxyClient.h trunk/Source/WebKit2/UIProcess/WebDatabaseManagerProxyClient.h trunk/Source/WebKit2/UIProcess/WebDownloadClient.h trunk/Source/WebKit2/UIProcess/WebFindClient.h trunk/Source/WebKit2/UIProcess/WebFormClient.h trunk/Source/WebKit2/UIProcess/WebGeolocationProvider.h trunk/Source/WebKit2/UIProcess/WebHistoryClient.h trunk/Source/WebKit2/UIProcess/WebIconDatabaseClient.h trunk/Source/WebKit2/UIProcess/WebLoaderClient.h trunk/Source/WebKit2/UIProcess/WebOriginDataManagerProxyChangeClient.h trunk/Source/WebKit2/UIProcess/WebPageContextMenuClient.h trunk/Source/WebKit2/UIProcess/WebPolicyClient.h trunk/Source/WebKit2/UIProcess/WebUIClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h Diff Modified: trunk/Source/WebKit2/ChangeLog (159993 => 159994) --- trunk/Source/WebKit2/ChangeLog 2013-12-03 06:20:39 UTC (rev 159993) +++ trunk/Source/WebKit2/ChangeLog 2013-12-03 08:01:17 UTC (rev 159994) @@ -1,3 +1,40 @@ +2013-12-02 Zan Dobersek zdober...@igalia.com + +Build fixes for GCC-using ports after r159965 and later +https://bugs.webkit.org/show_bug.cgi?id=125136 + +GCC doesn't process API::ClientTraits template instantiations unless they're done +inside the API namespace. + +* Shared/WebConnectionClient.h: +* UIProcess/Notifications/WebNotificationProvider.h: +* UIProcess/WebContextClient.h: +* UIProcess/WebContextConnectionClient.h: +* UIProcess/WebContextInjectedBundleClient.h: +* UIProcess/WebCookieManagerProxyClient.h: +* UIProcess/WebDatabaseManagerProxyClient.h: +* UIProcess/WebDownloadClient.h: +* UIProcess/WebFindClient.h: +* UIProcess/WebFormClient.h: +* UIProcess/WebGeolocationProvider.h: +* UIProcess/WebHistoryClient.h: +* UIProcess/WebIconDatabaseClient.h: +* UIProcess/WebLoaderClient.h: +* UIProcess/WebOriginDataManagerProxyChangeClient.h: +* UIProcess/WebPageContextMenuClient.h: +* UIProcess/WebPolicyClient.h: +* UIProcess/WebUIClient.h: +* WebProcess/InjectedBundle/InjectedBundleClient.h: +*
