[webkit-changes] [167699] trunk/Source/WebKit2
Title: [167699] trunk/Source/WebKit2
Revision 167699
Author commit-qu...@webkit.org
Date 2014-04-22 22:59:34 -0700 (Tue, 22 Apr 2014)
Log Message
Add SPI to expose provisional URL from Frame.
https://bugs.webkit.org/show_bug.cgi?id=132014
Add methods to return the provisional URL from WKWebProcessPlugInFrame.
Patch by Yongjun Zhang yongjun_zh...@apple.com on 2014-04-22
Reviewed by Dan Bernstein.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame _provisionalURL]):
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (167698 => 167699)
--- trunk/Source/WebKit2/ChangeLog 2014-04-23 05:53:05 UTC (rev 167698)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-23 05:59:34 UTC (rev 167699)
@@ -1,3 +1,16 @@
+2014-04-22 Yongjun Zhang yongjun_zh...@apple.com
+
+Add SPI to expose provisional URL from Frame.
+https://bugs.webkit.org/show_bug.cgi?id=132014
+
+Add methods to return the provisional URL from WKWebProcessPlugInFrame.
+
+Reviewed by Dan Bernstein.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
+(-[WKWebProcessPlugInFrame _provisionalURL]):
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
+
2014-04-22 Benjamin Poulain bpoul...@apple.com
[iOS][WK2] Split iOS touch event dispatch for the regular touch event dispatch
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm (167698 => 167699)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm 2014-04-23 05:53:05 UTC (rev 167698)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm 2014-04-23 05:59:34 UTC (rev 167699)
@@ -116,6 +116,11 @@
return (NSArray *)_frame-certificateInfo().certificateChain();
}
+- (NSURL *)_provisionalURL
+{
+return [NSURL _web_URLWithWTFString:_frame-provisionalURL()];
+}
+
#pragma mark WKObject protocol implementation
- (API::Object)_apiObject
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h (167698 => 167699)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h 2014-04-23 05:53:05 UTC (rev 167698)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h 2014-04-23 05:59:34 UTC (rev 167699)
@@ -37,6 +37,7 @@
@property (nonatomic, readonly) BOOL _hasCustomContentProvider;
@property (nonatomic, readonly) NSArray *_certificateChain;
+@property (nonatomic, readonly) NSURL *_provisionalURL;
@end
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167700] trunk/Source
Title: [167700] trunk/Source
Revision 167700
Author rn...@webkit.org
Date 2014-04-22 23:11:22 -0700 (Tue, 22 Apr 2014)
Log Message
Cursor doesn't change back to pointer when leaving the Safari window
https://bugs.webkit.org/show_bug.cgi?id=132038
Reviewed by Alexey Proskuryakov.
Source/WebCore:
r147739 incorrectly added an early exit in EventHandler::selectCursor when hit test result didn't have
any node associated with it. Since we will hit this code when the cursor is outside of the WebView,
we still need to take the CURSOR_AUTO path as did the code before r147739.
No new test is added since this behavior can't be tested in DRT or WTR.
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
Source/WebKit/mac:
Since the cursor type is now updated asynchronously after r147739,
[window windowNumber] != [NSWindow windowNumberAtPoint:[NSEvent mouseLocation] belowWindowWithWindowNumber:0]
evalutes to false depending on how fast cursor is moving.
Instead, check whether the NSWindow of the WebView is the key window or not since
key window appears to control the cursor style in Cocoa as far as I've tested:
https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/WinPanel/Concepts/ChangingMainKeyWindow.html
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::setCursor):
Source/WebKit2:
Since the cursor type is now updated asynchronously after r147739,
[window windowNumber] != [NSWindow windowNumberAtPoint:[NSEvent mouseLocation] belowWindowWithWindowNumber:0]
evalutes to false depending on how fast cursor is moving.
Instead, check whether the NSWindow of the WebView is the key window or not since
key window appears to control the cursor style in Cocoa as far as I've tested:
https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/WinPanel/Concepts/ChangingMainKeyWindow.html
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setCursor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (167699 => 167700)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 05:59:34 UTC (rev 167699)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 06:11:22 UTC (rev 167700)
@@ -1,3 +1,19 @@
+2014-04-22 Ryosuke Niwa rn...@webkit.org
+
+Cursor doesn't change back to pointer when leaving the Safari window
+https://bugs.webkit.org/show_bug.cgi?id=132038
+
+Reviewed by Alexey Proskuryakov.
+
+r147739 incorrectly added an early exit in EventHandler::selectCursor when hit test result didn't have
+any node associated with it. Since we will hit this code when the cursor is outside of the WebView,
+we still need to take the CURSOR_AUTO path as did the code before r147739.
+
+No new test is added since this behavior can't be tested in DRT or WTR.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::selectCursor):
+
2014-04-22 Zalan Bujtas za...@apple.com
Do not paint border image when the border rect is empty.
Modified: trunk/Source/WebCore/page/EventHandler.cpp (167699 => 167700)
--- trunk/Source/WebCore/page/EventHandler.cpp 2014-04-23 05:59:34 UTC (rev 167699)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2014-04-23 06:11:22 UTC (rev 167700)
@@ -1311,10 +1311,7 @@
#endif
Node* node = result.targetNode();
-if (!node)
-return NoCursorChange;
-
-auto renderer = node-renderer();
+auto renderer = node ? node-renderer() : 0;
RenderStyle* style = renderer ? renderer-style() : nullptr;
bool horizontalText = !style || style-isHorizontalWritingMode();
const Cursor iBeam = horizontalText ? iBeamCursor() : verticalTextCursor();
@@ -1386,7 +1383,7 @@
switch (style ? style-cursor() : CURSOR_AUTO) {
case CURSOR_AUTO: {
-bool editable = node-hasEditableStyle();
+bool editable = node node-hasEditableStyle();
if (useHandCursor(node, result.isOverLink(), shiftKey))
return handCursor();
Modified: trunk/Source/WebKit/mac/ChangeLog (167699 => 167700)
--- trunk/Source/WebKit/mac/ChangeLog 2014-04-23 05:59:34 UTC (rev 167699)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-04-23 06:11:22 UTC (rev 167700)
@@ -1,3 +1,21 @@
+2014-04-22 Ryosuke Niwa rn...@webkit.org
+
+Cursor doesn't change back to pointer when leaving the Safari window
+https://bugs.webkit.org/show_bug.cgi?id=132038
+
+Reviewed by Alexey Proskuryakov.
+
+Since the cursor type is now updated asynchronously after r147739,
+[window windowNumber] != [NSWindow windowNumberAtPoint:[NSEvent mouseLocation] belowWindowWithWindowNumber:0]
+evalutes to false depending on how fast cursor is moving.
+
+Instead, check whether the NSWindow of the WebView
[webkit-changes] [167702] trunk/Tools
Title: [167702] trunk/Tools
Revision 167702
Author commit-qu...@webkit.org
Date 2014-04-23 02:39:51 -0700 (Wed, 23 Apr 2014)
Log Message
[GTK] run-webkit-tests script is failing to invoke run-launcher
https://bugs.webkit.org/show_bug.cgi?id=132051
Patch by Lorenzo Tilve lti...@igalia.com on 2014-04-23
Reviewed by Philippe Normand.
After the WK1 support was dropped, if run-webkit-tests is executed
without --no-show-results parameter, the launcher is being called
using a -2 parameter that is it causing the run-launcher to break.
* Scripts/webkitpy/port/gtk.py:
(GtkPort.show_results_html_file):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/gtk.py
Diff
Modified: trunk/Tools/ChangeLog (167701 => 167702)
--- trunk/Tools/ChangeLog 2014-04-23 07:34:01 UTC (rev 167701)
+++ trunk/Tools/ChangeLog 2014-04-23 09:39:51 UTC (rev 167702)
@@ -1,3 +1,17 @@
+2014-04-23 Lorenzo Tilve lti...@igalia.com
+
+[GTK] run-webkit-tests script is failing to invoke run-launcher
+https://bugs.webkit.org/show_bug.cgi?id=132051
+
+Reviewed by Philippe Normand.
+
+After the WK1 support was dropped, if run-webkit-tests is executed
+without --no-show-results parameter, the launcher is being called
+using a -2 parameter that is it causing the run-launcher to break.
+
+* Scripts/webkitpy/port/gtk.py:
+(GtkPort.show_results_html_file):
+
2014-04-22 Tim Horton timothy_hor...@apple.com
DumpRenderTree generates black snapshots on some platforms
Modified: trunk/Tools/Scripts/webkitpy/port/gtk.py (167701 => 167702)
--- trunk/Tools/Scripts/webkitpy/port/gtk.py 2014-04-23 07:34:01 UTC (rev 167701)
+++ trunk/Tools/Scripts/webkitpy/port/gtk.py 2014-04-23 09:39:51 UTC (rev 167702)
@@ -184,8 +184,6 @@
# or teach run-launcher how to call run-safari and move this down to Port.
def show_results_html_file(self, results_filename):
run_launcher_args = [file://%s % results_filename]
-if self.get_option('webkit_test_runner'):
-run_launcher_args.append('-2')
# FIXME: old-run-webkit-tests also added [-graphicssystem, raster, -style, windows]
# FIXME: old-run-webkit-tests converted results_filename path for cygwin.
self._run_script(run-launcher, run_launcher_args)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167703] trunk/LayoutTests
Title: [167703] trunk/LayoutTests Revision 167703 Author commit-qu...@webkit.org Date 2014-04-23 04:11:47 -0700 (Wed, 23 Apr 2014) Log Message [EFL] Add expectations of new added tests. https://bugs.webkit.org/show_bug.cgi?id=132052 Unreviewed EFL gardening. Patch by Krzysztof Wolanski k.wolan...@samsung.com on 2014-04-23 * platform/efl-wk2/TestExpectations: * platform/efl/fast/repaint/spanner-with-margin-expected.txt: Added. Rebaseline after r167439 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations Added Paths trunk/LayoutTests/platform/efl/fast/repaint/spanner-with-margin-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (167702 => 167703) --- trunk/LayoutTests/ChangeLog 2014-04-23 09:39:51 UTC (rev 167702) +++ trunk/LayoutTests/ChangeLog 2014-04-23 11:11:47 UTC (rev 167703) @@ -1,3 +1,13 @@ +2014-04-23 Krzysztof Wolanski k.wolan...@samsung.com + +[EFL] Add expectations of new added tests. +https://bugs.webkit.org/show_bug.cgi?id=132052 + +Unreviewed EFL gardening. + +* platform/efl-wk2/TestExpectations: +* platform/efl/fast/repaint/spanner-with-margin-expected.txt: Added. Rebaseline after r167439 + 2014-04-22 Grzegorz Czajkowski g.czajkow...@samsung.com Refactoring editing/selection/13804.html Added: trunk/LayoutTests/platform/efl/fast/repaint/spanner-with-margin-expected.txt (0 => 167703) --- trunk/LayoutTests/platform/efl/fast/repaint/spanner-with-margin-expected.txt (rev 0) +++ trunk/LayoutTests/platform/efl/fast/repaint/spanner-with-margin-expected.txt 2014-04-23 11:11:47 UTC (rev 167703) @@ -0,0 +1,25 @@ +You should see the word 'PASS' five times below (letter spacing will differ), and no red: + +P +P +A +A +S +S +S +S +PASS + +P +P +A +A +S +S +S +S +(repaint rects + (rect 104 334 18 36) + (rect 104 334 18 36) +) + Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (167702 => 167703) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-04-23 09:39:51 UTC (rev 167702) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-04-23 11:11:47 UTC (rev 167703) @@ -529,8 +529,6 @@ webkit.org/b/129731 css3/masking/clip-path-filter.html [ ImageOnlyFailure ] -webkit.org/b/129733 fast/borders/hidpi-simple-hairline-border-painting.html [ ImageOnlyFailure ] - webkit.org/b/129734 fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales.html [ ImageOnlyFailure ] webkit.org/b/129735 fast/regions/box-decorations-over-region-padding.html [ ImageOnlyFailure ] @@ -554,3 +552,17 @@ webkit.org/b/130020 webaudio/codec-tests/wav/24bit-22khz-resample.html [ Failure ] webkit.org/b/130340 fast/css/cascade/box-shadow-and-webkit-box-shadow-cascade-order.html [ ImageOnlyFailure ] + +webkit.org/b/131496 accessibility/help-text.html [ Failure ] + +# Need HighDPI support +webkit.org/b/131987 fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position.html [ ImageOnlyFailure ] +webkit.org/b/131987 fast/borders/hidpi-border-image-gradient-on-subpixels.html [ ImageOnlyFailure ] +webkit.org/b/131987 fast/borders/hidpi-rounded-border-on-subpixel-position.html [ ImageOnlyFailure ] +webkit.org/b/129733 fast/borders/hidpi-simple-hairline-border-painting.html [ ImageOnlyFailure ] +webkit.org/b/131987 fast/layers/hidpi-box-positioned-off-by-one-when-transform-is-present.html [ ImageOnlyFailure ] +webkit.org/b/131987 fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html [ Failure ] + +webkit.org/b/131377 fast/repaint/blend-mode-isolate-stacking-context.html [ Failure Timeout ] + +webkit.org/b/132049 fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167705] trunk/Source/WebCore
Title: [167705] trunk/Source/WebCore
Revision 167705
Author abu...@adobe.com
Date 2014-04-23 05:30:22 -0700 (Wed, 23 Apr 2014)
Log Message
[CSS Regions] Improve the debugging infrastructure
https://bugs.webkit.org/show_bug.cgi?id=132042
Reviewed by Mihnea Ovidenie.
This patch improves the debugging code for CSS Regions.
Tests: No function change. No new tests.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::showRegionsInformation): Print brackets around the region range when dumping
the render tree to the console.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::containingRegion): Convert the ASSERT to an ASSERT_WITH_SECURITY_IMPLICATION.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RootInlineBox.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (167704 => 167705)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 11:19:36 UTC (rev 167704)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 12:30:22 UTC (rev 167705)
@@ -1,3 +1,20 @@
+2014-04-23 Andrei Bucur abu...@adobe.com
+
+[CSS Regions] Improve the debugging infrastructure
+https://bugs.webkit.org/show_bug.cgi?id=132042
+
+Reviewed by Mihnea Ovidenie.
+
+This patch improves the debugging code for CSS Regions.
+
+Tests: No function change. No new tests.
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::showRegionsInformation): Print brackets around the region range when dumping
+the render tree to the console.
+* rendering/RootInlineBox.cpp:
+(WebCore::RootInlineBox::containingRegion): Convert the ASSERT to an ASSERT_WITH_SECURITY_IMPLICATION.
+
2014-04-22 Ryosuke Niwa rn...@webkit.org
Cursor doesn't change back to pointer when leaving the Safari window
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (167704 => 167705)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2014-04-23 11:19:36 UTC (rev 167704)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2014-04-23 12:30:22 UTC (rev 167705)
@@ -1426,7 +1426,7 @@
RenderRegion* startRegion = nullptr;
RenderRegion* endRegion = nullptr;
flowThread-getRegionRangeForBox(box, startRegion, endRegion);
-printedCharacters += fprintf(stderr, Rs:%p Re:%p, startRegion, endRegion);
+printedCharacters += fprintf(stderr, [Rs:%p Re:%p], startRegion, endRegion);
}
}
}
Modified: trunk/Source/WebCore/rendering/RootInlineBox.cpp (167704 => 167705)
--- trunk/Source/WebCore/rendering/RootInlineBox.cpp 2014-04-23 11:19:36 UTC (rev 167704)
+++ trunk/Source/WebCore/rendering/RootInlineBox.cpp 2014-04-23 12:30:22 UTC (rev 167705)
@@ -218,14 +218,17 @@
RenderRegion* RootInlineBox::containingRegion() const
{
+RenderRegion* region = m_hasContainingRegion ? containingRegionMap().get(this) : nullptr;
+
#ifndef NDEBUG
if (m_hasContainingRegion) {
RenderFlowThread* flowThread = blockFlow().flowThreadContainingBlock();
const RenderRegionList regionList = flowThread-renderRegionList();
-ASSERT(regionList.contains(containingRegionMap().get(this)));
+ASSERT_WITH_SECURITY_IMPLICATION(regionList.contains(region));
}
#endif
-return m_hasContainingRegion ? containingRegionMap().get(this) : nullptr;
+
+return region;
}
void RootInlineBox::clearContainingRegion()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167706] trunk
Title: [167706] trunk
Revision 167706
Author commit-qu...@webkit.org
Date 2014-04-23 06:32:56 -0700 (Wed, 23 Apr 2014)
Log Message
Overflow propagation broken in BTT and RTL writing-modes
https://bugs.webkit.org/show_bug.cgi?id=113781
Patch by Morten Stenshorne msten...@opera.com on 2014-04-23
Reviewed by David Hyatt.
Source/WebCore:
Overflow rectangles are not quite physical, not quite logical. This
means that we cannot use clientBoxRect() directly to represent a
rectangle that expresses exactly no overflow. This rectangle is the
padding box (relative to the border box) in vertical-lr and
horizontal-tb, but the block-direction borders need to be flipped in
vertical-rl and horizontal-bt.
Tests: fast/css/overflow-btt-border-after.html
fast/css/overflow-rtl-border-after.html
* WebCore.exp.in:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
* rendering/RenderBox.h:
(WebCore::RenderBox::layoutOverflowRect):
LayoutTests:
* fast/css/overflow-btt-border-after-expected.txt: Added.
* fast/css/overflow-btt-border-after.html: Added.
* fast/css/overflow-rtl-border-after-expected.txt: Added.
* fast/css/overflow-rtl-border-after.html: Added.
* fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
* platform/gtk/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
* platform/mac/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
Removed incorrect screenshots that now differ from the actual (correct) rendering.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
Added Paths
trunk/LayoutTests/fast/css/overflow-btt-border-after-expected.txt
trunk/LayoutTests/fast/css/overflow-btt-border-after.html
trunk/LayoutTests/fast/css/overflow-rtl-border-after-expected.txt
trunk/LayoutTests/fast/css/overflow-rtl-border-after.html
Removed Paths
trunk/LayoutTests/fast/multicol/vertical-rl/rules-with-border-before-expected.png
trunk/LayoutTests/platform/gtk/fast/multicol/vertical-rl/rules-with-border-before-expected.png
trunk/LayoutTests/platform/mac/fast/multicol/vertical-rl/rules-with-border-before-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (167705 => 167706)
--- trunk/LayoutTests/ChangeLog 2014-04-23 12:30:22 UTC (rev 167705)
+++ trunk/LayoutTests/ChangeLog 2014-04-23 13:32:56 UTC (rev 167706)
@@ -1,3 +1,19 @@
+2014-04-23 Morten Stenshorne msten...@opera.com
+
+Overflow propagation broken in BTT and RTL writing-modes
+https://bugs.webkit.org/show_bug.cgi?id=113781
+
+Reviewed by David Hyatt.
+
+* fast/css/overflow-btt-border-after-expected.txt: Added.
+* fast/css/overflow-btt-border-after.html: Added.
+* fast/css/overflow-rtl-border-after-expected.txt: Added.
+* fast/css/overflow-rtl-border-after.html: Added.
+* fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
+* platform/gtk/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
+* platform/mac/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
+Removed incorrect screenshots that now differ from the actual (correct) rendering.
+
2014-04-23 Ryuan Choi ryuan.c...@samsung.com
Unreviewed EFL gardening.
Added: trunk/LayoutTests/fast/css/overflow-btt-border-after-expected.txt (0 => 167706)
--- trunk/LayoutTests/fast/css/overflow-btt-border-after-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/overflow-btt-border-after-expected.txt 2014-04-23 13:32:56 UTC (rev 167706)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/fast/css/overflow-btt-border-after.html (0 => 167706)
--- trunk/LayoutTests/fast/css/overflow-btt-border-after.html (rev 0)
+++ trunk/LayoutTests/fast/css/overflow-btt-border-after.html 2014-04-23 13:32:56 UTC (rev 167706)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+ head
+titleBorder-after in horizontal-bt mode, non-visible overflow/title
+style
+ body { color:black; background:white; }
+ #container {
+-webkit-writing-mode: horizontal-bt;
+overflow:hidden;
+-webkit-logical-height:100px;
+-webkit-border-after:150px solid white;
+background:red;
+ }
+ #inner { -webkit-logical-height:200px; background:white; }
+/style
+script
+ if (window.testRunner)
+testRunner.dumpAsText();
+/script
+ /head
+ body
+pThe word 'HEST' should be seen below, and there should be no red./p
+div id=container
+ div id=innerHEST/div
+/div
+script
+ if (window.testRunner) {
+var
[webkit-changes] [167707] trunk
Title: [167707] trunk Revision 167707 Author commit-qu...@webkit.org Date 2014-04-23 06:36:30 -0700 (Wed, 23 Apr 2014) Log Message [New Multicolumn] fast/multicol/overflow-content.html displays red https://bugs.webkit.org/show_bug.cgi?id=131809 Patch by Morten Stenshorne msten...@opera.com on 2014-04-23 Reviewed by David Hyatt. Source/WebCore: Insert a break at end of content on our own in the multicol code, to make sure that overflow is accounted for, and also to make sure that we account for all content in non-final sets (i.e. those preceding spanners). In other words, this will additionally fix balancing issues in sets preceding a spanner. Added a test for that. Tests: fast/multicol/break-in-columns-before-spanner.html fast/multicol/newmulticol/compare-with-old-impl/overflow-content.html * rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::regionInRange): Deleted. * rendering/RenderFlowThread.h: * rendering/RenderMultiColumnSet.cpp: (WebCore::RenderMultiColumnSet::distributeImplicitBreaks): * rendering/RenderNamedFlowThread.cpp: (WebCore::RenderNamedFlowThread::applyBreakAfterContent): * rendering/RenderNamedFlowThread.h: LayoutTests: * fast/multicol/break-in-columns-before-spanner-expected.html: Added. * fast/multicol/break-in-columns-before-spanner.html: Added. * fast/multicol/newmulticol/compare-with-old-impl/overflow-content-expected.html: Added. * fast/multicol/newmulticol/compare-with-old-impl/overflow-content.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderFlowThread.cpp trunk/Source/WebCore/rendering/RenderFlowThread.h trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp trunk/Source/WebCore/rendering/RenderNamedFlowThread.h Added Paths trunk/LayoutTests/fast/multicol/break-in-columns-before-spanner-expected.html trunk/LayoutTests/fast/multicol/break-in-columns-before-spanner.html trunk/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/overflow-content-expected.html trunk/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/overflow-content.html Diff Modified: trunk/LayoutTests/ChangeLog (167706 => 167707) --- trunk/LayoutTests/ChangeLog 2014-04-23 13:32:56 UTC (rev 167706) +++ trunk/LayoutTests/ChangeLog 2014-04-23 13:36:30 UTC (rev 167707) @@ -1,5 +1,17 @@ 2014-04-23 Morten Stenshorne msten...@opera.com +[New Multicolumn] fast/multicol/overflow-content.html displays red +https://bugs.webkit.org/show_bug.cgi?id=131809 + +Reviewed by David Hyatt. + +* fast/multicol/break-in-columns-before-spanner-expected.html: Added. +* fast/multicol/break-in-columns-before-spanner.html: Added. +* fast/multicol/newmulticol/compare-with-old-impl/overflow-content-expected.html: Added. +* fast/multicol/newmulticol/compare-with-old-impl/overflow-content.html: Added. + +2014-04-23 Morten Stenshorne msten...@opera.com + Overflow propagation broken in BTT and RTL writing-modes https://bugs.webkit.org/show_bug.cgi?id=113781 Added: trunk/LayoutTests/fast/multicol/break-in-columns-before-spanner-expected.html (0 => 167707) --- trunk/LayoutTests/fast/multicol/break-in-columns-before-spanner-expected.html (rev 0) +++ trunk/LayoutTests/fast/multicol/break-in-columns-before-spanner-expected.html 2014-04-23 13:36:30 UTC (rev 167707) @@ -0,0 +1,10 @@ +!DOCTYPE html +script +if (window.internals) +internals.settings.setRegionBasedColumnsEnabled(true); +/script +pThere should be a blue emsquare/em below./p +div style=-webkit-columns:3; columns:3; -webkit-column-gap:0; column-gap:0; column-fill:auto; width:300px; height:200px; +nbsp; +div style=-webkit-column-break-before:always; break-before:column; height:400px; background:blue;/div +/div Added: trunk/LayoutTests/fast/multicol/break-in-columns-before-spanner.html (0 => 167707) --- trunk/LayoutTests/fast/multicol/break-in-columns-before-spanner.html (rev 0) +++ trunk/LayoutTests/fast/multicol/break-in-columns-before-spanner.html 2014-04-23 13:36:30 UTC (rev 167707) @@ -0,0 +1,11 @@ +!DOCTYPE html +script +if (window.internals) +internals.settings.setRegionBasedColumnsEnabled(true); +/script +pThere should be a blue emsquare/em below./p +div style=-webkit-columns:3; columns:3; -webkit-column-gap:0; column-gap:0; width:300px; +nbsp; +div style=-webkit-column-break-before:always; break-before:column; height:400px; background:blue;/div +div style=-webkit-column-span:all; column-span:all;nbsp;/div +/div Added: trunk/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/overflow-content-expected.html (0 => 167707) --- trunk/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/overflow-content-expected.html (rev 0) +++
[webkit-changes] [167708] trunk
Title: [167708] trunk
Revision 167708
Author commit-qu...@webkit.org
Date 2014-04-23 06:43:12 -0700 (Wed, 23 Apr 2014)
Log Message
[GTK] ShadowRoot API was removed in r164131
https://bugs.webkit.org/show_bug.cgi?id=132059
Source/WebCore:
Patch by Philippe Normand pnorm...@igalia.com on 2014-04-23
Reviewed by Gustavo Noronha Silva.
Add ShadowRoot removed API to WebKitDOMDeprecated to keep API/ABI compatibility.
* bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_shadow_root_class_init):
(webkit_dom_shadow_root_init):
(webkit_dom_shadow_root_element_from_point):
(webkit_dom_shadow_root_get_active_element):
(webkit_dom_shadow_root_get_apply_author_styles):
(webkit_dom_shadow_root_get_element_by_id):
(webkit_dom_shadow_root_get_elements_by_class_name):
(webkit_dom_shadow_root_get_elements_by_tag_name):
(webkit_dom_shadow_root_get_elements_by_tag_name_ns):
(webkit_dom_shadow_root_get_inner_html):
(webkit_dom_shadow_root_get_reset_style_inheritance):
(webkit_dom_shadow_root_get_selection):
(webkit_dom_shadow_root_set_apply_author_styles):
(webkit_dom_shadow_root_set_inner_html):
(webkit_dom_shadow_root_set_reset_style_inheritance):
* bindings/gobject/WebKitDOMDeprecated.h:
* bindings/gobject/WebKitDOMDeprecated.symbols:
Tools:
Patch by Carlos Garcia Campos cgar...@igalia.com on 2014-04-23
Reviewed by Gustavo Noronha Silva.
Add WebKitDOMShadowRoot to the list of deleted classes to generate
the API docs.
* gtk/webkitdom.py:
(WebKitDOMDocGenerator):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp
trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h
trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols
trunk/Tools/ChangeLog
trunk/Tools/gtk/webkitdom.py
Diff
Modified: trunk/Source/WebCore/ChangeLog (167707 => 167708)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 13:36:30 UTC (rev 167707)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 13:43:12 UTC (rev 167708)
@@ -1,3 +1,31 @@
+2014-04-23 Philippe Normand pnorm...@igalia.com
+
+[GTK] ShadowRoot API was removed in r164131
+https://bugs.webkit.org/show_bug.cgi?id=132059
+
+Reviewed by Gustavo Noronha Silva.
+
+Add ShadowRoot removed API to WebKitDOMDeprecated to keep API/ABI compatibility.
+
+* bindings/gobject/WebKitDOMDeprecated.cpp:
+(webkit_dom_shadow_root_class_init):
+(webkit_dom_shadow_root_init):
+(webkit_dom_shadow_root_element_from_point):
+(webkit_dom_shadow_root_get_active_element):
+(webkit_dom_shadow_root_get_apply_author_styles):
+(webkit_dom_shadow_root_get_element_by_id):
+(webkit_dom_shadow_root_get_elements_by_class_name):
+(webkit_dom_shadow_root_get_elements_by_tag_name):
+(webkit_dom_shadow_root_get_elements_by_tag_name_ns):
+(webkit_dom_shadow_root_get_inner_html):
+(webkit_dom_shadow_root_get_reset_style_inheritance):
+(webkit_dom_shadow_root_get_selection):
+(webkit_dom_shadow_root_set_apply_author_styles):
+(webkit_dom_shadow_root_set_inner_html):
+(webkit_dom_shadow_root_set_reset_style_inheritance):
+* bindings/gobject/WebKitDOMDeprecated.h:
+* bindings/gobject/WebKitDOMDeprecated.symbols:
+
2014-04-23 Morten Stenshorne msten...@opera.com
[New Multicolumn] fast/multicol/overflow-content.html displays red
Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (167707 => 167708)
--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2014-04-23 13:36:30 UTC (rev 167707)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2014-04-23 13:43:12 UTC (rev 167708)
@@ -552,3 +552,97 @@
g_warning(%s: this functionality has been removed from WebKit, this function does nothing., __func__);
}
+// WebKitDOMShadowRoot
+
+typedef struct _WebKitDOMShadowRoot {
+WebKitDOMObject parent_instance;
+} WebKitDOMShadowRoot;
+
+typedef struct _WebKitDOMShadowRootClass {
+WebKitDOMObjectClass parent_class;
+} WebKitDOMShadowRootClass;
+
+G_DEFINE_TYPE(WebKitDOMShadowRoot, webkit_dom_shadow_root, WEBKIT_TYPE_DOM_OBJECT)
+
+static void webkit_dom_shadow_root_class_init(WebKitDOMShadowRootClass*)
+{
+}
+
+static void webkit_dom_shadow_root_init(WebKitDOMShadowRoot*)
+{
+}
+
+WebKitDOMElement* webkit_dom_shadow_root_element_from_point(WebKitDOMShadowRoot*, glong, glong)
+{
+g_warning(%s: Access to the DOM Shadow Root has been removed from WebKit, this function does nothing., __func__);
+return 0;
+}
+
+WebKitDOMElement* webkit_dom_shadow_root_get_active_element(WebKitDOMShadowRoot*)
+{
+g_warning(%s: Access to the DOM Shadow Root has been removed from WebKit, this function does nothing., __func__);
+return 0;
+}
+
+gboolean webkit_dom_shadow_root_get_apply_author_styles(WebKitDOMShadowRoot*)
+{
+g_warning(%s: Access to the DOM Shadow Root has been removed from WebKit, this function does nothing.,
[webkit-changes] [167709] trunk/Source/JavaScriptCore
Title: [167709] trunk/Source/_javascript_Core
Revision 167709
Author mr...@apple.com
Date 2014-04-23 07:39:46 -0700 (Wed, 23 Apr 2014)
Log Message
[Mac] REGRESSION (r164823): Building _javascript_Core creates files under /tmp/_javascript_Core.dst
https://webkit.org/b/132053
Reviewed by Dan Bernstein.
* _javascript_Core.xcodeproj/project.pbxproj: Don't try to create a symlink at /usr/local/bin/jsc inside
the DSTROOT unless we're building to the deployment location. Also remove the unnecessary -x argument
from /bin/sh since that generates unnecessary output.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (167708 => 167709)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-23 13:43:12 UTC (rev 167708)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-23 14:39:46 UTC (rev 167709)
@@ -1,3 +1,14 @@
+2014-04-23 Mark Rowe mr...@apple.com
+
+[Mac] REGRESSION (r164823): Building _javascript_Core creates files under /tmp/_javascript_Core.dst
+https://webkit.org/b/132053
+
+Reviewed by Dan Bernstein.
+
+* _javascript_Core.xcodeproj/project.pbxproj: Don't try to create a symlink at /usr/local/bin/jsc inside
+the DSTROOT unless we're building to the deployment location. Also remove the unnecessary -x argument
+from /bin/sh since that generates unnecessary output.
+
2014-04-22 Mark Lam mark@apple.com
DFG::Worklist should acquire the m_lock before iterating DFG plans.
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (167708 => 167709)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2014-04-23 13:43:12 UTC (rev 167708)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2014-04-23 14:39:46 UTC (rev 167709)
@@ -6660,8 +6660,8 @@
outputPaths = (
$(DSTROOT)$(INSTALL_PATH_PREFIX)/usr/local/bin/jsc,
);
- runOnlyForDeploymentPostprocessing = 0;
- shellPath = /bin/sh -x;
+ runOnlyForDeploymentPostprocessing = 1;
+ shellPath = /bin/sh;
shellScript = if [[ \${SKIP_INSTALL}\ == \NO\ ]]; then\nmkdir -p \${DSTROOT}${INSTALL_PATH_PREFIX}/usr/local/bin\\ncd \${DSTROOT}${INSTALL_PATH_PREFIX}/usr/local/bin\\nif [ -L jsc ]; then\nrm -f jsc\nfi\nln -s \../../..${INSTALL_PATH_ACTUAL}/jsc\ jsc\nexit\nfi\n;
};
5DAFD6CD146B6B6E00FBEFB4 /* Install Support Script */ = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167710] trunk/LayoutTests
Title: [167710] trunk/LayoutTests Revision 167710 Author commit-qu...@webkit.org Date 2014-04-23 08:38:31 -0700 (Wed, 23 Apr 2014) Log Message [GTK] Unreviewed GTK gardening https://bugs.webkit.org/show_bug.cgi?id=132058 Patch by Lorenzo Tilve lti...@igalia.com on 2014-04-23 * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (167709 => 167710) --- trunk/LayoutTests/ChangeLog 2014-04-23 14:39:46 UTC (rev 167709) +++ trunk/LayoutTests/ChangeLog 2014-04-23 15:38:31 UTC (rev 167710) @@ -1,3 +1,10 @@ +2014-04-23 Lorenzo Tilve lti...@igalia.com + +[GTK] Unreviewed GTK gardening +https://bugs.webkit.org/show_bug.cgi?id=132058 + +* platform/gtk/TestExpectations: + 2014-04-23 Morten Stenshorne msten...@opera.com [New Multicolumn] fast/multicol/overflow-content.html displays red Modified: trunk/LayoutTests/platform/gtk/TestExpectations (167709 => 167710) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-23 14:39:46 UTC (rev 167709) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-23 15:38:31 UTC (rev 167710) @@ -1827,6 +1827,14 @@ webkit.org/b/130971 media/track/track-remove-track.html [ Failure Timeout ] +webkit.org/b/132046 svg/css/svg-resource-fragment-identifier-img-src.html [ ImageOnlyFailure ] + +webkit.org/b/132054 js/dom/global-constructors-attributes.html [ Failure ] + +webkit.org/b/132055 media/track/track-datacue.html [ Timeout ] + +webkit.org/b/132056 webaudio/codec-tests/mp3/128kbps-44khz.html [ Failure ] + # # End of Tests failing # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167711] trunk/Source/WebCore
Title: [167711] trunk/Source/WebCore
Revision 167711
Author akl...@apple.com
Date 2014-04-23 09:19:24 -0700 (Wed, 23 Apr 2014)
Log Message
[iOS WebKit1] MemoryPressureHandler::respondToMemoryPressure called on wrong thread.
https://webkit.org/b/132041
rdar://problem/16687238
Always dispatch the memory pressure relief code on the main queue.
This is really only needed for iOS/WK1, but we might as well share the code.
Reviewed by Michael Saboff.
* platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (167710 => 167711)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 15:38:31 UTC (rev 167710)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 16:19:24 UTC (rev 167711)
@@ -1,3 +1,17 @@
+2014-04-22 Andreas Kling akl...@apple.com
+
+[iOS WebKit1] MemoryPressureHandler::respondToMemoryPressure called on wrong thread.
+https://webkit.org/b/132041
+rdar://problem/16687238
+
+Always dispatch the memory pressure relief code on the main queue.
+This is really only needed for iOS/WK1, but we might as well share the code.
+
+Reviewed by Michael Saboff.
+
+* platform/cocoa/MemoryPressureHandlerCocoa.mm:
+(WebCore::MemoryPressureHandler::install):
+
2014-04-23 Philippe Normand pnorm...@igalia.com
[GTK] ShadowRoot API was removed in r164131
Modified: trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm (167710 => 167711)
--- trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm 2014-04-23 15:38:31 UTC (rev 167710)
+++ trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm 2014-04-23 16:19:24 UTC (rev 167711)
@@ -90,7 +90,9 @@
if (_cache_event_source) {
dispatch_set_context(_cache_event_source, this);
dispatch_source_set_event_handler(_cache_event_source, ^{
-memoryPressureHandler().respondToMemoryPressure();
+dispatch_async(dispatch_get_main_queue(), ^{
+memoryPressureHandler().respondToMemoryPressure();
+});
});
dispatch_resume(_cache_event_source);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167714] trunk/Source/WebCore
Title: [167714] trunk/Source/WebCore Revision 167714 Author hy...@apple.com Date 2014-04-23 11:05:33 -0700 (Wed, 23 Apr 2014) Log Message [New Multicolumn] Nested columns not working at all. https://bugs.webkit.org/show_bug.cgi?id=131805 Reviewed by Dean Jackson. Add support for nested pagination contexts, allowing for an arbitrary level of nesting of multicolumn layouts. There were a number of things that had to be patched in order for this to work. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::regionAtBlockOffset): Make sure RenderMultiColumnFlowThreads just return null for regions at any block offset. Individual region sets will be created as you cross ancestor regions eventually, so this is just getting in the way. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::enclosingPaginationLayerInSubtree): Add a new helper method for obtaining an enclosingPaginationLayer when constrained by some root. This function ensures you don't accidentally cross your subtree root when looking for enclosing pagination layers. (WebCore::RenderLayer::collectFragments): Patch collectFragments to know how to recur to collect ancestor fragments in order to apply nested splitting as you cross pagination boundaries. (WebCore::RenderLayer::updatePaintingInfoForFragments): (WebCore::RenderLayer::calculateClipRects): * rendering/RenderLayer.h: (WebCore::LayerFragment::LayerFragment): (WebCore::LayerFragment::setRects): (WebCore::LayerFragment::moveBy): (WebCore::LayerFragment::intersect): Improve the LayerFragment so that it caches transformed bounding boxes as well. This is needed to fix intersectsDamageRect so that it doesn't grab the wrong bounding box when checking inline layers that are paginated. * rendering/RenderMultiColumnFlowThread.cpp: (WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted): Ignore inserted flow threads inside an ancestor flow thread, since we only care about what the sets do. * rendering/RenderObject.cpp: (WebCore::RenderObject::insertedIntoTree): Make sure that nested flow thread layers return themselves when a child is inserted directly under them. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp trunk/Source/WebCore/rendering/RenderObject.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (167713 => 167714) --- trunk/Source/WebCore/ChangeLog 2014-04-23 17:49:40 UTC (rev 167713) +++ trunk/Source/WebCore/ChangeLog 2014-04-23 18:05:33 UTC (rev 167714) @@ -1,3 +1,51 @@ +2014-04-22 David Hyatt hy...@apple.com + +[New Multicolumn] Nested columns not working at all. +https://bugs.webkit.org/show_bug.cgi?id=131805 + +Reviewed by Dean Jackson. + +Add support for nested pagination contexts, allowing for an arbitrary level +of nesting of multicolumn layouts. There were a number of things that had to +be patched in order for this to work. + +* rendering/RenderBlock.cpp: +(WebCore::RenderBlock::regionAtBlockOffset): +Make sure RenderMultiColumnFlowThreads just return null for regions at any +block offset. Individual region sets will be created as you cross ancestor +regions eventually, so this is just getting in the way. + +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::enclosingPaginationLayerInSubtree): +Add a new helper method for obtaining an enclosingPaginationLayer when +constrained by some root. This function ensures you don't accidentally +cross your subtree root when looking for enclosing pagination layers. + +(WebCore::RenderLayer::collectFragments): +Patch collectFragments to know how to recur to collect ancestor fragments +in order to apply nested splitting as you cross pagination boundaries. + +(WebCore::RenderLayer::updatePaintingInfoForFragments): +(WebCore::RenderLayer::calculateClipRects): +* rendering/RenderLayer.h: +(WebCore::LayerFragment::LayerFragment): +(WebCore::LayerFragment::setRects): +(WebCore::LayerFragment::moveBy): +(WebCore::LayerFragment::intersect): +Improve the LayerFragment so that it caches transformed bounding boxes as +well. This is needed to fix intersectsDamageRect so that it doesn't grab +the wrong bounding box when checking inline layers that are paginated. + +* rendering/RenderMultiColumnFlowThread.cpp: +(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted): +Ignore inserted flow threads inside an ancestor flow thread, since we only +care about what the sets do. + +* rendering/RenderObject.cpp: +(WebCore::RenderObject::insertedIntoTree): +Make sure that nested flow thread layers return themselves when a
[webkit-changes] [167715] trunk/Source/WebCore
Title: [167715] trunk/Source/WebCore
Revision 167715
Author commit-qu...@webkit.org
Date 2014-04-23 11:36:26 -0700 (Wed, 23 Apr 2014)
Log Message
Unreviewed, rolling out r167713.
https://bugs.webkit.org/show_bug.cgi?id=132070
broke hundreds of tests (Requested by thorton on #webkit).
Reverted changeset:
[OS X] Make checking if a font is the system font more
robust
https://bugs.webkit.org/show_bug.cgi?id=132030
http://trac.webkit.org/changeset/167713
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Font.cpp
trunk/Source/WebCore/platform/graphics/Font.h
trunk/Source/WebCore/platform/graphics/mac/FontMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (167714 => 167715)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 18:05:33 UTC (rev 167714)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 18:36:26 UTC (rev 167715)
@@ -1,3 +1,17 @@
+2014-04-23 Commit Queue commit-qu...@webkit.org
+
+Unreviewed, rolling out r167713.
+https://bugs.webkit.org/show_bug.cgi?id=132070
+
+broke hundreds of tests (Requested by thorton on #webkit).
+
+Reverted changeset:
+
+[OS X] Make checking if a font is the system font more
+robust
+https://bugs.webkit.org/show_bug.cgi?id=132030
+http://trac.webkit.org/changeset/167713
+
2014-04-22 David Hyatt hy...@apple.com
[New Multicolumn] Nested columns not working at all.
Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (167714 => 167715)
--- trunk/Source/WebCore/platform/graphics/Font.cpp 2014-04-23 18:05:33 UTC (rev 167714)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp 2014-04-23 18:36:26 UTC (rev 167715)
@@ -481,11 +481,11 @@
if (family.isEmpty())
return false;
-#if PLATFORM(MAC) || PLATFORM(IOS)
-// Internal fonts on OS X and iOS also have an invalid entry in the table for avgCharWidth.
-if (primaryFontDataIsSystemFont())
+// Internal fonts on OS X also have an invalid entry in the table for avgCharWidth.
+// They are hidden by having a name that begins with a period, so simply search
+// for that here rather than try to keep the list up to date.
+if (family.startsWith('.'))
return false;
-#endif
static HashSetAtomicString* fontFamiliesWithInvalidCharWidthMap = 0;
Modified: trunk/Source/WebCore/platform/graphics/Font.h (167714 => 167715)
--- trunk/Source/WebCore/platform/graphics/Font.h 2014-04-23 18:05:33 UTC (rev 167714)
+++ trunk/Source/WebCore/platform/graphics/Font.h 2014-04-23 18:36:26 UTC (rev 167715)
@@ -188,8 +188,6 @@
CodePath codePath(const TextRun) const;
static CodePath characterRangeCodePath(const LChar*, unsigned) { return Simple; }
static CodePath characterRangeCodePath(const UChar*, unsigned len);
-
-bool primaryFontDataIsSystemFont() const;
private:
enum ForTextEmphasisOrNot { NotForTextEmphasis, ForTextEmphasis };
Modified: trunk/Source/WebCore/platform/graphics/mac/FontMac.mm (167714 => 167715)
--- trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2014-04-23 18:05:33 UTC (rev 167714)
+++ trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2014-04-23 18:36:26 UTC (rev 167715)
@@ -34,11 +34,6 @@
#endif
#import wtf/MathExtras.h
-#if __has_include(CoreText/CTFontDescriptorPriv.h)
-#import CoreText/CTFontDescriptorPriv.h
-#endif
-extern C bool CTFontDescriptorIsSystemUIFont(CTFontDescriptorRef);
-
#if ENABLE(LETTERPRESS)
#import SoftLinking.h
#if __has_include(CoreGraphics/CoreGraphicsPrivate.h)
@@ -540,14 +535,4 @@
}
#endif
-bool Font::primaryFontDataIsSystemFont() const
-{
-#if __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
-RetainPtrCTFontDescriptorRef descriptor = CTFontCopyFontDescriptor(primaryFont()-platformData().ctFont());
-return CTFontDescriptorIsSystemUIFont(descriptor.get());
-#else
-return false;
-#endif
}
-
-}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167717] trunk/Source/WebCore
Title: [167717] trunk/Source/WebCore
Revision 167717
Author akl...@apple.com
Date 2014-04-23 11:47:15 -0700 (Wed, 23 Apr 2014)
Log Message
[iOS WebKit2] IOSurfacePool should force CA to actually garbage collect surfaces.
https://webkit.org/b/132065
rdar://problem/16110687
Add a platformGarbageCollectNow() helper function to IOSurfacePool that
triggers a sweep of the IOSurfaces. Call this from collectionTimerFired()
and discardAllSurfaces().
This lets us drop all otherwise-unused 420f surfaces on memory pressure.
Reviewed by Tim Horton.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/cg/IOSurfacePool.cpp:
(WebCore::IOSurfacePool::collectionTimerFired):
(WebCore::IOSurfacePool::discardAllSurfaces):
* platform/graphics/cg/IOSurfacePool.h:
* platform/graphics/cocoa/IOSurfacePoolCocoa.mm: Added.
(WebCore::IOSurfacePool::platformGarbageCollectNow):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp
trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.h
Added Paths
trunk/Source/WebCore/platform/graphics/cocoa/IOSurfacePoolCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (167716 => 167717)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 18:39:57 UTC (rev 167716)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 18:47:15 UTC (rev 167717)
@@ -1,3 +1,25 @@
+2014-04-23 Andreas Kling akl...@apple.com
+
+[iOS WebKit2] IOSurfacePool should force CA to actually garbage collect surfaces.
+https://webkit.org/b/132065
+rdar://problem/16110687
+
+Add a platformGarbageCollectNow() helper function to IOSurfacePool that
+triggers a sweep of the IOSurfaces. Call this from collectionTimerFired()
+and discardAllSurfaces().
+
+This lets us drop all otherwise-unused 420f surfaces on memory pressure.
+
+Reviewed by Tim Horton.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/graphics/cg/IOSurfacePool.cpp:
+(WebCore::IOSurfacePool::collectionTimerFired):
+(WebCore::IOSurfacePool::discardAllSurfaces):
+* platform/graphics/cg/IOSurfacePool.h:
+* platform/graphics/cocoa/IOSurfacePoolCocoa.mm: Added.
+(WebCore::IOSurfacePool::platformGarbageCollectNow):
+
2014-04-23 Morten Stenshorne msten...@opera.com
REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (167716 => 167717)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-04-23 18:39:57 UTC (rev 167716)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-04-23 18:47:15 UTC (rev 167717)
@@ -4245,6 +4245,7 @@
AD726FED16DA1171003A4E6D /* JSCSSStyleDeclarationCustom.h in Headers */ = {isa = PBXBuildFile; fileRef = AD726FEA16D9F40B003A4E6D /* JSCSSStyleDeclarationCustom.h */; settings = {ATTRIBUTES = (Private, ); }; };
AD726FEE16DA11BC003A4E6D /* JSStyleSheetCustom.h in Headers */ = {isa = PBXBuildFile; fileRef = AD726FEC16D9F4B9003A4E6D /* JSStyleSheetCustom.h */; settings = {ATTRIBUTES = (Private, ); }; };
AD726FEF16DA11F5003A4E6D /* JSCSSRuleCustom.h in Headers */ = {isa = PBXBuildFile; fileRef = AD726FE916D9F40A003A4E6D /* JSCSSRuleCustom.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ AD9FF6E11908391D003B61E0 /* IOSurfacePoolCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = AD9FF6E01908391D003B61E0 /* IOSurfacePoolCocoa.mm */; };
ADB6B29818FB90240081963E /* MemoryPressureHandlerCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = ADB6B29718FB90240081963E /* MemoryPressureHandlerCocoa.mm */; };
ADDF1AD71257CD9A0003A759 /* RenderSVGPath.h in Headers */ = {isa = PBXBuildFile; fileRef = ADDF1AD51257CD9A0003A759 /* RenderSVGPath.h */; };
ADEC78F818EE5308001315C2 /* JSElementCustom.h in Headers */ = {isa = PBXBuildFile; fileRef = ADEC78F718EE5308001315C2 /* JSElementCustom.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -11369,6 +11370,7 @@
AD726FE916D9F40A003A4E6D /* JSCSSRuleCustom.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSCSSRuleCustom.h; sourceTree = group; };
AD726FEA16D9F40B003A4E6D /* JSCSSStyleDeclarationCustom.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSCSSStyleDeclarationCustom.h; sourceTree = group; };
AD726FEC16D9F4B9003A4E6D /* JSStyleSheetCustom.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSStyleSheetCustom.h; sourceTree = group; };
+ AD9FF6E01908391D003B61E0 /* IOSurfacePoolCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = IOSurfacePoolCocoa.mm; sourceTree = group; };
ADB6B29718FB90240081963E /* MemoryPressureHandlerCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path =
[webkit-changes] [167718] trunk
Title: [167718] trunk
Revision 167718
Author hy...@apple.com
Date 2014-04-23 11:55:43 -0700 (Wed, 23 Apr 2014)
Log Message
[New Multicolumn] Crasher when clearing out a flow thread in multicolumn layout.
https://bugs.webkit.org/show_bug.cgi?id=132069
Reviewed by Dean Jackson.
Source/WebCore:
This is imported from a patch Morten did for Blink, but I had to change it a fair
bit. deleteLines() is used to handle simple line box layout instead of just calling
deleteLineBoxTree.
I also had to disable the layout state to stop asserts on repaint when the children
get moved. Not sure why Blink didn't hit this, but it's simple enough to add a
LayoutStateDisabler to stop the assert.
Added fast/multicol/inline-children-crash.html
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::evacuateAndDestroy):
LayoutTests:
* fast/multicol/inline-children-crash-expected.txt: Added.
* fast/multicol/inline-children-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp
Added Paths
trunk/LayoutTests/fast/multicol/inline-children-crash-expected.txt
trunk/LayoutTests/fast/multicol/inline-children-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (167717 => 167718)
--- trunk/LayoutTests/ChangeLog 2014-04-23 18:47:15 UTC (rev 167717)
+++ trunk/LayoutTests/ChangeLog 2014-04-23 18:55:43 UTC (rev 167718)
@@ -1,3 +1,13 @@
+2014-04-23 David Hyatt hy...@apple.com
+
+[New Multicolumn] Crasher when clearing out a flow thread in multicolumn layout.
+https://bugs.webkit.org/show_bug.cgi?id=132069
+
+Reviewed by Dean Jackson.
+
+* fast/multicol/inline-children-crash-expected.txt: Added.
+* fast/multicol/inline-children-crash.html: Added.
+
2014-04-23 Morten Stenshorne msten...@opera.com
REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared
Added: trunk/LayoutTests/fast/multicol/inline-children-crash-expected.txt (0 => 167718)
--- trunk/LayoutTests/fast/multicol/inline-children-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/multicol/inline-children-crash-expected.txt 2014-04-23 18:55:43 UTC (rev 167718)
@@ -0,0 +1,3 @@
+This test should not crash.
+
+PASS
Added: trunk/LayoutTests/fast/multicol/inline-children-crash.html (0 => 167718)
--- trunk/LayoutTests/fast/multicol/inline-children-crash.html (rev 0)
+++ trunk/LayoutTests/fast/multicol/inline-children-crash.html 2014-04-23 18:55:43 UTC (rev 167718)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+script
+if (window.internals)
+internals.settings.setRegionBasedColumnsEnabled(true);
+if (window.testRunner)
+testRunner.dumpAsText();
+_onload_ = function() {
+document.getElementById('mc').offsetTop; // trigger layout
+document.getElementById('mc').style.webkitColumns = 'auto';
+document.getElementById('mc').style.columns = 'auto';
+document.getElementById('inline').style.color = 'green';
+}
+/script
+pThis test should not crash./p
+div id=mc style=-webkit-columns:3; columns:3;
+span id=inlinePASS/span
+/div
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (167717 => 167718)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 18:47:15 UTC (rev 167717)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 18:55:43 UTC (rev 167718)
@@ -1,3 +1,23 @@
+2014-04-23 David Hyatt hy...@apple.com
+
+[New Multicolumn] Crasher when clearing out a flow thread in multicolumn layout.
+https://bugs.webkit.org/show_bug.cgi?id=132069
+
+Reviewed by Dean Jackson.
+
+This is imported from a patch Morten did for Blink, but I had to change it a fair
+bit. deleteLines() is used to handle simple line box layout instead of just calling
+deleteLineBoxTree.
+
+I also had to disable the layout state to stop asserts on repaint when the children
+get moved. Not sure why Blink didn't hit this, but it's simple enough to add a
+LayoutStateDisabler to stop the assert.
+
+Added fast/multicol/inline-children-crash.html
+
+* rendering/RenderMultiColumnFlowThread.cpp:
+(WebCore::RenderMultiColumnFlowThread::evacuateAndDestroy):
+
2014-04-23 Andreas Kling akl...@apple.com
[iOS WebKit2] IOSurfacePool should force CA to actually garbage collect surfaces.
Modified: trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp (167717 => 167718)
--- trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp 2014-04-23 18:47:15 UTC (rev 167717)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp 2014-04-23 18:55:43 UTC (rev 167718)
@@ -30,6 +30,7 @@
#include LayoutState.h
#include RenderMultiColumnSet.h
#include RenderMultiColumnSpannerPlaceholder.h
+#include RenderView.h
#include TransformState.h
namespace WebCore {
[webkit-changes] [167719] trunk/Source/WebKit2
Title: [167719] trunk/Source/WebKit2
Revision 167719
Author commit-qu...@webkit.org
Date 2014-04-23 12:38:42 -0700 (Wed, 23 Apr 2014)
Log Message
Support encoding/decoding NSUInteger arguments in WKRemoteObjectCoder.
https://bugs.webkit.org/show_bug.cgi?id=132040
Add support for encoding/decoding NSUInteger arguments.
Patch by Yongjun Zhang yongjun_zh...@apple.com on 2014-04-23
Reviewed by Sam Weinig.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocation):
(decodeInvocationArguments):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (167718 => 167719)
--- trunk/Source/WebKit2/ChangeLog 2014-04-23 18:55:43 UTC (rev 167718)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-23 19:38:42 UTC (rev 167719)
@@ -1,3 +1,16 @@
+2014-04-23 Yongjun Zhang yongjun_zh...@apple.com
+
+Support encoding/decoding NSUInteger arguments in WKRemoteObjectCoder.
+https://bugs.webkit.org/show_bug.cgi?id=132040
+
+Add support for encoding/decoding NSUInteger arguments.
+
+Reviewed by Sam Weinig.
+
+* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
+(encodeInvocation):
+(decodeInvocationArguments):
+
2014-04-22 Ryosuke Niwa rn...@webkit.org
Cursor doesn't change back to pointer when leaving the Safari window
Modified: trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm (167718 => 167719)
--- trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm 2014-04-23 18:55:43 UTC (rev 167718)
+++ trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm 2014-04-23 19:38:42 UTC (rev 167719)
@@ -158,7 +158,7 @@
// bool
case 'B': {
BOOL value;
-[invocation getArgument:value atIndex:i];;
+[invocation getArgument:value atIndex:i];
encodeToObjectStream(encoder, @(value));
break;
@@ -167,12 +167,21 @@
// NSInteger
case 'q': {
NSInteger value;
-[invocation getArgument:value atIndex:i];;
+[invocation getArgument:value atIndex:i];
encodeToObjectStream(encoder, @(value));
break;
}
+// NSUInteger
+case 'Q': {
+NSUInteger value;
+[invocation getArgument:value atIndex:i];
+
+encodeToObjectStream(encoder, @(value));
+break;
+}
+
// Objective-C object
case '@': {
id value;
@@ -433,6 +442,13 @@
break;
}
+// NSUInteger
+case 'Q': {
+NSUInteger value = [decodeObjectFromObjectStream(decoder, [NSSet setWithObject:[NSNumber class]]) unsignedIntegerValue];
+[invocation setArgument:value atIndex:i];
+break;
+}
+
// Objective-C object
case '@': {
NSSet *allowedClasses = allowedArgumentClasses[i - 2].get();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167720] trunk/Source/WebCore
Title: [167720] trunk/Source/WebCore
Revision 167720
Author hy...@apple.com
Date 2014-04-23 13:01:01 -0700 (Wed, 23 Apr 2014)
Log Message
[New Multicolumn] Assertion failure in huge-column-count.html
https://bugs.webkit.org/show_bug.cgi?id=132071
Reviewed by Dean Jackson.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::regionAtBlockOffset):
Remove the code that returned 0 here, since we're going to patch a lower-level
function to catch all cases.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::getRegionRangeForBox):
Don't allow in-flow RenderFlowThreads to ever have a region range. The sets
are what should have ranges... the flow thread needs to just be ignored.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (167719 => 167720)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 19:38:42 UTC (rev 167719)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 20:01:01 UTC (rev 167720)
@@ -1,5 +1,22 @@
2014-04-23 David Hyatt hy...@apple.com
+[New Multicolumn] Assertion failure in huge-column-count.html
+https://bugs.webkit.org/show_bug.cgi?id=132071
+
+Reviewed by Dean Jackson.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::regionAtBlockOffset):
+Remove the code that returned 0 here, since we're going to patch a lower-level
+function to catch all cases.
+
+* rendering/RenderFlowThread.cpp:
+(WebCore::RenderFlowThread::getRegionRangeForBox):
+Don't allow in-flow RenderFlowThreads to ever have a region range. The sets
+are what should have ranges... the flow thread needs to just be ignored.
+
+2014-04-23 David Hyatt hy...@apple.com
+
[New Multicolumn] Crasher when clearing out a flow thread in multicolumn layout.
https://bugs.webkit.org/show_bug.cgi?id=132069
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (167719 => 167720)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-04-23 19:38:42 UTC (rev 167719)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-04-23 20:01:01 UTC (rev 167720)
@@ -4828,9 +4828,6 @@
RenderRegion* RenderBlock::regionAtBlockOffset(LayoutUnit blockOffset) const
{
-if (isInFlowRenderFlowThread())
-return 0;
-
RenderFlowThread* flowThread = flowThreadContainingBlock();
if (!flowThread || !flowThread-hasValidRegionInfo())
return 0;
Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (167719 => 167720)
--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-04-23 19:38:42 UTC (rev 167719)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-04-23 20:01:01 UTC (rev 167720)
@@ -760,7 +760,7 @@
ASSERT(box);
startRegion = endRegion = nullptr;
-if (!hasValidRegionInfo()) // We clear the ranges when we invalidate the regions.
+if (!hasValidRegionInfo() || box-isInFlowRenderFlowThread()) // We clear the ranges when we invalidate the regions.
return false;
if (getRegionRangeForBoxFromCachedInfo(box, startRegion, endRegion))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167721] trunk/Source/WebCore
Title: [167721] trunk/Source/WebCore
Revision 167721
Author commit-qu...@webkit.org
Date 2014-04-23 13:54:12 -0700 (Wed, 23 Apr 2014)
Log Message
Unreviewed, rolling out r167720.
https://bugs.webkit.org/show_bug.cgi?id=132075
broke eight newmulticol tests (Requested by thorton on
#webkit).
Reverted changeset:
[New Multicolumn] Assertion failure in huge-column-
count.html
https://bugs.webkit.org/show_bug.cgi?id=132071
http://trac.webkit.org/changeset/167720
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (167720 => 167721)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 20:01:01 UTC (rev 167720)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 20:54:12 UTC (rev 167721)
@@ -1,3 +1,18 @@
+2014-04-23 Commit Queue commit-qu...@webkit.org
+
+Unreviewed, rolling out r167720.
+https://bugs.webkit.org/show_bug.cgi?id=132075
+
+broke eight newmulticol tests (Requested by thorton on
+#webkit).
+
+Reverted changeset:
+
+[New Multicolumn] Assertion failure in huge-column-
+count.html
+https://bugs.webkit.org/show_bug.cgi?id=132071
+http://trac.webkit.org/changeset/167720
+
2014-04-23 David Hyatt hy...@apple.com
[New Multicolumn] Assertion failure in huge-column-count.html
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (167720 => 167721)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-04-23 20:01:01 UTC (rev 167720)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-04-23 20:54:12 UTC (rev 167721)
@@ -4828,6 +4828,9 @@
RenderRegion* RenderBlock::regionAtBlockOffset(LayoutUnit blockOffset) const
{
+if (isInFlowRenderFlowThread())
+return 0;
+
RenderFlowThread* flowThread = flowThreadContainingBlock();
if (!flowThread || !flowThread-hasValidRegionInfo())
return 0;
Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (167720 => 167721)
--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-04-23 20:01:01 UTC (rev 167720)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-04-23 20:54:12 UTC (rev 167721)
@@ -760,7 +760,7 @@
ASSERT(box);
startRegion = endRegion = nullptr;
-if (!hasValidRegionInfo() || box-isInFlowRenderFlowThread()) // We clear the ranges when we invalidate the regions.
+if (!hasValidRegionInfo()) // We clear the ranges when we invalidate the regions.
return false;
if (getRegionRangeForBoxFromCachedInfo(box, startRegion, endRegion))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167722] trunk/Source/WebCore
Title: [167722] trunk/Source/WebCore
Revision 167722
Author akl...@apple.com
Date 2014-04-23 14:22:53 -0700 (Wed, 23 Apr 2014)
Log Message
[iOS] Memory pressure notification should fire on main thread.
https://webkit.org/b/132074
Rejig the memory pressure notification to fire on the main queue
directly instead of rerouting it manually.
Reviewed by Mark Rowe.
* platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (167721 => 167722)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 20:54:12 UTC (rev 167721)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 21:22:53 UTC (rev 167722)
@@ -1,3 +1,16 @@
+2014-04-23 Andreas Kling akl...@apple.com
+
+[iOS] Memory pressure notification should fire on main thread.
+https://webkit.org/b/132074
+
+Rejig the memory pressure notification to fire on the main queue
+directly instead of rerouting it manually.
+
+Reviewed by Mark Rowe.
+
+* platform/cocoa/MemoryPressureHandlerCocoa.mm:
+(WebCore::MemoryPressureHandler::install):
+
2014-04-23 Commit Queue commit-qu...@webkit.org
Unreviewed, rolling out r167720.
Modified: trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm (167721 => 167722)
--- trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm 2014-04-23 20:54:12 UTC (rev 167721)
+++ trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm 2014-04-23 21:22:53 UTC (rev 167722)
@@ -81,7 +81,7 @@
dispatch_async(dispatch_get_main_queue(), ^{
#if PLATFORM(IOS) __IPHONE_OS_VERSION_MIN_REQUIRED = 8
-_cache_event_source = dispatch_source_create(DISPATCH_SOURCE_TYPE_MEMORYSTATUS, 0, DISPATCH_MEMORYSTATUS_PRESSURE_WARN, dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0));
+_cache_event_source = dispatch_source_create(DISPATCH_SOURCE_TYPE_MEMORYSTATUS, 0, DISPATCH_MEMORYSTATUS_PRESSURE_WARN, dispatch_get_main_queue());
#elif PLATFORM(MAC) MAC_OS_X_VERSION_MIN_REQUIRED = 1090
_cache_event_source = wkCreateMemoryStatusPressureCriticalDispatchOnMainQueue();
#else
@@ -90,9 +90,7 @@
if (_cache_event_source) {
dispatch_set_context(_cache_event_source, this);
dispatch_source_set_event_handler(_cache_event_source, ^{
-dispatch_async(dispatch_get_main_queue(), ^{
-memoryPressureHandler().respondToMemoryPressure();
-});
+memoryPressureHandler().respondToMemoryPressure();
});
dispatch_resume(_cache_event_source);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167723] trunk/Source/WebCore
Title: [167723] trunk/Source/WebCore
Revision 167723
Author hy...@apple.com
Date 2014-04-23 14:27:54 -0700 (Wed, 23 Apr 2014)
Log Message
[New Multicolumn] Assertion failure in huge-column-count.html
https://bugs.webkit.org/show_bug.cgi?id=132071
Reviewed by Dean Jackson.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::regionAtBlockOffset):
Back out this change, since it wasn't general enough.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::getRegionRangeForBox):
The real issue was that this loop needed to consider the actual box
rather than starting from the parent. This was a non-issue for normal
regions (which cannot have nested flow threads), but for columns, you
have to consider the fact that the box could itself be a flow thread.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (167722 => 167723)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 21:22:53 UTC (rev 167722)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 21:27:54 UTC (rev 167723)
@@ -1,3 +1,21 @@
+2014-04-23 David Hyatt hy...@apple.com
+
+[New Multicolumn] Assertion failure in huge-column-count.html
+https://bugs.webkit.org/show_bug.cgi?id=132071
+
+Reviewed by Dean Jackson.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::regionAtBlockOffset):
+Back out this change, since it wasn't general enough.
+
+* rendering/RenderFlowThread.cpp:
+(WebCore::RenderFlowThread::getRegionRangeForBox):
+The real issue was that this loop needed to consider the actual box
+rather than starting from the parent. This was a non-issue for normal
+regions (which cannot have nested flow threads), but for columns, you
+have to consider the fact that the box could itself be a flow thread.
+
2014-04-23 Andreas Kling akl...@apple.com
[iOS] Memory pressure notification should fire on main thread.
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (167722 => 167723)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-04-23 21:22:53 UTC (rev 167722)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-04-23 21:27:54 UTC (rev 167723)
@@ -4828,9 +4828,6 @@
RenderRegion* RenderBlock::regionAtBlockOffset(LayoutUnit blockOffset) const
{
-if (isInFlowRenderFlowThread())
-return 0;
-
RenderFlowThread* flowThread = flowThreadContainingBlock();
if (!flowThread || !flowThread-hasValidRegionInfo())
return 0;
Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (167722 => 167723)
--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-04-23 21:22:53 UTC (rev 167722)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-04-23 21:27:54 UTC (rev 167723)
@@ -771,13 +771,13 @@
// should be equal with the region for the unsplittable box if any.
RenderBox* topMostUnsplittable = nullptr;
RenderBox* cb = const_castRenderBox*(box);
-do {
+while (!cb-isRenderFlowThread()) {
if (cb-isUnsplittableForPagination())
topMostUnsplittable = cb;
ASSERT(cb-parent());
cb = cb-parent()-enclosingBox();
ASSERT(cb);
-} while (!cb-isRenderFlowThread());
+}
if (topMostUnsplittable) {
if (getRegionRangeForBoxFromCachedInfo(topMostUnsplittable, startRegion, endRegion)) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167724] trunk/Source/WebCore
Title: [167724] trunk/Source/WebCore
Revision 167724
Author mmaxfi...@apple.com
Date 2014-04-23 14:33:14 -0700 (Wed, 23 Apr 2014)
Log Message
[OS X] Make checking if a font is the system font more robust
https://bugs.webkit.org/show_bug.cgi?id=132030
Reviewed by Dean Jackson.
Instead of inspecting a font's name to determine if it is a system font,
on OS X we can ask the system directly.
This patch also moves a platform-specific check into platform-specific
code, so that other platforms don't check for OS X-specific behavior.
Covered by existing tests.
* platform/graphics/Font.cpp:
(WebCore::Font::hasValidAverageCharWidth):
* platform/graphics/Font.h:
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::primaryFontDataIsSystemFont):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Font.cpp
trunk/Source/WebCore/platform/graphics/Font.h
trunk/Source/WebCore/platform/graphics/mac/FontMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (167723 => 167724)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 21:27:54 UTC (rev 167723)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 21:33:14 UTC (rev 167724)
@@ -1,3 +1,24 @@
+2014-04-23 Myles C. Maxfield mmaxfi...@apple.com
+
+[OS X] Make checking if a font is the system font more robust
+https://bugs.webkit.org/show_bug.cgi?id=132030
+
+Reviewed by Dean Jackson.
+
+Instead of inspecting a font's name to determine if it is a system font,
+on OS X we can ask the system directly.
+
+This patch also moves a platform-specific check into platform-specific
+code, so that other platforms don't check for OS X-specific behavior.
+
+Covered by existing tests.
+
+* platform/graphics/Font.cpp:
+(WebCore::Font::hasValidAverageCharWidth):
+* platform/graphics/Font.h:
+* platform/graphics/mac/FontMac.mm:
+(WebCore::Font::primaryFontDataIsSystemFont):
+
2014-04-23 David Hyatt hy...@apple.com
[New Multicolumn] Assertion failure in huge-column-count.html
Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (167723 => 167724)
--- trunk/Source/WebCore/platform/graphics/Font.cpp 2014-04-23 21:27:54 UTC (rev 167723)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp 2014-04-23 21:33:14 UTC (rev 167724)
@@ -481,11 +481,11 @@
if (family.isEmpty())
return false;
-// Internal fonts on OS X also have an invalid entry in the table for avgCharWidth.
-// They are hidden by having a name that begins with a period, so simply search
-// for that here rather than try to keep the list up to date.
-if (family.startsWith('.'))
+#if PLATFORM(MAC) || PLATFORM(IOS)
+// Internal fonts on OS X and iOS also have an invalid entry in the table for avgCharWidth.
+if (primaryFontDataIsSystemFont())
return false;
+#endif
static HashSetAtomicString* fontFamiliesWithInvalidCharWidthMap = 0;
Modified: trunk/Source/WebCore/platform/graphics/Font.h (167723 => 167724)
--- trunk/Source/WebCore/platform/graphics/Font.h 2014-04-23 21:27:54 UTC (rev 167723)
+++ trunk/Source/WebCore/platform/graphics/Font.h 2014-04-23 21:33:14 UTC (rev 167724)
@@ -189,6 +189,8 @@
static CodePath characterRangeCodePath(const LChar*, unsigned) { return Simple; }
static CodePath characterRangeCodePath(const UChar*, unsigned len);
+bool primaryFontDataIsSystemFont() const;
+
private:
enum ForTextEmphasisOrNot { NotForTextEmphasis, ForTextEmphasis };
Modified: trunk/Source/WebCore/platform/graphics/mac/FontMac.mm (167723 => 167724)
--- trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2014-04-23 21:27:54 UTC (rev 167723)
+++ trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2014-04-23 21:33:14 UTC (rev 167724)
@@ -34,6 +34,11 @@
#endif
#import wtf/MathExtras.h
+#if __has_include(CoreText/CTFontDescriptorPriv.h)
+#import CoreText/CTFontDescriptorPriv.h
+#endif
+extern C bool CTFontDescriptorIsSystemUIFont(CTFontDescriptorRef);
+
#if ENABLE(LETTERPRESS)
#import SoftLinking.h
#if __has_include(CoreGraphics/CoreGraphicsPrivate.h)
@@ -535,4 +540,16 @@
}
#endif
+bool Font::primaryFontDataIsSystemFont() const
+{
+#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED 1090
+RetainPtrCTFontDescriptorRef descriptor = CTFontCopyFontDescriptor(primaryFont()-platformData().ctFont());
+return CTFontDescriptorIsSystemUIFont(descriptor.get());
+#else
+// System fonts are hidden by having a name that begins with a period, so simply search
+// for that here rather than try to keep the list up to date.
+return firstFamily().startsWith('.');
+#endif
}
+
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167725] branches/safari-537.76-branch/
Title: [167725] branches/safari-537.76-branch/ Revision 167725 Author lforsch...@apple.com Date 2014-04-23 14:48:11 -0700 (Wed, 23 Apr 2014) Log Message New branch. Added Paths branches/safari-537.76-branch/ Diff Property changes: branches/safari-537.76-branch Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167726] branches/safari-537.76-branch/Source
Title: [167726] branches/safari-537.76-branch/Source Revision 167726 Author lforsch...@apple.com Date 2014-04-23 14:55:50 -0700 (Wed, 23 Apr 2014) Log Message Versioning. Modified Paths branches/safari-537.76-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-537.76-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-537.76-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-537.76-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-537.76-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-537.76-branch/Source/_javascript_Core/Configurations/Version.xcconfig (167725 => 167726) --- branches/safari-537.76-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2014-04-23 21:48:11 UTC (rev 167725) +++ branches/safari-537.76-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2014-04-23 21:55:50 UTC (rev 167726) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 75; -TINY_VERSION = 15; +MINOR_VERSION = 76; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.76-branch/Source/WebCore/Configurations/Version.xcconfig (167725 => 167726) --- branches/safari-537.76-branch/Source/WebCore/Configurations/Version.xcconfig 2014-04-23 21:48:11 UTC (rev 167725) +++ branches/safari-537.76-branch/Source/WebCore/Configurations/Version.xcconfig 2014-04-23 21:55:50 UTC (rev 167726) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 75; -TINY_VERSION = 15; +MINOR_VERSION = 76; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.76-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (167725 => 167726) --- branches/safari-537.76-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-04-23 21:48:11 UTC (rev 167725) +++ branches/safari-537.76-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-04-23 21:55:50 UTC (rev 167726) @@ -1,6 +1,6 @@ MAJOR_VERSION = 537; -MINOR_VERSION = 75; -TINY_VERSION = 15; +MINOR_VERSION = 76; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-537.76-branch/Source/WebKit/mac/Configurations/Version.xcconfig (167725 => 167726) --- branches/safari-537.76-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2014-04-23 21:48:11 UTC (rev 167725) +++ branches/safari-537.76-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2014-04-23 21:55:50 UTC (rev 167726) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 75; -TINY_VERSION = 15; +MINOR_VERSION = 76; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.76-branch/Source/WebKit2/Configurations/Version.xcconfig (167725 => 167726) --- branches/safari-537.76-branch/Source/WebKit2/Configurations/Version.xcconfig 2014-04-23 21:48:11 UTC (rev 167725) +++ branches/safari-537.76-branch/Source/WebKit2/Configurations/Version.xcconfig 2014-04-23 21:55:50 UTC (rev 167726) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 75; -TINY_VERSION = 15; +MINOR_VERSION = 76; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167727] trunk/Source/WebCore
Title: [167727] trunk/Source/WebCore
Revision 167727
Author hy...@apple.com
Date 2014-04-23 15:19:19 -0700 (Wed, 23 Apr 2014)
Log Message
[New Multicolumn] fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html fails
https://bugs.webkit.org/show_bug.cgi?id=132078
Reviewed by Anders Carlsson.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
Add a parameter to test for orthogonal writing modes. If we're perpendicular,
then we should not skip the flow thread, since we resolve relative to the column width,
and that is always set.
(WebCore::RenderBox::computePercentageLogicalHeight):
Patched to pass in whether or not the box and the ancestor block are perpendicular.
* rendering/RenderBox.h:
Patched the signature of skipContainingBlockForPercentHeightCalculation
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (167726 => 167727)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 21:55:50 UTC (rev 167726)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 22:19:19 UTC (rev 167727)
@@ -1,3 +1,22 @@
+2014-04-23 David Hyatt hy...@apple.com
+
+[New Multicolumn] fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html fails
+https://bugs.webkit.org/show_bug.cgi?id=132078
+
+Reviewed by Anders Carlsson.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
+Add a parameter to test for orthogonal writing modes. If we're perpendicular,
+then we should not skip the flow thread, since we resolve relative to the column width,
+and that is always set.
+
+(WebCore::RenderBox::computePercentageLogicalHeight):
+Patched to pass in whether or not the box and the ancestor block are perpendicular.
+
+* rendering/RenderBox.h:
+Patched the signature of skipContainingBlockForPercentHeightCalculation
+
2014-04-23 Myles C. Maxfield mmaxfi...@apple.com
[OS X] Make checking if a font is the system font more robust
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (167726 => 167727)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-04-23 21:55:50 UTC (rev 167726)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-04-23 22:19:19 UTC (rev 167727)
@@ -2712,11 +2712,11 @@
return -1;
}
-bool RenderBox::skipContainingBlockForPercentHeightCalculation(const RenderBox* containingBlock) const
+bool RenderBox::skipContainingBlockForPercentHeightCalculation(const RenderBox* containingBlock, bool isPerpendicularWritingMode) const
{
// Flow threads for multicol or paged overflow should be skipped. They are invisible to the DOM,
// and percent heights of children should be resolved against the multicol or paged container.
-if (containingBlock-isInFlowRenderFlowThread())
+if (containingBlock-isInFlowRenderFlowThread() !isPerpendicularWritingMode)
return true;
// For quirks mode and anonymous blocks, we skip auto-height containingBlocks when computing percentages.
@@ -2734,7 +2734,8 @@
RenderBlock* cb = containingBlock();
const RenderBox* containingBlockChild = this;
LayoutUnit rootMarginBorderPaddingHeight = 0;
-while (!cb-isRenderView() skipContainingBlockForPercentHeightCalculation(cb)) {
+bool isHorizontal = isHorizontalWritingMode();
+while (!cb-isRenderView() skipContainingBlockForPercentHeightCalculation(cb, isHorizontal != cb-isHorizontalWritingMode())) {
if (cb-isBody() || cb-isRoot())
rootMarginBorderPaddingHeight += cb-marginBefore() + cb-marginAfter() + cb-borderAndPaddingLogicalHeight();
skippedAutoHeightContainingBlock = true;
@@ -2751,7 +2752,7 @@
bool includeBorderPadding = isTable();
-if (isHorizontalWritingMode() != cb-isHorizontalWritingMode())
+if (isHorizontal != cb-isHorizontalWritingMode())
availableHeight = containingBlockChild-containingBlockLogicalWidthForContent();
else if (hasOverrideContainingBlockLogicalHeight())
availableHeight = overrideContainingBlockContentLogicalHeight();
Modified: trunk/Source/WebCore/rendering/RenderBox.h (167726 => 167727)
--- trunk/Source/WebCore/rendering/RenderBox.h 2014-04-23 21:55:50 UTC (rev 167726)
+++ trunk/Source/WebCore/rendering/RenderBox.h 2014-04-23 22:19:19 UTC (rev 167727)
@@ -669,7 +669,7 @@
// Returns true if we did a full repaint
bool repaintLayerRectsForImage(WrappedImagePtr image, const FillLayer* layers, bool drawingBackground);
-bool skipContainingBlockForPercentHeightCalculation(const RenderBox* containingBlock) const;
+bool skipContainingBlockForPercentHeightCalculation(const RenderBox* containingBlock, bool isPerpendicularWritingMode) const;
LayoutUnit containingBlockLogicalWidthForPositioned(const
[webkit-changes] [167728] trunk/Tools
Title: [167728] trunk/Tools Revision 167728 Author timothy_hor...@apple.com Date 2014-04-23 15:22:00 -0700 (Wed, 23 Apr 2014) Log Message Mock scrollbars don't always work in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=132082 Reviewed by Alexey Proskuryakov. * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment): Set the mock scrollbar setting before creating the WebView, as this setting cannot be dynamically changed, so any scrollbars that are created during WebView initialization and are not replaced before snapshotting will end up being platform scrollbars instead of mock ones. WebKitTestRunner already sets this preference before creating WKViews, so we're just matching its behavior. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm Diff Modified: trunk/Tools/ChangeLog (167727 => 167728) --- trunk/Tools/ChangeLog 2014-04-23 22:19:19 UTC (rev 167727) +++ trunk/Tools/ChangeLog 2014-04-23 22:22:00 UTC (rev 167728) @@ -1,3 +1,19 @@ +2014-04-23 Tim Horton timothy_hor...@apple.com + +Mock scrollbars don't always work in DumpRenderTree +https://bugs.webkit.org/show_bug.cgi?id=132082 + +Reviewed by Alexey Proskuryakov. + +* DumpRenderTree/mac/DumpRenderTree.mm: +(prepareConsistentTestingEnvironment): +Set the mock scrollbar setting before creating the WebView, as this setting +cannot be dynamically changed, so any scrollbars that are created during +WebView initialization and are not replaced before snapshotting will end +up being platform scrollbars instead of mock ones. +WebKitTestRunner already sets this preference before creating WKViews, +so we're just matching its behavior. + 2014-04-23 Carlos Garcia Campos cgar...@igalia.com [GTK] ShadowRoot API was removed in r164131 Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (167727 => 167728) --- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2014-04-23 22:19:19 UTC (rev 167727) +++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2014-04-23 22:22:00 UTC (rev 167728) @@ -1098,6 +1098,9 @@ adjustFonts(); registerMockScrollbars(); + +// The mock scrollbars setting cannot be modified after creating a view, so we have to do it now. +[[WebPreferences standardPreferences] setMockScrollbarsEnabled:YES]; #else activateFontsIOS(); #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167729] trunk/Source/JavaScriptCore
Title: [167729] trunk/Source/_javascript_Core
Revision 167729
Author mhahnenb...@apple.com
Date 2014-04-23 15:35:16 -0700 (Wed, 23 Apr 2014)
Log Message
Arguments::copyBackingStore needs to update m_registers in tandem with m_registerArray
https://bugs.webkit.org/show_bug.cgi?id=132079
Reviewed by Michael Saboff.
Since we're moving the register backing store, we don't want to leave a dangling pointer into a random CopiedBlock.
Also added a test that previously triggered this bug.
* runtime/Arguments.cpp:
(JSC::Arguments::copyBackingStore): D'oh!
* tests/stress/arguments-copy-register-array-backing-store.js: Added.
(foo):
(bar):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Arguments.cpp
Added Paths
trunk/Source/_javascript_Core/tests/stress/arguments-copy-register-array-backing-store.js
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (167728 => 167729)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-23 22:22:00 UTC (rev 167728)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-23 22:35:16 UTC (rev 167729)
@@ -1,3 +1,20 @@
+2014-04-23 Mark Hahnenberg mhahnenb...@apple.com
+
+Arguments::copyBackingStore needs to update m_registers in tandem with m_registerArray
+https://bugs.webkit.org/show_bug.cgi?id=132079
+
+Reviewed by Michael Saboff.
+
+Since we're moving the register backing store, we don't want to leave a dangling pointer into a random CopiedBlock.
+
+Also added a test that previously triggered this bug.
+
+* runtime/Arguments.cpp:
+(JSC::Arguments::copyBackingStore): D'oh!
+* tests/stress/arguments-copy-register-array-backing-store.js: Added.
+(foo):
+(bar):
+
2014-04-23 Mark Rowe mr...@apple.com
[Mac] REGRESSION (r164823): Building _javascript_Core creates files under /tmp/_javascript_Core.dst
Modified: trunk/Source/_javascript_Core/runtime/Arguments.cpp (167728 => 167729)
--- trunk/Source/_javascript_Core/runtime/Arguments.cpp 2014-04-23 22:22:00 UTC (rev 167728)
+++ trunk/Source/_javascript_Core/runtime/Arguments.cpp 2014-04-23 22:35:16 UTC (rev 167729)
@@ -78,6 +78,7 @@
WriteBarrierUnknown* newRegisterArray = static_castWriteBarrierUnknown*(visitor.allocateNewSpace(bytes));
memcpy(newRegisterArray, registerArray, bytes);
thisObject-m_registerArray.setWithoutWriteBarrier(newRegisterArray);
+thisObject-m_registers = newRegisterArray - CallFrame::offsetFor(1) - 1;
visitor.didCopy(registerArray, bytes);
}
return;
Added: trunk/Source/_javascript_Core/tests/stress/arguments-copy-register-array-backing-store.js (0 => 167729)
--- trunk/Source/_javascript_Core/tests/stress/arguments-copy-register-array-backing-store.js (rev 0)
+++ trunk/Source/_javascript_Core/tests/stress/arguments-copy-register-array-backing-store.js 2014-04-23 22:35:16 UTC (rev 167729)
@@ -0,0 +1,32 @@
+var foo = function(o) {
+return arguments;
+};
+
+var bar = function() {
+var a = Array.prototype.slice.call(arguments);
+var sum = 0;
+for (var i = 0; i a.length; ++i)
+sum += a[i];
+return sum;
+};
+
+var args = foo({}, 1, 2, 3);
+var expectedArgs = Array.prototype.slice.call(args);
+
+edenGC();
+
+var expectedResult = 0;
+var result = 0;
+for (var i = 0; i 1; ++i) {
+expectedResult += i + i + 1 + i + 2;
+result += bar(i, i + 1, i + 2);
+}
+
+if (result != expectedResult)
+throw new Error(Incorrect result: + result + != + expectedResult);
+
+for (var i = 0; i expectedArgs.length; ++i) {
+if (args[i] !== expectedArgs[i])
+throw new Error(Incorrect arg result);
+}
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167730] trunk/Source
Title: [167730] trunk/Source
Revision 167730
Author ander...@apple.com
Date 2014-04-23 16:17:49 -0700 (Wed, 23 Apr 2014)
Log Message
Don't migrate the WKView.h header from WebCore to WebKit
https://bugs.webkit.org/show_bug.cgi?id=132086
Reviewed by Dan Bernstein.
Source/WebCore:
* WebCore.xcodeproj/project.pbxproj:
Add WAKViewInternal.h.
* platform/WAKViewInternal.h: Added.
* platform/ios/wak/WAKClipView.m:
Import WAKViewInternal.h instead of WAKViewPrivate.h.
* platform/ios/wak/WAKScrollView.mm:
Import WAKViewInternal.h instead of WAKViewPrivate.h.
* platform/ios/wak/WAKView.h:
Move ivars to a class extension in WAKViewInternal.h and remove WKView.h import.
* platform/ios/wak/WAKView.mm:
Import WAKViewInternal.h instead of WAKViewPrivate.h.
* platform/ios/wak/WAKViewPrivate.h:
Import WKViewPrivate.h.
Source/WebKit/mac:
* MigrateHeaders.make:
Remove WKView.h from the list of headers to migrate.
* WebView/WebView.mm:
Import WKView.h.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/ios/wak/WAKClipView.m
trunk/Source/WebCore/platform/ios/wak/WAKScrollView.mm
trunk/Source/WebCore/platform/ios/wak/WAKView.h
trunk/Source/WebCore/platform/ios/wak/WAKView.mm
trunk/Source/WebCore/platform/ios/wak/WAKViewPrivate.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/MigrateHeaders.make
trunk/Source/WebKit/mac/WebView/WebView.mm
Added Paths
trunk/Source/WebCore/platform/WAKViewInternal.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (167729 => 167730)
--- trunk/Source/WebCore/ChangeLog 2014-04-23 22:35:16 UTC (rev 167729)
+++ trunk/Source/WebCore/ChangeLog 2014-04-23 23:17:49 UTC (rev 167730)
@@ -1,3 +1,30 @@
+2014-04-23 Anders Carlsson ander...@apple.com
+
+Don't migrate the WKView.h header from WebCore to WebKit
+https://bugs.webkit.org/show_bug.cgi?id=132086
+
+Reviewed by Dan Bernstein.
+
+* WebCore.xcodeproj/project.pbxproj:
+Add WAKViewInternal.h.
+
+* platform/WAKViewInternal.h: Added.
+
+* platform/ios/wak/WAKClipView.m:
+Import WAKViewInternal.h instead of WAKViewPrivate.h.
+
+* platform/ios/wak/WAKScrollView.mm:
+Import WAKViewInternal.h instead of WAKViewPrivate.h.
+
+* platform/ios/wak/WAKView.h:
+Move ivars to a class extension in WAKViewInternal.h and remove WKView.h import.
+
+* platform/ios/wak/WAKView.mm:
+Import WAKViewInternal.h instead of WAKViewPrivate.h.
+
+* platform/ios/wak/WAKViewPrivate.h:
+Import WKViewPrivate.h.
+
2014-04-23 David Hyatt hy...@apple.com
[New Multicolumn] fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html fails
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (167729 => 167730)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-04-23 22:35:16 UTC (rev 167729)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-04-23 23:17:49 UTC (rev 167730)
@@ -751,6 +751,7 @@
1A85B2110A1B258700D8C87C /* JSHTMLUListElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A85B20F0A1B258700D8C87C /* JSHTMLUListElement.h */; };
1A85B2B60A1B2AC700D8C87C /* JSHTMLDivElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A85B2B40A1B2AC700D8C87C /* JSHTMLDivElement.cpp */; };
1A85B2B70A1B2AC700D8C87C /* JSHTMLDivElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A85B2B50A1B2AC700D8C87C /* JSHTMLDivElement.h */; };
+ 1A874ADF19085E9100B03171 /* WAKViewInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A874ADE19085E9100B03171 /* WAKViewInternal.h */; };
1A88A90417553CD7000C74F9 /* FileIconLoader.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A88A90217553CD7000C74F9 /* FileIconLoader.cpp */; };
1A88A90517553CD7000C74F9 /* FileIconLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A88A90317553CD7000C74F9 /* FileIconLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
1A8F6B020DB53006001DB794 /* SubstituteResource.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A8F6B010DB53006001DB794 /* SubstituteResource.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -7624,6 +7625,7 @@
1A85B2AD0A1B2A6D00D8C87C /* HTMLDivElement.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = HTMLDivElement.idl; sourceTree = group; };
1A85B2B40A1B2AC700D8C87C /* JSHTMLDivElement.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLDivElement.cpp; sourceTree = group; };
1A85B2B50A1B2AC700D8C87C /* JSHTMLDivElement.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSHTMLDivElement.h; sourceTree = group; };
+ 1A874ADE19085E9100B03171 /* WAKViewInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WAKViewInternal.h; sourceTree = group; };
[webkit-changes] [167731] trunk/Tools
Title: [167731] trunk/Tools
Revision 167731
Author jcr...@apple.com
Date 2014-04-23 17:08:28 -0700 (Wed, 23 Apr 2014)
Log Message
Unreviewed. Moving myself from Contributors to Committers list.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (167730 => 167731)
--- trunk/Tools/ChangeLog 2014-04-23 23:17:49 UTC (rev 167730)
+++ trunk/Tools/ChangeLog 2014-04-24 00:08:28 UTC (rev 167731)
@@ -1,3 +1,9 @@
+2014-04-23 James Craig jcr...@apple.com
+
+Unreviewed. Moving myself from Contributors to Committers list.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2014-04-23 Tim Horton timothy_hor...@apple.com
Mock scrollbars don't always work in DumpRenderTree
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (167730 => 167731)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-04-23 23:17:49 UTC (rev 167730)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-04-24 00:08:28 UTC (rev 167731)
@@ -1130,6 +1130,15 @@
fawek
]
},
+ James Craig : {
+ emails : [
+jcr...@apple.com,
+ja...@cookiecrook.com
+ ],
+ nicks : [
+jcraig
+ ]
+ },
James Hawkins : {
emails : [
jhawk...@chromium.org,
@@ -2999,15 +3008,6 @@
hixie
]
},
- James Craig : {
- emails : [
-jcr...@apple.com,
-ja...@cookiecrook.com
- ],
- nicks : [
-jcraig
- ]
- },
Javier Fernandez : {
emails : [
jfernan...@igalia.com
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167732] trunk
Title: [167732] trunk Revision 167732 Author a...@apple.com Date 2014-04-23 17:32:14 -0700 (Wed, 23 Apr 2014) Log Message Eliminate internals.setMockScrollbarsEnabled() https://bugs.webkit.org/show_bug.cgi?id=132085 Reviewed by Tim Horton. Source/WebCore: This was essentially unused, and also didnt work. * testing/InternalSettings.cpp: (WebCore::InternalSettings::Backup::restoreTo): (WebCore::InternalSettings::setMockScrollbarsEnabled): Deleted. * testing/InternalSettings.h: * testing/InternalSettings.idl: Tools: * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): No need to reset the preference, there is no way it can change. LayoutTests: Remove calls, all of which were resetting it to true (which is the default, and the only value that makes sense). * compositing/geometry/fixed-position.html: * compositing/geometry/horizontal-scroll-composited.html: * compositing/geometry/vertical-scroll-composited.html: * compositing/iframes/resources/scrollgrandchild-inner.html: * compositing/overflow/fixed-position-ancestor-clip.html: * compositing/resources/mock_scrollbars.js: Removed. * css3/filters/blur-filter-page-scroll-parents.html: * css3/filters/blur-filter-page-scroll-self.html: * css3/filters/blur-filter-page-scroll.html: * fast/dom/window-scroll-scaling.html: * fast/events/touch/gesture/gesture-scrollbar.html: * fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: * fast/sub-pixel/transformed-iframe-copy-on-scroll.html: * media/video-controls-rendering.html: * media/video-zoom.html: * scrollingcoordinator/resources/non-fast-scrollable-region-testing.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/compositing/geometry/fixed-position.html trunk/LayoutTests/compositing/geometry/horizontal-scroll-composited.html trunk/LayoutTests/compositing/geometry/vertical-scroll-composited.html trunk/LayoutTests/compositing/iframes/resources/scrollgrandchild-inner.html trunk/LayoutTests/compositing/overflow/fixed-position-ancestor-clip.html trunk/LayoutTests/css3/filters/blur-filter-page-scroll-parents.html trunk/LayoutTests/css3/filters/blur-filter-page-scroll-self.html trunk/LayoutTests/css3/filters/blur-filter-page-scroll.html trunk/LayoutTests/fast/dom/window-scroll-scaling.html trunk/LayoutTests/fast/events/touch/gesture/gesture-scrollbar.html trunk/LayoutTests/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html trunk/LayoutTests/fast/sub-pixel/transformed-iframe-copy-on-scroll.html trunk/LayoutTests/media/video-controls-rendering.html trunk/LayoutTests/media/video-zoom.html trunk/LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/testing/InternalSettings.cpp trunk/Source/WebCore/testing/InternalSettings.h trunk/Source/WebCore/testing/InternalSettings.idl trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm Removed Paths trunk/LayoutTests/compositing/resources/mock_scrollbars.js Diff Modified: trunk/LayoutTests/ChangeLog (167731 => 167732) --- trunk/LayoutTests/ChangeLog 2014-04-24 00:08:28 UTC (rev 167731) +++ trunk/LayoutTests/ChangeLog 2014-04-24 00:32:14 UTC (rev 167732) @@ -1,3 +1,30 @@ +2014-04-23 Alexey Proskuryakov a...@apple.com + +Eliminate internals.setMockScrollbarsEnabled() +https://bugs.webkit.org/show_bug.cgi?id=132085 + +Reviewed by Tim Horton. + +Remove calls, all of which were resetting it to true (which is the default, and +the only value that makes sense). + +* compositing/geometry/fixed-position.html: +* compositing/geometry/horizontal-scroll-composited.html: +* compositing/geometry/vertical-scroll-composited.html: +* compositing/iframes/resources/scrollgrandchild-inner.html: +* compositing/overflow/fixed-position-ancestor-clip.html: +* compositing/resources/mock_scrollbars.js: Removed. +* css3/filters/blur-filter-page-scroll-parents.html: +* css3/filters/blur-filter-page-scroll-self.html: +* css3/filters/blur-filter-page-scroll.html: +* fast/dom/window-scroll-scaling.html: +* fast/events/touch/gesture/gesture-scrollbar.html: +* fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: +* fast/sub-pixel/transformed-iframe-copy-on-scroll.html: +* media/video-controls-rendering.html: +* media/video-zoom.html: +* scrollingcoordinator/resources/non-fast-scrollable-region-testing.js: + 2014-04-23 David Hyatt hy...@apple.com [New Multicolumn] Crasher when clearing out a flow thread in multicolumn layout. Modified: trunk/LayoutTests/compositing/geometry/fixed-position.html (167731 => 167732) --- trunk/LayoutTests/compositing/geometry/fixed-position.html 2014-04-24 00:08:28 UTC (rev 167731) +++ trunk/LayoutTests/compositing/geometry/fixed-position.html 2014-04-24 00:32:14 UTC (rev 167732) @@ -5,7 +5,6 @@ head meta http-equiv=Content-Type
[webkit-changes] [167733] trunk/Source/JavaScriptCore
Title: [167733] trunk/Source/_javascript_Core
Revision 167733
Author mark@apple.com
Date 2014-04-23 17:43:15 -0700 (Wed, 23 Apr 2014)
Log Message
The GC should only resume compiler threads that it suspended in the same GC pass.
https://webkit.org/b/132088
Reviewed by Mark Hahnenberg.
Previously, this scenario can occur:
1. Thread 1 starts a GC and tries to suspend DFG worklist threads. However,
no worklists were created yet at the that time.
2. Thread 2 starts to compile some functions and creates a DFG worklist, and
acquires the worklist thread's lock.
3. Thread 1's GC completes and tries to resume suspended DFG worklist thread.
This time, it sees the worklist created by Thread 2 and ends up unlocking
the worklist thread's lock that is supposedly held by Thread 2.
Thereafter, chaos ensues.
The fix is to cache the worklists that were actually suspended by each GC pass,
and only resume those when the GC is done.
This issue was discovered by enabling COLLECT_ON_EVERY_ALLOCATION and running
the fast/workers layout tests.
* heap/Heap.cpp:
(JSC::Heap::visitCompilerWorklists):
(JSC::Heap::deleteAllCompiledCode):
(JSC::Heap::suspendCompilerThreads):
(JSC::Heap::resumeCompilerThreads):
* heap/Heap.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (167732 => 167733)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-24 00:32:14 UTC (rev 167732)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-24 00:43:15 UTC (rev 167733)
@@ -1,3 +1,33 @@
+2014-04-23 Mark Lam mark@apple.com
+
+The GC should only resume compiler threads that it suspended in the same GC pass.
+https://webkit.org/b/132088
+
+Reviewed by Mark Hahnenberg.
+
+Previously, this scenario can occur:
+1. Thread 1 starts a GC and tries to suspend DFG worklist threads. However,
+ no worklists were created yet at the that time.
+2. Thread 2 starts to compile some functions and creates a DFG worklist, and
+ acquires the worklist thread's lock.
+3. Thread 1's GC completes and tries to resume suspended DFG worklist thread.
+ This time, it sees the worklist created by Thread 2 and ends up unlocking
+ the worklist thread's lock that is supposedly held by Thread 2.
+Thereafter, chaos ensues.
+
+The fix is to cache the worklists that were actually suspended by each GC pass,
+and only resume those when the GC is done.
+
+This issue was discovered by enabling COLLECT_ON_EVERY_ALLOCATION and running
+the fast/workers layout tests.
+
+* heap/Heap.cpp:
+(JSC::Heap::visitCompilerWorklists):
+(JSC::Heap::deleteAllCompiledCode):
+(JSC::Heap::suspendCompilerThreads):
+(JSC::Heap::resumeCompilerThreads):
+* heap/Heap.h:
+
2014-04-23 Mark Hahnenberg mhahnenb...@apple.com
Arguments::copyBackingStore needs to update m_registers in tandem with m_registerArray
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (167732 => 167733)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2014-04-24 00:32:14 UTC (rev 167732)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2014-04-24 00:43:15 UTC (rev 167733)
@@ -626,10 +626,8 @@
{
#if ENABLE(DFG_JIT)
GCPHASE(VisitDFGWorklists);
-for (unsigned i = DFG::numberOfWorklists(); i--;) {
-if (DFG::Worklist* worklist = DFG::worklistForIndexOrNull(i))
-worklist-visitChildren(m_slotVisitor, m_codeBlocks);
-}
+for (auto worklist : m_suspendedCompilerWorklists)
+worklist-visitChildren(m_slotVisitor, m_codeBlocks);
if (Options::logGC() == GCLogging::Verbose)
dataLog(DFG Worklists:\n, m_slotVisitor);
@@ -881,11 +879,9 @@
// means that we are running some hot JS code right now. Maybe causing
// recompilations isn't a good idea.
#if ENABLE(DFG_JIT)
-for (unsigned i = DFG::numberOfWorklists(); i--;) {
-if (DFG::Worklist* worklist = DFG::worklistForIndexOrNull(i)) {
-if (worklist-isActiveForVM(*vm()))
-return;
-}
+for (auto worklist : m_suspendedCompilerWorklists) {
+if (worklist-isActiveForVM(*vm()))
+return;
}
#endif // ENABLE(DFG_JIT)
@@ -1022,9 +1018,12 @@
{
#if ENABLE(DFG_JIT)
GCPHASE(SuspendCompilerThreads);
+ASSERT(m_suspendedCompilerWorklists.isEmpty());
for (unsigned i = DFG::numberOfWorklists(); i--;) {
-if (DFG::Worklist* worklist = DFG::worklistForIndexOrNull(i))
+if (DFG::Worklist* worklist = DFG::worklistForIndexOrNull(i)) {
+m_suspendedCompilerWorklists.append(worklist);
worklist-suspendAllThreads();
+}
}
#endif
}
@@ -1227,10 +1226,9 @@
{
#if ENABLE(DFG_JIT)
GCPHASE(ResumeCompilerThreads);
-for (unsigned i =
[webkit-changes] [167734] trunk/Source/WebCore
Title: [167734] trunk/Source/WebCore Revision 167734 Author bfulg...@apple.com Date 2014-04-23 18:23:58 -0700 (Wed, 23 Apr 2014) Log Message [Mac, iOS] Stop buffering media when on an inactive tab. https://bugs.webkit.org/show_bug.cgi?id=132077 Reviewed by Eric Carlson. * html/HTMLMediaElement.cpp: Rename 'm_isDisplaySleepDisablingSuspended' to 'm_elementIsHidden'. (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::visibilityStatusChanged): Notify the media session that the element is (or is not) hidden. (WebCore::HTMLMediaElement::setShouldBufferData): Added. * html/HTMLMediaElement.h: * platform/audio/MediaSession.cpp: (WebCore::MediaSession::clientWillBeginPlayback): Tell media to buffer if not hidden or playing. (WebCore::MediaSession::clientWillPausePlayback): Ditto. (WebCore::MediaSession::visibilityChanged): Added. Client API, just relays call to updateClientDataBuffering. (WebCore::MediaSession::updateClientDataBuffering): Tell client it should only buffer data if it's currently playing, or not hidden. * platform/audio/MediaSession.h: * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setShouldBufferData): Added: Just relays to MediaPlayerPrivate object. * platform/graphics/MediaPlayer.h: * platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setShouldBufferData): * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): (WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldBufferData): Added. Detach the player item from the player if we don't want to continue buffering or other background tasks. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h trunk/Source/WebCore/platform/audio/MediaSession.cpp trunk/Source/WebCore/platform/audio/MediaSession.h trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp trunk/Source/WebCore/platform/graphics/MediaPlayer.h trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm Diff Modified: trunk/Source/WebCore/ChangeLog (167733 => 167734) --- trunk/Source/WebCore/ChangeLog 2014-04-24 00:43:15 UTC (rev 167733) +++ trunk/Source/WebCore/ChangeLog 2014-04-24 01:23:58 UTC (rev 167734) @@ -1,3 +1,39 @@ +2014-04-23 Brent Fulgham bfulg...@apple.com + +[Mac, iOS] Stop buffering media when on an inactive tab. +https://bugs.webkit.org/show_bug.cgi?id=132077 + +Reviewed by Eric Carlson. + +* html/HTMLMediaElement.cpp: Rename 'm_isDisplaySleepDisablingSuspended' +to 'm_elementIsHidden'. +(WebCore::HTMLMediaElement::HTMLMediaElement): +(WebCore::HTMLMediaElement::visibilityStatusChanged): Notify the +media session that the element is (or is not) hidden. +(WebCore::HTMLMediaElement::setShouldBufferData): Added. +* html/HTMLMediaElement.h: +* platform/audio/MediaSession.cpp: +(WebCore::MediaSession::clientWillBeginPlayback): Tell media to +buffer if not hidden or playing. +(WebCore::MediaSession::clientWillPausePlayback): Ditto. +(WebCore::MediaSession::visibilityChanged): Added. Client API, just relays call +to updateClientDataBuffering. +(WebCore::MediaSession::updateClientDataBuffering): Tell client it should only +buffer data if it's currently playing, or not hidden. +* platform/audio/MediaSession.h: +* platform/graphics/MediaPlayer.cpp: +(WebCore::MediaPlayer::setShouldBufferData): Added: Just relays to +MediaPlayerPrivate object. +* platform/graphics/MediaPlayer.h: +* platform/graphics/MediaPlayerPrivate.h: +(WebCore::MediaPlayerPrivateInterface::setShouldBufferData): +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: +(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): +(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldBufferData): Added. +Detach the player item from the player if we don't want to continue +buffering or other background tasks. + 2014-04-23 Alexey Proskuryakov a...@apple.com Eliminate internals.setMockScrollbarsEnabled() Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (167733 => 167734) --- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-04-24 00:43:15 UTC (rev 167733) +++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-04-24 01:23:58 UTC (rev 167734) @@ -325,7 +325,7 @@ , m_havePreparedToPlay(false)
[webkit-changes] [167735] trunk/Source
Title: [167735] trunk/Source Revision 167735 Author benja...@webkit.org Date 2014-04-23 19:13:06 -0700 (Wed, 23 Apr 2014) Log Message [iOS][WK2] Fix a few mistakes affecting the initial layout and the initial unobscured rect https://bugs.webkit.org/show_bug.cgi?id=132093 Source/WebCore: Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-23 Reviewed by Tim Horton. Change the minimum layout size to float point values to account for size defined on retina displays. The minimum layout size supports half-pixels, the value is rounded later when computing the layout size in document coordinates. * WebCore.exp.in: * page/ViewportConfiguration.cpp: (WebCore::ViewportConfiguration::ViewportConfiguration): Setting the initial content size is incorrect. The layout size computation already take into account empty size for the first layout. Setting the content size upfront make the first computation incorrect when the viewport arguments specify the initial scale. (WebCore::ViewportConfiguration::setMinimumLayoutSize): * page/ViewportConfiguration.h: (WebCore::ViewportConfiguration::minimumLayoutSize): Source/WebKit2: rdar://problem/16703237 Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-23 Reviewed by Tim Horton. The user of WKWebView can setup a size on device pixels, which can add half a point to the minimum layout size. By rounding this up before applying the page scale, we ended up with rounding errors on the layout size and the transitory unobscured content rect. This patch fixes changes the minimal layout size to float point values to reduce the rounding problems. * UIProcess/API/Cocoa/WKWebView.mm: (setViewportConfigurationMinimumLayoutSize): (-[WKWebView _setMinimumLayoutSizeOverrideForMinimalUI:]): (-[WKWebView _beginAnimatedResizeWithUpdates:]): * UIProcess/WebPageProxy.h: * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::dynamicViewportSizeUpdate): (WebKit::WebPageProxy::setViewportConfigurationMinimumLayoutSize): (WebKit::WebPageProxy::setMinimumLayoutSizeForMinimalUI): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad): Defaulting the content size to the minimum layout size only works if the initial-scale is 1. ViewportConfiguration knows exactly what to do before the first layout. * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::setViewportConfigurationMinimumLayoutSize): (WebKit::WebPage::setMinimumLayoutSizeForMinimalUI): (WebKit::WebPage::dynamicViewportSizeUpdate): A few fixes here: -setZoomedOutPageScaleFactor() was incorrectly using the initial scale. 99% of the time, initial scale and minimum scale are equal, but the page can specify something different with the viewport meta tag. -Use floating point for manipulating the minimum layout sizes, then round the value. -minimumLayoutSizeInDocumentCoordinate was scaled the wrong way around. (WebKit::WebPage::viewportConfigurationChanged): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/page/ViewportConfiguration.cpp trunk/Source/WebCore/page/ViewportConfiguration.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm Diff Modified: trunk/Source/WebCore/ChangeLog (167734 => 167735) --- trunk/Source/WebCore/ChangeLog 2014-04-24 01:23:58 UTC (rev 167734) +++ trunk/Source/WebCore/ChangeLog 2014-04-24 02:13:06 UTC (rev 167735) @@ -1,3 +1,27 @@ +2014-04-23 Benjamin Poulain bpoul...@apple.com + +[iOS][WK2] Fix a few mistakes affecting the initial layout and the initial unobscured rect +https://bugs.webkit.org/show_bug.cgi?id=132093 + +Reviewed by Tim Horton. + +Change the minimum layout size to float point values to account for size defined on retina displays. +The minimum layout size supports half-pixels, the value is rounded later when computing the layout size +in document coordinates. + +* WebCore.exp.in: +* page/ViewportConfiguration.cpp: +(WebCore::ViewportConfiguration::ViewportConfiguration): +Setting the initial content size is incorrect. The layout size computation already take into account +empty size for the first layout. + +Setting the content size upfront make the first computation incorrect when the viewport arguments specify +the initial scale. + +(WebCore::ViewportConfiguration::setMinimumLayoutSize): +* page/ViewportConfiguration.h: +(WebCore::ViewportConfiguration::minimumLayoutSize): + 2014-04-23 Brent Fulgham bfulg...@apple.com [Mac, iOS] Stop
[webkit-changes] [167736] trunk/Tools
Title: [167736] trunk/Tools Revision 167736 Author ander...@apple.com Date 2014-04-23 19:23:32 -0700 (Wed, 23 Apr 2014) Log Message Try to fix iOS build. * DumpRenderTree/mac/DumpRenderTree.mm: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm Diff Modified: trunk/Tools/ChangeLog (167735 => 167736) --- trunk/Tools/ChangeLog 2014-04-24 02:13:06 UTC (rev 167735) +++ trunk/Tools/ChangeLog 2014-04-24 02:23:32 UTC (rev 167736) @@ -1,3 +1,9 @@ +2014-04-23 Anders Carlsson ander...@apple.com + +Try to fix iOS build. + +* DumpRenderTree/mac/DumpRenderTree.mm: + 2014-04-23 Alexey Proskuryakov a...@apple.com Eliminate internals.setMockScrollbarsEnabled() Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (167735 => 167736) --- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2014-04-24 02:13:06 UTC (rev 167735) +++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2014-04-24 02:23:32 UTC (rev 167736) @@ -105,7 +105,6 @@ #import UIKit/UIMath.h #import UIKit/UIWebBrowserView.h #import UIKit/UIWebScrollView.h -#import WebKit/WAKViewPrivate.h #import WebKit/WAKWindow.h #import WebKit/WebCoreThread.h #import WebKit/WebCoreThreadRun.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167737] trunk/Source/WebKit/efl
Title: [167737] trunk/Source/WebKit/efl
Revision 167737
Author commit-qu...@webkit.org
Date 2014-04-23 19:25:08 -0700 (Wed, 23 Apr 2014)
Log Message
[EFL][WK1] Add *const* keyword to _get() APIs
https://bugs.webkit.org/show_bug.cgi?id=132094
Patch by Hyowon Kim hw1008@samsung.com on 2014-04-23
Reviewed by Gyuyoung Kim.
Some _get() EFL APIs don't have *const* keyword though the _get() APIs don't modify passed argument.
We need to add *const* keyword to those APIs.
* ewk/ewk_history.cpp:
(ewk_history_limit_get):
* ewk/ewk_history.h:
* ewk/ewk_js.cpp:
(ewk_js_object_type_get):
* ewk/ewk_js.h:
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_history.cpp
trunk/Source/WebKit/efl/ewk/ewk_history.h
trunk/Source/WebKit/efl/ewk/ewk_js.cpp
trunk/Source/WebKit/efl/ewk/ewk_js.h
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (167736 => 167737)
--- trunk/Source/WebKit/efl/ChangeLog 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ChangeLog 2014-04-24 02:25:08 UTC (rev 167737)
@@ -1,3 +1,20 @@
+2014-04-23 Hyowon Kim hw1008@samsung.com
+
+[EFL][WK1] Add *const* keyword to _get() APIs
+https://bugs.webkit.org/show_bug.cgi?id=132094
+
+Reviewed by Gyuyoung Kim.
+
+Some _get() EFL APIs don't have *const* keyword though the _get() APIs don't modify passed argument.
+We need to add *const* keyword to those APIs.
+
+* ewk/ewk_history.cpp:
+(ewk_history_limit_get):
+* ewk/ewk_history.h:
+* ewk/ewk_js.cpp:
+(ewk_js_object_type_get):
+* ewk/ewk_js.h:
+
2014-04-22 Ryuan Choi ryuan.c...@samsung.com
[EFL][WK1] There are many failures in fast/forms since r163033
Modified: trunk/Source/WebKit/efl/ewk/ewk_history.cpp (167736 => 167737)
--- trunk/Source/WebKit/efl/ewk/ewk_history.cpp 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_history.cpp 2014-04-24 02:25:08 UTC (rev 167737)
@@ -219,7 +219,7 @@
return core-backListCount();
}
-int ewk_history_limit_get(Ewk_History* history)
+int ewk_history_limit_get(const Ewk_History* history)
{
EWK_HISTORY_CORE_GET_OR_RETURN(history, core, 0);
return core-capacity();
Modified: trunk/Source/WebKit/efl/ewk/ewk_history.h (167736 => 167737)
--- trunk/Source/WebKit/efl/ewk/ewk_history.h 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_history.h 2014-04-24 02:25:08 UTC (rev 167737)
@@ -251,7 +251,7 @@
*
* @return maximum number of entries this history will hold.
*/
-EAPI int ewk_history_limit_get(Ewk_History *history);
+EAPI int ewk_history_limit_get(const Ewk_History *history);
/**
* Set maximum capacity of given history.
Modified: trunk/Source/WebKit/efl/ewk/ewk_js.cpp (167736 => 167737)
--- trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2014-04-24 02:25:08 UTC (rev 167737)
@@ -693,7 +693,7 @@
#endif
}
-Ewk_JS_Object_Type ewk_js_object_type_get(Ewk_JS_Object* jsObject)
+Ewk_JS_Object_Type ewk_js_object_type_get(const Ewk_JS_Object* jsObject)
{
#if ENABLE(NETSCAPE_PLUGIN_API)
EINA_SAFETY_ON_NULL_RETURN_VAL(jsObject, EWK_JS_OBJECT_OBJECT);
Modified: trunk/Source/WebKit/efl/ewk/ewk_js.h (167736 => 167737)
--- trunk/Source/WebKit/efl/ewk/ewk_js.h 2014-04-24 02:23:32 UTC (rev 167736)
+++ trunk/Source/WebKit/efl/ewk/ewk_js.h 2014-04-24 02:25:08 UTC (rev 167737)
@@ -191,7 +191,7 @@
* @return @c EWK_JS_OBJECT if it is an object, @c EWK_JS_ARRAY if it is an array and
* @c EWK_JS_FUNCTION if it is a function.
*/
-EAPI Ewk_JS_Object_Type ewk_js_object_type_get(Ewk_JS_Object *obj);
+EAPI Ewk_JS_Object_Type ewk_js_object_type_get(const Ewk_JS_Object *obj);
/**
* Sets the type this object represents.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167738] trunk/Source/WebKit2
Title: [167738] trunk/Source/WebKit2
Revision 167738
Author benja...@webkit.org
Date 2014-04-23 19:37:05 -0700 (Wed, 23 Apr 2014)
Log Message
[iOS][WK2] Image and text documents sometime gets the webpage viewport configuration
https://bugs.webkit.org/show_bug.cgi?id=132099
Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-23
Reviewed by Tim Horton.
When didReceiveMobileDocType(), if the doctype was not XHTML mobile, we were setting
the viewport configuration to webpageParameters(). This is obviously not correct for
Image and Text documents.
This patch moves the code deciding the default configuration out of WebPage::didCommitLoad()
and use it from WebPage::didCommitLoad() and WebPage::didReceiveMobileDocType().
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::didReceiveMobileDocType):
(WebKit::WebPage::resetViewportDefaultConfiguration):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (167737 => 167738)
--- trunk/Source/WebKit2/ChangeLog 2014-04-24 02:25:08 UTC (rev 167737)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-24 02:37:05 UTC (rev 167738)
@@ -1,5 +1,26 @@
2014-04-23 Benjamin Poulain bpoul...@apple.com
+[iOS][WK2] Image and text documents sometime gets the webpage viewport configuration
+https://bugs.webkit.org/show_bug.cgi?id=132099
+
+Reviewed by Tim Horton.
+
+When didReceiveMobileDocType(), if the doctype was not XHTML mobile, we were setting
+the viewport configuration to webpageParameters(). This is obviously not correct for
+Image and Text documents.
+
+This patch moves the code deciding the default configuration out of WebPage::didCommitLoad()
+and use it from WebPage::didCommitLoad() and WebPage::didReceiveMobileDocType().
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::didCommitLoad):
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::didReceiveMobileDocType):
+(WebKit::WebPage::resetViewportDefaultConfiguration):
+
+2014-04-23 Benjamin Poulain bpoul...@apple.com
+
[iOS][WK2] Fix a few mistakes affecting the initial layout and the initial unobscured rect
https://bugs.webkit.org/show_bug.cgi?id=132093
rdar://problem/16703237
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (167737 => 167738)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-04-24 02:25:08 UTC (rev 167737)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-04-24 02:37:05 UTC (rev 167738)
@@ -4254,14 +4254,7 @@
WebProcess::shared().eventDispatcher().clearQueuedTouchEventsForPage(*this);
-Document* document = frame-coreFrame()-document();
-if (document-isImageDocument())
-m_viewportConfiguration.setDefaultConfiguration(ViewportConfiguration::imageDocumentParameters());
-else if (document-isTextDocument())
-m_viewportConfiguration.setDefaultConfiguration(ViewportConfiguration::textDocumentParameters());
-else
-m_viewportConfiguration.setDefaultConfiguration(ViewportConfiguration::webpageParameters());
-
+resetViewportDefaultConfiguration(frame);
m_viewportConfiguration.setViewportArguments(ViewportArguments());
m_viewportConfiguration.setContentsSize(IntSize());
viewportConfigurationChanged();
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (167737 => 167738)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2014-04-24 02:25:08 UTC (rev 167737)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2014-04-24 02:37:05 UTC (rev 167738)
@@ -698,7 +698,6 @@
void setViewportConfigurationMinimumLayoutSize(const WebCore::FloatSize);
void setMinimumLayoutSizeForMinimalUI(const WebCore::FloatSize);
void dynamicViewportSizeUpdate(const WebCore::FloatSize minimumLayoutSize, const WebCore::FloatRect targetExposedContentRect, const WebCore::FloatRect targetUnobscuredRect, double scale);
-void viewportConfigurationChanged();
void updateVisibleContentRects(const VisibleContentRectUpdateInfo);
bool scaleWasSetByUIProcess() const { return m_scaleWasSetByUIProcess; }
void willStartUserTriggeredZooming();
@@ -802,6 +801,9 @@
void didReceiveSyncWebPageMessage(IPC::Connection*, IPC::MessageDecoder, std::unique_ptrIPC::MessageEncoder);
#if PLATFORM(IOS)
+void resetViewportDefaultConfiguration(WebFrame* mainFrame);
+void viewportConfigurationChanged();
+
static void convertSelectionRectsToRootView(WebCore::FrameView*, VectorWebCore::SelectionRect);
PassRefPtrWebCore::Range rangeForWebSelectionAtPosition(const WebCore::IntPoint, const
[webkit-changes] [167739] trunk/Source/WebKit2
Title: [167739] trunk/Source/WebKit2 Revision 167739 Author simon.fra...@apple.com Date 2014-04-23 20:31:28 -0700 (Wed, 23 Apr 2014) Log Message Nonopaque layers double-paint with UI-side compositing https://bugs.webkit.org/show_bug.cgi?id=132101 Reviewed by Tim Horton. The non-IOSurface code path was failing to clear the backing store before painting. * Shared/mac/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::display): (WebKit::RemoteLayerBackingStore::drawInContext): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (167738 => 167739) --- trunk/Source/WebKit2/ChangeLog 2014-04-24 02:37:05 UTC (rev 167738) +++ trunk/Source/WebKit2/ChangeLog 2014-04-24 03:31:28 UTC (rev 167739) @@ -1,3 +1,17 @@ +2014-04-23 Simon Fraser simon.fra...@apple.com + +Nonopaque layers double-paint with UI-side compositing +https://bugs.webkit.org/show_bug.cgi?id=132101 + +Reviewed by Tim Horton. + +The non-IOSurface code path was failing to clear the backing store +before painting. + +* Shared/mac/RemoteLayerBackingStore.mm: +(WebKit::RemoteLayerBackingStore::display): +(WebKit::RemoteLayerBackingStore::drawInContext): + 2014-04-23 Benjamin Poulain bpoul...@apple.com [iOS][WK2] Image and text documents sometime gets the webpage viewport configuration Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm (167738 => 167739) --- trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm 2014-04-24 02:37:05 UTC (rev 167738) +++ trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm 2014-04-24 03:31:28 UTC (rev 167739) @@ -212,14 +212,6 @@ GraphicsContext context = m_frontSurface-ensureGraphicsContext(); -if (!m_isOpaque) -context.clearRect(expandedScaledLayerBounds); - -#ifndef NDEBUG -if (m_isOpaque) -context.fillRect(expandedScaledLayerBounds, Color(255, 0, 0), ColorSpaceDeviceRGB); -#endif - context.scale(FloatSize(1, -1)); context.translate(0, -expandedScaledSize.height()); drawInContext(context, backImage.get()); @@ -251,6 +243,14 @@ IntRect layerBounds(IntPoint(), m_size); IntRect scaledLayerBounds(IntPoint(), expandedIntSize(m_size * m_scale)); +if (!m_isOpaque) +context.clearRect(scaledLayerBounds); + +#ifndef NDEBUG +if (m_isOpaque) +context.fillRect(scaledLayerBounds, Color(255, 0, 0), ColorSpaceDeviceRGB); +#endif + CGContextRef cgContext = context.platformContext(); // If we have less than webLayerMaxRectsToPaint rects to paint and they cover less ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167740] trunk/Source/WebKit2
Title: [167740] trunk/Source/WebKit2
Revision 167740
Author simon.fra...@apple.com
Date 2014-04-23 20:31:30 -0700 (Wed, 23 Apr 2014)
Log Message
[iOS WK2] Make -webkit-overflow-scrolling:touch work
https://bugs.webkit.org/show_bug.cgi?id=132097
Reviewed by Tim Horton.
Scrolling of UIScrollViews in content (for -webkit-overflow-scrolling:touch)
depends on them getting hit-tested correctly. UIKit hit testing assumes
that subviews are enclosed by their ancestors, but this is not true of
web content. In addition, we had a root layer that was zero sized.
Fix by overriding hitTest:withEvent: on our content WKViews to hit
test subviews even if they are not enclosed.
* UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(-[UIView _recursiveFindDescendantViewAtPoint:withEvent:]):
(-[UIView _findDescendantViewAtPoint:withEvent:]):
(-[WKCompositingView hitTest:withEvent:]):
(-[WKTransformView hitTest:withEvent:]):
(-[WKRemoteView hitTest:withEvent:]):
(WebKit::RemoteLayerTreeHost::createLayer):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
Update debug borders on the root layer.
(WebKit::RemoteLayerTreeDrawingArea::mainFrameContentSizeChanged):
Size the root layer to the contents size. This isn't strictly necessary
given the hit testing overrides, but seems sensible to do anyway.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (167739 => 167740)
--- trunk/Source/WebKit2/ChangeLog 2014-04-24 03:31:28 UTC (rev 167739)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-24 03:31:30 UTC (rev 167740)
@@ -1,5 +1,34 @@
2014-04-23 Simon Fraser simon.fra...@apple.com
+[iOS WK2] Make -webkit-overflow-scrolling:touch work
+https://bugs.webkit.org/show_bug.cgi?id=132097
+
+Reviewed by Tim Horton.
+
+Scrolling of UIScrollViews in content (for -webkit-overflow-scrolling:touch)
+depends on them getting hit-tested correctly. UIKit hit testing assumes
+that subviews are enclosed by their ancestors, but this is not true of
+web content. In addition, we had a root layer that was zero sized.
+
+Fix by overriding hitTest:withEvent: on our content WKViews to hit
+test subviews even if they are not enclosed.
+
+* UIProcess/ios/RemoteLayerTreeHostIOS.mm:
+(-[UIView _recursiveFindDescendantViewAtPoint:withEvent:]):
+(-[UIView _findDescendantViewAtPoint:withEvent:]):
+(-[WKCompositingView hitTest:withEvent:]):
+(-[WKTransformView hitTest:withEvent:]):
+(-[WKRemoteView hitTest:withEvent:]):
+(WebKit::RemoteLayerTreeHost::createLayer):
+* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
+(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
+Update debug borders on the root layer.
+(WebKit::RemoteLayerTreeDrawingArea::mainFrameContentSizeChanged):
+Size the root layer to the contents size. This isn't strictly necessary
+given the hit testing overrides, but seems sensible to do anyway.
+
+2014-04-23 Simon Fraser simon.fra...@apple.com
+
Nonopaque layers double-paint with UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=132101
Modified: trunk/Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm (167739 => 167740)
--- trunk/Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm 2014-04-24 03:31:28 UTC (rev 167739)
+++ trunk/Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm 2014-04-24 03:31:30 UTC (rev 167740)
@@ -41,6 +41,53 @@
- (void)setContextId:(uint32_t)contextID;
@end
+@interface UIView (WKHitTesting)
+- (UIView *)_findDescendantViewAtPoint:(CGPoint)point withEvent:(UIEvent *)event;
+@end
+
+@implementation UIView (WKHitTesting)
+
+// UIView hit testing assumes that views should only hit test subviews that are entirely contained
+// in the view. This is not true of web content.
+- (UIView *)_recursiveFindDescendantViewAtPoint:(CGPoint)point withEvent:(UIEvent *)event
+{
+if (self.clipsToBounds ![self pointInside:point withEvent:event])
+return nil;
+
+__block UIView *foundView = nil;
+[[self subviews] enumerateObjectsUsingBlock:^(UIView *view, NSUInteger idx, BOOL *stop) {
+CGPoint subviewPoint = [view convertPoint:point fromView:self];
+
+if ([view pointInside:subviewPoint withEvent:event])
+foundView = view;
+
+if (![view subviews])
+return;
+
+if (UIView *hitView = [view _recursiveFindDescendantViewAtPoint:subviewPoint withEvent:event])
+foundView = hitView;
+}];
+
+return foundView;
+}
+
+- (UIView *)_findDescendantViewAtPoint:(CGPoint)point withEvent:(UIEvent *)event
+{
+return [self _recursiveFindDescendantViewAtPoint:point withEvent:event];
+}
[webkit-changes] [167741] trunk/Source/WebCore
Title: [167741] trunk/Source/WebCore
Revision 167741
Author akl...@apple.com
Date 2014-04-23 20:43:47 -0700 (Wed, 23 Apr 2014)
Log Message
Canvas cache of clean URLs can grow without bounds.
https://webkit.org/b/132091
rdar://problem/16695665
Remove a silly optimization that kept a cache of clean URLs
that can be drawn into a canvas without tainting it, all to avoid
the expensive checks to determine whether it would taint.
Reviewed by Benjamin Poulain.
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin):
* html/canvas/CanvasRenderingContext.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (167740 => 167741)
--- trunk/Source/WebCore/ChangeLog 2014-04-24 03:31:30 UTC (rev 167740)
+++ trunk/Source/WebCore/ChangeLog 2014-04-24 03:43:47 UTC (rev 167741)
@@ -1,3 +1,19 @@
+2014-04-23 Andreas Kling akl...@apple.com
+
+Canvas cache of clean URLs can grow without bounds.
+https://webkit.org/b/132091
+rdar://problem/16695665
+
+Remove a silly optimization that kept a cache of clean URLs
+that can be drawn into a canvas without tainting it, all to avoid
+the expensive checks to determine whether it would taint.
+
+Reviewed by Benjamin Poulain.
+
+* html/canvas/CanvasRenderingContext.cpp:
+(WebCore::CanvasRenderingContext::wouldTaintOrigin):
+* html/canvas/CanvasRenderingContext.h:
+
2014-04-23 Benjamin Poulain bpoul...@apple.com
[iOS][WK2] Fix a few mistakes affecting the initial layout and the initial unobscured rect
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext.cpp (167740 => 167741)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext.cpp 2014-04-24 03:31:30 UTC (rev 167740)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext.cpp 2014-04-24 03:43:47 UTC (rev 167741)
@@ -92,7 +92,7 @@
bool CanvasRenderingContext::wouldTaintOrigin(const URL url)
{
-if (!canvas()-originClean() || m_cleanURLs.contains(url.string()))
+if (!canvas()-originClean())
return false;
if (canvas()-securityOrigin()-taintsCanvas(url))
@@ -101,7 +101,6 @@
if (url.protocolIsData())
return false;
-m_cleanURLs.add(url.string());
return false;
}
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext.h (167740 => 167741)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext.h 2014-04-24 03:31:30 UTC (rev 167740)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext.h 2014-04-24 03:43:47 UTC (rev 167741)
@@ -75,7 +75,6 @@
private:
HTMLCanvasElement* m_canvas;
-HashSetString m_cleanURLs;
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167742] trunk/Source/WebKit2
Title: [167742] trunk/Source/WebKit2
Revision 167742
Author akl...@apple.com
Date 2014-04-23 20:56:09 -0700 (Wed, 23 Apr 2014)
Log Message
Remove unused WKPageSetMemoryCacheClientCallsEnabled API.
https://webkit.org/b/132098
This API was added to WK2 back in 2011 but never actually used.
Reviewed by Anders Carlsson.
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageSetMemoryCacheClientCallsEnabled): Deleted.
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Deleted.
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setMemoryCacheMessagesEnabled): Deleted.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp
trunk/Source/WebKit2/Shared/WebPageCreationParameters.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPage.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
Diff
Modified: trunk/Source/WebKit2/ChangeLog (167741 => 167742)
--- trunk/Source/WebKit2/ChangeLog 2014-04-24 03:43:47 UTC (rev 167741)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-24 03:56:09 UTC (rev 167742)
@@ -1,3 +1,30 @@
+2014-04-23 Andreas Kling akl...@apple.com
+
+Remove unused WKPageSetMemoryCacheClientCallsEnabled API.
+https://webkit.org/b/132098
+
+This API was added to WK2 back in 2011 but never actually used.
+
+Reviewed by Anders Carlsson.
+
+* Shared/WebPageCreationParameters.cpp:
+(WebKit::WebPageCreationParameters::encode):
+(WebKit::WebPageCreationParameters::decode):
+* Shared/WebPageCreationParameters.h:
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetMemoryCacheClientCallsEnabled): Deleted.
+* UIProcess/API/C/WKPage.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::WebPageProxy):
+(WebKit::WebPageProxy::creationParameters):
+(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled): Deleted.
+* UIProcess/WebPageProxy.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::WebPage):
+(WebKit::WebPage::setMemoryCacheMessagesEnabled): Deleted.
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/WebPage.messages.in:
+
2014-04-23 Simon Fraser simon.fra...@apple.com
[iOS WK2] Make -webkit-overflow-scrolling:touch work
Modified: trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp (167741 => 167742)
--- trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp 2014-04-24 03:43:47 UTC (rev 167741)
+++ trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp 2014-04-24 03:56:09 UTC (rev 167742)
@@ -41,7 +41,6 @@
encoder drawsBackground;
encoder drawsTransparentBackground;
encoder underlayColor;
-encoder areMemoryCacheClientCallsEnabled;
encoder useFixedLayout;
encoder fixedLayoutSize;
encoder.encodeEnum(paginationMode);
@@ -95,8 +94,6 @@
return false;
if (!decoder.decode(parameters.underlayColor))
return false;
-if (!decoder.decode(parameters.areMemoryCacheClientCallsEnabled))
-return false;
if (!decoder.decode(parameters.useFixedLayout))
return false;
if (!decoder.decode(parameters.fixedLayoutSize))
Modified: trunk/Source/WebKit2/Shared/WebPageCreationParameters.h (167741 => 167742)
--- trunk/Source/WebKit2/Shared/WebPageCreationParameters.h 2014-04-24 03:43:47 UTC (rev 167741)
+++ trunk/Source/WebKit2/Shared/WebPageCreationParameters.h 2014-04-24 03:56:09 UTC (rev 167742)
@@ -69,8 +69,6 @@
WebCore::Color underlayColor;
-bool areMemoryCacheClientCallsEnabled;
-
bool useFixedLayout;
WebCore::IntSize fixedLayoutSize;
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (167741 => 167742)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-04-24 03:43:47 UTC (rev 167741)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-04-24 03:56:09 UTC (rev 167742)
@@ -295,11 +295,6 @@
return toImpl(pageRef)-estimatedProgress();
}
-void WKPageSetMemoryCacheClientCallsEnabled(WKPageRef pageRef, bool memoryCacheClientCallsEnabled)
-{
-toImpl(pageRef)-setMemoryCacheClientCallsEnabled(memoryCacheClientCallsEnabled);
-}
-
WKStringRef WKPageCopyUserAgent(WKPageRef pageRef)
{
return toCopiedAPI(toImpl(pageRef)-userAgent());
Modified:
[webkit-changes] [167743] trunk/Source/WebCore
Title: [167743] trunk/Source/WebCore
Revision 167743
Author akl...@apple.com
Date 2014-04-23 21:11:50 -0700 (Wed, 23 Apr 2014)
Log Message
CachedResourceLoader hoards URLs indefinitely for no good reason.
https://webkit.org/b/132102
rdar://problem/16708265
Since we don't care about CachedResourceLoader::m_validatedURL's after
the Document has finished dispatching its initial load event, clear the
set at that point, and don't add any new URLs to it.
Reviewed by Anders Carlsson.
* dom/Document.cpp:
(WebCore::Document::dispatchWindowLoadEvent):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::documentDidFinishLoadEvent):
* loader/cache/CachedResourceLoader.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (167742 => 167743)
--- trunk/Source/WebCore/ChangeLog 2014-04-24 03:56:09 UTC (rev 167742)
+++ trunk/Source/WebCore/ChangeLog 2014-04-24 04:11:50 UTC (rev 167743)
@@ -1,5 +1,24 @@
2014-04-23 Andreas Kling akl...@apple.com
+CachedResourceLoader hoards URLs indefinitely for no good reason.
+https://webkit.org/b/132102
+rdar://problem/16708265
+
+Since we don't care about CachedResourceLoader::m_validatedURL's after
+the Document has finished dispatching its initial load event, clear the
+set at that point, and don't add any new URLs to it.
+
+Reviewed by Anders Carlsson.
+
+* dom/Document.cpp:
+(WebCore::Document::dispatchWindowLoadEvent):
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::requestResource):
+(WebCore::CachedResourceLoader::documentDidFinishLoadEvent):
+* loader/cache/CachedResourceLoader.h:
+
+2014-04-23 Andreas Kling akl...@apple.com
+
Canvas cache of clean URLs can grow without bounds.
https://webkit.org/b/132091
rdar://problem/16695665
Modified: trunk/Source/WebCore/dom/Document.cpp (167742 => 167743)
--- trunk/Source/WebCore/dom/Document.cpp 2014-04-24 03:56:09 UTC (rev 167742)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-04-24 04:11:50 UTC (rev 167743)
@@ -3697,6 +3697,8 @@
return;
m_domWindow-dispatchLoadEvent();
m_loadEventFinished = true;
+if (m_cachedResourceLoader)
+m_cachedResourceLoader-documentDidFinishLoadEvent();
}
void Document::enqueueWindowEvent(PassRefPtrEvent event)
Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (167742 => 167743)
--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2014-04-24 03:56:09 UTC (rev 167742)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2014-04-24 04:11:50 UTC (rev 167743)
@@ -477,7 +477,7 @@
}
}
-if (!request.resourceRequest().url().protocolIsData())
+if (document() !document()-loadEventFinished() !request.resourceRequest().url().protocolIsData())
m_validatedURLs.add(request.resourceRequest().url());
ASSERT(resource-url() == url.string());
@@ -485,6 +485,11 @@
return resource;
}
+void CachedResourceLoader::documentDidFinishLoadEvent()
+{
+m_validatedURLs.clear();
+}
+
CachedResourceHandleCachedResource CachedResourceLoader::revalidateResource(const CachedResourceRequest request, CachedResource* resource)
{
ASSERT(resource);
Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.h (167742 => 167743)
--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.h 2014-04-24 03:56:09 UTC (rev 167742)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.h 2014-04-24 04:11:50 UTC (rev 167743)
@@ -133,6 +133,8 @@
static const ResourceLoaderOptions defaultCachedResourceOptions();
+void documentDidFinishLoadEvent();
+
private:
explicit CachedResourceLoader(DocumentLoader*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167744] trunk/Source/WebCore
Title: [167744] trunk/Source/WebCore
Revision 167744
Author rn...@webkit.org
Date 2014-04-23 21:24:30 -0700 (Wed, 23 Apr 2014)
Log Message
REGRESSION (r157328): popover to check into flight ba.com dismisses instantly when focusing form
https://bugs.webkit.org/show_bug.cgi?id=131949
Address the review comment.
* dom/EventDispatcher.cpp:
(WebCore::EventRelatedNodeResolver::findHostOfTreeScopeInTargetTreeScope):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventDispatcher.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (167743 => 167744)
--- trunk/Source/WebCore/ChangeLog 2014-04-24 04:11:50 UTC (rev 167743)
+++ trunk/Source/WebCore/ChangeLog 2014-04-24 04:24:30 UTC (rev 167744)
@@ -1,3 +1,13 @@
+2014-04-23 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION (r157328): popover to check into flight ba.com dismisses instantly when focusing form
+https://bugs.webkit.org/show_bug.cgi?id=131949
+
+Address the review comment.
+
+* dom/EventDispatcher.cpp:
+(WebCore::EventRelatedNodeResolver::findHostOfTreeScopeInTargetTreeScope):
+
2014-04-23 Andreas Kling akl...@apple.com
CachedResourceLoader hoards URLs indefinitely for no good reason.
Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (167743 => 167744)
--- trunk/Source/WebCore/dom/EventDispatcher.cpp 2014-04-24 04:11:50 UTC (rev 167743)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2014-04-24 04:24:30 UTC (rev 167744)
@@ -177,7 +177,7 @@
static Node* findHostOfTreeScopeInTargetTreeScope(const TreeScope startingTreeScope, const TreeScope targetScope)
{
ASSERT(targetScope != startingTreeScope);
-Node* previousHost = 0;
+Node* previousHost = nullptr;
for (const TreeScope* scope = startingTreeScope; scope; scope = scope-parentTreeScope()) {
if (scope == targetScope) {
ASSERT(previousHost);
@@ -189,7 +189,7 @@
else
ASSERT_WITH_SECURITY_IMPLICATION(!scope-parentTreeScope());
}
-return 0;
+return nullptr;
}
private:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167745] trunk/Source/WebKit/mac
Title: [167745] trunk/Source/WebKit/mac
Revision 167745
Author akl...@apple.com
Date 2014-04-23 21:42:32 -0700 (Wed, 23 Apr 2014)
Log Message
Remove Apple Dictionary workaround in WebFrameLoaderClient.
https://webkit.org/b/132095
Kill a hack to work around a WK1 client bug that got fixed years ago.
See rdar://problem/6471058 for backstory.
Reviewed by Darin Adler.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
(WebFrameLoaderClient::dispatchWillSendRequest):
(applyAppleDictionaryApplicationQuirkNonInlinePart): Deleted.
(applyAppleDictionaryApplicationQuirk): Deleted.
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (167744 => 167745)
--- trunk/Source/WebKit/mac/ChangeLog 2014-04-24 04:24:30 UTC (rev 167744)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-04-24 04:42:32 UTC (rev 167745)
@@ -1,3 +1,19 @@
+2014-04-23 Andreas Kling akl...@apple.com
+
+Remove Apple Dictionary workaround in WebFrameLoaderClient.
+https://webkit.org/b/132095
+
+Kill a hack to work around a WK1 client bug that got fixed years ago.
+See rdar://problem/6471058 for backstory.
+
+Reviewed by Darin Adler.
+
+* WebCoreSupport/WebFrameLoaderClient.mm:
+(WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
+(WebFrameLoaderClient::dispatchWillSendRequest):
+(applyAppleDictionaryApplicationQuirkNonInlinePart): Deleted.
+(applyAppleDictionaryApplicationQuirk): Deleted.
+
2014-04-23 Anders Carlsson ander...@apple.com
Don't migrate the WKView.h header from WebCore to WebKit
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (167744 => 167745)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2014-04-24 04:24:30 UTC (rev 167744)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2014-04-24 04:42:32 UTC (rev 167745)
@@ -98,7 +98,6 @@
#import WebCore/HTMLFormElement.h
#import WebCore/HTMLFrameElement.h
#import WebCore/HTMLFrameOwnerElement.h
-#import WebCore/HTMLHeadElement.h
#import WebCore/HTMLNames.h
#import WebCore/HTMLParserIdioms.h
#import WebCore/HTMLPlugInElement.h
@@ -188,52 +187,6 @@
return loader ? static_castWebDocumentLoaderMac*(loader)-dataSource() : nil;
}
-#if !PLATFORM(IOS)
-// Quirk for the Apple Dictionary application.
-//
-// If a top level frame has a script element in its head for a script named MainPageJavaScript.js,
-// then for that frame's document, ignore changes to the scrolling attribute of frames. That script
-// has a bug in it where it sets the scrolling attribute on frames, and that erroneous scrolling
-// attribute needs to be ignored to avoid showing extra scroll bars in the window.
-// This quirk can be removed when Apple Dictionary is fixed (see rdar://problem/6471058).
-
-static void applyAppleDictionaryApplicationQuirkNonInlinePart(WebFrameLoaderClient* client, const ResourceRequest request)
-{
-if (!request.url().isLocalFile())
-return;
-if (!request.url().string().endsWith(MainPageJavaScript.js))
-return;
-Frame* frame = core(client-webFrame());
-if (!frame)
-return;
-if (frame-tree().parent())
-return;
-Document* document = frame-document();
-if (!document)
-return;
-HTMLHeadElement* head = document-head();
-if (!head)
-return;
-for (Node* c = head-firstChild(); c; c = c-nextSibling()) {
-if (c-hasTagName(scriptTag) toElement(c)-getAttribute(srcAttr) == MainPageJavaScript.js) {
-document-setFrameElementsShouldIgnoreScrolling(true);
-return;
-}
-}
-}
-#endif
-
-static inline void applyAppleDictionaryApplicationQuirk(WebFrameLoaderClient* client, const ResourceRequest request)
-{
-#if !PLATFORM(IOS)
-// Use a one-time-initialized global variable so we can quickly determine there's nothing to do in
-// all applications other than Apple Dictionary.
-static bool isAppleDictionary = [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@com.apple.Dictionary];
-if (isAppleDictionary)
-applyAppleDictionaryApplicationQuirkNonInlinePart(client, request);
-#endif
-}
-
WebFrameLoaderClient::WebFrameLoaderClient(WebFrame *webFrame)
: m_webFrame(webFrame)
{
@@ -346,8 +299,6 @@
bool WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache(DocumentLoader* loader, const ResourceRequest request, const ResourceResponse response, int length)
{
-applyAppleDictionaryApplicationQuirk(this, request);
-
WebView *webView = getWebView(m_webFrame.get());
WebResourceDelegateImplementationCache* implementations = WebViewGetResourceLoadDelegateImplementations(webView);
#if PLATFORM(IOS)
@@ -390,8 +341,6 @@
void WebFrameLoaderClient::dispatchWillSendRequest(DocumentLoader* loader,
[webkit-changes] [167746] trunk/Source/WebCore
Title: [167746] trunk/Source/WebCore
Revision 167746
Author da...@apple.com
Date 2014-04-23 21:46:28 -0700 (Wed, 23 Apr 2014)
Log Message
[Cocoa] fix CF leaks found by code inspection
https://bugs.webkit.org/show_bug.cgi?id=132106
Reviewed by Andreas Kling.
* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::trackDisplayName): Added a missing adoptCF.
* platform/Language.cpp:
(WebCore::displayNameForLanguageLocale): Added a missing adoptCF.
* platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::openTypeTable): Added a missing adoptCF.
* platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
(WebCore::InbandTextTrackPrivateAVCF::label): Added two missing adoptCF.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::createImageForTimeInRect): Added two missing adoptCF.
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::createPDFDocument): Added missing adoptCF.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::cascadeToLastResortFontDescriptor): Added two missing adoptCF.
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::primaryFontDataIsSystemFont): Added missing adoptCF.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::hasCustomTracking): Added missing adoptCF.
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::qcmsOutputDeviceProfile): Added CFRelease.
* plugins/mac/PluginPackageMac.cpp:
(WebCore::readPListFile): Added two missing adoptCF.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
trunk/Source/WebCore/platform/Language.cpp
trunk/Source/WebCore/platform/graphics/FontPlatformData.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp
trunk/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp
trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm
trunk/Source/WebCore/platform/graphics/mac/FontMac.mm
trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm
trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h
trunk/Source/WebCore/plugins/mac/PluginPackageMac.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (167745 => 167746)
--- trunk/Source/WebCore/ChangeLog 2014-04-24 04:42:32 UTC (rev 167745)
+++ trunk/Source/WebCore/ChangeLog 2014-04-24 04:46:28 UTC (rev 167746)
@@ -1,3 +1,43 @@
+2014-04-23 Darin Adler da...@apple.com
+
+[Cocoa] fix CF leaks found by code inspection
+https://bugs.webkit.org/show_bug.cgi?id=132106
+
+Reviewed by Andreas Kling.
+
+* page/CaptionUserPreferencesMediaAF.cpp:
+(WebCore::trackDisplayName): Added a missing adoptCF.
+
+* platform/Language.cpp:
+(WebCore::displayNameForLanguageLocale): Added a missing adoptCF.
+
+* platform/graphics/FontPlatformData.cpp:
+(WebCore::FontPlatformData::openTypeTable): Added a missing adoptCF.
+
+* platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
+(WebCore::InbandTextTrackPrivateAVCF::label): Added two missing adoptCF.
+
+* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::AVFWrapper::createImageForTimeInRect): Added two missing adoptCF.
+
+* platform/graphics/cg/PDFDocumentImage.cpp:
+(WebCore::PDFDocumentImage::createPDFDocument): Added missing adoptCF.
+
+* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
+(WebCore::cascadeToLastResortFontDescriptor): Added two missing adoptCF.
+
+* platform/graphics/mac/FontMac.mm:
+(WebCore::Font::primaryFontDataIsSystemFont): Added missing adoptCF.
+
+* platform/graphics/mac/SimpleFontDataMac.mm:
+(WebCore::hasCustomTracking): Added missing adoptCF.
+
+* platform/image-decoders/ImageDecoder.h:
+(WebCore::ImageDecoder::qcmsOutputDeviceProfile): Added CFRelease.
+
+* plugins/mac/PluginPackageMac.cpp:
+(WebCore::readPListFile): Added two missing adoptCF.
+
2014-04-23 Ryosuke Niwa rn...@webkit.org
REGRESSION (r157328): popover to check into flight ba.com dismisses instantly when focusing form
Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp (167745 => 167746)
--- trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2014-04-24 04:42:32 UTC (rev 167745)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2014-04-24 04:46:28 UTC (rev 167746)
@@ -608,7 +608,7 @@
}
}
} else {
-String languageAndLocale = CFLocaleCopyDisplayNameForPropertyValue(currentLocale.get(), kCFLocaleIdentifier, trackLanguageIdentifier.createCFString().get());
+String languageAndLocale = adoptCF(CFLocaleCopyDisplayNameForPropertyValue(currentLocale.get(), kCFLocaleIdentifier,
[webkit-changes] [167747] tags/Safari-538.31/
Title: [167747] tags/Safari-538.31/ Revision 167747 Author lforsch...@apple.com Date 2014-04-23 21:47:40 -0700 (Wed, 23 Apr 2014) Log Message New Tag. Added Paths tags/Safari-538.31/ Diff Property changes: tags/Safari-538.31 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167748] trunk/Source
Title: [167748] trunk/Source Revision 167748 Author lforsch...@apple.com Date 2014-04-23 21:49:22 -0700 (Wed, 23 Apr 2014) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (167747 => 167748) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2014-04-24 04:47:40 UTC (rev 167747) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2014-04-24 04:49:22 UTC (rev 167748) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 31; +MINOR_VERSION = 32; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (167747 => 167748) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2014-04-24 04:47:40 UTC (rev 167747) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2014-04-24 04:49:22 UTC (rev 167748) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 31; +MINOR_VERSION = 32; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (167747 => 167748) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-04-24 04:47:40 UTC (rev 167747) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-04-24 04:49:22 UTC (rev 167748) @@ -1,5 +1,5 @@ MAJOR_VERSION = 538; -MINOR_VERSION = 31; +MINOR_VERSION = 32; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (167747 => 167748) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2014-04-24 04:47:40 UTC (rev 167747) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2014-04-24 04:49:22 UTC (rev 167748) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 31; +MINOR_VERSION = 32; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (167747 => 167748) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2014-04-24 04:47:40 UTC (rev 167747) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2014-04-24 04:49:22 UTC (rev 167748) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 31; +MINOR_VERSION = 32; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167749] trunk/Source/WebKit2
Title: [167749] trunk/Source/WebKit2 Revision 167749 Author simon.fra...@apple.com Date 2014-04-23 22:16:45 -0700 (Wed, 23 Apr 2014) Log Message [iOS WK2] Missing content inside long overflow-scrolling:touch https://bugs.webkit.org/show_bug.cgi?id=132105 Reviewed by Tim Horton. PlatformCALayerRemote needs to track bounds origin as well as size, since iOS uses bounds origin for overflow scrolling. * Shared/mac/RemoteLayerTreePropertyApplier.mm: (WebKit::applyPropertiesToLayer): * Shared/mac/RemoteLayerTreeTransaction.h: * Shared/mac/RemoteLayerTreeTransaction.mm: (WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties): (WebKit::RemoteLayerTreeTransaction::LayerProperties::encode): (WebKit::RemoteLayerTreeTransaction::LayerProperties::decode): (WebKit::dumpChangedLayers): * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: (WebKit::PlatformCALayerRemote::updateBackingStore): (WebKit::PlatformCALayerRemote::bounds): (WebKit::PlatformCALayerRemote::setBounds): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (167748 => 167749) --- trunk/Source/WebKit2/ChangeLog 2014-04-24 04:49:22 UTC (rev 167748) +++ trunk/Source/WebKit2/ChangeLog 2014-04-24 05:16:45 UTC (rev 167749) @@ -1,3 +1,26 @@ +2014-04-23 Simon Fraser simon.fra...@apple.com + +[iOS WK2] Missing content inside long overflow-scrolling:touch +https://bugs.webkit.org/show_bug.cgi?id=132105 + +Reviewed by Tim Horton. + +PlatformCALayerRemote needs to track bounds origin as well as size, +since iOS uses bounds origin for overflow scrolling. + +* Shared/mac/RemoteLayerTreePropertyApplier.mm: +(WebKit::applyPropertiesToLayer): +* Shared/mac/RemoteLayerTreeTransaction.h: +* Shared/mac/RemoteLayerTreeTransaction.mm: +(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties): +(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode): +(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode): +(WebKit::dumpChangedLayers): +* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: +(WebKit::PlatformCALayerRemote::updateBackingStore): +(WebKit::PlatformCALayerRemote::bounds): +(WebKit::PlatformCALayerRemote::setBounds): + 2014-04-23 Andreas Kling akl...@apple.com Remove unused WKPageSetMemoryCacheClientCallsEnabled API. Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm (167748 => 167749) --- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm 2014-04-24 04:49:22 UTC (rev 167748) +++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm 2014-04-24 05:16:45 UTC (rev 167749) @@ -128,8 +128,8 @@ layer.anchorPointZ = properties.anchorPoint.z(); } -if (properties.changedProperties RemoteLayerTreeTransaction::SizeChanged) -layer.bounds = FloatRect(FloatPoint(), properties.size); +if (properties.changedProperties RemoteLayerTreeTransaction::BoundsChanged) +layer.bounds = properties.bounds; if (properties.changedProperties RemoteLayerTreeTransaction::BackgroundColorChanged) layer.backgroundColor = cgColorFromColor(properties.backgroundColor).get(); Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h (167748 => 167749) --- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h 2014-04-24 04:49:22 UTC (rev 167748) +++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h 2014-04-24 05:16:45 UTC (rev 167749) @@ -54,7 +54,7 @@ NameChanged = 1 1, ChildrenChanged = 1 2, PositionChanged = 1 3, -SizeChanged = 1 4, +BoundsChanged = 1 4, BackgroundColorChanged = 1 5, AnchorPointChanged = 1 6, BorderWidthChanged = 1 7, @@ -127,7 +127,7 @@ WebCore::FloatPoint3D position; WebCore::FloatPoint3D anchorPoint; -WebCore::FloatSize size; +WebCore::FloatRect bounds; WebCore::FloatRect contentsRect; std::unique_ptrRemoteLayerBackingStore backingStore; std::unique_ptrWebCore::FilterOperations filters; Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm (167748 => 167749) --- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2014-04-24 04:49:22 UTC (rev 167748) +++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2014-04-24 05:16:45 UTC (rev 167749) @@ -111,7 +111,7 @@ , keyPathsOfAnimationsToRemove(other.keyPathsOfAnimationsToRemove) , position(other.position) , anchorPoint(other.anchorPoint) -, size(other.size) +,
