[webkit-changes] [171912] trunk/LayoutTests
Title: [171912] trunk/LayoutTests Revision 171912 Author m.pak...@samsung.com Date 2014-08-01 01:14:20 -0700 (Fri, 01 Aug 2014) Log Message Unreviewed EFL gardening Update test expectations for crashing webgl tests. * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (171911 => 171912) --- trunk/LayoutTests/ChangeLog 2014-08-01 07:26:47 UTC (rev 171911) +++ trunk/LayoutTests/ChangeLog 2014-08-01 08:14:20 UTC (rev 171912) @@ -1,3 +1,11 @@ +2014-08-01 Michał Pakuła vel Rutka m.pak...@samsung.com + +Unreviewed EFL gardening + +Update test expectations for crashing webgl tests. + +* platform/efl/TestExpectations: + 2014-07-31 Beth Dakin bda...@apple.com platform/mac/fast/scrolling/scroll-select-bottom-test.html failing on Mavericks Modified: trunk/LayoutTests/platform/efl/TestExpectations (171911 => 171912) --- trunk/LayoutTests/platform/efl/TestExpectations 2014-08-01 07:26:47 UTC (rev 171911) +++ trunk/LayoutTests/platform/efl/TestExpectations 2014-08-01 08:14:20 UTC (rev 171912) @@ -547,12 +547,37 @@ webkit.org/b/135194 webgl/1.0.1/conformance/textures/texture-size-cube-maps.html [ Crash Timeout ] webkit.org/b/135194 webgl/1.0.2/conformance/rendering/multisample-corruption.html [ Crash Timeout ] +# Tests crashing with common backtrace ending in GraphicsContext3D::mappedSymbolName +webkit.org/b/105029 webkit.org/b/135196 fast/canvas/webgl/webgl-composite-modes.html [ Crash Failure Timeout ] +webkit.org/b/105029 webkit.org/b/135196 fast/canvas/webgl/webgl-composite-modes-repaint.html [ Crash Timeout ] webkit.org/b/135196 webgl/1.0.2/conformance/attribs/gl-vertex-attrib-render.html [ Crash Failure Timeout ] webkit.org/b/135196 webgl/1.0.2/conformance/ogles/GL/sin/sin_001_to_006.html [ Crash Timeout ] +webkit.org/b/135196 webgl/1.0.2/conformance/uniforms/gl-uniform-arrays.html [ Crash Timeout ] webkit.org/b/124935 webkit.org/b/135196 webgl/1.0.2/conformance/uniforms/out-of-bounds-uniform-array-access.html [ Crash Timeout ] webkit.org/b/135196 webgl/conformance/ogles/GL/sin/sin_001_to_006.html [ Crash Timeout ] webkit.org/b/135196 webgl/conformance/ogles/GL/vec3/vec3_001_to_008.html [ Crash Timeout ] +webkit.org/b/130586 webkit.org/b/135196 webgl/conformance/uniforms/gl-uniform-arrays.html [ Crash Timeout ] +# Tests crashing with common backtrace ending in WebGLRenderingContext::bindTexture +webkit.org/b/105030 webkit.org/b/135197 fast/canvas/webgl/framebuffer-object-attachment.html [ Crash Timeout ] +webkit.org/b/105030 webkit.org/b/135197 fast/canvas/webgl/premultiplyalpha-test.html [ Crash Timeout ] +webkit.org/b/127279 webkit.org/b/135197 fast/canvas/webgl/webgl-compressed-texture-size-limit.html [ Crash Timeout ] +webkit.org/b/129818 webkit.org/b/135197 fast/canvas/webgl/webgl-draw-buffers.html [ Crash Timeout ] +webkit.org/b/135197 fast/images/webgl-teximage2d.html [ Crash Timeout ] +webkit.org/b/135197 webgl/1.0.1/conformance/context/context-lost-restored.html [ Crash ] +webkit.org/b/135197 webgl/1.0.1/conformance/context/premultiplyalpha-test.html [ Crash Timeout ] +webkit.org/b/135197 webgl/1.0.1/conformance/glsl/samplers/glsl-function-texture2dproj.html [ Crash Timeout ] +webkit.org/b/135197 webgl/1.0.1/conformance/glsl/samplers/glsl-function-texture2dlod.html [ Crash Timeout ] +webkit.org/b/109941 webkit.org/b/135197 webgl/1.0.1/conformance/textures/origin-clean-conformance.html [ Crash Timeout ] +webkit.org/b/135197 webgl/1.0.2/conformance/context/context-creation-and-destruction.html [ Crash Timeout ] +webkit.org/b/135197 webgl/1.0.2/conformance/context/premultiplyalpha-test.html [ Crash Timeout ] +webkit.org/b/135197 webgl/1.0.2/conformance/extensions/oes-texture-float.html [ Crash Timeout ] +webkit.org/b/135197 webgl/1.0.2/conformance/textures/copy-tex-image-2d-formats.html [ Crash Timeout ] +webkit.org/b/135197 webgl/conformance/context/context-lost-restored.html [ Crash Timeout ] +webkit.org/b/109941 webkit.org/b/135197 webgl/conformance/textures/origin-clean-conformance.html [ Crash Timeout ] + +webkit.org/b/135498 css3/device-adapt/opera/constrain-009.xhtml [ Crash Timeout ] + # # FLAKY TESTS # @@ -633,8 +658,6 @@ webkit.org/b/128252 media/track/track-kind.html [ Pass Failure ] webkit.org/b/128528 media/media-ended.html [ Pass Failure ] -webkit.org/b/130586 webgl/conformance/uniforms/gl-uniform-arrays.html [ Failure Pass ] - # Tests that sometimes fail on the bot webkit.org/b/130581 perf/clone-with-focus.html [ Pass Failure ] @@ -1420,17 +1443,7 @@ # Rendering failure, also missing expected results: webkit.org/b/105093 compositing/webgl/webgl-nonpremultiplied-blend.html [ Skip ] -# WebProcess timeouts
[webkit-changes] [171913] releases/WebKitGTK/webkit-2.5.1/
Title: [171913] releases/WebKitGTK/webkit-2.5.1/ Revision 171913 Author carlo...@webkit.org Date 2014-08-01 02:59:14 -0700 (Fri, 01 Aug 2014) Log Message WebKitGTK+ 2.5.1 Added Paths releases/WebKitGTK/webkit-2.5.1/ Diff Property changes: releases/WebKitGTK/webkit-2.5.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171914] trunk/Source/WebKit2
Title: [171914] trunk/Source/WebKit2 Revision 171914 Author carlo...@webkit.org Date 2014-08-01 03:48:30 -0700 (Fri, 01 Aug 2014) Log Message Unreviewed. Add missing sections to documentation. * UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add WebKitUserContent and WebKitUserContentManager sections to the documentation. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml Diff Modified: trunk/Source/WebKit2/ChangeLog (171913 => 171914) --- trunk/Source/WebKit2/ChangeLog 2014-08-01 09:59:14 UTC (rev 171913) +++ trunk/Source/WebKit2/ChangeLog 2014-08-01 10:48:30 UTC (rev 171914) @@ -1,3 +1,11 @@ +2014-08-01 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Add missing sections to documentation. + +* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add +WebKitUserContent and WebKitUserContentManager sections to the +documentation. + 2014-08-01 Ryuan Choi ryuan.c...@samsung.com [EFL] Unable to do make install since r171901 Modified: trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml (171913 => 171914) --- trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml 2014-08-01 09:59:14 UTC (rev 171913) +++ trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml 2014-08-01 10:48:30 UTC (rev 171914) @@ -43,6 +43,8 @@ xi:include href="" xi:include href="" xi:include href="" +xi:include href="" +xi:include href="" /chapter chapter ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171915] trunk
Title: [171915] trunk
Revision 171915
Author carlo...@webkit.org
Date 2014-08-01 06:34:56 -0700 (Fri, 01 Aug 2014)
Log Message
[CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
https://bugs.webkit.org/show_bug.cgi?id=135501
Reviewed by Gyuyoung Kim.
Use PROJECT_VERSION_MICRO instead.
.:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitHelpers.cmake:
Source/WebKit2:
* UIProcess/API/efl/EWebKit2.h.in:
* UIProcess/API/gtk/WebKitVersion.h.in:
Modified Paths
trunk/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h.in
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitVersion.h.in
trunk/Source/cmake/OptionsEfl.cmake
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/WebKitHelpers.cmake
Diff
Modified: trunk/ChangeLog (171914 => 171915)
--- trunk/ChangeLog 2014-08-01 10:48:30 UTC (rev 171914)
+++ trunk/ChangeLog 2014-08-01 13:34:56 UTC (rev 171915)
@@ -1,3 +1,16 @@
+2014-08-01 Carlos Garcia Campos cgar...@igalia.com
+
+[CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
+https://bugs.webkit.org/show_bug.cgi?id=135501
+
+Reviewed by Gyuyoung Kim.
+
+Use PROJECT_VERSION_MICRO instead.
+
+* Source/cmake/OptionsEfl.cmake:
+* Source/cmake/OptionsGTK.cmake:
+* Source/cmake/WebKitHelpers.cmake:
+
2014-07-31 Ryuan Choi ryuan.c...@samsung.com
[EFL] Bump ewebkit version to 1.11
Modified: trunk/Source/WebKit2/ChangeLog (171914 => 171915)
--- trunk/Source/WebKit2/ChangeLog 2014-08-01 10:48:30 UTC (rev 171914)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-01 13:34:56 UTC (rev 171915)
@@ -1,5 +1,17 @@
2014-08-01 Carlos Garcia Campos cgar...@igalia.com
+[CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
+https://bugs.webkit.org/show_bug.cgi?id=135501
+
+Reviewed by Gyuyoung Kim.
+
+Use PROJECT_VERSION_MICRO instead.
+
+* UIProcess/API/efl/EWebKit2.h.in:
+* UIProcess/API/gtk/WebKitVersion.h.in:
+
+2014-08-01 Carlos Garcia Campos cgar...@igalia.com
+
Unreviewed. Add missing sections to documentation.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h.in (171914 => 171915)
--- trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h.in 2014-08-01 10:48:30 UTC (rev 171914)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h.in 2014-08-01 13:34:56 UTC (rev 171915)
@@ -30,7 +30,7 @@
#define EWK_VERSION_MAJOR @PROJECT_VERSION_MAJOR@
#define EWK_VERSION_MINOR @PROJECT_VERSION_MINOR@
-#define EWK_VERSION_MICRO @PROJECT_VERSION_PATCH@
+#define EWK_VERSION_MICRO @PROJECT_VERSION_MICRO@
#include ewk_auth_request.h
#include ewk_back_forward_list.h
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitVersion.h.in (171914 => 171915)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitVersion.h.in 2014-08-01 10:48:30 UTC (rev 171914)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitVersion.h.in 2014-08-01 13:34:56 UTC (rev 171915)
@@ -53,7 +53,7 @@
* application compile time, rather than from the library linked
* against at application run time.
*/
-#define WEBKIT_MICRO_VERSION (@PROJECT_VERSION_PATCH@)
+#define WEBKIT_MICRO_VERSION (@PROJECT_VERSION_MICRO@)
/**
* WEBKIT_CHECK_VERSION:
Modified: trunk/Source/cmake/OptionsEfl.cmake (171914 => 171915)
--- trunk/Source/cmake/OptionsEfl.cmake 2014-08-01 10:48:30 UTC (rev 171914)
+++ trunk/Source/cmake/OptionsEfl.cmake 2014-08-01 13:34:56 UTC (rev 171915)
@@ -1,7 +1,7 @@
set(PROJECT_VERSION_MAJOR 1)
set(PROJECT_VERSION_MINOR 11)
-set(PROJECT_VERSION_PATCH 0)
-set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH})
+set(PROJECT_VERSION_MICRO 0)
+set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_MICRO})
add_definitions(-DBUILDING_EFL__=1)
Modified: trunk/Source/cmake/OptionsGTK.cmake (171914 => 171915)
--- trunk/Source/cmake/OptionsGTK.cmake 2014-08-01 10:48:30 UTC (rev 171914)
+++ trunk/Source/cmake/OptionsGTK.cmake 2014-08-01 13:34:56 UTC (rev 171915)
@@ -2,8 +2,8 @@
set(PROJECT_VERSION_MAJOR 2)
set(PROJECT_VERSION_MINOR 5)
-set(PROJECT_VERSION_PATCH 1)
-set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH})
+set(PROJECT_VERSION_MICRO 1)
+set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_MICRO})
set(WEBKITGTK_API_VERSION 4.0)
# Libtool library version, not to be confused with API version.
Modified: trunk/Source/cmake/WebKitHelpers.cmake (171914 => 171915)
--- trunk/Source/cmake/WebKitHelpers.cmake 2014-08-01 10:48:30 UTC (rev 171914)
+++ trunk/Source/cmake/WebKitHelpers.cmake 2014-08-01 13:34:56 UTC (rev 171915)
@@ -98,7 +98,7 @@
macro(CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE library_name current revision age)
[webkit-changes] [171916] trunk/LayoutTests
Title: [171916] trunk/LayoutTests Revision 171916 Author m.pak...@samsung.com Date 2014-08-01 06:42:26 -0700 (Fri, 01 Aug 2014) Log Message Unreviewed EFL gardening Add test expectations for failing tests. Remove flaky test expectations that are no longer correct. * platform/efl/TestExpectations: * platform/efl/fast/text/khmer-lao-font-expected.txt: Update expected result. * svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Update after r171046. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/efl/fast/text/khmer-lao-font-expected.txt trunk/LayoutTests/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (171915 => 171916) --- trunk/LayoutTests/ChangeLog 2014-08-01 13:34:56 UTC (rev 171915) +++ trunk/LayoutTests/ChangeLog 2014-08-01 13:42:26 UTC (rev 171916) @@ -2,6 +2,17 @@ Unreviewed EFL gardening +Add test expectations for failing tests. Remove flaky test expectations that are +no longer correct. + +* platform/efl/TestExpectations: +* platform/efl/fast/text/khmer-lao-font-expected.txt: Update expected result. +* svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Update after r171046. + +2014-08-01 Michał Pakuła vel Rutka m.pak...@samsung.com + +Unreviewed EFL gardening + Update test expectations for crashing webgl tests. * platform/efl/TestExpectations: Modified: trunk/LayoutTests/platform/efl/TestExpectations (171915 => 171916) --- trunk/LayoutTests/platform/efl/TestExpectations 2014-08-01 13:34:56 UTC (rev 171915) +++ trunk/LayoutTests/platform/efl/TestExpectations 2014-08-01 13:42:26 UTC (rev 171916) @@ -292,9 +292,6 @@ # CSS image-resolution is not yet enabled. webkit.org/b/85262 fast/css/image-resolution -# CSS image-orientation is not yet enabled. -webkit.org/b/89052 fast/css/image-orientation - # Perf tests are really slow in debug builds and there are few benefits in running them. [ Debug ] perf [ WontFix ] @@ -460,7 +457,6 @@ # Sometimes hit !m_finishedNodes.size() assertion in AudioContext destructor. webkit.org/b/105870 webaudio/audiobuffersource.html [ Pass Crash ] -webkit.org/b/105870 webaudio/audionode.html [ Pass Crash ] webkit.org/b/105870 webaudio/audionode-connect-order.html [ Pass Crash ] webkit.org/b/105870 webaudio/audionode-channel-rules.html [ Pass Crash ] @@ -471,10 +467,8 @@ webkit.org/b/104809 media/remove-from-document.html [ Crash Pass ] webkit.org/b/104809 media/video-timeupdate-during-playback.html [ Crash Pass ] -webkit.org/b/111521 editing/selection/selection-invalid-offset.html [ Crash Pass ] - # Sometimes crashes in PlatformContextCairo::drawSurfaceToContext(). -webkit.org/b/116025 compositing/video/video-background-color.html [ Crash Pass ] +webkit.org/b/116025 compositing/video/video-background-color.html [ Crash Pass Failure ] # EFL specific error : (_ecore_main_fd_handlers_bads_rem() No bad fd found) webkit.org/b/116587 http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html [ Skip ] @@ -544,10 +538,13 @@ webkit.org/b/131729 http/tests [ Skip ] webkit.org/b/131729 webgl [ Skip ] +# Tests crashing with common backtrace ending in WebGLRenderingContext::reshape webkit.org/b/135194 webgl/1.0.1/conformance/textures/texture-size-cube-maps.html [ Crash Timeout ] webkit.org/b/135194 webgl/1.0.2/conformance/rendering/multisample-corruption.html [ Crash Timeout ] +webkit.org/b/135194 webgl/1.0.2/conformance/textures/texture-size-cube-maps.html [ Crash Timeout ] # Tests crashing with common backtrace ending in GraphicsContext3D::mappedSymbolName +webkit.org/b/127277 webkit.org/b/135196 fast/canvas/webgl/glsl-conformance.html [ Crash Timeout ] webkit.org/b/105029 webkit.org/b/135196 fast/canvas/webgl/webgl-composite-modes.html [ Crash Failure Timeout ] webkit.org/b/105029 webkit.org/b/135196 fast/canvas/webgl/webgl-composite-modes-repaint.html [ Crash Timeout ] webkit.org/b/135196 webgl/1.0.2/conformance/attribs/gl-vertex-attrib-render.html [ Crash Failure Timeout ] @@ -573,43 +570,32 @@ webkit.org/b/135197 webgl/1.0.2/conformance/context/premultiplyalpha-test.html [ Crash Timeout ] webkit.org/b/135197 webgl/1.0.2/conformance/extensions/oes-texture-float.html [ Crash Timeout ] webkit.org/b/135197 webgl/1.0.2/conformance/textures/copy-tex-image-2d-formats.html [ Crash Timeout ] +webkit.org/b/135197 webgl/1.0.2/conformance/textures/texture-attachment-formats.html [ Crash Timeout ] webkit.org/b/135197 webgl/conformance/context/context-lost-restored.html [ Crash Timeout ] webkit.org/b/109941 webkit.org/b/135197 webgl/conformance/textures/origin-clean-conformance.html [ Crash Timeout ] webkit.org/b/135498 css3/device-adapt/opera/constrain-009.xhtml [ Crash Timeout ] +webkit.org/b/135498 css3/device-adapt/opera/constrain-023.xhtml [ Crash Timeout ]
[webkit-changes] [171917] trunk/Source/WebCore
Title: [171917] trunk/Source/WebCore
Revision 171917
Author commit-qu...@webkit.org
Date 2014-08-01 09:15:26 -0700 (Fri, 01 Aug 2014)
Log Message
ASSERTION FAILED: listNode in WebCore::RenderListItem::updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=134970
Patch by Renato Nagy nagy.ren...@stud.u-szeged.hu on 2014-08-01
Reviewed by Zalan Bujtas.
Removed an unnecessary assert, because the null return value of enclosingList() is
handled properly after this assert.
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateListMarkerNumbers):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListItem.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (171916 => 171917)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 13:42:26 UTC (rev 171916)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 16:15:26 UTC (rev 171917)
@@ -1,3 +1,16 @@
+2014-08-01 Renato Nagy nagy.ren...@stud.u-szeged.hu
+
+ASSERTION FAILED: listNode in WebCore::RenderListItem::updateListMarkerNumbers
+https://bugs.webkit.org/show_bug.cgi?id=134970
+
+Reviewed by Zalan Bujtas.
+
+Removed an unnecessary assert, because the null return value of enclosingList() is
+handled properly after this assert.
+
+* rendering/RenderListItem.cpp:
+(WebCore::RenderListItem::updateListMarkerNumbers):
+
2014-08-01 Gyuyoung Kim gyuyoung@samsung.com
Replace DEPRECATED_DEFINE_STATIC_LOCAL with NeverDestroyedT in NavigatorContentUtils
Modified: trunk/Source/WebCore/rendering/RenderListItem.cpp (171916 => 171917)
--- trunk/Source/WebCore/rendering/RenderListItem.cpp 2014-08-01 13:42:26 UTC (rev 171916)
+++ trunk/Source/WebCore/rendering/RenderListItem.cpp 2014-08-01 16:15:26 UTC (rev 171917)
@@ -497,7 +497,6 @@
{
Element* listNode = enclosingList(this);
// The list node can be the shadow root which has no renderer.
-ASSERT(listNode);
if (!listNode)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171918] tags/Safari-600.1.2.5/Safari-600.1.2.4/
Title: [171918] tags/Safari-600.1.2.5/Safari-600.1.2.4/ Revision 171918 Author matthew_han...@apple.com Date 2014-08-01 10:02:37 -0700 (Fri, 01 Aug 2014) Log Message New Tag. Added Paths tags/Safari-600.1.2.5/Safari-600.1.2.4/ Diff Property changes: tags/Safari-600.1.2.5/Safari-600.1.2.4 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171919] branches/safari-600.1.4-branch/Source/WebCore
Title: [171919] branches/safari-600.1.4-branch/Source/WebCore Revision 171919 Author matthew_han...@apple.com Date 2014-08-01 10:32:03 -0700 (Fri, 01 Aug 2014) Log Message Merge r171895. rdar://problem/17835345 Modified Paths branches/safari-600.1.4-branch/Source/WebCore/ChangeLog branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm Diff Modified: branches/safari-600.1.4-branch/Source/WebCore/ChangeLog (171918 => 171919) --- branches/safari-600.1.4-branch/Source/WebCore/ChangeLog 2014-08-01 17:02:37 UTC (rev 171918) +++ branches/safari-600.1.4-branch/Source/WebCore/ChangeLog 2014-08-01 17:32:03 UTC (rev 171919) @@ -1,5 +1,22 @@ 2014-07-31 Matthew Hanson matthew_han...@apple.com +Merge r171895. rdar://problem/17835345 + +2014-07-31 Jer Noble jer.no...@apple.com + +[iOS] Video in an embed has a bad aspect ratio when in fullscreen mode. +https://bugs.webkit.org/show_bug.cgi?id=135481 + +Reviewed by Simon Fraser. + +Do not change the gravity of our AVPlayerLayer when in full screen mode; its gravity +is controlled by setVideoFullscreenGravity(), and should not be affected by style changes. + +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: +(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity): + +2014-07-31 Matthew Hanson matthew_han...@apple.com + Merge r171866. rdar://problem/17872676 2014-07-31 Joseph Pecoraro pecor...@apple.com Modified: branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (171918 => 171919) --- branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 17:02:37 UTC (rev 171918) +++ branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 17:32:03 UTC (rev 171919) @@ -1559,6 +1559,13 @@ if (!m_videoLayer) return; +#if PLATFORM(IOS) +// Do not attempt to change the video gravity while in full screen mode. +// See setVideoFullscreenGravity(). +if (m_videoFullscreenLayer) +return; +#endif + [CATransaction begin]; [CATransaction setDisableActions:YES]; NSString* gravity = shouldMaintainAspectRatio() ? AVLayerVideoGravityResizeAspect : AVLayerVideoGravityResize; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171920] trunk/Source/WebKit2
Title: [171920] trunk/Source/WebKit2
Revision 171920
Author bfulg...@apple.com
Date 2014-08-01 10:38:53 -0700 (Fri, 01 Aug 2014)
Log Message
[Mac] Fullscreen mode for some applications shows only a black screen.
https://bugs.webkit.org/show_bug.cgi?id=135493
rdar://problem/17628212
Reviewed by Jer Noble.
In some applications, the window hosting the WKView is an InProcess layer hosting mode.
The fullscreen window created by the WKFullScreenWindowController defaults to an
OutOfProcess mode.
When this kind of mismatch is encountered, the WK2 layer in the UI process is supposed
to send a message back to the WebProcess indicating that the layer hosting mode of the
containing window is different, so that the WebProcess can adjust its logic accordingly.
Unfortunately, the notification that this had happened was not getting sent to the
WebProcess due to an optimization in window state change logic (see Bug 135509 for
details).
The fix is to check layer hosting mode state when a WKView is added to a window, and
notify the WebProcess when it needs to change state to match.
* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]): When moving to a new window, always call
'layerHostingModeDidChange' to pick up any changes in the layer hosting mode.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (171919 => 171920)
--- trunk/Source/WebKit2/ChangeLog 2014-08-01 17:32:03 UTC (rev 171919)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-01 17:38:53 UTC (rev 171920)
@@ -1,3 +1,30 @@
+2014-08-01 Brent Fulgham bfulg...@apple.com
+
+[Mac] Fullscreen mode for some applications shows only a black screen.
+https://bugs.webkit.org/show_bug.cgi?id=135493
+rdar://problem/17628212
+
+Reviewed by Jer Noble.
+
+In some applications, the window hosting the WKView is an InProcess layer hosting mode.
+The fullscreen window created by the WKFullScreenWindowController defaults to an
+OutOfProcess mode.
+
+When this kind of mismatch is encountered, the WK2 layer in the UI process is supposed
+to send a message back to the WebProcess indicating that the layer hosting mode of the
+containing window is different, so that the WebProcess can adjust its logic accordingly.
+Unfortunately, the notification that this had happened was not getting sent to the
+WebProcess due to an optimization in window state change logic (see Bug 135509 for
+details).
+
+The fix is to check layer hosting mode state when a WKView is added to a window, and
+notify the WebProcess when it needs to change state to match.
+
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView viewDidMoveToWindow]): When moving to a new window, always call
+'layerHostingModeDidChange' to pick up any changes in the layer hosting mode.
+
2014-08-01 Carlos Garcia Campos cgar...@igalia.com
[CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (171919 => 171920)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-08-01 17:32:03 UTC (rev 171919)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-08-01 17:38:53 UTC (rev 171920)
@@ -2506,6 +2506,9 @@
[self _updateWindowAndViewFrames];
+// FIXME(135509) This call becomes unnecessary once 135509 is fixed; remove.
+_data-_page-layerHostingModeDidChange();
+
if (!_data-_flagsChangedEventMonitor) {
_data-_flagsChangedEventMonitor = [NSEvent addLocalMonitorForEventsMatchingMask:NSFlagsChangedMask handler:^(NSEvent *flagsChangedEvent) {
[self _postFakeMouseMovedEventForFlagsChangedEvent:flagsChangedEvent];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171921] tags/Safari-600.1.4.3/
Title: [171921] tags/Safari-600.1.4.3/ Revision 171921 Author matthew_han...@apple.com Date 2014-08-01 10:44:06 -0700 (Fri, 01 Aug 2014) Log Message New Tag. Added Paths tags/Safari-600.1.4.3/ Diff Property changes: tags/Safari-600.1.4.3 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171922] branches/safari-600.1.4-branch/Source
Title: [171922] branches/safari-600.1.4-branch/Source Revision 171922 Author matthew_han...@apple.com Date 2014-08-01 10:46:27 -0700 (Fri, 01 Aug 2014) Log Message Versioning. Modified Paths branches/safari-600.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-600.1.4-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-600.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-600.1.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-600.1.4-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-600.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig (171921 => 171922) --- branches/safari-600.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2014-08-01 17:44:06 UTC (rev 171921) +++ branches/safari-600.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2014-08-01 17:46:27 UTC (rev 171922) @@ -24,7 +24,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-600.1.4-branch/Source/WebCore/Configurations/Version.xcconfig (171921 => 171922) --- branches/safari-600.1.4-branch/Source/WebCore/Configurations/Version.xcconfig 2014-08-01 17:44:06 UTC (rev 171921) +++ branches/safari-600.1.4-branch/Source/WebCore/Configurations/Version.xcconfig 2014-08-01 17:46:27 UTC (rev 171922) @@ -24,7 +24,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-600.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (171921 => 171922) --- branches/safari-600.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-08-01 17:44:06 UTC (rev 171921) +++ branches/safari-600.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-08-01 17:46:27 UTC (rev 171922) @@ -1,7 +1,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-600.1.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig (171921 => 171922) --- branches/safari-600.1.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2014-08-01 17:44:06 UTC (rev 171921) +++ branches/safari-600.1.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2014-08-01 17:46:27 UTC (rev 171922) @@ -24,7 +24,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-600.1.4-branch/Source/WebKit2/Configurations/Version.xcconfig (171921 => 171922) --- branches/safari-600.1.4-branch/Source/WebKit2/Configurations/Version.xcconfig 2014-08-01 17:44:06 UTC (rev 171921) +++ branches/safari-600.1.4-branch/Source/WebKit2/Configurations/Version.xcconfig 2014-08-01 17:46:27 UTC (rev 171922) @@ -24,7 +24,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171924] trunk/Tools
Title: [171924] trunk/Tools
Revision 171924
Author timothy_hor...@apple.com
Date 2014-08-01 11:19:07 -0700 (Fri, 01 Aug 2014)
Log Message
MiniBrowser doesn't support data URLs
https://bugs.webkit.org/show_bug.cgi?id=135492
Reviewed by Simon Fraser.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController addProtocolIfNecessary:]):
Don't add http:// to data: URLs.
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController updateTextFieldFromURL:]):
Percent-escape the contents of the address field before trying to make a URL.
Percent-unescape the URL when displaying it in the address field.
This is not great, but trivial and good-enough-for-Minibrowser.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/BrowserWindowController.m
trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m
Diff
Modified: trunk/Tools/ChangeLog (171923 => 171924)
--- trunk/Tools/ChangeLog 2014-08-01 18:16:19 UTC (rev 171923)
+++ trunk/Tools/ChangeLog 2014-08-01 18:19:07 UTC (rev 171924)
@@ -1,3 +1,21 @@
+2014-08-01 Tim Horton timothy_hor...@apple.com
+
+MiniBrowser doesn't support data URLs
+https://bugs.webkit.org/show_bug.cgi?id=135492
+
+Reviewed by Simon Fraser.
+
+* MiniBrowser/mac/BrowserWindowController.m:
+(-[BrowserWindowController addProtocolIfNecessary:]):
+Don't add http:// to data: URLs.
+
+* MiniBrowser/mac/WK2BrowserWindowController.m:
+(-[WK2BrowserWindowController fetch:]):
+(-[WK2BrowserWindowController updateTextFieldFromURL:]):
+Percent-escape the contents of the address field before trying to make a URL.
+Percent-unescape the URL when displaying it in the address field.
+This is not great, but trivial and good-enough-for-Minibrowser.
+
2014-07-31 Ryuan Choi ryuan.c...@samsung.com
[EFL][WK2] MiniBrower comes to crash when combo box is pressed
Modified: trunk/Tools/MiniBrowser/mac/BrowserWindowController.m (171923 => 171924)
--- trunk/Tools/MiniBrowser/mac/BrowserWindowController.m 2014-08-01 18:16:19 UTC (rev 171923)
+++ trunk/Tools/MiniBrowser/mac/BrowserWindowController.m 2014-08-01 18:19:07 UTC (rev 171924)
@@ -64,6 +64,9 @@
if ([address rangeOfString:@://].length 0)
return address;
+if ([address hasPrefix:@data:])
+return address;
+
return [@http:// stringByAppendingString:address];
}
Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (171923 => 171924)
--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-08-01 18:16:19 UTC (rev 171923)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-08-01 18:19:07 UTC (rev 171924)
@@ -98,7 +98,7 @@
{
[urlText setStringValue:[self addProtocolIfNecessary:[urlText stringValue]]];
-[_webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:[urlText stringValue;
+[_webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:[[urlText stringValue] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding;
}
- (IBAction)showHideWebView:(id)sender
@@ -423,7 +423,7 @@
if (!URL.absoluteString.length)
return;
-urlText.stringValue = [URL absoluteString];
+urlText.stringValue = [[URL absoluteString] stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
}
- (void)loadURLString:(NSString *)urlString
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171925] trunk/Source/WebCore
Title: [171925] trunk/Source/WebCore
Revision 171925
Author simon.fra...@apple.com
Date 2014-08-01 11:20:04 -0700 (Fri, 01 Aug 2014)
Log Message
nullptr goodness in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=135512
Reviewed by Brent Fulgham.
Use nullptr in RenderLayer.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateDescendantDependentFlags):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateClipRects):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (171924 => 171925)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 18:19:07 UTC (rev 171924)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 18:20:04 UTC (rev 171925)
@@ -1,3 +1,24 @@
+2014-08-01 Simon Fraser simon.fra...@apple.com
+
+nullptr goodness in RenderLayer
+https://bugs.webkit.org/show_bug.cgi?id=135512
+
+Reviewed by Brent Fulgham.
+
+Use nullptr in RenderLayer.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::RenderLayer):
+(WebCore::RenderLayer::updateDescendantDependentFlags):
+(WebCore::accumulateOffsetTowardsAncestor):
+(WebCore::RenderLayer::scrollRectToVisible):
+(WebCore::RenderLayer::destroyScrollbar):
+(WebCore::RenderLayer::paintLayerContents):
+(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
+(WebCore::RenderLayer::hitTestLayer):
+(WebCore::RenderLayer::hitTestList):
+(WebCore::RenderLayer::calculateClipRects):
+
2014-08-01 Tim Horton timothy_hor...@apple.com
Build fix for iOS
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (171924 => 171925)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-08-01 18:19:07 UTC (rev 171924)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-08-01 18:20:04 UTC (rev 171925)
@@ -191,14 +191,14 @@
, m_hasNotIsolatedBlendingDescendantsStatusDirty(false)
#endif
, m_renderer(rendererLayerModelObject)
-, m_parent(0)
-, m_previous(0)
-, m_next(0)
-, m_first(0)
-, m_last(0)
+, m_parent(nullptr)
+, m_previous(nullptr)
+, m_next(nullptr)
+, m_first(nullptr)
+, m_last(nullptr)
, m_staticInlinePosition(0)
, m_staticBlockPosition(0)
-, m_enclosingPaginationLayer(0)
+, m_enclosingPaginationLayer(nullptr)
{
m_isNormalFlowOnly = shouldBeNormalFlowOnly();
m_isSelfPaintingLayer = shouldBeSelfPaintingLayer();
@@ -1139,7 +1139,7 @@
do {
r = r-parent();
if (r == renderer())
-r = 0;
+r = nullptr;
} while (r !r-nextSibling());
if (r)
r = r-nextSibling();
@@ -1894,7 +1894,7 @@
// FIXME: Special casing RenderFlowThread so much for fixed positioning here is not great.
RenderFlowThread* fixedFlowThreadContainer = position == FixedPosition ? renderer.flowThreadContainingBlock() : 0;
if (fixedFlowThreadContainer !fixedFlowThreadContainer-isOutOfFlowPositioned())
-fixedFlowThreadContainer = 0;
+fixedFlowThreadContainer = nullptr;
// FIXME: Positioning of out-of-flow(fixed, absolute) elements collected in a RenderFlowThread
// may need to be revisited in a future patch.
@@ -1916,7 +1916,7 @@
// For a fixed layers, we need to walk up to the root to see if there's a fixed position container
// (e.g. a transformed layer). It's an error to call offsetFromAncestor() across a layer with a transform,
// so we should always find the ancestor at or before we find the fixed position container.
-RenderLayer* fixedPositionContainerLayer = 0;
+RenderLayer* fixedPositionContainerLayer = nullptr;
bool foundAncestor = false;
for (RenderLayer* currLayer = layer-parent(); currLayer; currLayer = currLayer-parent()) {
if (currLayer == ancestorLayer)
@@ -2338,7 +2338,7 @@
void RenderLayer::scrollRectToVisible(const LayoutRect rect, const ScrollAlignment alignX, const ScrollAlignment alignY)
{
-RenderLayer* parentLayer = 0;
+RenderLayer* parentLayer = nullptr;
LayoutRect newRect = rect;
// We may end up propagating a scroll event. It is important that we suspend events until
@@ -2372,7 +2372,7 @@
Element* ownerElement = renderer().document().ownerElement();
if (ownerElement ownerElement-renderer()) {
-HTMLFrameElementBase* frameElementBase = 0;
+HTMLFrameElementBase* frameElementBase =
[webkit-changes] [171926] trunk/Tools
Title: [171926] trunk/Tools
Revision 171926
Author timothy_hor...@apple.com
Date 2014-08-01 11:21:11 -0700 (Fri, 01 Aug 2014)
Log Message
Make it easer to add switches to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=135499
Reviewed by Simon Fraser.
Add a single class to manage a set of persistent, global settings for MiniBrowser.
Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
Add SettingsController.{m, h}.
* MiniBrowser/mac/AppDelegate.h:
Move _browserWindowControllers to the implementation.
Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
of that; instead, we'll receive didChangeSettings.
* MiniBrowser/mac/AppDelegate.m:
Move the default URL, default URL preference key, and use-WebKit2-by-default
preference key into SettingsController.
(-[BrowserAppDelegate awakeFromNib]):
Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
(-[BrowserAppDelegate newWindow:]):
Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
SettingsController now takes care of reading the default URL preference.
WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
(-[BrowserAppDelegate didChangeSettings]):
When settings change, update the key equivalents for the new-window menu items, as they
might have changed (as use-WebKit2-by-default is one of the settings).
Dispatch settings change notifications to all live BrowserControllers.
(-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
(-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
(-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
(-[BrowserAppDelegate validateMenuItem:]): Deleted.
All menu item validation for settings is moved into SettingsController.
* MiniBrowser/mac/BrowserWindowController.h:
Simplify the BrowserWindowController interface; toggling settings will happen inside SettingsController,
the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
* MiniBrowser/mac/MainMenu.xib:
Remove the settings menu items from the Debug menu.
* MiniBrowser/mac/SettingsController.h: Added.
* MiniBrowser/mac/SettingsController.m: Added.
(+[SettingsController shared]):
(-[SettingsController menu]):
(-[SettingsController _addItemWithTitle:action:indented:]):
(-[SettingsController _addHeaderWithTitle:]):
NSMenuItem-creating helpers.
(-[SettingsController _populateMenu]):
Build the menu. Ideally this and the validation step would eventually be made more dynamic.
(-[SettingsController validateMenuItem:]):
Validate menu items; since they can be used to toggle the default state of a setting,
we'll always return YES. However, we will use this opportunity to set the 'checked' state
of each item.
(-[SettingsController _toggleBooleanDefault:]):
Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
(-[SettingsController toggleUseWebKit2ByDefault:]):
(-[SettingsController useWebKit2ByDefault]):
(-[SettingsController toggleUseTransparentWindows:]):
(-[SettingsController useTransparentWindows]):
(-[SettingsController toggleUsePaginatedMode:]):
(-[SettingsController usePaginatedMode]):
(-[SettingsController toggleUseUISideCompositing:]):
(-[SettingsController useUISideCompositing]):
(-[SettingsController toggleShowLayerBorders:]):
(-[SettingsController layerBordersVisible]):
(-[SettingsController toggleShowTiledScrollingIndicator:]):
(-[SettingsController tiledScrollingIndicatorVisible]):
(-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
(-[SettingsController subPixelCSSOMMetricsEnabled]):
(-[SettingsController defaultURL]):
Toggle or return the current state of each preference.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController validateMenuItem:]):
(-[WK1BrowserWindowController windowWillClose:]):
(-[WK1BrowserWindowController find:]):
(-[WK1BrowserWindowController dumpSourceToConsole:]):
(-[WK1BrowserWindowController didChangeSettings]):
(-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
(-[WK1BrowserWindowController isPaginated]): Deleted.
(-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
(-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
(-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
(-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
(-[WK1BrowserWindowController layerBordersVisible]): Deleted.
(-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController validateMenuItem:]):
[webkit-changes] [171927] branches/safari-600.1.4-branch/Source/WebCore
Title: [171927] branches/safari-600.1.4-branch/Source/WebCore
Revision 171927
Author matthew_han...@apple.com
Date 2014-08-01 11:21:59 -0700 (Fri, 01 Aug 2014)
Log Message
Merge r171259. rdar://problem/17718984
Modified Paths
branches/safari-600.1.4-branch/Source/WebCore/ChangeLog
branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: branches/safari-600.1.4-branch/Source/WebCore/ChangeLog (171926 => 171927)
--- branches/safari-600.1.4-branch/Source/WebCore/ChangeLog 2014-08-01 18:21:11 UTC (rev 171926)
+++ branches/safari-600.1.4-branch/Source/WebCore/ChangeLog 2014-08-01 18:21:59 UTC (rev 171927)
@@ -1,5 +1,19 @@
2014-07-31 Matthew Hanson matthew_han...@apple.com
+Merge r171259. rdar://problem/17718984
+
+2014-07-18 Eric Carlson eric.carl...@apple.com
+
+[iOS] ignore requests to set volume
+https://bugs.webkit.org/show_bug.cgi?id=135081
+
+Reviewed by Jer Noble.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Do nothing on iOS.
+
+2014-07-31 Matthew Hanson matthew_han...@apple.com
+
Merge r171895. rdar://problem/17835345
2014-07-31 Jer Noble jer.no...@apple.com
Modified: branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (171926 => 171927)
--- branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 18:21:11 UTC (rev 171926)
+++ branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 18:21:59 UTC (rev 171927)
@@ -1155,6 +1155,10 @@
void MediaPlayerPrivateAVFoundationObjC::setVolume(float volume)
{
+#if PLATFORM(IOS)
+return;
+#endif
+
if (!metaDataAvailable())
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171923] trunk/Source/WebCore
Title: [171923] trunk/Source/WebCore Revision 171923 Author timothy_hor...@apple.com Date 2014-08-01 11:16:19 -0700 (Fri, 01 Aug 2014) Log Message Build fix for iOS * bindings/objc/DOM.mm: (-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]): We use CGImageRef instead of NSImage here on iOS. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/objc/DOM.mm Diff Modified: trunk/Source/WebCore/ChangeLog (171922 => 171923) --- trunk/Source/WebCore/ChangeLog 2014-08-01 17:46:27 UTC (rev 171922) +++ trunk/Source/WebCore/ChangeLog 2014-08-01 18:16:19 UTC (rev 171923) @@ -1,3 +1,11 @@ +2014-08-01 Tim Horton timothy_hor...@apple.com + +Build fix for iOS + +* bindings/objc/DOM.mm: +(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]): +We use CGImageRef instead of NSImage here on iOS. + 2014-08-01 Renato Nagy nagy.ren...@stud.u-szeged.hu ASSERTION FAILED: listNode in WebCore::RenderListItem::updateListMarkerNumbers Modified: trunk/Source/WebCore/bindings/objc/DOM.mm (171922 => 171923) --- trunk/Source/WebCore/bindings/objc/DOM.mm 2014-08-01 17:46:27 UTC (rev 171922) +++ trunk/Source/WebCore/bindings/objc/DOM.mm 2014-08-01 18:16:19 UTC (rev 171923) @@ -610,6 +610,8 @@ if (!frame) return nil; +// iOS uses CGImageRef for drag images, which doesn't support separate logical/physical sizes. +#if PLATFORM(MAC) RetainPtrNSImage renderedImage = createDragImageForRange(*frame, *range, forceBlackText); IntSize size([renderedImage size]); @@ -617,6 +619,9 @@ [renderedImage setSize:size]; return renderedImage.autorelease(); +#else +return createDragImageForRange(*frame, *range, forceBlackText).autorelease(); +#endif } - (NSArray *)textRects ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171928] trunk/Source/WebKit2
Title: [171928] trunk/Source/WebKit2 Revision 171928 Author m...@apple.com Date 2014-08-01 11:22:38 -0700 (Fri, 01 Aug 2014) Log Message rdar://problem/17862013 REGRESSION (r169357): Disabling allow plug-ins doesn't stick on quit/relaunch https://bugs.webkit.org/show_bug.cgi?id=135511 Reviewed by Alexey Proskuryakov. Since the values map in the preferences store doesn’t include values that are equal to the defaults, we need to update it when a new default is registered. * UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::createWithLegacyDefaults): Changed to use new member functions for registering defaults. (WebKit::WebPreferences::registerDefaultBoolValueForKey): Added. Sets an override default in the store, and sets the user default, if there is one, on top of it. (WebKit::WebPreferences::registerDefaultUInt32ValueForKey): Ditto. * UIProcess/WebPreferences.h: Declared new member functions for getting the user default value for a key. * UIProcess/efl/WebPreferencesEfl.cpp: (WebKit::WebPreferences::platformGetStringUserValueForKey): Added an implementation that returns false, because the EFL port doesn’t support persistent user defaults. (WebKit::WebPreferences::platformGetBoolUserValueForKey): Ditto. (WebKit::WebPreferences::platformGetUInt32UserValueForKey): Ditto. (WebKit::WebPreferences::platformGetDoubleUserValueForKey): Ditto. * UIProcess/gtk/WebPreferencesGtk.cpp: (WebKit::WebPreferences::platformGetStringUserValueForKey): Ditto for the GTK port. (WebKit::WebPreferences::platformGetBoolUserValueForKey): Ditto. (WebKit::WebPreferences::platformGetUInt32UserValueForKey): Ditto. (WebKit::WebPreferences::platformGetDoubleUserValueForKey): Ditto. * UIProcess/mac/WebPreferencesMac.mm: (WebKit::WebPreferences::platformGetStringUserValueForKey): Added. Replaces setStringValueIfInUserDefaults, on which it is based. (WebKit::WebPreferences::platformGetBoolUserValueForKey): Similarly for booleans. (WebKit::WebPreferences::platformGetUInt32UserValueForKey): Similarly for integers. (WebKit::WebPreferences::platformGetDoubleUserValueForKey): Similarly for doubles. (WebKit::WebPreferences::platformInitializeStore): Changed to use the above functions. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPreferences.cpp trunk/Source/WebKit2/UIProcess/WebPreferences.h trunk/Source/WebKit2/UIProcess/efl/WebPreferencesEfl.cpp trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp trunk/Source/WebKit2/UIProcess/mac/WebPreferencesMac.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (171927 => 171928) --- trunk/Source/WebKit2/ChangeLog 2014-08-01 18:21:59 UTC (rev 171927) +++ trunk/Source/WebKit2/ChangeLog 2014-08-01 18:22:38 UTC (rev 171928) @@ -1,3 +1,43 @@ +2014-08-01 Dan Bernstein m...@apple.com + +rdar://problem/17862013 REGRESSION (r169357): Disabling allow plug-ins doesn't stick on quit/relaunch +https://bugs.webkit.org/show_bug.cgi?id=135511 + +Reviewed by Alexey Proskuryakov. + +Since the values map in the preferences store doesn’t include values that are equal to the +defaults, we need to update it when a new default is registered. + +* UIProcess/WebPreferences.cpp: +(WebKit::WebPreferences::createWithLegacyDefaults): Changed to use new member functions +for registering defaults. +(WebKit::WebPreferences::registerDefaultBoolValueForKey): Added. Sets an override default +in the store, and sets the user default, if there is one, on top of it. +(WebKit::WebPreferences::registerDefaultUInt32ValueForKey): Ditto. +* UIProcess/WebPreferences.h: Declared new member functions for getting the user default +value for a key. + +* UIProcess/efl/WebPreferencesEfl.cpp: +(WebKit::WebPreferences::platformGetStringUserValueForKey): Added an implementation that +returns false, because the EFL port doesn’t support persistent user defaults. +(WebKit::WebPreferences::platformGetBoolUserValueForKey): Ditto. +(WebKit::WebPreferences::platformGetUInt32UserValueForKey): Ditto. +(WebKit::WebPreferences::platformGetDoubleUserValueForKey): Ditto. + +* UIProcess/gtk/WebPreferencesGtk.cpp: +(WebKit::WebPreferences::platformGetStringUserValueForKey): Ditto for the GTK port. +(WebKit::WebPreferences::platformGetBoolUserValueForKey): Ditto. +(WebKit::WebPreferences::platformGetUInt32UserValueForKey): Ditto. +(WebKit::WebPreferences::platformGetDoubleUserValueForKey): Ditto. + +* UIProcess/mac/WebPreferencesMac.mm: +(WebKit::WebPreferences::platformGetStringUserValueForKey): Added. Replaces +setStringValueIfInUserDefaults, on which it is based. +(WebKit::WebPreferences::platformGetBoolUserValueForKey): Similarly for booleans. +(WebKit::WebPreferences::platformGetUInt32UserValueForKey): Similarly for integers. +
[webkit-changes] [171929] branches/safari-600.1.4-branch/Source/WebCore
Title: [171929] branches/safari-600.1.4-branch/Source/WebCore
Revision 171929
Author matthew_han...@apple.com
Date 2014-08-01 11:26:16 -0700 (Fri, 01 Aug 2014)
Log Message
Merge r171259. rdar://problem/17718984
Modified Paths
branches/safari-600.1.4-branch/Source/WebCore/ChangeLog
branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: branches/safari-600.1.4-branch/Source/WebCore/ChangeLog (171928 => 171929)
--- branches/safari-600.1.4-branch/Source/WebCore/ChangeLog 2014-08-01 18:22:38 UTC (rev 171928)
+++ branches/safari-600.1.4-branch/Source/WebCore/ChangeLog 2014-08-01 18:26:16 UTC (rev 171929)
@@ -2,6 +2,21 @@
Merge r171259. rdar://problem/17718984
+2014-07-20 Eric Carlson eric.carl...@apple.com
+
+[iOS] ignore requests to set volume
+https://bugs.webkit.org/show_bug.cgi?id=135081
+
+Applied post-review comments from Darin Adler.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Don't include unreachable
+code on iOS.
+
+2014-07-31 Matthew Hanson matthew_han...@apple.com
+
+Merge r171259. rdar://problem/17718984
+
2014-07-18 Eric Carlson eric.carl...@apple.com
[iOS] ignore requests to set volume
Modified: branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (171928 => 171929)
--- branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 18:22:38 UTC (rev 171928)
+++ branches/safari-600.1.4-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 18:26:16 UTC (rev 171929)
@@ -1156,13 +1156,14 @@
void MediaPlayerPrivateAVFoundationObjC::setVolume(float volume)
{
#if PLATFORM(IOS)
+UNUSED_PARAM(volume);
return;
-#endif
-
+#else
if (!metaDataAvailable())
return;
[m_avPlayer.get() setVolume:volume];
+#endif
}
void MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible(bool closedCaptionsVisible)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171930] tags/Safari-600.1.4.3/Source
Title: [171930] tags/Safari-600.1.4.3/Source Revision 171930 Author matthew_han...@apple.com Date 2014-08-01 11:28:13 -0700 (Fri, 01 Aug 2014) Log Message Versioning. Modified Paths tags/Safari-600.1.4.3/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-600.1.4.3/Source/WebCore/Configurations/Version.xcconfig tags/Safari-600.1.4.3/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-600.1.4.3/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-600.1.4.3/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-600.1.4.3/Source/_javascript_Core/Configurations/Version.xcconfig (171929 => 171930) --- tags/Safari-600.1.4.3/Source/_javascript_Core/Configurations/Version.xcconfig 2014-08-01 18:26:16 UTC (rev 171929) +++ tags/Safari-600.1.4.3/Source/_javascript_Core/Configurations/Version.xcconfig 2014-08-01 18:28:13 UTC (rev 171930) @@ -24,7 +24,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-600.1.4.3/Source/WebCore/Configurations/Version.xcconfig (171929 => 171930) --- tags/Safari-600.1.4.3/Source/WebCore/Configurations/Version.xcconfig 2014-08-01 18:26:16 UTC (rev 171929) +++ tags/Safari-600.1.4.3/Source/WebCore/Configurations/Version.xcconfig 2014-08-01 18:28:13 UTC (rev 171930) @@ -24,7 +24,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-600.1.4.3/Source/WebInspectorUI/Configurations/Version.xcconfig (171929 => 171930) --- tags/Safari-600.1.4.3/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-08-01 18:26:16 UTC (rev 171929) +++ tags/Safari-600.1.4.3/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-08-01 18:28:13 UTC (rev 171930) @@ -1,7 +1,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-600.1.4.3/Source/WebKit/mac/Configurations/Version.xcconfig (171929 => 171930) --- tags/Safari-600.1.4.3/Source/WebKit/mac/Configurations/Version.xcconfig 2014-08-01 18:26:16 UTC (rev 171929) +++ tags/Safari-600.1.4.3/Source/WebKit/mac/Configurations/Version.xcconfig 2014-08-01 18:28:13 UTC (rev 171930) @@ -24,7 +24,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-600.1.4.3/Source/WebKit2/Configurations/Version.xcconfig (171929 => 171930) --- tags/Safari-600.1.4.3/Source/WebKit2/Configurations/Version.xcconfig 2014-08-01 18:26:16 UTC (rev 171929) +++ tags/Safari-600.1.4.3/Source/WebKit2/Configurations/Version.xcconfig 2014-08-01 18:28:13 UTC (rev 171930) @@ -24,7 +24,7 @@ MAJOR_VERSION = 600; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171931] trunk/Source/WebCore
Title: [171931] trunk/Source/WebCore
Revision 171931
Author psola...@apple.com
Date 2014-08-01 11:29:28 -0700 (Fri, 01 Aug 2014)
Log Message
Remove EventNames.h include from header files
https://bugs.webkit.org/show_bug.cgi?id=135486
Reviewed by Alexey Proskuryakov.
No new tests because no functional changes.
* Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h:
* Modules/gamepad/GamepadEvent.h:
* Modules/indexeddb/IDBRequest.h:
* Modules/indexeddb/IDBTransaction.h:
* Modules/mediastream/RTCStatsResponse.h:
* Modules/websockets/WebSocket.h:
* css/FontLoader.h:
* dom/SecurityPolicyViolationEvent.h:
* loader/appcache/DOMApplicationCache.h:
* workers/AbstractWorker.h:
* workers/Worker.h:
* workers/WorkerGlobalScope.h:
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequestProgressEvent.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h
trunk/Source/WebCore/Modules/gamepad/GamepadEvent.h
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h
trunk/Source/WebCore/Modules/mediastream/RTCStatsResponse.h
trunk/Source/WebCore/Modules/websockets/WebSocket.h
trunk/Source/WebCore/css/FontLoader.h
trunk/Source/WebCore/dom/SecurityPolicyViolationEvent.h
trunk/Source/WebCore/loader/appcache/DOMApplicationCache.h
trunk/Source/WebCore/workers/AbstractWorker.h
trunk/Source/WebCore/workers/Worker.h
trunk/Source/WebCore/workers/WorkerGlobalScope.h
trunk/Source/WebCore/xml/XMLHttpRequest.h
trunk/Source/WebCore/xml/XMLHttpRequestProgressEvent.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (171930 => 171931)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 18:28:13 UTC (rev 171930)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 18:29:28 UTC (rev 171931)
@@ -1,3 +1,27 @@
+2014-08-01 Pratik Solanki psola...@apple.com
+
+Remove EventNames.h include from header files
+https://bugs.webkit.org/show_bug.cgi?id=135486
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests because no functional changes.
+
+* Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h:
+* Modules/gamepad/GamepadEvent.h:
+* Modules/indexeddb/IDBRequest.h:
+* Modules/indexeddb/IDBTransaction.h:
+* Modules/mediastream/RTCStatsResponse.h:
+* Modules/websockets/WebSocket.h:
+* css/FontLoader.h:
+* dom/SecurityPolicyViolationEvent.h:
+* loader/appcache/DOMApplicationCache.h:
+* workers/AbstractWorker.h:
+* workers/Worker.h:
+* workers/WorkerGlobalScope.h:
+* xml/XMLHttpRequest.h:
+* xml/XMLHttpRequestProgressEvent.h:
+
2014-08-01 Simon Fraser simon.fra...@apple.com
nullptr goodness in RenderLayer
Modified: trunk/Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h (171930 => 171931)
--- trunk/Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h 2014-08-01 18:28:13 UTC (rev 171930)
+++ trunk/Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h 2014-08-01 18:29:28 UTC (rev 171931)
@@ -29,7 +29,6 @@
#if ENABLE(IOS_AIRPLAY)
#include Event.h
-#include EventNames.h
namespace WebCore {
Modified: trunk/Source/WebCore/Modules/gamepad/GamepadEvent.h (171930 => 171931)
--- trunk/Source/WebCore/Modules/gamepad/GamepadEvent.h 2014-08-01 18:28:13 UTC (rev 171930)
+++ trunk/Source/WebCore/Modules/gamepad/GamepadEvent.h 2014-08-01 18:29:28 UTC (rev 171931)
@@ -28,7 +28,6 @@
#if ENABLE(GAMEPAD)
#include Event.h
-#include EventNames.h
#include Gamepad.h
#include wtf/RefPtr.h
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h (171930 => 171931)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h 2014-08-01 18:28:13 UTC (rev 171930)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h 2014-08-01 18:29:28 UTC (rev 171931)
@@ -37,7 +37,6 @@
#include DOMStringList.h
#include Event.h
#include EventListener.h
-#include EventNames.h
#include EventTarget.h
#include IDBAny.h
#include IDBCallbacks.h
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h (171930 => 171931)
--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h 2014-08-01 18:28:13 UTC (rev 171930)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h 2014-08-01 18:29:28 UTC (rev 171931)
@@ -32,7 +32,6 @@
#include DOMError.h
#include Event.h
#include EventListener.h
-#include EventNames.h
#include EventTarget.h
#include IDBDatabaseMetadata.h
#include IndexedDB.h
Modified: trunk/Source/WebCore/Modules/mediastream/RTCStatsResponse.h (171930 => 171931)
--- trunk/Source/WebCore/Modules/mediastream/RTCStatsResponse.h 2014-08-01 18:28:13 UTC (rev 171930)
+++ trunk/Source/WebCore/Modules/mediastream/RTCStatsResponse.h 2014-08-01 18:29:28 UTC (rev 171931)
@@ -30,7 +30,6 @@
#include DOMStringList.h
#include Event.h
#include EventListener.h
-#include EventNames.h
#include EventTarget.h
#include
[webkit-changes] [171932] trunk/Source/WebCore
Title: [171932] trunk/Source/WebCore
Revision 171932
Author timothy_hor...@apple.com
Date 2014-08-01 11:30:34 -0700 (Fri, 01 Aug 2014)
Log Message
Fix the iOS build after r171891
* platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (171931 => 171932)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 18:29:28 UTC (rev 171931)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 18:30:34 UTC (rev 171932)
@@ -1,3 +1,11 @@
+2014-08-01 Tim Horton timothy_hor...@apple.com
+
+Fix the iOS build after r171891
+
+* platform/ios/ScrollViewIOS.mm:
+(WebCore::ScrollView::platformTopContentInset):
+(WebCore::ScrollView::platformSetTopContentInset):
+
2014-08-01 Pratik Solanki psola...@apple.com
Remove EventNames.h include from header files
Modified: trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm (171931 => 171932)
--- trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm 2014-08-01 18:29:28 UTC (rev 171931)
+++ trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm 2014-08-01 18:30:34 UTC (rev 171932)
@@ -161,12 +161,12 @@
END_BLOCK_OBJC_EXCEPTIONS;
}
-float ScrollView::platformTopContentInset(float) const
+float ScrollView::platformTopContentInset() const
{
return 0;
}
-void ScrollView::platformSetTopContentInset()
+void ScrollView::platformSetTopContentInset(float)
{
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171933] tags/Safari-600.1.4.3/Source/WebCore
Title: [171933] tags/Safari-600.1.4.3/Source/WebCore
Revision 171933
Author matthew_han...@apple.com
Date 2014-08-01 11:32:18 -0700 (Fri, 01 Aug 2014)
Log Message
Merge r171259. rdar://problem/17718984
Modified Paths
tags/Safari-600.1.4.3/Source/WebCore/ChangeLog
tags/Safari-600.1.4.3/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: tags/Safari-600.1.4.3/Source/WebCore/ChangeLog (171932 => 171933)
--- tags/Safari-600.1.4.3/Source/WebCore/ChangeLog 2014-08-01 18:30:34 UTC (rev 171932)
+++ tags/Safari-600.1.4.3/Source/WebCore/ChangeLog 2014-08-01 18:32:18 UTC (rev 171933)
@@ -1,5 +1,19 @@
2014-07-31 Matthew Hanson matthew_han...@apple.com
+Merge r171259. rdar://problem/17718984
+
+2014-07-18 Eric Carlson eric.carl...@apple.com
+
+[iOS] ignore requests to set volume
+https://bugs.webkit.org/show_bug.cgi?id=135081
+
+Reviewed by Jer Noble.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Do nothing on iOS.
+
+2014-07-31 Matthew Hanson matthew_han...@apple.com
+
Merge r171895. rdar://problem/17835345
2014-07-31 Jer Noble jer.no...@apple.com
Modified: tags/Safari-600.1.4.3/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (171932 => 171933)
--- tags/Safari-600.1.4.3/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 18:30:34 UTC (rev 171932)
+++ tags/Safari-600.1.4.3/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 18:32:18 UTC (rev 171933)
@@ -1155,6 +1155,10 @@
void MediaPlayerPrivateAVFoundationObjC::setVolume(float volume)
{
+#if PLATFORM(IOS)
+return;
+#endif
+
if (!metaDataAvailable())
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171934] tags/Safari-600.1.4.3/Source/WebCore
Title: [171934] tags/Safari-600.1.4.3/Source/WebCore
Revision 171934
Author matthew_han...@apple.com
Date 2014-08-01 11:33:31 -0700 (Fri, 01 Aug 2014)
Log Message
Merge r171259. rdar://problem/17718984
Modified Paths
tags/Safari-600.1.4.3/Source/WebCore/ChangeLog
tags/Safari-600.1.4.3/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: tags/Safari-600.1.4.3/Source/WebCore/ChangeLog (171933 => 171934)
--- tags/Safari-600.1.4.3/Source/WebCore/ChangeLog 2014-08-01 18:32:18 UTC (rev 171933)
+++ tags/Safari-600.1.4.3/Source/WebCore/ChangeLog 2014-08-01 18:33:31 UTC (rev 171934)
@@ -2,6 +2,21 @@
Merge r171259. rdar://problem/17718984
+2014-07-20 Eric Carlson eric.carl...@apple.com
+
+[iOS] ignore requests to set volume
+https://bugs.webkit.org/show_bug.cgi?id=135081
+
+Applied post-review comments from Darin Adler.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Don't include unreachable
+code on iOS.
+
+2014-07-31 Matthew Hanson matthew_han...@apple.com
+
+Merge r171259. rdar://problem/17718984
+
2014-07-18 Eric Carlson eric.carl...@apple.com
[iOS] ignore requests to set volume
Modified: tags/Safari-600.1.4.3/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (171933 => 171934)
--- tags/Safari-600.1.4.3/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 18:32:18 UTC (rev 171933)
+++ tags/Safari-600.1.4.3/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-08-01 18:33:31 UTC (rev 171934)
@@ -1156,13 +1156,14 @@
void MediaPlayerPrivateAVFoundationObjC::setVolume(float volume)
{
#if PLATFORM(IOS)
+UNUSED_PARAM(volume);
return;
-#endif
-
+#else
if (!metaDataAvailable())
return;
[m_avPlayer.get() setVolume:volume];
+#endif
}
void MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible(bool closedCaptionsVisible)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171935] trunk/Tools
Title: [171935] trunk/Tools
Revision 171935
Author timothy_hor...@apple.com
Date 2014-08-01 11:44:46 -0700 (Fri, 01 Aug 2014)
Log Message
Confusing build fix after r171926.
* MiniBrowser/mac/AppDelegate.h:
* MiniBrowser/mac/AppDelegate.m:
* MiniBrowser/mac/SettingsController.m:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/AppDelegate.h
trunk/Tools/MiniBrowser/mac/AppDelegate.m
trunk/Tools/MiniBrowser/mac/SettingsController.m
Diff
Modified: trunk/Tools/ChangeLog (171934 => 171935)
--- trunk/Tools/ChangeLog 2014-08-01 18:33:31 UTC (rev 171934)
+++ trunk/Tools/ChangeLog 2014-08-01 18:44:46 UTC (rev 171935)
@@ -1,5 +1,13 @@
2014-08-01 Tim Horton timothy_hor...@apple.com
+Confusing build fix after r171926.
+
+* MiniBrowser/mac/AppDelegate.h:
+* MiniBrowser/mac/AppDelegate.m:
+* MiniBrowser/mac/SettingsController.m:
+
+2014-08-01 Tim Horton timothy_hor...@apple.com
+
Make it easer to add switches to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=135499
Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.h (171934 => 171935)
--- trunk/Tools/MiniBrowser/mac/AppDelegate.h 2014-08-01 18:33:31 UTC (rev 171934)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.h 2014-08-01 18:44:46 UTC (rev 171935)
@@ -24,6 +24,8 @@
*/
@interface BrowserAppDelegate : NSObject NSApplicationDelegate {
+NSMutableSet *_browserWindowControllers;
+
IBOutlet NSMenuItem *_newWebKit1WindowItem;
IBOutlet NSMenuItem *_newWebKit2WindowItem;
}
Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (171934 => 171935)
--- trunk/Tools/MiniBrowser/mac/AppDelegate.m 2014-08-01 18:33:31 UTC (rev 171934)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m 2014-08-01 18:44:46 UTC (rev 171935)
@@ -36,9 +36,7 @@
WebKit2NewWindowTag = 2
};
-@implementation BrowserAppDelegate {
-NSMutableSet *_browserWindowControllers;
-}
+@implementation BrowserAppDelegate
- (id)init
{
Modified: trunk/Tools/MiniBrowser/mac/SettingsController.m (171934 => 171935)
--- trunk/Tools/MiniBrowser/mac/SettingsController.m 2014-08-01 18:33:31 UTC (rev 171934)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.m 2014-08-01 18:44:46 UTC (rev 171935)
@@ -42,7 +42,9 @@
// This default name intentionally overlaps with the key that WebKit2 checks when creating a view.
static NSString * const UseRemoteLayerTreeDrawingAreaPreferenceKey = @WebKit2UseRemoteLayerTreeDrawingArea;
-@implementation SettingsController
+@implementation SettingsController {
+NSMenu *_menu;
+}
@synthesize menu=_menu;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171936] tags/Safari-600.1.2.5
Title: [171936] tags/Safari-600.1.2.5
Revision 171936
Author matthew_han...@apple.com
Date 2014-08-01 11:50:05 -0700 (Fri, 01 Aug 2014)
Log Message
Merge r171903. rdar://problem/17877481
Modified Paths
tags/Safari-600.1.2.5/Tools/ChangeLog
tags/Safari-600.1.2.5/WebKitLibraries/ChangeLog
tags/Safari-600.1.2.5/WebKitLibraries/win/tools/scripts/version-stamp.pl
Added Paths
tags/Safari-600.1.2.5/Tools/Scripts/webkitperl/auto-version_unittest/versionStampTests.pl
Diff
Modified: tags/Safari-600.1.2.5/Tools/ChangeLog (171935 => 171936)
--- tags/Safari-600.1.2.5/Tools/ChangeLog 2014-08-01 18:44:46 UTC (rev 171935)
+++ tags/Safari-600.1.2.5/Tools/ChangeLog 2014-08-01 18:50:05 UTC (rev 171936)
@@ -1,3 +1,18 @@
+2014-08-01 Matthew Hanson matthew_han...@apple.com
+
+Merge r171903. rdar://problem/17877481
+
+2014-07-31 Brent Fulgham bfulg...@apple.com
+
+[Win] Use RC_PROJECTBUILDVERSION as build portion of version
+https://bugs.webkit.org/show_bug.cgi?id=135478
+
+Reviewed by David Kilzer.
+
+Add new test suite for the version-stamp program.
+
+* Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
+
2014-07-30 Matthew Hanson matthew_han...@apple.com
Merge r171798. rdar://problem/17849033
Copied: tags/Safari-600.1.2.5/Tools/Scripts/webkitperl/auto-version_unittest/versionStampTests.pl (from rev 171903, trunk/Tools/Scripts/webkitperl/auto-version_unittest/versionStampTests.pl) (0 => 171936)
--- tags/Safari-600.1.2.5/Tools/Scripts/webkitperl/auto-version_unittest/versionStampTests.pl (rev 0)
+++ tags/Safari-600.1.2.5/Tools/Scripts/webkitperl/auto-version_unittest/versionStampTests.pl 2014-08-01 18:50:05 UTC (rev 171936)
@@ -0,0 +1,93 @@
+#!/usr/bin/perl -w
+
+# Copyright (C) 2014 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+use strict;
+use warnings;
+
+use File::Spec;
+use File::Temp qw/ tempdir /;
+
+use Test::More;
+
+my @testCases =
+(
+{
+'RC_ProjectSourceVersion' = '5300.4.3.2.1',
+'RC_PROJECTBUILDVERSION' = undef,
+expectedVersionResult = '300.4003.2001',
+expectedBuildVersionResult = 1,
+},
+
+{
+'RC_ProjectSourceVersion' = '5300.4.3.2.1',
+'RC_PROJECTBUILDVERSION' = 156,
+expectedVersionResult = '300.4003.2001',
+expectedBuildVersionResult = 156,
+},
+);
+
+# This test should only be run on Windows
+if ($^O ne 'MSWin32' $^O ne 'cygwin') {
+plan(tests = 1);
+is(1, 1, 'do nothing for non-Windows builds.');
+exit 0;
+}
+
+my $testCasesCount = scalar(@testCases) * 2;
+plan(tests = $testCasesCount);
+
+my $TOOLS_PATH = $ENV{'WEBKIT_LIBRARIES'};
+my $AUTO_VERSION_SCRIPT = File::Spec-catfile($TOOLS_PATH, 'tools', 'scripts', 'auto-version.pl');
+my $VERSION_STAMP_SCRIPT = File::Spec-catfile($TOOLS_PATH, 'tools', 'scripts', 'version-stamp.pl');
+
+foreach my $testCase (@testCases) {
+my $testOutputDir = tempdir(CLEANUP = 1);
+`RC_ProjectSourceVersion=$testCase-{'RC_ProjectSourceVersion'} perl $AUTO_VERSION_SCRIPT $testOutputDir`;
+
+my $command;
+if (defined($testCase-{'RC_PROJECTBUILDVERSION'})) {
+$command=RC_PROJECTBUILDVERSION=\$testCase-{'RC_PROJECTBUILDVERSION'}\ ;
+}
+$command .= perl $VERSION_STAMP_SCRIPT $testOutputDir $testOutputDir;
+
+my @versionStamperOutput = qx($command 21);
+
+foreach my $line (@versionStamperOutput) {
+if ($line !~ m/RC_PROJECTBUILDVERSION/) {
+next;
+}
+
+chomp($line);
+
+$line =~ m/RC_PROJECTSOURCEVERSION=([^\s]+) and RC_PROJECTBUILDVERSION=(.*)$/;
+
+my $projectSourceResult=$1;
+
[webkit-changes] [171937] trunk/Source/WebCore
Title: [171937] trunk/Source/WebCore Revision 171937 Author jer.no...@apple.com Date 2014-08-01 11:53:38 -0700 (Fri, 01 Aug 2014) Log Message [MSE][Mac] Volume is not remembered between items in a YouTube playlist https://bugs.webkit.org/show_bug.cgi?id=135479 Reviewed by Eric Carlson. When an AVSampleBufferAudioRenderer is added to the player, set its -volume and -muted properties with the current values from the HTMLMediaElement. * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm Diff Modified: trunk/Source/WebCore/ChangeLog (171936 => 171937) --- trunk/Source/WebCore/ChangeLog 2014-08-01 18:50:05 UTC (rev 171936) +++ trunk/Source/WebCore/ChangeLog 2014-08-01 18:53:38 UTC (rev 171937) @@ -1,3 +1,16 @@ +2014-08-01 Jer Noble jer.no...@apple.com + +[MSE][Mac] Volume is not remembered between items in a YouTube playlist +https://bugs.webkit.org/show_bug.cgi?id=135479 + +Reviewed by Eric Carlson. + +When an AVSampleBufferAudioRenderer is added to the player, set its -volume and -muted +properties with the current values from the HTMLMediaElement. + +* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: +(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer): + 2014-08-01 Tim Horton timothy_hor...@apple.com Fix the iOS build after r171891 Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (171936 => 171937) --- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2014-08-01 18:50:05 UTC (rev 171936) +++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2014-08-01 18:53:38 UTC (rev 171937) @@ -758,6 +758,10 @@ return; m_sampleBufferAudioRenderers.append(audioRenderer); + +[audioRenderer setMuted:m_player-muted()]; +[audioRenderer setVolume:m_player-volume()]; + [m_synchronizer addRenderer:audioRenderer]; m_player-mediaPlayerClient()-mediaPlayerRenderingModeChanged(m_player); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171938] tags/Safari-600.1.2.5/Safari-600.1.2.4/
Title: [171938] tags/Safari-600.1.2.5/Safari-600.1.2.4/ Revision 171938 Author matthew_han...@apple.com Date 2014-08-01 11:54:28 -0700 (Fri, 01 Aug 2014) Log Message Remove extraneous tag. Removed Paths tags/Safari-600.1.2.5/Safari-600.1.2.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171939] trunk/Source
Title: [171939] trunk/Source Revision 171939 Author akl...@apple.com Date 2014-08-01 11:57:39 -0700 (Fri, 01 Aug 2014) Log Message Remove the JSC::OverridesVisitChildren flag. https://webkit.org/b/135489 Source/_javascript_Core: Except for 3 special classes, the visitChildren() call is always dispatched through the method table (see SlotVisitor.cpp.) The OverridesVisitChildren flag doesn't actually do anything. It could be used to implement a non-virtual direct call to JSCell::visitChildren, bypassing the method table for some objects, but such a micro-optimization seems like a weak trade for all this code complexity. Instead, just remove the flag. This change frees up an inline flag bit in JSCell. Reviewed by Geoffrey Garen. * API/JSAPIWrapperObject.h: * API/JSAPIWrapperObject.mm: (JSC::JSAPIWrapperObject::visitChildren): * API/JSCallbackObject.h: (JSC::JSCallbackObject::visitChildren): * bytecode/UnlinkedCodeBlock.cpp: (JSC::UnlinkedFunctionExecutable::visitChildren): (JSC::UnlinkedCodeBlock::visitChildren): (JSC::UnlinkedProgramCodeBlock::visitChildren): * bytecode/UnlinkedCodeBlock.h: * debugger/DebuggerScope.cpp: (JSC::DebuggerScope::visitChildren): * debugger/DebuggerScope.h: * jsc.cpp: * runtime/Arguments.cpp: (JSC::Arguments::visitChildren): * runtime/Arguments.h: * runtime/Executable.cpp: (JSC::EvalExecutable::visitChildren): (JSC::ProgramExecutable::visitChildren): (JSC::FunctionExecutable::visitChildren): * runtime/Executable.h: * runtime/GetterSetter.cpp: (JSC::GetterSetter::visitChildren): * runtime/GetterSetter.h: (JSC::GetterSetter::createStructure): * runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): * runtime/JSActivation.cpp: (JSC::JSActivation::visitChildren): * runtime/JSActivation.h: * runtime/JSArrayIterator.cpp: (JSC::JSArrayIterator::visitChildren): * runtime/JSArrayIterator.h: * runtime/JSBoundFunction.cpp: (JSC::JSBoundFunction::visitChildren): * runtime/JSBoundFunction.h: * runtime/JSCellInlines.h: (JSC::JSCell::setStructure): * runtime/JSFunction.cpp: (JSC::JSFunction::visitChildren): * runtime/JSFunction.h: * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildren): * runtime/JSGlobalObject.h: * runtime/JSMap.h: * runtime/JSMapIterator.cpp: (JSC::JSMapIterator::visitChildren): * runtime/JSMapIterator.h: * runtime/JSNameScope.cpp: (JSC::JSNameScope::visitChildren): * runtime/JSNameScope.h: * runtime/JSPromise.cpp: (JSC::JSPromise::visitChildren): * runtime/JSPromise.h: * runtime/JSPromiseDeferred.cpp: (JSC::JSPromiseDeferred::visitChildren): * runtime/JSPromiseDeferred.h: * runtime/JSPromiseReaction.cpp: (JSC::JSPromiseReaction::visitChildren): * runtime/JSPromiseReaction.h: * runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::visitChildren): * runtime/JSPropertyNameIterator.h: * runtime/JSProxy.cpp: (JSC::JSProxy::visitChildren): * runtime/JSProxy.h: * runtime/JSScope.cpp: (JSC::JSScope::visitChildren): * runtime/JSScope.h: * runtime/JSSegmentedVariableObject.cpp: (JSC::JSSegmentedVariableObject::visitChildren): * runtime/JSSegmentedVariableObject.h: * runtime/JSSet.h: * runtime/JSSetIterator.cpp: (JSC::JSSetIterator::visitChildren): * runtime/JSSetIterator.h: * runtime/JSSymbolTableObject.cpp: (JSC::JSSymbolTableObject::visitChildren): * runtime/JSSymbolTableObject.h: * runtime/JSTypeInfo.h: (JSC::TypeInfo::overridesVisitChildren): Deleted. * runtime/JSWeakMap.h: * runtime/JSWithScope.cpp: (JSC::JSWithScope::visitChildren): * runtime/JSWithScope.h: * runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::visitChildren): * runtime/JSWrapperObject.h: * runtime/MapData.h: * runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::visitChildren): * runtime/NativeErrorConstructor.h: * runtime/PropertyMapHashTable.h: * runtime/PropertyTable.cpp: (JSC::PropertyTable::visitChildren): * runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::visitChildren): * runtime/RegExpConstructor.h: * runtime/RegExpMatchesArray.cpp: (JSC::RegExpMatchesArray::visitChildren): * runtime/RegExpMatchesArray.h: * runtime/RegExpObject.cpp: (JSC::RegExpObject::visitChildren): * runtime/RegExpObject.h: * runtime/SparseArrayValueMap.h: * runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::visitChildren): * runtime/StructureChain.cpp: (JSC::StructureChain::visitChildren): * runtime/StructureChain.h: * runtime/StructureRareData.cpp: (JSC::StructureRareData::visitChildren): * runtime/StructureRareData.h: * runtime/WeakMapData.h: Source/WebCore: Tweak the bindings code generator to stop spitting out the flag. Reviewed by Geoffrey Garen. * bindings/js/JSDOMBinding.h: * bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren): * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): (GenerateImplementation): Modified Paths trunk/Source/_javascript_Core/API/JSAPIWrapperObject.h trunk/Source/_javascript_Core/API/JSAPIWrapperObject.mm trunk/Source/_javascript_Core/API/JSCallbackObject.h
[webkit-changes] [171940] trunk/Source/WebInspectorUI
Title: [171940] trunk/Source/WebInspectorUI Revision 171940 Author jonowe...@apple.com Date 2014-08-01 12:06:55 -0700 (Fri, 01 Aug 2014) Log Message Web Inspector: Timeline header height doesn't match style updates. https://bugs.webkit.org/show_bug.cgi?id=135516 Reviewed by Timothy Hatcher. Update the timeline header height to match the updates to the navigation bars in other panels made in https://bugs.webkit.org/show_bug.cgi?id=135445. Also update the shadows on some of the search bars. * UserInterface/Views/FilterBar.css: (.filter-bar input[type=search]): (body.mac-platform.legacy .filter-bar input[type=search]): * UserInterface/Views/FindBanner.css: (.find-banner input[type=search]): (body.mac-platform.legacy .find-banner input[type=search]): * UserInterface/Views/LogContentView.css: (.search-bar.log-search-bar input[type=search]): (body.mac-platform.legacy .search-bar.log-search-bar input[type=search]): Remove inset shadows on search bars. * UserInterface/Views/TimelineSidebarPanel.css: (.sidebar .panel.navigation.timeline .status-bar): (body.mac-platform.legacy .sidebar .panel.navigation.timeline .status-bar): (.sidebar .panel.navigation.timeline .status-bar .record-glyph): (body.mac-platform.legacy .sidebar .panel.navigation.timeline .status-bar .record-glyph): (.sidebar .panel.navigation.timeline .status-bar .record-status): (body.mac-platform.legacy .sidebar .panel.navigation.timeline .status-bar .record-status): (.sidebar .panel.navigation.timeline .title-bar.timelines): (body.mac-platform.legacy .sidebar .panel.navigation.timeline .title-bar.timelines): (.sidebar .panel.navigation.timeline .title-bar.timeline-events): (body.mac-platform.legacy .sidebar .panel.navigation.timeline .title-bar.timeline-events): (.sidebar .panel.navigation.timeline .timelines-content): (body.mac-platform.legacy .sidebar .panel.navigation.timeline .timelines-content): (.sidebar .panel.navigation.timeline .empty-content-placeholder): (body.mac-platform.legacy .sidebar .panel.navigation.timeline .empty-content-placeholder): Update the height of the timeline status bar. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.css trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.css trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (171939 => 171940) --- trunk/Source/WebInspectorUI/ChangeLog 2014-08-01 18:57:39 UTC (rev 171939) +++ trunk/Source/WebInspectorUI/ChangeLog 2014-08-01 19:06:55 UTC (rev 171940) @@ -1,3 +1,43 @@ +2014-08-01 Jonathan Wells jonowe...@apple.com + +Web Inspector: Timeline header height doesn't match style updates. +https://bugs.webkit.org/show_bug.cgi?id=135516 + +Reviewed by Timothy Hatcher. + +Update the timeline header height to match the updates +to the navigation bars in other panels made in +https://bugs.webkit.org/show_bug.cgi?id=135445. Also +update the shadows on some of the search bars. + +* UserInterface/Views/FilterBar.css: +(.filter-bar input[type=search]): +(body.mac-platform.legacy .filter-bar input[type=search]): +* UserInterface/Views/FindBanner.css: +(.find-banner input[type=search]): +(body.mac-platform.legacy .find-banner input[type=search]): +* UserInterface/Views/LogContentView.css: +(.search-bar.log-search-bar input[type=search]): +(body.mac-platform.legacy .search-bar.log-search-bar input[type=search]): +Remove inset shadows on search bars. + +* UserInterface/Views/TimelineSidebarPanel.css: +(.sidebar .panel.navigation.timeline .status-bar): +(body.mac-platform.legacy .sidebar .panel.navigation.timeline .status-bar): +(.sidebar .panel.navigation.timeline .status-bar .record-glyph): +(body.mac-platform.legacy .sidebar .panel.navigation.timeline .status-bar .record-glyph): +(.sidebar .panel.navigation.timeline .status-bar .record-status): +(body.mac-platform.legacy .sidebar .panel.navigation.timeline .status-bar .record-status): +(.sidebar .panel.navigation.timeline .title-bar.timelines): +(body.mac-platform.legacy .sidebar .panel.navigation.timeline .title-bar.timelines): +(.sidebar .panel.navigation.timeline .title-bar.timeline-events): +(body.mac-platform.legacy .sidebar .panel.navigation.timeline .title-bar.timeline-events): +(.sidebar .panel.navigation.timeline .timelines-content): +(body.mac-platform.legacy .sidebar .panel.navigation.timeline .timelines-content): +(.sidebar .panel.navigation.timeline .empty-content-placeholder): +(body.mac-platform.legacy .sidebar .panel.navigation.timeline .empty-content-placeholder):
[webkit-changes] [171941] trunk
Title: [171941] trunk Revision 171941 Author mmaxfi...@apple.com Date 2014-08-01 12:08:59 -0700 (Fri, 01 Aug 2014) Log Message URLs in srcset attributes are not made absolute upon copy and paste https://bugs.webkit.org/show_bug.cgi?id=135448 Reviewed by Ryosuke Niwa. Source/WebCore: When pasting, canonicalize URLs in srcset the same way we do with src. Test: editing/pasteboard/img-srcset-copy-paste-canonicalization.html * dom/Element.cpp: (WebCore::Element::completeURLsInAttributeValue): Initial implemention, moved from markup.cpp. * dom/Element.h: (WebCore::Element::attributeContainsURL): New function for completeURLs to call. (WebCore::Element::completeURLsInAttributeValue): Only called if attributeContainsURL returns true. Default implementation simply calls isURLAttribute(). * editing/markup.cpp: (WebCore::completeURLs): Call attributeContainsURL() and completeURLsInAttributeValue() to complete the URL, so nodes can perform their own behavior. * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::attributeContainsURL): Return true for srcset. (WebCore::HTMLImageElement::completeUrlAttributeValue): Use our existing srcset parser to parse the srcset attribute, then use its output to canonicalize URLs, and build it back up into a string. * html/HTMLImageElement.h: (WebCore::HTMLImageElement::attributeContainsURL): (WebCore::HTMLImageElement::completeUrlAttributeValue): * html/parser/HTMLSrcsetParser.cpp: Make parseImageCandidatesFromSrcsetAttribute() public and change its signature to return its result. (WebCore::parseImageCandidatesFromSrcsetAttribute): * html/parser/HTMLSrcsetParser.h: Ditto. LayoutTests: Copy and paste a srcset image with relative URLs, and make sure that the pasted srcset attribute doesn't match what it was before. I can't actually dump the new srcset because it will include a full path of the file on the user's system, and would therefore be machine-specific. * editing/pasteboard/img-srcset-copy-paste-canonicalization-expected.txt: * editing/pasteboard/img-srcset-copy-paste-canonicalization.html: Paste and check. * editing/pasteboard/resources/img-srcset-copy-paste-canonicalization-iframe.html: This has to be an iframe because we don't perform any url canonicalization if we are copying and pasting from a document into itself. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/editing/markup.cpp trunk/Source/WebCore/html/HTMLImageElement.cpp trunk/Source/WebCore/html/HTMLImageElement.h trunk/Source/WebCore/html/parser/HTMLSrcsetParser.cpp trunk/Source/WebCore/html/parser/HTMLSrcsetParser.h Added Paths trunk/LayoutTests/editing/pasteboard/img-srcset-copy-paste-canonicalization-expected.txt trunk/LayoutTests/editing/pasteboard/img-srcset-copy-paste-canonicalization.html trunk/LayoutTests/editing/pasteboard/resources/img-srcset-copy-paste-canonicalization-iframe.html Diff Modified: trunk/LayoutTests/ChangeLog (171940 => 171941) --- trunk/LayoutTests/ChangeLog 2014-08-01 19:06:55 UTC (rev 171940) +++ trunk/LayoutTests/ChangeLog 2014-08-01 19:08:59 UTC (rev 171941) @@ -1,3 +1,21 @@ +2014-07-30 Myles C. Maxfield mmaxfi...@apple.com + +URLs in srcset attributes are not made absolute upon copy and paste +https://bugs.webkit.org/show_bug.cgi?id=135448 + +Reviewed by Ryosuke Niwa. + +Copy and paste a srcset image with relative URLs, and make sure that the +pasted srcset attribute doesn't match what it was before. I can't actually +dump the new srcset because it will include a full path of the file on the +user's system, and would therefore be machine-specific. + +* editing/pasteboard/img-srcset-copy-paste-canonicalization-expected.txt: +* editing/pasteboard/img-srcset-copy-paste-canonicalization.html: Paste and check. +* editing/pasteboard/resources/img-srcset-copy-paste-canonicalization-iframe.html: +This has to be an iframe because we don't perform any url canonicalization if we +are copying and pasting from a document into itself. + 2014-08-01 Michał Pakuła vel Rutka m.pak...@samsung.com Unreviewed EFL gardening Added: trunk/LayoutTests/editing/pasteboard/img-srcset-copy-paste-canonicalization-expected.txt (0 => 171941) --- trunk/LayoutTests/editing/pasteboard/img-srcset-copy-paste-canonicalization-expected.txt (rev 0) +++ trunk/LayoutTests/editing/pasteboard/img-srcset-copy-paste-canonicalization-expected.txt 2014-08-01 19:08:59 UTC (rev 171941) @@ -0,0 +1,18 @@ +The following test does a copy and a paste of an image with the srcset attribute. The test is successful if the value of the srcset attribute has been canonicalized. To run the test manually, copy the green square into the contentediable area above the iframe. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS
[webkit-changes] [171942] trunk
Title: [171942] trunk
Revision 171942
Author achristen...@apple.com
Date 2014-08-01 12:19:14 -0700 (Fri, 01 Aug 2014)
Log Message
Progress towards cmake on Windows.
https://bugs.webkit.org/show_bug.cgi?id=135484
Reviewed by Martin Robinson.
.:
* CMakeLists.txt:
Added Mac to list of ports, even though it is not done yet.
Changed minimum bison version to version installed on Macs.
* Source/cmake/OptionsAppleWin.cmake:
Added some definitions.
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
Set WTF_LIBRARY_TYPE to STATIC to not change WTF linking on EFL or GTK ports.
* Source/cmake/OptionsMac.cmake: Added blank for now.
* Source/cmake/OptionsWinCairo.cmake:
* Source/cmake/OptionsWindows.cmake:
Added some definitions.
Removed /WX (warnings treated as error while compiling).
Copied warnings to ignore from WebKitLibraries/win/tools/vsprops/common.props.
Source/_javascript_Core:
* CMakeLists.txt:
Generate code directly to inspector directory to avoid using the cp command
which is not available on Windows.
* PlatformWin.cmake: Added.
Source/WTF:
* wtf/CMakeLists.txt:
Added WTF_LIBRARY_TYPE because Windows needs WTF to be a shared library.
Modified Paths
trunk/CMakeLists.txt
trunk/ChangeLog
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/cmake/OptionsAppleWin.cmake
trunk/Source/cmake/OptionsEfl.cmake
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWinCairo.cmake
trunk/Source/cmake/OptionsWindows.cmake
Added Paths
trunk/Source/_javascript_Core/PlatformWin.cmake
trunk/Source/cmake/OptionsMac.cmake
Diff
Modified: trunk/CMakeLists.txt (171941 => 171942)
--- trunk/CMakeLists.txt 2014-08-01 19:08:59 UTC (rev 171941)
+++ trunk/CMakeLists.txt 2014-08-01 19:19:14 UTC (rev 171942)
@@ -41,7 +41,7 @@
# -
# Determine which port will be built
# -
-set(ALL_PORTS Efl WinCE GTK AppleWin WinCairo)
+set(ALL_PORTS Efl WinCE GTK AppleWin WinCairo Mac)
set(PORT NOPORT CACHE STRING choose which WebKit port to build (one of ${ALL_PORTS}))
list(FIND ALL_PORTS ${PORT} RET)
@@ -54,7 +54,7 @@
# -
# Find common packages (used by all ports)
# -
-find_package(BISON 2.4.1 REQUIRED)
+find_package(BISON 2.3 REQUIRED)
find_package(FLEX 2.5.34 REQUIRED)
# TODO Enforce version requirement for gperf
Modified: trunk/ChangeLog (171941 => 171942)
--- trunk/ChangeLog 2014-08-01 19:08:59 UTC (rev 171941)
+++ trunk/ChangeLog 2014-08-01 19:19:14 UTC (rev 171942)
@@ -1,3 +1,25 @@
+2014-08-01 Alex Christensen achristen...@webkit.org
+
+Progress towards cmake on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=135484
+
+Reviewed by Martin Robinson.
+
+* CMakeLists.txt:
+Added Mac to list of ports, even though it is not done yet.
+Changed minimum bison version to version installed on Macs.
+* Source/cmake/OptionsAppleWin.cmake:
+Added some definitions.
+* Source/cmake/OptionsEfl.cmake:
+* Source/cmake/OptionsGTK.cmake:
+Set WTF_LIBRARY_TYPE to STATIC to not change WTF linking on EFL or GTK ports.
+* Source/cmake/OptionsMac.cmake: Added blank for now.
+* Source/cmake/OptionsWinCairo.cmake:
+* Source/cmake/OptionsWindows.cmake:
+Added some definitions.
+Removed /WX (warnings treated as error while compiling).
+Copied warnings to ignore from WebKitLibraries/win/tools/vsprops/common.props.
+
2014-08-01 Carlos Garcia Campos cgar...@igalia.com
[CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (171941 => 171942)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2014-08-01 19:08:59 UTC (rev 171941)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2014-08-01 19:19:14 UTC (rev 171942)
@@ -27,6 +27,7 @@
${_javascript_CORE_DIR}/yarr
${WTF_DIR}
${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}
+${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector
${CMAKE_SOURCE_DIR}/Source
${ICU_INCLUDE_DIRS}
)
@@ -872,18 +873,19 @@
# Inspector Backend Dispatchers, Frontend Dispatchers, Type Builders
add_custom_command(
-OUTPUT ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSBackendDispatchers.cpp
- ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSBackendDispatchers.h
- ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSFrontendDispatchers.cpp
- ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSFrontendDispatchers.h
- ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSTypeBuilders.cpp
-
[webkit-changes] [171943] trunk/Source/WebKit2
Title: [171943] trunk/Source/WebKit2 Revision 171943 Author oli...@apple.com Date 2014-08-01 12:19:22 -0700 (Fri, 01 Aug 2014) Log Message Various frameworks may want to use the container temp directory, so our current restrictions are too tight https://bugs.webkit.org/show_bug.cgi?id=135518 rdar://17869279 Reviewed by Anders Carlsson. We don't (and can't) have complete knowledge of what different frameworks will want to use the container temporary directory for, and so our current attempt to heavily restrict access is simply too tight. This patch recognises this by simply giving read-write access to the entire NSTemporary() directory (e.g. $container/tmp in the general case), rather than the single sub directory we wishfully thought that we would be able to get away with. * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * UIProcess/WebContext.cpp: (WebKit::WebContext::createNewWebProcess): (WebKit::WebContext::mediaCacheDirectory): Deleted. * UIProcess/WebContext.h: * UIProcess/efl/WebContextEfl.cpp: (WebKit::WebContext::containerTemporaryDirectory): (WebKit::WebContext::platformMediaCacheDirectory): Deleted. * UIProcess/gtk/WebContextGtk.cpp: (WebKit::WebContext::containerTemporaryDirectory): (WebKit::WebContext::platformMediaCacheDirectory): Deleted. * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::containerTemporaryDirectory): (WebKit::WebContext::platformMediaCacheDirectory): Deleted. * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h trunk/Source/WebKit2/UIProcess/WebContext.cpp trunk/Source/WebKit2/UIProcess/WebContext.h trunk/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (171942 => 171943) --- trunk/Source/WebKit2/ChangeLog 2014-08-01 19:19:14 UTC (rev 171942) +++ trunk/Source/WebKit2/ChangeLog 2014-08-01 19:19:22 UTC (rev 171943) @@ -1,3 +1,40 @@ +2014-08-01 Oliver Hunt oli...@apple.com + +Various frameworks may want to use the container temp directory, so our current restrictions are too tight +https://bugs.webkit.org/show_bug.cgi?id=135518 +rdar://17869279 + +Reviewed by Anders Carlsson. + +We don't (and can't) have complete knowledge of what different frameworks +will want to use the container temporary directory for, and so our +current attempt to heavily restrict access is simply too tight. + +This patch recognises this by simply giving read-write access to the +entire NSTemporary() directory (e.g. $container/tmp in the general case), +rather than the single sub directory we wishfully thought that we would +be able to get away with. + +* Shared/WebProcessCreationParameters.cpp: +(WebKit::WebProcessCreationParameters::encode): +(WebKit::WebProcessCreationParameters::decode): +* Shared/WebProcessCreationParameters.h: +* UIProcess/WebContext.cpp: +(WebKit::WebContext::createNewWebProcess): +(WebKit::WebContext::mediaCacheDirectory): Deleted. +* UIProcess/WebContext.h: +* UIProcess/efl/WebContextEfl.cpp: +(WebKit::WebContext::containerTemporaryDirectory): +(WebKit::WebContext::platformMediaCacheDirectory): Deleted. +* UIProcess/gtk/WebContextGtk.cpp: +(WebKit::WebContext::containerTemporaryDirectory): +(WebKit::WebContext::platformMediaCacheDirectory): Deleted. +* UIProcess/mac/WebContextMac.mm: +(WebKit::WebContext::containerTemporaryDirectory): +(WebKit::WebContext::platformMediaCacheDirectory): Deleted. +* WebProcess/cocoa/WebProcessCocoa.mm: +(WebKit::WebProcess::platformInitializeWebProcess): + 2014-08-01 Dan Bernstein m...@apple.com rdar://problem/17862013 REGRESSION (r169357): Disabling allow plug-ins doesn't stick on quit/relaunch Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (171942 => 171943) --- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2014-08-01 19:19:14 UTC (rev 171942) +++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2014-08-01 19:19:22 UTC (rev 171943) @@ -69,8 +69,8 @@ encoder cookieStorageDirectoryExtensionHandle; encoder openGLCacheDirectory; encoder openGLCacheDirectoryExtensionHandle; -encoder mediaCacheDirectory; -encoder mediaCacheDirectoryExtensionHandle; +encoder containerTemporaryDirectory; +encoder containerTemporaryDirectoryExtensionHandle; encoder
[webkit-changes] [171944] trunk/Source/WebCore
Title: [171944] trunk/Source/WebCore
Revision 171944
Author d...@apple.com
Date 2014-08-01 12:42:06 -0700 (Fri, 01 Aug 2014)
Log Message
[Media iOS] Ensure there is a nice default fallback for missing wireless target names
https://bugs.webkit.org/show_bug.cgi?id=135488
rdar://problem/17879156
Reviewed by Eric Carlson.
We occasionally run into cases where this.host.externalDeviceDisplayName
is empty or null, creating a pretty ugly/confusing string in the
wireless playback status screen.
If this happens, we should default to using Apple TV.
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.updateWirelessPlaybackStatus): Check if the externalDeviceDisplayName
is empty or null, and fall back to Apple TV if so.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (171943 => 171944)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 19:19:22 UTC (rev 171943)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 19:42:06 UTC (rev 171944)
@@ -1,3 +1,21 @@
+2014-07-31 Dean Jackson d...@apple.com
+
+[Media iOS] Ensure there is a nice default fallback for missing wireless target names
+https://bugs.webkit.org/show_bug.cgi?id=135488
+rdar://problem/17879156
+
+Reviewed by Eric Carlson.
+
+We occasionally run into cases where this.host.externalDeviceDisplayName
+is empty or null, creating a pretty ugly/confusing string in the
+wireless playback status screen.
+
+If this happens, we should default to using Apple TV.
+
+* Modules/mediacontrols/mediaControlsiOS.js:
+(ControllerIOS.prototype.updateWirelessPlaybackStatus): Check if the externalDeviceDisplayName
+is empty or null, and fall back to Apple TV if so.
+
2014-07-30 Myles C. Maxfield mmaxfi...@apple.com
URLs in srcset attributes are not made absolute upon copy and paste
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js (171943 => 171944)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js 2014-08-01 19:19:22 UTC (rev 171943)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js 2014-08-01 19:42:06 UTC (rev 171944)
@@ -110,13 +110,16 @@
var deviceType = ;
var type = this.host.externalDeviceType;
if (type == airplay) {
+var externalDeviceDisplayName = this.host.externalDeviceDisplayName;
+if (!externalDeviceDisplayName || externalDeviceDisplayName == )
+externalDeviceDisplayName = Apple TV;
deviceType = this.UIString('##WIRELESS_PLAYBACK_DEVICE_TYPE##');
-deviceName = this.UIString('##WIRELESS_PLAYBACK_DEVICE_NAME##', '##DEVICE_NAME##', this.host.externalDeviceDisplayName);
+deviceName = this.UIString('##WIRELESS_PLAYBACK_DEVICE_NAME##', '##DEVICE_NAME##', externalDeviceDisplayName);
} else if (type == tvout) {
deviceType = this.UIString('##TVOUT_DEVICE_TYPE##');
deviceName = this.UIString('##TVOUT_DEVICE_NAME##');
}
-
+
backgroundImageSVG = backgroundImageSVG.replace('##DEVICE_TYPE##', deviceType);
backgroundImageSVG = backgroundImageSVG.replace('##DEVICE_NAME##', deviceName);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171945] trunk/Tools
Title: [171945] trunk/Tools
Revision 171945
Author timothy_hor...@apple.com
Date 2014-08-01 13:01:15 -0700 (Fri, 01 Aug 2014)
Log Message
Build fix for 32-bit after r171926.
* MiniBrowser/mac/SettingsController.h:
* MiniBrowser/mac/SettingsController.m:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/SettingsController.h
trunk/Tools/MiniBrowser/mac/SettingsController.m
Diff
Modified: trunk/Tools/ChangeLog (171944 => 171945)
--- trunk/Tools/ChangeLog 2014-08-01 19:42:06 UTC (rev 171944)
+++ trunk/Tools/ChangeLog 2014-08-01 20:01:15 UTC (rev 171945)
@@ -1,3 +1,10 @@
+2014-08-01 Timothy Horton timothy_hor...@apple.com
+
+Build fix for 32-bit after r171926.
+
+* MiniBrowser/mac/SettingsController.h:
+* MiniBrowser/mac/SettingsController.m:
+
2014-08-01 Tim Horton timothy_hor...@apple.com
Confusing build fix after r171926.
Modified: trunk/Tools/MiniBrowser/mac/SettingsController.h (171944 => 171945)
--- trunk/Tools/MiniBrowser/mac/SettingsController.h 2014-08-01 19:42:06 UTC (rev 171944)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.h 2014-08-01 20:01:15 UTC (rev 171945)
@@ -25,7 +25,9 @@
#import Cocoa/Cocoa.h
-@interface SettingsController : NSObject
+@interface SettingsController : NSObject {
+NSMenu *_menu;
+}
+ (instancetype)shared;
Modified: trunk/Tools/MiniBrowser/mac/SettingsController.m (171944 => 171945)
--- trunk/Tools/MiniBrowser/mac/SettingsController.m 2014-08-01 19:42:06 UTC (rev 171944)
+++ trunk/Tools/MiniBrowser/mac/SettingsController.m 2014-08-01 20:01:15 UTC (rev 171945)
@@ -42,9 +42,7 @@
// This default name intentionally overlaps with the key that WebKit2 checks when creating a view.
static NSString * const UseRemoteLayerTreeDrawingAreaPreferenceKey = @WebKit2UseRemoteLayerTreeDrawingArea;
-@implementation SettingsController {
-NSMenu *_menu;
-}
+@implementation SettingsController
@synthesize menu=_menu;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171946] trunk/Source/JavaScriptCore
Title: [171946] trunk/Source/_javascript_Core
Revision 171946
Author gga...@apple.com
Date 2014-08-01 13:17:25 -0700 (Fri, 01 Aug 2014)
Log Message
CodeBlock fails to visit the Executables of its InlineCallFrames
https://bugs.webkit.org/show_bug.cgi?id=135471
Patch by Mark Hahnenberg mhahnenb...@apple.com on 2014-08-01
Reviewed by Geoffrey Garen.
CodeBlock needs to visit its InlineCallFrames' owner Executables. If it doesn't, they
can be prematurely collected and cause crashes.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
* bytecode/CodeOrigin.h:
(JSC::InlineCallFrame::visitAggregate):
* bytecode/InlineCallFrameSet.cpp:
(JSC::InlineCallFrameSet::visitAggregate):
* bytecode/InlineCallFrameSet.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeOrigin.h
trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.cpp
trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (171945 => 171946)
--- trunk/Source/_javascript_Core/ChangeLog 2014-08-01 20:01:15 UTC (rev 171945)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-08-01 20:17:25 UTC (rev 171946)
@@ -1,3 +1,21 @@
+2014-08-01 Mark Hahnenberg mhahnenb...@apple.com
+
+CodeBlock fails to visit the Executables of its InlineCallFrames
+https://bugs.webkit.org/show_bug.cgi?id=135471
+
+Reviewed by Geoffrey Garen.
+
+CodeBlock needs to visit its InlineCallFrames' owner Executables. If it doesn't, they
+can be prematurely collected and cause crashes.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::stronglyVisitStrongReferences):
+* bytecode/CodeOrigin.h:
+(JSC::InlineCallFrame::visitAggregate):
+* bytecode/InlineCallFrameSet.cpp:
+(JSC::InlineCallFrameSet::visitAggregate):
+* bytecode/InlineCallFrameSet.h:
+
2014-08-01 Alex Christensen achristen...@webkit.org
Progress towards cmake on Windows.
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (171945 => 171946)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-08-01 20:01:15 UTC (rev 171945)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-08-01 20:17:25 UTC (rev 171946)
@@ -2595,6 +2595,14 @@
for (unsigned i = 0; i m_objectAllocationProfiles.size(); ++i)
m_objectAllocationProfiles[i].visitAggregate(visitor);
+#if ENABLE(DFG_JIT)
+if (JITCode::isOptimizingJIT(jitType())) {
+DFG::CommonData* dfgCommon = m_jitCode-dfgCommon();
+if (dfgCommon-inlineCallFrames.get())
+dfgCommon-inlineCallFrames-visitAggregate(visitor);
+}
+#endif
+
updateAllPredictions();
}
Modified: trunk/Source/_javascript_Core/bytecode/CodeOrigin.h (171945 => 171946)
--- trunk/Source/_javascript_Core/bytecode/CodeOrigin.h 2014-08-01 20:01:15 UTC (rev 171945)
+++ trunk/Source/_javascript_Core/bytecode/CodeOrigin.h 2014-08-01 20:17:25 UTC (rev 171946)
@@ -182,6 +182,11 @@
return jsCastJSFunction*(calleeRecovery.constant());
return 0;
}
+
+void visitAggregate(SlotVisitor visitor)
+{
+visitor.append(executable);
+}
// Get the callee given a machine call frame to which this InlineCallFrame belongs.
JSFunction* calleeForCallFrame(ExecState*) const;
Modified: trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.cpp (171945 => 171946)
--- trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.cpp 2014-08-01 20:01:15 UTC (rev 171945)
+++ trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.cpp 2014-08-01 20:17:25 UTC (rev 171946)
@@ -36,5 +36,11 @@
return m_frames.add();
}
+void InlineCallFrameSet::visitAggregate(SlotVisitor visitor)
+{
+for (InlineCallFrame* callFrame : m_frames)
+callFrame-visitAggregate(visitor);
+}
+
} // namespace JSC
Modified: trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.h (171945 => 171946)
--- trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.h 2014-08-01 20:01:15 UTC (rev 171945)
+++ trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.h 2014-08-01 20:17:25 UTC (rev 171946)
@@ -44,6 +44,8 @@
typedef BagInlineCallFrame::iterator iterator;
iterator begin() { return m_frames.begin(); }
iterator end() { return m_frames.end(); }
+
+void visitAggregate(SlotVisitor);
private:
BagInlineCallFrame m_frames;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171947] trunk
Title: [171947] trunk Revision 171947 Author betra...@adobe.com Date 2014-08-01 13:43:56 -0700 (Fri, 01 Aug 2014) Log Message [Feature Queries] Enable Feature Queries on EFL/GTK https://bugs.webkit.org/show_bug.cgi?id=134902 Reviewed by Benjamin Poulain. .: Enable CSS Feature Queries by default on the EFL and GTK platforms. * Source/cmake/OptionsEfl.cmake: * Source/cmake/OptionsGTK.cmake: Tools: Turn the feature on by default for the build script. * Scripts/webkitperl/FeatureList.pm: LayoutTests: Resume running the CSS Feature Query tests on the EFL and GTK platforms. * platform/efl/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/cmake/OptionsEfl.cmake trunk/Source/cmake/OptionsGTK.cmake trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitperl/FeatureList.pm Diff Modified: trunk/ChangeLog (171946 => 171947) --- trunk/ChangeLog 2014-08-01 20:17:25 UTC (rev 171946) +++ trunk/ChangeLog 2014-08-01 20:43:56 UTC (rev 171947) @@ -1,3 +1,16 @@ +2014-08-01 Bear Travis betra...@adobe.com + +[Feature Queries] Enable Feature Queries on EFL/GTK +https://bugs.webkit.org/show_bug.cgi?id=134902 + +Reviewed by Benjamin Poulain. + +Enable CSS Feature Queries by default on the EFL and GTK +platforms. + +* Source/cmake/OptionsEfl.cmake: +* Source/cmake/OptionsGTK.cmake: + 2014-08-01 Alex Christensen achristen...@webkit.org Progress towards cmake on Windows. Modified: trunk/LayoutTests/ChangeLog (171946 => 171947) --- trunk/LayoutTests/ChangeLog 2014-08-01 20:17:25 UTC (rev 171946) +++ trunk/LayoutTests/ChangeLog 2014-08-01 20:43:56 UTC (rev 171947) @@ -1,3 +1,15 @@ +2014-08-01 Bear Travis betra...@adobe.com + +[Feature Queries] Enable Feature Queries on EFL/GTK +https://bugs.webkit.org/show_bug.cgi?id=134902 + +Reviewed by Benjamin Poulain. + +Resume running the CSS Feature Query tests on the EFL and GTK platforms. + +* platform/efl/TestExpectations: +* platform/gtk/TestExpectations: + 2014-07-30 Myles C. Maxfield mmaxfi...@apple.com URLs in srcset attributes are not made absolute upon copy and paste Modified: trunk/LayoutTests/platform/efl/TestExpectations (171946 => 171947) --- trunk/LayoutTests/platform/efl/TestExpectations 2014-08-01 20:17:25 UTC (rev 171946) +++ trunk/LayoutTests/platform/efl/TestExpectations 2014-08-01 20:43:56 UTC (rev 171947) @@ -1287,11 +1287,6 @@ webkit.org/b/99878 css3/flexbox/flexbox-baseline-margins.html [ Missing ImageOnlyFailure ] -# css3-conditionals support is not yet enabled. -webkit.org/b/86146 css3/supports.html -webkit.org/b/104822 css3/supports-cssom.html -webkit.org/b/100324 css3/supports-dom-api.html - # Occasionally fails if run after right after # fast/selectors/unqualified-hover-quirks.html or itself. webkit.org/b/10890 fast/selectors/unqualified-hover-strict.html [ Failure Pass ] Modified: trunk/LayoutTests/platform/gtk/TestExpectations (171946 => 171947) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-08-01 20:17:25 UTC (rev 171946) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-08-01 20:43:56 UTC (rev 171947) @@ -321,11 +321,6 @@ # HIDDEN_PAGE_DOM_TIMER_THROTTLING is not enabled webkit.org/b/99059 fast/dom/timer-throttling-hidden-page.html [ Failure ] -# css3-conditionals support is not yet enabled. -webkit.org/b/86146 css3/supports.html -webkit.org/b/104822 css3/supports-cssom.html -webkit.org/b/100324 css3/supports-dom-api.html - # Requires Resolution Media Query support webkit.org/b/100137 fast/media/mq-resolution.html [ Failure ] webkit.org/b/100137 fast/media/mq-resolution-dpi-dpcm-warning.html [ Failure ] Modified: trunk/Source/cmake/OptionsEfl.cmake (171946 => 171947) --- trunk/Source/cmake/OptionsEfl.cmake 2014-08-01 20:17:25 UTC (rev 171946) +++ trunk/Source/cmake/OptionsEfl.cmake 2014-08-01 20:43:56 UTC (rev 171947) @@ -55,6 +55,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS ON) +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_CONDITIONAL_RULES ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_DEVICE_ADAPTATION ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_FILTERS ON) Modified: trunk/Source/cmake/OptionsGTK.cmake (171946 => 171947) --- trunk/Source/cmake/OptionsGTK.cmake 2014-08-01 20:17:25 UTC (rev 171946) +++ trunk/Source/cmake/OptionsGTK.cmake 2014-08-01 20:43:56 UTC (rev 171947) @@ -99,6 +99,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH OFF)
[webkit-changes] [171948] trunk/LayoutTests
Title: [171948] trunk/LayoutTests Revision 171948 Author bda...@apple.com Date 2014-08-01 13:46:28 -0700 (Fri, 01 Aug 2014) Log Message REGRESSION (r171891): platform/mac/fast/scrolling/scroll-select-bottom-test.html failing https://bugs.webkit.org/show_bug.cgi?id=135485 Now that WK1 really tests contentInset, this test no longer works on platforms that do not support the real contentInset * platform/mac-wk1/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (171947 => 171948) --- trunk/LayoutTests/ChangeLog 2014-08-01 20:43:56 UTC (rev 171947) +++ trunk/LayoutTests/ChangeLog 2014-08-01 20:46:28 UTC (rev 171948) @@ -1,3 +1,14 @@ +2014-08-01 Beth Dakin bda...@apple.com + +REGRESSION (r171891): platform/mac/fast/scrolling/scroll-select-bottom-test.html +failing +https://bugs.webkit.org/show_bug.cgi?id=135485 + +Now that WK1 really tests contentInset, this test no longer works on platforms +that do not support the real contentInset +* platform/mac-wk1/TestExpectations: +* platform/mac/TestExpectations: + 2014-08-01 Bear Travis betra...@adobe.com [Feature Queries] Enable Feature Queries on EFL/GTK Modified: trunk/LayoutTests/platform/mac/TestExpectations (171947 => 171948) --- trunk/LayoutTests/platform/mac/TestExpectations 2014-08-01 20:43:56 UTC (rev 171947) +++ trunk/LayoutTests/platform/mac/TestExpectations 2014-08-01 20:46:28 UTC (rev 171948) @@ -1409,5 +1409,3 @@ webkit.org/b/135160 media/track/track-in-band-subtitles-too-large.html [ Pass Failure ] webkit.org/b/135160 media/track/track-long-word-container-sizing.html [ Pass Failure ] - -webkit.org/b/135485 platform/mac/fast/scrolling/scroll-select-bottom-test.html [ Skip ] Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (171947 => 171948) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2014-08-01 20:43:56 UTC (rev 171947) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2014-08-01 20:46:28 UTC (rev 171948) @@ -50,6 +50,7 @@ # Mavericks and prior do not support contentInset [ MountainLion Mavericks ] platform/mac/fast/events/content-inset-hit-testing.html [ Skip ] [ MountainLion Mavericks ] platform/mac/fast/events/content-inset-hit-testing-in-frame.html [ Skip ] +[ MountainLion Mavericks ] platform/mac/fast/scrolling/scroll-select-bottom-test.html [ Skip ] ### END OF (2) Failures without bug reports ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171949] trunk/Source/JavaScriptCore
Title: [171949] trunk/Source/_javascript_Core
Revision 171949
Author o...@webkit.org
Date 2014-08-01 13:58:19 -0700 (Fri, 01 Aug 2014)
Log Message
URTBF after r171946 to fix non-Apple builds.
* bytecode/InlineCallFrameSet.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (171948 => 171949)
--- trunk/Source/_javascript_Core/ChangeLog 2014-08-01 20:46:28 UTC (rev 171948)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-08-01 20:58:19 UTC (rev 171949)
@@ -1,3 +1,9 @@
+2014-08-01 Csaba Osztrogonác o...@webkit.org
+
+URTBF after r171946 to fix non-Apple builds.
+
+* bytecode/InlineCallFrameSet.cpp:
+
2014-08-01 Mark Hahnenberg mhahnenb...@apple.com
CodeBlock fails to visit the Executables of its InlineCallFrames
Modified: trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.cpp (171948 => 171949)
--- trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.cpp 2014-08-01 20:46:28 UTC (rev 171948)
+++ trunk/Source/_javascript_Core/bytecode/InlineCallFrameSet.cpp 2014-08-01 20:58:19 UTC (rev 171949)
@@ -25,6 +25,7 @@
#include config.h
#include InlineCallFrameSet.h
+#include JSCInlines.h
namespace JSC {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171950] trunk/Source/WebCore
Title: [171950] trunk/Source/WebCore
Revision 171950
Author mmaxfi...@apple.com
Date 2014-08-01 15:33:50 -0700 (Fri, 01 Aug 2014)
Log Message
SVGGlyph wastes space due to padding
https://bugs.webkit.org/show_bug.cgi?id=135520
Reviewed by Dean Jackson.
Rearrange members in SVGGlyph so there is no wasted padding space.
No new tests because there is no behavior change.
* platform/graphics/SVGGlyph.h:
(WebCore::SVGGlyph::SVGGlyph):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/SVGGlyph.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (171949 => 171950)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 20:58:19 UTC (rev 171949)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 22:33:50 UTC (rev 171950)
@@ -1,3 +1,17 @@
+2014-08-01 Myles C. Maxfield mmaxfi...@apple.com
+
+SVGGlyph wastes space due to padding
+https://bugs.webkit.org/show_bug.cgi?id=135520
+
+Reviewed by Dean Jackson.
+
+Rearrange members in SVGGlyph so there is no wasted padding space.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/SVGGlyph.h:
+(WebCore::SVGGlyph::SVGGlyph):
+
2014-07-31 Dean Jackson d...@apple.com
[Media iOS] Ensure there is a nice default fallback for missing wireless target names
Modified: trunk/Source/WebCore/platform/graphics/SVGGlyph.h (171949 => 171950)
--- trunk/Source/WebCore/platform/graphics/SVGGlyph.h 2014-08-01 20:58:19 UTC (rev 171949)
+++ trunk/Source/WebCore/platform/graphics/SVGGlyph.h 2014-08-01 22:33:50 UTC (rev 171950)
@@ -51,16 +51,16 @@
};
SVGGlyph()
-: isPartOfLigature(false)
-, orientation(Both)
-, arabicForm(None)
+: unicodeStringLength(0)
, priority(0)
-, tableEntry(0)
-, unicodeStringLength(0)
, horizontalAdvanceX(0)
, verticalOriginX(0)
, verticalOriginY(0)
, verticalAdvanceY(0)
+, tableEntry(0)
+, isPartOfLigature(false)
+, orientation(Both)
+, arabicForm(None)
{
}
@@ -86,22 +86,25 @@
languages == other.languages;
}
-bool isPartOfLigature : 1;
+VectorString languages;
-unsigned orientation : 2; // Orientation
-unsigned arabicForm : 3; // ArabicForm
-int priority;
-Glyph tableEntry;
size_t unicodeStringLength;
String glyphName;
+Path pathData;
+int priority;
+
float horizontalAdvanceX;
float verticalOriginX;
float verticalOriginY;
float verticalAdvanceY;
-Path pathData;
-VectorString languages;
+Glyph tableEntry;
+
+unsigned isPartOfLigature : 1;
+
+unsigned orientation : 2; // Orientation
+unsigned arabicForm : 3; // ArabicForm
};
VectorSVGGlyph::ArabicForm charactersWithArabicForm(const String input, bool rtl);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171951] trunk/Source/WebCore
Title: [171951] trunk/Source/WebCore Revision 171951 Author bda...@apple.com Date 2014-08-01 15:39:52 -0700 (Fri, 01 Aug 2014) Log Message Inspector highlights clipped at the bottom on the page in WK1 views with contentInsets https://bugs.webkit.org/show_bug.cgi?id=135480 -and corresponding- rdar://problem/17850323 Reviewed by Simon Fraser. unscaledTotalVisibleContentSize() was the main function on Mac that was expected to return the rect representing ALL visible content, including content that might be in an inset area and obscured by UI elements. This patch re-names that function to unscaledVisibleContentSizeIncludingObscuredArea(), and that patch makes that function return the right thing in the platformWidget() case. Re-name. * inspector/InspectorOverlay.cpp: (WebCore::InspectorOverlay::update): Return platformVisibleContentSizeIncludingObscuredArea() for the platformWidget() case and re-name. * platform/ScrollView.cpp: (WebCore::ScrollView::unscaledVisibleContentSizeIncludingObscuredArea): This was just wrong. It was returning the big rectangle instead of the small one for platformWidget(). (WebCore::ScrollView::unscaledUnobscuredVisibleContentSize): New platform functions. (WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea): (WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea): (WebCore::ScrollView::unscaledTotalVisibleContentSize): Deleted. * platform/ScrollView.h: * platform/ios/ScrollViewIOS.mm: (WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea): (WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea): * platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformVisibleContentRect): (WebCore::ScrollView::platformVisibleContentSize): (WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea): (WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea): Re-name. * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::flushPendingLayerChanges): (WebCore::RenderLayerCompositor::frameViewDidChangeSize): (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::RenderLayerCompositor::ensureRootLayer): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorOverlay.cpp trunk/Source/WebCore/platform/ScrollView.cpp trunk/Source/WebCore/platform/ScrollView.h trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm trunk/Source/WebCore/platform/mac/ScrollViewMac.mm trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (171950 => 171951) --- trunk/Source/WebCore/ChangeLog 2014-08-01 22:33:50 UTC (rev 171950) +++ trunk/Source/WebCore/ChangeLog 2014-08-01 22:39:52 UTC (rev 171951) @@ -1,3 +1,53 @@ +2014-08-01 Beth Dakin bda...@apple.com + +Inspector highlights clipped at the bottom on the page in WK1 views with +contentInsets +https://bugs.webkit.org/show_bug.cgi?id=135480 +-and corresponding- +rdar://problem/17850323 + +Reviewed by Simon Fraser. + +unscaledTotalVisibleContentSize() was the main function on Mac that was expected +to return the rect representing ALL visible content, including content that might +be in an inset area and obscured by UI elements. This patch re-names that function +to unscaledVisibleContentSizeIncludingObscuredArea(), and that patch makes that +function return the right thing in the platformWidget() case. + +Re-name. +* inspector/InspectorOverlay.cpp: +(WebCore::InspectorOverlay::update): + +Return platformVisibleContentSizeIncludingObscuredArea() for the platformWidget() +case and re-name. +* platform/ScrollView.cpp: +(WebCore::ScrollView::unscaledVisibleContentSizeIncludingObscuredArea): + +This was just wrong. It was returning the big rectangle instead of the small one +for platformWidget(). +(WebCore::ScrollView::unscaledUnobscuredVisibleContentSize): + +New platform functions. +(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea): +(WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea): +(WebCore::ScrollView::unscaledTotalVisibleContentSize): Deleted. +* platform/ScrollView.h: +* platform/ios/ScrollViewIOS.mm: +(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea): +(WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea): +* platform/mac/ScrollViewMac.mm: +(WebCore::ScrollView::platformVisibleContentRect): +(WebCore::ScrollView::platformVisibleContentSize): +(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea): +(WebCore::ScrollView::platformVisibleContentSizeIncludingObscuredArea): + +Re-name. +* rendering/RenderLayerCompositor.cpp: +
[webkit-changes] [171952] trunk/Source/WebCore
Title: [171952] trunk/Source/WebCore
Revision 171952
Author bda...@apple.com
Date 2014-08-01 15:47:57 -0700 (Fri, 01 Aug 2014)
Log Message
Inspector highlights clipped at the bottom on the page in WK1 views with
contentInsets
https://bugs.webkit.org/show_bug.cgi?id=135480
-and corresponding-
rdar://problem/17850323
Forgot to commit this one very critical part with
http://trac.webkit.org/changeset/171951
* platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSizeIncludingObscuredArea):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (171951 => 171952)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 22:39:52 UTC (rev 171951)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 22:47:57 UTC (rev 171952)
@@ -6,6 +6,20 @@
-and corresponding-
rdar://problem/17850323
+Forgot to commit this one very critical part with
+http://trac.webkit.org/changeset/171951
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::unscaledVisibleContentSizeIncludingObscuredArea):
+
+2014-08-01 Beth Dakin bda...@apple.com
+
+Inspector highlights clipped at the bottom on the page in WK1 views with
+contentInsets
+https://bugs.webkit.org/show_bug.cgi?id=135480
+-and corresponding-
+rdar://problem/17850323
+
Reviewed by Simon Fraser.
unscaledTotalVisibleContentSize() was the main function on Mac that was expected
Modified: trunk/Source/WebCore/platform/ScrollView.cpp (171951 => 171952)
--- trunk/Source/WebCore/platform/ScrollView.cpp 2014-08-01 22:39:52 UTC (rev 171951)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2014-08-01 22:47:57 UTC (rev 171952)
@@ -269,7 +269,7 @@
IntSize ScrollView::unscaledVisibleContentSizeIncludingObscuredArea(VisibleContentRectIncludesScrollbars scrollbarInclusion) const
{
if (platformWidget())
-return platformVisibleContentSize(scrollbarInclusion == IncludeScrollbars);
+return platformVisibleContentSizeIncludingObscuredArea(scrollbarInclusion == IncludeScrollbars);
#if USE(TILED_BACKING_STORE)
if (!m_fixedVisibleContentRect.isEmpty())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171953] trunk/Source/JavaScriptCore
Title: [171953] trunk/Source/_javascript_Core
Revision 171953
Author mark@apple.com
Date 2014-08-01 15:49:51 -0700 (Fri, 01 Aug 2014)
Log Message
Add some structure related assertions.
https://webkit.org/b/135523
Reviewed by Geoffrey Garen.
Adding 2 assertions:
1. assert that we don't index pass the end of the StructureIDTable.
This should never happen, but this assertion will help catch bugs
where a bad structureID gets passed in.
2. assert that cells in MarkedBlock::callDestructor() that are not
zapped should have a non-null StructureID. This will help us catch
bugs where the other cell header flag bits get set after the cell is
zapped, thereby making the cell look like an unzapped cell but has a
null structureID.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor):
* runtime/StructureIDTable.h:
(JSC::StructureIDTable::get):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MarkedBlock.cpp
trunk/Source/_javascript_Core/runtime/StructureIDTable.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (171952 => 171953)
--- trunk/Source/_javascript_Core/ChangeLog 2014-08-01 22:47:57 UTC (rev 171952)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-08-01 22:49:51 UTC (rev 171953)
@@ -1,3 +1,25 @@
+2014-08-01 Mark Lam mark@apple.com
+
+Add some structure related assertions.
+https://webkit.org/b/135523
+
+Reviewed by Geoffrey Garen.
+
+Adding 2 assertions:
+1. assert that we don't index pass the end of the StructureIDTable.
+ This should never happen, but this assertion will help catch bugs
+ where a bad structureID gets passed in.
+2. assert that cells in MarkedBlock::callDestructor() that are not
+ zapped should have a non-null StructureID. This will help us catch
+ bugs where the other cell header flag bits get set after the cell is
+ zapped, thereby making the cell look like an unzapped cell but has a
+ null structureID.
+
+* heap/MarkedBlock.cpp:
+(JSC::MarkedBlock::callDestructor):
+* runtime/StructureIDTable.h:
+(JSC::StructureIDTable::get):
+
2014-08-01 Csaba Osztrogonác o...@webkit.org
URTBF after r171946 to fix non-Apple builds.
Modified: trunk/Source/_javascript_Core/heap/MarkedBlock.cpp (171952 => 171953)
--- trunk/Source/_javascript_Core/heap/MarkedBlock.cpp 2014-08-01 22:47:57 UTC (rev 171952)
+++ trunk/Source/_javascript_Core/heap/MarkedBlock.cpp 2014-08-01 22:49:51 UTC (rev 171953)
@@ -61,6 +61,7 @@
if (cell-isZapped())
return;
+ASSERT(cell-structureID());
if (dtorType == MarkedBlock::Normal)
jsCastJSDestructibleObject*(cell)-classInfo()-methodTable.destroy(cell);
else
Modified: trunk/Source/_javascript_Core/runtime/StructureIDTable.h (171952 => 171953)
--- trunk/Source/_javascript_Core/runtime/StructureIDTable.h 2014-08-01 22:47:57 UTC (rev 171952)
+++ trunk/Source/_javascript_Core/runtime/StructureIDTable.h 2014-08-01 22:49:51 UTC (rev 171953)
@@ -83,6 +83,7 @@
inline Structure* StructureIDTable::get(StructureID structureID)
{
#if USE(JSVALUE64)
+ASSERT(structureID structureID m_capacity);
return table()[structureID].structure;
#else
return structureID;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171954] trunk/Tools
Title: [171954] trunk/Tools
Revision 171954
Author m...@apple.com
Date 2014-08-01 16:10:50 -0700 (Fri, 01 Aug 2014)
Log Message
commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
https://bugs.webkit.org/show_bug.cgi?id=135527
Reviewed by Tim Horton.
* Scripts/commit-log-editor:
In the case of a git repository when there are no changed ChangeLog files, changed to pass
the --delimiters option to prepare-ChangeLog, then process each entry in the output using
commitMessageFromChangeLogEntry.
(commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
(sortKey): Factored out from createCommitMessage.
(createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
subroutines.
* Scripts/prepare-ChangeLog:
(main): Parse new --delimiters option.
(generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
the label before each change log entry, and a ~ delimiter on a new line after each entry.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/commit-log-editor
trunk/Tools/Scripts/prepare-ChangeLog
Diff
Modified: trunk/Tools/ChangeLog (171953 => 171954)
--- trunk/Tools/ChangeLog 2014-08-01 22:49:51 UTC (rev 171953)
+++ trunk/Tools/ChangeLog 2014-08-01 23:10:50 UTC (rev 171954)
@@ -1,3 +1,24 @@
+2014-08-01 Dan Bernstein m...@apple.com
+
+commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
+https://bugs.webkit.org/show_bug.cgi?id=135527
+
+Reviewed by Tim Horton.
+
+* Scripts/commit-log-editor:
+In the case of a git repository when there are no changed ChangeLog files, changed to pass
+the --delimiters option to prepare-ChangeLog, then process each entry in the output using
+commitMessageFromChangeLogEntry.
+(commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
+(sortKey): Factored out from createCommitMessage.
+(createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
+subroutines.
+
+* Scripts/prepare-ChangeLog:
+(main): Parse new --delimiters option.
+(generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
+the label before each change log entry, and a ~ delimiter on a new line after each entry.
+
2014-08-01 Bear Travis betra...@adobe.com
[Feature Queries] Enable Feature Queries on EFL/GTK
Modified: trunk/Tools/Scripts/commit-log-editor (171953 => 171954)
--- trunk/Tools/Scripts/commit-log-editor 2014-08-01 22:49:51 UTC (rev 171953)
+++ trunk/Tools/Scripts/commit-log-editor 2014-08-01 23:10:50 UTC (rev 171954)
@@ -38,6 +38,8 @@
use VCSUtils;
use webkitdirs;
+sub commitMessageFromChangeLogEntry($);
+sub sortKey($);
sub createCommitMessage(@);
sub loadTermReadKey();
sub normalizeLineEndings($$);
@@ -176,11 +178,34 @@
chomp($webkitGenerateCommitMessage = `git config --bool core.webkitGenerateCommitMessage`);
}
if ($webkitGenerateCommitMessage ne false) {
-open CHANGELOG_ENTRIES, -|, $FindBin::Bin/prepare-ChangeLog --git-index --no-write --no-style or die prepare-ChangeLog failed: $!.\n;
-while (CHANGELOG_ENTRIES) {
-print NEWLOG normalizeLineEndings($_, $endl);
+my %changeLogSort;
+my %changeLogContents;
+open my $changeLogEntries, -|, $FindBin::Bin/prepare-ChangeLog --git-index --no-write --no-style --delimiters or die prepare-ChangeLog failed: $!.\n;
+
+while (!eof($changeLogEntries)) {
+my $label = $changeLogEntries;
+chomp $label;
+$label =~ s/:$//;
+($changeLogContents{$label}) = commitMessageFromChangeLogEntry($changeLogEntries);
+$changeLogSort{sortKey($label)} = $label;
}
-close CHANGELOG_ENTRIES;
+close $changeLogEntries;
+
+my $commonPrefix = removeLongestCommonPrefixEndingInNewline(%changeLogContents);
+
+my @result;
+push @result, normalizeLineEndings($commonPrefix, $endl);
+for my $sortKey (sort keys %changeLogSort) {
+my $label = $changeLogSort{$sortKey};
+next if ($changeLogContents{$label} eq \n);
+if (keys %changeLogSort 1) {
+push @result, normalizeLineEndings(\n, $endl);
+push @result, normalizeLineEndings($label: , $endl);
+}
+push @result, normalizeLineEndings($changeLogContents{$label}, $endl);
+}
+
+print NEWLOG join '', @result;
}
} else {
print NEWLOG createCommitMessage(@changeLogs);
@@ -209,68 +234,89 @@
unlink $log.edit;
-sub createCommitMessage(@)
+sub commitMessageFromChangeLogEntry($)
{
-my @changeLogs = @_;
+my ($changeLog) = @_;
-my $topLevel = determineVCSRoot();
+my $commitMessage = ;
+my $blankLines = ;
+my $lineCount = 0;
+my
[webkit-changes] [171955] trunk/Source/WebCore
Title: [171955] trunk/Source/WebCore
Revision 171955
Author mmaxfi...@apple.com
Date 2014-08-01 16:14:30 -0700 (Fri, 01 Aug 2014)
Log Message
SVG Font kerning can take an early out if the font has no kerning information
https://bugs.webkit.org/show_bug.cgi?id=135524
Reviewed by Dean Jackson.
Rather than calling SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs() again
and again, skip the iteration entirely if every call would return 0.
No new tests because there is no behavior change.
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::applySVGKerning):
* svg/SVGFontElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp
trunk/Source/WebCore/svg/SVGFontElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (171954 => 171955)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 23:10:50 UTC (rev 171954)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 23:14:30 UTC (rev 171955)
@@ -1,3 +1,19 @@
+2014-08-01 Myles C. Maxfield mmaxfi...@apple.com
+
+SVG Font kerning can take an early out if the font has no kerning information
+https://bugs.webkit.org/show_bug.cgi?id=135524
+
+Reviewed by Dean Jackson.
+
+Rather than calling SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs() again
+and again, skip the iteration entirely if every call would return 0.
+
+No new tests because there is no behavior change.
+
+* rendering/svg/SVGTextRunRenderingContext.cpp:
+(WebCore::SVGTextRunRenderingContext::applySVGKerning):
+* svg/SVGFontElement.h:
+
2014-08-01 Beth Dakin bda...@apple.com
Inspector highlights clipped at the bottom on the page in WK1 views with
Modified: trunk/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp (171954 => 171955)
--- trunk/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp 2014-08-01 23:10:50 UTC (rev 171954)
+++ trunk/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp 2014-08-01 23:14:30 UTC (rev 171955)
@@ -72,6 +72,9 @@
if (!fontElement || !fontFaceElement)
return false;
+if (fontElement-horizontalKerningMapIsEmpty())
+return true;
+
float scale = scaleEmToUnits(fontData-platformData().size(), fontFaceElement-unitsPerEm());
String lastGlyphName;
Modified: trunk/Source/WebCore/svg/SVGFontElement.h (171954 => 171955)
--- trunk/Source/WebCore/svg/SVGFontElement.h 2014-08-01 23:10:50 UTC (rev 171954)
+++ trunk/Source/WebCore/svg/SVGFontElement.h 2014-08-01 23:14:30 UTC (rev 171955)
@@ -81,6 +81,7 @@
Glyph missingGlyph();
const SVGMissingGlyphElement* firstMissingGlyphElement() const;
+bool horizontalKerningMapIsEmpty() const { return m_horizontalKerningMap.isEmpty(); }
private:
SVGFontElement(const QualifiedName, Document);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171956] trunk/Source/WebCore
Title: [171956] trunk/Source/WebCore
Revision 171956
Author akl...@apple.com
Date 2014-08-01 16:20:45 -0700 (Fri, 01 Aug 2014)
Log Message
Many DOM objects have InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero for no reason.
https://webkit.org/b/135519
Don't set this structure flag unless the object actually has an override
for getOwnPropertySlotByIndex().
Reviewed by Geoffrey Garen.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
* bindings/scripts/test/JS/JSTestException.h:
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestTypedefs.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (171955 => 171956)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 23:14:30 UTC (rev 171955)
+++ trunk/Source/WebCore/ChangeLog 2014-08-01 23:20:45 UTC (rev 171956)
@@ -1,3 +1,21 @@
+2014-08-01 Andreas Kling akl...@apple.com
+
+Many DOM objects have InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero for no reason.
+https://webkit.org/b/135519
+
+Don't set this structure flag unless the object actually has an override
+for getOwnPropertySlotByIndex().
+
+Reviewed by Geoffrey Garen.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
+* bindings/scripts/test/JS/JSTestException.h:
+* bindings/scripts/test/JS/JSTestInterface.h:
+* bindings/scripts/test/JS/JSTestObj.h:
+* bindings/scripts/test/JS/JSTestTypedefs.h:
+
2014-08-01 Myles C. Maxfield mmaxfi...@apple.com
SVG Font kerning can take an early out if the font has no kerning information
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (171955 => 171956)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2014-08-01 23:14:30 UTC (rev 171955)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2014-08-01 23:20:45 UTC (rev 171956)
@@ -890,10 +890,13 @@
# Getters
if ($hasGetter) {
push(@headerContent, static bool getOwnPropertySlot(JSC::JSObject*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot);\n);
-push(@headerContent, static bool getOwnPropertySlotByIndex(JSC::JSObject*, JSC::ExecState*, unsigned propertyName, JSC::PropertySlot);\n) if ($hasComplexGetter);
push(@headerContent, bool getOwnPropertySlotDelegate(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot);\n) if $interface-extendedAttributes-{JSCustomGetOwnPropertySlotAndDescriptor};
$structureFlags{JSC::OverridesGetOwnPropertySlot} = 1;
-$structureFlags{JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero} = 1;
+
+if ($hasComplexGetter) {
+push(@headerContent, static bool getOwnPropertySlotByIndex(JSC::JSObject*, JSC::ExecState*, unsigned propertyName, JSC::PropertySlot);\n);
+$structureFlags{JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero} = 1;
+}
}
my $overridesPut = InstanceOverridesPutDeclaration($interface);
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h (171955 => 171956)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h 2014-08-01 23:14:30 UTC (rev 171955)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h 2014-08-01 23:20:45 UTC (rev 171956)
@@ -72,7 +72,7 @@
ASSERT(inherits(info()));
}
-static const unsigned StructureFlags = JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | Base::StructureFlags;
+static const unsigned StructureFlags = JSC::OverridesGetOwnPropertySlot | Base::StructureFlags;
};
class JSTestActiveDOMObjectOwner : public JSC::WeakHandleOwner {
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.h (171955 => 171956)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.h 2014-08-01 23:14:30 UTC (rev 171955)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.h 2014-08-01 23:20:45 UTC (rev 171956)
@@ -73,7 +73,7 @@
ASSERT(inherits(info()));
}
-static const unsigned StructureFlags = JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | Base::StructureFlags;
+static const unsigned StructureFlags = JSC::OverridesGetOwnPropertySlot | Base::StructureFlags;
};
class JSTestExceptionOwner :
[webkit-changes] [171957] trunk/Source/WebCore
Title: [171957] trunk/Source/WebCore Revision 171957 Author simon.fra...@apple.com Date 2014-08-01 16:22:44 -0700 (Fri, 01 Aug 2014) Log Message Clean up image subsampling code, make it less iOS-specific https://bugs.webkit.org/show_bug.cgi?id=134916 Reviewed by Dean Jackson. Compile the image subsampling code on both Mac and iOS, and make it more platform neutral in general. Add a setting to allow it to be enabled on Mac for testing. The most significant changes are in ImageSourceCG and BitmapImageCG. CG's ImageSource is no longer stateful with respect to subsampling; its functions take a SubsamplingLevel when appropriate. CG's BitmapImage now determines which level of subsampling to use for a given frame, storing the subsampling level in the frame data. It can replace an aggressively subsampled frame with a less subsampled frame if necessary. To reduce the chances of subsampling affecting rendering, BitmapImage::size() now always returns the non-subsampled size; subsampling is strictly internal to BitmapImage. BitmapImage::draw() takes care of scaling the srcRect for subsampled images. iOS had a code path that enabled caching of frame metadata in BitmapImage without actually decoding the frame; make this cross-platform. * WebCore.exp.in: Changed signature for GraphicsContext::drawNativeImage(). * WebCore.xcodeproj/project.pbxproj: Added ImageSource.cpp, which is not built for Cocoa but useful for reference. * loader/cache/CachedImage.cpp: (WebCore::CachedImage::imageSizeForRenderer): Remove iOS-specific subsampling code. (WebCore::CachedImage::createImage): Call setAllowSubsampling() on the image if we can get to Settings (m_loader is null for image documents). (WebCore::CachedImage::currentFrameKnownToBeOpaque): This forced decode always caused creation of the non-subsampled image, so remove it. There's no reason to eagerly decode the frame here. * loader/cache/CachedImage.h: Fix comment. * page/Settings.cpp: Add defaultImageSubsamplingEnabled, true for iOS and false for Mac. * page/Settings.in: Added imageSubsamplingEnabled. * platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): Init some more things. Default m_allowSubsampling to true for iOS to catch images created in code paths where we can't get to Settings. (WebCore::BitmapImage::haveFrameAtIndex): Handy helper. (WebCore::BitmapImage::cacheFrame): Now takes the subsampling level and whether to cache just metadata, or also the frame. (WebCore::BitmapImage::didDecodeProperties): No need to store originalSize. (WebCore::BitmapImage::updateSize): When we get the size for the first time, call determineMinimumSubsamplingLevel() to choose a reasonable subsampling level which takes platform-specific limits into account. (WebCore::BitmapImage::dataChanged): Comment. (WebCore::BitmapImage::ensureFrameIsCached): Take ImageFrameCaching into account. (WebCore::BitmapImage::frameAtIndex): Choose a subsampling level given the scale, then determine if we can use the currently cached frame, or whether we should resample. (WebCore::BitmapImage::frameIsCompleteAtIndex): Caching m_isComplete is now done when caching frame metadata. (WebCore::BitmapImage::frameDurationAtIndex): (WebCore::BitmapImage::frameHasAlphaAtIndex): The 'true' return is the safe return value. (WebCore::BitmapImage::frameOrientationAtIndex): Caching m_orientation is now done when caching frame metadata. (WebCore::BitmapImage::cacheFrameInfo): Deleted. (WebCore::BitmapImage::originalSize): Deleted. (WebCore::BitmapImage::originalSizeRespectingOrientation): Deleted. (WebCore::BitmapImage::currentFrameSize): Deleted. (WebCore::BitmapImage::ensureFrameInfoIsCached): Deleted. * platform/graphics/BitmapImage.h: (WebCore::FrameData::FrameData): * platform/graphics/GraphicsContext.h: No need to pass a scale param now. * platform/graphics/ImageSource.cpp: Non-Cocoa changes. (WebCore::ImageSource::subsamplingLevelForScale): (WebCore::ImageSource::allowSubsamplingOfFrameAtIndex): (WebCore::ImageSource::size): (WebCore::ImageSource::frameSizeAtIndex): (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameBytesAtIndex): * platform/graphics/ImageSource.h: No longer stores subsampling state. (WebCore::ImageSource::isSubsampled): Deleted. * platform/graphics/cairo/BitmapImageCairo.cpp: (WebCore::BitmapImage::determineMinimumSubsamplingLevel): * platform/graphics/cg/BitmapImageCG.cpp: (WebCore::FrameData::clear): (WebCore::BitmapImage::BitmapImage): Init more members. (WebCore::BitmapImage::determineMinimumSubsamplingLevel): Choose a minimum subsampling level for the platform (subsample until the image area falls under a threshold). (WebCore::BitmapImage::checkForSolidColor): Don't bother decoding frames if the image is not 1x1. Also take care not to decode a non-subsampled image. (WebCore::BitmapImage::draw): The actual bug fix is here; remove logic that computed srcRectForCurrentFrame from m_size and m_originalSize; for some callers srcRect was computed
[webkit-changes] [171958] trunk/LayoutTests
Title: [171958] trunk/LayoutTests
Revision 171958
Author mmaxfi...@apple.com
Date 2014-08-01 16:55:40 -0700 (Fri, 01 Aug 2014)
Log Message
Unreviewed post-review test fixup
* editing/pasteboard/img-srcset-copy-paste-canonicalization.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/img-srcset-copy-paste-canonicalization.html
Diff
Modified: trunk/LayoutTests/ChangeLog (171957 => 171958)
--- trunk/LayoutTests/ChangeLog 2014-08-01 23:22:44 UTC (rev 171957)
+++ trunk/LayoutTests/ChangeLog 2014-08-01 23:55:40 UTC (rev 171958)
@@ -1,3 +1,9 @@
+2014-08-01 Myles C. Maxfield mmaxfi...@apple.com
+
+Unreviewed post-review test fixup
+
+* editing/pasteboard/img-srcset-copy-paste-canonicalization.html:
+
2014-08-01 Beth Dakin bda...@apple.com
REGRESSION (r171891): platform/mac/fast/scrolling/scroll-select-bottom-test.html
Modified: trunk/LayoutTests/editing/pasteboard/img-srcset-copy-paste-canonicalization.html (171957 => 171958)
--- trunk/LayoutTests/editing/pasteboard/img-srcset-copy-paste-canonicalization.html 2014-08-01 23:22:44 UTC (rev 171957)
+++ trunk/LayoutTests/editing/pasteboard/img-srcset-copy-paste-canonicalization.html 2014-08-01 23:55:40 UTC (rev 171958)
@@ -27,6 +27,13 @@
var sourceImageSegments;
var destinationImageSegments;
+var finishTestCount = 0;
+function maybeFinishTest() {
+++finishTestCount;
+if (finishTestCount == 2)
+finishJSTest();
+}
+
function runTests(href) {
iframeHref = href;
@@ -53,10 +60,10 @@
destinationImage._onerror_ = function() {
testFailed(Image should not fail to load);
-finishJSTest();
+maybeFinishTest();
}
-image._onload_ = function() {
-finishJSTest();
+destinationImage._onload_ = function() {
+maybeFinishTest();
}
sourceImageSegments = sourceImage.getAttribute(srcset).split( );
@@ -69,6 +76,7 @@
shouldBe(destinationImageSegments[1], \2x,\);
shouldBe(sourceImageSegments[3], \1x\);
shouldBe(destinationImageSegments[3], \1x\);
+maybeFinishTest();
}
/script
script src=""
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171959] trunk/Source/WebKit2
Title: [171959] trunk/Source/WebKit2 Revision 171959 Author joep...@webkit.org Date 2014-08-01 16:57:12 -0700 (Fri, 01 Aug 2014) Log Message [iOS WK2] Add extension read permission to network sandbox profile rdar://problem/17671574 Reviewed by Alexey Proskuryakov and Oliver Hunt. * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb Diff Modified: trunk/Source/WebKit2/ChangeLog (171958 => 171959) --- trunk/Source/WebKit2/ChangeLog 2014-08-01 23:55:40 UTC (rev 171958) +++ trunk/Source/WebKit2/ChangeLog 2014-08-01 23:57:12 UTC (rev 171959) @@ -1,3 +1,12 @@ +2014-08-01 Joseph Pecoraro pecor...@apple.com + +[iOS WK2] Add extension read permission to network sandbox profile +rdar://problem/17671574 + +Reviewed by Alexey Proskuryakov and Oliver Hunt. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: + 2014-08-01 Oliver Hunt oli...@apple.com Various frameworks may want to use the container temp directory, so our current restrictions are too tight Modified: trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (171958 => 171959) --- trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb 2014-08-01 23:55:40 UTC (rev 171958) +++ trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb 2014-08-01 23:57:12 UTC (rev 171959) @@ -36,6 +36,7 @@ ;; App sandbox extensions (allow file-read* file-write* (extension com.apple.app-sandbox.read-write)) +(allow file-read* (extension com.apple.app-sandbox.read)) ;; IOKit user clients (allow iokit-open ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171960] trunk/Source/WebCore
Title: [171960] trunk/Source/WebCore
Revision 171960
Author simon.fra...@apple.com
Date 2014-08-01 17:00:19 -0700 (Fri, 01 Aug 2014)
Log Message
Fix resource leak in FillLayersPropertyWrapper object member
https://bugs.webkit.org/show_bug.cgi?id=135462
Reviewed by Andreas Kling.
Fix leak of m_fillLayerPropertyWrapper by using unique_ptr.
Based on patch by Przemyslaw Kuczynski.
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (171959 => 171960)
--- trunk/Source/WebCore/ChangeLog 2014-08-01 23:57:12 UTC (rev 171959)
+++ trunk/Source/WebCore/ChangeLog 2014-08-02 00:00:19 UTC (rev 171960)
@@ -1,5 +1,18 @@
2014-08-01 Simon Fraser simon.fra...@apple.com
+Fix resource leak in FillLayersPropertyWrapper object member
+https://bugs.webkit.org/show_bug.cgi?id=135462
+
+Reviewed by Andreas Kling.
+
+Fix leak of m_fillLayerPropertyWrapper by using unique_ptr.
+Based on patch by Przemyslaw Kuczynski.
+
+* page/animation/CSSPropertyAnimation.cpp:
+(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
+
+2014-08-01 Simon Fraser simon.fra...@apple.com
+
Clean up image subsampling code, make it less iOS-specific
https://bugs.webkit.org/show_bug.cgi?id=134916
Modified: trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp (171959 => 171960)
--- trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2014-08-01 23:57:12 UTC (rev 171959)
+++ trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2014-08-02 00:00:19 UTC (rev 171960)
@@ -900,19 +900,19 @@
switch (prop) {
case CSSPropertyBackgroundPositionX:
case CSSPropertyWebkitMaskPositionX:
-m_fillLayerPropertyWrapper = new FillLayerPropertyWrapperLength(FillLayer::xPosition, FillLayer::setXPosition);
+m_fillLayerPropertyWrapper = std::make_uniqueFillLayerPropertyWrapperLength(FillLayer::xPosition, FillLayer::setXPosition);
break;
case CSSPropertyBackgroundPositionY:
case CSSPropertyWebkitMaskPositionY:
-m_fillLayerPropertyWrapper = new FillLayerPropertyWrapperLength(FillLayer::yPosition, FillLayer::setYPosition);
+m_fillLayerPropertyWrapper = std::make_uniqueFillLayerPropertyWrapperLength(FillLayer::yPosition, FillLayer::setYPosition);
break;
case CSSPropertyBackgroundSize:
case CSSPropertyWebkitBackgroundSize:
case CSSPropertyWebkitMaskSize:
-m_fillLayerPropertyWrapper = new FillLayerPropertyWrapperLengthSize(FillLayer::sizeLength, FillLayer::setSizeLength);
+m_fillLayerPropertyWrapper = std::make_uniqueFillLayerPropertyWrapperLengthSize(FillLayer::sizeLength, FillLayer::setSizeLength);
break;
case CSSPropertyBackgroundImage:
-m_fillLayerPropertyWrapper = new FillLayerStyleImagePropertyWrapper(FillLayer::image, FillLayer::setImage);
+m_fillLayerPropertyWrapper = std::make_uniqueFillLayerStyleImagePropertyWrapper(FillLayer::image, FillLayer::setImage);
break;
default:
break;
@@ -950,7 +950,7 @@
}
private:
-FillLayerAnimationPropertyWrapperBase* m_fillLayerPropertyWrapper;
+std::unique_ptrFillLayerAnimationPropertyWrapperBase m_fillLayerPropertyWrapper;
LayersGetter m_layersGetter;
LayersAccessor m_layersAccessor;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171961] trunk/Source
Title: [171961] trunk/Source
Revision 171961
Author clo...@igalia.com
Date 2014-08-01 17:10:11 -0700 (Fri, 01 Aug 2014)
Log Message
REGRESSION(r171942): [CMAKE] [GTK] build broken (clean build).
https://bugs.webkit.org/show_bug.cgi?id=135522
Reviewed by Martin Robinson.
Source/_javascript_Core:
* CMakeLists.txt: Output the inspector headers inside inspector
subdirectory.
Source/WebCore:
No new tests required, no new functionality.
* CMakeLists.txt: Add missing include to the inspector headers
and fix the path to InspectorJSTypeBuilders.h
Modified Paths
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (171960 => 171961)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2014-08-02 00:00:19 UTC (rev 171960)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2014-08-02 00:10:11 UTC (rev 171961)
@@ -883,7 +883,7 @@
MAIN_DEPENDENCY ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJS.json
DEPENDS ${_javascript_Core_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspector.py
${_javascript_Core_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspectorStrings.py
-COMMAND ${PYTHON_EXECUTABLE} ${_javascript_Core_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspector.py ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJS.json --output_h_dir ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR} --output_cpp_dir ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector --output_js_dir ${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol --output_type _javascript_ --write_always
+COMMAND ${PYTHON_EXECUTABLE} ${_javascript_Core_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspector.py ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJS.json --output_h_dir ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector --output_cpp_dir ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector --output_js_dir ${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol --output_type _javascript_ --write_always
VERBATIM)
file(MAKE_DIRECTORY ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector)
Modified: trunk/Source/_javascript_Core/ChangeLog (171960 => 171961)
--- trunk/Source/_javascript_Core/ChangeLog 2014-08-02 00:00:19 UTC (rev 171960)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-08-02 00:10:11 UTC (rev 171961)
@@ -1,3 +1,13 @@
+2014-08-01 Carlos Alberto Lopez Perez clo...@igalia.com
+
+REGRESSION(r171942): [CMAKE] [GTK] build broken (clean build).
+https://bugs.webkit.org/show_bug.cgi?id=135522
+
+Reviewed by Martin Robinson.
+
+* CMakeLists.txt: Output the inspector headers inside inspector
+subdirectory.
+
2014-08-01 Mark Lam mark@apple.com
Add some structure related assertions.
Modified: trunk/Source/WebCore/CMakeLists.txt (171960 => 171961)
--- trunk/Source/WebCore/CMakeLists.txt 2014-08-02 00:00:19 UTC (rev 171960)
+++ trunk/Source/WebCore/CMakeLists.txt 2014-08-02 00:10:11 UTC (rev 171961)
@@ -120,6 +120,7 @@
${WTF_DIR}
${DERIVED_SOURCES_DIR}/ForwardingHeaders
${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}
+${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector
${DERIVED_SOURCES_WEBCORE_DIR}
${CMAKE_SOURCE_DIR}/Source
${CMAKE_BINARY_DIR}
@@ -3275,7 +3276,7 @@
DEPENDS ${WebCore_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspector.py
${WebCore_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspectorStrings.py
${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJS.json
-${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSTypeBuilders.h
+${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector/InspectorJSTypeBuilders.h
COMMAND ${PYTHON_EXECUTABLE} ${WebCore_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspector.py ${DERIVED_SOURCES_WEBCORE_DIR}/InspectorWeb.json ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJS.json --output_h_dir ${DERIVED_SOURCES_WEBCORE_DIR} --output_cpp_dir ${DERIVED_SOURCES_WEBCORE_DIR} --output_js_dir ${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol --output_type Web --write_always
VERBATIM)
Modified: trunk/Source/WebCore/ChangeLog (171960 => 171961)
--- trunk/Source/WebCore/ChangeLog 2014-08-02 00:00:19 UTC (rev 171960)
+++ trunk/Source/WebCore/ChangeLog 2014-08-02 00:10:11 UTC (rev 171961)
@@ -1,3 +1,15 @@
+2014-08-01 Carlos Alberto Lopez Perez clo...@igalia.com
+
+REGRESSION(r171942): [CMAKE] [GTK] build broken (clean build).
+https://bugs.webkit.org/show_bug.cgi?id=135522
+
+Reviewed by Martin Robinson.
+
+No new tests required, no new functionality.
+
+* CMakeLists.txt: Add missing include to the inspector headers
+and fix the path to InspectorJSTypeBuilders.h
+
2014-08-01 Simon Fraser simon.fra...@apple.com
Fix resource leak in FillLayersPropertyWrapper object member
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [171962] trunk/Source
Title: [171962] trunk/Source
Revision 171962
Author commit-qu...@webkit.org
Date 2014-08-01 17:46:22 -0700 (Fri, 01 Aug 2014)
Log Message
[CMake] Allow CMake to find GLib on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=132530
Patch by Myles C. Maxfield lithe...@gmail.com on 2014-08-01
Reviewed by Gustavo Noronha Silva.
On FreeBSD, glibconfig.h is at /usr/local/include/glib-2.0/glibconfig.h.
* Source/cmake/FindGLIB.cmake:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/cmake/FindGLIB.cmake
Diff
Modified: trunk/Source/WebCore/ChangeLog (171961 => 171962)
--- trunk/Source/WebCore/ChangeLog 2014-08-02 00:10:11 UTC (rev 171961)
+++ trunk/Source/WebCore/ChangeLog 2014-08-02 00:46:22 UTC (rev 171962)
@@ -1,3 +1,14 @@
+2014-08-01 Myles C. Maxfield lithe...@gmail.com
+
+[CMake] Allow CMake to find GLib on FreeBSD
+https://bugs.webkit.org/show_bug.cgi?id=132530
+
+Reviewed by Gustavo Noronha Silva.
+
+On FreeBSD, glibconfig.h is at /usr/local/include/glib-2.0/glibconfig.h.
+
+* Source/cmake/FindGLIB.cmake:
+
2014-08-01 Carlos Alberto Lopez Perez clo...@igalia.com
REGRESSION(r171942): [CMAKE] [GTK] build broken (clean build).
Modified: trunk/Source/cmake/FindGLIB.cmake (171961 => 171962)
--- trunk/Source/cmake/FindGLIB.cmake 2014-08-02 00:10:11 UTC (rev 171961)
+++ trunk/Source/cmake/FindGLIB.cmake 2014-08-02 00:46:22 UTC (rev 171962)
@@ -56,6 +56,7 @@
find_path(GLIBCONFIG_INCLUDE_DIR
NAMES glibconfig.h
HINTS ${PC_LIBDIR} ${PC_LIBRARY_DIRS} ${_GLIB_LIBRARY_DIR}
+ ${PC_GLIB_INCLUDEDIR} ${PC_GLIB_INCLUDE_DIRS}
PATH_SUFFIXES glib-2.0/include
)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [171963] trunk/LayoutTests
Title: [171963] trunk/LayoutTests Revision 171963 Author clo...@igalia.com Date 2014-08-01 21:00:18 -0700 (Fri, 01 Aug 2014) Log Message [GTK] Unreviewed GTK gardening. * platform/gtk/TestExpectations: Report and mark new failures and flaky tests after 171341, r171591, r171567 and others. * platform/gtk/fast/css/viewport-units-dynamic-expected.txt: Added. Rebaseline after r171567. * platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt: Added. Rebaseline after r171609. * platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Rebaseline after 171341. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt Added Paths trunk/LayoutTests/platform/gtk/fast/css/viewport-units-dynamic-expected.txt trunk/LayoutTests/platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (171962 => 171963) --- trunk/LayoutTests/ChangeLog 2014-08-02 00:46:22 UTC (rev 171962) +++ trunk/LayoutTests/ChangeLog 2014-08-02 04:00:18 UTC (rev 171963) @@ -1,3 +1,12 @@ +2014-08-01 Carlos Alberto Lopez Perez clo...@igalia.com + +[GTK] Unreviewed GTK gardening. + +* platform/gtk/TestExpectations: Report and mark new failures and flaky tests after 171341, r171591, r171567 and others. +* platform/gtk/fast/css/viewport-units-dynamic-expected.txt: Added. Rebaseline after r171567. +* platform/gtk/fast/multicol/pagination/RightToLeft-max-width-expected.txt: Added. Rebaseline after r171609. +* platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Rebaseline after 171341. + 2014-08-01 Myles C. Maxfield mmaxfi...@apple.com Unreviewed post-review test fixup Modified: trunk/LayoutTests/platform/gtk/TestExpectations (171962 => 171963) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-08-02 00:46:22 UTC (rev 171962) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-08-02 04:00:18 UTC (rev 171963) @@ -396,6 +396,7 @@ # HighDPI support is not enabled webkit.org/b/131347 fast/backgrounds/hidpi-background-image-contain-cover-scale-needs-more-precision.html [ ImageOnlyFailure ] webkit.org/b/131347 fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position.html [ ImageOnlyFailure ] +webkit.org/b/131347 fast/backgrounds/hidpi-generated-gradient-background-on-subpixel-position.html [ ImageOnlyFailure Pass ] webkit.org/b/131347 fast/borders/hidpi-border-image-gradient-on-subpixels.html [ ImageOnlyFailure ] webkit.org/b/131347 fast/borders/hidpi-border-radius-with-subpixel-margin-not-renderable.html [ ImageOnlyFailure ] webkit.org/b/131347 fast/borders/hidpi-double-border-with-border-radius-always-produce-solid-line.html [ ImageOnlyFailure ] @@ -409,6 +410,7 @@ webkit.org/b/131347 fast/hidpi/image-srcset-fraction-1.5x.html [ Failure ] webkit.org/b/131347 fast/hidpi/image-srcset-fraction.html [ Failure ] webkit.org/b/131347 fast/hidpi/image-srcset-invalid-inputs-except-one.html [ Failure ] +webkit.org/b/131347 fast/hidpi/image-srcset-png-canvas.html [ ImageOnlyFailure Pass ] webkit.org/b/131347 fast/hidpi/image-srcset-simple-2x.html [ Failure ] webkit.org/b/131347 fast/hidpi/image-srcset-src-selection-2x.html [ Failure ] webkit.org/b/131347 fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html [ ImageOnlyFailure ] @@ -494,8 +496,6 @@ webkit.org/b/131219 [ Debug ] http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html [ Crash ] -webkit.org/b/116977 [ Debug ] media/event-attributes.html [ Crash Pass ] - webkit.org/b/131222 [ Debug ] media/video-currentsrc-cleared.html [ Crash Pass ] webkit.org/b/131224 [ Debug ] media/track/track-insert-after-load-crash.html [ Crash ] @@ -658,7 +658,7 @@ webkit.org/b/116976 media/video-played-collapse.html [ Failure Pass ] -webkit.org/b/116977 media/event-attributes.html [ Failure Timeout Pass ] +webkit.org/b/116977 media/event-attributes.html [ Crash Failure Timeout Pass ] webkit.org/b/103443 fast/parser/parser-yield-timing.html [ Failure Pass ] @@ -792,10 +792,12 @@ # Some media fragment tests are flaky webkit.org/b/132248 media/media-fragments/TC0001.html [ Timeout Pass ] webkit.org/b/132248 media/media-fragments/TC0002.html [ Crash Pass ] +webkit.org/b/132248 media/media-fragments/TC0004.html [ Crash Pass ] webkit.org/b/132248 media/media-fragments/TC0005.html [ Failure Pass ] webkit.org/b/132248 media/media-fragments/TC0006.html [ Failure Pass ] webkit.org/b/132248 media/media-fragments/TC0014.html [ Failure Pass ] webkit.org/b/132248 media/media-fragments/TC0015.html [ Failure Crash Pass ] +webkit.org/b/134574 media/media-fragments/TC0024.html [ Failure Timeout Pass ] webkit.org/b/132248 media/media-fragments/TC0037.html [ Failure Pass ] webkit.org/b/132248 media/media-fragments/TC0038.html [ Failure Crash Pass ] webkit.org/b/132248
[webkit-changes] [171964] trunk/Source/WebCore
Title: [171964] trunk/Source/WebCore
Revision 171964
Author commit-qu...@webkit.org
Date 2014-08-01 22:10:46 -0700 (Fri, 01 Aug 2014)
Log Message
Unreviewed, rolling out r171957.
https://bugs.webkit.org/show_bug.cgi?id=135538
Caused GTK assertions and test failures (Requested by smfr on
#webkit).
Reverted changeset:
Clean up image subsampling code, make it less iOS-specific
https://bugs.webkit.org/show_bug.cgi?id=134916
http://trac.webkit.org/changeset/171957
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/loader/cache/CachedImage.h
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.h
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/ImageSource.cpp
trunk/Source/WebCore/platform/graphics/ImageSource.h
trunk/Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp
trunk/Source/WebCore/platform/graphics/mac/ImageMac.mm
trunk/Source/WebCore/platform/graphics/wince/ImageWinCE.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (171963 => 171964)
--- trunk/Source/WebCore/ChangeLog 2014-08-02 04:00:18 UTC (rev 171963)
+++ trunk/Source/WebCore/ChangeLog 2014-08-02 05:10:46 UTC (rev 171964)
@@ -1,3 +1,17 @@
+2014-08-01 Commit Queue commit-qu...@webkit.org
+
+Unreviewed, rolling out r171957.
+https://bugs.webkit.org/show_bug.cgi?id=135538
+
+Caused GTK assertions and test failures (Requested by smfr on
+#webkit).
+
+Reverted changeset:
+
+Clean up image subsampling code, make it less iOS-specific
+https://bugs.webkit.org/show_bug.cgi?id=134916
+http://trac.webkit.org/changeset/171957
+
2014-08-01 Myles C. Maxfield lithe...@gmail.com
[CMake] Allow CMake to find GLib on FreeBSD
Modified: trunk/Source/WebCore/WebCore.exp.in (171963 => 171964)
--- trunk/Source/WebCore/WebCore.exp.in 2014-08-02 04:00:18 UTC (rev 171963)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-08-02 05:10:46 UTC (rev 171964)
@@ -521,7 +521,6 @@
__ZN7WebCore15GraphicsContext11clearShadowEv
__ZN7WebCore15GraphicsContext12setFillColorERKNS_5ColorENS_10ColorSpaceE
__ZN7WebCore15GraphicsContext14setStrokeColorERKNS_5ColorENS_10ColorSpaceE
-__ZN7WebCore15GraphicsContext15drawNativeImageEP7CGImageRKNS_9FloatSizeENS_10ColorSpaceERKNS_9FloatRectES9_NS_17CompositeOperatorENS_9BlendModeENS_16ImageOrientationE
__ZN7WebCore15GraphicsContext15setFillGradientEN3WTF10PassRefPtrINS_8GradientEEE
__ZN7WebCore15GraphicsContext18setShouldAntialiasEb
__ZN7WebCore15GraphicsContext19setIsCALayerContextEb
@@ -2238,6 +2237,7 @@
__ZN7WebCore13getRawCookiesERKNS_21NetworkStorageSessionERKNS_3URLES5_RN3WTF6VectorINS_6CookieELm0ENS6_15CrashOnOverflowEEE
__ZN7WebCore13toDeviceSpaceERKNS_9FloatRectEP8NSWindow
__ZN7WebCore14cookiesEnabledERKNS_21NetworkStorageSessionERKNS_3URLES5_
+__ZN7WebCore15GraphicsContext15drawNativeImageEP7CGImageRKNS_9FloatSizeENS_10ColorSpaceERKNS_9FloatRectES9_fNS_17CompositeOperatorENS_9BlendModeENS_16ImageOrientationE
__ZN7WebCore15GraphicsContextC1EP9CGContext
__ZN7WebCore15ResourceRequest41updateFromDelegatePreservingOldPropertiesERKS0_
__ZN7WebCore16FontPlatformDataC1EP6NSFontfbbbNS_15FontOrientationENS_16FontWidthVariantE
@@ -2588,6 +2588,7 @@
__ZN7WebCore15DatabaseTracker7trackerEv
__ZN7WebCore15GraphicsContext12drawBidiTextERKNS_4FontERKNS_7TextRunERKNS_10FloatPointENS1_24CustomFontNotReadyActionEPNS_10BidiStatusEi
__ZN7WebCore15GraphicsContext15drawLineForTextERKNS_10FloatPointEfbb
+__ZN7WebCore15GraphicsContext15drawNativeImageEP7CGImageRKNS_9FloatSizeENS_10ColorSpaceERKNS_9FloatRectES9_fNS_17CompositeOperatorENS_9BlendModeENS_16ImageOrientationE
__ZN7WebCore15GraphicsContext22setEmojiDrawingEnabledEb
__ZN7WebCore15GraphicsContext23setIsAcceleratedContextEb
__ZN7WebCore15GraphicsContextC1EP9CGContextb
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (171963 => 171964)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-08-02 04:00:18 UTC (rev 171963)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-08-02 05:10:46 UTC (rev 171964)
@@ -473,7 +473,6 @@
0F1774801378B772009DA76A /* ScrollAnimatorIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F17747E1378B771009DA76A /* ScrollAnimatorIOS.h */; };
0F1774811378B772009DA76A /* ScrollAnimatorIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 0F17747F1378B772009DA76A /*
