date:20140815

[webkit-changes] [172622] trunk

2014-08-15 Thread carlosgc

Title: [172622] trunk








Revision 172622
Author carlo...@webkit.org
Date 2014-08-15 02:16:07 -0700 (Fri, 15 Aug 2014)


Log Message
[GTK] HTML API documentation should also be installed versioned
https://bugs.webkit.org/show_bug.cgi?id=135970

Reviewed by Philippe Normand.

* Source/PlatformGTK.cmake: Append -${WEBKITGTK_API_VERSION} to
the directory name.

Modified Paths

trunk/ChangeLog
trunk/Source/PlatformGTK.cmake




Diff

Modified: trunk/ChangeLog (172621 => 172622)

--- trunk/ChangeLog	2014-08-15 04:24:33 UTC (rev 172621)
+++ trunk/ChangeLog	2014-08-15 09:16:07 UTC (rev 172622)
@@ -1,3 +1,13 @@
+2014-08-15  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] HTML API documentation should also be installed versioned
+https://bugs.webkit.org/show_bug.cgi?id=135970
+
+Reviewed by Philippe Normand.
+
+* Source/PlatformGTK.cmake: Append -${WEBKITGTK_API_VERSION} to
+the directory name.
+
 2014-08-14  Tomas Popela  tpop...@redhat.com
 
 Add support for ppc, ppc64, ppc64le, s390, s390x into the CMake build


Modified: trunk/Source/PlatformGTK.cmake (172621 => 172622)

--- trunk/Source/PlatformGTK.cmake	2014-08-15 04:24:33 UTC (rev 172621)
+++ trunk/Source/PlatformGTK.cmake	2014-08-15 09:16:07 UTC (rev 172622)
@@ -14,10 +14,10 @@
 
 if (ENABLE_GTKDOC)
 install(DIRECTORY ${CMAKE_BINARY_DIR}/Documentation/webkit2gtk/html/
-DESTINATION ${CMAKE_INSTALL_DATADIR}/gtk-doc/html/webkit2gtk
+DESTINATION ${CMAKE_INSTALL_DATADIR}/gtk-doc/html/webkit2gtk-${WEBKITGTK_API_VERSION}
 )
 install(DIRECTORY ${CMAKE_BINARY_DIR}/Documentation/webkitdomgtk/html/
-DESTINATION ${CMAKE_INSTALL_DATADIR}/gtk-doc/html/webkitdomgtk
+DESTINATION ${CMAKE_INSTALL_DATADIR}/gtk-doc/html/webkitdomgtk-${WEBKITGTK_API_VERSION}
 )
 endif ()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172623] trunk

2014-08-15 Thread carlosgc

Title: [172623] trunk








Revision 172623
Author carlo...@webkit.org
Date 2014-08-15 04:30:15 -0700 (Fri, 15 Aug 2014)


Log Message
[GTK] Disable memory sampler on non-Linux system
https://bugs.webkit.org/show_bug.cgi?id=134483

Patch by Ting-Wei Lan lant...@gmail.com on 2014-08-15
Reviewed by Philippe Normand.

Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp only works on
Linux because it uses many Linux-specific features, so we should disable
memory sampler on other systems by default.

* Source/cmake/OptionsGTK.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (172622 => 172623)

--- trunk/ChangeLog	2014-08-15 09:16:07 UTC (rev 172622)
+++ trunk/ChangeLog	2014-08-15 11:30:15 UTC (rev 172623)
@@ -1,3 +1,16 @@
+2014-08-15  Ting-Wei Lan  lant...@gmail.com
+
+[GTK] Disable memory sampler on non-Linux system
+https://bugs.webkit.org/show_bug.cgi?id=134483
+
+Reviewed by Philippe Normand.
+
+Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp only works on
+Linux because it uses many Linux-specific features, so we should disable
+memory sampler on other systems by default.
+
+* Source/cmake/OptionsGTK.cmake:
+
 2014-08-15  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] HTML API documentation should also be installed versioned


Modified: trunk/Source/cmake/OptionsGTK.cmake (172622 => 172623)

--- trunk/Source/cmake/OptionsGTK.cmake	2014-08-15 09:16:07 UTC (rev 172622)
+++ trunk/Source/cmake/OptionsGTK.cmake	2014-08-15 11:30:15 UTC (rev 172623)
@@ -96,6 +96,12 @@
 set(WebKit2_VERSION_SCRIPT -Wl,--version-script,${CMAKE_MODULE_PATH}/gtksymbols.filter)
 endif ()
 
+if (CMAKE_SYSTEM_NAME MATCHES Linux)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER ON)
+else ()
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER OFF)
+endif ()
+
 # FIXME: We want to expose fewer options to downstream, but for now everything is public.
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_RENDERING ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY ON)
@@ -127,7 +133,6 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LINK_PREFETCH OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_CAPTURE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_CONTROLS_SCRIPT ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_CONTENT_UTILS OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NAVIGATOR_HWCONCURRENCY ON)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172624] trunk

2014-08-15 Thread carlosgc

Title: [172624] trunk








Revision 172624
Author carlo...@webkit.org
Date 2014-08-15 05:23:07 -0700 (Fri, 15 Aug 2014)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.3 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

* gtk/NEWS: Add release notes for 2.5.3.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/gtk/NEWS
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (172623 => 172624)

--- trunk/ChangeLog	2014-08-15 11:30:15 UTC (rev 172623)
+++ trunk/ChangeLog	2014-08-15 12:23:07 UTC (rev 172624)
@@ -1,3 +1,9 @@
+2014-08-15  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.3 release.
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2014-08-15  Ting-Wei Lan  lant...@gmail.com
 
 [GTK] Disable memory sampler on non-Linux system


Modified: trunk/Source/WebKit2/ChangeLog (172623 => 172624)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 11:30:15 UTC (rev 172623)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 12:23:07 UTC (rev 172624)
@@ -1,3 +1,9 @@
+2014-08-15  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.3 release.
+
+* gtk/NEWS: Add release notes for 2.5.3.
+
 2014-08-14  Enrica Casucci  enr...@apple.com
 
 [Services with UI] Selection services don't work inside iframes.


Modified: trunk/Source/WebKit2/gtk/NEWS (172623 => 172624)

--- trunk/Source/WebKit2/gtk/NEWS	2014-08-15 11:30:15 UTC (rev 172623)
+++ trunk/Source/WebKit2/gtk/NEWS	2014-08-15 12:23:07 UTC (rev 172624)
@@ -1,4 +1,17 @@
 =
+WebKitGTK+  2.5.3
+=
+
+What's new in WebKitGTK+ 2.5.3?
+
+  - Fix a crash when drag and drop to a WebKitWebView.
+  - Fix slow motion rendering problem in GStreamer media backend due to integer rounding.
+  - Make sure the plugins cache is always used even if the cache directory doesn't exist.
+  - Fix the build on FreeBSD.
+  - Install the HTML API docs for WebKit2 and WebKitDOM in a versioned directory.
+  - Intall the GObject instrospection files to the correct path.
+
+=
 WebKitGTK+  2.5.2
 =
 


Modified: trunk/Source/cmake/OptionsGTK.cmake (172623 => 172624)

--- trunk/Source/cmake/OptionsGTK.cmake	2014-08-15 11:30:15 UTC (rev 172623)
+++ trunk/Source/cmake/OptionsGTK.cmake	2014-08-15 12:23:07 UTC (rev 172624)
@@ -2,14 +2,14 @@
 
 set(PROJECT_VERSION_MAJOR 2)
 set(PROJECT_VERSION_MINOR 5)
-set(PROJECT_VERSION_MICRO 2)
+set(PROJECT_VERSION_MICRO 3)
 set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_MICRO})
 set(WEBKITGTK_API_VERSION 4.0)
 
 # Libtool library version, not to be confused with API version.
 # See http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT2 38 0 1)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 18 1 0)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT2 38 1 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 18 2 0)
 
 set(ENABLE_CREDENTIAL_STORAGE ON CACHE BOOL Whether or not to enable support for credential storage using libsecret.)
 set(ENABLE_GTKDOC OFF CACHE BOOL Whether or not to use generate gtkdoc.)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172625] releases/WebKitGTK/webkit-2.5.3/

2014-08-15 Thread carlosgc

Title: [172625] releases/WebKitGTK/webkit-2.5.3/








Revision 172625
Author carlo...@webkit.org
Date 2014-08-15 05:35:02 -0700 (Fri, 15 Aug 2014)


Log Message
WebKitGTK+ 2.5.3

Added Paths

releases/WebKitGTK/webkit-2.5.3/




Diff

Property changes: releases/WebKitGTK/webkit-2.5.3



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172627] trunk/Source/WebKit

2014-08-15 Thread mrowe

Title: [172627] trunk/Source/WebKit








Revision 172627
Author mr...@apple.com
Date 2014-08-15 09:49:37 -0700 (Fri, 15 Aug 2014)


Log Message
https://webkit.org/b/135979 WebKit1 Plug-in test failures in clean builds after r172595

Reviewed by Dan Bernstein.

* WebKit.xcodeproj/project.pbxproj: Add a WebKitPluginHost.app symlink at the top level of
WebKitLegacy.framework that points into Versions/Current. This enables -[NSBundle pathForAuxiliaryExecutable:]
to work correctly. Adding this symlink requires deleting any content that may already exist
at that path, since prior to r172595 it may have contained either a symlink or an
application bundle.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (172626 => 172627)

--- trunk/Source/WebKit/ChangeLog	2014-08-15 16:38:35 UTC (rev 172626)
+++ trunk/Source/WebKit/ChangeLog	2014-08-15 16:49:37 UTC (rev 172627)
@@ -1,3 +1,15 @@
+2014-08-15  Mark Rowe  mr...@apple.com
+
+https://webkit.org/b/135979 WebKit1 Plug-in test failures in clean builds after r172595
+
+Reviewed by Dan Bernstein.
+
+* WebKit.xcodeproj/project.pbxproj: Add a WebKitPluginHost.app symlink at the top level of
+WebKitLegacy.framework that points into Versions/Current. This enables -[NSBundle pathForAuxiliaryExecutable:]
+to work correctly. Adding this symlink requires deleting any content that may already exist
+at that path, since prior to r172595 it may have contained either a symlink or an
+application bundle.
+
 2014-08-13  Mark Rowe  mr...@apple.com
 
 https://webkit.org/b/135909 Move helper applications out of the root of the framework.


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (172626 => 172627)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2014-08-15 16:38:35 UTC (rev 172626)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2014-08-15 16:49:37 UTC (rev 172627)
@@ -2011,7 +2011,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = if [[ ${PLATFORM_NAME} == \iphoneos\ || ${PLATFORM_NAME} == \iphonesimulator\ ]]; then\nexit 0\nfi\n\nif [[ \${CONFIGURATION}\ != \Production\  \${ACTION}\ == \build\ ]]; then\n# FIXME: This should be removed once faulty links have been removed on the bots.\nif [[ -L \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app\ ]]; then\nrm \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app\\nfi\n\nif [[ -e \/System/Library/Frameworks/WebKit.framework/WebKitPluginHost.app\ ]]; then\nln -s /System/Library/Frameworks/WebKit.framework/WebKitPluginHost.app \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app\\nelse\nln -s /System/Library/Frameworks/WebKit.framework/Frameworks/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app\\nfi\nfi\n;
+			shellScript = if [[ ${PLATFORM_NAME} == \iphoneos\ || ${PLATFORM_NAME} == \iphonesimulator\ || ${ACTION} != \build\ ]]; then\nexit 0\nfi\n\n# Prior to r172595, WebKitPluginHost.app lived at the top level of the framework. Replace any stale copy with a symlink to the new location at Versions/Current.\nrm -rf \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/WebKitPluginHost.app\\nln -s Versions/Current/WebKitPluginHost.app \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/WebKitPluginHost.app\\n\nif [[ \${CONFIGURATION}\ != \Production\ ]]; then\n# FIXME: This should be removed once faulty links have been removed on the bots.\nif [[ -L \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app\ ]]; then\nrm \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app\\nfi\n\nif [[ -e \/System/Library/Frameworks/WebKit.framework/WebKitPluginHost.app\ ]]; then\nln -s /System/Library/Frameworks/WebKit.framework/WebKitPluginHost.app \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app\\nelse\nln -s /System/Library/Frameworks/WebKit.framework/Frameworks/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app \${CONFIGURATION_BUILD_DIR}/WebKitLegacy.framework/Versions/A/WebKitPluginHost.app\\nfi\nfi\n;
 		};
 		1C395DE20C6BE8ED1E52 /* Generate Export Files */ = {
 			isa = PBXShellScriptBuildPhase;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172628] branches/safari-600.1.4.11-branch/

2014-08-15 Thread lforschler

Title: [172628] branches/safari-600.1.4.11-branch/








Revision 172628
Author lforsch...@apple.com
Date 2014-08-15 10:31:45 -0700 (Fri, 15 Aug 2014)


Log Message
New Branch.

Added Paths

branches/safari-600.1.4.11-branch/




Diff

Property changes: branches/safari-600.1.4.11-branch



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172629] trunk/Source/WebKit2

2014-08-15 Thread barraclough

Title: [172629] trunk/Source/WebKit2








Revision 172629
Author barraclo...@apple.com
Date 2014-08-15 10:33:22 -0700 (Fri, 15 Aug 2014)


Log Message
Simplify visibility activity accounting for plugins
https://bugs.webkit.org/show_bug.cgi?id=135981

Reviewed by Dan Bernstein.

Just take one per connection, rather than implementing a counting mechanism.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
* PluginProcess/PluginControllerProxy.h:
- added m_visiblityActivity.
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess):
(WebKit::PluginProcess::pluginsForWebProcessDidBecomeVisible): Deleted.
(WebKit::PluginProcess::pluginsForWebProcessDidBecomeHidden): Deleted.
* PluginProcess/PluginProcess.h:
- removed pluginsForWebProcessDidBecomeVisible/Hidden.
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::pluginDidBecomeVisible): Deleted.
(WebKit::WebProcessConnection::pluginDidBecomeHidden): Deleted.
* PluginProcess/WebProcessConnection.h:
- removed pluginDidBecomeVisible/Hidden.
* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::windowVisibilityChanged):
- windowVisibilityChanged uses m_visiblityActivity, rather than calling to PluginControllerProxy.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h
trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp
trunk/Source/WebKit2/PluginProcess/PluginProcess.h
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h
trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172628 => 172629)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 17:31:45 UTC (rev 172628)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 17:33:22 UTC (rev 172629)
@@ -1,3 +1,32 @@
+2014-08-15  Gavin Barraclough  barraclo...@apple.com
+
+Simplify visibility activity accounting for plugins
+https://bugs.webkit.org/show_bug.cgi?id=135981
+
+Reviewed by Dan Bernstein.
+
+Just take one per connection, rather than implementing a counting mechanism.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::PluginControllerProxy):
+* PluginProcess/PluginControllerProxy.h:
+- added m_visiblityActivity.
+* PluginProcess/PluginProcess.cpp:
+(WebKit::PluginProcess::PluginProcess):
+(WebKit::PluginProcess::pluginsForWebProcessDidBecomeVisible): Deleted.
+(WebKit::PluginProcess::pluginsForWebProcessDidBecomeHidden): Deleted.
+* PluginProcess/PluginProcess.h:
+- removed pluginsForWebProcessDidBecomeVisible/Hidden.
+* PluginProcess/WebProcessConnection.cpp:
+(WebKit::WebProcessConnection::removePluginControllerProxy):
+(WebKit::WebProcessConnection::pluginDidBecomeVisible): Deleted.
+(WebKit::WebProcessConnection::pluginDidBecomeHidden): Deleted.
+* PluginProcess/WebProcessConnection.h:
+- removed pluginDidBecomeVisible/Hidden.
+* PluginProcess/mac/PluginControllerProxyMac.mm:
+(WebKit::PluginControllerProxy::windowVisibilityChanged):
+- windowVisibilityChanged uses m_visiblityActivity, rather than calling to PluginControllerProxy.
+
 2014-08-15  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.3 release.


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (172628 => 172629)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2014-08-15 17:31:45 UTC (rev 172628)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2014-08-15 17:33:22 UTC (rev 172629)
@@ -72,6 +72,7 @@
 , m_contentsScaleFactor(creationParameters.contentsScaleFactor)
 , m_windowNPObject(0)
 , m_pluginElementNPObject(0)
+, m_visiblityActivity(Plugin is visible.)
 {
 }
 


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h (172628 => 172629)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h	2014-08-15 17:31:45 UTC (rev 172628)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h	2014-08-15 17:33:22 UTC (rev 172629)
@@ -35,6 +35,7 @@
 #include ShareableBitmap.h
 #include WebProcessConnectionMessages.h
 #include WebCore/SecurityOrigin.h
+#include WebCore/UserActivity.h
 #include wtf/Noncopyable.h
 #include wtf/RunLoop.h
 
@@ -220,6 +221,9 @@
 
 // The plug-in element NPObject.
 NPObject* m_pluginElementNPObject;
+
+// Hold an activity when the plugin is visible to prevent throttling.
+UserActivity m_visiblityActivity;
 };
 
 } // namespace WebKit


Modified: trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp (172628 => 172629)

[webkit-changes] [172630] branches/safari-600.1.4.11-branch/Source

2014-08-15 Thread lforschler

Title: [172630] branches/safari-600.1.4.11-branch/Source








Revision 172630
Author lforsch...@apple.com
Date 2014-08-15 10:36:05 -0700 (Fri, 15 Aug 2014)


Log Message
Versioning.

Modified Paths

branches/safari-600.1.4.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-600.1.4.11-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-600.1.4.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-600.1.4.11-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-600.1.4.11-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-600.1.4.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (172629 => 172630)

--- branches/safari-600.1.4.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-15 17:33:22 UTC (rev 172629)
+++ branches/safari-600.1.4.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-15 17:36:05 UTC (rev 172630)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
 MICRO_VERSION = 11;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-600.1.4.11-branch/Source/WebCore/Configurations/Version.xcconfig (172629 => 172630)

--- branches/safari-600.1.4.11-branch/Source/WebCore/Configurations/Version.xcconfig	2014-08-15 17:33:22 UTC (rev 172629)
+++ branches/safari-600.1.4.11-branch/Source/WebCore/Configurations/Version.xcconfig	2014-08-15 17:36:05 UTC (rev 172630)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
 MICRO_VERSION = 11;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-600.1.4.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (172629 => 172630)

--- branches/safari-600.1.4.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-15 17:33:22 UTC (rev 172629)
+++ branches/safari-600.1.4.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-15 17:36:05 UTC (rev 172630)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
 MICRO_VERSION = 11;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX = $(SYSTEM_VERSION_PREFIX_$(PLATFORM_NAME));


Modified: branches/safari-600.1.4.11-branch/Source/WebKit/mac/Configurations/Version.xcconfig (172629 => 172630)

--- branches/safari-600.1.4.11-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-15 17:33:22 UTC (rev 172629)
+++ branches/safari-600.1.4.11-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-15 17:36:05 UTC (rev 172630)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
 MICRO_VERSION = 11;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-600.1.4.11-branch/Source/WebKit2/Configurations/Version.xcconfig (172629 => 172630)

--- branches/safari-600.1.4.11-branch/Source/WebKit2/Configurations/Version.xcconfig	2014-08-15 17:33:22 UTC (rev 172629)
+++ branches/safari-600.1.4.11-branch/Source/WebKit2/Configurations/Version.xcconfig	2014-08-15 17:36:05 UTC (rev 172630)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
 MICRO_VERSION = 11;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172631] trunk/Source/WebKit

2014-08-15 Thread aestes

Title: [172631] trunk/Source/WebKit








Revision 172631
Author aes...@apple.com
Date 2014-08-15 10:38:47 -0700 (Fri, 15 Aug 2014)


Log Message
[Cocoa] Add migrate-headers.sh and postprocess-headers.sh to WebKit.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=135984

Reviewed by Daniel Bates.

It's nice to be able to look at these files in Xcode.

* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (172630 => 172631)

--- trunk/Source/WebKit/ChangeLog	2014-08-15 17:36:05 UTC (rev 172630)
+++ trunk/Source/WebKit/ChangeLog	2014-08-15 17:38:47 UTC (rev 172631)
@@ -1,3 +1,14 @@
+2014-08-15  Andy Estes  aes...@apple.com
+
+[Cocoa] Add migrate-headers.sh and postprocess-headers.sh to WebKit.xcodeproj
+https://bugs.webkit.org/show_bug.cgi?id=135984
+
+Reviewed by Daniel Bates.
+
+It's nice to be able to look at these files in Xcode.
+
+* WebKit.xcodeproj/project.pbxproj:
+
 2014-08-15  Mark Rowe  mr...@apple.com
 
 https://webkit.org/b/135979 WebKit1 Plug-in test failures in clean builds after r172595


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (172630 => 172631)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2014-08-15 17:36:05 UTC (rev 172630)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2014-08-15 17:38:47 UTC (rev 172631)
@@ -775,6 +775,8 @@
 		A10C1D891820305E0036883A /* WebPDFViewPlaceholder.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = WebPDFViewPlaceholder.mm; path = ios/WebView/WebPDFViewPlaceholder.mm; sourceTree = SOURCE_ROOT; };
 		A10C1D8F1820307D0036883A /* WebKit.iOS.exp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.exports; name = WebKit.iOS.exp; path = ios/WebKit.iOS.exp; sourceTree = group; };
 		A17A11B0180DC84800E5498C /* WebPluginPackagePrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebPluginPackagePrivate.h; sourceTree = group; };
+		A182B74E199E7B8F001FD95A /* migrate-headers.sh */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.sh; name = migrate-headers.sh; path = mac/migrate-headers.sh; sourceTree = group; };
+		A182B74F199E7B8F001FD95A /* postprocess-headers.sh */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.sh; name = postprocess-headers.sh; path = mac/postprocess-headers.sh; sourceTree = group; };
 		A560946414D8AD2600799A8A /* WebIndicateLayer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebIndicateLayer.h; sourceTree = group; };
 		A560946514D8AD2600799A8A /* WebIndicateLayer.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebIndicateLayer.mm; sourceTree = group; };
 		A5687BD8135B791A0074CBCB /* WebNodeHighlighter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebNodeHighlighter.h; sourceTree = group; };
@@ -938,6 +940,8 @@
 319A3F4D1885E5FB00E0C900 /* WebKit.mac.exp */,
 A10C1D8F1820307D0036883A /* WebKit.iOS.exp */,
 F5C283730284676D018635CA /* WebKitPrefix.h */,
+A182B74E199E7B8F001FD95A /* migrate-headers.sh */,
+A182B74F199E7B8F001FD95A /* postprocess-headers.sh */,
 6508A4A7099B375F00BCBF45 /* Default Delegates */,
 F57D194A034E732C01A80180 /* DOM */,
 25A8176801B5474B0ECA149E /* History */,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172632] branches/safari-600.1.4.11-branch

2014-08-15 Thread lforschler

Title: [172632] branches/safari-600.1.4.11-branch








Revision 172632
Author lforsch...@apple.com
Date 2014-08-15 11:24:08 -0700 (Fri, 15 Aug 2014)


Log Message
Merged r171675.  rdar://problem/18022779

Modified Paths

branches/safari-600.1.4.11-branch/LayoutTests/ChangeLog
branches/safari-600.1.4.11-branch/Source/WebCore/ChangeLog
branches/safari-600.1.4.11-branch/Source/WebCore/css/SelectorChecker.cpp


Added Paths

branches/safari-600.1.4.11-branch/LayoutTests/fast/history/nested-visited-test-complex-expected.txt
branches/safari-600.1.4.11-branch/LayoutTests/fast/history/nested-visited-test-complex.html
branches/safari-600.1.4.11-branch/LayoutTests/fast/history/sibling-visited-test-complex-expected.txt
branches/safari-600.1.4.11-branch/LayoutTests/fast/history/sibling-visited-test-complex.html




Diff

Modified: branches/safari-600.1.4.11-branch/LayoutTests/ChangeLog (172631 => 172632)

--- branches/safari-600.1.4.11-branch/LayoutTests/ChangeLog	2014-08-15 17:38:47 UTC (rev 172631)
+++ branches/safari-600.1.4.11-branch/LayoutTests/ChangeLog	2014-08-15 18:24:08 UTC (rev 172632)
@@ -1,3 +1,26 @@
+2014-08-15  Lucas Forschler  lforsch...@apple.com
+
+Merge r171675
+
+2014-07-28  Yusuke Suzuki  utatane@gmail.com
+
+CSS: Fix :visited behavior for SubSelectors
+https://bugs.webkit.org/show_bug.cgi?id=135324
+
+Reviewed by Benjamin Poulain.
+
+Disable :visited match for the selectors that has SubSelectors.
+This `isSubSelector` (`context.firstSelectorOfTheFragment == context.selector`) is intended to
+check `relation != CSSSelector::SubSelector`.
+But since this value belongs to the previous selector and it is tested inside the branch that checks
+the next selector isn't SubSelector `relation != CSSSelector::SubSelector`,
+this only matches when the previous selector doesn't has SubSelectors.
+
+* fast/history/nested-visited-test-complex-expected.txt: Added.
+* fast/history/nested-visited-test-complex.html: Added.
+* fast/history/sibling-visited-test-complex-expected.txt: Added.
+* fast/history/sibling-visited-test-complex.html: Added.
+
 2014-08-07  Matthew Hanson  matthew_han...@apple.com
 
 Merge r172183. rdar://problem/17908085


Copied: branches/safari-600.1.4.11-branch/LayoutTests/fast/history/nested-visited-test-complex-expected.txt (from rev 171675, trunk/LayoutTests/fast/history/nested-visited-test-complex-expected.txt) (0 => 172632)

--- branches/safari-600.1.4.11-branch/LayoutTests/fast/history/nested-visited-test-complex-expected.txt	(rev 0)
+++ branches/safari-600.1.4.11-branch/LayoutTests/fast/history/nested-visited-test-complex-expected.txt	2014-08-15 18:24:08 UTC (rev 172632)
@@ -0,0 +1,9 @@
+These contents (not underline) of two links should be different colors (green and orange):
+
+One Two
+
+PASS firstStyle.color became different from secondStyle.color
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Copied: branches/safari-600.1.4.11-branch/LayoutTests/fast/history/nested-visited-test-complex.html (from rev 171675, trunk/LayoutTests/fast/history/nested-visited-test-complex.html) (0 => 172632)

--- branches/safari-600.1.4.11-branch/LayoutTests/fast/history/nested-visited-test-complex.html	(rev 0)
+++ branches/safari-600.1.4.11-branch/LayoutTests/fast/history/nested-visited-test-complex.html	2014-08-15 18:24:08 UTC (rev 172632)
@@ -0,0 +1,44 @@
+html
+head
+script src=""
+script
+jsTestIsAsync = true;
+
+if (window.testRunner)
+window.testRunner.keepWebHistory();
+
+function compareStyles()
+{
+var anchor = document.createElement(a);
+anchor.href=""
+anchor.setAttribute(id, one);
+anchor.classList.add(ok);
+anchor.classList.add(ng);
+anchor.innerHTML = One;
+document.getElementById('enclosure').appendChild(anchor);
+
+if (window.internals) {
+firstStyle = internals.computedStyleIncludingVisitedInfo(document.getElementById('one'));
+secondStyle = internals.computedStyleIncludingVisitedInfo(document.getElementById('two'));
+shouldBecomeDifferent('firstStyle.color', 'secondStyle.color', finishJSTest);
+}
+}
+/script
+style
+a { color: green }
+:visited.ok  a.ok { color: orange }
+:visited.ok  span.ok { color: orange }
+/style
+/head
+body _onload_=compareStyles()
+iframe src="" style=display:none/iframe
+
+pThese contents (not underline) of two links should be different colors (green and orange):/p
+p style=color:green
+a id=enclosure class=ok href=""
+a class=ok href="" class=ok id=twoTwo/span/a
+/p
+div id=console/div
+/body
+script src=""
+/html


Copied: branches/safari-600.1.4.11-branch/LayoutTests/fast/history/sibling-visited-test-complex-expected.txt (from rev 171675, trunk/LayoutTests/fast/history/sibling-visited-test-complex-expected.txt) (0 => 172632)

---

[webkit-changes] [172633] branches/safari-600.1.4.11-branch/Source

2014-08-15 Thread lforschler

Title: [172633] branches/safari-600.1.4.11-branch/Source








Revision 172633
Author lforsch...@apple.com
Date 2014-08-15 11:26:10 -0700 (Fri, 15 Aug 2014)


Log Message
Merged r172502.  rdar://problem/18022784

Modified Paths

branches/safari-600.1.4.11-branch/Source/WebCore/ChangeLog
branches/safari-600.1.4.11-branch/Source/WebCore/WebCore.exp.in
branches/safari-600.1.4.11-branch/Source/WebCore/platform/SharedBuffer.h
branches/safari-600.1.4.11-branch/Source/WebCore/platform/mac/SharedBufferMac.mm
branches/safari-600.1.4.11-branch/Source/WebKit2/ChangeLog
branches/safari-600.1.4.11-branch/Source/WebKit2/NetworkProcess/mac/NetworkResourceLoaderMac.mm




Diff

Modified: branches/safari-600.1.4.11-branch/Source/WebCore/ChangeLog (172632 => 172633)

--- branches/safari-600.1.4.11-branch/Source/WebCore/ChangeLog	2014-08-15 18:24:08 UTC (rev 172632)
+++ branches/safari-600.1.4.11-branch/Source/WebCore/ChangeLog	2014-08-15 18:26:10 UTC (rev 172633)
@@ -1,5 +1,26 @@
 2014-08-15  Lucas Forschler  lforsch...@apple.com
 
+Merge r172502
+
+2014-08-12  Pratik Solanki  psola...@apple.com
+
+Cached file backed resources don't make it to the Web Process when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
+https://bugs.webkit.org/show_bug.cgi?id=135727
+rdar://problem/17947880
+
+Reviewed by Darin Adler.
+
+Add SharedBuffer::existingCFData() which returns CFDataRef if it has one. Refactor
+this code out of createCFData().
+
+* WebCore.exp.in:
+* platform/SharedBuffer.h:
+* platform/mac/SharedBufferMac.mm:
+(WebCore::SharedBuffer::existingCFData): Added.
+(WebCore::SharedBuffer::createCFData):
+
+2014-08-15  Lucas Forschler  lforsch...@apple.com
+
 Merge r171675
 
 2014-07-28  Yusuke Suzuki  utatane@gmail.com


Modified: branches/safari-600.1.4.11-branch/Source/WebCore/WebCore.exp.in (172632 => 172633)

--- branches/safari-600.1.4.11-branch/Source/WebCore/WebCore.exp.in	2014-08-15 18:24:08 UTC (rev 172632)
+++ branches/safari-600.1.4.11-branch/Source/WebCore/WebCore.exp.in	2014-08-15 18:26:10 UTC (rev 172633)
@@ -242,6 +242,7 @@
 __ZN7WebCore12SharedBuffer11adoptVectorERN3WTF6VectorIcLm0ENS1_15CrashOnOverflowEEE
 __ZN7WebCore12SharedBuffer12createCFDataEv
 __ZN7WebCore12SharedBuffer12createNSDataEv
+__ZN7WebCore12SharedBuffer14existingCFDataEv
 __ZN7WebCore12SharedBuffer24createWithContentsOfFileERKN3WTF6StringE
 __ZN7WebCore12SharedBuffer6appendEPKcj
 __ZN7WebCore12SharedBuffer6appendEPS0_


Modified: branches/safari-600.1.4.11-branch/Source/WebCore/platform/SharedBuffer.h (172632 => 172633)

--- branches/safari-600.1.4.11-branch/Source/WebCore/platform/SharedBuffer.h	2014-08-15 18:24:08 UTC (rev 172632)
+++ branches/safari-600.1.4.11-branch/Source/WebCore/platform/SharedBuffer.h	2014-08-15 18:26:10 UTC (rev 172633)
@@ -74,6 +74,7 @@
 #endif
 #if USE(CF)
 RetainPtrCFDataRef createCFData();
+CFDataRef existingCFData();
 static PassRefPtrSharedBuffer wrapCFData(CFDataRef);
 #endif
 


Modified: branches/safari-600.1.4.11-branch/Source/WebCore/platform/mac/SharedBufferMac.mm (172632 => 172633)

--- branches/safari-600.1.4.11-branch/Source/WebCore/platform/mac/SharedBufferMac.mm	2014-08-15 18:24:08 UTC (rev 172632)
+++ branches/safari-600.1.4.11-branch/Source/WebCore/platform/mac/SharedBufferMac.mm	2014-08-15 18:26:10 UTC (rev 172633)
@@ -128,16 +128,24 @@
 return adoptNS((NSData *)createCFData().leakRef());
 }
 
-RetainPtrCFDataRef SharedBuffer::createCFData()
+CFDataRef SharedBuffer::existingCFData()
 {
 if (m_cfData)
-return m_cfData;
+return m_cfData.get();
 
 #if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
 if (m_dataArray.size() == 1)
-return m_dataArray.at(0);
+return m_dataArray.at(0).get();
 #endif
 
+return nullptr;
+}
+
+RetainPtrCFDataRef SharedBuffer::createCFData()
+{
+if (CFDataRef cfData = existingCFData())
+return cfData;
+
 #if ENABLE(DISK_IMAGE_CACHE)
 if (isMemoryMapped())
 return adoptCF((CFDataRef)adoptNS([[WebCoreSharedBufferData alloc] initWithMemoryMappedSharedBuffer:*this]).leakRef());


Modified: branches/safari-600.1.4.11-branch/Source/WebKit2/ChangeLog (172632 => 172633)

--- branches/safari-600.1.4.11-branch/Source/WebKit2/ChangeLog	2014-08-15 18:24:08 UTC (rev 172632)
+++ branches/safari-600.1.4.11-branch/Source/WebKit2/ChangeLog	2014-08-15 18:26:10 UTC (rev 172633)
@@ -1,3 +1,24 @@
+2014-08-15  Lucas Forschler  lforsch...@apple.com
+
+Merge r172502
+
+2014-08-12  Pratik Solanki  psola...@apple.com
+
+Cached file backed resources don't make it to the Web Process when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
+https://bugs.webkit.org/show_bug.cgi?id=135727
+rdar://problem/17947880
+
+Reviewed by Darin Adler.
+
+tryGetShareableHandleFromSharedBuffer() assumed that we have a file backed resource

[webkit-changes] [172634] trunk/Source/WebKit2

2014-08-15 Thread barraclough

Title: [172634] trunk/Source/WebKit2








Revision 172634
Author barraclo...@apple.com
Date 2014-08-15 11:26:34 -0700 (Fri, 15 Aug 2014)


Log Message
Fix plugin visibility initialization
https://bugs.webkit.org/show_bug.cgi?id=135985

Reviewed by Geoffrey Garen.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin):
- We're not currently initializing the plugin visibility state,
  and we're passing the wrong value for window visibility.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172633 => 172634)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 18:26:10 UTC (rev 172633)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 18:26:34 UTC (rev 172634)
@@ -1,5 +1,17 @@
 2014-08-15  Gavin Barraclough  barraclo...@apple.com
 
+Fix plugin visibility initialization
+https://bugs.webkit.org/show_bug.cgi?id=135985
+
+Reviewed by Geoffrey Garen.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::didInitializePlugin):
+- We're not currently initializing the plugin visibility state,
+  and we're passing the wrong value for window visibility.
+
+2014-08-15  Gavin Barraclough  barraclo...@apple.com
+
 Simplify visibility activity accounting for plugins
 https://bugs.webkit.org/show_bug.cgi?id=135981
 


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (172633 => 172634)

--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2014-08-15 18:26:10 UTC (rev 172633)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2014-08-15 18:26:34 UTC (rev 172634)
@@ -647,7 +647,8 @@
 m_pluginElement-dispatchPendingMouseClick();
 }
 
-m_plugin-windowVisibilityChanged(m_webPage-isVisible());
+m_plugin-visibilityDidChange(isVisible());
+m_plugin-windowVisibilityChanged(m_webPage-isVisibleOrOccluded());
 m_plugin-windowFocusChanged(m_webPage-windowIsFocused());
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172635] trunk/Source/WebKit2

2014-08-15 Thread timothy_horton

Title: [172635] trunk/Source/WebKit2








Revision 172635
Author timothy_hor...@apple.com
Date 2014-08-15 11:42:24 -0700 (Fri, 15 Aug 2014)


Log Message
REGRESSION (WebKit2 Gestures): White flash when swiping back to cnn.com's homepage from an article
https://bugs.webkit.org/show_bug.cgi?id=135951
rdar://problem/18006149

Reviewed by Simon Fraser.

Wait for (the first visually non-empty layout AND the render tree size threshold to be hit),
OR didFinishLoadForFrame, whichever comes first. Once we've done the first visually non-empty layout,
we'll start the watchdog and tear down the snapshot in three seconds no matter what.
Also, force a repaint so we can asynchronously wait for the Web Process to paint and return to us
before removing the snapshot, which improves our chances that something is actually on the screen.

* UIProcess/API/mac/WKView.mm:
(-[WKView _didFirstVisuallyNonEmptyLayoutForMainFrame]):
(-[WKView _didFinishLoadForMainFrame]):
(-[WKView _removeNavigationGestureSnapshot]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::removeNavigationGestureSnapshot):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
(WebKit::PageClientImpl::didFinishLoadForMainFrame):
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
(WebKit::PageClientImpl::didFinishLoadForMainFrame):
(WebKit::PageClientImpl::removeNavigationGestureSnapshot):
Plumb didFirstVisuallyNonEmptyLayoutForMainFrame and didFinishLoadForMainFrame
through to ViewGestureController from WebPageProxy via the PageClient, etc.

Ditto for removeNavigationGestureSnapshot, though it is called from a
VoidCallback in ViewGestureController instead of from WebFrameLoaderClient and friends.

* UIProcess/mac/ViewGestureController.h:
* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::endSwipeGesture):
When finishing a swipe, we want to wait for both the first visually non-empty layout
and the render tree size threshold being hit.

(WebKit::ViewGestureController::didHitRenderTreeSizeThreshold):
(WebKit::ViewGestureController::didFirstVisuallyNonEmptyLayoutForMainFrame):
When both of these things have happened, remove the swipe snapshot (after forcing a repaint).
For didFirstVisuallyNonEmptyLayoutForMainFrame, we will also start a watchdog
ensuring that we remove the snapshot in three seconds.

(WebKit::ViewGestureController::didFinishLoadForMainFrame):
When didFinishLoadForMainFrame happens, remove the swipe snapshot (after forcing a repaint).

(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
If the watchdog timer fires, remove the swipe snapshot (after forcing a repaint).

(WebKit::ViewGestureController::removeSwipeSnapshotAfterRepaint):
Force a repaint and wait for the async callback before removing the snapshot.
It is safe to hold on to the WebPageProxy here because it will always
call all of its callbacks before it is destroyed.
Avoid enqueuing multiple force-repaints.

(WebKit::ViewGestureController::removeSwipeSnapshot):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h
trunk/Source/WebKit2/UIProcess/PageClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm
trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h
trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172634 => 172635)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 18:26:34 UTC (rev 172634)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 18:42:24 UTC (rev 172635)
@@ -1,3 +1,70 @@
+2014-08-15  Tim Horton  timothy_hor...@apple.com
+
+REGRESSION (WebKit2 Gestures): White flash when swiping back to cnn.com's homepage from an article
+https://bugs.webkit.org/show_bug.cgi?id=135951
+rdar://problem/18006149
+
+Reviewed by Simon Fraser.
+
+Wait for (the first visually non-empty layout AND the render tree size threshold to be hit),
+OR didFinishLoadForFrame, whichever comes first. Once we've done the first visually non-empty layout,
+we'll start the watchdog and tear down the snapshot in three seconds no matter what.
+Also, force a repaint so we can asynchronously wait for the Web Process to paint and return to us
+before

[webkit-changes] [172636] trunk/Source/WebKit2

2014-08-15 Thread timothy_horton

Title: [172636] trunk/Source/WebKit2








Revision 172636
Author timothy_hor...@apple.com
Date 2014-08-15 11:47:51 -0700 (Fri, 15 Aug 2014)


Log Message
Service overlays stay fixed when iframe scrolls
https://bugs.webkit.org/show_bug.cgi?id=135959
rdar://problem/17957716

Reviewed by Enrica Casucci.

* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::didScrollFrame):
* WebProcess/WebPage/PageOverlay.h:
(WebKit::PageOverlay::Client::didScrollFrame):
* WebProcess/WebPage/PageOverlayController.cpp:
(WebKit::PageOverlayController::didScrollFrame):
Push didScrollFrame down to the overlays.

* WebProcess/WebPage/ServicesOverlayController.h:
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::Highlight::createForSelection):
Hold on to the selection's Range so we can use it to compare Highlights later.

(WebKit::ServicesOverlayController::Highlight::Highlight):
(WebKit::ServicesOverlayController::Highlight::setDDHighlight):
Factor the code to set up and paint the highlight out, so that we can
set a new DDHighlightRef on a Highlight and the layer moves/reshapes/repaints.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
(WebKit::ServicesOverlayController::buildSelectionHighlight):
(WebKit::ServicesOverlayController::replaceHighlightsOfTypePreservingEquivalentHighlights):
Factor replaceHighlightsOfTypePreservingEquivalentHighlights out
so that we can use it for buildSelectionHighlight as well.

Steal the DDHighlightRef from the new Highlight when re-using an old one
so that the newly computed rects are used instead of the old ones.

(WebKit::ServicesOverlayController::highlightsAreEquivalent):
We will always have a Range now, so we can always check equivalence using it.

(WebKit::ServicesOverlayController::didScrollFrame):
Rebuild all highlights upon subframe scroll, as they might have moved.
We could optimize this in the future, but for now it's cheap enough
and rare enough that it doesn't matter.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp
trunk/Source/WebKit2/WebProcess/WebPage/PageOverlay.h
trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp
trunk/Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172635 => 172636)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 18:42:24 UTC (rev 172635)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 18:47:51 UTC (rev 172636)
@@ -1,5 +1,48 @@
 2014-08-15  Tim Horton  timothy_hor...@apple.com
 
+Service overlays stay fixed when iframe scrolls
+https://bugs.webkit.org/show_bug.cgi?id=135959
+rdar://problem/17957716
+
+Reviewed by Enrica Casucci.
+
+* WebProcess/WebPage/PageOverlay.cpp:
+(WebKit::PageOverlay::didScrollFrame):
+* WebProcess/WebPage/PageOverlay.h:
+(WebKit::PageOverlay::Client::didScrollFrame):
+* WebProcess/WebPage/PageOverlayController.cpp:
+(WebKit::PageOverlayController::didScrollFrame):
+Push didScrollFrame down to the overlays.
+
+* WebProcess/WebPage/ServicesOverlayController.h:
+* WebProcess/WebPage/mac/ServicesOverlayController.mm:
+(WebKit::ServicesOverlayController::Highlight::createForSelection):
+Hold on to the selection's Range so we can use it to compare Highlights later.
+
+(WebKit::ServicesOverlayController::Highlight::Highlight):
+(WebKit::ServicesOverlayController::Highlight::setDDHighlight):
+Factor the code to set up and paint the highlight out, so that we can
+set a new DDHighlightRef on a Highlight and the layer moves/reshapes/repaints.
+
+(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
+(WebKit::ServicesOverlayController::buildSelectionHighlight):
+(WebKit::ServicesOverlayController::replaceHighlightsOfTypePreservingEquivalentHighlights):
+Factor replaceHighlightsOfTypePreservingEquivalentHighlights out
+so that we can use it for buildSelectionHighlight as well.
+
+Steal the DDHighlightRef from the new Highlight when re-using an old one
+so that the newly computed rects are used instead of the old ones.
+
+(WebKit::ServicesOverlayController::highlightsAreEquivalent):
+We will always have a Range now, so we can always check equivalence using it.
+
+(WebKit::ServicesOverlayController::didScrollFrame):
+Rebuild all highlights upon subframe scroll, as they might have moved.
+We could optimize this in the future, but for now it's cheap enough
+and rare enough that it doesn't matter.
+
+2014-08-15  Tim Horton  timothy_hor...@apple.com
+
 REGRESSION (WebKit2 Gestures): White flash when swiping back to cnn.com's homepage from an article
 https://bugs.webkit.org/show_bug.cgi?id=135951

[webkit-changes] [172637] trunk/Source/WebKit2

2014-08-15 Thread barraclough

Title: [172637] trunk/Source/WebKit2








Revision 172637
Author barraclo...@apple.com
Date 2014-08-15 11:56:52 -0700 (Fri, 15 Aug 2014)


Log Message
de-PLATFORM(COCOA) a couple of methods in plugin code
https://bugs.webkit.org/show_bug.cgi?id=135987

Reviewed by Sam Weinig.

Pass through the visibility  focus on all platforms, to simplify  avoid
any weird inconsistencies between platforms.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::windowFocusChanged):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::windowFocusChanged): Deleted.
(WebKit::PluginControllerProxy::windowVisibilityChanged): Deleted.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::windowVisibilityChanged):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::windowAndViewFramesChanged):
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewStateDidChange):
(WebKit::PluginView::platformViewStateDidChange): Deleted.
* WebProcess/Plugins/PluginView.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in
trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172636 => 172637)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 18:47:51 UTC (rev 172636)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 18:56:52 UTC (rev 172637)
@@ -1,3 +1,34 @@
+2014-08-15  Gavin Barraclough  barraclo...@apple.com
+
+de-PLATFORM(COCOA) a couple of methods in plugin code
+https://bugs.webkit.org/show_bug.cgi?id=135987
+
+Reviewed by Sam Weinig.
+
+Pass through the visibility  focus on all platforms, to simplify  avoid
+any weird inconsistencies between platforms.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::windowFocusChanged):
+(WebKit::PluginControllerProxy::windowVisibilityChanged):
+* PluginProcess/PluginControllerProxy.h:
+* PluginProcess/PluginControllerProxy.messages.in:
+* PluginProcess/mac/PluginControllerProxyMac.mm:
+(WebKit::PluginControllerProxy::windowFocusChanged): Deleted.
+(WebKit::PluginControllerProxy::windowVisibilityChanged): Deleted.
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::windowFocusChanged):
+(WebKit::NetscapePlugin::windowVisibilityChanged):
+* WebProcess/Plugins/Netscape/NetscapePlugin.h:
+* WebProcess/Plugins/Plugin.h:
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::windowAndViewFramesChanged):
+* WebProcess/Plugins/PluginProxy.h:
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::viewStateDidChange):
+(WebKit::PluginView::platformViewStateDidChange): Deleted.
+* WebProcess/Plugins/PluginView.h:
+
 2014-08-15  Tim Horton  timothy_hor...@apple.com
 
 Service overlays stay fixed when iframe scrolls


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (172636 => 172637)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2014-08-15 18:47:51 UTC (rev 172636)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2014-08-15 18:56:52 UTC (rev 172637)
@@ -434,6 +434,23 @@
 m_plugin-visibilityDidChange(isVisible);
 }
 
+void PluginControllerProxy::windowFocusChanged(bool hasFocus)
+{
+ASSERT(m_plugin);
+m_plugin-windowFocusChanged(hasFocus);
+}
+
+void PluginControllerProxy::windowVisibilityChanged(bool isVisible)
+{
+ASSERT(m_plugin);
+m_plugin-windowVisibilityChanged(isVisible);
+
+if (isVisible)
+m_visiblityActivity.start();
+else
+m_visiblityActivity.stop();
+}
+
 void PluginControllerProxy::didEvaluateJavaScript(uint64_t requestID, const String result)
 {
 m_plugin-didEvaluateJavaScript(requestID, result);


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h (172636 => 172637)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h	2014-08-15 18:47:51 UTC (rev 172636)
+++

[webkit-changes] [172638] trunk/Tools

2014-08-15 Thread commit-queue

Title: [172638] trunk/Tools








Revision 172638
Author commit-qu...@webkit.org
Date 2014-08-15 12:03:59 -0700 (Fri, 15 Aug 2014)


Log Message
run-webkit-tests should skip 'support' directories
https://bugs.webkit.org/show_bug.cgi?id=135910

Patch by Rebecca Hauck rha...@adobe.com on 2014-08-15
Reviewed by Bem Jones-Bey.

This patch adds the 'support' directory to the list
of dirs to skip when looking for runnable tests.
the W3C uses this name for support files, so tests
imported from the W3C will not work without this change
or without many edits.

* Scripts/webkitpy/port/base.py:
(Port._real_tests):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/base.py




Diff

Modified: trunk/Tools/ChangeLog (172637 => 172638)

--- trunk/Tools/ChangeLog	2014-08-15 18:56:52 UTC (rev 172637)
+++ trunk/Tools/ChangeLog	2014-08-15 19:03:59 UTC (rev 172638)
@@ -1,3 +1,19 @@
+2014-08-15  Rebecca Hauck  rha...@adobe.com
+
+run-webkit-tests should skip 'support' directories
+https://bugs.webkit.org/show_bug.cgi?id=135910
+
+Reviewed by Bem Jones-Bey.
+
+This patch adds the 'support' directory to the list
+of dirs to skip when looking for runnable tests.
+the W3C uses this name for support files, so tests
+imported from the W3C will not work without this change
+or without many edits.
+
+* Scripts/webkitpy/port/base.py:
+(Port._real_tests):
+
 2014-08-14  Brent Fulgham  bfulg...@apple.com
 
 [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion


Modified: trunk/Tools/Scripts/webkitpy/port/base.py (172637 => 172638)

--- trunk/Tools/Scripts/webkitpy/port/base.py	2014-08-15 18:56:52 UTC (rev 172637)
+++ trunk/Tools/Scripts/webkitpy/port/base.py	2014-08-15 19:03:59 UTC (rev 172638)
@@ -543,7 +543,7 @@
 
 def _real_tests(self, paths):
 # When collecting test cases, skip these directories
-skipped_directories = set(['.svn', '_svn', 'resources', 'script-tests', 'reference', 'reftest'])
+skipped_directories = set(['.svn', '_svn', 'resources', 'support', 'script-tests', 'reference', 'reftest'])
 files = find_files.find(self._filesystem, self.layout_tests_dir(), paths, skipped_directories, Port._is_test_file, self.test_key)
 return [self.relative_test_filename(f) for f in files]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172639] trunk/Source/WebKit2

2014-08-15 Thread timothy_horton

Title: [172639] trunk/Source/WebKit2








Revision 172639
Author timothy_hor...@apple.com
Date 2014-08-15 12:10:04 -0700 (Fri, 15 Aug 2014)


Log Message
Service overlays stay fixed when iframe scrolls
https://bugs.webkit.org/show_bug.cgi?id=135959
rdar://problem/17957716

Reviewed by Enrica Casucci.

* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::highlightsAreEquivalent):
Tiny correctness fix; highlights can only be equivalent if their
types are equivalent as well.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172638 => 172639)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 19:03:59 UTC (rev 172638)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 19:10:04 UTC (rev 172639)
@@ -1,3 +1,16 @@
+2014-08-15  Tim Horton  timothy_hor...@apple.com
+
+Service overlays stay fixed when iframe scrolls
+https://bugs.webkit.org/show_bug.cgi?id=135959
+rdar://problem/17957716
+
+Reviewed by Enrica Casucci.
+
+* WebProcess/WebPage/mac/ServicesOverlayController.mm:
+(WebKit::ServicesOverlayController::highlightsAreEquivalent):
+Tiny correctness fix; highlights can only be equivalent if their
+types are equivalent as well.
+
 2014-08-15  Gavin Barraclough  barraclo...@apple.com
 
 de-PLATFORM(COCOA) a couple of methods in plugin code


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm (172638 => 172639)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm	2014-08-15 19:03:59 UTC (rev 172638)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm	2014-08-15 19:10:04 UTC (rev 172639)
@@ -613,7 +613,7 @@
 if (!a || !b)
 return false;
 
-if (areRangesEqual(a-range(), b-range()))
+if (a-type() == b-type()  areRangesEqual(a-range(), b-range()))
 return true;
 
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172640] trunk/Source/WebInspectorUI

2014-08-15 Thread timothy

Title: [172640] trunk/Source/WebInspectorUI








Revision 172640
Author timo...@apple.com
Date 2014-08-15 12:11:55 -0700 (Fri, 15 Aug 2014)


Log Message
Web Inspector: Legacy Mac toolbar appearance looks wrong
https://bugs.webkit.org/show_bug.cgi?id=135962

Reviewed by Joseph Pecoraro.

* UserInterface/Views/Toolbar.css:
(body.mac-platform.legacy .toolbar): Don't draw a gradient background when not docked.
Move border-bottom-color from body.mac-platform.legacy.docked .toolbar to here so it
applies all the time as it should have.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (172639 => 172640)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-08-15 19:10:04 UTC (rev 172639)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-08-15 19:11:55 UTC (rev 172640)
@@ -1,3 +1,15 @@
+2014-08-15  Timothy Hatcher  timo...@apple.com
+
+Web Inspector: Legacy Mac toolbar appearance looks wrong
+https://bugs.webkit.org/show_bug.cgi?id=135962
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/Toolbar.css:
+(body.mac-platform.legacy .toolbar): Don't draw a gradient background when not docked.
+Move border-bottom-color from body.mac-platform.legacy.docked .toolbar to here so it
+applies all the time as it should have.
+
 2014-08-14  Joseph Pecoraro  pecor...@apple.com
 
 Web Inspector: Dragging Undocked inspector by window title has broken behavior


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (172639 => 172640)

--- trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2014-08-15 19:10:04 UTC (rev 172639)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2014-08-15 19:11:55 UTC (rev 172640)
@@ -85,10 +85,11 @@
 
 body.mac-platform.legacy .toolbar {
 box-shadow: none;
+background-image: none;
+border-bottom-color: rgb(85, 85, 85);
 }
 
 body.mac-platform.legacy.docked .toolbar {
-border-bottom-color: rgb(85, 85, 85);
 background-image: linear-gradient(to bottom, rgb(216, 216, 216), rgb(190, 190, 190));
 box-shadow: inset rgba(255, 255, 255, 0.1) 0 1px 0, inset rgba(0, 0, 0, 0.02) 0 -1px 0;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172641] trunk

2014-08-15 Thread krit

Title: [172641] trunk








Revision 172641
Author k...@webkit.org
Date 2014-08-15 12:38:10 -0700 (Fri, 15 Aug 2014)


Log Message
Turn cx/cy to presentation attributes
https://bugs.webkit.org/show_bug.cgi?id=135975

Reviewed by Dean Jackson.

This follows the patch for width and height presentation attributes and
Source/WebCore:

turns x and y to presentation attributes as well:

http://trac.webkit.org/changeset/171341

Extended existing tests.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSPropertyNames.in:
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* rendering/style/RenderStyle.h:
* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::setCx):
(WebCore::SVGRenderStyle::setCy):
(WebCore::SVGRenderStyle::cx):
(WebCore::SVGRenderStyle::cy):
* rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::StyleLayoutData::StyleLayoutData):
(WebCore::StyleLayoutData::operator==):
* rendering/style/SVGRenderStyleDefs.h:
* rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
* rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromCircleElement):
(WebCore::updatePathFromEllipseElement):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged):
(WebCore::SVGCircleElement::selfHasRelativeLengths): Deleted.
* svg/SVGCircleElement.h:
* svg/SVGElement.cpp:
(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged):
(WebCore::SVGEllipseElement::selfHasRelativeLengths): Deleted.
* svg/SVGEllipseElement.h:

LayoutTests:

turns cx and cy to presentation attributes as well:

http://trac.webkit.org/changeset/171341

* svg/css/parse-length-expected.txt:
* svg/css/parse-length.html:
* transitions/svg-layout-transition-expected.txt:
* transitions/svg-layout-transition.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/css/parse-length-expected.txt
trunk/LayoutTests/svg/css/parse-length.html
trunk/LayoutTests/transitions/svg-layout-transition-expected.txt
trunk/LayoutTests/transitions/svg-layout-transition.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp
trunk/Source/WebCore/css/SVGCSSParser.cpp
trunk/Source/WebCore/css/SVGCSSPropertyNames.in
trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/SVGRenderStyle.h
trunk/Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp
trunk/Source/WebCore/rendering/style/SVGRenderStyleDefs.h
trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp
trunk/Source/WebCore/rendering/svg/SVGPathData.cpp
trunk/Source/WebCore/svg/SVGCircleElement.cpp
trunk/Source/WebCore/svg/SVGCircleElement.h
trunk/Source/WebCore/svg/SVGElement.cpp
trunk/Source/WebCore/svg/SVGEllipseElement.cpp
trunk/Source/WebCore/svg/SVGEllipseElement.h




Diff

Modified: trunk/LayoutTests/ChangeLog (172640 => 172641)

--- trunk/LayoutTests/ChangeLog	2014-08-15 19:11:55 UTC (rev 172640)
+++ trunk/LayoutTests/ChangeLog	2014-08-15 19:38:10 UTC (rev 172641)
@@ -1,3 +1,20 @@
+2014-08-15  Dirk Schulze  k...@webkit.org
+
+Turn cx/cy to presentation attributes
+https://bugs.webkit.org/show_bug.cgi?id=135975
+
+Reviewed by Dean Jackson.
+
+This follows the patch for width and height presentation attributes and
+turns cx and cy to presentation attributes as well:
+
+http://trac.webkit.org/changeset/171341
+
+* svg/css/parse-length-expected.txt:
+* svg/css/parse-length.html:
+* transitions/svg-layout-transition-expected.txt:
+* transitions/svg-layout-transition.html:
+
 2014-08-14  Benjamin Poulain  benja...@webkit.org
 
 CSS JIT: compile the :empty pseudo class


Modified: trunk/LayoutTests/svg/css/parse-length-expected.txt (172640 => 172641)

--- trunk/LayoutTests/svg/css/parse-length-expected.txt	2014-08-15 19:11:55 UTC (rev 172640)
+++ trunk/LayoutTests/svg/css/parse-length-expected.txt	2014-08-15 19:38:10 UTC (rev 172641)
@@ -25,6 +25,20 @@
 On success, you will see a series of PASS messages, followed by TEST COMPLETE.
 
 
+PASS computedStyle(cx,   100) is 100px
+PASS computedStyle(cx, 100   ) is 100px
+PASS computedStyle(cx, 100px) is 100px
+PASS computedStyle(cx, 1em) is 16px
+PASS computedStyle(cx, 1ex) is 12.80190734863px
+PASS computedStyle(cx, 20%) is 20%
+PASS computedStyle(cx, -200px) is -200px
+PASS computedStyle(cy,   100) is 100px
+PASS

[webkit-changes] [172642] trunk

2014-08-15 Thread krit

Title: [172642] trunk








Revision 172642
Author k...@webkit.org
Date 2014-08-15 12:42:38 -0700 (Fri, 15 Aug 2014)


Log Message
Turn r/rx/ry to presentation attributes
https://bugs.webkit.org/show_bug.cgi?id=135978

Patch by Dirk Schulze k...@webkit.org on 2014-08-15
Reviewed by Dean Jackson.

This follows the patch for width and height presentation attributes and
Source/WebCore:

turns rx, ry and r to presentation attributes as well:

http://trac.webkit.org/changeset/171341

Extended existing tests.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSPropertyNames.in:
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* rendering/style/RenderStyle.h:
* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::setR):
(WebCore::SVGRenderStyle::setRx):
(WebCore::SVGRenderStyle::setRy):
(WebCore::SVGRenderStyle::r):
(WebCore::SVGRenderStyle::rx):
(WebCore::SVGRenderStyle::ry):
* rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::StyleLayoutData::StyleLayoutData):
(WebCore::StyleLayoutData::operator==):
* rendering/style/SVGRenderStyleDefs.h:
* rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
* rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromCircleElement):
(WebCore::updatePathFromEllipseElement):
(WebCore::updatePathFromRectElement):
(WebCore::updatePathFromLineElement): Deleted.
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged):
* svg/SVGElement.cpp:
(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::svgAttributeChanged):

LayoutTests:

turns r, rx and ry to presentation attributes as well:

http://trac.webkit.org/changeset/171341

* svg/css/parse-length.html:
* transitions/svg-layout-transition-expected.txt:
* transitions/svg-layout-transition.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/css/parse-length.html
trunk/LayoutTests/transitions/svg-layout-transition-expected.txt
trunk/LayoutTests/transitions/svg-layout-transition.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp
trunk/Source/WebCore/css/SVGCSSParser.cpp
trunk/Source/WebCore/css/SVGCSSPropertyNames.in
trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/SVGRenderStyle.h
trunk/Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp
trunk/Source/WebCore/rendering/style/SVGRenderStyleDefs.h
trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp
trunk/Source/WebCore/rendering/svg/SVGPathData.cpp
trunk/Source/WebCore/svg/SVGCircleElement.cpp
trunk/Source/WebCore/svg/SVGElement.cpp
trunk/Source/WebCore/svg/SVGEllipseElement.cpp
trunk/Source/WebCore/svg/SVGRectElement.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (172641 => 172642)

--- trunk/LayoutTests/ChangeLog	2014-08-15 19:38:10 UTC (rev 172641)
+++ trunk/LayoutTests/ChangeLog	2014-08-15 19:42:38 UTC (rev 172642)
@@ -1,5 +1,21 @@
 2014-08-15  Dirk Schulze  k...@webkit.org
 
+Turn r/rx/ry to presentation attributes
+https://bugs.webkit.org/show_bug.cgi?id=135978
+
+Reviewed by Dean Jackson.
+
+This follows the patch for width and height presentation attributes and
+turns r, rx and ry to presentation attributes as well:
+
+http://trac.webkit.org/changeset/171341
+
+* svg/css/parse-length.html:
+* transitions/svg-layout-transition-expected.txt:
+* transitions/svg-layout-transition.html:
+
+2014-08-15  Dirk Schulze  k...@webkit.org
+
 Turn cx/cy to presentation attributes
 https://bugs.webkit.org/show_bug.cgi?id=135975
 


Modified: trunk/LayoutTests/svg/css/parse-length.html (172641 => 172642)

--- trunk/LayoutTests/svg/css/parse-length.html	2014-08-15 19:38:10 UTC (rev 172641)
+++ trunk/LayoutTests/svg/css/parse-length.html	2014-08-15 19:42:38 UTC (rev 172642)
@@ -50,6 +50,33 @@
 testComputed(cy, 20%, 20%);
 testComputed(cy, -200px, -200px);
 
+// Test 'r'.
+testComputed(r,   100, 100px);
+testComputed(r, 100   , 100px);
+testComputed(r, 100px, 100px);
+testComputed(r, 1em, 16px);
+testComputed(r, 1ex, 12.80190734863px);
+testComputed(r, 20%, 20%);
+testComputed(r, -200px, -200px);
+
+// Test 'rx'.
+testComputed(rx,   100, 100px);
+testComputed(rx, 100   , 100px);
+testComputed(rx, 100px, 100px);
+testComputed(rx, 1em, 16px);
+testComputed(rx,

[webkit-changes] [172643] trunk/Source/WebKit2

2014-08-15 Thread enrica

Title: [172643] trunk/Source/WebKit2








Revision 172643
Author enr...@apple.com
Date 2014-08-15 12:53:19 -0700 (Fri, 15 Aug 2014)


Log Message
[Services with UI] Selections are incorrect when selecting three lines.
https://bugs.webkit.org/show_bug.cgi?id=135989
rdar://problem/18032571

Reviewed by Tim Horton.

The stitching algorithm did not handle correctly the case of selections
over three lines if the middle line is composed of only one rectangle.

* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::stitchRects):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172642 => 172643)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 19:42:38 UTC (rev 172642)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 19:53:19 UTC (rev 172643)
@@ -1,3 +1,17 @@
+2014-08-15  Enrica Casucci  enr...@apple.com
+
+[Services with UI] Selections are incorrect when selecting three lines.
+https://bugs.webkit.org/show_bug.cgi?id=135989
+rdar://problem/18032571
+
+Reviewed by Tim Horton.
+
+The stitching algorithm did not handle correctly the case of selections
+over three lines if the middle line is composed of only one rectangle.
+
+* WebProcess/WebPage/mac/ServicesOverlayController.mm:
+(WebKit::stitchRects):
+
 2014-08-15  Tim Horton  timothy_hor...@apple.com
 
 Service overlays stay fixed when iframe scrolls


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm (172642 => 172643)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm	2014-08-15 19:42:38 UTC (rev 172642)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm	2014-08-15 19:53:19 UTC (rev 172643)
@@ -279,7 +279,7 @@
 // First stitch together all the rects on the first line of the selection.
 size_t indexFromStart = 0;
 LayoutUnit firstTop = rects[indexFromStart].y();
-LayoutRect currentRect = rects[indexFromStart++];
+LayoutRect currentRect = rects[indexFromStart];
 while (indexFromStart  rects.size()  rects[indexFromStart].y() == firstTop)
 currentRect.unite(rects[indexFromStart++]);
 
@@ -294,18 +294,22 @@
 size_t indexFromEnd = rects.size() - 1;
 LayoutUnit lastTop = rects[indexFromEnd].y();
 LayoutRect lastRect = rects[indexFromEnd];
-while (indexFromEnd != indexFromStart  rects[--indexFromEnd].y() == lastTop)
-lastRect.unite(rects[indexFromEnd]);
+while (indexFromEnd = indexFromStart  rects[indexFromEnd].y() == lastTop)
+lastRect.unite(rects[indexFromEnd--]);
 
-if (indexFromEnd == indexFromStart) {
-// All the rects are on two lines only. There is nothing else to do.
+// indexFromStart is the index of the first rectangle on the second line.
+// indexFromEnd is the index of the last rectangle on the second to the last line.
+// if they are equal, there is one additional rectangle for the line in the middle.
+if (indexFromEnd == indexFromStart)
+newRects.append(rects[indexFromStart]);
+
+if (indexFromEnd = indexFromStart) {
+// There are no more rects to stitch. Just append the last line.
 newRects.append(lastRect);
 rects.swap(newRects);
 return;
 }
 
-// indexFromStart is the index of the first rectangle on the second line.
-// indexFromEnd is the index of the last rectangle on the second to the last line.
 // Stitch together all the rects after the first line until the second to the last included.
 currentRect = rects[indexFromStart];
 while (indexFromStart != indexFromEnd)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172644] branches/safari-600.1-branch/Source

2014-08-15 Thread dburkart

Title: [172644] branches/safari-600.1-branch/Source








Revision 172644
Author dburk...@apple.com
Date 2014-08-15 13:12:32 -0700 (Fri, 15 Aug 2014)


Log Message
Bump versioning.

Modified Paths

branches/safari-600.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-600.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-600.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-600.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-600.1-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-600.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (172643 => 172644)

--- branches/safari-600.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-15 19:53:19 UTC (rev 172643)
+++ branches/safari-600.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-15 20:12:32 UTC (rev 172644)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.1-branch/Source/WebCore/Configurations/Version.xcconfig (172643 => 172644)

--- branches/safari-600.1-branch/Source/WebCore/Configurations/Version.xcconfig	2014-08-15 19:53:19 UTC (rev 172643)
+++ branches/safari-600.1-branch/Source/WebCore/Configurations/Version.xcconfig	2014-08-15 20:12:32 UTC (rev 172644)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (172643 => 172644)

--- branches/safari-600.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-15 19:53:19 UTC (rev 172643)
+++ branches/safari-600.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-15 20:12:32 UTC (rev 172644)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig (172643 => 172644)

--- branches/safari-600.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-15 19:53:19 UTC (rev 172643)
+++ branches/safari-600.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-15 20:12:32 UTC (rev 172644)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.1-branch/Source/WebKit2/Configurations/Version.xcconfig (172643 => 172644)

--- branches/safari-600.1-branch/Source/WebKit2/Configurations/Version.xcconfig	2014-08-15 19:53:19 UTC (rev 172643)
+++ branches/safari-600.1-branch/Source/WebKit2/Configurations/Version.xcconfig	2014-08-15 20:12:32 UTC (rev 172644)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172645] trunk/Source/WebKit2

2014-08-15 Thread barraclough

Title: [172645] trunk/Source/WebKit2








Revision 172645
Author barraclo...@apple.com
Date 2014-08-15 13:32:14 -0700 (Fri, 15 Aug 2014)


Log Message
Fix plugin visibility check.
https://bugs.webkit.org/show_bug.cgi?id=135991

Reviewed by Andreas Kling.

We should only take a UserActivity if the plugin is in a visible window,
and also is itself visible.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
- initialize member state.
(WebKit::PluginControllerProxy::visibilityDidChange):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
- update member state  call updateVisiblityActivity.
(WebKit::PluginControllerProxy::updateVisiblityActivity):
- enable the UserActivity only if both visibilities are true.
* PluginProcess/PluginControllerProxy.h:
- added m_isVisible, m_isWindowVisible, updateVisibilityActivity.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172644 => 172645)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 20:12:32 UTC (rev 172644)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 20:32:14 UTC (rev 172645)
@@ -1,3 +1,24 @@
+2014-08-15  Gavin Barraclough  barraclo...@apple.com
+
+Fix plugin visibility check.
+https://bugs.webkit.org/show_bug.cgi?id=135991
+
+Reviewed by Andreas Kling.
+
+We should only take a UserActivity if the plugin is in a visible window,
+and also is itself visible.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::PluginControllerProxy):
+- initialize member state.
+(WebKit::PluginControllerProxy::visibilityDidChange):
+(WebKit::PluginControllerProxy::windowVisibilityChanged):
+- update member state  call updateVisiblityActivity.
+(WebKit::PluginControllerProxy::updateVisiblityActivity):
+- enable the UserActivity only if both visibilities are true.
+* PluginProcess/PluginControllerProxy.h:
+- added m_isVisible, m_isWindowVisible, updateVisibilityActivity.
+
 2014-08-15  Enrica Casucci  enr...@apple.com
 
 [Services with UI] Selections are incorrect when selecting three lines.


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (172644 => 172645)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2014-08-15 20:12:32 UTC (rev 172644)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2014-08-15 20:32:14 UTC (rev 172645)
@@ -61,6 +61,8 @@
 , m_isPrivateBrowsingEnabled(creationParameters.isPrivateBrowsingEnabled)
 , m_isAcceleratedCompositingEnabled(creationParameters.isAcceleratedCompositingEnabled)
 , m_isInitializing(false)
+, m_isVisibile(false)
+, m_isWindowVisibile(false)
 , m_paintTimer(RunLoop::main(), this, PluginControllerProxy::paint)
 , m_pluginDestructionProtectCount(0)
 , m_pluginDestroyTimer(RunLoop::main(), this, PluginControllerProxy::destroy)
@@ -430,8 +432,12 @@
 
 void PluginControllerProxy::visibilityDidChange(bool isVisible)
 {
+m_isVisibile = isVisible;
+
 ASSERT(m_plugin);
 m_plugin-visibilityDidChange(isVisible);
+
+updateVisiblityActivity();
 }
 
 void PluginControllerProxy::windowFocusChanged(bool hasFocus)
@@ -442,10 +448,17 @@
 
 void PluginControllerProxy::windowVisibilityChanged(bool isVisible)
 {
+m_isWindowVisibile = isVisible;
+
 ASSERT(m_plugin);
 m_plugin-windowVisibilityChanged(isVisible);
 
-if (isVisible)
+updateVisiblityActivity();
+}
+
+void PluginControllerProxy::updateVisiblityActivity()
+{
+if (m_isVisibile  m_isWindowVisibile)
 m_visiblityActivity.start();
 else
 m_visiblityActivity.stop();


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h (172644 => 172645)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h	2014-08-15 20:12:32 UTC (rev 172644)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h	2014-08-15 20:32:14 UTC (rev 172645)
@@ -151,6 +151,7 @@
 
 void windowFocusChanged(bool);
 void windowVisibilityChanged(bool);
+void updateVisiblityActivity();
 
 #if PLATFORM(COCOA)
 void windowAndViewFramesChanged(const WebCore::IntRect windowFrameInScreenCoordinates, const WebCore::IntRect viewFrameInWindowCoordinates);
@@ -176,6 +177,8 @@
 bool m_isPrivateBrowsingEnabled;
 bool m_isAcceleratedCompositingEnabled;
 bool m_isInitializing;
+bool m_isVisibile;
+bool m_isWindowVisibile;
 
 RefPtrMessages::WebProcessConnection::CreatePlugin::DelayedReply m_initializationReply;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172646] trunk/Source/WebKit2

2014-08-15 Thread barraclough

Title: [172646] trunk/Source/WebKit2








Revision 172646
Author barraclo...@apple.com
Date 2014-08-15 13:37:15 -0700 (Fri, 15 Aug 2014)


Log Message
Fix plugin visibility check.
https://bugs.webkit.org/show_bug.cgi?id=135991

Unreviewed typo fix.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::visibilityDidChange):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
(WebKit::PluginControllerProxy::updateVisiblityActivity):
* PluginProcess/PluginControllerProxy.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172645 => 172646)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 20:32:14 UTC (rev 172645)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 20:37:15 UTC (rev 172646)
@@ -3,6 +3,20 @@
 Fix plugin visibility check.
 https://bugs.webkit.org/show_bug.cgi?id=135991
 
+Unreviewed typo fix.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::PluginControllerProxy):
+(WebKit::PluginControllerProxy::visibilityDidChange):
+(WebKit::PluginControllerProxy::windowVisibilityChanged):
+(WebKit::PluginControllerProxy::updateVisiblityActivity):
+* PluginProcess/PluginControllerProxy.h:
+
+2014-08-15  Gavin Barraclough  barraclo...@apple.com
+
+Fix plugin visibility check.
+https://bugs.webkit.org/show_bug.cgi?id=135991
+
 Reviewed by Andreas Kling.
 
 We should only take a UserActivity if the plugin is in a visible window,


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (172645 => 172646)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2014-08-15 20:32:14 UTC (rev 172645)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2014-08-15 20:37:15 UTC (rev 172646)
@@ -61,8 +61,8 @@
 , m_isPrivateBrowsingEnabled(creationParameters.isPrivateBrowsingEnabled)
 , m_isAcceleratedCompositingEnabled(creationParameters.isAcceleratedCompositingEnabled)
 , m_isInitializing(false)
-, m_isVisibile(false)
-, m_isWindowVisibile(false)
+, m_isVisible(false)
+, m_isWindowVisible(false)
 , m_paintTimer(RunLoop::main(), this, PluginControllerProxy::paint)
 , m_pluginDestructionProtectCount(0)
 , m_pluginDestroyTimer(RunLoop::main(), this, PluginControllerProxy::destroy)
@@ -432,7 +432,7 @@
 
 void PluginControllerProxy::visibilityDidChange(bool isVisible)
 {
-m_isVisibile = isVisible;
+m_isVisible = isVisible;
 
 ASSERT(m_plugin);
 m_plugin-visibilityDidChange(isVisible);
@@ -448,7 +448,7 @@
 
 void PluginControllerProxy::windowVisibilityChanged(bool isVisible)
 {
-m_isWindowVisibile = isVisible;
+m_isWindowVisible = isVisible;
 
 ASSERT(m_plugin);
 m_plugin-windowVisibilityChanged(isVisible);
@@ -458,7 +458,7 @@
 
 void PluginControllerProxy::updateVisiblityActivity()
 {
-if (m_isVisibile  m_isWindowVisibile)
+if (m_isVisible  m_isWindowVisible)
 m_visiblityActivity.start();
 else
 m_visiblityActivity.stop();


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h (172645 => 172646)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h	2014-08-15 20:32:14 UTC (rev 172645)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h	2014-08-15 20:37:15 UTC (rev 172646)
@@ -177,8 +177,8 @@
 bool m_isPrivateBrowsingEnabled;
 bool m_isAcceleratedCompositingEnabled;
 bool m_isInitializing;
-bool m_isVisibile;
-bool m_isWindowVisibile;
+bool m_isVisible;
+bool m_isWindowVisible;
 
 RefPtrMessages::WebProcessConnection::CreatePlugin::DelayedReply m_initializationReply;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172647] trunk

2014-08-15 Thread krit

Title: [172647] trunk








Revision 172647
Author k...@webkit.org
Date 2014-08-15 13:48:35 -0700 (Fri, 15 Aug 2014)


Log Message
Turn r/rx/ry to presentation attributes
https://bugs.webkit.org/show_bug.cgi?id=135978

Source/WebCore:

Unreviewed typo.

Patch by Dirk Schulze k...@webkit.org on 2014-08-15

* rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

LayoutTests:

Patch by Dirk Schulze k...@webkit.org on 2014-08-15
Reviewed by Dean Jackson.

Rebaseline test.

* svg/css/parse-length-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/css/parse-length-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (172646 => 172647)

--- trunk/LayoutTests/ChangeLog	2014-08-15 20:37:15 UTC (rev 172646)
+++ trunk/LayoutTests/ChangeLog	2014-08-15 20:48:35 UTC (rev 172647)
@@ -5,6 +5,17 @@
 
 Reviewed by Dean Jackson.
 
+Rebaseline test.
+
+* svg/css/parse-length-expected.txt:
+
+2014-08-15  Dirk Schulze  k...@webkit.org
+
+Turn r/rx/ry to presentation attributes
+https://bugs.webkit.org/show_bug.cgi?id=135978
+
+Reviewed by Dean Jackson.
+
 This follows the patch for width and height presentation attributes and
 turns r, rx and ry to presentation attributes as well:
 


Modified: trunk/LayoutTests/svg/css/parse-length-expected.txt (172646 => 172647)

--- trunk/LayoutTests/svg/css/parse-length-expected.txt	2014-08-15 20:37:15 UTC (rev 172646)
+++ trunk/LayoutTests/svg/css/parse-length-expected.txt	2014-08-15 20:48:35 UTC (rev 172647)
@@ -1,3 +1,9 @@
+CONSOLE MESSAGE: Error: Invalid value for rect attribute rx=  100
+CONSOLE MESSAGE: Error: Invalid value for rect attribute rx=100   
+CONSOLE MESSAGE: Error: Invalid negative value for rect attribute rx=-200px
+CONSOLE MESSAGE: Error: Invalid value for rect attribute ry=  100
+CONSOLE MESSAGE: Error: Invalid value for rect attribute ry=100   
+CONSOLE MESSAGE: Error: Invalid negative value for rect attribute ry=-200px
 CONSOLE MESSAGE: Error: Invalid value for rect attribute width=auto
 CONSOLE MESSAGE: Error: Invalid value for rect attribute width=  100
 CONSOLE MESSAGE: Error: Invalid value for rect attribute width=100   
@@ -5,6 +11,16 @@
 CONSOLE MESSAGE: Error: Invalid value for rect attribute x=100   
 CONSOLE MESSAGE: Error: Invalid value for rect attribute y=  100
 CONSOLE MESSAGE: Error: Invalid value for rect attribute y=100   
+CONSOLE MESSAGE: Error: Invalid value for rect attribute rx=auto
+CONSOLE MESSAGE: Error: Invalid value for rect attribute rx=100   px
+CONSOLE MESSAGE: Error: Invalid value for rect attribute rx=100px;
+CONSOLE MESSAGE: Error: Invalid value for rect attribute rx=100px !important
+CONSOLE MESSAGE: Error: Invalid value for rect attribute rx={ 100px }
+CONSOLE MESSAGE: Error: Invalid value for rect attribute ry=auto
+CONSOLE MESSAGE: Error: Invalid value for rect attribute ry=100   px
+CONSOLE MESSAGE: Error: Invalid value for rect attribute ry=100px;
+CONSOLE MESSAGE: Error: Invalid value for rect attribute ry=100px !important
+CONSOLE MESSAGE: Error: Invalid value for rect attribute ry={ 100px }
 CONSOLE MESSAGE: Error: Invalid value for rect attribute width=100   px
 CONSOLE MESSAGE: Error: Invalid value for rect attribute width=100px;
 CONSOLE MESSAGE: Error: Invalid value for rect attribute width=100px !important
@@ -39,6 +55,27 @@
 PASS computedStyle(cy, 1ex) is 12.80190734863px
 PASS computedStyle(cy, 20%) is 20%
 PASS computedStyle(cy, -200px) is -200px
+PASS computedStyle(r,   100) is 100px
+PASS computedStyle(r, 100   ) is 100px
+PASS computedStyle(r, 100px) is 100px
+PASS computedStyle(r, 1em) is 16px
+PASS computedStyle(r, 1ex) is 12.80190734863px
+PASS computedStyle(r, 20%) is 20%
+PASS computedStyle(r, -200px) is -200px
+PASS computedStyle(rx,   100) is 100px
+PASS computedStyle(rx, 100   ) is 100px
+PASS computedStyle(rx, 100px) is 100px
+PASS computedStyle(rx, 1em) is 16px
+PASS computedStyle(rx, 1ex) is 12.80190734863px
+PASS computedStyle(rx, 20%) is 20%
+PASS computedStyle(rx, -200px) is -200px
+PASS computedStyle(ry,   100) is 100px
+PASS computedStyle(ry, 100   ) is 100px
+PASS computedStyle(ry, 100px) is 100px
+PASS computedStyle(ry, 1em) is 16px
+PASS computedStyle(ry, 1ex) is 12.80190734863px
+PASS computedStyle(ry, 20%) is 20%
+PASS computedStyle(ry, -200px) is -200px
 PASS computedStyle(width, auto) is auto
 PASS computedStyle(width,   100) is 100px
 PASS computedStyle(width, 100   ) is 100px
@@ -70,6 +107,21 @@
 PASS computedStyle(cy, 100px;) is 0px
 PASS computedStyle(cy, 100px !important) is 0px
 PASS computedStyle(cy, { 100px }) is 0px
+PASS computedStyle(r, auto) is 0px
+PASS computedStyle(r, 100   px) is 0px
+PASS computedStyle(r, 100px;) is 0px
+PASS computedStyle(r, 100px !important) is 0px
+PASS computedStyle(r, { 100px }) is 0px
+PASS computedStyle(rx, auto)

[webkit-changes] [172648] trunk/Source/JavaScriptCore

2014-08-15 Thread mmirman

Title: [172648] trunk/Source/_javascript_Core








Revision 172648
Author mmir...@apple.com
Date 2014-08-15 14:04:31 -0700 (Fri, 15 Aug 2014)


Log Message
Made native inlining errors not segfault.
https://bugs.webkit.org/show_bug.cgi?id=135988

Reviewed by Geoffrey Garen.

* ftl/FTLAbbreviations.h:
(JSC::FTL::disposeMessage): Added.
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compilePutById):
abstracted out Options::verboseCompilation as was the case in the rest of the file.
(JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol):
added output error messages for llvm module loading.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLAbbreviations.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (172647 => 172648)

--- trunk/Source/_javascript_Core/ChangeLog	2014-08-15 20:48:35 UTC (rev 172647)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-08-15 21:04:31 UTC (rev 172648)
@@ -1,3 +1,19 @@
+2014-08-15  Matthew Mirman  mmir...@apple.com
+
+Made native inlining errors not segfault. 
+https://bugs.webkit.org/show_bug.cgi?id=135988
+
+Reviewed by Geoffrey Garen.
+
+* ftl/FTLAbbreviations.h:
+(JSC::FTL::disposeMessage): Added.
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compilePutById): 
+abstracted out Options::verboseCompilation as was the case in the rest of the file.
+(JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct):
+(JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol): 
+added output error messages for llvm module loading.
+
 2014-08-14  Andreas Kling  akl...@apple.com
 
 Allocate the whole RegExpMatchesArray backing store up front.


Modified: trunk/Source/_javascript_Core/ftl/FTLAbbreviations.h (172647 => 172648)

--- trunk/Source/_javascript_Core/ftl/FTLAbbreviations.h	2014-08-15 20:48:35 UTC (rev 172647)
+++ trunk/Source/_javascript_Core/ftl/FTLAbbreviations.h	2014-08-15 21:04:31 UTC (rev 172648)
@@ -187,6 +187,8 @@
 static inline LModule moduleCreateWithNameInContext(const char* moduleID, LContext context){ return llvm-ModuleCreateWithNameInContext(moduleID, context); }
 static inline void disposeModule(LModule m){ llvm-DisposeModule(m); }
 
+static inline void disposeMessage(char* outMsg) { llvm-DisposeMessage(outMsg); }
+
 static inline LValue getParam(LValue function, unsigned index) { return llvm-GetParam(function, index); }
 
 static inline void getParamTypes(LType function, LType* dest) { return llvm-GetParamTypes(function, dest); }


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (172647 => 172648)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-08-15 20:48:35 UTC (rev 172647)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2014-08-15 21:04:31 UTC (rev 172648)
@@ -1899,7 +1899,7 @@
 // Arguments: id, bytes, target, numArgs, args...
 unsigned stackmapID = m_stackmapIDs++;
 
-if (Options::verboseCompilation())
+if (verboseCompilationEnabled())
 dataLog(Emitting PutById patchpoint with stackmap #, stackmapID, \n);
 
 LValue call = m_out.call(
@@ -3715,7 +3715,7 @@
 : m_out.bitCast(calleeCallFrame, typeCalleeArg);
 LValue call = vmCall(callee, argument);
 
-if (Options::verboseCompilation())
+if (verboseCompilationEnabled())
 dataLog(Native calling: , info.dli_sname, \n);
 
 setJSValue(call);
@@ -4382,16 +4382,22 @@
 isX86() ? /Resources/Runtime/x86_64/ : /Resources/Runtime/arm64/,
 path.data());
 
-if (createMemoryBufferWithContentsOfFile(actualPath.data(), memBuf, nullptr)) {
-if (Options::verboseCompilation()) 
-dataLog(Failed to load module at , actualPath.data(), \n for symbol , symbol.data());
+char* outMsg;
+
+if (createMemoryBufferWithContentsOfFile(actualPath.data(), memBuf, outMsg)) {
+if (Options::verboseFTLFailure())
+dataLog(Failed to load module at , actualPath, \n for symbol , symbol, \nERROR: , outMsg, \n);
+disposeMessage(outMsg);
 return false;
 }
 
 LModule module;
 
-if (parseBitcodeInContext(m_ftlState.context, memBuf, module, nullptr)) {
+if (parseBitcodeInContext(m_ftlState.context, memBuf, module, outMsg)) {
+if (Options::verboseFTLFailure())
+dataLog(Failed to parse module at , actualPath, \n for symbol , symbol, \nERROR: , outMsg, \n);
 disposeMemoryBuffer(memBuf);
+disposeMessage(outMsg);
 return false;
 }
 
@@ -4424,8 +4430,12 @@
 namedGlobals.append(globalName);
 }
 
-if (linkModules(m_ftlState.module, module, LLVMLinkerDestroySource,

[webkit-changes] [172649] trunk/Source

2014-08-15 Thread commit-queue

Title: [172649] trunk/Source








Revision 172649
Author commit-qu...@webkit.org
Date 2014-08-15 14:09:13 -0700 (Fri, 15 Aug 2014)


Log Message
Implement snapping behavior for iOS
https://bugs.webkit.org/show_bug.cgi?id=135769

Patch by Wenson Hsieh wenson_hs...@apple.com on 2014-08-15
Reviewed by Brent Fulgham.

Source/WebCore:

Added support for snap points on iOS. This entails sending snap points from the web process to the UI process
by encoding and decoding snap points and updating ScrollingTreeOverflowScrollingNodeIOS and WKWebView to support
animation to snap points in the cases of mainframe and overflow scrolling, respectively.

There are no new tests yet -- we'll need to find a way to test this!

* WebCore.exp.in:
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::setStateScrollingNodeSnapOffsetsAsFloat): Helper functions used to convert LayoutUnits to floats for snap offsets.
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated): Update snap offsets for mainframe scrolling, as well as the state node.
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode): Added snap offsets.
* page/scrolling/AxisScrollSnapOffsets.h:
(WebCore::closestSnapOffset): Computes the closest snap offset given a sorted vector of comparable types (e.g. float, LayoutUnit).
* page/scrolling/ScrollingCoordinator.h:
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setHorizontalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::setVerticalSnapOffsets):
* page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::ScrollingStateScrollingNode::horizontalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::verticalSnapOffsets):
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
* page/scrolling/ScrollingTreeScrollingNode.h:
(WebCore::ScrollingTreeScrollingNode::horizontalSnapOffsets):
(WebCore::ScrollingTreeScrollingNode::verticalSnapOffsets):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Update snap offsets for overflow scrolling.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer): Updates the state node's snap offsets for overflow scrolling.

Source/WebKit2:

Added support for snap points on iOS.

* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoderScrollingStateScrollingNode::encode): Added snap offset encoding.
(ArgumentCoderScrollingStateScrollingNode::decode): Added snap offset decoding.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): For mainframe scrolling, retargets the scroll destination to the appropriate snap point.
* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h: Added methods to extract relevant information for WKWebView from snap offsets in mainframe scrolling.
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): For overflow scrolling, retargets the scroll destination to the appropriate snap point.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren): Sets the deceleration factor to FAST if snap points are active.
* UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::adjustTargetContentOffsetForSnapping): Used by WKWebView for mainframe scrolling to retarget the scroll destination, if necessary.
(WebKit::RemoteScrollingCoordinatorProxy::shouldSetScrollViewDecelerationRateFast): Used by WKWebView for mainframe scrolling to determine whether to set deceleration rate to the fast value.
(WebKit::RemoteScrollingCoordinatorProxy::shouldSnapForMainFrameScrolling): Helper method.
(WebKit::RemoteScrollingCoordinatorProxy::closestSnapOffsetForMainFrameScrolling): Helper method.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp
trunk/Source/WebCore/page/scrolling/AxisScrollSnapOffsets.h
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp
trunk/Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h
trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h
trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h

[webkit-changes] [172650] trunk/Source/WebInspectorUI

2014-08-15 Thread timothy

Title: [172650] trunk/Source/WebInspectorUI








Revision 172650
Author timo...@apple.com
Date 2014-08-15 14:12:06 -0700 (Fri, 15 Aug 2014)


Log Message
Web Inspector: Probe details sidebar data grids do not show data
https://bugs.webkit.org/show_bug.cgi?id=135992

Reviewed by Joseph Pecoraro.

* UserInterface/Views/ProbeSetDataGrid.js:
(WebInspector.ProbeSetDataGrid): Make the DataGrid be inline to show the data correctly.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (172649 => 172650)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-08-15 21:09:13 UTC (rev 172649)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-08-15 21:12:06 UTC (rev 172650)
@@ -1,5 +1,15 @@
 2014-08-15  Timothy Hatcher  timo...@apple.com
 
+Web Inspector: Probe details sidebar data grids do not show data
+https://bugs.webkit.org/show_bug.cgi?id=135992
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/ProbeSetDataGrid.js:
+(WebInspector.ProbeSetDataGrid): Make the DataGrid be inline to show the data correctly.
+
+2014-08-15  Timothy Hatcher  timo...@apple.com
+
 Web Inspector: Legacy Mac toolbar appearance looks wrong
 https://bugs.webkit.org/show_bug.cgi?id=135962
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js (172649 => 172650)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js	2014-08-15 21:09:13 UTC (rev 172649)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js	2014-08-15 21:12:06 UTC (rev 172650)
@@ -34,8 +34,11 @@
 var probeTitle = probe._expression_ || WebInspector.UIString((uninitialized));
 columnsData[probe.id] = { title: probeTitle };
 }
+
 WebInspector.DataGrid.call(this, columnsData);
 
+this.element.classList.add(inline);
+
 this._frameNodes = new Map;
 this._nodesSinceLastNavigation = [];
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172651] trunk/Source/WebCore

2014-08-15 Thread jer . noble

Title: [172651] trunk/Source/WebCore








Revision 172651
Author jer.no...@apple.com
Date 2014-08-15 14:14:14 -0700 (Fri, 15 Aug 2014)


Log Message
[EME][Mac] Adopt AVStreamSession.
https://bugs.webkit.org/show_bug.cgi?id=135983

Reviewed by Eric Carlson.

Add AVStreamDataParsers to a new AVStreamSession instance, and expire that session when asked to release
the session's keys.

* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys):
(WebCore::CDMSessionMediaSourceAVFObjC::update):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (172650 => 172651)

--- trunk/Source/WebCore/ChangeLog	2014-08-15 21:12:06 UTC (rev 172650)
+++ trunk/Source/WebCore/ChangeLog	2014-08-15 21:14:14 UTC (rev 172651)
@@ -1,3 +1,19 @@
+2014-08-15  Jer Noble  jer.no...@apple.com
+
+[EME][Mac] Adopt AVStreamSession.
+https://bugs.webkit.org/show_bug.cgi?id=135983
+
+Reviewed by Eric Carlson.
+
+Add AVStreamDataParsers to a new AVStreamSession instance, and expire that session when asked to release
+the session's keys.
+
+* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
+* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
+(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC):
+(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys):
+(WebCore::CDMSessionMediaSourceAVFObjC::update):
+
 2014-08-15  Wenson Hsieh  wenson_hs...@apple.com
 
 Implement snapping behavior for iOS


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h (172650 => 172651)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h	2014-08-15 21:12:06 UTC (rev 172650)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h	2014-08-15 21:14:14 UTC (rev 172651)
@@ -33,6 +33,8 @@
 
 #if ENABLE(ENCRYPTED_MEDIA_V2)  ENABLE(MEDIA_SOURCE)
 
+OBJC_CLASS AVStreamSession;
+
 namespace WebCore {
 
 class CDMSessionMediaSourceAVFObjC : public CDMSession, public SourceBufferPrivateAVFObjCErrorClient {
@@ -52,6 +54,7 @@
 protected:
 RefPtrSourceBufferPrivateAVFObjC m_parent;
 CDMSessionClient* m_client;
+RetainPtrAVStreamSession m_streamSession;
 RefPtrUint8Array m_initData;
 RefPtrUint8Array m_certificate;
 String m_sessionId;


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm (172650 => 172651)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm	2014-08-15 21:12:06 UTC (rev 172650)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm	2014-08-15 21:14:14 UTC (rev 172651)
@@ -42,7 +42,7 @@
 
 SOFT_LINK_FRAMEWORK_OPTIONAL(AVFoundation)
 SOFT_LINK_CLASS(AVFoundation, AVStreamDataParser);
-#define AVAssetResourceLoadingRequest getAVStreamDataParser()
+SOFT_LINK_CLASS_OPTIONAL(AVFoundation, AVStreamSession);
 
 @interface AVStreamDataParser : NSObject
 - (void)processContentKeyResponseData:(NSData *)contentKeyResponseData forTrackID:(CMPersistentTrackID)trackID;
@@ -51,6 +51,15 @@
 - (NSData *)streamingContentKeyRequestDataForApp:(NSData *)appIdentifier contentIdentifier:(NSData *)contentIdentifier trackID:(CMPersistentTrackID)trackID options:(NSDictionary *)options error:(NSError **)outError;
 @end
 
+@interface AVStreamSession : NSObject
+- (instancetype)initWithAppIdentifier:(NSData *)appIdentifier;
+- (void)addStreamDataParser:(AVStreamDataParser *)streamDataParser;
+- (void)removeStreamDataParser:(AVStreamDataParser *)streamDataParser;
+- (void)expire;
++ (NSArray *)pendingExpiredSessionReportsWithAppIdentifier:(NSData *)appIdentifier;
++ (void)removePendingExpiredSessionReports:(NSArray *)expiredSessionReports withAppIdentifier:(NSData *)appIdentifier;
+@end
+
 namespace WebCore {
 
 CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC(SourceBufferPrivateAVFObjC* parent)
@@ -64,6 +73,10 @@
 
 CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC()
 {
+if (m_streamSession) {
+[m_streamSession removeStreamDataParser:m_parent-parser()];
+m_streamSession = nil;
+}
 m_parent-unregisterForErrorNotifications(this);
 m_client = nullptr;
 }
@@ -90,7 +103,10 @@
 
 void CDMSessionMediaSourceAVFObjC::releaseKeys()
 {
-LOG(Media, CDMSessionMediaSourceAVFObjC::releaseKeys(%p), this);
+if (m_streamSession) {
+LOG(Media, CDMSessionMediaSourceAVFObjC::releaseKeys(%p) - expiring stream session,

[webkit-changes] [172652] branches/safari-600.1.4.11-branch

2014-08-15 Thread matthew_hanson

Title: [172652] branches/safari-600.1.4.11-branch








Revision 172652
Author matthew_han...@apple.com
Date 2014-08-15 14:16:21 -0700 (Fri, 15 Aug 2014)


Log Message
Merge r172603. rdar://problem/18008488

Modified Paths

branches/safari-600.1.4.11-branch/LayoutTests/ChangeLog
branches/safari-600.1.4.11-branch/Source/WebCore/ChangeLog
branches/safari-600.1.4.11-branch/Source/WebCore/Modules/indexeddb/IDBFactory.cpp


Added Paths

branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/open-db-private-browsing-expected.txt
branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/open-db-private-browsing.html
branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/resources/open-db-private-browsing.js




Diff

Modified: branches/safari-600.1.4.11-branch/LayoutTests/ChangeLog (172651 => 172652)

--- branches/safari-600.1.4.11-branch/LayoutTests/ChangeLog	2014-08-15 21:14:14 UTC (rev 172651)
+++ branches/safari-600.1.4.11-branch/LayoutTests/ChangeLog	2014-08-15 21:16:21 UTC (rev 172652)
@@ -1,3 +1,19 @@
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
+Merge r172603. rdar://problem/18008488
+
+2014-08-14  Martin Hock  mh...@apple.com
+
+IndexedDB should respect SchemeRegistry's database access setting.
+https://bugs.webkit.org/show_bug.cgi?id=135890
+rdar://problem/17989469
+
+Reviewed by Alexey Proskuryakov.
+
+* storage/indexeddb/open-db-private-browsing-expected.txt: Added.
+* storage/indexeddb/open-db-private-browsing.html: Added. Simple test to open database in private browsing mode.
+* storage/indexeddb/resources/open-db-private-browsing.js: Added.
+
 2014-08-15  Lucas Forschler  lforsch...@apple.com
 
 Merge r171675


Copied: branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/open-db-private-browsing-expected.txt (from rev 172603, trunk/LayoutTests/storage/indexeddb/open-db-private-browsing-expected.txt) (0 => 172652)

--- branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/open-db-private-browsing-expected.txt	(rev 0)
+++ branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/open-db-private-browsing-expected.txt	2014-08-15 21:16:21 UTC (rev 172652)
@@ -0,0 +1,12 @@
+Simple test to open IndexedDB database in private browsing mode.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+PASS indexedDB.open('db') is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Copied: branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/open-db-private-browsing.html (from rev 172603, trunk/LayoutTests/storage/indexeddb/open-db-private-browsing.html) (0 => 172652)

--- branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/open-db-private-browsing.html	(rev 0)
+++ branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/open-db-private-browsing.html	2014-08-15 21:16:21 UTC (rev 172652)
@@ -0,0 +1,9 @@
+html
+head
+script src=""
+script src=""
+/head
+body
+script src=""
+/body
+/html


Copied: branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/resources/open-db-private-browsing.js (from rev 172603, trunk/LayoutTests/storage/indexeddb/resources/open-db-private-browsing.js) (0 => 172652)

--- branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/resources/open-db-private-browsing.js	(rev 0)
+++ branches/safari-600.1.4.11-branch/LayoutTests/storage/indexeddb/resources/open-db-private-browsing.js	2014-08-15 21:16:21 UTC (rev 172652)
@@ -0,0 +1,11 @@
+if (this.importScripts) {
+importScripts('../../../resources/js-test.js');
+importScripts('shared.js');
+}
+
+description(Simple test to open IndexedDB database in private browsing mode.);
+
+testRunner.setPrivateBrowsingEnabled(true);
+removeVendorPrefixes();
+shouldBeNull(indexedDB.open('db'));
+finishJSTest();


Modified: branches/safari-600.1.4.11-branch/Source/WebCore/ChangeLog (172651 => 172652)

--- branches/safari-600.1.4.11-branch/Source/WebCore/ChangeLog	2014-08-15 21:14:14 UTC (rev 172651)
+++ branches/safari-600.1.4.11-branch/Source/WebCore/ChangeLog	2014-08-15 21:16:21 UTC (rev 172652)
@@ -1,3 +1,19 @@
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
+Merge r172603. rdar://problem/18008488
+
+2014-08-14  Martin Hock  mh...@apple.com
+
+IndexedDB should respect SchemeRegistry's database access setting.
+https://bugs.webkit.org/show_bug.cgi?id=135890
+rdar://problem/17989469
+
+Reviewed by Alexey Proskuryakov.
+
+Test: storage/indexeddb/open-db-private-browsing.html
+
+* Modules/indexeddb/IDBFactory.cpp:
+
 2014-08-15  Lucas Forschler  lforsch...@apple.com
 
 Merge r172502


Modified:

[webkit-changes] [172654] tags/Safari-600.1.4.11.1/

2014-08-15 Thread matthew_hanson

Title: [172654] tags/Safari-600.1.4.11.1/








Revision 172654
Author matthew_han...@apple.com
Date 2014-08-15 14:48:36 -0700 (Fri, 15 Aug 2014)


Log Message
New Tag.

Added Paths

tags/Safari-600.1.4.11.1/




Diff

Property changes: tags/Safari-600.1.4.11.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172656] trunk

2014-08-15 Thread zalan

Title: [172656] trunk








Revision 172656
Author za...@apple.com
Date 2014-08-15 15:43:50 -0700 (Fri, 15 Aug 2014)


Log Message
REGRESSION: Parts of the route/route options windows are invisible at maps.google.com
https://bugs.webkit.org/show_bug.cgi?id=135977
rdar://problem/17961698

Reviewed by Andreas Kling.

When the style change requires both layout and repaint, the style diff is set to
'layout is needed' (and masks the repaint change) as normally layout is followed by a repaint.
However, in compositing context, layout may not be followed by repaint, so when the style diff
indicates layout, we need to figure out whether it implies repaint too.
This logic should eventually be moved from RenderElement to RenderLayerModelObject/RenderLayer.
-tracked here: webkit.org/b/135990

Source/WebCore:

Test: compositing/cliprect-and-position-change-on-compositing-layer.html

* rendering/RenderElement.cpp:
(WebCore::RenderElement::setNeedsPositionedMovementLayout):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayerRepaint):
(WebCore::RenderStyle::diffRequiresLayerRepaint):
(WebCore::RenderStyle::diffRequiresRepaint): Deleted.
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:

LayoutTests:

* compositing/cliprect-and-position-change-on-compositing-layer-expected.html: Added.
* compositing/cliprect-and-position-change-on-compositing-layer.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h


Added Paths

trunk/LayoutTests/compositing/cliprect-and-position-change-on-compositing-layer-expected.html
trunk/LayoutTests/compositing/cliprect-and-position-change-on-compositing-layer.html




Diff

Modified: trunk/LayoutTests/ChangeLog (172655 => 172656)

--- trunk/LayoutTests/ChangeLog	2014-08-15 22:40:33 UTC (rev 172655)
+++ trunk/LayoutTests/ChangeLog	2014-08-15 22:43:50 UTC (rev 172656)
@@ -1,3 +1,21 @@
+2014-08-15  Zalan Bujtas  za...@apple.com
+
+REGRESSION: Parts of the route/route options windows are invisible at maps.google.com
+https://bugs.webkit.org/show_bug.cgi?id=135977
+rdar://problem/17961698
+
+Reviewed by Andreas Kling.
+
+When the style change requires both layout and repaint, the style diff is set to
+'layout is needed' (and masks the repaint change) as normally layout is followed by a repaint.
+However, in compositing context, layout may not be followed by repaint, so when the style diff
+indicates layout, we need to figure out whether it implies repaint too.
+This logic should eventually be moved from RenderElement to RenderLayerModelObject/RenderLayer.
+-tracked here: webkit.org/b/135990
+
+* compositing/cliprect-and-position-change-on-compositing-layer-expected.html: Added.
+* compositing/cliprect-and-position-change-on-compositing-layer.html: Added.
+
 2014-08-15  Dirk Schulze  k...@webkit.org
 
 Turn r/rx/ry to presentation attributes


Added: trunk/LayoutTests/compositing/cliprect-and-position-change-on-compositing-layer-expected.html (0 => 172656)

--- trunk/LayoutTests/compositing/cliprect-and-position-change-on-compositing-layer-expected.html	(rev 0)
+++ trunk/LayoutTests/compositing/cliprect-and-position-change-on-compositing-layer-expected.html	2014-08-15 22:43:50 UTC (rev 172656)
@@ -0,0 +1,20 @@
+!DOCTYPE html
+html
+head
+titleThis test that compositing layers get repainted properly when cliprect is applied with position change./title
+style
+  #foo {
+position: absolute;
+top: 1px;
+left: 0px;
+width: 100px;
+height: 100px;
+background-color: green;
+-webkit-transform: translateZ(0);
+}
+/style
+/head 
+body 
+div id=foo/div  
+/body
+/html


Added: trunk/LayoutTests/compositing/cliprect-and-position-change-on-compositing-layer.html (0 => 172656)

--- trunk/LayoutTests/compositing/cliprect-and-position-change-on-compositing-layer.html	(rev 0)
+++ trunk/LayoutTests/compositing/cliprect-and-position-change-on-compositing-layer.html	2014-08-15 22:43:50 UTC (rev 172656)
@@ -0,0 +1,35 @@
+!DOCTYPE html
+html
+head
+titleThis test that compositing layers get repainted properly when cliprect is applied with position change./title
+style
+  #foo {
+position: absolute;
+top: 0px;
+left: 0px;
+width: 100px;
+height: 100px;
+background-color: green;
+clip: rect(70px, 102px, 102px, -1px);
+-webkit-transform: translateZ(0);
+}
+/style
+/head 
+body 
+div id=foo/div  
+script
+  if (window.testRunner)
+testRunner.waitUntilDone();
+
+  setTimeout(function() { 
+var box = document.getElementById(foo);
+box.style.clip = rect(0px, 102px, 202px, 0px);
+box.style.top =

[webkit-changes] [172657] trunk/Source/WebCore

2014-08-15 Thread eric . carlson

Title: [172657] trunk/Source/WebCore








Revision 172657
Author eric.carl...@apple.com
Date 2014-08-15 16:09:19 -0700 (Fri, 15 Aug 2014)


Log Message
[MSE] Implement a maximum buffer size for SourceBuffer
https://bugs.webkit.org/show_bug.cgi?id=135614

Reviewed by Jer Noble.

Implement the MSE coded frame eviction algorithm: when new buffers are appended attempt
to keep the amount of data buffered below a maximum size (which is determined by the media
session manager) by freeing coded frames as follows:
1 - Free frames in 30 second chunks from 0 to 30 seconds before the current time.
2 - If there are time ranges after the range with the current time, free frames in
30 second chunks from duration back to the beginning of the time range after
current time.

For now we DO NOT throw a QUOTA_EXCEEDED_ERR when we are not able to free up enough
space to remain below the prescribed quota, because some big name, widely deployed, 
code bases ignore the error and continue appending data as though the failed append
succeeded, leading to a corrupted bitstream and failure to play.

* Modules/mediasource/SampleMap.cpp:
(WebCore::SampleMap::addSample): Drive-by performance optimization: sample-presentationTime()
is used more than once, stash it in a local variable.
(WebCore::SampleMap::removeSample): Ditto.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::logRanges): Debug-only function to log TimeRanges.
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::remove): Optimize logging. Buffer full and coded frame eviction logic
is in SourceBuffer instead of SourceBufferPrivate.
(WebCore::SourceBuffer::appendBufferInternal): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Set m_bufferFull when more data
has been buffered than allowed.
(WebCore::removeSamplesFromTrackBuffer): Add logging.
(WebCore::SourceBuffer::removeCodedFrames): Improve logging. Avoid debug build assert when
current time is after last enqueued presentation time.
(WebCore::SourceBuffer::evictCodedFrames): The coded frame eviction algorithm.
(WebCore::SourceBuffer::maximumBufferSize): Return the maximum amount of data that can 
be buffered.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Improve logging. Don't attempt
to create a PlatformTimeRanges with inverted start and end to avoid an assert in debug.
(WebCore::SourceBuffer::hasAudio): New, return true if there are any audio tracks.
(WebCore::SourceBuffer::hasVideo): New, return true if there are any video tracks.
(WebCore::SourceBuffer::sourceBufferPrivateHasAudio): Call hasAudio.
(WebCore::SourceBuffer::sourceBufferPrivateHasVideo): Call hasVideo.
(WebCore::SourceBuffer::hasCurrentTime): Return true if currentTime is greater than duration.
(WebCore::SourceBuffer::hasFutureTime): Ditto.
(WebCore::SourceBuffer::extraMemoryCost): Return the amount of data buffered: the size of
the input buffer plus the size of all track samples.
(WebCore::SourceBuffer::reportExtraMemoryCost): Move buffered size calculation to extraMemoryCost.
(WebCore::SourceBuffer::document): Document accessor.
* Modules/mediasource/SourceBuffer.h: Drive-by size optimization by moving all bool member
variables to the end of class.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::refreshCachedTime): Drive-by removal of overly chatty logging.
(WebCore::HTMLMediaElement::maximumSourceBufferSize): New, maximum source buffer size.
* html/HTMLMediaElement.h:

* html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::maximumMediaSourceBufferSize): New, get maximum source buffer 
size from settings, return full amount for an SourceBuffer with video and audio, return 5%
of the maximum for an audio-only SourceBuffer.
* html/HTMLMediaSession.h:

* page/Settings.in: Add maximumSourceBufferSize. Default value is enough for approximately
five minutes of 1080p video and stereo audio.

* platform/graphics/PlatformTimeRanges.cpp:
(WebCore::PlatformTimeRanges::totalDuration): Drive-by optimization.
(WebCore::PlatformTimeRanges::dump): New, allow a PlatformTimeRanges to be printed.
* platform/graphics/PlatformTimeRanges.h:

* platform/graphics/SourceBufferPrivate.h: Delete evictCodedFrames and isFull, that logic
is not in SourceBuffer.
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame): Drive-by logging fix.
(WebCore::SourceBufferPrivateAVFObjC::evictCodedFrames): Deleted.
(WebCore::SourceBufferPrivateAVFObjC::isFull): Deleted.

* platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::evictCodedFrames): Deleted.
(WebCore::MockSourceBufferPrivate::isFull): Deleted.
* platform/mock/mediasource/MockSourceBufferPrivate.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/SampleMap.cpp

[webkit-changes] [172658] trunk/Source/WebKit/mac

2014-08-15 Thread dbates

Title: [172658] trunk/Source/WebKit/mac








Revision 172658
Author dba...@webkit.org
Date 2014-08-15 16:19:44 -0700 (Fri, 15 Aug 2014)


Log Message
[iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
and ENABLE_TOUCH_EVENTS if applicable
https://bugs.webkit.org/show_bug.cgi?id=135993

Reviewed by Andy Estes.

Add support infrastructure to remove code from public and private API headers that is
guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.

We aren't using this functionality yet, but we will soon.

* postprocess-headers.sh:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/postprocess-headers.sh




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (172657 => 172658)

--- trunk/Source/WebKit/mac/ChangeLog	2014-08-15 23:09:19 UTC (rev 172657)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-08-15 23:19:44 UTC (rev 172658)
@@ -1,3 +1,18 @@
+2014-08-15  Daniel Bates  daba...@apple.com
+
+[iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
+and ENABLE_TOUCH_EVENTS if applicable
+https://bugs.webkit.org/show_bug.cgi?id=135993
+
+Reviewed by Andy Estes.
+
+Add support infrastructure to remove code from public and private API headers that is
+guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.
+
+We aren't using this functionality yet, but we will soon.
+
+* postprocess-headers.sh:
+
 2014-08-13  Wenson Hsieh  wenson_hs...@apple.com
 
 Enable CSS_SCROLL_SNAP for iOS


Modified: trunk/Source/WebKit/mac/postprocess-headers.sh (172657 => 172658)

--- trunk/Source/WebKit/mac/postprocess-headers.sh	2014-08-15 23:09:19 UTC (rev 172657)
+++ trunk/Source/WebKit/mac/postprocess-headers.sh	2014-08-15 23:19:44 UTC (rev 172658)
@@ -14,6 +14,20 @@
 unifdefOptions=-DTARGET_OS_EMBEDDED=0 -DTARGET_OS_IPHONE=0 -DTARGET_IPHONE_SIMULATOR=0;
 fi
 
+# FIXME: We should consider making this logic general purpose so as to support keeping or removing
+# code guarded by an arbitrary feature define. For now it's sufficient to process touch- and gesture-
+# guarded code.
+for featureDefine in ENABLE_TOUCH_EVENTS ENABLE_IOS_GESTURE_EVENTS
+do
+# We assume a disabled feature is either undefined or has the empty string as its value.
+eval isFeatureEnabled=\$$featureDefine
+if [[ -z $isFeatureEnabled ]]; then
+unifdefOptions=$unifdefOptions -D$featureDefine=0
+else
+unifdefOptions=$unifdefOptions -D$featureDefine=1
+fi
+done
+
 if [[ ${PLATFORM_NAME} == iphone* ]]; then
 sedExpression='s/ *WEBKIT_((CLASS_|ENUM_)?AVAILABLE|DEPRECATED)_MAC\([^)]+\)//g';
 else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172659] trunk/Source/WebCore

2014-08-15 Thread commit-queue

Title: [172659] trunk/Source/WebCore








Revision 172659
Author commit-qu...@webkit.org
Date 2014-08-15 16:35:21 -0700 (Fri, 15 Aug 2014)


Log Message
Fix gliding in AxisScrollSnapAnimator for Mac
https://bugs.webkit.org/show_bug.cgi?id=135971

Patch by Wenson Hsieh wenson_hs...@apple.com on 2014-08-15
Reviewed by Dean Jackson.

Previously, momentum events that are handled immediately after finishing a glide animation cause a second, extremely
slow glide animation to trigger. To fix this, I added a new state DestinationReached. During this state, additional
momentum events that are handled after the glide animation completes will not fill up the momentum window and trigger
a second glide event.

* platform/mac/AxisScrollSnapAnimator.h:
* platform/mac/AxisScrollSnapAnimator.mm:
(WebCore::AxisScrollSnapAnimator::AxisScrollSnapAnimator):
(WebCore::AxisScrollSnapAnimator::handleWheelEvent):
(WebCore::AxisScrollSnapAnimator::scrollSnapAnimationUpdate):
(WebCore::AxisScrollSnapAnimator::endScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::computeGlideDelta):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.h
trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (172658 => 172659)

--- trunk/Source/WebCore/ChangeLog	2014-08-15 23:19:44 UTC (rev 172658)
+++ trunk/Source/WebCore/ChangeLog	2014-08-15 23:35:21 UTC (rev 172659)
@@ -1,3 +1,23 @@
+2014-08-15  Wenson Hsieh  wenson_hs...@apple.com
+
+Fix gliding in AxisScrollSnapAnimator for Mac
+https://bugs.webkit.org/show_bug.cgi?id=135971
+
+Reviewed by Dean Jackson.
+
+Previously, momentum events that are handled immediately after finishing a glide animation cause a second, extremely
+slow glide animation to trigger. To fix this, I added a new state DestinationReached. During this state, additional
+momentum events that are handled after the glide animation completes will not fill up the momentum window and trigger
+a second glide event.
+
+* platform/mac/AxisScrollSnapAnimator.h:
+* platform/mac/AxisScrollSnapAnimator.mm:
+(WebCore::AxisScrollSnapAnimator::AxisScrollSnapAnimator):
+(WebCore::AxisScrollSnapAnimator::handleWheelEvent):
+(WebCore::AxisScrollSnapAnimator::scrollSnapAnimationUpdate):
+(WebCore::AxisScrollSnapAnimator::endScrollSnapAnimation):
+(WebCore::AxisScrollSnapAnimator::computeGlideDelta):
+
 2014-08-15  Eric Carlson  eric.carl...@apple.com
 
 [MSE] Implement a maximum buffer size for SourceBuffer


Modified: trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.h (172658 => 172659)

--- trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.h	2014-08-15 23:19:44 UTC (rev 172658)
+++ trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.h	2014-08-15 23:35:21 UTC (rev 172659)
@@ -38,7 +38,8 @@
 enum class ScrollSnapState {
 Snapping,
 Gliding,
-Idle
+DestinationReached,
+UserInteraction
 };
 
 enum class WheelEventStatus {
@@ -71,7 +72,7 @@
 
 private:
 void beginScrollSnapAnimation(ScrollSnapState);
-void endScrollSnapAnimation();
+void endScrollSnapAnimation(ScrollSnapState);
 
 float computeSnapDelta() const;
 float computeGlideDelta() const;


Modified: trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm (172658 => 172659)

--- trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm	2014-08-15 23:19:44 UTC (rev 172658)
+++ trunk/Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm	2014-08-15 23:35:21 UTC (rev 172659)
@@ -86,7 +86,7 @@
 : m_client(client)
 , m_snapOffsets(snapOffsets)
 , m_axis(axis)
-, m_currentState(ScrollSnapState::Idle)
+, m_currentState(ScrollSnapState::DestinationReached)
 , m_initialOffset(0)
 , m_targetOffset(0)
 , m_beginTrackingWheelDeltaOffset(0)
@@ -108,7 +108,7 @@
 switch (wheelStatus) {
 case WheelEventStatus::UserScrollBegin:
 case WheelEventStatus::UserScrolling:
-endScrollSnapAnimation();
+endScrollSnapAnimation(ScrollSnapState::UserInteraction);
 break;
 
 case WheelEventStatus::UserScrollEnd:
@@ -117,15 +117,15 @@
 
 case WheelEventStatus::InertialScrollBegin:
 // Begin tracking wheel deltas for glide prediction.
-endScrollSnapAnimation();
+endScrollSnapAnimation(ScrollSnapState::UserInteraction);
 pushInitialWheelDelta(wheelDelta);
 m_beginTrackingWheelDeltaOffset = m_client-scrollOffsetInAxis(m_axis);
 break;
 
 case WheelEventStatus::InertialScrolling:
-if (m_currentState != ScrollSnapState::Gliding) {
-// FIXME: Investigate why small wheel deltas pushed into the window without the  -1,  1 check.
-if (m_numWheelDeltasTracked  wheelDeltaWindowSize  (wheelDelta  -1 || wheelDelta  1))
+// This check for DestinationReached ensures that we don't

[webkit-changes] [172660] trunk/Source/WebKit2

2014-08-15 Thread ap

Title: [172660] trunk/Source/WebKit2








Revision 172660
Author a...@apple.com
Date 2014-08-15 16:56:57 -0700 (Fri, 15 Aug 2014)


Log Message
Improve page to process relationship tracking
https://bugs.webkit.org/show_bug.cgi?id=135996
rdar://problem/16991213

Reviewed by Sam Weinig.

* UIProcess/VisitedLinkProvider.cpp:
(WebKit::VisitedLinkProvider::removeAll):
(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkProvider::sendTable):
Added assertions for m_processes only having valid entries.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess): When attaching to a new process,
tell the old process that the page is not longer associated with it, avoiding
a potential stale pointer.
If re-attached to an existing process, make sure that we perform all the same
registrations as after having launched a new process. This substantially improves
the behavior when the number of open tabs is over process limit.
(WebKit::WebPageProxy::reattachToWebProcessWithItem): Added ASSERT(!isValid())
to avoid confusion. All other calls to reattachToWebProcess() have this as a
runtime check, but reattachToWebProcessWithItem() is only called for valid pages.
(WebKit::WebPageProxy::terminateProcess): Added an assertion with a FIXME for
something that will need to be fixed another day.

* UIProcess/WebPageProxy.h: Removed an unimplemented function.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addExistingWebPage): Added assertions for page map sanity.
(WebKit::WebProcessProxy::removeWebPage): Added a check for page state being Terminated
already. This avoids an assertion failure that happened under the new call to
removeWebPage() in reattachToWebProcess(), as we are now calling it for terminated
processes that are not in WebContext::m_processes any more.
(WebKit::WebProcessProxy::didFinishLaunching): Added an assertion that page agrees
about using this process.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172659 => 172660)

--- trunk/Source/WebKit2/ChangeLog	2014-08-15 23:35:21 UTC (rev 172659)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-15 23:56:57 UTC (rev 172660)
@@ -1,3 +1,41 @@
+2014-08-15  Alexey Proskuryakov  a...@apple.com
+
+Improve page to process relationship tracking
+https://bugs.webkit.org/show_bug.cgi?id=135996
+rdar://problem/16991213
+
+Reviewed by Sam Weinig.
+
+* UIProcess/VisitedLinkProvider.cpp:
+(WebKit::VisitedLinkProvider::removeAll):
+(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
+(WebKit::VisitedLinkProvider::sendTable):
+Added assertions for m_processes only having valid entries.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::reattachToWebProcess): When attaching to a new process,
+tell the old process that the page is not longer associated with it, avoiding
+a potential stale pointer.
+If re-attached to an existing process, make sure that we perform all the same
+registrations as after having launched a new process. This substantially improves
+the behavior when the number of open tabs is over process limit.
+(WebKit::WebPageProxy::reattachToWebProcessWithItem): Added ASSERT(!isValid())
+to avoid confusion. All other calls to reattachToWebProcess() have this as a
+runtime check, but reattachToWebProcessWithItem() is only called for valid pages.
+(WebKit::WebPageProxy::terminateProcess): Added an assertion with a FIXME for
+something that will need to be fixed another day.
+
+* UIProcess/WebPageProxy.h: Removed an unimplemented function.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::addExistingWebPage): Added assertions for page map sanity.
+(WebKit::WebProcessProxy::removeWebPage): Added a check for page state being Terminated
+already. This avoids an assertion failure that happened under the new call to
+removeWebPage() in reattachToWebProcess(), as we are now calling it for terminated
+processes that are not in WebContext::m_processes any more.
+(WebKit::WebProcessProxy::didFinishLaunching): Added an assertion that page agrees
+about using this process.
+
 2014-08-15  Gavin Barraclough  barraclo...@apple.com
 
 Fix plugin visibility check.


Modified: trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.cpp (172659 => 172660)

--- trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.cpp	2014-08-15 23:35:21 UTC (rev 172659)
+++ trunk/Source/WebKit2/UIProcess/VisitedLinkProvider.cpp	2014-08-15 23:56:57 UTC (rev 172660)
@@ -97,8 +97,11 @@
 m_tableSize = 0;
 m_table.clear();
 
-for (auto

[webkit-changes] [172661] trunk/WebKitLibraries

2014-08-15 Thread bfulgham

Title: [172661] trunk/WebKitLibraries








Revision 172661
Author bfulg...@apple.com
Date 2014-08-15 17:42:24 -0700 (Fri, 15 Aug 2014)


Log Message
[Win] Link to static VS2013 runtime library.
https://bugs.webkit.org/show_bug.cgi?id=136007
rdar://problem/18037766

Reviewed by Dean Jackson.

* win/tools/vsprops/common.props: Update link command.
* win/tools/vsprops/debugsuffix.props: Ditto.

Modified Paths

trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/vsprops/common.props
trunk/WebKitLibraries/win/tools/vsprops/debugsuffix.props




Diff

Modified: trunk/WebKitLibraries/ChangeLog (172660 => 172661)

--- trunk/WebKitLibraries/ChangeLog	2014-08-15 23:56:57 UTC (rev 172660)
+++ trunk/WebKitLibraries/ChangeLog	2014-08-16 00:42:24 UTC (rev 172661)
@@ -1,3 +1,14 @@
+2014-08-15  Brent Fulgham  bfulg...@apple.com
+
+[Win] Link to static VS2013 runtime library.
+https://bugs.webkit.org/show_bug.cgi?id=136007
+rdar://problem/18037766
+
+Reviewed by Dean Jackson.
+
+* win/tools/vsprops/common.props: Update link command.
+* win/tools/vsprops/debugsuffix.props: Ditto.
+
 2014-08-14  Brent Fulgham  bfulg...@apple.com
 
 [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion


Modified: trunk/WebKitLibraries/win/tools/vsprops/common.props (172660 => 172661)

--- trunk/WebKitLibraries/win/tools/vsprops/common.props	2014-08-15 23:56:57 UTC (rev 172660)
+++ trunk/WebKitLibraries/win/tools/vsprops/common.props	2014-08-16 00:42:24 UTC (rev 172661)
@@ -47,7 +47,7 @@
   TreatWarningAsErrorfalse/TreatWarningAsError
   DebugInformationFormatProgramDatabase/DebugInformationFormat
   DisableSpecificWarnings4018;4068;4099;4100;4127;4138;4146;4180;4189;4201;4244;4251;4267;4275;4288;4291;4305;4309;4344;4355;4389;4396;4481;4503;4505;4510;4512;4530;4610;4702;4706;4800;4819;4951;4952;4996;6011;6031;6211;6246;6255;6387;%(DisableSpecificWarnings)/DisableSpecificWarnings
-  RuntimeLibraryMultiThreadedDLL/RuntimeLibrary
+  RuntimeLibraryMultiThreaded/RuntimeLibrary
   FunctionLevelLinkingfalse/FunctionLevelLinking
   FloatingPointExceptionsfalse/FloatingPointExceptions
   OpenMPSupportfalse/OpenMPSupport


Modified: trunk/WebKitLibraries/win/tools/vsprops/debugsuffix.props (172660 => 172661)

--- trunk/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2014-08-15 23:56:57 UTC (rev 172660)
+++ trunk/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2014-08-16 00:42:24 UTC (rev 172661)
@@ -11,7 +11,7 @@
   ItemDefinitionGroup
 ClCompile
   PreprocessorDefinitions_CONSOLE;DEBUG_INTERNAL;DEBUG_ALL;%(PreprocessorDefinitions)/PreprocessorDefinitions
-  RuntimeLibraryMultiThreadedDebugDLL/RuntimeLibrary
+  RuntimeLibraryMultiThreadedDebug/RuntimeLibrary
 /ClCompile
 Lib
   OutputFile$(OutDir)\$(ProjectName)$(DebugSuffix).lib/OutputFile






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172662] trunk/Source/WebInspectorUI

2014-08-15 Thread jonowells

Title: [172662] trunk/Source/WebInspectorUI








Revision 172662
Author jonowe...@apple.com
Date 2014-08-15 17:56:44 -0700 (Fri, 15 Aug 2014)


Log Message
Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting
https://bugs.webkit.org/show_bug.cgi?id=135995

Reviewed by Joseph Pecoraro.

Change so if an element is inspected via the Inspect Element context menu, selected
node restoration is disallowed until the main resource in the main frame changes.
This way an attempt by a sub-frame will not change the highlighted element in the
Main Frame's DOM tree unexpectedly.

* UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._mainResourceDidChange):
(WebInspector.DOMTreeManager.prototype.inspectElement):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (172661 => 172662)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-08-16 00:42:24 UTC (rev 172661)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-08-16 00:56:44 UTC (rev 172662)
@@ -1,3 +1,20 @@
+2014-08-15  Jono Wells  jonowe...@apple.com
+
+Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting
+https://bugs.webkit.org/show_bug.cgi?id=135995
+
+Reviewed by Joseph Pecoraro.
+
+Change so if an element is inspected via the Inspect Element context menu, selected
+node restoration is disallowed until the main resource in the main frame changes.
+This way an attempt by a sub-frame will not change the highlighted element in the
+Main Frame's DOM tree unexpectedly.
+
+* UserInterface/Controllers/DOMTreeManager.js:
+(WebInspector.DOMTreeManager):
+(WebInspector.DOMTreeManager.prototype._mainResourceDidChange):
+(WebInspector.DOMTreeManager.prototype.inspectElement):
+
 2014-08-15  Brian J. Burg  b...@cs.washington.edu
 
 Web Inspector: rewrite CodeGeneratorInspector to be modular and testable


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js (172661 => 172662)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js	2014-08-16 00:42:24 UTC (rev 172661)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js	2014-08-16 00:56:44 UTC (rev 172662)
@@ -37,6 +37,8 @@
 this._flows = new Map;
 this._contentNodesToFlowsMap = new Map;
 this._restoreSelectedNodeIsAllowed = true;
+
+WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
 };
 
 WebInspector.Object.addConstructorFunctions(WebInspector.DOMTreeManager);
@@ -271,8 +273,6 @@
 
 inspectElement: function(nodeId)
 {
-this._restoreSelectedNodeIsAllowed = true;
-
 var node = this._idToDOMNode[nodeId];
 if (node)
 this.dispatchEventToListeners(WebInspector.DOMTreeManager.Event.DOMNodeWasInspected, {node: node});
@@ -711,6 +711,14 @@
 
 return result;
 }
+},
+
+// Private
+
+_mainResourceDidChange: function(event)
+{
+if (event.target.isMainFrame())
+this._restoreSelectedNodeIsAllowed = true;
 }
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172663] trunk/Source/WebCore

2014-08-15 Thread benjamin

Title: [172663] trunk/Source/WebCore








Revision 172663
Author benja...@webkit.org
Date 2014-08-15 18:37:29 -0700 (Fri, 15 Aug 2014)


Log Message
CSS JIT: compile :-webkit-full-page-media
https://bugs.webkit.org/show_bug.cgi?id=135968

Reviewed by Alexey Proskuryakov.

Add the pseudo class :-webkit-full-page-media with an unoptimized function call.

It would be possible to inline it, but this selector is so uncommon I don't think
it is worth having any additional complexity for it.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorCheckerTestFunctions.h:
(WebCore::isMediaDocument):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (172662 => 172663)

--- trunk/Source/WebCore/ChangeLog	2014-08-16 00:56:44 UTC (rev 172662)
+++ trunk/Source/WebCore/ChangeLog	2014-08-16 01:37:29 UTC (rev 172663)
@@ -1,3 +1,22 @@
+2014-08-15  Benjamin Poulain  benja...@webkit.org
+
+CSS JIT: compile :-webkit-full-page-media
+https://bugs.webkit.org/show_bug.cgi?id=135968
+
+Reviewed by Alexey Proskuryakov.
+
+Add the pseudo class :-webkit-full-page-media with an unoptimized function call.
+
+It would be possible to inline it, but this selector is so uncommon I don't think
+it is worth having any additional complexity for it.
+
+* css/SelectorChecker.cpp:
+(WebCore::SelectorChecker::checkOne):
+* css/SelectorCheckerTestFunctions.h:
+(WebCore::isMediaDocument):
+* cssjit/SelectorCompiler.cpp:
+(WebCore::SelectorCompiler::addPseudoClassType):
+
 2014-08-15  Wenson Hsieh  wenson_hs...@apple.com
 
 Fix gliding in AxisScrollSnapAnimator for Mac


Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (172662 => 172663)

--- trunk/Source/WebCore/css/SelectorChecker.cpp	2014-08-16 00:56:44 UTC (rev 172662)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp	2014-08-16 01:37:29 UTC (rev 172663)
@@ -723,7 +723,7 @@
 case CSSSelector::PseudoClassEnabled:
 return isEnabled(element);
 case CSSSelector::PseudoClassFullPageMedia:
-return element-document().isMediaDocument();
+return isMediaDocument(element);
 case CSSSelector::PseudoClassDefault:
 return isDefaultButtonForForm(element);
 case CSSSelector::PseudoClassDisabled:


Modified: trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h (172662 => 172663)

--- trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h	2014-08-16 00:56:44 UTC (rev 172662)
+++ trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h	2014-08-16 01:37:29 UTC (rev 172663)
@@ -73,6 +73,11 @@
 return isEnabled;
 }
 
+ALWAYS_INLINE bool isMediaDocument(Element* element)
+{
+return element-document().isMediaDocument();
+}
+
 ALWAYS_INLINE bool isChecked(Element* element)
 {
 // Even though WinIE allows checked and indeterminate to co-exist, the CSS selector spec says that


Modified: trunk/Source/WebCore/cssjit/SelectorCompiler.cpp (172662 => 172663)

--- trunk/Source/WebCore/cssjit/SelectorCompiler.cpp	2014-08-16 00:56:44 UTC (rev 172662)
+++ trunk/Source/WebCore/cssjit/SelectorCompiler.cpp	2014-08-16 01:37:29 UTC (rev 172663)
@@ -430,6 +430,9 @@
 case CSSSelector::PseudoClassFocus:
 fragment.unoptimizedPseudoClasses.append(JSC::FunctionPtr(SelectorChecker::matchesFocusPseudoClass));
 return FunctionType::SimpleSelectorChecker;
+case CSSSelector::PseudoClassFullPageMedia:
+fragment.unoptimizedPseudoClasses.append(JSC::FunctionPtr(isMediaDocument));
+return FunctionType::SimpleSelectorChecker;
 case CSSSelector::PseudoClassInRange:
 fragment.unoptimizedPseudoClasses.append(JSC::FunctionPtr(isInRange));
 return FunctionType::SimpleSelectorChecker;
@@ -506,7 +509,6 @@
 case CSSSelector::PseudoClassNthLastOfType:
 case CSSSelector::PseudoClassVisited:
 case CSSSelector::PseudoClassDrag:
-case CSSSelector::PseudoClassFullPageMedia:
 return FunctionType::CannotCompile;
 
 // Optimized pseudo selectors.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172664] tags/Safari-600.1.10.1/

2014-08-15 Thread matthew_hanson

Title: [172664] tags/Safari-600.1.10.1/








Revision 172664
Author matthew_han...@apple.com
Date 2014-08-15 18:39:04 -0700 (Fri, 15 Aug 2014)


Log Message
New Tag.

Added Paths

tags/Safari-600.1.10.1/




Diff

Property changes: tags/Safari-600.1.10.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172665] trunk/Source/JavaScriptCore

2014-08-15 Thread msaboff

Title: [172665] trunk/Source/_javascript_Core








Revision 172665
Author msab...@apple.com
Date 2014-08-15 18:45:40 -0700 (Fri, 15 Aug 2014)


Log Message
Change callToJavaScript and callToNativeFunction so their callFrames match the native calling conventions
https://bugs.webkit.org/show_bug.cgi?id=131578

Reviewed by Geoffrey Garen.

Renamed callToJavaScript and callToNativeFunction to vmEntryToJavaScript and vmEntryToNative,
respectively.  Eliminated the sentinel frame and replaced it with the structure VMEntryRecord
that appears in the locals area of a VM entry stack frame.  Changed the order that
vmEntryToJavaScript and vmEntryToNative creates their stack frames to be native calling
convention compliant.  That is to save prior frame pointer, save callee save registers, then
allocate and populate the VMEntryRecord, and finally allocate a CallFrame for the JS function
that vmEntryToJavaScript will invoke.  The top most vm entry frame pointer is saved in
VM::topVMEntryFrame.  The vmEntry functions save prior contents of VM::topVMEntryFrame
along with the VM and VM::topCallFrame in the VMEntryRecord it places on the stack.  Starting
at VM::topCallFrame, the stack can be walked using these VMEntryRecords.

Arbitrary stack unwinding is now handled either iteratively by loading VM::topVMEntryFrame
into a local variable and using CallFrame::callerFrame(VMEntryFrame*) or by using StackVisitor.
Given that the stack is effectively a singly linked list, general stack unwinding needs to use
one of these two methods.

* _javascript_Core.vcxproj/_javascript_Core.vcxproj:
* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters:
* _javascript_Core.xcodeproj/project.pbxproj:
Addition of VMEntryRecord.h

* bytecode/BytecodeList.json:
Renaming of llint helper opcodes due to renaming callToJavaScript and callToNativeFunction.

* debugger/Debugger.cpp:
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::returnEvent):
(JSC::Debugger::didExecuteProgram):
* jsc.cpp:
(functionDumpCallFrame):
* jit/JITOperations.cpp:
Changed unwinding to use CallFrame::callerFrame(VMEntryFrame*).

* bytecode/CodeBlock.cpp:
(JSC::RecursionCheckFunctor::RecursionCheckFunctor):
(JSC::RecursionCheckFunctor::operator()):
(JSC::RecursionCheckFunctor::didRecurse):
(JSC::CodeBlock::noticeIncomingCall):
* debugger/DebuggerCallFrame.cpp:
(JSC::FindCallerMidStackFunctor::FindCallerMidStackFunctor):
(JSC::FindCallerMidStackFunctor::operator()):
(JSC::FindCallerMidStackFunctor::getCallerFrame):
(JSC::DebuggerCallFrame::callerFrame):
* interpreter/VMInspector.cpp:
(JSC::CountFramesFunctor::CountFramesFunctor):
(JSC::CountFramesFunctor::operator()):
(JSC::CountFramesFunctor::count):
(JSC::VMInspector::countFrames):
* runtime/VM.cpp:
(JSC::VM::VM):
(JSC::FindFirstCallerFrameWithCodeblockFunctor::FindFirstCallerFrameWithCodeblockFunctor):
(JSC::FindFirstCallerFrameWithCodeblockFunctor::operator()):
(JSC::FindFirstCallerFrameWithCodeblockFunctor::foundCallFrame):
(JSC::FindFirstCallerFrameWithCodeblockFunctor::index):
(JSC::VM::throwException):
Changed unwinding to use StackVisitor including added functor classes.

* interpreter/CallFrame.cpp:
(JSC::CallFrame::callerFrame):
Added new flavor of callerFrame() that can iteratively unwind the stack.

* interpreter/CallFrame.h:
(JSC::ExecState::callerFrame): Changed callerFrame() to use private common helper.
(JSC::ExecState::callerFrameOrVMEntryFrame): Deleted.
(JSC::ExecState::isVMEntrySentinel): Deleted.
(JSC::ExecState::vmEntrySentinelCallerFrame): Deleted.
(JSC::ExecState::initializeVMEntrySentinelFrame): Deleted.
(JSC::ExecState::callerFrameSkippingVMEntrySentinel): Deleted.
(JSC::ExecState::vmEntrySentinelCodeBlock): Deleted.

* interpreter/CallFrame.h:
(JSC::ExecState::init):
(JSC::ExecState::topOfFrame):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
Eliminated unneded checking of sentinel frame.

* interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::Interpreter::getStackTrace): Updated for unwidning changes.
(JSC::Interpreter::unwind): Eliminated unneeded sentinel frame check.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
* jit/JITStubs.h:
* llint/LLIntThunks.cpp:
(JSC::callToJavaScript): Deleted.
(JSC::callToNativetion): Deleted.
(JSC::vmEntryToJavaScript):
(JSC::vmEntryToNative):
* llint/LLIntThunks.h:
Updated for vmEntryToJavaScript and vmEntryToNative name changes.

* interpreter/Interpreter.h:
(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):
Eliminated unneeded sentinel frame check.

* interpreter/Interpreter.h:
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
Removed sentinel specific constructor.

* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::StackVisitor):
(JSC::StackVisitor::readFrame):
(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::readInlinedFrame):
(JSC::StackVisitor::Frame::print):
* interpreter/StackVisitor.h:

[webkit-changes] [172666] tags/Safari-600.1.10.1/Source

2014-08-15 Thread matthew_hanson

Title: [172666] tags/Safari-600.1.10.1/Source








Revision 172666
Author matthew_han...@apple.com
Date 2014-08-15 18:47:48 -0700 (Fri, 15 Aug 2014)


Log Message
Versioning.

Modified Paths

tags/Safari-600.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-600.1.10.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-600.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-600.1.10.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-600.1.10.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-600.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig (172665 => 172666)

--- tags/Safari-600.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-16 01:45:40 UTC (rev 172665)
+++ tags/Safari-600.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-16 01:47:48 UTC (rev 172666)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-600.1.10.1/Source/WebCore/Configurations/Version.xcconfig (172665 => 172666)

--- tags/Safari-600.1.10.1/Source/WebCore/Configurations/Version.xcconfig	2014-08-16 01:45:40 UTC (rev 172665)
+++ tags/Safari-600.1.10.1/Source/WebCore/Configurations/Version.xcconfig	2014-08-16 01:47:48 UTC (rev 172666)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-600.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig (172665 => 172666)

--- tags/Safari-600.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-16 01:45:40 UTC (rev 172665)
+++ tags/Safari-600.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-16 01:47:48 UTC (rev 172666)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX = $(SYSTEM_VERSION_PREFIX_$(PLATFORM_NAME));


Modified: tags/Safari-600.1.10.1/Source/WebKit/mac/Configurations/Version.xcconfig (172665 => 172666)

--- tags/Safari-600.1.10.1/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-16 01:45:40 UTC (rev 172665)
+++ tags/Safari-600.1.10.1/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-16 01:47:48 UTC (rev 172666)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-600.1.10.1/Source/WebKit2/Configurations/Version.xcconfig (172665 => 172666)

--- tags/Safari-600.1.10.1/Source/WebKit2/Configurations/Version.xcconfig	2014-08-16 01:45:40 UTC (rev 172665)
+++ tags/Safari-600.1.10.1/Source/WebKit2/Configurations/Version.xcconfig	2014-08-16 01:47:48 UTC (rev 172666)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172667] tags/Safari-600.1.2.10.1/

2014-08-15 Thread matthew_hanson

Title: [172667] tags/Safari-600.1.2.10.1/








Revision 172667
Author matthew_han...@apple.com
Date 2014-08-15 18:52:24 -0700 (Fri, 15 Aug 2014)


Log Message
New Tag.

Added Paths

tags/Safari-600.1.2.10.1/




Diff

Property changes: tags/Safari-600.1.2.10.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172668] tags/Safari-600.1.10.1/

2014-08-15 Thread matthew_hanson

Title: [172668] tags/Safari-600.1.10.1/








Revision 172668
Author matthew_han...@apple.com
Date 2014-08-15 18:54:07 -0700 (Fri, 15 Aug 2014)


Log Message
Delete tag.

Removed Paths

tags/Safari-600.1.10.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172669] tags/Safari-600.1.2.10.1/Source

2014-08-15 Thread matthew_hanson

Title: [172669] tags/Safari-600.1.2.10.1/Source








Revision 172669
Author matthew_han...@apple.com
Date 2014-08-15 18:59:08 -0700 (Fri, 15 Aug 2014)


Log Message
Versioning.

Modified Paths

tags/Safari-600.1.2.10.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-600.1.2.10.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-600.1.2.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-600.1.2.10.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-600.1.2.10.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-600.1.2.10.1/Source/_javascript_Core/Configurations/Version.xcconfig (172668 => 172669)

--- tags/Safari-600.1.2.10.1/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-16 01:54:07 UTC (rev 172668)
+++ tags/Safari-600.1.2.10.1/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-16 01:59:08 UTC (rev 172669)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 2;
 MICRO_VERSION = 10;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-600.1.2.10.1/Source/WebCore/Configurations/Version.xcconfig (172668 => 172669)

--- tags/Safari-600.1.2.10.1/Source/WebCore/Configurations/Version.xcconfig	2014-08-16 01:54:07 UTC (rev 172668)
+++ tags/Safari-600.1.2.10.1/Source/WebCore/Configurations/Version.xcconfig	2014-08-16 01:59:08 UTC (rev 172669)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 2;
 MICRO_VERSION = 10;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-600.1.2.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig (172668 => 172669)

--- tags/Safari-600.1.2.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-16 01:54:07 UTC (rev 172668)
+++ tags/Safari-600.1.2.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-16 01:59:08 UTC (rev 172669)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 2;
 MICRO_VERSION = 10;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX = $(SYSTEM_VERSION_PREFIX_$(PLATFORM_NAME));


Modified: tags/Safari-600.1.2.10.1/Source/WebKit/mac/Configurations/Version.xcconfig (172668 => 172669)

--- tags/Safari-600.1.2.10.1/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-16 01:54:07 UTC (rev 172668)
+++ tags/Safari-600.1.2.10.1/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-16 01:59:08 UTC (rev 172669)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 2;
 MICRO_VERSION = 10;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-600.1.2.10.1/Source/WebKit2/Configurations/Version.xcconfig (172668 => 172669)

--- tags/Safari-600.1.2.10.1/Source/WebKit2/Configurations/Version.xcconfig	2014-08-16 01:54:07 UTC (rev 172668)
+++ tags/Safari-600.1.2.10.1/Source/WebKit2/Configurations/Version.xcconfig	2014-08-16 01:59:08 UTC (rev 172669)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 2;
 MICRO_VERSION = 10;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172670] tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog

2014-08-15 Thread matthew_hanson

Title: [172670] tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog








Revision 172670
Author matthew_han...@apple.com
Date 2014-08-15 19:03:11 -0700 (Fri, 15 Aug 2014)


Log Message
Merge r172019. rdar://problem/18029617

Modified Paths

tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog




Diff

Modified: tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog (172669 => 172670)

--- tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog	2014-08-16 01:59:08 UTC (rev 172669)
+++ tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog	2014-08-16 02:03:11 UTC (rev 172670)
@@ -1,3 +1,18 @@
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
+Merge r172019. rdar://problem/18029617
+
+2014-08-04  Matthew Hanson  matthew_han...@apple.com
+
+[Win] Temporarily turn off WebGL feature.
+https://bugs.webkit.org/show_bug.cgi?id=135543
+
+Unreviewed build fix.
+
+Landed on behalf of Brent Fulgham.
+
+* win/tools/vsprops/FeatureDefines.props: Deactivate feature.
+
 2014-08-05  Brent Fulgham  bfulg...@apple.com
 
 [Win] Turn off features we don't want to ship this cycle.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172671] tags/Safari-600.1.2.10.1/WebKitLibraries

2014-08-15 Thread matthew_hanson

Title: [172671] tags/Safari-600.1.2.10.1/WebKitLibraries








Revision 172671
Author matthew_han...@apple.com
Date 2014-08-15 19:05:48 -0700 (Fri, 15 Aug 2014)


Log Message
Merge r172661. rdar://problem/18037766

Modified Paths

tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog
tags/Safari-600.1.2.10.1/WebKitLibraries/win/tools/vsprops/common.props
tags/Safari-600.1.2.10.1/WebKitLibraries/win/tools/vsprops/debugsuffix.props




Diff

Modified: tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog (172670 => 172671)

--- tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog	2014-08-16 02:03:11 UTC (rev 172670)
+++ tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog	2014-08-16 02:05:48 UTC (rev 172671)
@@ -1,5 +1,20 @@
 2014-08-15  Matthew Hanson  matthew_han...@apple.com
 
+Merge r172661. rdar://problem/18037766
+
+2014-08-15  Brent Fulgham  bfulg...@apple.com
+
+[Win] Link to static VS2013 runtime library.
+https://bugs.webkit.org/show_bug.cgi?id=136007
+rdar://problem/18037766
+
+Reviewed by Dean Jackson.
+
+* win/tools/vsprops/common.props: Update link command.
+* win/tools/vsprops/debugsuffix.props: Ditto.
+
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
 Merge r172019. rdar://problem/18029617
 
 2014-08-04  Matthew Hanson  matthew_han...@apple.com


Modified: tags/Safari-600.1.2.10.1/WebKitLibraries/win/tools/vsprops/common.props (172670 => 172671)

--- tags/Safari-600.1.2.10.1/WebKitLibraries/win/tools/vsprops/common.props	2014-08-16 02:03:11 UTC (rev 172670)
+++ tags/Safari-600.1.2.10.1/WebKitLibraries/win/tools/vsprops/common.props	2014-08-16 02:05:48 UTC (rev 172671)
@@ -47,7 +47,7 @@
   TreatWarningAsErrorfalse/TreatWarningAsError
   DebugInformationFormatProgramDatabase/DebugInformationFormat
   DisableSpecificWarnings4018;4068;4099;4100;4127;4138;4146;4180;4189;4201;4244;4251;4267;4275;4288;4291;4305;4309;4344;4355;4389;4396;4481;4503;4505;4510;4512;4530;4610;4702;4706;4800;4819;4951;4952;4996;6011;6031;6211;6246;6255;6387;%(DisableSpecificWarnings)/DisableSpecificWarnings
-  RuntimeLibraryMultiThreadedDLL/RuntimeLibrary
+  RuntimeLibraryMultiThreaded/RuntimeLibrary
   FunctionLevelLinkingfalse/FunctionLevelLinking
   FloatingPointExceptionsfalse/FloatingPointExceptions
   OpenMPSupportfalse/OpenMPSupport


Modified: tags/Safari-600.1.2.10.1/WebKitLibraries/win/tools/vsprops/debugsuffix.props (172670 => 172671)

--- tags/Safari-600.1.2.10.1/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2014-08-16 02:03:11 UTC (rev 172670)
+++ tags/Safari-600.1.2.10.1/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2014-08-16 02:05:48 UTC (rev 172671)
@@ -11,7 +11,7 @@
   ItemDefinitionGroup
 ClCompile
   PreprocessorDefinitions_CONSOLE;DEBUG_INTERNAL;DEBUG_ALL;%(PreprocessorDefinitions)/PreprocessorDefinitions
-  RuntimeLibraryMultiThreadedDebugDLL/RuntimeLibrary
+  RuntimeLibraryMultiThreadedDebug/RuntimeLibrary
 /ClCompile
 Lib
   OutputFile$(OutDir)\$(ProjectName)$(DebugSuffix).lib/OutputFile






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172673] tags/Safari-600.1.10.1/

2014-08-15 Thread matthew_hanson

Title: [172673] tags/Safari-600.1.10.1/








Revision 172673
Author matthew_han...@apple.com
Date 2014-08-15 19:10:20 -0700 (Fri, 15 Aug 2014)


Log Message
New Tag.

Added Paths

tags/Safari-600.1.10.1/




Diff

Property changes: tags/Safari-600.1.10.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172674] tags/Safari-600.1.2.10.1/

2014-08-15 Thread matthew_hanson

Title: [172674] tags/Safari-600.1.2.10.1/








Revision 172674
Author matthew_han...@apple.com
Date 2014-08-15 19:11:43 -0700 (Fri, 15 Aug 2014)


Log Message
Delete Tag.

Removed Paths

tags/Safari-600.1.2.10.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172675] tags/Safari-600.1.10.1/Source

2014-08-15 Thread matthew_hanson

Title: [172675] tags/Safari-600.1.10.1/Source








Revision 172675
Author matthew_han...@apple.com
Date 2014-08-15 19:14:29 -0700 (Fri, 15 Aug 2014)


Log Message
Versioning.

Modified Paths

tags/Safari-600.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-600.1.10.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-600.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-600.1.10.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-600.1.10.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-600.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig (172674 => 172675)

--- tags/Safari-600.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-16 02:11:43 UTC (rev 172674)
+++ tags/Safari-600.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig	2014-08-16 02:14:29 UTC (rev 172675)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-600.1.10.1/Source/WebCore/Configurations/Version.xcconfig (172674 => 172675)

--- tags/Safari-600.1.10.1/Source/WebCore/Configurations/Version.xcconfig	2014-08-16 02:11:43 UTC (rev 172674)
+++ tags/Safari-600.1.10.1/Source/WebCore/Configurations/Version.xcconfig	2014-08-16 02:14:29 UTC (rev 172675)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-600.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig (172674 => 172675)

--- tags/Safari-600.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-16 02:11:43 UTC (rev 172674)
+++ tags/Safari-600.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2014-08-16 02:14:29 UTC (rev 172675)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX = $(SYSTEM_VERSION_PREFIX_$(PLATFORM_NAME));


Modified: tags/Safari-600.1.10.1/Source/WebKit/mac/Configurations/Version.xcconfig (172674 => 172675)

--- tags/Safari-600.1.10.1/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-16 02:11:43 UTC (rev 172674)
+++ tags/Safari-600.1.10.1/Source/WebKit/mac/Configurations/Version.xcconfig	2014-08-16 02:14:29 UTC (rev 172675)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-600.1.10.1/Source/WebKit2/Configurations/Version.xcconfig (172674 => 172675)

--- tags/Safari-600.1.10.1/Source/WebKit2/Configurations/Version.xcconfig	2014-08-16 02:11:43 UTC (rev 172674)
+++ tags/Safari-600.1.10.1/Source/WebKit2/Configurations/Version.xcconfig	2014-08-16 02:14:29 UTC (rev 172675)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 600;
 MINOR_VERSION = 1;
 TINY_VERSION = 10;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172676] tags/Safari-600.1.10.1

2014-08-15 Thread matthew_hanson

Title: [172676] tags/Safari-600.1.10.1








Revision 172676
Author matthew_han...@apple.com
Date 2014-08-15 19:23:43 -0700 (Fri, 15 Aug 2014)


Log Message
Merge r172019. rdar://problem/18029617

Modified Paths

tags/Safari-600.1.10.1/Source/WTF/ChangeLog
tags/Safari-600.1.10.1/Source/WTF/wtf/FeatureDefines.h
tags/Safari-600.1.10.1/Source/WebKit/ChangeLog
tags/Safari-600.1.10.1/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props
tags/Safari-600.1.10.1/WebKitLibraries/ChangeLog
tags/Safari-600.1.10.1/WebKitLibraries/win/tools/vsprops/FeatureDefines.props




Diff

Modified: tags/Safari-600.1.10.1/Source/WTF/ChangeLog (172675 => 172676)

--- tags/Safari-600.1.10.1/Source/WTF/ChangeLog	2014-08-16 02:14:29 UTC (rev 172675)
+++ tags/Safari-600.1.10.1/Source/WTF/ChangeLog	2014-08-16 02:23:43 UTC (rev 172676)
@@ -1,3 +1,16 @@
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
+Merge r172019. rdar://problem/18029617
+
+2014-08-04  Matthew Hanson  matthew_han...@apple.com
+
+[Win] Temporarily turn off WebGL.
+https://bugs.webkit.org/show_bug.cgi?id=135543
+
+Landed on behalf of Brent Fulgham.
+
+* wtf/FeatureDefines.h: Turn off WebGL feature.
+
 2014-07-30  Lucas Forschler  lforsch...@apple.com
 
 Merge r171825


Modified: tags/Safari-600.1.10.1/Source/WTF/wtf/FeatureDefines.h (172675 => 172676)

--- tags/Safari-600.1.10.1/Source/WTF/wtf/FeatureDefines.h	2014-08-16 02:14:29 UTC (rev 172675)
+++ tags/Safari-600.1.10.1/Source/WTF/wtf/FeatureDefines.h	2014-08-16 02:23:43 UTC (rev 172676)
@@ -249,9 +249,12 @@
 #define ENABLE_WEB_ARCHIVE 1
 #endif
 
+/*
+FIXME: Remove under https://bugs.webkit.org/show_bug.cgi?id=135543
 #if !defined(ENABLE_WEBGL)
 #define ENABLE_WEBGL 1
 #endif
+*/
 
 #endif /* PLATFORM(WIN)  !OS(WINCE)  !PLATFORM(WIN_CAIRO) */
 


Modified: tags/Safari-600.1.10.1/Source/WebKit/ChangeLog (172675 => 172676)

--- tags/Safari-600.1.10.1/Source/WebKit/ChangeLog	2014-08-16 02:14:29 UTC (rev 172675)
+++ tags/Safari-600.1.10.1/Source/WebKit/ChangeLog	2014-08-16 02:23:43 UTC (rev 172676)
@@ -1,3 +1,19 @@
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
+Merge r172019. rdar://problem/18029617
+
+2014-08-04  Matthew Hanson  matthew_han...@apple.com
+
+[Win] Temporarily deactivate WebGL.
+https://bugs.webkit.org/show_bug.cgi?id=135543
+
+Unreviewed build fix.
+
+Landed on behalf of Brent Fulgham.
+
+* WebKit.vcxproj/WebKit/WebKitCommon.props: Avoid
+linking to ANGLE-based libraries.
+
 2014-08-07  Dana Burkart dburk...@apple.com
 
 Merge r172241


Modified: tags/Safari-600.1.10.1/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props (172675 => 172676)

--- tags/Safari-600.1.10.1/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props	2014-08-16 02:14:29 UTC (rev 172675)
+++ tags/Safari-600.1.10.1/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props	2014-08-16 02:23:43 UTC (rev 172676)
@@ -13,7 +13,7 @@
   ForcedIncludeFilesWebKitPrefix.h;ICUVersion.h;%(ForcedIncludeFiles)/ForcedIncludeFiles
 /ClCompile
 Link
-  AdditionalDependencieslibEGL.lib;libGLESv2.lib;preprocessor.lib;translator_common.lib;translator_glsl.lib;translator_hlsl.lib;opengl32.lib;delayimp.lib;kernel32.lib;user32.lib;gdi32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;odbc32.lib;odbccp32.lib;usp10.lib;comctl32.lib;version.lib;shlwapi.lib;libxslt$(DebugSuffix).lib;libxml2$(DebugSuffix).lib;libicuin$(DebugSuffix).lib;libicuuc$(DebugSuffix).lib;WTF$(DebugSuffix).lib;_javascript_Core$(DebugSuffix).lib;WebCore$(DebugSuffix).lib;WebKitGUID$(DebugSuffix).lib;SQLite3$(DebugSuffix).lib;msimg32.lib;crypt32.lib;iphlpapi.lib;winmm.lib;comsuppw.lib;rpcrt4.lib;zdll$(DebugSuffix).lib;uuid.lib;%(AdditionalDependencies)/AdditionalDependencies
+  AdditionalDependenciesopengl32.lib;delayimp.lib;kernel32.lib;user32.lib;gdi32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;odbc32.lib;odbccp32.lib;usp10.lib;comctl32.lib;version.lib;shlwapi.lib;libxslt$(DebugSuffix).lib;libxml2$(DebugSuffix).lib;libicuin$(DebugSuffix).lib;libicuuc$(DebugSuffix).lib;WTF$(DebugSuffix).lib;_javascript_Core$(DebugSuffix).lib;WebCore$(DebugSuffix).lib;WebKitGUID$(DebugSuffix).lib;SQLite3$(DebugSuffix).lib;msimg32.lib;crypt32.lib;iphlpapi.lib;winmm.lib;comsuppw.lib;rpcrt4.lib;zdll$(DebugSuffix).lib;uuid.lib;%(AdditionalDependencies)/AdditionalDependencies
   ModuleDefinitionFile$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\WebKitExportGenerator\WebKitExports.def/ModuleDefinitionFile
   DelayLoadDLLsusp10.dll;comctl32.dll;version.dll;iphlpapi.dll;%(DelayLoadDLLs)/DelayLoadDLLs
 /Link


Modified: tags/Safari-600.1.10.1/WebKitLibraries/ChangeLog (172675 => 172676)

--- tags/Safari-600.1.10.1/WebKitLibraries/ChangeLog	2014-08-16 02:14:29 UTC (rev 172675)
+++ tags/Safari-600.1.10.1/WebKitLibraries/ChangeLog	2014-08-16 02:23:43 UTC (rev

[webkit-changes] [172677] tags/Safari-600.1.10.1/WebKitLibraries

2014-08-15 Thread matthew_hanson

Title: [172677] tags/Safari-600.1.10.1/WebKitLibraries








Revision 172677
Author matthew_han...@apple.com
Date 2014-08-15 19:25:29 -0700 (Fri, 15 Aug 2014)


Log Message
Merge r172661. rdar://problem/18037766

Modified Paths

tags/Safari-600.1.10.1/WebKitLibraries/ChangeLog
tags/Safari-600.1.10.1/WebKitLibraries/win/tools/vsprops/common.props
tags/Safari-600.1.10.1/WebKitLibraries/win/tools/vsprops/debugsuffix.props




Diff

Modified: tags/Safari-600.1.10.1/WebKitLibraries/ChangeLog (172676 => 172677)

--- tags/Safari-600.1.10.1/WebKitLibraries/ChangeLog	2014-08-16 02:23:43 UTC (rev 172676)
+++ tags/Safari-600.1.10.1/WebKitLibraries/ChangeLog	2014-08-16 02:25:29 UTC (rev 172677)
@@ -1,5 +1,20 @@
 2014-08-15  Matthew Hanson  matthew_han...@apple.com
 
+Merge r172661. rdar://problem/18037766
+
+2014-08-15  Brent Fulgham  bfulg...@apple.com
+
+[Win] Link to static VS2013 runtime library.
+https://bugs.webkit.org/show_bug.cgi?id=136007
+rdar://problem/18037766
+
+Reviewed by Dean Jackson.
+
+* win/tools/vsprops/common.props: Update link command.
+* win/tools/vsprops/debugsuffix.props: Ditto.
+
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
 Merge r172019. rdar://problem/18029617
 
 2014-08-04  Matthew Hanson  matthew_han...@apple.com


Modified: tags/Safari-600.1.10.1/WebKitLibraries/win/tools/vsprops/common.props (172676 => 172677)

--- tags/Safari-600.1.10.1/WebKitLibraries/win/tools/vsprops/common.props	2014-08-16 02:23:43 UTC (rev 172676)
+++ tags/Safari-600.1.10.1/WebKitLibraries/win/tools/vsprops/common.props	2014-08-16 02:25:29 UTC (rev 172677)
@@ -47,7 +47,7 @@
   TreatWarningAsErrorfalse/TreatWarningAsError
   DebugInformationFormatProgramDatabase/DebugInformationFormat
   DisableSpecificWarnings4018;4068;4099;4100;4127;4138;4146;4180;4189;4201;4244;4251;4267;4275;4288;4291;4305;4309;4344;4355;4389;4396;4481;4503;4505;4510;4512;4530;4610;4702;4706;4800;4819;4951;4952;4996;6011;6031;6211;6246;6255;6387;%(DisableSpecificWarnings)/DisableSpecificWarnings
-  RuntimeLibraryMultiThreadedDLL/RuntimeLibrary
+  RuntimeLibraryMultiThreaded/RuntimeLibrary
   FunctionLevelLinkingfalse/FunctionLevelLinking
   FloatingPointExceptionsfalse/FloatingPointExceptions
   OpenMPSupportfalse/OpenMPSupport


Modified: tags/Safari-600.1.10.1/WebKitLibraries/win/tools/vsprops/debugsuffix.props (172676 => 172677)

--- tags/Safari-600.1.10.1/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2014-08-16 02:23:43 UTC (rev 172676)
+++ tags/Safari-600.1.10.1/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2014-08-16 02:25:29 UTC (rev 172677)
@@ -11,7 +11,7 @@
   ItemDefinitionGroup
 ClCompile
   PreprocessorDefinitions_CONSOLE;DEBUG_INTERNAL;DEBUG_ALL;%(PreprocessorDefinitions)/PreprocessorDefinitions
-  RuntimeLibraryMultiThreadedDebugDLL/RuntimeLibrary
+  RuntimeLibraryMultiThreadedDebug/RuntimeLibrary
 /ClCompile
 Lib
   OutputFile$(OutDir)\$(ProjectName)$(DebugSuffix).lib/OutputFile






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172679] trunk/Source/WebCore

2014-08-15 Thread benjamin

Title: [172679] trunk/Source/WebCore








Revision 172679
Author benja...@webkit.org
Date 2014-08-15 19:49:30 -0700 (Fri, 15 Aug 2014)


Log Message
Unify the modes style resolution modes SharingRules and StyleInvalidation
https://bugs.webkit.org/show_bug.cgi?id=135969

Reviewed by Andreas Kling.

Unifying the Collector and SelectorCheckers was done in previous patches,
this is just removing the enums.

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
* css/SelectorChecker.h:
* css/StyleInvalidationAnalysis.cpp:
(WebCore::invalidateStyleRecursively):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/ElementRuleCollector.cpp
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorChecker.h
trunk/Source/WebCore/css/StyleInvalidationAnalysis.cpp
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (172678 => 172679)

--- trunk/Source/WebCore/ChangeLog	2014-08-16 02:32:54 UTC (rev 172678)
+++ trunk/Source/WebCore/ChangeLog	2014-08-16 02:49:30 UTC (rev 172679)
@@ -1,5 +1,26 @@
 2014-08-15  Benjamin Poulain  benja...@webkit.org
 
+Unify the modes style resolution modes SharingRules and StyleInvalidation
+https://bugs.webkit.org/show_bug.cgi?id=135969
+
+Reviewed by Andreas Kling.
+
+Unifying the Collector and SelectorCheckers was done in previous patches,
+this is just removing the enums.
+
+* css/ElementRuleCollector.cpp:
+(WebCore::ElementRuleCollector::collectMatchingRules):
+(WebCore::ElementRuleCollector::hasAnyMatchingRules):
+* css/SelectorChecker.cpp:
+(WebCore::SelectorChecker::match):
+* css/SelectorChecker.h:
+* css/StyleInvalidationAnalysis.cpp:
+(WebCore::invalidateStyleRecursively):
+* cssjit/SelectorCompiler.cpp:
+(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):
+
+2014-08-15  Benjamin Poulain  benja...@webkit.org
+
 CSS JIT: compile :-webkit-full-page-media
 https://bugs.webkit.org/show_bug.cgi?id=135968
 


Modified: trunk/Source/WebCore/css/ElementRuleCollector.cpp (172678 => 172679)

--- trunk/Source/WebCore/css/ElementRuleCollector.cpp	2014-08-16 02:32:54 UTC (rev 172678)
+++ trunk/Source/WebCore/css/ElementRuleCollector.cpp	2014-08-16 02:49:30 UTC (rev 172679)
@@ -145,7 +145,7 @@
 {
 ASSERT(matchRequest.ruleSet);
 ASSERT_WITH_MESSAGE(!(m_mode == SelectorChecker::Mode::ResolvingStyle  !m_style), When resolving style, the SelectorChecker must have a style to set the pseudo elements and/or to do marking. The SelectorCompiler also rely on that behavior.);
-ASSERT_WITH_MESSAGE(!((m_mode == SelectorChecker::Mode::StyleInvalidation || m_mode == SelectorChecker::Mode::SharingRules)  m_pseudoStyleRequest.pseudoId != NOPSEUDO), When in mode StyleInvalidation or SharingRules, SelectorChecker does not try to match the pseudo ID. While ElementRuleCollector supports matching a particular pseudoId in this case, this would indicate a error at the call site since matching a particular element should be unnecessary.);
+ASSERT_WITH_MESSAGE(!(m_mode == SelectorChecker::Mode::CollectingRulesIgnoringVirtualPseudoElements  m_pseudoStyleRequest.pseudoId != NOPSEUDO), When in StyleInvalidation or SharingRules, SelectorChecker does not try to match the pseudo ID. While ElementRuleCollector supports matching a particular pseudoId in this case, this would indicate a error at the call site since matching a particular element should be unnecessary.);
 
 #if ENABLE(VIDEO_TRACK)
 if (m_element.isWebVTTElement())
@@ -430,7 +430,7 @@
 {
 clearMatchedRules();
 
-m_mode = SelectorChecker::Mode::SharingRules;
+m_mode = SelectorChecker::Mode::CollectingRulesIgnoringVirtualPseudoElements;
 int firstRuleIndex = -1, lastRuleIndex = -1;
 StyleResolver::RuleRange ruleRange(firstRuleIndex, lastRuleIndex);
 collectMatchingRules(MatchRequest(ruleSet), ruleRange);


Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (172678 => 172679)

--- trunk/Source/WebCore/css/SelectorChecker.cpp	2014-08-16 02:32:54 UTC (rev 172678)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp	2014-08-16 02:49:30 UTC (rev 172679)
@@ -146,8 +146,9 @@
 if (m_mode == Mode::ResolvingStyle  pseudoId  FIRST_INTERNAL_PSEUDOID)
 context.elementStyle-setHasPseudoStyle(pseudoId);
 
-// For SharingRules testing, any match is good enough, we don't care what is matched.
-return m_mode == Mode::SharingRules || m_mode == Mode::StyleInvalidation;
+// When ignoring virtual pseudo elements, the context's pseudo should also be NOPSEUDO but that

[webkit-changes] [172680] trunk

2014-08-15 Thread ap

Title: [172680] trunk








Revision 172680
Author a...@apple.com
Date 2014-08-15 19:57:58 -0700 (Fri, 15 Aug 2014)


Log Message
REGRESSION (r172660): WebKit2.TerminateTwice asserts
https://bugs.webkit.org/show_bug.cgi?id=136012

Source/WebKit2:

* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::terminateProcess):
Added bug number to a fixme.

Tools:

* TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (172679 => 172680)

--- trunk/Source/WebKit2/ChangeLog	2014-08-16 02:49:30 UTC (rev 172679)
+++ trunk/Source/WebKit2/ChangeLog	2014-08-16 02:57:58 UTC (rev 172680)
@@ -1,3 +1,11 @@
+2014-08-15  Alexey Proskuryakov  a...@apple.com
+
+REGRESSION (r172660): WebKit2.TerminateTwice asserts
+https://bugs.webkit.org/show_bug.cgi?id=136012
+
+* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::terminateProcess):
+Added bug number to a fixme.
+
 2014-08-15  Ryuan Choi  ryuan.c...@samsung.com
 
 Unreviewed build fix on the EFL port since r172635


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (172679 => 172680)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-08-16 02:49:30 UTC (rev 172679)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-08-16 02:57:58 UTC (rev 172680)
@@ -1873,6 +1873,7 @@
 {
 // requestTermination() is a no-op for launching processes, so we get into an inconsistent state by calling resetStateAfterProcessExited().
 // FIXME: A client can terminate the page at any time, so we should do something more meaningful than assert and fall apart in release builds.
+// See also https://bugs.webkit.org/show_bug.cgi?id=136012.
 ASSERT(m_process-state() != WebProcessProxy::State::Launching);
 
 // NOTE: This uses a check of m_isValid rather than calling isValid() since


Modified: trunk/Tools/ChangeLog (172679 => 172680)

--- trunk/Tools/ChangeLog	2014-08-16 02:49:30 UTC (rev 172679)
+++ trunk/Tools/ChangeLog	2014-08-16 02:57:58 UTC (rev 172680)
@@ -1,3 +1,10 @@
+2014-08-15  Alexey Proskuryakov  a...@apple.com
+
+REGRESSION (r172660): WebKit2.TerminateTwice asserts
+https://bugs.webkit.org/show_bug.cgi?id=136012
+
+* TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
+
 2014-08-15  Ryuan Choi  ryuan.c...@samsung.com
 
 Unreviewed build fix attempt on the CMake based pots since r172665


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp (172679 => 172680)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp	2014-08-16 02:49:30 UTC (rev 172679)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp	2014-08-16 02:57:58 UTC (rev 172680)
@@ -29,6 +29,9 @@
 
 namespace TestWebKitAPI {
 
+// Disabled in debug mode while investigating https://bugs.webkit.org/show_bug.cgi?id=136012.
+#ifdef NDEBUG
+
 static bool loaded;
 
 static void didFinishLoadForFrame(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void* clientInfo)
@@ -62,5 +65,7 @@
 WKPageTerminate(webView.page());
 }
 
+#endif
+
 } // namespace TestWebKitAPI
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172681] trunk/Source

2014-08-15 Thread zalan

Title: [172681] trunk/Source








Revision 172681
Author za...@apple.com
Date 2014-08-15 21:03:42 -0700 (Fri, 15 Aug 2014)


Log Message
Do not use FloatRect::infiniteRect() to flag full repaints.
https://bugs.webkit.org/show_bug.cgi?id=135900

Reviewed by Simon Fraser.

Converting FloatRect::infiniteRect() to IntRect leads to value overflow
and we end up with invalid repaint rectangle. Use a boolean flag to indicate
full repaint request.

Covered by existing tests.

Source/WebCore:

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setNeedsDisplay):
(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):
(WebCore::GraphicsLayerCA::repaintLayerDirtyRects):
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::setTileNeedsDisplayInRect):
* platform/graphics/ca/mac/PlatformCALayerMac.h:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::setNeedsDisplay):
(PlatformCALayerMac::setNeedsDisplayInRect):

Source/WebKit2:

* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemote::setNeedsDisplay):
* WebProcess/WebPage/mac/PlatformCALayerRemote.h:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemoteCustom::setNeedsDisplay):
* WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:
(WebKit::PlatformCALayerRemoteTiledBacking::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemoteTiledBacking::setNeedsDisplay):
* WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (172680 => 172681)

--- trunk/Source/WebCore/ChangeLog	2014-08-16 02:57:58 UTC (rev 172680)
+++ trunk/Source/WebCore/ChangeLog	2014-08-16 04:03:42 UTC (rev 172681)
@@ -1,3 +1,30 @@
+2014-08-15  Zalan Bujtas  za...@apple.com
+
+Do not use FloatRect::infiniteRect() to flag full repaints.
+https://bugs.webkit.org/show_bug.cgi?id=135900
+
+Reviewed by Simon Fraser.
+
+Converting FloatRect::infiniteRect() to IntRect leads to value overflow
+and we end up with invalid repaint rectangle. Use a boolean flag to indicate
+full repaint request.
+
+Covered by existing tests.
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::GraphicsLayerCA):
+(WebCore::GraphicsLayerCA::setNeedsDisplay):
+(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):
+(WebCore::GraphicsLayerCA::repaintLayerDirtyRects):
+* platform/graphics/ca/GraphicsLayerCA.h:
+* platform/graphics/ca/PlatformCALayer.h:
+* platform/graphics/ca/TileGrid.cpp:
+(WebCore::TileGrid::setTileNeedsDisplayInRect):
+* platform/graphics/ca/mac/PlatformCALayerMac.h:
+* platform/graphics/ca/mac/PlatformCALayerMac.mm:
+(PlatformCALayerMac::setNeedsDisplay):
+(PlatformCALayerMac::setNeedsDisplayInRect):
+
 2014-08-15  Benjamin Poulain  benja...@webkit.org
 
 Unify the modes style resolution modes SharingRules and StyleInvalidation


Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp (172680 => 172681)

--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp	2014-08-16 02:57:58 UTC (rev 172680)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp	2014-08-16 04:03:42 UTC (rev 172681)
@@ -571,18 +571,19 @@
 
 void GraphicsLayer::addRepaintRect(const FloatRect repaintRect)
 {
-if (m_client.isTrackingRepaints()) {
-

[webkit-changes] [172682] trunk/Source/WebInspectorUI

2014-08-15 Thread commit-queue

Title: [172682] trunk/Source/WebInspectorUI








Revision 172682
Author commit-qu...@webkit.org
Date 2014-08-15 21:05:50 -0700 (Fri, 15 Aug 2014)


Log Message
Web Inspector: Remove forced layouts during recording caused by striped background element resizing
https://bugs.webkit.org/show_bug.cgi?id=136009

Patch by Joseph Pecoraro pecor...@apple.com on 2014-08-15
Reviewed by Timothy Hatcher.

We used to manually resize and a custom striped background behind
the timeline tree outline content area. This can happen frequently
during timeline recordings causing forced layouts. We can eliminate
the hack and instead put the stripe background on the tree outline.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
* UserInterface/Views/TimelineSidebarPanel.css:
(body.mac-platform.legacy .sidebar  .panel.navigation.timeline  .content .item  .status  .status-button):
(.sidebar  .panel.navigation.timeline  .content  .stripe-background): Deleted.
(.sidebar  .panel.navigation.timeline.timeline-content-view-showing  .content  .stripe-background): Deleted.
Eliminate the striped background element.

* UserInterface/Views/TimelineView.css:
(.panel.navigation.timeline  .content  .navigation-sidebar-panel-content-tree-outline):
(.panel.navigation.timeline.timeline-content-view-showing  .content  .navigation-sidebar-panel-content-tree-outline):
Give the timeline content tree outlines the striped background.

* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
(WebInspector.NavigationSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
Remove the now unused updateCustomContentOverflow method.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (172681 => 172682)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-08-16 04:03:42 UTC (rev 172681)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-08-16 04:05:50 UTC (rev 172682)
@@ -1,3 +1,33 @@
+2014-08-15  Joseph Pecoraro  pecor...@apple.com
+
+Web Inspector: Remove forced layouts during recording caused by striped background element resizing
+https://bugs.webkit.org/show_bug.cgi?id=136009
+
+Reviewed by Timothy Hatcher.
+
+We used to manually resize and a custom striped background behind
+the timeline tree outline content area. This can happen frequently
+during timeline recordings causing forced layouts. We can eliminate
+the hack and instead put the stripe background on the tree outline.
+
+* UserInterface/Views/TimelineSidebarPanel.js:
+(WebInspector.TimelineSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
+* UserInterface/Views/TimelineSidebarPanel.css:
+(body.mac-platform.legacy .sidebar  .panel.navigation.timeline  .content .item  .status  .status-button):
+(.sidebar  .panel.navigation.timeline  .content  .stripe-background): Deleted.
+(.sidebar  .panel.navigation.timeline.timeline-content-view-showing  .content  .stripe-background): Deleted.
+Eliminate the striped background element.
+
+* UserInterface/Views/TimelineView.css:
+(.panel.navigation.timeline  .content  .navigation-sidebar-panel-content-tree-outline):
+(.panel.navigation.timeline.timeline-content-view-showing  .content  .navigation-sidebar-panel-content-tree-outline):
+Give the timeline content tree outlines the striped background.
+
+* UserInterface/Views/NavigationSidebarPanel.js:
+(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
+(WebInspector.NavigationSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
+Remove the now unused updateCustomContentOverflow method.
+
 2014-08-15  Jono Wells  jonowe...@apple.com
 
 Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (172681 => 172682)

--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js	2014-08-16 04:03:42 UTC (rev 172681)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js	2014-08-16 04:05:50 UTC (rev 172682)
@@ -297,11 +297,6 @@
 }
 },
 
-updateCustomContentOverflow: function()
-{
-// Implemented by subclasses if needed.
-},
-
 updateFilter: function()
 {
 this._updateFilter();
@@ -441,8 +436,6 @@
 {
 delete

[webkit-changes] [172683] branches/safari-600.1-branch

2014-08-15 Thread matthew_hanson

Title: [172683] branches/safari-600.1-branch








Revision 172683
Author matthew_han...@apple.com
Date 2014-08-15 21:19:44 -0700 (Fri, 15 Aug 2014)


Log Message
Merge r172019. rdar://problem/18029617

Modified Paths

branches/safari-600.1-branch/Source/WTF/ChangeLog
branches/safari-600.1-branch/Source/WTF/wtf/FeatureDefines.h
branches/safari-600.1-branch/Source/WebKit/ChangeLog
branches/safari-600.1-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props
branches/safari-600.1-branch/WebKitLibraries/ChangeLog
branches/safari-600.1-branch/WebKitLibraries/win/tools/vsprops/FeatureDefines.props




Diff

Modified: branches/safari-600.1-branch/Source/WTF/ChangeLog (172682 => 172683)

--- branches/safari-600.1-branch/Source/WTF/ChangeLog	2014-08-16 04:05:50 UTC (rev 172682)
+++ branches/safari-600.1-branch/Source/WTF/ChangeLog	2014-08-16 04:19:44 UTC (rev 172683)
@@ -1,3 +1,16 @@
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
+Merge r172019. rdar://problem/18029617
+
+2014-08-04  Matthew Hanson  matthew_han...@apple.com
+
+[Win] Temporarily turn off WebGL.
+https://bugs.webkit.org/show_bug.cgi?id=135543
+
+Landed on behalf of Brent Fulgham.
+
+* wtf/FeatureDefines.h: Turn off WebGL feature.
+
 2014-07-30  Lucas Forschler  lforsch...@apple.com
 
 Merge r171825


Modified: branches/safari-600.1-branch/Source/WTF/wtf/FeatureDefines.h (172682 => 172683)

--- branches/safari-600.1-branch/Source/WTF/wtf/FeatureDefines.h	2014-08-16 04:05:50 UTC (rev 172682)
+++ branches/safari-600.1-branch/Source/WTF/wtf/FeatureDefines.h	2014-08-16 04:19:44 UTC (rev 172683)
@@ -249,9 +249,12 @@
 #define ENABLE_WEB_ARCHIVE 1
 #endif
 
+/*
+FIXME: Remove under https://bugs.webkit.org/show_bug.cgi?id=135543
 #if !defined(ENABLE_WEBGL)
 #define ENABLE_WEBGL 1
 #endif
+*/
 
 #endif /* PLATFORM(WIN)  !OS(WINCE)  !PLATFORM(WIN_CAIRO) */
 


Modified: branches/safari-600.1-branch/Source/WebKit/ChangeLog (172682 => 172683)

--- branches/safari-600.1-branch/Source/WebKit/ChangeLog	2014-08-16 04:05:50 UTC (rev 172682)
+++ branches/safari-600.1-branch/Source/WebKit/ChangeLog	2014-08-16 04:19:44 UTC (rev 172683)
@@ -1,3 +1,19 @@
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
+Merge r172019. rdar://problem/18029617
+
+2014-08-04  Matthew Hanson  matthew_han...@apple.com
+
+[Win] Temporarily deactivate WebGL.
+https://bugs.webkit.org/show_bug.cgi?id=135543
+
+Unreviewed build fix.
+
+Landed on behalf of Brent Fulgham.
+
+* WebKit.vcxproj/WebKit/WebKitCommon.props: Avoid
+linking to ANGLE-based libraries.
+
 2014-08-07  Dana Burkart dburk...@apple.com
 
 Merge r172241


Modified: branches/safari-600.1-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props (172682 => 172683)

--- branches/safari-600.1-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props	2014-08-16 04:05:50 UTC (rev 172682)
+++ branches/safari-600.1-branch/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props	2014-08-16 04:19:44 UTC (rev 172683)
@@ -13,7 +13,7 @@
   ForcedIncludeFilesWebKitPrefix.h;ICUVersion.h;%(ForcedIncludeFiles)/ForcedIncludeFiles
 /ClCompile
 Link
-  AdditionalDependencieslibEGL.lib;libGLESv2.lib;preprocessor.lib;translator_common.lib;translator_glsl.lib;translator_hlsl.lib;opengl32.lib;delayimp.lib;kernel32.lib;user32.lib;gdi32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;odbc32.lib;odbccp32.lib;usp10.lib;comctl32.lib;version.lib;shlwapi.lib;libxslt$(DebugSuffix).lib;libxml2$(DebugSuffix).lib;libicuin$(DebugSuffix).lib;libicuuc$(DebugSuffix).lib;WTF$(DebugSuffix).lib;_javascript_Core$(DebugSuffix).lib;WebCore$(DebugSuffix).lib;WebKitGUID$(DebugSuffix).lib;SQLite3$(DebugSuffix).lib;msimg32.lib;crypt32.lib;iphlpapi.lib;winmm.lib;comsuppw.lib;rpcrt4.lib;zdll$(DebugSuffix).lib;uuid.lib;%(AdditionalDependencies)/AdditionalDependencies
+  AdditionalDependenciesopengl32.lib;delayimp.lib;kernel32.lib;user32.lib;gdi32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;odbc32.lib;odbccp32.lib;usp10.lib;comctl32.lib;version.lib;shlwapi.lib;libxslt$(DebugSuffix).lib;libxml2$(DebugSuffix).lib;libicuin$(DebugSuffix).lib;libicuuc$(DebugSuffix).lib;WTF$(DebugSuffix).lib;_javascript_Core$(DebugSuffix).lib;WebCore$(DebugSuffix).lib;WebKitGUID$(DebugSuffix).lib;SQLite3$(DebugSuffix).lib;msimg32.lib;crypt32.lib;iphlpapi.lib;winmm.lib;comsuppw.lib;rpcrt4.lib;zdll$(DebugSuffix).lib;uuid.lib;%(AdditionalDependencies)/AdditionalDependencies
   ModuleDefinitionFile$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\WebKitExportGenerator\WebKitExports.def/ModuleDefinitionFile
   DelayLoadDLLsusp10.dll;comctl32.dll;version.dll;iphlpapi.dll;%(DelayLoadDLLs)/DelayLoadDLLs
 /Link


Modified: branches/safari-600.1-branch/WebKitLibraries/ChangeLog (172682 => 172683)

---

[webkit-changes] [172684] branches/safari-600.1-branch/WebKitLibraries

2014-08-15 Thread matthew_hanson

Title: [172684] branches/safari-600.1-branch/WebKitLibraries








Revision 172684
Author matthew_han...@apple.com
Date 2014-08-15 21:21:49 -0700 (Fri, 15 Aug 2014)


Log Message
Merge r172661. rdar://problem/18037766

Modified Paths

branches/safari-600.1-branch/WebKitLibraries/ChangeLog
branches/safari-600.1-branch/WebKitLibraries/win/tools/vsprops/common.props
branches/safari-600.1-branch/WebKitLibraries/win/tools/vsprops/debugsuffix.props




Diff

Modified: branches/safari-600.1-branch/WebKitLibraries/ChangeLog (172683 => 172684)

--- branches/safari-600.1-branch/WebKitLibraries/ChangeLog	2014-08-16 04:19:44 UTC (rev 172683)
+++ branches/safari-600.1-branch/WebKitLibraries/ChangeLog	2014-08-16 04:21:49 UTC (rev 172684)
@@ -1,5 +1,20 @@
 2014-08-15  Matthew Hanson  matthew_han...@apple.com
 
+Merge r172661. rdar://problem/18037766
+
+2014-08-15  Brent Fulgham  bfulg...@apple.com
+
+[Win] Link to static VS2013 runtime library.
+https://bugs.webkit.org/show_bug.cgi?id=136007
+rdar://problem/18037766
+
+Reviewed by Dean Jackson.
+
+* win/tools/vsprops/common.props: Update link command.
+* win/tools/vsprops/debugsuffix.props: Ditto.
+
+2014-08-15  Matthew Hanson  matthew_han...@apple.com
+
 Merge r172019. rdar://problem/18029617
 
 2014-08-04  Matthew Hanson  matthew_han...@apple.com


Modified: branches/safari-600.1-branch/WebKitLibraries/win/tools/vsprops/common.props (172683 => 172684)

--- branches/safari-600.1-branch/WebKitLibraries/win/tools/vsprops/common.props	2014-08-16 04:19:44 UTC (rev 172683)
+++ branches/safari-600.1-branch/WebKitLibraries/win/tools/vsprops/common.props	2014-08-16 04:21:49 UTC (rev 172684)
@@ -47,7 +47,7 @@
   TreatWarningAsErrorfalse/TreatWarningAsError
   DebugInformationFormatProgramDatabase/DebugInformationFormat
   DisableSpecificWarnings4018;4068;4099;4100;4127;4138;4146;4180;4189;4201;4244;4251;4267;4275;4288;4291;4305;4309;4344;4355;4389;4396;4481;4503;4505;4510;4512;4530;4610;4702;4706;4800;4819;4951;4952;4996;6011;6031;6211;6246;6255;6387;%(DisableSpecificWarnings)/DisableSpecificWarnings
-  RuntimeLibraryMultiThreadedDLL/RuntimeLibrary
+  RuntimeLibraryMultiThreaded/RuntimeLibrary
   FunctionLevelLinkingfalse/FunctionLevelLinking
   FloatingPointExceptionsfalse/FloatingPointExceptions
   OpenMPSupportfalse/OpenMPSupport


Modified: branches/safari-600.1-branch/WebKitLibraries/win/tools/vsprops/debugsuffix.props (172683 => 172684)

--- branches/safari-600.1-branch/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2014-08-16 04:19:44 UTC (rev 172683)
+++ branches/safari-600.1-branch/WebKitLibraries/win/tools/vsprops/debugsuffix.props	2014-08-16 04:21:49 UTC (rev 172684)
@@ -11,7 +11,7 @@
   ItemDefinitionGroup
 ClCompile
   PreprocessorDefinitions_CONSOLE;DEBUG_INTERNAL;DEBUG_ALL;%(PreprocessorDefinitions)/PreprocessorDefinitions
-  RuntimeLibraryMultiThreadedDebugDLL/RuntimeLibrary
+  RuntimeLibraryMultiThreadedDebug/RuntimeLibrary
 /ClCompile
 Lib
   OutputFile$(OutDir)\$(ProjectName)$(DebugSuffix).lib/OutputFile






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172686] trunk/Source/JavaScriptCore

2014-08-15 Thread burg

Title: [172686] trunk/Source/_javascript_Core








Revision 172686
Author b...@cs.washington.edu
Date 2014-08-15 21:36:42 -0700 (Fri, 15 Aug 2014)


Log Message
Unreviewed build fix for some GTK bots after r172655.

Some bots use Python 2.6, which lacks the 'flags' named parameter for re.sub.

* inspector/scripts/codegen/generator.py:
(Generator.stylized_name_for_enum_value): Do things the old-school way.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (172685 => 172686)

--- trunk/Source/_javascript_Core/ChangeLog	2014-08-16 04:35:59 UTC (rev 172685)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-08-16 04:36:42 UTC (rev 172686)
@@ -1,3 +1,12 @@
+2014-08-15  Brian J. Burg  b...@cs.washington.edu
+
+Unreviewed build fix for some GTK bots after r172655.
+
+Some bots use Python 2.6, which lacks the 'flags' named parameter for re.sub.
+
+* inspector/scripts/codegen/generator.py:
+(Generator.stylized_name_for_enum_value): Do things the old-school way.
+
 2014-08-15  Michael Saboff  msab...@apple.com
 
 Change callToJavaScript and callToNativeFunction so their callFrames match the native calling conventions


Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py (172685 => 172686)

--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py	2014-08-16 04:35:59 UTC (rev 172685)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generator.py	2014-08-16 04:36:42 UTC (rev 172686)
@@ -229,7 +229,7 @@
 
 # Split on hyphen, introduce camelcase, and force uppercasing of acronyms.
 subwords = map(ucfirst, enum_value.split('-'))
-return re.sub(regex, replaceCallback, .join(subwords), flags=re.IGNORECASE)
+return re.sub(re.compile(regex, re.IGNORECASE), replaceCallback, .join(subwords))
 
 @staticmethod
 def keyed_get_method_for_type(_type):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [172687] trunk/Source/JavaScriptCore

2014-08-15 Thread burg

Title: [172687] trunk/Source/_javascript_Core








Revision 172687
Author b...@cs.washington.edu
Date 2014-08-15 21:38:00 -0700 (Fri, 15 Aug 2014)


Log Message
Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
https://bugs.webkit.org/show_bug.cgi?id=131596

Unreviewed gardening to rebaseline inspector generator tests after addressing review comments.

* inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
* inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
* inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
* inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
* inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
* inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
* inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
* inspector/scripts/tests/expected/type-declaration-array-type.json-result:
* inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
* inspector/scripts/tests/expected/type-declaration-object-type.json-result:
* inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/events-with-optional-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/same-type-id-different-domain.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-array-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-enum-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (172686 => 172687)

--- trunk/Source/_javascript_Core/ChangeLog	2014-08-16 04:36:42 UTC (rev 172686)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-08-16 04:38:00 UTC (rev 172687)
@@ -1,5 +1,24 @@
 2014-08-15  Brian J. Burg  b...@cs.washington.edu
 
+Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
+https://bugs.webkit.org/show_bug.cgi?id=131596
+
+Unreviewed gardening to rebaseline inspector generator tests after addressing review comments.
+
+* inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
+* inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
+* inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
+* inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
+* inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
+* inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
+* inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
+* inspector/scripts/tests/expected/type-declaration-array-type.json-result:
+* inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
+* inspector/scripts/tests/expected/type-declaration-object-type.json-result:
+* inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
+
+2014-08-15  Brian J. Burg  b...@cs.washington.edu
+
 Unreviewed build fix for some GTK bots after r172655.
 
 Some bots use Python 2.6, which lacks the 'flags' named parameter for re.sub.


Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result (172686 => 172687)

--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result	2014-08-16 04:36:42 UTC (rev 172686)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result	2014-08-16 04:38:00 UTC (rev 172687)
@@ -27,7 +27,7 @@
  */
 
 // DO NOT EDIT THIS FILE. It is automatically generated from commands-with-async-attribute.json
-// by the script: Source/_javascript_Core/inspector/scripts/codegen/generate-inspector-protocol-bindings.py
+// by the script:

[webkit-changes] [172688] trunk/Source/WebInspectorUI

2014-08-15 Thread commit-queue

Title: [172688] trunk/Source/WebInspectorUI








Revision 172688
Author commit-qu...@webkit.org
Date 2014-08-15 22:49:19 -0700 (Fri, 15 Aug 2014)


Log Message
Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
https://bugs.webkit.org/show_bug.cgi?id=136006

Patch by Joseph Pecoraro pecor...@apple.com on 2014-08-15
Reviewed by Timothy Hatcher.

* Scripts/update-LegacyInspectorBackendCommands.rb:
Use the new generator and pass the appropriate flags.

* UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
Newly generated files using the new generator.

* Versions/Inspector-iOS-6.0.json:
Remove unsupported features.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Scripts/update-LegacyInspectorBackendCommands.rb
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (172687 => 172688)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-08-16 04:38:00 UTC (rev 172687)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-08-16 05:49:19 UTC (rev 172688)
@@ -1,5 +1,22 @@
 2014-08-15  Joseph Pecoraro  pecor...@apple.com
 
+Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
+https://bugs.webkit.org/show_bug.cgi?id=136006
+
+Reviewed by Timothy Hatcher.
+
+* Scripts/update-LegacyInspectorBackendCommands.rb:
+Use the new generator and pass the appropriate flags.
+
+* UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
+* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
+Newly generated files using the new generator.
+
+* Versions/Inspector-iOS-6.0.json:
+Remove unsupported features.
+
+2014-08-15  Joseph Pecoraro  pecor...@apple.com
+
 Web Inspector: Remove forced layouts during recording caused by striped background element resizing
 https://bugs.webkit.org/show_bug.cgi?id=136009
 


Modified: trunk/Source/WebInspectorUI/Scripts/update-LegacyInspectorBackendCommands.rb (172687 => 172688)

--- trunk/Source/WebInspectorUI/Scripts/update-LegacyInspectorBackendCommands.rb	2014-08-16 04:38:00 UTC (rev 172687)
+++ trunk/Source/WebInspectorUI/Scripts/update-LegacyInspectorBackendCommands.rb	2014-08-16 05:49:19 UTC (rev 172688)
@@ -11,7 +11,7 @@
 WEB_INSPECTOR_PATH = File.expand_path File.join(File.dirname(__FILE__), ..)
 _javascript_CORE_PATH = File.expand_path File.join(File.dirname(__FILE__), .., .., _javascript_Core)
 
-$code_generator_path = File.join _javascript_CORE_PATH, inspector, scripts, CodeGeneratorInspector.py
+$code_generator_path = File.join _javascript_CORE_PATH, inspector, scripts, generate-inspector-protocol-bindings.py
 $versions_directory_path = File.join WEB_INSPECTOR_PATH, Versions
 $web_inspector_protocol_legacy_path = File.join WEB_INSPECTOR_PATH, UserInterface, Protocol, Legacy
 
@@ -25,6 +25,7 @@
 
   def run
 output_filename_prefix = {_javascript_ = JS, Web = Web}[@type]
+framework = {_javascript_ = _javascript_Core, Web = WebCore}[@type]
 output_filename = Inspector#{output_filename_prefix}BackendCommands.js
 display_input = File.basename @input_json_path
 display_output = File.join @output_directory_path.gsub(/^.*?\/UserInterface/, UserInterface), output_filename
@@ -32,7 +33,7 @@
 
 Dir.mktmpdir do |tmpdir|
   dependency = @dependency_json_path ? '#{@dependency_json_path}' : 
-  cmd = #{$code_generator_path} '#{@input_json_path}' #{dependency} --no_verification --output_h_dir '#{tmpdir}' --output_cpp_dir '#{tmpdir}' --output_js_dir '#{tmpdir}' --write_always --output_type '#{@type}'
+  cmd = #{$code_generator_path} --force --outputDir '#{tmpdir}' --framework #{framework} '#{@input_json_path}' #{dependency}
   %x{ #{cmd} }
   if $?.exitstatus != 0
 puts ERROR: Error Code (#{$?.exitstatus}) Evaluating: #{cmd}


Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js (172687 => 172688)

--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js	2014-08-16 04:38:00 UTC (rev 172687)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js	2014-08-16 05:49:19 UTC (rev 172688)
@@ -1,11 +1,33 @@
-// File is generated by _javascript_Core/inspector/scripts/CodeGeneratorInspector.py
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
+ * Copyright (C) 2014 University of Washington. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are

61 matches

Mail list logo