[webkit-changes] [185107] trunk/Source/WebKit2
Title: [185107] trunk/Source/WebKit2 Revision 185107 Author gyuyoung@webkit.org Date 2015-06-02 02:12:41 -0700 (Tue, 02 Jun 2015) Log Message REGRESSION(r185091): Crash happens on indexdb tests https://bugs.webkit.org/show_bug.cgi?id=145549 Reviewed by Csaba Osztrogonác. r185091 caused crash on some indexeddb tests. The crash happens because IDBDatabaseError::create() doesn't dereference count by using ptr(). It makes a crash when dereferencing on ~Ref() destructor. To fix this issue, this patch uses leakRef() instead of ptr(). * WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp: (WebKit::WebIDBServerConnection::didCreateObjectStore): (WebKit::WebIDBServerConnection::didCreateIndex): (WebKit::WebIDBServerConnection::didDeleteIndex): (WebKit::WebIDBServerConnection::didPutRecord): (WebKit::WebIDBServerConnection::didGetRecord): (WebKit::WebIDBServerConnection::didOpenCursor): (WebKit::WebIDBServerConnection::didAdvanceCursor): (WebKit::WebIDBServerConnection::didIterateCursor): (WebKit::WebIDBServerConnection::didCount): (WebKit::WebIDBServerConnection::didDeleteRange): (WebKit::WebIDBServerConnection::didClearObjectStore): (WebKit::WebIDBServerConnection::didDeleteObjectStore): (WebKit::WebIDBServerConnection::didChangeDatabaseVersion): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (185106 => 185107) --- trunk/Source/WebKit2/ChangeLog 2015-06-02 09:08:52 UTC (rev 185106) +++ trunk/Source/WebKit2/ChangeLog 2015-06-02 09:12:41 UTC (rev 185107) @@ -1,3 +1,29 @@ +2015-06-02 Gyuyoung Kim gyuyoung@webkit.org + +REGRESSION(r185091): Crash happens on indexdb tests +https://bugs.webkit.org/show_bug.cgi?id=145549 + +Reviewed by Csaba Osztrogonác. + +r185091 caused crash on some indexeddb tests. The crash happens because IDBDatabaseError::create() doesn't +dereference count by using ptr(). It makes a crash when dereferencing on ~Ref() destructor. To fix this issue, +this patch uses leakRef() instead of ptr(). + +* WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp: +(WebKit::WebIDBServerConnection::didCreateObjectStore): +(WebKit::WebIDBServerConnection::didCreateIndex): +(WebKit::WebIDBServerConnection::didDeleteIndex): +(WebKit::WebIDBServerConnection::didPutRecord): +(WebKit::WebIDBServerConnection::didGetRecord): +(WebKit::WebIDBServerConnection::didOpenCursor): +(WebKit::WebIDBServerConnection::didAdvanceCursor): +(WebKit::WebIDBServerConnection::didIterateCursor): +(WebKit::WebIDBServerConnection::didCount): +(WebKit::WebIDBServerConnection::didDeleteRange): +(WebKit::WebIDBServerConnection::didClearObjectStore): +(WebKit::WebIDBServerConnection::didDeleteObjectStore): +(WebKit::WebIDBServerConnection::didChangeDatabaseVersion): + 2015-06-01 Enrica Casucci enr...@apple.com [iOS] Hardware Keyboard: All combinations for arrow keys with Shift do not extend the selection. Modified: trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp (185106 => 185107) --- trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp 2015-06-02 09:08:52 UTC (rev 185106) +++ trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp 2015-06-02 09:12:41 UTC (rev 185107) @@ -336,7 +336,7 @@ if (!serverRequest) return; -serverRequest-completeRequest(success ? nullptr : IDBDatabaseError::create(IDBDatabaseException::UnknownError, Unknown error occured creating object store).ptr()); +serverRequest-completeRequest(success ? nullptr : IDBDatabaseError::create(IDBDatabaseException::UnknownError, Unknown error occured creating object store).leakRef()); } void WebIDBServerConnection::createIndex(IDBTransactionBackendtransaction, const CreateIndexOperation operation, std::functionvoid (PassRefPtrIDBDatabaseError) completionCallback) @@ -365,7 +365,7 @@ if (!serverRequest) return; -serverRequest-completeRequest(success ? nullptr : IDBDatabaseError::create(IDBDatabaseException::UnknownError, Unknown error occured creating index).ptr()); +serverRequest-completeRequest(success ? nullptr : IDBDatabaseError::create(IDBDatabaseException::UnknownError, Unknown error occured creating index).leakRef()); } void WebIDBServerConnection::deleteIndex(IDBTransactionBackendtransaction, const DeleteIndexOperation operation, std::functionvoid (PassRefPtrIDBDatabaseError) completionCallback) @@ -394,7 +394,7 @@ if (!serverRequest) return; -serverRequest-completeRequest(success ? nullptr : IDBDatabaseError::create(IDBDatabaseException::UnknownError, Unknown error occured deleting index).ptr()); +serverRequest-completeRequest(success ? nullptr :
[webkit-changes] [185115] trunk/LayoutTests
Title: [185115] trunk/LayoutTests
Revision 185115
Author beid...@apple.com
Date 2015-06-02 12:40:13 -0700 (Tue, 02 Jun 2015)
Log Message
Add more tests for should open external urls flag.
https://bugs.webkit.org/show_bug.cgi?id=145558
Rubberstamped by Geoff Garen.
* loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt: Added.
* loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html: Added.
* loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt: Added.
* loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html: Added.
* loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt: Added.
* loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html: Added.
* loader/navigation-policy/should-open-external-urls/resources/do-nothing.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt
trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html
trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt
trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html
trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt
trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html
trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/resources/do-nothing.html
Diff
Modified: trunk/LayoutTests/ChangeLog (185114 => 185115)
--- trunk/LayoutTests/ChangeLog 2015-06-02 19:28:11 UTC (rev 185114)
+++ trunk/LayoutTests/ChangeLog 2015-06-02 19:40:13 UTC (rev 185115)
@@ -1,3 +1,18 @@
+2015-06-02 Brady Eidson beid...@apple.com
+
+Add more tests for should open external urls flag.
+https://bugs.webkit.org/show_bug.cgi?id=145558
+
+Rubber-stamped by Geoff Garen.
+
+* loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt: Added.
+* loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html: Added.
+* loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt: Added.
+* loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html: Added.
+* loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt: Added.
+* loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html: Added.
+* loader/navigation-policy/should-open-external-urls/resources/do-nothing.html: Added.
+
2015-06-02 Xabier Rodriguez Calvar calva...@igalia.com and Youenn Fablet youenn.fab...@crf.canon.fr
[Streams API] Implement ReadableStreamReader read method in closed and errored state
@@ -23,7 +38,7 @@
* streams/reference-implementation/readable-stream-templated-expected.txt:
* streams/reference-implementation/readable-stream-templated.html:
* streams/reference-implementation/readable-stream.html:
-
+
2015-06-02 Brady Eidson beid...@apple.com
WebKit policy delegate should suggest if a navigation should be allowed to open URLs externally.
Added: trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt (0 => 185115)
--- trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt 2015-06-02 19:40:13 UTC (rev 185115)
@@ -0,0 +1,5 @@
+ - decidePolicyForNavigationAction
+NSURLRequest URL resources/do-nothing, main document URL resources/do-nothing, http method GET is main frame - yes should open URLs externally - no
+ - decidePolicyForNavigationAction
+NSURLRequest URL resources/notify-done.html, main document URL resources/notify-done.html, http method GET is main frame - yes should open URLs externally - yes
+
Added: trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html (0 => 185115)
--- trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html (rev 0)
+++ trunk/LayoutTests/loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html 2015-06-02 19:40:13 UTC (rev 185115)
@@ -0,0 +1,11 @@
+script
+if (window.testRunner) {
+testRunner.dumpAsText();
+
[webkit-changes] [185112] trunk/Source/WebCore
Title: [185112] trunk/Source/WebCore
Revision 185112
Author aes...@apple.com
Date 2015-06-02 12:13:29 -0700 (Tue, 02 Jun 2015)
Log Message
[Mac] REGRESSION (r175941): Max.app crashes when adding a sound file to a patch due to removing cursor resources from WebCore.framework
https://bugs.webkit.org/show_bug.cgi?id=14
Reviewed by Darin Adler.
Re-added the cursor resources used by Max.app and ran sort-Xcode-project-file.
* Resources/copyCursor.png: Added.
* Resources/moveCursor.png: Added.
* Resources/northEastSouthWestResizeCursor.png: Added.
* Resources/northSouthResizeCursor.png: Added.
* Resources/northWestSouthEastResizeCursor.png: Added.
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebCore/Resources/copyCursor.png
trunk/Source/WebCore/Resources/moveCursor.png
trunk/Source/WebCore/Resources/northEastSouthWestResizeCursor.png
trunk/Source/WebCore/Resources/northSouthResizeCursor.png
trunk/Source/WebCore/Resources/northWestSouthEastResizeCursor.png
Diff
Modified: trunk/Source/WebCore/ChangeLog (185111 => 185112)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 18:43:13 UTC (rev 185111)
+++ trunk/Source/WebCore/ChangeLog 2015-06-02 19:13:29 UTC (rev 185112)
@@ -1,3 +1,19 @@
+2015-06-02 Andy Estes aes...@apple.com
+
+[Mac] REGRESSION (r175941): Max.app crashes when adding a sound file to a patch due to removing cursor resources from WebCore.framework
+https://bugs.webkit.org/show_bug.cgi?id=14
+
+Reviewed by Darin Adler.
+
+Re-added the cursor resources used by Max.app and ran sort-Xcode-project-file.
+
+* Resources/copyCursor.png: Added.
+* Resources/moveCursor.png: Added.
+* Resources/northEastSouthWestResizeCursor.png: Added.
+* Resources/northSouthResizeCursor.png: Added.
+* Resources/northWestSouthEastResizeCursor.png: Added.
+* WebCore.xcodeproj/project.pbxproj:
+
2015-06-02 Brady Eidson beid...@apple.com
WebKit policy delegate should suggest if a navigation should be allowed to open URLs externally.
Added: trunk/Source/WebCore/Resources/copyCursor.png
(Binary files differ)
Property changes on: trunk/Source/WebCore/Resources/copyCursor.png
___
Added: svn:mime-type
Added: trunk/Source/WebCore/Resources/moveCursor.png
(Binary files differ)
Property changes on: trunk/Source/WebCore/Resources/moveCursor.png
___
Added: svn:mime-type
Added: trunk/Source/WebCore/Resources/northEastSouthWestResizeCursor.png
(Binary files differ)
Property changes on: trunk/Source/WebCore/Resources/northEastSouthWestResizeCursor.png
___
Added: svn:mime-type
Added: trunk/Source/WebCore/Resources/northSouthResizeCursor.png
(Binary files differ)
Property changes on: trunk/Source/WebCore/Resources/northSouthResizeCursor.png
___
Added: svn:mime-type
Added: trunk/Source/WebCore/Resources/northWestSouthEastResizeCursor.png
(Binary files differ)
Property changes on: trunk/Source/WebCore/Resources/northWestSouthEastResizeCursor.png
___
Added: svn:mime-type
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (185111 => 185112)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2015-06-02 18:43:13 UTC (rev 185111)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2015-06-02 19:13:29 UTC (rev 185112)
@@ -3812,6 +3812,11 @@
A10DC76B14747BAB005E2471 /* StyleGridData.h in Headers */ = {isa = PBXBuildFile; fileRef = A10DC76914747BAB005E2471 /* StyleGridData.h */; settings = {ATTRIBUTES = (Private, ); }; };
A110DB9B14F5DF7700A03B93 /* StyleGridItemData.h in Headers */ = {isa = PBXBuildFile; fileRef = A110DB9A14F5DF7700A03B93 /* StyleGridItemData.h */; settings = {ATTRIBUTES = (Private, ); }; };
A110DB9D14F5DF8700A03B93 /* StyleGridItemData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A110DB9C14F5DF8700A03B93 /* StyleGridItemData.cpp */; };
+ A11E8C051B1E28F40003A7C7 /* copyCursor.png in Resources */ = {isa = PBXBuildFile; fileRef = A11E8C001B1E28BE0003A7C7 /* copyCursor.png */; };
+ A11E8C061B1E28FA0003A7C7 /* moveCursor.png in Resources */ = {isa = PBXBuildFile; fileRef = A11E8C011B1E28BE0003A7C7 /* moveCursor.png */; };
+ A11E8C071B1E28FE0003A7C7 /* northEastSouthWestResizeCursor.png in Resources */ = {isa = PBXBuildFile; fileRef = A11E8C021B1E28BE0003A7C7 /* northEastSouthWestResizeCursor.png */; };
+ A11E8C081B1E29020003A7C7 /* northSouthResizeCursor.png in Resources */ = {isa = PBXBuildFile; fileRef = A11E8C031B1E28BE0003A7C7 /* northSouthResizeCursor.png */; };
+ A11E8C091B1E29070003A7C7 /*
[webkit-changes] [185113] trunk/Source/WebCore
Title: [185113] trunk/Source/WebCore
Revision 185113
Author mmaxfi...@apple.com
Date 2015-06-02 12:21:43 -0700 (Tue, 02 Jun 2015)
Log Message
[Cocoa] FontPlatformData's equality check should always use reference URLs
https://bugs.webkit.org/show_bug.cgi?id=144168
Reviewed by Tim Horton.
rdar://problem/18985642 is not fixed, so we need to continue using the older
objectForEqualityCheck().
No new tests because there is no behavior change.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::objectForEqualityCheck):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (185112 => 185113)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 19:13:29 UTC (rev 185112)
+++ trunk/Source/WebCore/ChangeLog 2015-06-02 19:21:43 UTC (rev 185113)
@@ -1,3 +1,18 @@
+2015-06-01 Myles C. Maxfield mmaxfi...@apple.com
+
+[Cocoa] FontPlatformData's equality check should always use reference URLs
+https://bugs.webkit.org/show_bug.cgi?id=144168
+
+Reviewed by Tim Horton.
+
+rdar://problem/18985642 is not fixed, so we need to continue using the older
+objectForEqualityCheck().
+
+No new tests because there is no behavior change.
+
+* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
+(WebCore::FontPlatformData::objectForEqualityCheck):
+
2015-06-02 Andy Estes aes...@apple.com
[Mac] REGRESSION (r175941): Max.app crashes when adding a sound file to a patch due to removing cursor resources from WebCore.framework
Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm (185112 => 185113)
--- trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm 2015-06-02 19:13:29 UTC (rev 185112)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm 2015-06-02 19:21:43 UTC (rev 185113)
@@ -268,16 +268,12 @@
RetainPtrCFTypeRef FontPlatformData::objectForEqualityCheck(CTFontRef ctFont)
{
-#if (PLATFORM(IOS) __IPHONE_OS_VERSION_MIN_REQUIRED = 8) || (PLATFORM(MAC) __MAC_OS_X_VERSION_MIN_REQUIRED = 101000)
auto fontDescriptor = adoptCF(CTFontCopyFontDescriptor(ctFont));
// FIXME: https://bugs.webkit.org/show_bug.cgi?id=138683 This is a shallow pointer compare for web fonts
// because the URL contains the address of the font. This means we might erroneously get false negatives.
RetainPtrCFURLRef url = "" kCTFontReferenceURLAttribute)));
ASSERT(CFGetTypeID(url.get()) == CFURLGetTypeID());
return url;
-#else
-return adoptCF(CTFontCopyGraphicsFont(ctFont, 0));
-#endif
}
RetainPtrCFTypeRef FontPlatformData::objectForEqualityCheck() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185117] trunk/Source/WebCore
Title: [185117] trunk/Source/WebCore
Revision 185117
Author mmaxfi...@apple.com
Date 2015-06-02 13:19:08 -0700 (Tue, 02 Jun 2015)
Log Message
Remove use of CTFontSetRenderingParameters()
https://bugs.webkit.org/show_bug.cgi?id=145560
Reviewed by Simon Fraser.
Instead, always use CTFontSetRenderingStyle().
No new tests because there is no behavior change.
* platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::RenderingStyleSaver::RenderingStyleSaver): Deleted.
(WebCore::RenderingStyleSaver::~RenderingStyleSaver): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (185116 => 185117)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 20:00:01 UTC (rev 185116)
+++ trunk/Source/WebCore/ChangeLog 2015-06-02 20:19:08 UTC (rev 185117)
@@ -1,3 +1,18 @@
+2015-06-02 Myles C. Maxfield mmaxfi...@apple.com
+
+Remove use of CTFontSetRenderingParameters()
+https://bugs.webkit.org/show_bug.cgi?id=145560
+
+Reviewed by Simon Fraser.
+
+Instead, always use CTFontSetRenderingStyle().
+
+No new tests because there is no behavior change.
+
+* platform/graphics/cocoa/FontCascadeCocoa.mm:
+(WebCore::RenderingStyleSaver::RenderingStyleSaver): Deleted.
+(WebCore::RenderingStyleSaver::~RenderingStyleSaver): Deleted.
+
2015-06-02 Anders Carlsson ander...@apple.com
Move WKFontAntialiasingStateSaver to its own file
Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm (185116 => 185117)
--- trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm 2015-06-02 20:00:01 UTC (rev 185116)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm 2015-06-02 20:19:08 UTC (rev 185117)
@@ -134,30 +134,8 @@
class RenderingStyleSaver {
public:
#if !PLATFORM(MAC) || __MAC_OS_X_VERSION_MIN_REQUIRED = 101000
-
RenderingStyleSaver(CTFontRef, CGContextRef) { }
-
-#elif !defined(CORETEXT_HAS_CTFontSetRenderingStyle) || CORETEXT_HAS_CTFontSetRenderingStyle != 1
-
-// This is very slow, but it's just a holdover until everyone migrates to CTFontSetRenderingStyle()
-// FIXME: Delete this implementation when everyone has migrated off
-RenderingStyleSaver(CTFontRef font, CGContextRef context)
-: m_context(context)
-{
-CGContextSaveGState(context);
-CTFontSetRenderingParameters(font, context);
-}
-
-~RenderingStyleSaver()
-{
-CGContextRestoreGState(m_context);
-}
-
-private:
-CGContextRef m_context;
-
#else
-
RenderingStyleSaver(CTFontRef font, CGContextRef context)
: m_context(context)
{
@@ -177,7 +155,6 @@
CGContextRef m_context;
CGFontRenderingStyle m_originalStyle;
CGSize m_originalDilation;
-
#endif
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185118] trunk/Source/WebCore
Title: [185118] trunk/Source/WebCore
Revision 185118
Author cdu...@apple.com
Date 2015-06-02 13:20:41 -0700 (Tue, 02 Jun 2015)
Log Message
Calling FrameView::viewportContentsChanged() after style recalcs is too expensive
https://bugs.webkit.org/show_bug.cgi?id=145554
rdar://problem/21189478
Reviewed by Darin Adler and Simon Fraser.
Only call FrameView::viewportContentsChanged() after a style recalc if
composited layers have been updated (and there is no pending layout).
We already viewportContentsChanged() after layout so we only need to
call viewportContentsChanged() after a style recalc if it did not cause
a layout but may have caused an element to become visible. In
particular, this can happen in the case of composited animations (e.g.
using -webkit-transform to move an element inside the viewport).
Therefore, we now only call viewportContentsChanged() after a style
recalc if it caused composited layers to be updated. This avoids a lot
of unnecessary calls to viewportContentsChanged(), which is expensive.
No new tests, already covered by:
fast/images/animated-gif-webkit-transform.html
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
* page/FrameView.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
* rendering/RenderLayerCompositor.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (185117 => 185118)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 20:19:08 UTC (rev 185117)
+++ trunk/Source/WebCore/ChangeLog 2015-06-02 20:20:41 UTC (rev 185118)
@@ -1,3 +1,36 @@
+2015-06-02 Chris Dumez cdu...@apple.com
+
+Calling FrameView::viewportContentsChanged() after style recalcs is too expensive
+https://bugs.webkit.org/show_bug.cgi?id=145554
+rdar://problem/21189478
+
+Reviewed by Darin Adler and Simon Fraser.
+
+Only call FrameView::viewportContentsChanged() after a style recalc if
+composited layers have been updated (and there is no pending layout).
+
+We already viewportContentsChanged() after layout so we only need to
+call viewportContentsChanged() after a style recalc if it did not cause
+a layout but may have caused an element to become visible. In
+particular, this can happen in the case of composited animations (e.g.
+using -webkit-transform to move an element inside the viewport).
+Therefore, we now only call viewportContentsChanged() after a style
+recalc if it caused composited layers to be updated. This avoids a lot
+of unnecessary calls to viewportContentsChanged(), which is expensive.
+
+No new tests, already covered by:
+fast/images/animated-gif-webkit-transform.html
+
+* dom/Document.cpp:
+(WebCore::Document::recalcStyle):
+* page/FrameView.cpp:
+(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
+* page/FrameView.h:
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
+(WebCore::RenderLayerCompositor::updateCompositingLayers):
+* rendering/RenderLayerCompositor.h:
+
2015-06-02 Myles C. Maxfield mmaxfi...@apple.com
Remove use of CTFontSetRenderingParameters()
Modified: trunk/Source/WebCore/dom/Document.cpp (185117 => 185118)
--- trunk/Source/WebCore/dom/Document.cpp 2015-06-02 20:19:08 UTC (rev 185117)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-06-02 20:20:41 UTC (rev 185118)
@@ -1767,6 +1767,7 @@
// i.e. updating the flag here would be too late.
m_inStyleRecalc = true;
+bool updatedCompositingLayers = false;
{
Style::PostResolutionCallbackDisabler disabler(*this);
WidgetHierarchyUpdatesSuspensionScope suspendWidgetHierarchyUpdates;
@@ -1781,7 +1782,7 @@
Style::resolveTree(*this, change);
-frameView.updateCompositingLayersAfterStyleChange();
+updatedCompositingLayers = frameView.updateCompositingLayersAfterStyleChange();
clearNeedsStyleRecalc();
clearChildNeedsStyleRecalc();
@@ -1807,7 +1808,7 @@
// Some animated images may now be inside the viewport due to style recalc,
// resume them if necessary if there is no layout pending. Otherwise, we'll
// check if they need to be resumed after layout.
-if (!frameView.needsLayout())
+if (updatedCompositingLayers !frameView.needsLayout())
frameView.viewportContentsChanged();
// As a result of the style recalculation, the currently hovered element
[webkit-changes] [185119] trunk/LayoutTests
Title: [185119] trunk/LayoutTests
Revision 185119
Author s...@apple.com
Date 2015-06-02 13:22:15 -0700 (Tue, 02 Jun 2015)
Log Message
Fix Mac Mavericks layout test failure following http://trac.webkit.org/changeset/185096
(https://bugs.webkit.org/show_bug.cgi?id=145478)
Move fast/text/font-weights-zh.html out of the platform directory. The
webkit test runner is not smart enough to ignore the expected results
in the mac directory and get it from the Mavericks directory, if it exists,
when running on Mavericks.
Reviewed by Alexey Proskuryakov.
* fast/text/font-weights-zh.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/fast/text/font-weights-zh.html: Removed.
* platform/win/TestExpectations:
* platform/win-xp/TestExpectations:
* platform/wincairo/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/wincairo/TestExpectations
Added Paths
trunk/LayoutTests/fast/text/font-weights-zh.html
Removed Paths
trunk/LayoutTests/platform/mac/fast/text/font-weights-zh.html
Diff
Modified: trunk/LayoutTests/ChangeLog (185118 => 185119)
--- trunk/LayoutTests/ChangeLog 2015-06-02 20:20:41 UTC (rev 185118)
+++ trunk/LayoutTests/ChangeLog 2015-06-02 20:22:15 UTC (rev 185119)
@@ -1,3 +1,23 @@
+2015-06-02 Said Abou-Hallawa sabouhall...@apple.com
+
+Fix Mac Mavericks layout test failure following http://trac.webkit.org/changeset/185096
+(https://bugs.webkit.org/show_bug.cgi?id=145478)
+
+Move fast/text/font-weights-zh.html out of the platform directory. The
+webkit test runner is not smart enough to ignore the expected results
+in the mac directory and get it from the Mavericks directory, if it exists,
+when running on Mavericks.
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/text/font-weights-zh.html: Added.
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/mac/fast/text/font-weights-zh.html: Removed.
+* platform/win/TestExpectations:
+* platform/win-xp/TestExpectations:
+* platform/wincairo/TestExpectations:
+
2015-06-02 Brady Eidson beid...@apple.com
Add more tests for should open external urls flag.
Added: trunk/LayoutTests/fast/text/font-weights-zh.html (0 => 185119)
--- trunk/LayoutTests/fast/text/font-weights-zh.html (rev 0)
+++ trunk/LayoutTests/fast/text/font-weights-zh.html 2015-06-02 20:22:15 UTC (rev 185119)
@@ -0,0 +1,36 @@
+!DOCTYPE html
+html
+head
+meta charset=UTF-8
+/head
+body
+This test is designed to test the interaction between font-family and font-weight. In particular, our implementation of font-family accepts PostScript names, which may name a font with a particular weight. However, there is another CSS property, font-weight, in which the author may also name a particular weight. Our font selection algorithm takes both of these signals into account when choosing fonts.brbrThere is currently no good way in _javascript_ to find the actual font chosen for some text. Therefore, the best way to test this aspect of the font selection algorithm is to dump the render tree, therefore testing glyph advances (which are a property of font weight).
+script
+function generateElements(fontNames) {
+[normal, italic].forEach(function(fontStyle) {
+fontNames.forEach(function(fontName) {
+for (var fontWeight = 100; fontWeight 1000; fontWeight += 100) {
+var d = document.createElement(div);
+d.innerText = Font: + fontName + Weight: + fontWeight + Style: + fontStyle;
+document.body.appendChild(d);
+d = document.createElement(div);
+d.style.fontFamily = fontName;
+d.style.fontWeight = fontWeight;
+d.style.fontStyle = fontStyle;
+d.innerText = 果城的美譽。中国古;
+document.body.appendChild(d);
+}
+});
+});
+}
+var heitiFonts = [Heiti SC, STHeitiSC-Light, STHeitiSC-Medium];
+var songtiFonts = [Songti SC, STSongti-SC-Regular, STSongti-SC-Light, STSongti-SC-Bold, STSongti-SC-Black];
+var hiraginoFonts = [Hiragino Kaku Gothic ProN, HiraKakuProN-W3, HiraKakuProN-W6];
+var appleSDGothicNeoFonts = [Apple SD Gothic Neo, AppleSDGothicNeo-Regular, AppleSDGothicNeo-Medium, AppleSDGothicNeo-Light, AppleSDGothicNeo-UltraLight, AppleSDGothicNeo-Thin, AppleSDGothicNeo-SemiBold, AppleSDGothicNeo-Bold, AppleSDGothicNeo-ExtraBold, AppleSDGothicNeo-Heavy];
+generateElements(heitiFonts);
+generateElements(songtiFonts);
+generateElements(hiraginoFonts);
+generateElements(appleSDGothicNeoFonts);
+/script
+/body
+/html
Modified: trunk/LayoutTests/platform/efl/TestExpectations (185118 => 185119)
---
[webkit-changes] [185120] trunk/Source/WebCore
Title: [185120] trunk/Source/WebCore
Revision 185120
Author eric.carl...@apple.com
Date 2015-06-02 14:04:55 -0700 (Tue, 02 Jun 2015)
Log Message
[Mac] occasional crash in Document::playbackTargetAvailabilityDidChange
https://bugs.webkit.org/show_bug.cgi?id=145559
Reviewed by Darin Adler.
No new tests, covered by existing tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::registerWithDocument): Pass document to m_mediaSession-registerWithDocument.
(WebCore::HTMLMediaElement::unregisterWithDocument): Pass document to m_mediaSession-unRegisterWithDocument.
(WebCore::HTMLMediaElement::documentWillSuspendForPageCache): Ditto.
(WebCore::HTMLMediaElement::documentDidResumeFromPageCache): Ditto.
* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::registerWithDocument): Take a document.
(WebCore::MediaElementSession::unregisterWithDocument): Ditto.
* html/MediaElementSession.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/MediaElementSession.cpp
trunk/Source/WebCore/html/MediaElementSession.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (185119 => 185120)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 20:22:15 UTC (rev 185119)
+++ trunk/Source/WebCore/ChangeLog 2015-06-02 21:04:55 UTC (rev 185120)
@@ -1,3 +1,23 @@
+2015-06-02 Eric Carlson eric.carl...@apple.com
+
+[Mac] occasional crash in Document::playbackTargetAvailabilityDidChange
+https://bugs.webkit.org/show_bug.cgi?id=145559
+
+Reviewed by Darin Adler.
+
+No new tests, covered by existing tests.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::registerWithDocument): Pass document to m_mediaSession-registerWithDocument.
+(WebCore::HTMLMediaElement::unregisterWithDocument): Pass document to m_mediaSession-unRegisterWithDocument.
+(WebCore::HTMLMediaElement::documentWillSuspendForPageCache): Ditto.
+(WebCore::HTMLMediaElement::documentDidResumeFromPageCache): Ditto.
+
+* html/MediaElementSession.cpp:
+(WebCore::MediaElementSession::registerWithDocument): Take a document.
+(WebCore::MediaElementSession::unregisterWithDocument): Ditto.
+* html/MediaElementSession.h:
+
2015-06-02 Chris Dumez cdu...@apple.com
Calling FrameView::viewportContentsChanged() after style recalcs is too expensive
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (185119 => 185120)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2015-06-02 20:22:15 UTC (rev 185119)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2015-06-02 21:04:55 UTC (rev 185120)
@@ -460,7 +460,7 @@
void HTMLMediaElement::registerWithDocument(Document document)
{
-m_mediaSession-registerWithDocument(*this);
+m_mediaSession-registerWithDocument(document);
if (m_isWaitingUntilMediaCanStart)
document.addMediaCanStartListener(this);
@@ -492,7 +492,7 @@
void HTMLMediaElement::unregisterWithDocument(Document document)
{
-m_mediaSession-unregisterWithDocument(*this);
+m_mediaSession-unregisterWithDocument(document);
if (m_isWaitingUntilMediaCanStart)
document.removeMediaCanStartListener(this);
@@ -530,9 +530,8 @@
document().incrementLoadEventDelayCount();
}
-if (oldDocument) {
+if (oldDocument)
unregisterWithDocument(*oldDocument);
-}
registerWithDocument(document());
@@ -542,12 +541,12 @@
#if ENABLE(WIRELESS_PLAYBACK_TARGET)
void HTMLMediaElement::documentWillSuspendForPageCache()
{
-m_mediaSession-unregisterWithDocument(*this);
+m_mediaSession-unregisterWithDocument(document());
}
void HTMLMediaElement::documentDidResumeFromPageCache()
{
-m_mediaSession-registerWithDocument(*this);
+m_mediaSession-registerWithDocument(document());
}
#endif
Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (185119 => 185120)
--- trunk/Source/WebCore/html/MediaElementSession.cpp 2015-06-02 20:22:15 UTC (rev 185119)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp 2015-06-02 21:04:55 UTC (rev 185120)
@@ -87,21 +87,21 @@
{
}
-void MediaElementSession::registerWithDocument(const HTMLMediaElement element)
+void MediaElementSession::registerWithDocument(Document document)
{
#if ENABLE(WIRELESS_PLAYBACK_TARGET)
-element.document().addPlaybackTargetPickerClient(*this);
+document.addPlaybackTargetPickerClient(*this);
#else
-UNUSED_PARAM(element);
+UNUSED_PARAM(document);
#endif
}
-void MediaElementSession::unregisterWithDocument(const HTMLMediaElement element)
+void MediaElementSession::unregisterWithDocument(Document document)
{
#if ENABLE(WIRELESS_PLAYBACK_TARGET)
-element.document().removePlaybackTargetPickerClient(*this);
+document.removePlaybackTargetPickerClient(*this);
#else
-UNUSED_PARAM(element);
+UNUSED_PARAM(document);
#endif
}
Modified:
[webkit-changes] [185121] trunk/Source/WebInspectorUI
Title: [185121] trunk/Source/WebInspectorUI
Revision 185121
Author commit-qu...@webkit.org
Date 2015-06-02 14:14:25 -0700 (Tue, 02 Jun 2015)
Log Message
Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in the quick console
https://bugs.webkit.org/show_bug.cgi?id=145546
Patch by Joseph Pecoraro pecor...@apple.com on 2015-06-02
Reviewed by Timothy Hatcher.
Scope ContentBrowser keyboard events within the ContentBrowser instead
of global, where they might conflict between ContentBrowsers. The scoped
shortcuts now no longer need to be enabled/disabled.
* UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser):
Scope the keyboard shortcuts.
(WebInspector.ContentBrowser.prototype.shown):
(WebInspector.ContentBrowser.prototype.hidden):
No longer need to control enabling / disabling these non-global shortcuts.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185120 => 185121)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-02 21:04:55 UTC (rev 185120)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-02 21:14:25 UTC (rev 185121)
@@ -1,3 +1,22 @@
+2015-06-02 Joseph Pecoraro pecor...@apple.com
+
+Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in the quick console
+https://bugs.webkit.org/show_bug.cgi?id=145546
+
+Reviewed by Timothy Hatcher.
+
+Scope ContentBrowser keyboard events within the ContentBrowser instead
+of global, where they might conflict between ContentBrowsers. The scoped
+shortcuts now no longer need to be enabled/disabled.
+
+* UserInterface/Views/ContentBrowser.js:
+(WebInspector.ContentBrowser):
+Scope the keyboard shortcuts.
+
+(WebInspector.ContentBrowser.prototype.shown):
+(WebInspector.ContentBrowser.prototype.hidden):
+No longer need to control enabling / disabling these non-global shortcuts.
+
2015-06-01 Jono Wells jonowe...@apple.com
Web Inspector: Type token text descenders touch bottom of container
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js (185120 => 185121)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js 2015-06-02 21:04:55 UTC (rev 185120)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js 2015-06-02 21:14:25 UTC (rev 185121)
@@ -42,21 +42,14 @@
this._findBanner.addEventListener(WebInspector.FindBanner.Event.DidShow, this._findBannerDidShow, this);
this._findBanner.addEventListener(WebInspector.FindBanner.Event.DidHide, this._findBannerDidHide, this);
-this._findKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, F, this._showFindBanner.bind(this));
-this._saveKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, S, this._save.bind(this));
-this._saveAsKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Shift | WebInspector.KeyboardShortcut.Modifier.CommandOrControl, S, this._saveAs.bind(this));
+this._findKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, F, this._showFindBanner.bind(this), this._element);
+this._saveKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, S, this._save.bind(this), this._element);
+this._saveAsKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Shift | WebInspector.KeyboardShortcut.Modifier.CommandOrControl, S, this._saveAs.bind(this), this._element);
-this._findKeyboardShortcut.disabled = true;
-this._saveKeyboardShortcut.disabled = true;
-this._saveAsKeyboardShortcut.disabled = true;
-
if (!disableBackForward) {
-this._backKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Control, WebInspector.KeyboardShortcut.Key.Left, this._backButtonClicked.bind(this));
-this._forwardKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Control, WebInspector.KeyboardShortcut.Key.Right, this._forwardButtonClicked.bind(this));
+this._backKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Control, WebInspector.KeyboardShortcut.Key.Left, this._backButtonClicked.bind(this), this._element);
+this._forwardKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Control, WebInspector.KeyboardShortcut.Key.Right,
[webkit-changes] [185116] trunk/Source/WebCore
Title: [185116] trunk/Source/WebCore
Revision 185116
Author ander...@apple.com
Date 2015-06-02 13:00:01 -0700 (Tue, 02 Jun 2015)
Log Message
Move WKFontAntialiasingStateSaver to its own file
https://bugs.webkit.org/show_bug.cgi?id=145557
rdar://problem/21134776
Reviewed by Dan Bernstein.
Also rename it to FontAntialiasingStateSaver. Also, change it to use the CoreGraphicsSPI.h header for its
CGFontAntialiasingStyle definition instead of using an explicit typedef.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::drawLayerContents):
* platform/graphics/ios/FontAntialiasingStateSaver.h: Copied from Source/WebCore/platform/ios/wak/WKGraphics.h.
(WebCore::FontAntialiasingStateSaver::FontAntialiasingStateSaver):
(WebCore::FontAntialiasingStateSaver::setup):
(WebCore::FontAntialiasingStateSaver::restore):
* platform/ios/LegacyTileCache.mm:
(WebCore::LegacyTileCache::drawWindowContent):
* platform/ios/wak/WKGraphics.h:
(WKFontAntialiasingStateSaver::WKFontAntialiasingStateSaver): Deleted.
* platform/ios/wak/WKGraphics.mm:
(WKFontAntialiasingStateSaver::setup): Deleted.
(WKFontAntialiasingStateSaver::restore): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
trunk/Source/WebCore/platform/ios/LegacyTileCache.mm
trunk/Source/WebCore/platform/ios/wak/WKGraphics.h
trunk/Source/WebCore/platform/ios/wak/WKGraphics.mm
Added Paths
trunk/Source/WebCore/platform/graphics/ios/FontAntialiasingStateSaver.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (185115 => 185116)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 19:40:13 UTC (rev 185115)
+++ trunk/Source/WebCore/ChangeLog 2015-06-02 20:00:01 UTC (rev 185116)
@@ -1,3 +1,29 @@
+2015-06-02 Anders Carlsson ander...@apple.com
+
+Move WKFontAntialiasingStateSaver to its own file
+https://bugs.webkit.org/show_bug.cgi?id=145557
+rdar://problem/21134776
+
+Reviewed by Dan Bernstein.
+
+Also rename it to FontAntialiasingStateSaver. Also, change it to use the CoreGraphicsSPI.h header for its
+CGFontAntialiasingStyle definition instead of using an explicit typedef.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/graphics/ca/mac/PlatformCALayerMac.mm:
+(PlatformCALayer::drawLayerContents):
+* platform/graphics/ios/FontAntialiasingStateSaver.h: Copied from Source/WebCore/platform/ios/wak/WKGraphics.h.
+(WebCore::FontAntialiasingStateSaver::FontAntialiasingStateSaver):
+(WebCore::FontAntialiasingStateSaver::setup):
+(WebCore::FontAntialiasingStateSaver::restore):
+* platform/ios/LegacyTileCache.mm:
+(WebCore::LegacyTileCache::drawWindowContent):
+* platform/ios/wak/WKGraphics.h:
+(WKFontAntialiasingStateSaver::WKFontAntialiasingStateSaver): Deleted.
+* platform/ios/wak/WKGraphics.mm:
+(WKFontAntialiasingStateSaver::setup): Deleted.
+(WKFontAntialiasingStateSaver::restore): Deleted.
+
2015-06-02 Xabier Rodriguez Calvar calva...@igalia.com and Youenn Fablet youenn.fab...@crf.canon.fr
[Streams API] Implement ReadableStreamReader read method in closed and errored state
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (185115 => 185116)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2015-06-02 19:40:13 UTC (rev 185115)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2015-06-02 20:00:01 UTC (rev 185116)
@@ -824,6 +824,7 @@
1AC2260C0DB69F190089B669 /* JSDOMApplicationCache.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AC2260A0DB69F190089B669 /* JSDOMApplicationCache.cpp */; };
1AC2260D0DB69F190089B669 /* JSDOMApplicationCache.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AC2260B0DB69F190089B669 /* JSDOMApplicationCache.h */; };
1AC2D845171734A100652FC0 /* Storage.h in Headers */ = {isa = PBXBuildFile; fileRef = 51E3F9C40DA059DC00250911 /* Storage.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 1AC2D89D1B1E291F00D52E87 /* FontAntialiasingStateSaver.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AC2D89C1B1E291F00D52E87 /* FontAntialiasingStateSaver.h */; };
1AC69593161A1E53003732CB /* GraphicsLayerFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AC69592161A1E53003732CB /* GraphicsLayerFactory.h */; settings = {ATTRIBUTES = (Private, ); }; };
1AC900C31943C0FC008625B5 /* HTTPHeaderNames.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AC900C01943C0A0008625B5 /* HTTPHeaderNames.cpp */; };
1ACADD791880D91C00D8B71D /* ProgressTrackerClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1ACADD781880D91C00D8B71D /* ProgressTrackerClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -7928,6 +7929,7 @@
1ABC7108170E5E1B00F9A9D6 /* WorkerNavigatorStorageQuota.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType
[webkit-changes] [185136] trunk/Source/WebCore
Title: [185136] trunk/Source/WebCore
Revision 185136
Author commit-qu...@webkit.org
Date 2015-06-02 17:45:00 -0700 (Tue, 02 Jun 2015)
Log Message
MediaSessions should keep track of their current state.
https://bugs.webkit.org/show_bug.cgi?id=145575
Patch by Matt Rajca mra...@apple.com on 2015-06-02
Reviewed by Alex Christensen.
* Modules/mediasession/MediaSession.h: Per the Media Session spec, the state can be 'Idle', 'Active', or
'Interrupted'. Sessions are created in an 'Idle' state.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasession/MediaSession.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (185135 => 185136)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 23:58:42 UTC (rev 185135)
+++ trunk/Source/WebCore/ChangeLog 2015-06-03 00:45:00 UTC (rev 185136)
@@ -1,3 +1,13 @@
+2015-06-02 Matt Rajca mra...@apple.com
+
+MediaSessions should keep track of their current state.
+https://bugs.webkit.org/show_bug.cgi?id=145575
+
+Reviewed by Alex Christensen.
+
+* Modules/mediasession/MediaSession.h: Per the Media Session spec, the state can be 'Idle', 'Active', or
+ 'Interrupted'. Sessions are created in an 'Idle' state.
+
2015-06-02 Jon Lee jon...@apple.com
Build fix when building with internal SDKs
Modified: trunk/Source/WebCore/Modules/mediasession/MediaSession.h (185135 => 185136)
--- trunk/Source/WebCore/Modules/mediasession/MediaSession.h 2015-06-02 23:58:42 UTC (rev 185135)
+++ trunk/Source/WebCore/Modules/mediasession/MediaSession.h 2015-06-03 00:45:00 UTC (rev 185136)
@@ -48,6 +48,14 @@
void releaseSession();
private:
+enum class State {
+Idle,
+Active,
+Interrupted
+};
+
+State m_currentState { State::Idle };
+
const String m_kind;
RefPtrMediaRemoteControls m_controls;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185132] trunk/LayoutTests
Title: [185132] trunk/LayoutTests Revision 185132 Author d...@apple.com Date 2015-06-02 16:45:11 -0700 (Tue, 02 Jun 2015) Log Message Skip webgl/useWhilePending.html on WebKit 1. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (185131 => 185132) --- trunk/LayoutTests/ChangeLog 2015-06-02 23:33:00 UTC (rev 185131) +++ trunk/LayoutTests/ChangeLog 2015-06-02 23:45:11 UTC (rev 185132) @@ -1,5 +1,11 @@ 2015-06-02 Dean Jackson d...@apple.com +Skip webgl/useWhilePending.html on WebKit 1. + +* platform/mac-wk1/TestExpectations: + +2015-06-02 Dean Jackson d...@apple.com + Crash in GraphicsContext3D::getInternalFramebufferSize https://bugs.webkit.org/show_bug.cgi?id=145479 rdar://problem/16461048 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (185131 => 185132) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-06-02 23:33:00 UTC (rev 185131) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-06-02 23:45:11 UTC (rev 185132) @@ -67,6 +67,9 @@ # Disable snapshotting tests on WK1 only plugins/snapshotting +# WK1 doesn't do pending WebGL policies +fast/canvas/webgl/useWhilePending.html [ Skip ] + # Animated image throttling behaves differently on WK1. fast/images/animated-gif-body-outside-viewport.html [ Skip ] fast/images/animated-gif-window-resizing.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185131] trunk/Source/JavaScriptCore
Title: [185131] trunk/Source/_javascript_Core Revision 185131 Author mark@apple.com Date 2015-06-02 16:33:00 -0700 (Tue, 02 Jun 2015) Log Message Gardening: fix broken CLoop build. Not reviewed. * bytecode/CallLinkStatus.cpp: (JSC::CallLinkStatus::computeExitSiteData): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/CallLinkStatus.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (185130 => 185131) --- trunk/Source/_javascript_Core/ChangeLog 2015-06-02 22:23:36 UTC (rev 185130) +++ trunk/Source/_javascript_Core/ChangeLog 2015-06-02 23:33:00 UTC (rev 185131) @@ -1,3 +1,12 @@ +2015-06-02 Mark Lam mark@apple.com + +Gardening: fix broken CLoop build. + +Not reviewed. + +* bytecode/CallLinkStatus.cpp: +(JSC::CallLinkStatus::computeExitSiteData): + 2015-06-02 Keith Miller keith_mil...@apple.com _javascript_Core: JSExport protocol with an NSInteger property converts negative values to 18446744073709552000 Modified: trunk/Source/_javascript_Core/bytecode/CallLinkStatus.cpp (185130 => 185131) --- trunk/Source/_javascript_Core/bytecode/CallLinkStatus.cpp 2015-06-02 22:23:36 UTC (rev 185130) +++ trunk/Source/_javascript_Core/bytecode/CallLinkStatus.cpp 2015-06-02 23:33:00 UTC (rev 185131) @@ -115,7 +115,6 @@ UNUSED_PARAM(locker); UNUSED_PARAM(profiledBlock); UNUSED_PARAM(bytecodeIndex); -UNUSED_PARAM(exitingJITType); #endif return exitSiteData; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185133] trunk/Source/WebCore
Title: [185133] trunk/Source/WebCore Revision 185133 Author jon...@apple.com Date 2015-06-02 16:51:18 -0700 (Tue, 02 Jun 2015) Log Message Build fix when building with internal SDKs https://bugs.webkit.org/show_bug.cgi?id=145576 rdar://problem/21089476 Reviewed by Alexey Proskuryakov. * platform/spi/mac/AVFoundationSPI.h: Include the right header. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/spi/mac/AVFoundationSPI.h Diff Modified: trunk/Source/WebCore/ChangeLog (185132 => 185133) --- trunk/Source/WebCore/ChangeLog 2015-06-02 23:45:11 UTC (rev 185132) +++ trunk/Source/WebCore/ChangeLog 2015-06-02 23:51:18 UTC (rev 185133) @@ -1,3 +1,13 @@ +2015-06-02 Jon Lee jon...@apple.com + +Build fix when building with internal SDKs +https://bugs.webkit.org/show_bug.cgi?id=145576 +rdar://problem/21089476 + +Reviewed by Alexey Proskuryakov. + +* platform/spi/mac/AVFoundationSPI.h: Include the right header. + 2015-06-02 Dean Jackson d...@apple.com No need to guard the sizes attribute against PICTURE_SIZES in preload scanner. Modified: trunk/Source/WebCore/platform/spi/mac/AVFoundationSPI.h (185132 => 185133) --- trunk/Source/WebCore/platform/spi/mac/AVFoundationSPI.h 2015-06-02 23:45:11 UTC (rev 185132) +++ trunk/Source/WebCore/platform/spi/mac/AVFoundationSPI.h 2015-06-02 23:51:18 UTC (rev 185133) @@ -54,9 +54,12 @@ #if PLATFORM(IOS) #if HAVE(AVKIT) USE(APPLE_INTERNAL_SDK) + +#import AVFoundation/AVPlayerLayer_Private.h #import AVKit/AVPlayerViewController_WebKitOnly.h -#endif +#else + #import AVFoundation/AVPlayerLayer.h @interface AVPlayerLayer (AVPlayerLayerOptimizedFullscreenModeSupportPrivate) @@ -65,3 +68,5 @@ #endif +#endif // PLATFORM(IOS) + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185134] trunk/Source/WebInspectorUI
Title: [185134] trunk/Source/WebInspectorUI
Revision 185134
Author commit-qu...@webkit.org
Date 2015-06-02 16:56:12 -0700 (Tue, 02 Jun 2015)
Log Message
Web Inspector: Shift + Cmd + Left/Right shouldn't switch tabs while editing text
https://bugs.webkit.org/show_bug.cgi?id=145562
Patch by Joseph Pecoraro pecor...@apple.com on 2015-06-02
Reviewed by Timothy Hatcher.
* UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser):
Only these keyboard shortcuts should check if we are in an editable field.
Remove the implicit prevent default so they can fall back to system behavior
if necessary.
(WebInspector.TabBrowser.prototype._showNextTabCheckingForEditableField):
(WebInspector.TabBrowser.prototype._showPreviousTabCheckingForEditableField):
Bail if we are in an editable field. Otherwise perform the action and prevent default.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185133 => 185134)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-02 23:51:18 UTC (rev 185133)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-02 23:56:12 UTC (rev 185134)
@@ -1,5 +1,22 @@
2015-06-02 Joseph Pecoraro pecor...@apple.com
+Web Inspector: Shift + Cmd + Left/Right shouldn't switch tabs while editing text
+https://bugs.webkit.org/show_bug.cgi?id=145562
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TabBrowser.js:
+(WebInspector.TabBrowser):
+Only these keyboard shortcuts should check if we are in an editable field.
+Remove the implicit prevent default so they can fall back to system behavior
+if necessary.
+
+(WebInspector.TabBrowser.prototype._showNextTabCheckingForEditableField):
+(WebInspector.TabBrowser.prototype._showPreviousTabCheckingForEditableField):
+Bail if we are in an editable field. Otherwise perform the action and prevent default.
+
+2015-06-02 Joseph Pecoraro pecor...@apple.com
+
Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in the quick console
https://bugs.webkit.org/show_bug.cgi?id=145546
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js (185133 => 185134)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2015-06-02 23:51:18 UTC (rev 185133)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBrowser.js 2015-06-02 23:56:12 UTC (rev 185134)
@@ -57,9 +57,12 @@
this._showPreviousTabKeyboardShortcut1 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.LeftCurlyBrace, showPreviousTab);
this._showNextTabKeyboardShortcut2 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Control, WebInspector.KeyboardShortcut.Key.Tab, showNextTab);
this._showPreviousTabKeyboardShortcut2 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Control | WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Tab, showPreviousTab);
-this._showNextTabKeyboardShortcut3 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Right, showNextTab);
-this._showPreviousTabKeyboardShortcut3 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Left, showPreviousTab);
+this._showNextTabKeyboardShortcut3 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Right, this._showNextTabCheckingForEditableField.bind(this));
+this._showNextTabKeyboardShortcut3.implicitlyPreventsDefault = false;
+this._showPreviousTabKeyboardShortcut3 = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl | WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Left, this._showPreviousTabCheckingForEditableField.bind(this));
+this._showPreviousTabKeyboardShortcut3.implicitlyPreventsDefault = false;
+
this._tabBar.newTabItem = new WebInspector.TabBarItem(Images/NewTabPlus.svg, WebInspector.UIString(Create a new tab), true);
this._tabBar.addEventListener(WebInspector.TabBar.Event.TabBarItemSelected, this._tabBarItemSelected, this);
@@ -351,6 +354,26 @@
{
this._tabBar.selectNextTab();
}
+
+_showNextTabCheckingForEditableField(event)
+{
+if (WebInspector.isEventTargetAnEditableField(event))
+return;
+
+this._showNextTab(event);
+
+event.preventDefault();
+}
+
+
[webkit-changes] [185135] trunk/Source/WebInspectorUI
Title: [185135] trunk/Source/WebInspectorUI
Revision 185135
Author nvasil...@apple.com
Date 2015-06-02 16:58:42 -0700 (Tue, 02 Jun 2015)
Log Message
Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
https://bugs.webkit.org/show_bug.cgi?id=145540
Also, increase clickable area of the arrow icon.
Reviewed by Timothy Hatcher.
* UserInterface/Views/DashboardContainerView.css:
(.dashboard-container .advance-arrow):
(.dashboard-container .advance-arrow.advance-forward):
(.dashboard-container .advance-arrow.advance-backward):
* UserInterface/Views/DebuggerDashboardView.css:
(.dashboard.debugger .location):
(.toolbar .dashboard.debugger):
Increase padding on the right so the content of the dashboard would be never be overlayed by the arrow.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185134 => 185135)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-02 23:56:12 UTC (rev 185134)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-02 23:58:42 UTC (rev 185135)
@@ -1,3 +1,21 @@
+2015-06-02 Nikita Vasilyev nvasil...@apple.com
+
+Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
+https://bugs.webkit.org/show_bug.cgi?id=145540
+
+Also, increase clickable area of the arrow icon.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/DashboardContainerView.css:
+(.dashboard-container .advance-arrow):
+(.dashboard-container .advance-arrow.advance-forward):
+(.dashboard-container .advance-arrow.advance-backward):
+* UserInterface/Views/DebuggerDashboardView.css:
+(.dashboard.debugger .location):
+(.toolbar .dashboard.debugger):
+Increase padding on the right so the content of the dashboard would be never be overlayed by the arrow.
+
2015-06-02 Joseph Pecoraro pecor...@apple.com
Web Inspector: Shift + Cmd + Left/Right shouldn't switch tabs while editing text
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css (185134 => 185135)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css 2015-06-02 23:56:12 UTC (rev 185134)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css 2015-06-02 23:58:42 UTC (rev 185135)
@@ -114,10 +114,11 @@
.dashboard-container .advance-arrow {
position: absolute;
-right: 0px;
-width: 10px;
-height: 10px;
-margin: 4px;
+right: 0;
+width: 12px;
+top: 0;
+bottom: 0;
+padding: 4px 0;
opacity: 0.6;
z-index: 1000;
@@ -127,6 +128,7 @@
transition-property: opacity;
transition-duration: 0.2s;
+background-clip: content-box;
}
.dashboard-container .advance-arrow:hover {
@@ -151,10 +153,10 @@
.dashboard-container .advance-arrow.advance-forward {
top: 0;
-background-position: 0% 0%;
+background-position: 50% 4px;
}
.dashboard-container .advance-arrow.advance-backward {
bottom: 0;
-background-position: 0% 100%;
+background-position: 50% -4px;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css (185134 => 185135)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css 2015-06-02 23:56:12 UTC (rev 185134)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css 2015-06-02 23:58:42 UTC (rev 185135)
@@ -31,7 +31,7 @@
text-align: center;
text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
color: rgb(60, 60, 60);
-padding: 0 5px;
+padding: 0 12px 0 5px;
}
.dashboard.debugger .message {
@@ -90,6 +90,7 @@
}
.dashboard.debugger .location {
+overflow: hidden;
flex: initial;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185129] trunk/Source/WebCore
Title: [185129] trunk/Source/WebCore
Revision 185129
Author ander...@apple.com
Date 2015-06-02 15:14:23 -0700 (Tue, 02 Jun 2015)
Log Message
Use UUIDs for WebSQL database filenames instead of a sequential number
https://bugs.webkit.org/show_bug.cgi?id=145571
Reviewed by Dan Bernstein.
This is a first step towards getting rid of the iOS specific code path where we truncate
database files instead of deleting them (in order to avoid file corruption).
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::generateDatabaseFileName):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
* platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::getFileNameForNewDatabase): Deleted.
* platform/sql/SQLiteFileSystem.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp
trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp
trunk/Source/WebCore/platform/sql/SQLiteFileSystem.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (185128 => 185129)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 22:11:32 UTC (rev 185128)
+++ trunk/Source/WebCore/ChangeLog 2015-06-02 22:14:23 UTC (rev 185129)
@@ -1,3 +1,20 @@
+2015-06-02 Anders Carlsson ander...@apple.com
+
+Use UUIDs for WebSQL database filenames instead of a sequential number
+https://bugs.webkit.org/show_bug.cgi?id=145571
+
+Reviewed by Dan Bernstein.
+
+This is a first step towards getting rid of the iOS specific code path where we truncate
+database files instead of deleting them (in order to avoid file corruption).
+
+* Modules/webdatabase/DatabaseTracker.cpp:
+(WebCore::generateDatabaseFileName):
+(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
+* platform/sql/SQLiteFileSystem.cpp:
+(WebCore::SQLiteFileSystem::getFileNameForNewDatabase): Deleted.
+* platform/sql/SQLiteFileSystem.h:
+
2015-06-02 Dean Jackson d...@apple.com
Crash in GraphicsContext3D::getInternalFramebufferSize
Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp (185128 => 185129)
--- trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp 2015-06-02 22:11:32 UTC (rev 185128)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp 2015-06-02 22:14:23 UTC (rev 185129)
@@ -45,6 +45,7 @@
#include SecurityOriginHash.h
#include SQLiteFileSystem.h
#include SQLiteStatement.h
+#include UUID.h
#include wtf/MainThread.h
#include wtf/NeverDestroyed.h
#include wtf/StdLibExtras.h
@@ -358,6 +359,16 @@
return SQLiteFileSystem::appendDatabaseFileNameToPath(m_databaseDirectoryPath.isolatedCopy(), origin-databaseIdentifier());
}
+static String generateDatabaseFileName()
+{
+StringBuilder stringBuilder;
+
+stringBuilder.append(createCanonicalUUIDString());
+stringBuilder.appendLiteral(.db);
+
+return stringBuilder.toString();
+}
+
String DatabaseTracker::fullPathForDatabaseNoLock(SecurityOrigin* origin, const String name, bool createIfNotExists)
{
ASSERT(!m_databaseGuard.tryLock());
@@ -393,7 +404,8 @@
}
statement.finalize();
-String fileName = SQLiteFileSystem::getFileNameForNewDatabase(originPath, name, originIdentifier, m_database);
+String fileName = generateDatabaseFileName();
+
if (!addDatabase(origin, name, fileName))
return String();
Modified: trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp (185128 => 185129)
--- trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp 2015-06-02 22:11:32 UTC (rev 185128)
+++ trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp 2015-06-02 22:14:23 UTC (rev 185129)
@@ -53,32 +53,6 @@
return sqlite3_open(fileSystemRepresentation(filename).data(), database);
}
-String SQLiteFileSystem::getFileNameForNewDatabase(const String dbDir, const String,
- const String, SQLiteDatabase* db)
-{
-// try to get the next sequence number from the given database
-// if we can't get a number, return an empty string
-SQLiteStatement sequenceStatement(*db, SELECT seq FROM sqlite_sequence WHERE name='Databases';);
-if (sequenceStatement.prepare() != SQLITE_OK)
-return String();
-int result = sequenceStatement.step();
-int64_t seq = 0;
-if (result == SQLITE_ROW)
-seq = sequenceStatement.getColumnInt64(0);
-else if (result != SQLITE_DONE)
-return String();
-sequenceStatement.finalize();
-
-// increment the number until we can use it to form a file name that doesn't exist
-String fileName;
-do {
-++seq;
-fileName = pathByAppendingComponent(dbDir, String::format(%016 PRIx64 .db, seq));
-} while (fileExists(fileName));
-
-return String::format(%016 PRIx64 .db, seq);
-}
-
String SQLiteFileSystem::appendDatabaseFileNameToPath(const String path, const String fileName)
{
return pathByAppendingComponent(path, fileName);
Modified:
[webkit-changes] [185123] trunk/Source/WebKit2
Title: [185123] trunk/Source/WebKit2 Revision 185123 Author cdu...@apple.com Date 2015-06-02 14:30:27 -0700 (Tue, 02 Jun 2015) Log Message [iOS][WK2] Always mark layers as volatile for background pages https://bugs.webkit.org/show_bug.cgi?id=145547 rdar://problem/20663184 Reviewed by Simon Fraser. We previously marked layers as volatile when the WebProcess was about to be suspended. Most of the time the WebProcess gets suspended when a page goes into the background. However, it is not always true (see radar), in which case the layers won't be marked as volatile and use memory even though they are not visible. We now mark layers as volatile as soon as the page goes into the background, instead of relying on the WebProcess suspension mechanism to do so. A new ApplicationDidEnterBackground IPC message from the UIProcess to the WebProcess is added (in addition to the pre-existing ApplicationWillEnterForeground one). When the WebProcess receives this message, it will freeze the layer tree state and mark the layers as volatile (with a timer to keep retrying if needed), similarly to what is already done in WebProcess::actualPrepareToSuspend(). When the ApplicationWillEnterForeground is received, we unfreeze the layer tree state. The layers' volatile state will be automatically updated when they are displayed (see setBufferVolatility() call in RemoteLayerBackingStore::display()). * UIProcess/WebPageProxy.h: * UIProcess/ios/WKContentView.mm: (-[WKContentView _applicationDidEnterBackground:]): * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::applicationDidEnterBackground): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::setLayerTreeStateIsFrozen): (WebKit::WebPage::markLayersVolatileImmediatelyIfPossible): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::volatilityTimerFired): (WebKit::WebPage::applicationDidEnterBackground): (WebKit::WebPage::applicationWillEnterForeground): * WebProcess/WebProcess.cpp: (WebKit::WebProcess::markAllLayersVolatileIfPossible): (WebKit::WebProcess::setAllLayerTreeStatesFrozen): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm trunk/Source/WebKit2/WebProcess/WebProcess.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (185122 => 185123) --- trunk/Source/WebKit2/ChangeLog 2015-06-02 21:24:10 UTC (rev 185122) +++ trunk/Source/WebKit2/ChangeLog 2015-06-02 21:30:27 UTC (rev 185123) @@ -1,3 +1,51 @@ +2015-06-02 Chris Dumez cdu...@apple.com + +[iOS][WK2] Always mark layers as volatile for background pages +https://bugs.webkit.org/show_bug.cgi?id=145547 +rdar://problem/20663184 + +Reviewed by Simon Fraser. + +We previously marked layers as volatile when the WebProcess was about +to be suspended. Most of the time the WebProcess gets suspended when a +page goes into the background. However, it is not always true (see +radar), in which case the layers won't be marked as volatile and use +memory even though they are not visible. + +We now mark layers as volatile as soon as the page goes into the +background, instead of relying on the WebProcess suspension mechanism +to do so. + +A new ApplicationDidEnterBackground IPC message from the UIProcess to +the WebProcess is added (in addition to the pre-existing +ApplicationWillEnterForeground one). When the WebProcess receives this +message, it will freeze the layer tree state and mark the layers as +volatile (with a timer to keep retrying if needed), similarly to what +is already done in WebProcess::actualPrepareToSuspend(). +When the ApplicationWillEnterForeground is received, we unfreeze the +layer tree state. The layers' volatile state will be automatically +updated when they are displayed (see setBufferVolatility() call in +RemoteLayerBackingStore::display()). + +* UIProcess/WebPageProxy.h: +* UIProcess/ios/WKContentView.mm: +(-[WKContentView _applicationDidEnterBackground:]): +* UIProcess/ios/WebPageProxyIOS.mm: +(WebKit::WebPageProxy::applicationDidEnterBackground): +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::WebPage): +(WebKit::WebPage::setLayerTreeStateIsFrozen): +(WebKit::WebPage::markLayersVolatileImmediatelyIfPossible): +* WebProcess/WebPage/WebPage.h: +* WebProcess/WebPage/WebPage.messages.in: +* WebProcess/WebPage/ios/WebPageIOS.mm: +
[webkit-changes] [185126] trunk/Source/WebCore
Title: [185126] trunk/Source/WebCore Revision 185126 Author commit-qu...@webkit.org Date 2015-06-02 14:54:13 -0700 (Tue, 02 Jun 2015) Log Message Added a stub implementation of MediaSession, part of the Media Session spec. https://bugs.webkit.org/show_bug.cgi?id=145530 Patch by Matt Rajca mra...@apple.com on 2015-06-02 Reviewed by Eric Carlson. * CMakeLists.txt: Added new MediaSession sources. * DerivedSources.make: * Modules/mediasession/MediaSession.cpp: Added stub implementation. (WebCore::MediaSession::MediaSession): Per the Media Session spec, a Media Remote Controls object should only be set for 'content' sessions; it is null otherwise. (WebCore::MediaSession::~MediaSession): (WebCore::MediaSession::controls): (WebCore::MediaSession::releaseSession): * Modules/mediasession/MediaSession.h: Added basic translation of IDL file. * Modules/mediasession/MediaSession.idl: Added from the Media Session spec. * WebCore.xcodeproj/project.pbxproj: Added new MediaSession sources. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj Added Paths trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp trunk/Source/WebCore/Modules/mediasession/MediaSession.h trunk/Source/WebCore/Modules/mediasession/MediaSession.idl Diff Modified: trunk/Source/WebCore/CMakeLists.txt (185125 => 185126) --- trunk/Source/WebCore/CMakeLists.txt 2015-06-02 21:37:36 UTC (rev 185125) +++ trunk/Source/WebCore/CMakeLists.txt 2015-06-02 21:54:13 UTC (rev 185126) @@ -219,6 +219,7 @@ Modules/mediacontrols/MediaControlsHost.idl Modules/mediasession/MediaRemoteControls.idl +Modules/mediasession/MediaSession.idl Modules/mediasource/DOMURLMediaSource.idl Modules/mediasource/MediaSource.idl @@ -874,6 +875,7 @@ Modules/mediacontrols/MediaControlsHost.cpp Modules/mediasession/MediaRemoteControls.cpp +Modules/mediasession/MediaSession.cpp Modules/mediasource/DOMURLMediaSource.cpp Modules/mediasource/MediaSource.cpp Modified: trunk/Source/WebCore/ChangeLog (185125 => 185126) --- trunk/Source/WebCore/ChangeLog 2015-06-02 21:37:36 UTC (rev 185125) +++ trunk/Source/WebCore/ChangeLog 2015-06-02 21:54:13 UTC (rev 185126) @@ -1,3 +1,22 @@ +2015-06-02 Matt Rajca mra...@apple.com + +Added a stub implementation of MediaSession, part of the Media Session spec. +https://bugs.webkit.org/show_bug.cgi?id=145530 + +Reviewed by Eric Carlson. + +* CMakeLists.txt: Added new MediaSession sources. +* DerivedSources.make: +* Modules/mediasession/MediaSession.cpp: Added stub implementation. +(WebCore::MediaSession::MediaSession): Per the Media Session spec, a Media Remote Controls object should only be + set for 'content' sessions; it is null otherwise. +(WebCore::MediaSession::~MediaSession): +(WebCore::MediaSession::controls): +(WebCore::MediaSession::releaseSession): +* Modules/mediasession/MediaSession.h: Added basic translation of IDL file. +* Modules/mediasession/MediaSession.idl: Added from the Media Session spec. +* WebCore.xcodeproj/project.pbxproj: Added new MediaSession sources. + 2015-06-02 Zalan Bujtas za...@apple.com Backdrop filter is pulling in content from behind the window. Modified: trunk/Source/WebCore/DerivedSources.make (185125 => 185126) --- trunk/Source/WebCore/DerivedSources.make 2015-06-02 21:37:36 UTC (rev 185125) +++ trunk/Source/WebCore/DerivedSources.make 2015-06-02 21:54:13 UTC (rev 185126) @@ -105,6 +105,7 @@ $(WebCore)/Modules/indieui/UIRequestEvent.idl \ $(WebCore)/Modules/mediacontrols/MediaControlsHost.idl \ $(WebCore)/Modules/mediasession/MediaRemoteControls.idl \ +$(WebCore)/Modules/mediasession/MediaSession.idl \ $(WebCore)/Modules/mediasource/DOMURLMediaSource.idl \ $(WebCore)/Modules/mediasource/AudioTrackMediaSource.idl \ $(WebCore)/Modules/mediasource/MediaSource.idl \ Added: trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp (0 => 185126) --- trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp (rev 0) +++ trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp 2015-06-02 21:54:13 UTC (rev 185126) @@ -0,0 +1,57 @@ +/* + * Copyright (C) 2015 Apple Inc. All Rights Reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE
[webkit-changes] [185128] trunk
Title: [185128] trunk
Revision 185128
Author d...@apple.com
Date 2015-06-02 15:11:32 -0700 (Tue, 02 Jun 2015)
Log Message
Crash in GraphicsContext3D::getInternalFramebufferSize
https://bugs.webkit.org/show_bug.cgi?id=145479
rdar://problem/16461048
Reviewed by Eric Carlson.
Source/WebCore:
If we are in an unitialized or lost state, don't try to access the context.
In order to test this, I added an Internal setting that always
forces WebGL into a pending state.
Test: fast/canvas/webgl/useWhilePending.html
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create): Check internal settings for
a forced pending state.
(WebCore::WebGLRenderingContextBase::drawingBufferWidth): Guard against a pending state.
(WebCore::WebGLRenderingContextBase::drawingBufferHeight): Ditto.
* page/Settings.cpp: New Internal setting for forcing a pending policy.
(WebCore::Settings::Settings):
(WebCore::Settings::setForcePendingWebGLPolicy):
* page/Settings.h:
(WebCore::Settings::isForcePendingWebGLPolicy):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setForcePendingWebGLPolicy):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:
LayoutTests:
Attemps to use a WebGL context while it is in the pending state.
* fast/canvas/webgl/useWhilePending-expected.txt: Added.
* fast/canvas/webgl/useWhilePending.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
Added Paths
trunk/LayoutTests/fast/canvas/webgl/useWhilePending-expected.txt
trunk/LayoutTests/fast/canvas/webgl/useWhilePending.html
Diff
Modified: trunk/LayoutTests/ChangeLog (185127 => 185128)
--- trunk/LayoutTests/ChangeLog 2015-06-02 22:02:35 UTC (rev 185127)
+++ trunk/LayoutTests/ChangeLog 2015-06-02 22:11:32 UTC (rev 185128)
@@ -1,3 +1,16 @@
+2015-06-02 Dean Jackson d...@apple.com
+
+Crash in GraphicsContext3D::getInternalFramebufferSize
+https://bugs.webkit.org/show_bug.cgi?id=145479
+rdar://problem/16461048
+
+Reviewed by Eric Carlson.
+
+Attemps to use a WebGL context while it is in the pending state.
+
+* fast/canvas/webgl/useWhilePending-expected.txt: Added.
+* fast/canvas/webgl/useWhilePending.html: Added.
+
2015-06-02 Said Abou-Hallawa sabouhall...@apple.com
Fix Windows layout test failure following http://trac.webkit.org/changeset/185095
Added: trunk/LayoutTests/fast/canvas/webgl/useWhilePending-expected.txt (0 => 185128)
--- trunk/LayoutTests/fast/canvas/webgl/useWhilePending-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/useWhilePending-expected.txt 2015-06-02 22:11:32 UTC (rev 185128)
@@ -0,0 +1 @@
+Should not crash.
Property changes on: trunk/LayoutTests/fast/canvas/webgl/useWhilePending-expected.txt
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/fast/canvas/webgl/useWhilePending.html (0 => 185128)
--- trunk/LayoutTests/fast/canvas/webgl/useWhilePending.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/useWhilePending.html 2015-06-02 22:11:32 UTC (rev 185128)
@@ -0,0 +1,23 @@
+script
+if (window.testRunner) {
+window.internals.settings.setForcePendingWebGLPolicy(true);
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+window.addEventListener(load, function () {
+
+var canvas = document.createElement(canvas);
+canvas.width = 100;
+canvas.height = 100;
+var gl = canvas.getContext(webgl);
+var foo = gl.drawingBufferWidth;
+foo = gl.drawingBufferHeight;
+
+if (window.testRunner)
+testRunner.notifyDone();
+
+}, false);
+/script
+
+Should not crash.
Property changes on: trunk/LayoutTests/fast/canvas/webgl/useWhilePending.html
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (185127 => 185128)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 22:02:35 UTC (rev 185127)
+++ trunk/Source/WebCore/ChangeLog 2015-06-02 22:11:32 UTC (rev 185128)
@@ -1,3 +1,35 @@
+2015-06-02 Dean Jackson d...@apple.com
+
+Crash in GraphicsContext3D::getInternalFramebufferSize
+https://bugs.webkit.org/show_bug.cgi?id=145479
+rdar://problem/16461048
+
+Reviewed by Eric Carlson.
+
+If we are in an unitialized or lost state, don't try to access the context.
+
+In order to test this, I added an Internal setting that always
+
[webkit-changes] [185122] trunk/Source/JavaScriptCore
Title: [185122] trunk/Source/_javascript_Core
Revision 185122
Author commit-qu...@webkit.org
Date 2015-06-02 14:24:10 -0700 (Tue, 02 Jun 2015)
Log Message
_javascript_Core: JSExport protocol with an NSInteger property converts negative values to 18446744073709552000
https://bugs.webkit.org/show_bug.cgi?id=145563
Patch by Keith Miller keith_mil...@apple.com on 2015-06-02
Reviewed by Darin Adler.
The Objective-C bindings were improperly converting negative
long long/NSIntegers to 18446744073709552000 because they
were converted to unsigned numbers.
* API/ObjcRuntimeExtras.h:
(parseObjCType):
* API/tests/testapi.mm:
(testObjectiveCAPIMain):
(checkNegativeNSIntegers):
(testObjectiveCAPI):
Modified Paths
trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h
trunk/Source/_javascript_Core/API/tests/testapi.mm
trunk/Source/_javascript_Core/ChangeLog
Diff
Modified: trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h (185121 => 185122)
--- trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h 2015-06-02 21:14:25 UTC (rev 185121)
+++ trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h 2015-06-02 21:24:10 UTC (rev 185122)
@@ -164,7 +164,7 @@
case 'l':
return DelegateType::template typeIntegerlong();
case 'q':
-return DelegateType::template typeDoubleunsigned long long();
+return DelegateType::template typeDoublelong long();
case 'C':
return DelegateType::template typeIntegerunsigned char();
case 'I':
Modified: trunk/Source/_javascript_Core/API/tests/testapi.mm (185121 => 185122)
--- trunk/Source/_javascript_Core/API/tests/testapi.mm 2015-06-02 21:14:25 UTC (rev 185121)
+++ trunk/Source/_javascript_Core/API/tests/testapi.mm 2015-06-02 21:24:10 UTC (rev 185122)
@@ -1416,9 +1416,41 @@
runRegress141809();
}
+@protocol NumberProtocol JSExport
+
+@property (nonatomic) NSInteger number;
+
+@end
+
+@interface NumberObject : NSObject NumberProtocol
+
+@property (nonatomic) NSInteger number;
+
+@end
+
+@implementation NumberObject
+
+@end
+
+// Check that negative NSIntegers retain the correct value when passed into JS code.
+static void checkNegativeNSIntegers()
+{
+NumberObject *container = [[NumberObject alloc] init];
+container.number = -1;
+JSContext *context = [[JSContext alloc] init];
+context[@container] = container;
+NSString *jsID = @var getContainerNumber = function() { return container.number };
+[context evaluateScript:jsID];
+JSValue *jsFunction = context[@getContainerNumber];
+JSValue *result = [jsFunction callWithArguments:@[]];
+
+checkResult(@Negative number maintained its original value, [[result toString] isEqualToString:@-1]);
+}
+
void testObjectiveCAPI()
{
NSLog(@Testing Objective-C API);
+checkNegativeNSIntegers();
testWeakValue();
testObjectiveCAPIMain();
}
Modified: trunk/Source/_javascript_Core/ChangeLog (185121 => 185122)
--- trunk/Source/_javascript_Core/ChangeLog 2015-06-02 21:14:25 UTC (rev 185121)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-06-02 21:24:10 UTC (rev 185122)
@@ -1,3 +1,21 @@
+2015-06-02 Keith Miller keith_mil...@apple.com
+
+_javascript_Core: JSExport protocol with an NSInteger property converts negative values to 18446744073709552000
+https://bugs.webkit.org/show_bug.cgi?id=145563
+
+Reviewed by Darin Adler.
+
+The Objective-C bindings were improperly converting negative
+long long/NSIntegers to 18446744073709552000 because they
+were converted to unsigned numbers.
+
+* API/ObjcRuntimeExtras.h:
+(parseObjCType):
+* API/tests/testapi.mm:
+(testObjectiveCAPIMain):
+(checkNegativeNSIntegers):
+(testObjectiveCAPI):
+
2015-06-02 Yusuke Suzuki utatane@gmail.com
Heap-use-after-free read of size 4 in _javascript_Core: WTF::StringImpl::isSymbol() (StringImpl.h:496)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185125] trunk/LayoutTests
Title: [185125] trunk/LayoutTests
Revision 185125
Author s...@apple.com
Date 2015-06-02 14:37:36 -0700 (Tue, 02 Jun 2015)
Log Message
Fix Windows layout test failure following http://trac.webkit.org/changeset/185095
(https://bugs.webkit.org/show_bug.cgi?id=145537)
Unreviewed.
* platform/win/fast/text/crash-complex-text-surrogate-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/win/fast/text/crash-complex-text-surrogate-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (185124 => 185125)
--- trunk/LayoutTests/ChangeLog 2015-06-02 21:35:24 UTC (rev 185124)
+++ trunk/LayoutTests/ChangeLog 2015-06-02 21:37:36 UTC (rev 185125)
@@ -1,3 +1,12 @@
+2015-06-02 Said Abou-Hallawa sabouhall...@apple.com
+
+Fix Windows layout test failure following http://trac.webkit.org/changeset/185095
+(https://bugs.webkit.org/show_bug.cgi?id=145537)
+
+Unreviewed.
+
+* platform/win/fast/text/crash-complex-text-surrogate-expected.txt: Added.
+
2015-06-02 Zalan Bujtas za...@apple.com
Backdrop filter is pulling in content from behind the window.
Added: trunk/LayoutTests/platform/win/fast/text/crash-complex-text-surrogate-expected.txt (0 => 185125)
--- trunk/LayoutTests/platform/win/fast/text/crash-complex-text-surrogate-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/fast/text/crash-complex-text-surrogate-expected.txt 2015-06-02 21:37:36 UTC (rev 185125)
@@ -0,0 +1,60 @@
+CONSOLE MESSAGE: line 35: TypeError: undefined is not an object (evaluating 'document.forms[0].outerHTML')
+layer at (0,0) size 785x693
+ RenderView at (0,0) size 785x600
+layer at (0,0) size 785x693
+ RenderBlock {HTML} at (0,0) size 785x693
+RenderBody {BODY} at (8,8) size 80x677
+ RenderText {#text} at (0,0) size 72x120
+text run at (0,0) width 36: This
+text run at (0,15) width 36: test
+text run at (0,30) width 54: passes
+text run at (0,45) width 54: if you
+text run at (0,60) width 72: can open
+text run at (0,75) width 72: the file
+text run at (0,90) width 63: without
+text run at (0,105) width 72: a crash.
+ RenderBlock (floating) {DIV} at (72,120) size 8x182 [bgcolor=#ADD8E6]
+ RenderText {#text} at (0,120) size 9x15
+text run at (0,120) width 9: Y
+ RenderText {#text} at (9,120) size 45x15
+text run at (9,120) width 45: a bcd
+ RenderInline {SPAN} at (0,0) size 9x15
+RenderText {#text} at (54,120) size 9x15
+ text run at (54,120) width 9: \x{202B}X
+ RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,135) size 279x287
+text run at (0,135) width 54: Errlog
+text run at (0,302) width 117: webtest_fn_1:
+text run at (0,317) width 90: TypeError:
+text run at (0,332) width 81: undefined
+text run at (0,347) width 54: is not
+text run at (0,362) width 18: an
+text run at (0,377) width 54: object
+text run at (0,392) width 99: (evaluating
+text run at (0,407) width 279: 'document.scripts[3].toString')
+ RenderBR {BR} at (0,0) size 0x0
+ RenderInline {ACRONYM} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,422) size 108x45
+text run at (0,422) width 45: s is:
+text run at (0,437) width 27: {,}
+text run at (0,452) width 108: \x{A888}{0}P{P}\\7H\\8
+ RenderBR {BR} at (0,0) size 0x0
+ RenderText {#text} at (0,467) size 72x15
+text run at (0,467) width 72: f is: gi
+ RenderBR {BR} at (72,467) size 0x15
+ RenderText {#text} at (0,482) size 369x195
+text run at (0,482) width 54: Errlog
+text run at (0,497) width 117: webtest_fn_4:
+text run at (0,512) width 90: TypeError:
+text run at (0,527) width 63: null is
+text run at (0,542) width 54: not an
+text run at (0,557) width 54: object
+text run at (0,572) width 99: (evaluating
+text run at (0,587) width 369: 'document.querySelector(\plaintext:first-
+text run at (0,602) width 63: of-type
+text run at (0,617) width 9: ~
+text run at (0,632) width 63: *|:out-
+text run at (0,647) width 27: of-
+text run at (0,662) width 198: range\).insertBefore')
+ RenderBR {BR} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185127] trunk/Source/WebKit2
Title: [185127] trunk/Source/WebKit2 Revision 185127 Author barraclo...@apple.com Date 2015-06-02 15:02:35 -0700 (Tue, 02 Jun 2015) Log Message PDFs always think they're visible on iOS. https://bugs.webkit.org/show_bug.cgi?id=145493 rdar://problem/19668879 Reviewed by Andreas Kling Sam Weinig. The problem here is that WKContentView is currently responsible for notifying the WebPageProxy that the visibility may have changed, but when a PDF isn't showing the WKContentView isn't in the view hierarchy and doesn't receive the didMoveToWindow notifications – and the WKPDFView (which is in the view hierarchy) does not listen for these events. Visibility of the page should really just track the visibility of the WKWebView (and when actually assessing the visibility it largely does - the page client checks the web view's visibility, bar a FIXME, and the foreground/background check, which needs to change). So notifications should really just come from the WKWebView. The WKWebView already listens for the didMoveToWindow notification, it just was only updating the IsInWindow flag. Instead just update all flags, and the call to viewStateDidChange from WKContentView can just be removed. There is one problem with this in that it would reverse the order of the calls to viewStateDidChange _updateForScreen:, which would mean the the view would become visible before updating the screen pixel density. To fix this, moving the call to _updateForScreen: to willMoveToWindow:, to ensure it occurs before the page becomes visible. This will also change behavior on Mac for WKWebView clients, in coalescing all view state changes within the didMoveToWindow call. This is the direction we intended to go in anyway (the plan is to remove the mayHaveChanged argument from viewStateDidChange - we're currently adding unnecessary IPC traffic). * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView didMoveToWindow]): - should update all view state flags. * UIProcess/API/ios/WKViewIOS.mm: (-[WKView didMoveToWindow]): - added to match WKWebView.mm, for WebKitTestRunner. * UIProcess/ios/WKContentView.mm: (-[WKContentView willMoveToWindow:]): - should _updateForScreen: (-[WKContentView didMoveToWindow]): Deleted. - functionality moved to -[WKWebView didMoveToWindow], -[WKContentView didMoveToWindow]. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (185126 => 185127) --- trunk/Source/WebKit2/ChangeLog 2015-06-02 21:54:13 UTC (rev 185126) +++ trunk/Source/WebKit2/ChangeLog 2015-06-02 22:02:35 UTC (rev 185127) @@ -1,3 +1,47 @@ +2015-06-02 Gavin Barraclough barraclo...@apple.com + +PDFs always think they're visible on iOS. +https://bugs.webkit.org/show_bug.cgi?id=145493 +rdar://problem/19668879 + +Reviewed by Andreas Kling Sam Weinig. + +The problem here is that WKContentView is currently responsible for notifying the WebPageProxy +that the visibility may have changed, but when a PDF isn't showing the WKContentView isn't in +the view hierarchy and doesn't receive the didMoveToWindow notifications – and the WKPDFView +(which is in the view hierarchy) does not listen for these events. + +Visibility of the page should really just track the visibility of the WKWebView (and when +actually assessing the visibility it largely does - the page client checks the web view's +visibility, bar a FIXME, and the foreground/background check, which needs to change). +So notifications should really just come from the WKWebView. + +The WKWebView already listens for the didMoveToWindow notification, it just was only updating +the IsInWindow flag. Instead just update all flags, and the call to viewStateDidChange from +WKContentView can just be removed. + +There is one problem with this in that it would reverse the order of the calls to +viewStateDidChange _updateForScreen:, which would mean the the view would become visible before +updating the screen pixel density. To fix this, moving the call to _updateForScreen: +to willMoveToWindow:, to ensure it occurs before the page becomes visible. + +This will also change behavior on Mac for WKWebView clients, in coalescing all view state changes +within the didMoveToWindow call. This is the direction we intended to go in anyway (the plan is +to remove the mayHaveChanged argument from viewStateDidChange - we're currently adding unnecessary +IPC traffic). + +* UIProcess/API/Cocoa/WKWebView.mm: +(-[WKWebView didMoveToWindow]): +- should update all view state flags. +* UIProcess/API/ios/WKViewIOS.mm: +(-[WKView didMoveToWindow]): +- added to match WKWebView.mm,
[webkit-changes] [185124] trunk
Title: [185124] trunk Revision 185124 Author za...@apple.com Date 2015-06-02 14:35:24 -0700 (Tue, 02 Jun 2015) Log Message Backdrop filter is pulling in content from behind the window. https://bugs.webkit.org/show_bug.cgi?id=145561 rdar://problem/20909309 Reviewed by Simon Fraser. This patch ensures that the backdrop filter layer is positioned and sized properly. The backdrop filter layer should take its size and position from its renderer and not directly from the composited layer. In certain cases the composited layer's size is expanded to cover items like box shadow or an absolute positioned descendant. In such cases, we ended up applying the backdrop filter to those areas as well. Source/WebCore: Tests: css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute.html css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding.html * platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setBackdropFiltersRect): (WebCore::GraphicsLayer::backdropFiltersRect): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setBackdropFiltersRect): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateBackdropFilters): (WebCore::GraphicsLayerCA::updateBackdropFiltersRect): (WebCore::GraphicsLayerCA::updateContentsRects): (WebCore::GraphicsLayerCA::updateGeometry): Deleted. * platform/graphics/ca/GraphicsLayerCA.h: * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateBackdropFiltersGeometry): (WebCore::RenderLayerBacking::updateGeometry): * rendering/RenderLayerBacking.h: LayoutTests: * css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt: Added. * css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute.html: Added. * css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding-expected.txt: Added. * css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/GraphicsLayer.h trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebCore/rendering/RenderLayerBacking.h Added Paths trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute.html trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding-expected.txt trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding.html Diff Modified: trunk/LayoutTests/ChangeLog (185123 => 185124) --- trunk/LayoutTests/ChangeLog 2015-06-02 21:30:27 UTC (rev 185123) +++ trunk/LayoutTests/ChangeLog 2015-06-02 21:35:24 UTC (rev 185124) @@ -1,3 +1,23 @@ +2015-06-02 Zalan Bujtas za...@apple.com + +Backdrop filter is pulling in content from behind the window. +https://bugs.webkit.org/show_bug.cgi?id=145561 +rdar://problem/20909309 + +Reviewed by Simon Fraser. + +This patch ensures that the backdrop filter layer is positioned and sized properly. + +The backdrop filter layer should take its size and position from its renderer and not +directly from the composited layer. +In certain cases the composited layer's size is expanded to cover items like box shadow or an absolute positioned descendant. +In such cases, we ended up applying the backdrop filter to those areas as well. + +* css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt: Added. +* css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute.html: Added. +* css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding-expected.txt: Added. +* css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding.html: Added. + 2015-06-02 Said Abou-Hallawa sabouhall...@apple.com Fix Mac Mavericks layout test failure following http://trac.webkit.org/changeset/185096 Added: trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt (0 => 185124) --- trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt (rev 0) +++ trunk/LayoutTests/css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt 2015-06-02 21:35:24 UTC (rev 185124) @@ -0,0 +1,21 @@ +foofoobar +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 800.00 600.00) + (children 1 +(GraphicsLayer + (bounds 800.00 600.00) + (contentsOpaque 1) + (children 1 +(GraphicsLayer + (position 8.00 8.00) + (bounds 342.00 318.00) +
[webkit-changes] [185130] trunk/Source/WebCore
Title: [185130] trunk/Source/WebCore
Revision 185130
Author d...@apple.com
Date 2015-06-02 15:23:36 -0700 (Tue, 02 Jun 2015)
Log Message
No need to guard the sizes attribute against PICTURE_SIZES in preload scanner.
https://bugs.webkit.org/show_bug.cgi?id=145573
rdar://problem/21210038
Reviewed by Myles Maxfield.
The PICTURE_SIZES feature flag doesn't need to be used to
guard preloading of the sizes attribute.
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): Deleted.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (185129 => 185130)
--- trunk/Source/WebCore/ChangeLog 2015-06-02 22:14:23 UTC (rev 185129)
+++ trunk/Source/WebCore/ChangeLog 2015-06-02 22:23:36 UTC (rev 185130)
@@ -1,3 +1,18 @@
+2015-06-02 Dean Jackson d...@apple.com
+
+No need to guard the sizes attribute against PICTURE_SIZES in preload scanner.
+https://bugs.webkit.org/show_bug.cgi?id=145573
+rdar://problem/21210038
+
+Reviewed by Myles Maxfield.
+
+The PICTURE_SIZES feature flag doesn't need to be used to
+guard preloading of the sizes attribute.
+
+* html/parser/HTMLPreloadScanner.cpp:
+(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): Deleted.
+(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Deleted.
+
2015-06-02 Anders Carlsson ander...@apple.com
Use UUIDs for WebSQL database filenames instead of a sequential number
Modified: trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp (185129 => 185130)
--- trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2015-06-02 22:14:23 UTC (rev 185129)
+++ trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2015-06-02 22:23:36 UTC (rev 185130)
@@ -112,11 +112,7 @@
// Resolve between src and srcSet if we have them and the tag is img.
if (m_tagId == TagId::Img !m_srcSetAttribute.isEmpty()) {
float sourceSize = 0;
-#if ENABLE(PICTURE_SIZES)
sourceSize = parseSizesAttribute(m_sizesAttribute, document.renderView(), document.frame());
-#else
-UNUSED_PARAM(document);
-#endif
ImageCandidate imageCandidate = bestFitSourceForImageAttributes(m_deviceScaleFactor, m_urlToLoad, m_srcSetAttribute, sourceSize);
setUrlToLoad(imageCandidate.string.toString(), true);
}
@@ -155,10 +151,8 @@
setUrlToLoad(attributeValue);
else if (match(attributeName, srcsetAttr) m_srcSetAttribute.isNull())
m_srcSetAttribute = attributeValue;
-#if ENABLE(PICTURE_SIZES)
else if (match(attributeName, sizesAttr) m_sizesAttribute.isNull())
m_sizesAttribute = attributeValue;
-#endif
else if (match(attributeName, crossoriginAttr) !attributeValue.isNull())
m_crossOriginMode = stripLeadingAndTrailingHTMLSpaces(attributeValue);
} else if (m_tagId == TagId::Link) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185137] trunk/Source/WebCore
Title: [185137] trunk/Source/WebCore
Revision 185137
Author commit-qu...@webkit.org
Date 2015-06-02 18:29:43 -0700 (Tue, 02 Jun 2015)
Log Message
AX: debugging attributes for text markers
https://bugs.webkit.org/show_bug.cgi?id=145283
Patch by Doug Russell d_russ...@apple.com on 2015-06-02
Reviewed by Chris Fleizach.
AXTextMarkerDebugDescription: returns the result of
VisiblePosition::formatForDebugger() for the visible position that a text marker
represents.
AXTextMarkerNodeDebugDescription: calls Node::showNode() and
Node::showNodePathForThis() for the visible position that a text marker
represents.
AXTextMarkerNodeTreeDebugDescription: calls Node::showTreeForThis() for the
visible position that a text marker represents.
AXTextMarkerRangeDebugDescription: returns the result of
formatForDebugger(VisiblePositionRange) for the visible position range that a text
marker range represents.
This is debug only tooling. Tests would be flakey and not very helpful.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper debugDescriptionForTextMarker:]):
(-[WebAccessibilityObjectWrapper debugDescriptionForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapper showNodeForTextMarker:]):
(-[WebAccessibilityObjectWrapper showNodeTreeForTextMarker:]):
(formatForDebugger):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* dom/Text.cpp:
(WebCore::Text::formatForDebugger):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Source/WebCore/dom/Text.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (185136 => 185137)
--- trunk/Source/WebCore/ChangeLog 2015-06-03 00:45:00 UTC (rev 185136)
+++ trunk/Source/WebCore/ChangeLog 2015-06-03 01:29:43 UTC (rev 185137)
@@ -1,3 +1,34 @@
+2015-06-02 Doug Russell d_russ...@apple.com
+
+AX: debugging attributes for text markers
+https://bugs.webkit.org/show_bug.cgi?id=145283
+
+Reviewed by Chris Fleizach.
+
+AXTextMarkerDebugDescription: returns the result of
+VisiblePosition::formatForDebugger() for the visible position that a text marker
+represents.
+AXTextMarkerNodeDebugDescription: calls Node::showNode() and
+Node::showNodePathForThis() for the visible position that a text marker
+represents.
+AXTextMarkerNodeTreeDebugDescription: calls Node::showTreeForThis() for the
+visible position that a text marker represents.
+AXTextMarkerRangeDebugDescription: returns the result of
+formatForDebugger(VisiblePositionRange) for the visible position range that a text
+marker range represents.
+
+This is debug only tooling. Tests would be flakey and not very helpful.
+
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper debugDescriptionForTextMarker:]):
+(-[WebAccessibilityObjectWrapper debugDescriptionForTextMarkerRange:]):
+(-[WebAccessibilityObjectWrapper showNodeForTextMarker:]):
+(-[WebAccessibilityObjectWrapper showNodeTreeForTextMarker:]):
+(formatForDebugger):
+(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
+* dom/Text.cpp:
+(WebCore::Text::formatForDebugger):
+
2015-06-02 Matt Rajca mra...@apple.com
MediaSessions should keep track of their current state.
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (185136 => 185137)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-06-03 00:45:00 UTC (rev 185136)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-06-03 01:29:43 UTC (rev 185137)
@@ -3485,6 +3485,62 @@
return [attrString RTFFromRange: NSMakeRange(0, [attrString length]) documentAttributes:@{ }];
}
+#if ENABLE(TREE_DEBUGGING)
+- (NSString *)debugDescriptionForTextMarker:(id)textMarker
+{
+char description[1024];
+[self visiblePositionForTextMarker:textMarker].formatForDebugger(description, sizeof(description));
+return [NSString stringWithUTF8String:description];
+
+}
+
+- (NSString *)debugDescriptionForTextMarkerRange:(id)textMarkerRange
+{
+VisiblePositionRange visiblePositionRange = [self visiblePositionRangeForTextMarkerRange:textMarkerRange];
+if (visiblePositionRange.isNull())
+return @null;
+char description[2048];
+formatForDebugger(visiblePositionRange, description, sizeof(description));
+return [NSString stringWithUTF8String:description];
+
+}
+
+- (void)showNodeForTextMarker:(id)textMarker
+{
+VisiblePosition visiblePosition = [self visiblePositionForTextMarker:textMarker];
+Node* node = visiblePosition.deepEquivalent().deprecatedNode();
+if (!node)
+return;
+node-showNode();
+node-showNodePathForThis();
+}
+
+- (void)showNodeTreeForTextMarker:(id)textMarker
+{
+
[webkit-changes] [185139] trunk/Source/WebInspectorUI
Title: [185139] trunk/Source/WebInspectorUI
Revision 185139
Author nvasil...@apple.com
Date 2015-06-02 19:46:44 -0700 (Tue, 02 Jun 2015)
Log Message
Web Inspector: Use non-monospace font for the frame selector
https://bugs.webkit.org/show_bug.cgi?id=145586
Reviewed by Timothy Hatcher.
* UserInterface/Views/HierarchicalPathComponent.css:
(.hierarchical-path-component):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185138 => 185139)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-03 02:33:16 UTC (rev 185138)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-03 02:46:44 UTC (rev 185139)
@@ -1,5 +1,15 @@
2015-06-02 Nikita Vasilyev nvasil...@apple.com
+Web Inspector: Use non-monospace font for the frame selector
+https://bugs.webkit.org/show_bug.cgi?id=145586
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/HierarchicalPathComponent.css:
+(.hierarchical-path-component):
+
+2015-06-02 Nikita Vasilyev nvasil...@apple.com
+
Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
https://bugs.webkit.org/show_bug.cgi?id=145540
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css (185138 => 185139)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css 2015-06-03 02:33:16 UTC (rev 185138)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css 2015-06-03 02:46:44 UTC (rev 185139)
@@ -28,6 +28,9 @@
position: relative;
height: 20px;
min-width: 32px;
+
+font-family: -webkit-system-font, sans-serif;
+font-size: 11px;
}
.hierarchical-path-component.show-selector-arrows {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185138] trunk/Source/WebKit2
Title: [185138] trunk/Source/WebKit2
Revision 185138
Author commit-qu...@webkit.org
Date 2015-06-02 19:33:16 -0700 (Tue, 02 Jun 2015)
Log Message
[EFL] Implement load_started callback in EwkPageClient.
https://bugs.webkit.org/show_bug.cgi?id=145545
Patch by Hyungwook Lee hyungwook@navercorp.com on 2015-06-02
Reviewed by Gyuyoung Kim.
We need to provide load_started callback to web extension module.
* UIProcess/API/efl/tests/extensions/extension_sample.cpp:
* WebProcess/InjectedBundle/API/efl/ewk_page.cpp:
(EwkPage::EwkPage):
(EwkPage::remove):
(EwkPage::didStartProvisionalLoadForFrame):
(EwkPage::didFinishDocumentLoadForFrame):
* WebProcess/InjectedBundle/API/efl/ewk_page.h:
* WebProcess/InjectedBundle/API/efl/ewk_page_private.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/tests/extensions/extension_sample.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page_private.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (185137 => 185138)
--- trunk/Source/WebKit2/ChangeLog 2015-06-03 01:29:43 UTC (rev 185137)
+++ trunk/Source/WebKit2/ChangeLog 2015-06-03 02:33:16 UTC (rev 185138)
@@ -1,3 +1,21 @@
+2015-06-02 Hyungwook Lee hyungwook@navercorp.com
+
+[EFL] Implement load_started callback in EwkPageClient.
+https://bugs.webkit.org/show_bug.cgi?id=145545
+
+Reviewed by Gyuyoung Kim.
+
+We need to provide load_started callback to web extension module.
+
+* UIProcess/API/efl/tests/extensions/extension_sample.cpp:
+* WebProcess/InjectedBundle/API/efl/ewk_page.cpp:
+(EwkPage::EwkPage):
+(EwkPage::remove):
+(EwkPage::didStartProvisionalLoadForFrame):
+(EwkPage::didFinishDocumentLoadForFrame):
+* WebProcess/InjectedBundle/API/efl/ewk_page.h:
+* WebProcess/InjectedBundle/API/efl/ewk_page_private.h:
+
2015-06-02 Gavin Barraclough barraclo...@apple.com
PDFs always think they're visible on iOS.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/extensions/extension_sample.cpp (185137 => 185138)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/extensions/extension_sample.cpp 2015-06-03 01:29:43 UTC (rev 185137)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/extensions/extension_sample.cpp 2015-06-03 02:33:16 UTC (rev 185138)
@@ -30,6 +30,8 @@
extern C {
#endif
+static Eina_Bool pageLoadStarted = false;
+
static JSValueRef helloCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
{
Ewk_Extension* extension = static_castEwk_Extension*(JSObjectGetPrivate(thisObject));
@@ -42,8 +44,17 @@
return nullptr;
}
+void loadStarted(Ewk_Page* page, void* data)
+{
+pageLoadStarted = true;
+}
+
void loadFinished(Ewk_Page* page, void* data)
{
+if (!pageLoadStarted)
+return;
+pageLoadStarted = false;
+
JSGlobalContextRef jsContext = ewk_page_js_global_context_get(page);
JSObjectRef windowObject = JSContextGetGlobalObject(jsContext);
@@ -73,6 +84,7 @@
{
pageClient.version = 1;
pageClient.data = ""
+pageClient.load_started = loadStarted;
pageClient.load_finished = loadFinished;
ewk_page_client_register(page, pageClient);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.cpp (185137 => 185138)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.cpp 2015-06-03 01:29:43 UTC (rev 185137)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.cpp 2015-06-03 02:33:16 UTC (rev 185138)
@@ -48,7 +48,7 @@
7, // version
this, // clientInfo
},
-0, // didStartProvisionalLoadForFrame,
+didStartProvisionalLoadForFrame,
0, // didReceiveServerRedirectForProvisionalLoadForFrame,
0, // didFailProvisionalLoadWithErrorForFrame
0, // didCommitLoadForFrame
@@ -97,6 +97,18 @@
m_clients.remove(m_clients.find(client));
}
+void EwkPage::didStartProvisionalLoadForFrame(WKBundlePageRef, WKBundleFrameRef frame, WKTypeRef*, const void* clientInfo)
+{
+if (!WKBundleFrameIsMainFrame(frame))
+return;
+
+EwkPage* self = toEwkPage(clientInfo);
+for (auto it : self-m_clients) {
+if (it-load_started)
+it-load_started(self, it-data);
+}
+}
+
void EwkPage::didFinishDocumentLoadForFrame(WKBundlePageRef, WKBundleFrameRef frame, WKTypeRef*, const void* clientInfo)
{
if (!WKBundleFrameIsMainFrame(frame))
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h (185137 => 185138)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h 2015-06-03 01:29:43 UTC (rev 185137)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h 2015-06-03
[webkit-changes] [185141] trunk/Source/WebInspectorUI
Title: [185141] trunk/Source/WebInspectorUI
Revision 185141
Author commit-qu...@webkit.org
Date 2015-06-02 22:46:56 -0700 (Tue, 02 Jun 2015)
Log Message
Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
https://bugs.webkit.org/show_bug.cgi?id=145591
Patch by Joseph Pecoraro pecor...@apple.com on 2015-06-02
Reviewed by Timothy Hatcher.
* UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.removeSidebarPanel):
When removing a sidebar panel, ensure we call hidden if it was the visible panel.
* UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel):
(WebInspector.SidebarPanel.prototype.shown):
(WebInspector.SidebarPanel.prototype.hidden):
Save and restore content element scroll position when sidebar panels are shown / hidden.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.visibilityDidChange):
* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WebInspector.ComputedStyleDetailsPanel.prototype.shown):
* UserInterface/Views/DetailsSidebarPanel.js:
(WebInspector.DetailsSidebarPanel.prototype.shown):
* UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.shown):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.hidden):
Cleanup. Since sidebar panels are using ES6 classes, have super class calls use `super`!
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js
trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185140 => 185141)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-03 03:39:27 UTC (rev 185140)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-03 05:46:56 UTC (rev 185141)
@@ -1,3 +1,31 @@
+2015-06-02 Joseph Pecoraro pecor...@apple.com
+
+Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
+https://bugs.webkit.org/show_bug.cgi?id=145591
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/Sidebar.js:
+(WebInspector.Sidebar.prototype.removeSidebarPanel):
+When removing a sidebar panel, ensure we call hidden if it was the visible panel.
+
+* UserInterface/Views/SidebarPanel.js:
+(WebInspector.SidebarPanel):
+(WebInspector.SidebarPanel.prototype.shown):
+(WebInspector.SidebarPanel.prototype.hidden):
+Save and restore content element scroll position when sidebar panels are shown / hidden.
+
+* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+(WebInspector.CSSStyleDetailsSidebarPanel.prototype.visibilityDidChange):
+* UserInterface/Views/ComputedStyleDetailsPanel.js:
+(WebInspector.ComputedStyleDetailsPanel.prototype.shown):
+* UserInterface/Views/DetailsSidebarPanel.js:
+(WebInspector.DetailsSidebarPanel.prototype.shown):
+* UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
+(WebInspector.LayerTreeDetailsSidebarPanel.prototype.shown):
+(WebInspector.LayerTreeDetailsSidebarPanel.prototype.hidden):
+Cleanup. Since sidebar panels are using ES6 classes, have super class calls use `super`!
+
2015-06-02 Nikita Vasilyev nvasil...@apple.com
Web Inspector: Use non-monospace font for the frame selector
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js (185140 => 185141)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2015-06-03 03:39:27 UTC (rev 185140)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2015-06-03 05:46:56 UTC (rev 185141)
@@ -111,7 +111,7 @@
visibilityDidChange()
{
-WebInspector.SidebarPanel.prototype.visibilityDidChange.call(this);
+super.visibilityDidChange();
if (!this._selectedPanel)
return;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js (185140 => 185141)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2015-06-03 03:39:27 UTC (rev 185140)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2015-06-03 05:46:56 UTC (rev 185141)
@@ -159,7 +159,7 @@
shown()
{
-WebInspector.StyleDetailsPanel.prototype.shown.call(this);
+super.shown();
this._propertiesTextEditor.updateLayout();
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSidebarPanel.js (185140 => 185141)
---
[webkit-changes] [185142] trunk/Source/WebInspectorUI
Title: [185142] trunk/Source/WebInspectorUI
Revision 185142
Author commit-qu...@webkit.org
Date 2015-06-02 22:57:33 -0700 (Tue, 02 Jun 2015)
Log Message
Web Inspector: Remove uses of delete in Sidebar related code
https://bugs.webkit.org/show_bug.cgi?id=145592
Patch by Joseph Pecoraro pecor...@apple.com on 2015-06-02
Reviewed by Timothy Hatcher.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
Clear value instead of deleting.
* UserInterface/Views/SearchSidebarPanel.js:
(WebInspector.SearchSidebarPanel.prototype.performSearch):
Just clear the search identifier. Also assert it (a required string) is always non-falsey.
* UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.resizerDragEnded): Deleted.
This entire callback is unnecessary because whenever we start
a drag we save the value.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185141 => 185142)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-03 05:46:56 UTC (rev 185141)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-03 05:57:33 UTC (rev 185142)
@@ -1,5 +1,25 @@
2015-06-02 Joseph Pecoraro pecor...@apple.com
+Web Inspector: Remove uses of delete in Sidebar related code
+https://bugs.webkit.org/show_bug.cgi?id=145592
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+(WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
+Clear value instead of deleting.
+
+* UserInterface/Views/SearchSidebarPanel.js:
+(WebInspector.SearchSidebarPanel.prototype.performSearch):
+Just clear the search identifier. Also assert it (a required string) is always non-falsey.
+
+* UserInterface/Views/Sidebar.js:
+(WebInspector.Sidebar.prototype.resizerDragEnded): Deleted.
+This entire callback is unnecessary because whenever we start
+a drag we save the value.
+
+2015-06-02 Joseph Pecoraro pecor...@apple.com
+
Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
https://bugs.webkit.org/show_bug.cgi?id=145591
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js (185141 => 185142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2015-06-03 05:46:56 UTC (rev 185141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2015-06-03 05:57:33 UTC (rev 185142)
@@ -101,9 +101,9 @@
this.contentElement.scrollTop = this._initialScrollOffset;
-for (var i = 0; i this._panels.length; ++i) {
-delete this._panels[i].element._savedScrollTop;
-this._panels[i].markAsNeedsRefresh(domNode);
+for (var panel of this._panels) {
+panel.element._savedScrollTop = undefined;
+panel.markAsNeedsRefresh(domNode);
}
this._updatePseudoClassCheckboxes();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js (185141 => 185142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2015-06-03 05:46:56 UTC (rev 185141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2015-06-03 05:57:33 UTC (rev 185142)
@@ -211,6 +211,8 @@
if (error || !resultsCount)
return;
+console.assert(searchId);
+
this._domSearchIdentifier = searchId;
function domSearchResults(error, nodeIds)
@@ -277,9 +279,9 @@
setTimeout(searchScripts.bind(this, WebInspector.debuggerManager.knownNonResourceScripts), 0);
if (window.DOMAgent) {
-if (_domSearchIdentifier in this) {
+if (this._domSearchIdentifier) {
DOMAgent.discardSearchResults(this._domSearchIdentifier);
-delete this._domSearchIdentifier;
+this._domSearchIdentifier = undefined;
}
DOMAgent.performSearch(searchQuery, domCallback.bind(this));
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js (185141 => 185142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2015-06-03 05:46:56 UTC (rev 185141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2015-06-03 05:57:33 UTC (rev 185142)
@@ -281,11 +281,6 @@
this.collapsed = (newWidth (this.minimumWidth / 2));
}
-resizerDragEnded(resizer)
-{
-delete this._widthBeforeResize;
-}
-
// Private
_navigationItemSelected(event)
___
webkit-changes mailing list
[webkit-changes] [185108] trunk/Tools
Title: [185108] trunk/Tools Revision 185108 Author dba...@webkit.org Date 2015-06-02 10:26:20 -0700 (Tue, 02 Jun 2015) Log Message Update ATS keys used in MiniBrowser and WebKitTestRunnerApp Rubber-stamped by Alexey Proskuryakov. * MiniBrowser/mac/Info.plist: * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Modified Paths trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/mac/Info.plist trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist Diff Modified: trunk/Tools/ChangeLog (185107 => 185108) --- trunk/Tools/ChangeLog 2015-06-02 09:12:41 UTC (rev 185107) +++ trunk/Tools/ChangeLog 2015-06-02 17:26:20 UTC (rev 185108) @@ -1,3 +1,12 @@ +2015-06-02 Daniel Bates daba...@apple.com + +Update ATS keys used in MiniBrowser and WebKitTestRunnerApp + +Rubber-stamped by Alexey Proskuryakov. + +* MiniBrowser/mac/Info.plist: +* WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: + 2015-06-01 Commit Queue commit-qu...@webkit.org Unreviewed, rolling out r185066. Modified: trunk/Tools/MiniBrowser/mac/Info.plist (185107 => 185108) --- trunk/Tools/MiniBrowser/mac/Info.plist 2015-06-02 09:12:41 UTC (rev 185107) +++ trunk/Tools/MiniBrowser/mac/Info.plist 2015-06-02 17:26:20 UTC (rev 185108) @@ -28,9 +28,9 @@ stringMainMenu/string keyNSPrincipalClass/key stringNSApplication/string - keyCFAppTransportSecurity/key + keyNSAppTransportSecurity/key dict - keyAllowArbitraryInsecureHTTPLoads/key + keyNSAllowsArbitraryLoads/key true/ /dict /dict Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist (185107 => 185108) --- trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist 2015-06-02 09:12:41 UTC (rev 185107) +++ trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist 2015-06-02 17:26:20 UTC (rev 185108) @@ -34,9 +34,9 @@ stringUIInterfaceOrientationLandscapeLeft/string stringUIInterfaceOrientationLandscapeRight/string /array - keyCFAppTransportSecurity/key + keyNSAppTransportSecurity/key dict - keyAllowArbitraryInsecureHTTPLoads/key + keyNSAllowsArbitraryLoads/key true/ /dict keyUISupportedInterfaceOrientations~ipad/key ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [185110] trunk/Tools
Title: [185110] trunk/Tools
Revision 185110
Author mark@apple.com
Date 2015-06-02 10:48:23 -0700 (Tue, 02 Jun 2015)
Log Message
build-jsc's --cloop option is broken.
https://bugs.webkit.org/show_bug.cgi?id=145516
Reviewed by Darin Adler.
* Scripts/build-jsc:
- Make sure to disable the JIT when --cloop is specified.
Did analogous fix for --ftljit.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-jsc
Diff
Modified: trunk/Tools/ChangeLog (185109 => 185110)
--- trunk/Tools/ChangeLog 2015-06-02 17:36:16 UTC (rev 185109)
+++ trunk/Tools/ChangeLog 2015-06-02 17:48:23 UTC (rev 185110)
@@ -1,3 +1,14 @@
+2015-06-02 Mark Lam mark@apple.com
+
+build-jsc's --cloop option is broken.
+https://bugs.webkit.org/show_bug.cgi?id=145516
+
+Reviewed by Darin Adler.
+
+* Scripts/build-jsc:
+- Make sure to disable the JIT when --cloop is specified.
+ Did analogous fix for --ftljit.
+
2015-06-02 Daniel Bates daba...@apple.com
Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
Modified: trunk/Tools/Scripts/build-jsc (185109 => 185110)
--- trunk/Tools/Scripts/build-jsc 2015-06-02 17:36:16 UTC (rev 185109)
+++ trunk/Tools/Scripts/build-jsc 2015-06-02 17:48:23 UTC (rev 185110)
@@ -95,8 +95,8 @@
}
if (cmakeBasedPortName()) {
-$cmakeArgs .= $forceCLoop ? -DENABLE_JIT=OFF : -DENABLE_JIT=ON;
-$cmakeArgs .= $ftlJIT ? -DENABLE_FTL_JIT=ON : -DENABLE_FTL_JIT=OFF;
+$cmakeArgs .= $forceCLoop ? -DENABLE_JIT=0 : -DENABLE_JIT;
+$cmakeArgs .= $ftlJIT ? -DENABLE_FTL_JIT : -DENABLE_FTL_JIT=0;
# By default we build using all of the available CPUs
$makeArgs .= ($makeArgs ? : ) . -j . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/;
@@ -107,8 +107,8 @@
}
if (isAppleMacWebKit()) {
-push @options, ($forceCLoop ? ENABLE_JIT= : ENABLE_JIT=ENABLE_JIT);
-push @options, ($ftlJIT ? ENABLE_FTL_JIT=ENABLE_FTL_JIT : ENABLE_FTL_JIT=);
+push @options, ($forceCLoop ? ENABLE_JIT=ENABLE_JIT=0 : ENABLE_JIT=ENABLE_JIT);
+push @options, ($ftlJIT ? ENABLE_FTL_JIT=ENABLE_FTL_JIT : ENABLE_FTL_JIT=ENABLE_FTL_JIT=0);
if ($copyLibraries) {
my @copyLibrariesArgs = (perl, Tools/Scripts/copy-webkitlibraries-to-product-directory);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
