[webkit-changes] [187485] trunk/Source
Title: [187485] trunk/Source
Revision 187485
Author carlo...@webkit.org
Date 2015-07-28 03:03:13 -0700 (Tue, 28 Jul 2015)
Log Message
[GTK] Use fastMalloc instead of g_slice
https://bugs.webkit.org/show_bug.cgi?id=147357
Reviewed by Sergio Villar Senin.
The use of g_slice is no longer encouraged by glib developers.
Source/WebCore:
* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::mapGstBuffer):
(WebCore::unmapGstBuffer):
Source/WebKit2:
* UIProcess/API/gtk/WebKitCredential.cpp:
(webkitCredentialCreate):
(webkit_credential_free):
* UIProcess/API/gtk/WebKitJavascriptResult.cpp:
(webkitJavascriptResultCreate):
(webkit_javascript_result_unref):
* UIProcess/API/gtk/WebKitMimeInfo.cpp:
(webkitMimeInfoCreate):
(webkit_mime_info_unref):
* UIProcess/API/gtk/WebKitNavigationAction.cpp:
(webkitNavigationActionCreate):
(webkit_navigation_action_copy):
(webkit_navigation_action_free):
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitScriptDialog.cpp:
(webkitScriptDialogCopy):
(webkitScriptDialogFree):
* UIProcess/API/gtk/WebKitUserContent.cpp:
(webkit_user_style_sheet_unref):
(webkit_user_style_sheet_new):
(webkit_user_script_unref):
(webkit_user_script_new):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCredential.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitJavascriptResult.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitMimeInfo.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitNavigationAction.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitScriptDialog.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187484 => 187485)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 08:32:19 UTC (rev 187484)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 10:03:13 UTC (rev 187485)
@@ -1,3 +1,16 @@
+2015-07-28 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Use fastMalloc instead of g_slice
+https://bugs.webkit.org/show_bug.cgi?id=147357
+
+Reviewed by Sergio Villar Senin.
+
+The use of g_slice is no longer encouraged by glib developers.
+
+* platform/graphics/gstreamer/GStreamerUtilities.cpp:
+(WebCore::mapGstBuffer):
+(WebCore::unmapGstBuffer):
+
2015-07-27 Jon Davis j...@apple.com
Adding Web Components to feature status page.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp (187484 => 187485)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp 2015-07-28 08:32:19 UTC (rev 187484)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp 2015-07-28 10:03:13 UTC (rev 187485)
@@ -105,9 +105,9 @@
void mapGstBuffer(GstBuffer* buffer)
{
-GstMapInfo* mapInfo = g_slice_new(GstMapInfo);
+GstMapInfo* mapInfo = static_castGstMapInfo*(fastMalloc(sizeof(GstMapInfo)));
if (!gst_buffer_map(buffer, mapInfo, GST_MAP_WRITE)) {
-g_slice_free(GstMapInfo, mapInfo);
+fastFree(mapInfo);
gst_buffer_unref(buffer);
return;
}
@@ -125,7 +125,7 @@
return;
gst_buffer_unmap(buffer, mapInfo);
-g_slice_free(GstMapInfo, mapInfo);
+fastFree(mapInfo);
}
bool initializeGStreamer()
Modified: trunk/Source/WebKit2/ChangeLog (187484 => 187485)
--- trunk/Source/WebKit2/ChangeLog 2015-07-28 08:32:19 UTC (rev 187484)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-28 10:03:13 UTC (rev 187485)
@@ -1,3 +1,35 @@
+2015-07-28 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Use fastMalloc instead of g_slice
+https://bugs.webkit.org/show_bug.cgi?id=147357
+
+Reviewed by Sergio Villar Senin.
+
+The use of g_slice is no longer encouraged by glib developers.
+
+* UIProcess/API/gtk/WebKitCredential.cpp:
+(webkitCredentialCreate):
+(webkit_credential_free):
+* UIProcess/API/gtk/WebKitJavascriptResult.cpp:
+(webkitJavascriptResultCreate):
+(webkit_javascript_result_unref):
+* UIProcess/API/gtk/WebKitMimeInfo.cpp:
+(webkitMimeInfoCreate):
+(webkit_mime_info_unref):
+* UIProcess/API/gtk/WebKitNavigationAction.cpp:
+(webkitNavigationActionCreate):
+(webkit_navigation_action_copy):
+(webkit_navigation_action_free):
+* UIProcess/API/gtk/WebKitPrivate.h:
+* UIProcess/API/gtk/WebKitScriptDialog.cpp:
+(webkitScriptDialogCopy):
+(webkitScriptDialogFree):
+* UIProcess/API/gtk/WebKitUserContent.cpp:
+(webkit_user_style_sheet_unref):
+(webkit_user_style_sheet_new):
+(webkit_user_script_unref):
+(webkit_user_script_new):
+
2015-07-27 Dan Bernstein m...@apple.com
[iOS] REGRESSION (r187376): Form editing buttons are missing from the
[webkit-changes] [187484] trunk/Source/WTF
Title: [187484] trunk/Source/WTF
Revision 187484
Author commit-qu...@webkit.org
Date 2015-07-28 01:32:19 -0700 (Tue, 28 Jul 2015)
Log Message
Speed up StringBuilder::appendQuotedJSONString()
https://bugs.webkit.org/show_bug.cgi?id=147352
Patch by Benjamin Poulain bpoul...@apple.com on 2015-07-28
Reviewed by Andreas Kling.
* wtf/text/StringBuilder.cpp:
(WTF::appendQuotedJSONStringInternal):
The cases '' and '\\' are not that uncommon, and they can easily
be handled in the original branch testing for them.
This is about 2.5% better on the JSON.stringify test.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringBuilder.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (187483 => 187484)
--- trunk/Source/WTF/ChangeLog 2015-07-28 06:01:34 UTC (rev 187483)
+++ trunk/Source/WTF/ChangeLog 2015-07-28 08:32:19 UTC (rev 187484)
@@ -1,3 +1,17 @@
+2015-07-28 Benjamin Poulain bpoul...@apple.com
+
+Speed up StringBuilder::appendQuotedJSONString()
+https://bugs.webkit.org/show_bug.cgi?id=147352
+
+Reviewed by Andreas Kling.
+
+* wtf/text/StringBuilder.cpp:
+(WTF::appendQuotedJSONStringInternal):
+The cases '' and '\\' are not that uncommon, and they can easily
+be handled in the original branch testing for them.
+
+This is about 2.5% better on the JSON.stringify test.
+
2015-07-27 Alex Christensen achristen...@webkit.org
Progress towards building AppleWin with CMake
Modified: trunk/Source/WTF/wtf/text/StringBuilder.cpp (187483 => 187484)
--- trunk/Source/WTF/wtf/text/StringBuilder.cpp 2015-07-28 06:01:34 UTC (rev 187483)
+++ trunk/Source/WTF/wtf/text/StringBuilder.cpp 2015-07-28 08:32:19 UTC (rev 187484)
@@ -365,7 +365,9 @@
static void appendQuotedJSONStringInternal(OutputCharacterType* output, const InputCharacterType* input, unsigned length)
{
for (const InputCharacterType* end = input + length; input != end; ++input) {
-if (*input 0x1F *input != '' *input != '\\') {
+if (LIKELY(*input 0x1F)) {
+if (*input == '' || *input == '\\')
+*output++ = '\\';
*output++ = *input;
continue;
}
@@ -390,14 +392,6 @@
*output++ = '\\';
*output++ = 'b';
break;
-case '':
-*output++ = '\\';
-*output++ = '';
-break;
-case '\\':
-*output++ = '\\';
-*output++ = '\\';
-break;
default:
ASSERT((*input 0xFF00) == 0);
static const char hexDigits[] = 0123456789abcdef;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187530] trunk/Source/WebKit2
Title: [187530] trunk/Source/WebKit2
Revision 187530
Author cfleiz...@apple.com
Date 2015-07-28 17:44:14 -0700 (Tue, 28 Jul 2015)
Log Message
AX: iOS: VoiceOver hangs indefinitely when an JS alert appears
https://bugs.webkit.org/show_bug.cgi?id=147386
Reviewed by Anders Carlsson.
Support the iOS platform API to notify accessibility clients when the WebProcess is about to suspend (because of some modal dialog).
Luckily, we did all the hardwork for OSX a few years ago to support this paradigm.
* Platform/IPC/mac/ConnectionMac.mm:
(IPC::AccessibilityProcessSuspendedNotification):
(IPC::Connection::willSendSyncMessage):
(IPC::Connection::didReceiveSyncReply):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (187529 => 187530)
--- trunk/Source/WebKit2/ChangeLog 2015-07-29 00:38:29 UTC (rev 187529)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-29 00:44:14 UTC (rev 187530)
@@ -1,3 +1,18 @@
+2015-07-28 Chris Fleizach cfleiz...@apple.com
+
+AX: iOS: VoiceOver hangs indefinitely when an JS alert appears
+https://bugs.webkit.org/show_bug.cgi?id=147386
+
+Reviewed by Anders Carlsson.
+
+Support the iOS platform API to notify accessibility clients when the WebProcess is about to suspend (because of some modal dialog).
+Luckily, we did all the hardwork for OSX a few years ago to support this paradigm.
+
+* Platform/IPC/mac/ConnectionMac.mm:
+(IPC::AccessibilityProcessSuspendedNotification):
+(IPC::Connection::willSendSyncMessage):
+(IPC::Connection::didReceiveSyncReply):
+
2015-07-28 Yusuke Suzuki utatane@gmail.com
[ES6] Add ENABLE_ES6_MODULES compile time flag with the default value false
Modified: trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm (187529 => 187530)
--- trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm 2015-07-29 00:38:29 UTC (rev 187529)
+++ trunk/Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm 2015-07-29 00:44:14 UTC (rev 187530)
@@ -39,8 +39,16 @@
#if PLATFORM(IOS)
#include ProcessAssertion.h
+#include UIKit/UIAccessibility.h
+
+#if __has_include(AXRuntime/AXNotificationConstants.h)
+#include AXRuntime/AXNotificationConstants.h
+#else
+#define kAXPidStatusChangedNotification 0
#endif
+#endif
+
#if __has_include(HIServices/AccessibilityPriv.h)
#include HIServices/AccessibilityPriv.h
#else
@@ -600,20 +608,27 @@
return false;
}
+static void AccessibilityProcessSuspendedNotification(bool suspended)
+{
+#if PLATFORM(MAC) __MAC_OS_X_VERSION_MIN_REQUIRED = 101000
+_AXUIElementNotifyProcessSuspendStatus(suspended ? AXSuspendStatusSuspended : AXSuspendStatusRunning);
+#elif PLATFORM(IOS) __IPHONE_OS_VERSION_MIN_REQUIRED = 9
+UIAccessibilityPostNotification(kAXPidStatusChangedNotification, @{ @pid : @(getpid()), @suspended : @(suspended) });
+#else
+UNUSED_PARAM(suspended);
+#endif
+}
+
void Connection::willSendSyncMessage(unsigned flags)
{
-#if !TARGET_OS_IPHONE __MAC_OS_X_VERSION_MIN_REQUIRED = 101000
if ((flags InformPlatformProcessWillSuspend) WebCore::AXObjectCache::accessibilityEnabled())
-_AXUIElementNotifyProcessSuspendStatus(AXSuspendStatusSuspended);
-#endif
+AccessibilityProcessSuspendedNotification(true);
}
void Connection::didReceiveSyncReply(unsigned flags)
{
-#if !TARGET_OS_IPHONE __MAC_OS_X_VERSION_MIN_REQUIRED = 101000
if ((flags InformPlatformProcessWillSuspend) WebCore::AXObjectCache::accessibilityEnabled())
-_AXUIElementNotifyProcessSuspendStatus(AXSuspendStatusRunning);
-#endif
+AccessibilityProcessSuspendedNotification(false);
}
pid_t Connection::remoteProcessID() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187535] trunk
Title: [187535] trunk
Revision 187535
Author simon.fra...@apple.com
Date 2015-07-28 18:57:30 -0700 (Tue, 28 Jul 2015)
Log Message
Animations sometimes fail to start
https://bugs.webkit.org/show_bug.cgi?id=147394
rdar://problem/21852603
Reviewed by Dean Jackson.
Source/WebCore:
When an accelerated animation or transition was started at the same time as
a non-accelerated one, and then the node for the former was removed, we could
never kick off the non-accelerated animation.
AnimationControllerPrivate has logic to synchronize the two types of animation
when they start in the same animation update, which involves setting the
m_waitingForAsyncStartNotification flag, and waiting for a notifyAnimationStarted()
to come in from the graphics system.
However, it failed to handle the case where the accelerated animation was removed
before the callback was received, which left the m_waitingForAsyncStartNotification flag
set to true, preventing the non-accelerated animation from running.
Test: animations/remove-syncing-animation.html
* page/animation/AnimationBase.h:
(WebCore::AnimationBase::isAccelerated): Make this public.
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::clear): Add logging.
(WebCore::AnimationControllerPrivate::receivedStartTimeResponse): Add logging.
(WebCore::AnimationControllerPrivate::animationWillBeRemoved): Add logging.
After removing animations from the maps, check to see if we expect any of the
remaining animations are waiting for a notifyAnimationStarted(). If not, clear
the m_waitingForAsyncStartNotification flag.
(WebCore::AnimationController::notifyAnimationStarted): Log the renderer.
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate): Remove unneeded
initializations of HashMaps.
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions): Log renderers.
(WebCore::CompositeAnimation::updateKeyframeAnimations): Ditto.
LayoutTests:
Test that starts an accelerated and non-accelerated animation, then removes
the node for the accelerated one.
* animations/remove-syncing-animation-expected.txt: Added.
* animations/remove-syncing-animation.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/AnimationBase.h
trunk/Source/WebCore/page/animation/AnimationController.cpp
trunk/Source/WebCore/page/animation/CompositeAnimation.cpp
Added Paths
trunk/LayoutTests/animations/remove-syncing-animation-expected.txt
trunk/LayoutTests/animations/remove-syncing-animation.html
Diff
Modified: trunk/LayoutTests/ChangeLog (187534 => 187535)
--- trunk/LayoutTests/ChangeLog 2015-07-29 01:43:58 UTC (rev 187534)
+++ trunk/LayoutTests/ChangeLog 2015-07-29 01:57:30 UTC (rev 187535)
@@ -1,3 +1,17 @@
+2015-07-28 Simon Fraser simon.fra...@apple.com
+
+Animations sometimes fail to start
+https://bugs.webkit.org/show_bug.cgi?id=147394
+rdar://problem/21852603
+
+Reviewed by Dean Jackson.
+
+Test that starts an accelerated and non-accelerated animation, then removes
+the node for the accelerated one.
+
+* animations/remove-syncing-animation-expected.txt: Added.
+* animations/remove-syncing-animation.html: Added.
+
2015-07-28 Michael Catanzaro mcatanz...@igalia.com
[Freetype] Always allow font matching for strong aliases
Added: trunk/LayoutTests/animations/remove-syncing-animation-expected.txt (0 => 187535)
--- trunk/LayoutTests/animations/remove-syncing-animation-expected.txt (rev 0)
+++ trunk/LayoutTests/animations/remove-syncing-animation-expected.txt 2015-07-29 01:57:30 UTC (rev 187535)
@@ -0,0 +1,5 @@
+The remaining square should show a color animation from orange to green.
+
+Color keyframes.
+PASS - colors animation ran.
+
Added: trunk/LayoutTests/animations/remove-syncing-animation.html (0 => 187535)
--- trunk/LayoutTests/animations/remove-syncing-animation.html (rev 0)
+++ trunk/LayoutTests/animations/remove-syncing-animation.html 2015-07-29 01:57:30 UTC (rev 187535)
@@ -0,0 +1,93 @@
+!DOCTYPE html
+
+html
+head
+style
+#container {
+
+}
+
+.box {
+height: 100px;
+width: 100px;
+margin: 10px;
+background-color: blue;
+}
+
+#container.changed #first {
+-webkit-animation: fade 0.1s linear;
+}
+
+#container.changed #second {
+-webkit-animation: colors 0.1s linear;
+}
+
+@-webkit-keyframes fade {
+from { opacity: 0; }
+to { opacity: 1; }
+}
+
+@-webkit-keyframes colors {
+from { background-color: orange; }
+to { background-color: green; }
+}
+/style
+script
+if (window.testRunner) {
+testRunner.waitUntilDone();
+
[webkit-changes] [187537] trunk
Title: [187537] trunk
Revision 187537
Author benja...@webkit.org
Date 2015-07-28 19:15:41 -0700 (Tue, 28 Jul 2015)
Log Message
Speed up the Stringifier::toJSON() fast case
https://bugs.webkit.org/show_bug.cgi?id=147383
Patch by Benjamin Poulain bpoul...@apple.com on 2015-07-28
Reviewed by Andreas Kling.
Source/_javascript_Core:
* runtime/JSONObject.cpp:
(JSC::Stringifier::toJSON):
(JSC::Stringifier::toJSONImpl):
LayoutTests:
Make the fast case of Stringifier::toJSON() inline and the uncommon
case out-of-line.
* js/dom/JSON-stringify-string-object-with-tojson-expected.txt: Added.
* js/dom/JSON-stringify-string-object-with-tojson.html: Added.
* js/resources/JSON-stringify-string-object-with-tojson.js: Added.
(stringObject.toJSON):
(String.prototype.toJSON):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSONObject.cpp
Added Paths
trunk/LayoutTests/js/dom/JSON-stringify-string-object-with-tojson-expected.txt
trunk/LayoutTests/js/dom/JSON-stringify-string-object-with-tojson.html
trunk/LayoutTests/js/resources/JSON-stringify-string-object-with-tojson.js
Diff
Modified: trunk/LayoutTests/ChangeLog (187536 => 187537)
--- trunk/LayoutTests/ChangeLog 2015-07-29 02:08:36 UTC (rev 187536)
+++ trunk/LayoutTests/ChangeLog 2015-07-29 02:15:41 UTC (rev 187537)
@@ -1,3 +1,19 @@
+2015-07-28 Benjamin Poulain bpoul...@apple.com
+
+Speed up the Stringifier::toJSON() fast case
+https://bugs.webkit.org/show_bug.cgi?id=147383
+
+Reviewed by Andreas Kling.
+
+Make the fast case of Stringifier::toJSON() inline and the uncommon
+case out-of-line.
+
+* js/dom/JSON-stringify-string-object-with-tojson-expected.txt: Added.
+* js/dom/JSON-stringify-string-object-with-tojson.html: Added.
+* js/resources/JSON-stringify-string-object-with-tojson.js: Added.
+(stringObject.toJSON):
+(String.prototype.toJSON):
+
2015-07-28 Simon Fraser simon.fra...@apple.com
Animations sometimes fail to start
Added: trunk/LayoutTests/js/dom/JSON-stringify-string-object-with-tojson-expected.txt (0 => 187537)
--- trunk/LayoutTests/js/dom/JSON-stringify-string-object-with-tojson-expected.txt (rev 0)
+++ trunk/LayoutTests/js/dom/JSON-stringify-string-object-with-tojson-expected.txt 2015-07-29 02:15:41 UTC (rev 187537)
@@ -0,0 +1,12 @@
+PASS nativeJSON.stringify(stringObject) is \Foo\
+PASS nativeJSON.stringify(stringObject) is JSON.stringify(stringObject)
+PASS nativeJSON.stringify(stringObject) is \Weird Case 1\
+PASS nativeJSON.stringify(stringObject) is JSON.stringify(stringObject)
+PASS nativeJSON.stringify(stringObject) is \Bar\
+PASS nativeJSON.stringify(stringObject) is JSON.stringify(stringObject)
+PASS nativeJSON.stringify(stringObject) is \Weird Case 2\
+PASS nativeJSON.stringify(stringObject) is JSON.stringify(stringObject)
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/js/dom/JSON-stringify-string-object-with-tojson.html (0 => 187537)
--- trunk/LayoutTests/js/dom/JSON-stringify-string-object-with-tojson.html (rev 0)
+++ trunk/LayoutTests/js/dom/JSON-stringify-string-object-with-tojson.html 2015-07-29 02:15:41 UTC (rev 187537)
@@ -0,0 +1,15 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+script
+var nativeJSON = this.JSON;
+this.JSON = null;
+/script
+script src=""
+script src=""
+script src=""
+/body
+/html
\ No newline at end of file
Added: trunk/LayoutTests/js/resources/JSON-stringify-string-object-with-tojson.js (0 => 187537)
--- trunk/LayoutTests/js/resources/JSON-stringify-string-object-with-tojson.js (rev 0)
+++ trunk/LayoutTests/js/resources/JSON-stringify-string-object-with-tojson.js 2015-07-29 02:15:41 UTC (rev 187537)
@@ -0,0 +1,15 @@
+var stringObject = new String(Foo);
+shouldBeEqualToString('nativeJSON.stringify(stringObject)', 'Foo');
+shouldBe('nativeJSON.stringify(stringObject)', 'JSON.stringify(stringObject)');
+
+stringObject.toJSON = function() { return Weird Case 1; }
+shouldBeEqualToString('nativeJSON.stringify(stringObject)', 'Weird Case 1');
+shouldBe('nativeJSON.stringify(stringObject)', 'JSON.stringify(stringObject)');
+
+var stringObject = new String(Bar);
+shouldBeEqualToString('nativeJSON.stringify(stringObject)', 'Bar');
+shouldBe('nativeJSON.stringify(stringObject)', 'JSON.stringify(stringObject)');
+
+String.prototype.toJSON = function() { return Weird Case 2; }
+shouldBeEqualToString('nativeJSON.stringify(stringObject)', 'Weird Case 2');
+shouldBe('nativeJSON.stringify(stringObject)', 'JSON.stringify(stringObject)');
\ No newline at end of file
Modified: trunk/Source/_javascript_Core/ChangeLog (187536 => 187537)
--- trunk/Source/_javascript_Core/ChangeLog 2015-07-29 02:08:36 UTC (rev 187536)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-07-29 02:15:41 UTC (rev 187537)
@@
[webkit-changes] [187522] trunk/Source
Title: [187522] trunk/Source Revision 187522 Author commit-qu...@webkit.org Date 2015-07-28 15:29:54 -0700 (Tue, 28 Jul 2015) Log Message [iOS] REGRESSION(r168075): Fullscreen web video doesn't pause on screen lock https://bugs.webkit.org/show_bug.cgi?id=147269 Patch by Said Abou-Hallawa sabouhall...@apple.com on 2015-07-28 Reviewed by Andreas Kling. Media elements should pause when the application is going to EnterBackground under lock regardless whether it is in full screen or not. Source/WebCore: * platform/audio/PlatformMediaSession.h: * platform/audio/PlatformMediaSession.cpp: (WebCore::PlatformMediaSession::doInterruption): This code was moved from beginInterruption(). (WebCore::PlatformMediaSession::shouldDoInterruption): Move the condition which allows the media session interruption to a separate function. (WebCore::PlatformMediaSession::beginInterruption): Call the functions shouldDoInterruption() and doInterruption(). (WebCore::PlatformMediaSession::forceInterruption): This function will be called from PlatformMediaSessionManager::applicationDidEnterBackground() to override the decision which is made by PlatformMediaSession::beginInterruption() if the application isSuspendedUnderLock. * platform/audio/PlatformMediaSessionManager.h: * platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::applicationDidEnterBackground): [UIApp isSuspendedUnderLock] is only valid when it is called when the UIApplicationDidEnterBackgroundNotification is received. We need to force interrupting the media sessions if the application isSuspendedUnderLock and UIApplicationWillResignActiveNotification was ignored because of PiP. * platform/audio/ios/MediaSessionManagerIOS.h: * platform/audio/ios/MediaSessionManagerIOS.mm: (-[WebMediaSessionHelper initWithCallback:]): (-[WebMediaSessionHelper applicationDidEnterBackground:]): Listen to UIApplicationDidEnterBackgroundNotification and make a call on the web thread to PlatformMediaSessionManager::applicationDidEnterBackground() and pass the isSuspendedUnderLock flag which is queried on the UIProcess. Source/WebKit2: * Platform/spi/ios/UIKitSPI.h: Forward declare [UIApplication isSuspendedUnderLock]. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::applicationDidEnterBackground): [UIApp isSuspendedUnderLock] can only be called in the UIProcess. We need to call it here and pass it to the WebPage in the WebProcess as part of the ApplicationDidEnterBackground message. * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Add the new parameter: 'isSuspendedUnderLock' to the ApplicationDidEnterBackground message. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::applicationDidEnterBackground): On iOS, the WebPage needs to notify the MediaSessionManagerIOS that it received the message ApplicationDidEnterBackground. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp trunk/Source/WebCore/platform/audio/PlatformMediaSession.h trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm Diff Modified: trunk/Source/WebCore/ChangeLog (187521 => 187522) --- trunk/Source/WebCore/ChangeLog 2015-07-28 22:22:14 UTC (rev 187521) +++ trunk/Source/WebCore/ChangeLog 2015-07-28 22:29:54 UTC (rev 187522) @@ -1,3 +1,45 @@ +2015-07-28 Said Abou-Hallawa sabouhall...@apple.com + +[iOS] REGRESSION(r168075): Fullscreen web video doesn't pause on screen lock +https://bugs.webkit.org/show_bug.cgi?id=147269 + +Reviewed by Andreas Kling. + +Media elements should pause when the application is going to EnterBackground +under lock regardless whether it is in full screen or not. + +* platform/audio/PlatformMediaSession.h: +* platform/audio/PlatformMediaSession.cpp: +(WebCore::PlatformMediaSession::doInterruption): This code was moved from +beginInterruption(). + +(WebCore::PlatformMediaSession::shouldDoInterruption): Move the condition +which allows the media session interruption to a separate function. + +(WebCore::PlatformMediaSession::beginInterruption): Call the functions +shouldDoInterruption() and doInterruption(). + +(WebCore::PlatformMediaSession::forceInterruption): This function will +be called from PlatformMediaSessionManager::applicationDidEnterBackground() +to override the decision which
[webkit-changes] [187533] trunk/Source
Title: [187533] trunk/Source Revision 187533 Author a...@apple.com Date 2015-07-28 18:26:49 -0700 (Tue, 28 Jul 2015) Log Message Clean up usesAsyncCallbacks handling in ResourceHandle https://bugs.webkit.org/show_bug.cgi?id=147342 Reviewed by Darin Adler. Source/WebCore: Store usesAsyncCallbacks bit in ResourceHandle, because it's not accessible via client once the client is zeroed out. Changed ResourceHandle::setClient into ResourceHandle::clearClient, because it's only ever used to zero out the client pointer, and it doesn't support changing it. * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading): * platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnSuccess): (WebCore::BlobResourceHandle::notifyResponseOnError): * platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::client): (WebCore::ResourceHandle::clearClient): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::usesAsyncCallbacks): (WebCore::ResourceHandle::setClient): Deleted. * platform/network/ResourceHandle.h: * platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::createCFURLConnection): (WebCore::ResourceHandle::willSendRequest): (WebCore::ResourceHandle::shouldUseCredentialStorage): (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::makeDelegate): (WebCore::ResourceHandle::willSendRequest): (WebCore::ResourceHandle::continueWillSendRequest): (WebCore::ResourceHandle::continueDidReceiveResponse): (WebCore::ResourceHandle::shouldUseCredentialStorage): (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): (WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace): (WebCore::ResourceHandle::continueWillCacheResponse): Source/WebKit2: Update for a renaming in WebCore. * NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::cleanup): * Shared/Downloads/soup/DownloadSoup.cpp: (WebKit::Download::platformInvalidate): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/ResourceLoader.cpp trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp trunk/Source/WebCore/platform/network/BlobResourceHandle.cpp trunk/Source/WebCore/platform/network/ResourceHandle.cpp trunk/Source/WebCore/platform/network/ResourceHandle.h trunk/Source/WebCore/platform/network/ResourceHandleInternal.h trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp trunk/Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (187532 => 187533) --- trunk/Source/WebCore/ChangeLog 2015-07-29 00:57:00 UTC (rev 187532) +++ trunk/Source/WebCore/ChangeLog 2015-07-29 01:26:49 UTC (rev 187533) @@ -1,3 +1,48 @@ +2015-07-28 Alexey Proskuryakov a...@apple.com + +Clean up usesAsyncCallbacks handling in ResourceHandle +https://bugs.webkit.org/show_bug.cgi?id=147342 + +Reviewed by Darin Adler. + +Store usesAsyncCallbacks bit in ResourceHandle, because it's not accessible +via client once the client is zeroed out. + +Changed ResourceHandle::setClient into ResourceHandle::clearClient, because it's +only ever used to zero out the client pointer, and it doesn't support changing it. + +* loader/ResourceLoader.cpp: +(WebCore::ResourceLoader::releaseResources): +* loader/appcache/ApplicationCacheGroup.cpp: +(WebCore::ApplicationCacheGroup::stopLoading): +* platform/network/BlobResourceHandle.cpp: +(WebCore::BlobResourceHandle::notifyResponseOnSuccess): +(WebCore::BlobResourceHandle::notifyResponseOnError): +* platform/network/ResourceHandle.cpp: +(WebCore::ResourceHandle::client): +(WebCore::ResourceHandle::clearClient): +(WebCore::ResourceHandle::setDefersLoading): +(WebCore::ResourceHandle::usesAsyncCallbacks): +(WebCore::ResourceHandle::setClient): Deleted. +* platform/network/ResourceHandle.h: +* platform/network/ResourceHandleInternal.h: +(WebCore::ResourceHandleInternal::ResourceHandleInternal): +* platform/network/cf/ResourceHandleCFNet.cpp: +(WebCore::ResourceHandle::createCFURLConnection): +(WebCore::ResourceHandle::willSendRequest): +(WebCore::ResourceHandle::shouldUseCredentialStorage): +(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): +* platform/network/mac/ResourceHandleMac.mm: +(WebCore::ResourceHandle::start): +
[webkit-changes] [187532] trunk/Source/WebCore
Title: [187532] trunk/Source/WebCore
Revision 187532
Author mcatanz...@igalia.com
Date 2015-07-28 17:57:00 -0700 (Tue, 28 Jul 2015)
Log Message
Minor cleanups in FontCacheFreeType.cpp
https://bugs.webkit.org/show_bug.cgi?id=147392
Reviewed by Martin Robinson.
Mark several functions as static (file-scope), use more nullptr, and use more smart
pointers. No behavior changes.
* platform/graphics/freetype/FcUniquePtr.h:
(WebCore::FcPtrDeleterFcCharSet::operator()):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::createFontConfigPatternForCharacters):
(WebCore::findBestFontGivenFallbacks):
(WebCore::FontCache::systemFallbackForCharacters):
(WebCore::fontWeightToFontconfigWeight):
(WebCore::FontCache::createFontPlatformData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187531 => 187532)
--- trunk/Source/WebCore/ChangeLog 2015-07-29 00:55:17 UTC (rev 187531)
+++ trunk/Source/WebCore/ChangeLog 2015-07-29 00:57:00 UTC (rev 187532)
@@ -1,3 +1,22 @@
+2015-07-28 Michael Catanzaro mcatanz...@igalia.com
+
+Minor cleanups in FontCacheFreeType.cpp
+https://bugs.webkit.org/show_bug.cgi?id=147392
+
+Reviewed by Martin Robinson.
+
+Mark several functions as static (file-scope), use more nullptr, and use more smart
+pointers. No behavior changes.
+
+* platform/graphics/freetype/FcUniquePtr.h:
+(WebCore::FcPtrDeleterFcCharSet::operator()):
+* platform/graphics/freetype/FontCacheFreeType.cpp:
+(WebCore::createFontConfigPatternForCharacters):
+(WebCore::findBestFontGivenFallbacks):
+(WebCore::FontCache::systemFallbackForCharacters):
+(WebCore::fontWeightToFontconfigWeight):
+(WebCore::FontCache::createFontPlatformData):
+
2015-07-28 Yusuke Suzuki utatane@gmail.com
[ES6] Add ENABLE_ES6_MODULES compile time flag with the default value false
Modified: trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h (187531 => 187532)
--- trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h 2015-07-29 00:55:17 UTC (rev 187531)
+++ trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h 2015-07-29 00:57:00 UTC (rev 187532)
@@ -41,6 +41,13 @@
templatetypename T
using FcUniquePtr = std::unique_ptrT, FcPtrDeleterT;
+template struct FcPtrDeleterFcCharSet {
+void operator()(FcCharSet* ptr) const
+{
+FcCharSetDestroy(ptr);
+}
+};
+
template struct FcPtrDeleterFcFontSet {
void operator()(FcFontSet* ptr) const
{
Modified: trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp (187531 => 187532)
--- trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp 2015-07-29 00:55:17 UTC (rev 187531)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp 2015-07-29 00:57:00 UTC (rev 187532)
@@ -41,60 +41,59 @@
ASSERT_NOT_REACHED();
}
-FcPattern* createFontConfigPatternForCharacters(const UChar* characters, int bufferLength)
+static RefPtrFcPattern createFontConfigPatternForCharacters(const UChar* characters, int bufferLength)
{
-FcPattern* pattern = FcPatternCreate();
-FcCharSet* fontConfigCharSet = FcCharSetCreate();
+RefPtrFcPattern pattern = adoptRef(FcPatternCreate());
+FcUniquePtrFcCharSet fontConfigCharSet(FcCharSetCreate());
UTF16UChar32Iterator iterator(characters, bufferLength);
UChar32 character = iterator.next();
while (character != iterator.end()) {
-FcCharSetAddChar(fontConfigCharSet, character);
+FcCharSetAddChar(fontConfigCharSet.get(), character);
character = iterator.next();
}
-FcPatternAddCharSet(pattern, FC_CHARSET, fontConfigCharSet);
-FcCharSetDestroy(fontConfigCharSet);
+FcPatternAddCharSet(pattern.get(), FC_CHARSET, fontConfigCharSet.get());
-FcPatternAddBool(pattern, FC_SCALABLE, FcTrue);
-FcConfigSubstitute(0, pattern, FcMatchPattern);
-FcDefaultSubstitute(pattern);
+FcPatternAddBool(pattern.get(), FC_SCALABLE, FcTrue);
+FcConfigSubstitute(nullptr, pattern.get(), FcMatchPattern);
+FcDefaultSubstitute(pattern.get());
return pattern;
}
-FcPattern* findBestFontGivenFallbacks(const FontPlatformData fontData, FcPattern* pattern)
+static RefPtrFcPattern findBestFontGivenFallbacks(const FontPlatformData fontData, FcPattern* pattern)
{
if (!fontData.m_pattern)
-return 0;
+return nullptr;
if (!fontData.m_fallbacks) {
FcResult fontConfigResult;
-fontData.m_fallbacks = FcFontSort(0, fontData.m_pattern.get(), FcTrue, 0, fontConfigResult);
+fontData.m_fallbacks = FcFontSort(nullptr, fontData.m_pattern.get(), FcTrue, nullptr, fontConfigResult);
}
if (!fontData.m_fallbacks)
-return 0;
+return nullptr;
[webkit-changes] [187536] trunk/Source/WebCore
Title: [187536] trunk/Source/WebCore
Revision 187536
Author simon.fra...@apple.com
Date 2015-07-28 19:08:36 -0700 (Tue, 28 Jul 2015)
Log Message
Fix debug builds.
* platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::premultiplyBufferData):
(WebCore::unpremultiplyBufferData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187535 => 187536)
--- trunk/Source/WebCore/ChangeLog 2015-07-29 01:57:30 UTC (rev 187535)
+++ trunk/Source/WebCore/ChangeLog 2015-07-29 02:08:36 UTC (rev 187536)
@@ -1,5 +1,13 @@
2015-07-28 Simon Fraser simon.fra...@apple.com
+Fix debug builds.
+
+* platform/graphics/cg/ImageBufferDataCG.cpp:
+(WebCore::premultiplyBufferData):
+(WebCore::unpremultiplyBufferData):
+
+2015-07-28 Simon Fraser simon.fra...@apple.com
+
Animations sometimes fail to start
https://bugs.webkit.org/show_bug.cgi?id=147394
rdar://problem/21852603
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp (187535 => 187536)
--- trunk/Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp 2015-07-29 01:57:30 UTC (rev 187535)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp 2015-07-29 02:08:36 UTC (rev 187536)
@@ -59,8 +59,8 @@
#if USE_ARGB32 || USE(IOSURFACE_CANVAS_BACKING_STORE)
static void premultiplyBufferData(const vImage_Buffer src, const vImage_Buffer dest)
{
-ASSERT(src-data);
-ASSERT(dest-data);
+ASSERT(src.data);
+ASSERT(dest.data);
if (kvImageNoError != vImagePremultiplyData_RGBA(src, dest, kvImageNoFlags))
return;
@@ -72,8 +72,8 @@
static void unpremultiplyBufferData(const vImage_Buffer src, const vImage_Buffer dest)
{
-ASSERT(src-data);
-ASSERT(dest-data);
+ASSERT(src.data);
+ASSERT(dest.data);
if (kvImageNoError != vImageUnpremultiplyData_RGBA(src, dest, kvImageNoFlags))
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187524] trunk/Source/JavaScriptCore
Title: [187524] trunk/Source/_javascript_Core Revision 187524 Author saambara...@gmail.com Date 2015-07-28 15:39:12 -0700 (Tue, 28 Jul 2015) Log Message Make the type profiler work with lexical scoping and add tests https://bugs.webkit.org/show_bug.cgi?id=145438 Reviewed by Geoffrey Garen. op_profile_type now knows how to resolve variables allocated within the local scope stack. This means it knows how to resolve let and const variables. Also, some refactoring was done inside the BytecodeGenerator to make writing code to support the type profiler much simpler and clearer. * bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): * bytecode/CodeBlock.h: (JSC::CodeBlock::symbolTable): Deleted. * bytecode/UnlinkedCodeBlock.h: (JSC::UnlinkedCodeBlock::addExceptionHandler): (JSC::UnlinkedCodeBlock::exceptionHandler): (JSC::UnlinkedCodeBlock::vm): (JSC::UnlinkedCodeBlock::addArrayProfile): (JSC::UnlinkedCodeBlock::setSymbolTableConstantIndex): Deleted. (JSC::UnlinkedCodeBlock::symbolTableConstantIndex): Deleted. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitMove): (JSC::BytecodeGenerator::emitTypeProfilerExpressionInfo): (JSC::BytecodeGenerator::emitProfileType): (JSC::BytecodeGenerator::emitProfileControlFlow): (JSC::BytecodeGenerator::pushLexicalScopeInternal): * bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNodeForLeftHandSide): * bytecompiler/NodesCodegen.cpp: (JSC::ThisNode::emitBytecode): (JSC::ResolveNode::emitBytecode): (JSC::BracketAccessorNode::emitBytecode): (JSC::DotAccessorNode::emitBytecode): (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::FunctionCallBracketNode::emitBytecode): (JSC::FunctionCallDotNode::emitBytecode): (JSC::CallFunctionCallDotNode::emitBytecode): (JSC::ApplyFunctionCallDotNode::emitBytecode): (JSC::PostfixNode::emitResolve): (JSC::PostfixNode::emitBracket): (JSC::PostfixNode::emitDot): (JSC::PrefixNode::emitResolve): (JSC::PrefixNode::emitBracket): (JSC::PrefixNode::emitDot): (JSC::ReadModifyResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode): (JSC::AssignDotNode::emitBytecode): (JSC::ReadModifyDotNode::emitBytecode): (JSC::AssignBracketNode::emitBytecode): (JSC::ReadModifyBracketNode::emitBytecode): (JSC::EmptyVarExpression::emitBytecode): (JSC::EmptyLetExpression::emitBytecode): (JSC::ForInNode::emitLoopHeader): (JSC::ForOfNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::FunctionNode::emitBytecode): (JSC::BindingNode::bindValue): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_profile_type): * jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_profile_type): * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: * tests/typeProfiler/es6-block-scoping.js: Added. (noop): (arr): (wrapper.changeFoo): (wrapper.scoping): (wrapper.scoping2): (wrapper): * tests/typeProfiler/es6-classes.js: Added. (noop): (wrapper.Animal): (wrapper.Animal.prototype.methodA): (wrapper.Dog): (wrapper.Dog.prototype.methodB): (wrapper): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecode/CodeBlock.h trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp trunk/Source/_javascript_Core/jit/JITOpcodes.cpp trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm Added Paths trunk/Source/_javascript_Core/tests/typeProfiler/es6-block-scoping.js trunk/Source/_javascript_Core/tests/typeProfiler/es6-classes.js Diff Modified: trunk/Source/_javascript_Core/ChangeLog (187523 => 187524) --- trunk/Source/_javascript_Core/ChangeLog 2015-07-28 22:38:17 UTC (rev 187523) +++ trunk/Source/_javascript_Core/ChangeLog 2015-07-28 22:39:12 UTC (rev 187524) @@ -1,5 +1,93 @@ 2015-07-28 Saam barati saambara...@gmail.com +Make the type profiler work with lexical scoping and add tests +https://bugs.webkit.org/show_bug.cgi?id=145438 + +Reviewed by Geoffrey Garen. + +op_profile_type now knows how to resolve variables allocated within +the local scope stack. This means it knows how to resolve let +and const variables. Also, some refactoring was done inside +the BytecodeGenerator to make writing code to support the type +profiler much simpler and clearer. + +* bytecode/CodeBlock.cpp: +(JSC::CodeBlock::CodeBlock): +
[webkit-changes] [187526] trunk/Websites/webkit.org
Title: [187526] trunk/Websites/webkit.org
Revision 187526
Author gga...@apple.com
Date 2015-07-28 16:21:15 -0700 (Tue, 28 Jul 2015)
Log Message
SunSpider is no longer maintained
https://bugs.webkit.org/show_bug.cgi?id=147370
Reviewed by Michael Saboff.
Add an indicator to show that SunSpider is no longer maintained.
* perf/sunspider/sunspider.css:
(#logo):
(.topbox):
(.bottombox):
* perf/sunspider/sunspider.html:
Modified Paths
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/perf/sunspider/sunspider.css
trunk/Websites/webkit.org/perf/sunspider/sunspider.html
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (187525 => 187526)
--- trunk/Websites/webkit.org/ChangeLog 2015-07-28 23:12:46 UTC (rev 187525)
+++ trunk/Websites/webkit.org/ChangeLog 2015-07-28 23:21:15 UTC (rev 187526)
@@ -1,3 +1,18 @@
+2015-07-28 Geoffrey Garen gga...@apple.com
+
+SunSpider is no longer maintained
+https://bugs.webkit.org/show_bug.cgi?id=147370
+
+Reviewed by Michael Saboff.
+
+Add an indicator to show that SunSpider is no longer maintained.
+
+* perf/sunspider/sunspider.css:
+(#logo):
+(.topbox):
+(.bottombox):
+* perf/sunspider/sunspider.html:
+
2015-07-24 Myles C. Maxfield mmaxfi...@apple.com
Add image for a blog post
Modified: trunk/Websites/webkit.org/perf/sunspider/sunspider.css (187525 => 187526)
--- trunk/Websites/webkit.org/perf/sunspider/sunspider.css 2015-07-28 23:12:46 UTC (rev 187525)
+++ trunk/Websites/webkit.org/perf/sunspider/sunspider.css 2015-07-28 23:21:15 UTC (rev 187526)
@@ -29,3 +29,13 @@
padding-right: 20px;
margin-bottom: -40px;
font-size: 3em }
+
+.topbox { padding: 20px;
+ border: 2px solid black;
+}
+
+.bottombox { margin-top: 20px;
+ padding: 20px;
+ border: 2px solid black;
+ opacity: 0.5;
+}
Modified: trunk/Websites/webkit.org/perf/sunspider/sunspider.html (187525 => 187526)
--- trunk/Websites/webkit.org/perf/sunspider/sunspider.html 2015-07-28 23:12:46 UTC (rev 187525)
+++ trunk/Websites/webkit.org/perf/sunspider/sunspider.html 2015-07-28 23:21:15 UTC (rev 187526)
@@ -34,6 +34,17 @@
body
+div class=topbox
+
+h1a href="" JetStream/a/h1
+pSunSpider is no longer maintained. We recommend
+a href="" which tests
+the _javascript_ techniques used by advanced web applications./p
+
+/div
+
+div class=bottombox
+
h2span id=logo#x2600;/spanSunSpider 1.0.2 _javascript_ Benchmark/h2
pThis is SunSpider, a _javascript_ benchmark. This benchmark tests the
@@ -76,6 +87,8 @@
a href="" versions./a
+/div
+
/body
/html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187531] trunk/Source/JavaScriptCore
Title: [187531] trunk/Source/_javascript_Core Revision 187531 Author commit-qu...@webkit.org Date 2015-07-28 17:55:17 -0700 (Tue, 28 Jul 2015) Log Message Implement WebAssembly module parser https://bugs.webkit.org/show_bug.cgi?id=147293 Patch by Sukolsak Sakshuwong sukol...@gmail.com on 2015-07-28 Reviewed by Geoffrey Garen. Implement WebAssembly module parser for WebAssembly files produced by pack-asmjs https://github.com/WebAssembly/polyfill-prototype-1. This patch only checks the magic number at the beginning of the files. Parsing of the rest will be implemented in a subsequent patch. * CMakeLists.txt: * _javascript_Core.vcxproj/_javascript_Core.vcxproj: * _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: * _javascript_Core.xcodeproj/project.pbxproj: * jsc.cpp: (GlobalObject::finishCreation): (functionLoadWebAssembly): * parser/SourceProvider.h: (JSC::WebAssemblySourceProvider::create): (JSC::WebAssemblySourceProvider::data): (JSC::WebAssemblySourceProvider::WebAssemblySourceProvider): * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildren): * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::wasmModuleStructure): * wasm/WASMMagicNumber.h: Added. * wasm/WASMModuleParser.cpp: Added. (JSC::WASMModuleParser::WASMModuleParser): (JSC::WASMModuleParser::parse): (JSC::WASMModuleParser::parseModule): (JSC::parseWebAssembly): * wasm/WASMModuleParser.h: Added. * wasm/WASMReader.cpp: Added. (JSC::WASMReader::readUnsignedInt32): (JSC::WASMReader::readFloat): (JSC::WASMReader::readDouble): * wasm/WASMReader.h: Added. (JSC::WASMReader::WASMReader): Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/jsc.cpp trunk/Source/_javascript_Core/parser/SourceProvider.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObject.h Added Paths trunk/Source/_javascript_Core/wasm/WASMMagicNumber.h trunk/Source/_javascript_Core/wasm/WASMModuleParser.cpp trunk/Source/_javascript_Core/wasm/WASMModuleParser.h trunk/Source/_javascript_Core/wasm/WASMReader.cpp trunk/Source/_javascript_Core/wasm/WASMReader.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (187530 => 187531) --- trunk/Source/_javascript_Core/CMakeLists.txt 2015-07-29 00:44:14 UTC (rev 187530) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2015-07-29 00:55:17 UTC (rev 187531) @@ -411,6 +411,8 @@ tools/JSDollarVMPrototype.cpp wasm/JSWASMModule.cpp +wasm/WASMModuleParser.cpp +wasm/WASMReader.cpp yarr/RegularExpression.cpp yarr/YarrCanonicalizeUCS2.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (187530 => 187531) --- trunk/Source/_javascript_Core/ChangeLog 2015-07-29 00:44:14 UTC (rev 187530) +++ trunk/Source/_javascript_Core/ChangeLog 2015-07-29 00:55:17 UTC (rev 187531) @@ -1,3 +1,45 @@ +2015-07-28 Sukolsak Sakshuwong sukol...@gmail.com + +Implement WebAssembly module parser +https://bugs.webkit.org/show_bug.cgi?id=147293 + +Reviewed by Geoffrey Garen. + +Implement WebAssembly module parser for WebAssembly files produced by pack-asmjs +https://github.com/WebAssembly/polyfill-prototype-1. This patch only checks +the magic number at the beginning of the files. Parsing of the rest will be +implemented in a subsequent patch. + +* CMakeLists.txt: +* _javascript_Core.vcxproj/_javascript_Core.vcxproj: +* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: +* _javascript_Core.xcodeproj/project.pbxproj: +* jsc.cpp: +(GlobalObject::finishCreation): +(functionLoadWebAssembly): +* parser/SourceProvider.h: +(JSC::WebAssemblySourceProvider::create): +(JSC::WebAssemblySourceProvider::data): +(JSC::WebAssemblySourceProvider::WebAssemblySourceProvider): +* runtime/JSGlobalObject.cpp: +(JSC::JSGlobalObject::init): +(JSC::JSGlobalObject::visitChildren): +* runtime/JSGlobalObject.h: +(JSC::JSGlobalObject::wasmModuleStructure): +* wasm/WASMMagicNumber.h: Added. +* wasm/WASMModuleParser.cpp: Added. +(JSC::WASMModuleParser::WASMModuleParser): +(JSC::WASMModuleParser::parse): +(JSC::WASMModuleParser::parseModule): +(JSC::parseWebAssembly): +* wasm/WASMModuleParser.h: Added. +* wasm/WASMReader.cpp: Added. +(JSC::WASMReader::readUnsignedInt32): +(JSC::WASMReader::readFloat): +(JSC::WASMReader::readDouble): +* wasm/WASMReader.h: Added. +(JSC::WASMReader::WASMReader): + 2015-07-28 Yusuke Suzuki utatane@gmail.com
[webkit-changes] [187534] trunk/Source/WebCore
Title: [187534] trunk/Source/WebCore
Revision 187534
Author d...@apple.com
Date 2015-07-28 18:43:58 -0700 (Tue, 28 Jul 2015)
Log Message
Remove dispatch_apply_f and instead use vImage more directly
https://bugs.webkit.org/show_bug.cgi?id=147391
rdar://problem/21893047
Reviewed by Simon Fraser.
Use vImage unmultiplication and premultiplication functions on the
entire ImageBufferData object, rather than getting and setting data on an
line by line using dispatch_apply.
We were seeing some crashes in vImage with the smaller buffer sizes, and
hopefully this will either fix the problem, or give us a better
stack trace to diagnose.
I also did a drive-by change of dst to dest. It was inconsistent throughout
the file.
Convered by the tests in fast/canvas and imported/w3c/canvas
* platform/graphics/cg/ImageBufferDataCG.cpp: Remove the ScanlineData structure. It is
no longer needed.
(WebCore::premultiplyBufferData): New function that calls vImagePremultiplyData_RGBA.
(WebCore::unpremultiplyBufferData): New function that calls vImageUnpremultiplyData_RGBA.
(WebCore::affineWarpBufferData): Extracting some common code into a function.
(WebCore::ImageBufferData::getData): Use the two new functions as appropriate. Move
some of the code around now that more is shared between the different #if branches.
(WebCore::ImageBufferData::putData):
(WebCore::convertScanline): Deleted.
(WebCore::unpremultitplyScanline): Deleted.
(WebCore::premultitplyScanline): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187533 => 187534)
--- trunk/Source/WebCore/ChangeLog 2015-07-29 01:26:49 UTC (rev 187533)
+++ trunk/Source/WebCore/ChangeLog 2015-07-29 01:43:58 UTC (rev 187534)
@@ -1,3 +1,36 @@
+2015-07-28 Dean Jackson d...@apple.com
+
+Remove dispatch_apply_f and instead use vImage more directly
+https://bugs.webkit.org/show_bug.cgi?id=147391
+rdar://problem/21893047
+
+Reviewed by Simon Fraser.
+
+Use vImage unmultiplication and premultiplication functions on the
+entire ImageBufferData object, rather than getting and setting data on an
+line by line using dispatch_apply.
+
+We were seeing some crashes in vImage with the smaller buffer sizes, and
+hopefully this will either fix the problem, or give us a better
+stack trace to diagnose.
+
+I also did a drive-by change of dst to dest. It was inconsistent throughout
+the file.
+
+Convered by the tests in fast/canvas and imported/w3c/canvas
+
+* platform/graphics/cg/ImageBufferDataCG.cpp: Remove the ScanlineData structure. It is
+no longer needed.
+(WebCore::premultiplyBufferData): New function that calls vImagePremultiplyData_RGBA.
+(WebCore::unpremultiplyBufferData): New function that calls vImageUnpremultiplyData_RGBA.
+(WebCore::affineWarpBufferData): Extracting some common code into a function.
+(WebCore::ImageBufferData::getData): Use the two new functions as appropriate. Move
+some of the code around now that more is shared between the different #if branches.
+(WebCore::ImageBufferData::putData):
+(WebCore::convertScanline): Deleted.
+(WebCore::unpremultitplyScanline): Deleted.
+(WebCore::premultitplyScanline): Deleted.
+
2015-07-28 Alexey Proskuryakov a...@apple.com
Clean up usesAsyncCallbacks handling in ResourceHandle
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp (187533 => 187534)
--- trunk/Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp 2015-07-29 01:26:49 UTC (rev 187533)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp 2015-07-29 01:43:58 UTC (rev 187534)
@@ -42,16 +42,6 @@
#include dispatch/dispatch.h
#endif
-#if USE(ACCELERATE)
-struct ScanlineData {
-vImagePixelCount scanlineWidth;
-unsigned char* srcData;
-size_t srcRowBytes;
-unsigned char* destData;
-size_t destRowBytes;
-};
-#endif
-
// CA uses ARGB32 for textures and ARGB32 - ARGB32 resampling is optimized.
#define USE_ARGB32 PLATFORM(IOS)
@@ -66,47 +56,41 @@
}
#if USE(ACCELERATE)
-
#if USE_ARGB32 || USE(IOSURFACE_CANVAS_BACKING_STORE)
-static void convertScanline(void* data, size_t tileNumber, bool premultiply)
+static void premultiplyBufferData(const vImage_Buffer src, const vImage_Buffer dest)
{
-ScanlineData* scanlineData = static_castScanlineData*(data);
+ASSERT(src-data);
+ASSERT(dest-data);
-vImage_Buffer src;
-src.data = "" + tileNumber * scanlineData-srcRowBytes;
-src.height = 1;
-src.width = scanlineData-scanlineWidth;
-src.rowBytes = scanlineData-srcRowBytes;
+if (kvImageNoError != vImagePremultiplyData_RGBA(src, dest, kvImageNoFlags))
+return;
-vImage_Buffer dest;
-dest.data = "" + tileNumber *
[webkit-changes] [187523] trunk/LayoutTests
Title: [187523] trunk/LayoutTests Revision 187523 Author cdu...@apple.com Date 2015-07-28 15:38:17 -0700 (Tue, 28 Jul 2015) Log Message Tests introduced in r187489 are flaky https://bugs.webkit.org/show_bug.cgi?id=147327 Rubber-stamped by Benjamin Poulain. Tests introduced in r187489 are flaky, they sometimes print the console message, sometimes not. The reason is that we sometimes use a cached parsed stylesheet and we do not print the warning in this case. To fix the flakiness, we now clear the memory cache at the beginning of each test to make sure we download and parse the stylesheets. * http/tests/security/cross-origin-css-1.html: * http/tests/security/cross-origin-css-2.html: * http/tests/security/cross-origin-css-3.html: * http/tests/security/cross-origin-css-4.html: * http/tests/security/cross-origin-css-5.html: * http/tests/security/cross-origin-css-6.html: * http/tests/security/cross-origin-css-7.html: * http/tests/security/cross-origin-css-8.html: * http/tests/security/cross-origin-css-in-quirks-1.html: * http/tests/security/cross-origin-css-in-quirks-2.html: * http/tests/security/cross-origin-css-in-quirks-3.html: * http/tests/security/cross-origin-css-in-quirks-4.html: * http/tests/security/cross-origin-css-in-quirks-5.html: * http/tests/security/cross-origin-css-in-quirks-6.html: * http/tests/security/cross-origin-css-in-quirks-7.html: * http/tests/security/cross-origin-css-in-quirks-8.html: * http/tests/security/same-origin-css-1.html: * http/tests/security/same-origin-css-2.html: * http/tests/security/same-origin-css-3.html: * http/tests/security/same-origin-css-4.html: * http/tests/security/same-origin-css-5.html: * http/tests/security/same-origin-css-6.html: * http/tests/security/same-origin-css-7.html: * http/tests/security/same-origin-css-8.html: * http/tests/security/same-origin-css-in-quirks.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/cross-origin-css-1.html trunk/LayoutTests/http/tests/security/cross-origin-css-2.html trunk/LayoutTests/http/tests/security/cross-origin-css-3.html trunk/LayoutTests/http/tests/security/cross-origin-css-4.html trunk/LayoutTests/http/tests/security/cross-origin-css-5.html trunk/LayoutTests/http/tests/security/cross-origin-css-6.html trunk/LayoutTests/http/tests/security/cross-origin-css-7.html trunk/LayoutTests/http/tests/security/cross-origin-css-8.html trunk/LayoutTests/http/tests/security/cross-origin-css-in-quirks-1.html trunk/LayoutTests/http/tests/security/cross-origin-css-in-quirks-2.html trunk/LayoutTests/http/tests/security/cross-origin-css-in-quirks-3.html trunk/LayoutTests/http/tests/security/cross-origin-css-in-quirks-4.html trunk/LayoutTests/http/tests/security/cross-origin-css-in-quirks-5.html trunk/LayoutTests/http/tests/security/cross-origin-css-in-quirks-6.html trunk/LayoutTests/http/tests/security/cross-origin-css-in-quirks-7.html trunk/LayoutTests/http/tests/security/cross-origin-css-in-quirks-8.html trunk/LayoutTests/http/tests/security/same-origin-css-1.html trunk/LayoutTests/http/tests/security/same-origin-css-2.html trunk/LayoutTests/http/tests/security/same-origin-css-3.html trunk/LayoutTests/http/tests/security/same-origin-css-4.html trunk/LayoutTests/http/tests/security/same-origin-css-5.html trunk/LayoutTests/http/tests/security/same-origin-css-6.html trunk/LayoutTests/http/tests/security/same-origin-css-7.html trunk/LayoutTests/http/tests/security/same-origin-css-8.html trunk/LayoutTests/http/tests/security/same-origin-css-in-quirks.html Diff Modified: trunk/LayoutTests/ChangeLog (187522 => 187523) --- trunk/LayoutTests/ChangeLog 2015-07-28 22:29:54 UTC (rev 187522) +++ trunk/LayoutTests/ChangeLog 2015-07-28 22:38:17 UTC (rev 187523) @@ -1,5 +1,44 @@ 2015-07-28 Chris Dumez cdu...@apple.com +Tests introduced in r187489 are flaky +https://bugs.webkit.org/show_bug.cgi?id=147327 + +Rubber-stamped by Benjamin Poulain. + +Tests introduced in r187489 are flaky, they sometimes print the console +message, sometimes not. The reason is that we sometimes use a cached +parsed stylesheet and we do not print the warning in this case. To fix +the flakiness, we now clear the memory cache at the beginning of each +test to make sure we download and parse the stylesheets. + +* http/tests/security/cross-origin-css-1.html: +* http/tests/security/cross-origin-css-2.html: +* http/tests/security/cross-origin-css-3.html: +* http/tests/security/cross-origin-css-4.html: +* http/tests/security/cross-origin-css-5.html: +* http/tests/security/cross-origin-css-6.html: +* http/tests/security/cross-origin-css-7.html: +* http/tests/security/cross-origin-css-8.html: +* http/tests/security/cross-origin-css-in-quirks-1.html: +* http/tests/security/cross-origin-css-in-quirks-2.html: +* http/tests/security/cross-origin-css-in-quirks-3.html: +
[webkit-changes] [187528] trunk/Source/WebInspectorUI
Title: [187528] trunk/Source/WebInspectorUI Revision 187528 Author commit-qu...@webkit.org Date 2015-07-28 16:50:11 -0700 (Tue, 28 Jul 2015) Log Message Web Inspector: console.groupEnd causes negative indent when no group is active https://bugs.webkit.org/show_bug.cgi?id=147375 Patch by Joseph Pecoraro pecor...@apple.com on 2015-07-28 Reviewed by Timothy Hatcher. * UserInterface/Views/LogContentView.js: (WebInspector.LogContentView.prototype.didAppendConsoleMessageView): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (187527 => 187528) --- trunk/Source/WebInspectorUI/ChangeLog 2015-07-28 23:37:10 UTC (rev 187527) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-28 23:50:11 UTC (rev 187528) @@ -1,3 +1,13 @@ +2015-07-28 Joseph Pecoraro pecor...@apple.com + +Web Inspector: console.groupEnd causes negative indent when no group is active +https://bugs.webkit.org/show_bug.cgi?id=147375 + +Reviewed by Timothy Hatcher. + +* UserInterface/Views/LogContentView.js: +(WebInspector.LogContentView.prototype.didAppendConsoleMessageView): + 2015-07-28 Brian J. Burg b...@cs.washington.edu Web Inspector: Convert NavigationItem subclasses to ES6 Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (187527 => 187528) --- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2015-07-28 23:37:10 UTC (rev 187527) +++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2015-07-28 23:50:11 UTC (rev 187528) @@ -172,7 +172,8 @@ ++this._nestingLevel; break; case WebInspector.ConsoleMessage.MessageType.EndGroup: ---this._nestingLevel; +if (this._nestingLevel 0) +--this._nestingLevel; break; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187527] trunk
Title: [187527] trunk Revision 187527 Author mcatanz...@igalia.com Date 2015-07-28 16:37:10 -0700 (Tue, 28 Jul 2015) Log Message [Freetype] Always allow font matching for strong aliases https://bugs.webkit.org/show_bug.cgi?id=147057 Reviewed by Martin Robinson. Source/WebCore: Tests: platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html Treat fonts that are strongly-aliased to each other as if they were identical for the purposes of CSS font fallback. This improves the layout of many web pages by allowing fontconfig to replace fonts with metric-compatible equivalents (e.g. Arial - Liberation Sans) instead of rejecting the metric-compatible font as unsuitable. * platform/graphics/cairo/RefPtrCairo.cpp: (WTF::refIfNotNull): (WTF::derefIfNotNull): * platform/graphics/cairo/RefPtrCairo.h: * platform/graphics/freetype/FcUniquePtr.h: Added. (WebCore::FcPtrDeleterFcFontSet::operator()): (WebCore::FcPtrDeleterFcLangSet::operator()): (WebCore::FcPtrDeleterFcObjectSet::operator()): * platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::strengthOfFirstAlias): (WebCore::strongAliasesForFamily): (WebCore::areStronglyAliased): (WebCore::FontCache::createFontPlatformData): Tools: Create family aliases needed for the new layout tests. * WebKitTestRunner/gtk/fonts/fonts.conf: LayoutTests: * platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html: Added. * platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html: Added. * platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html: Added. * platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/RefPtrCairo.h trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/gtk/fonts/fonts.conf Added Paths trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html trunk/Source/WebCore/platform/graphics/freetype/FcUniquePtr.h Diff Modified: trunk/LayoutTests/ChangeLog (187526 => 187527) --- trunk/LayoutTests/ChangeLog 2015-07-28 23:21:15 UTC (rev 187526) +++ trunk/LayoutTests/ChangeLog 2015-07-28 23:37:10 UTC (rev 187527) @@ -1,3 +1,15 @@ +2015-07-28 Michael Catanzaro mcatanz...@igalia.com + +[Freetype] Always allow font matching for strong aliases +https://bugs.webkit.org/show_bug.cgi?id=147057 + +Reviewed by Martin Robinson. + +* platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html: Added. +* platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html: Added. +* platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html: Added. +* platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html: Added. + 2015-07-28 Myles C. Maxfield mmaxfi...@apple.com [iOS] Crash when encountering characters whose natural font is one we can't look up Added: trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html (0 => 187527) --- trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html (rev 0) +++ trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html 2015-07-28 23:37:10 UTC (rev 187527) @@ -0,0 +1,5 @@ +body style=font-family:serif; +This test ensures that if a font is weakly aliased to another, the alias is +ignored for the purposes of CSS font fallback. This test passes if it is +displayed in a serif font and fails if it is displayed in FreeMono. +/body Added: trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html (0 => 187527) --- trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html (rev 0) +++ trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html 2015-07-28 23:37:10 UTC (rev 187527) @@ -0,0 +1,5 @@ +body style=font-family:FamilyWeakAliasedToFreeMono,serif; +This test ensures that if a font is weakly aliased to another, the alias is +ignored for the purposes of CSS font fallback. This test passes if it is +displayed in a serif font and fails if it is displayed in FreeMono. +/body Added: trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html (0 => 187527) --- trunk/LayoutTests/platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html
[webkit-changes] [187539] trunk/Source/JavaScriptCore
Title: [187539] trunk/Source/_javascript_Core Revision 187539 Author commit-qu...@webkit.org Date 2015-07-28 22:48:29 -0700 (Tue, 28 Jul 2015) Log Message Add the wasm directory to Visual Studio project files https://bugs.webkit.org/show_bug.cgi?id=147400 Patch by Sukolsak Sakshuwong sukol...@gmail.com on 2015-07-28 Reviewed by Simon Fraser. This patch should fix the Cannot open include file: 'JSWASMModule.h' issue in the Windows build. * _javascript_Core.vcxproj/_javascript_CoreCommon.props: * _javascript_Core.vcxproj/copy-files.cmd: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreCommon.props trunk/Source/_javascript_Core/_javascript_Core.vcxproj/copy-files.cmd Diff Modified: trunk/Source/_javascript_Core/ChangeLog (187538 => 187539) --- trunk/Source/_javascript_Core/ChangeLog 2015-07-29 03:27:23 UTC (rev 187538) +++ trunk/Source/_javascript_Core/ChangeLog 2015-07-29 05:48:29 UTC (rev 187539) @@ -1,3 +1,16 @@ +2015-07-28 Sukolsak Sakshuwong sukol...@gmail.com + +Add the wasm directory to Visual Studio project files +https://bugs.webkit.org/show_bug.cgi?id=147400 + +Reviewed by Simon Fraser. + +This patch should fix the Cannot open include file: 'JSWASMModule.h' issue +in the Windows build. + +* _javascript_Core.vcxproj/_javascript_CoreCommon.props: +* _javascript_Core.vcxproj/copy-files.cmd: + 2015-07-28 Commit Queue commit-qu...@webkit.org Unreviewed, rolling out r187531. Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreCommon.props (187538 => 187539) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreCommon.props 2015-07-29 03:27:23 UTC (rev 187538) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreCommon.props 2015-07-29 05:48:29 UTC (rev 187539) @@ -6,7 +6,7 @@ ItemDefinitionGroup ClCompile DisableSpecificWarnings4611;%(DisableSpecificWarnings)/DisableSpecificWarnings - AdditionalIncludeDirectories..\;..\tools\;..\runtime\;..\llint\;..\jit\;..\disassembler\;..\heap\;..\debugger\;..\assembler\;..\profiler\;..\yarr\;..\interpreter\;..\bytecode\;..\builtins\;..\dfg\;..\bytecompiler\;..\parser\;..\API\;..\ftl\;..\bindings\;..\inspector\;..\ftl;..\llvm;..\llvm\library;$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\_javascript_Core\DerivedSources\;$(ConfigurationBuildDir)\include\;$(ConfigurationBuildDir)\include\_javascript_Core\;$(ConfigurationBuildDir)\include\private\;$(WebKit_Libraries)\include;$(WebKit_Libraries)\include\private;%(AdditionalIncludeDirectories)/AdditionalIncludeDirectories + AdditionalIncludeDirectories..\;..\tools\;..\runtime\;..\llint\;..\jit\;..\disassembler\;..\heap\;..\debugger\;..\assembler\;..\profiler\;..\yarr\;..\interpreter\;..\bytecode\;..\builtins\;..\dfg\;..\bytecompiler\;..\parser\;..\API\;..\ftl\;..\bindings\;..\inspector\;..\wasm\;..\ftl;..\llvm;..\llvm\library;$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\_javascript_Core\DerivedSources\;$(ConfigurationBuildDir)\include\;$(ConfigurationBuildDir)\include\_javascript_Core\;$(ConfigurationBuildDir)\include\private\;$(WebKit_Libraries)\include;$(WebKit_Libraries)\include\private;%(AdditionalIncludeDirectories)/AdditionalIncludeDirectories ForcedIncludeFilesICUVersion.h;%(ForcedIncludeFiles)/ForcedIncludeFiles DisableSpecificWarnings4611;%(DisableSpecificWarnings)/DisableSpecificWarnings /ClCompile Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/copy-files.cmd (187538 => 187539) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/copy-files.cmd 2015-07-29 03:27:23 UTC (rev 187538) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/copy-files.cmd 2015-07-29 05:48:29 UTC (rev 187539) @@ -56,6 +56,7 @@ profiler replay runtime +wasm yarr ) do ( @xcopy /y /d ..\%%d\*.h %PrivateHeadersDirectory% NUL ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187538] trunk/Source/JavaScriptCore
Title: [187538] trunk/Source/_javascript_Core Revision 187538 Author commit-qu...@webkit.org Date 2015-07-28 20:27:23 -0700 (Tue, 28 Jul 2015) Log Message Unreviewed, rolling out r187531. https://bugs.webkit.org/show_bug.cgi?id=147397 Broke Windows bild (Requested by smfr on #webkit). Reverted changeset: Implement WebAssembly module parser https://bugs.webkit.org/show_bug.cgi?id=147293 http://trac.webkit.org/changeset/187531 Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/jsc.cpp trunk/Source/_javascript_Core/parser/SourceProvider.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObject.h Removed Paths trunk/Source/_javascript_Core/wasm/WASMMagicNumber.h trunk/Source/_javascript_Core/wasm/WASMModuleParser.cpp trunk/Source/_javascript_Core/wasm/WASMModuleParser.h trunk/Source/_javascript_Core/wasm/WASMReader.cpp trunk/Source/_javascript_Core/wasm/WASMReader.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (187537 => 187538) --- trunk/Source/_javascript_Core/CMakeLists.txt 2015-07-29 02:15:41 UTC (rev 187537) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2015-07-29 03:27:23 UTC (rev 187538) @@ -411,8 +411,6 @@ tools/JSDollarVMPrototype.cpp wasm/JSWASMModule.cpp -wasm/WASMModuleParser.cpp -wasm/WASMReader.cpp yarr/RegularExpression.cpp yarr/YarrCanonicalizeUCS2.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (187537 => 187538) --- trunk/Source/_javascript_Core/ChangeLog 2015-07-29 02:15:41 UTC (rev 187537) +++ trunk/Source/_javascript_Core/ChangeLog 2015-07-29 03:27:23 UTC (rev 187538) @@ -1,3 +1,16 @@ +2015-07-28 Commit Queue commit-qu...@webkit.org + +Unreviewed, rolling out r187531. +https://bugs.webkit.org/show_bug.cgi?id=147397 + +Broke Windows bild (Requested by smfr on #webkit). + +Reverted changeset: + +Implement WebAssembly module parser +https://bugs.webkit.org/show_bug.cgi?id=147293 +http://trac.webkit.org/changeset/187531 + 2015-07-28 Benjamin Poulain bpoul...@apple.com Speed up the Stringifier::toJSON() fast case Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj (187537 => 187538) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj 2015-07-29 02:15:41 UTC (rev 187537) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj 2015-07-29 03:27:23 UTC (rev 187538) @@ -868,8 +868,6 @@ ClCompile Include=..\tools\JSDollarVM.cpp / ClCompile Include=..\tools\JSDollarVMPrototype.cpp / ClCompile Include=..\wasm\JSWASMModule.cpp / -ClCompile Include=..\wasm\WASMModuleParser.cpp / -ClCompile Include=..\wasm\WASMReader.cpp / ClCompile Include=..\yarr\RegularExpression.cpp / ClCompile Include=..\yarr\YarrCanonicalizeUCS2.cpp / ClCompile Include=..\yarr\YarrInterpreter.cpp / @@ -1736,9 +1734,6 @@ ClInclude Include=..\tools\ProfileTreeNode.h / ClInclude Include=..\tools\TieredMMapArray.h / ClInclude Include=..\wasm\JSWASMModule.h / -ClInclude Include=..\wasm\WASMMagicNumber.h / -ClInclude Include=..\wasm\WASMModuleParser.h / -ClInclude Include=..\wasm\WASMReader.h / ClInclude Include=..\yarr\RegularExpression.h / ClInclude Include=..\yarr\Yarr.h / ClInclude Include=..\yarr\YarrCanonicalizeUCS2.h / Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters (187537 => 187538) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters 2015-07-29 02:15:41 UTC (rev 187537) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters 2015-07-29 03:27:23 UTC (rev 187538) @@ -1797,12 +1797,6 @@ ClCompile Include=..\wasm\JSWASMModule.cpp Filterwasm/Filter /ClCompile -ClCompile Include=..\wasm\WASMModuleParser.cpp - Filterwasm/Filter -/ClCompile -ClCompile Include=..\wasm\WASMReader.cpp - Filterwasm/Filter -/ClCompile /ItemGroup ItemGroup ClInclude Include=..\API\APICallbackFunction.h @@ -4307,15 +4301,6 @@ ClInclude Include=..\wasm\JSWASMModule.h Filterwasm/Filter /ClInclude -ClInclude Include=..\wasm\WASMMagicNumber.h - Filterwasm/Filter -/ClInclude -ClInclude Include=..\wasm\WASMModuleParser.h - Filterwasm/Filter -/ClInclude -ClInclude Include=..\wasm\WASMReader.h - Filterwasm/Filter -/ClInclude /ItemGroup ItemGroup None Include=_javascript_CorePreLink.cmd / Modified:
[webkit-changes] [187489] trunk
Title: [187489] trunk Revision 187489 Author cdu...@apple.com Date 2015-07-28 10:24:26 -0700 (Tue, 28 Jul 2015) Log Message Allow lax MIME type parsing for same-origin CSS in quirks mode. https://bugs.webkit.org/show_bug.cgi?id=147327 rdar://problem/22010303 Reviewed by Zalan Bujtas. Source/WebCore: The change made in r180020 is too strict for the web, and doesn't match Firefox Chrome, or IE's behavior. In particular, it does not respect the same-origin carveout that the HTML spec specifies: https://html.spec.whatwg.org/multipage/semantics.html#link-type-stylesheet This patch corrects that oversight and aligns our behavior with other popular browsers. This change was adapted from Blink r196678: https://src.chromium.org/viewvc/blink?revision=196678view=revision Tests: http/tests/security/cross-origin-css-in-quirks-1.html http/tests/security/cross-origin-css-in-quirks-2.html http/tests/security/cross-origin-css-in-quirks-3.html http/tests/security/cross-origin-css-in-quirks-4.html http/tests/security/cross-origin-css-in-quirks-5.html http/tests/security/cross-origin-css-in-quirks-6.html http/tests/security/cross-origin-css-in-quirks-7.html http/tests/security/cross-origin-css-in-quirks-8.html http/tests/security/same-origin-css-1.html http/tests/security/same-origin-css-2.html http/tests/security/same-origin-css-3.html http/tests/security/same-origin-css-4.html http/tests/security/same-origin-css-5.html http/tests/security/same-origin-css-6.html http/tests/security/same-origin-css-7.html http/tests/security/same-origin-css-8.html http/tests/security/same-origin-css-in-quirks.html * css/StyleRuleImport.cpp: (WebCore::StyleRuleImport::setCSSStyleSheet): * css/StyleSheetContents.cpp: (WebCore::StyleSheetContents::parseAuthorStyleSheet): * css/StyleSheetContents.h: * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet): * loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): (WebCore::CachedCSSStyleSheet::canUseSheet): (WebCore::CachedCSSStyleSheet::checkNotify): Deleted. * loader/cache/CachedCSSStyleSheet.h: LayoutTests: Add layout test coverage for MIME type parsing for same-origin CSS in quirks mode and not. * http/tests/inspector/css/bad-mime-type-expected.txt: * http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt: * http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt: * http/tests/misc/css-accept-any-type-expected.txt: Removed. * http/tests/misc/css-accept-any-type.html: Removed. * http/tests/misc/css-reject-any-type-in-strict-mode-expected.txt: * http/tests/security/cross-origin-css-1-expected.txt: * http/tests/security/cross-origin-css-2-expected.txt: * http/tests/security/cross-origin-css-4-expected.txt: * http/tests/security/cross-origin-css-5-expected.txt: * http/tests/security/cross-origin-css-7-expected.txt: * http/tests/security/cross-origin-css-in-quirks-1-expected.txt: Copied from LayoutTests/http/tests/security/cross-origin-css-1-expected.txt. * http/tests/security/cross-origin-css-in-quirks-1.html: Added. * http/tests/security/cross-origin-css-in-quirks-2-expected.txt: Copied from LayoutTests/http/tests/security/cross-origin-css-2-expected.txt. * http/tests/security/cross-origin-css-in-quirks-2.html: Added. * http/tests/security/cross-origin-css-in-quirks-3-expected.txt: Added. * http/tests/security/cross-origin-css-in-quirks-3.html: Added. * http/tests/security/cross-origin-css-in-quirks-4-expected.txt: Added. * http/tests/security/cross-origin-css-in-quirks-4.html: Added. * http/tests/security/cross-origin-css-in-quirks-5-expected.txt: Copied from LayoutTests/http/tests/security/cross-origin-css-5-expected.txt. * http/tests/security/cross-origin-css-in-quirks-5.html: Added. * http/tests/security/cross-origin-css-in-quirks-6-expected.txt: Added. * http/tests/security/cross-origin-css-in-quirks-6.html: Added. * http/tests/security/cross-origin-css-in-quirks-7-expected.txt: Added. * http/tests/security/cross-origin-css-in-quirks-7.html: Added. * http/tests/security/cross-origin-css-in-quirks-8-expected.txt: Added. * http/tests/security/cross-origin-css-in-quirks-8.html: Added. * http/tests/security/same-origin-css-1-expected.txt: Added. * http/tests/security/same-origin-css-1.html: Added. * http/tests/security/same-origin-css-2-expected.txt: Added. * http/tests/security/same-origin-css-2.html: Added. * http/tests/security/same-origin-css-3-expected.txt: Added. * http/tests/security/same-origin-css-3.html: Added. * http/tests/security/same-origin-css-4-expected.txt: Added. * http/tests/security/same-origin-css-4.html: Added. * http/tests/security/same-origin-css-5-expected.txt: Added. * http/tests/security/same-origin-css-5.html: Added. * http/tests/security/same-origin-css-6-expected.txt: Added. * http/tests/security/same-origin-css-6.html:
[webkit-changes] [187486] trunk
Title: [187486] trunk
Revision 187486
Author a...@apple.com
Date 2015-07-28 09:29:44 -0700 (Tue, 28 Jul 2015)
Log Message
Rolling out r187463, because it caused memory corruption on multiple tests.
Original bug:
Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree
https://bugs.webkit.org/show_bug.cgi?id=147290
* svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt: Removed.
* svg/custom/remove-event-listener-shadow-disallowed-element.svg: Removed.
Source/WebCore:
* svg/SVGUseElement.cpp:
(WebCore::removeDisallowedElementsFromSubtree):
(WebCore::associateClonesWithOriginals):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp
Removed Paths
trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt
trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (187485 => 187486)
--- trunk/LayoutTests/ChangeLog 2015-07-28 10:03:13 UTC (rev 187485)
+++ trunk/LayoutTests/ChangeLog 2015-07-28 16:29:44 UTC (rev 187486)
@@ -1,3 +1,14 @@
+2015-07-28 Alexey Proskuryakov a...@apple.com
+
+Rolling out r187463, because it caused memory corruption on multiple tests.
+
+Original bug:
+Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree
+https://bugs.webkit.org/show_bug.cgi?id=147290
+
+* svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt: Removed.
+* svg/custom/remove-event-listener-shadow-disallowed-element.svg: Removed.
+
2015-07-27 Yusuke Suzuki utatane@gmail.com
SparseValueMap check is skipped when the butterfly's vectorLength is larger than the access-requested index
Deleted: trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt (187485 => 187486)
--- trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt 2015-07-28 10:03:13 UTC (rev 187485)
+++ trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt 2015-07-28 16:29:44 UTC (rev 187486)
@@ -1 +0,0 @@
-Pass.
Deleted: trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg (187485 => 187486)
--- trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg 2015-07-28 10:03:13 UTC (rev 187485)
+++ trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg 2015-07-28 16:29:44 UTC (rev 187486)
@@ -1,37 +0,0 @@
-svg version=1.1 xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
-
- defs
-svg id=green-svg width=100 height=100
- defs
- rect id=green-rect fill=green width=100 height=100/
- /defs
- use id=use-green-rect xlink:href=""
-/svg
- /defs
-
- use id=use-green-svg x=10 y=10 xlink:href=""
- textPass./text
-
- script
- if (window.testRunner)
- testRunner.dumpAsText();
-
-var _onAlert_ = function() {
- alert(test);
-}
-
-// This removeEventListener() has to be called before the onload fires. Before
-// onload fires, the shadow tree of the SVGUseElement is not built. So this
-// call should affect the original element only. Once the shadow tree is built,
-// the SVGUseElement calls updateShadowTree() and this is where we want to make
-// sure the eventListeners of all the cloned elements in the shadow tree are
-// updated correctly and the disallowed cloned elements and their descendants
-// are disconnected from their corresponding elements.
-document.getElementById(green-rect).addEventListener(click, onAlert);
-
-window.addEventListener(load, function () {
- document.getElementById(green-rect).removeEventListener(click, onAlert);
-}, false);
- /script
-
-/svg
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (187485 => 187486)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 10:03:13 UTC (rev 187485)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 16:29:44 UTC (rev 187486)
@@ -1,3 +1,18 @@
+2015-07-28 Alexey Proskuryakov a...@apple.com
+
+Rolling out r187463, because it caused memory corruption on multiple tests.
+
+Original bug:
+Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree
+https://bugs.webkit.org/show_bug.cgi?id=147290
+
+* svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt: Removed.
+* svg/custom/remove-event-listener-shadow-disallowed-element.svg: Removed.
+
+* svg/SVGUseElement.cpp:
+(WebCore::removeDisallowedElementsFromSubtree):
+(WebCore::associateClonesWithOriginals):
+
2015-07-28 Carlos Garcia Campos cgar...@igalia.com
[webkit-changes] [187487] trunk/Source/JavaScriptCore
Title: [187487] trunk/Source/_javascript_Core
Revision 187487
Author fpi...@apple.com
Date 2015-07-28 09:55:21 -0700 (Tue, 28 Jul 2015)
Log Message
DFG::safeToExecute() cases for GetByOffset/PutByOffset don't handle clobbered structure abstract values correctly
https://bugs.webkit.org/show_bug.cgi?id=147354
Reviewed by Michael Saboff.
If m_structure.isClobbered(), it means that we had a side effect that clobbered
the abstract value but it may recover back to its original value at the next
invalidation point. Since the invalidation point hasn't been reached yet, we need
to conservatively treat the clobbered state as if it was top. At the invalidation
point, the clobbered set will return back to being unclobbered.
In addition to fixing the bug, this introduces isInfinite(), which should be used
in places where it's tempting to just use isTop().
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute): Fix the bug.
* dfg/DFGStructureAbstractValue.cpp:
(JSC::DFG::StructureAbstractValue::contains): Switch to using isInfinite().
(JSC::DFG::StructureAbstractValue::isSubsetOf): Switch to using isInfinite().
(JSC::DFG::StructureAbstractValue::isSupersetOf): Switch to using isInfinite().
(JSC::DFG::StructureAbstractValue::overlaps): Switch to using isInfinite().
* dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::isFinite): New convenience method.
(JSC::DFG::StructureAbstractValue::isInfinite): New convenience method.
(JSC::DFG::StructureAbstractValue::onlyStructure): Switch to using isInfinite().
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h
trunk/Source/_javascript_Core/dfg/DFGStructureAbstractValue.cpp
trunk/Source/_javascript_Core/dfg/DFGStructureAbstractValue.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (187486 => 187487)
--- trunk/Source/_javascript_Core/ChangeLog 2015-07-28 16:29:44 UTC (rev 187486)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-07-28 16:55:21 UTC (rev 187487)
@@ -1,3 +1,31 @@
+2015-07-27 Filip Pizlo fpi...@apple.com
+
+DFG::safeToExecute() cases for GetByOffset/PutByOffset don't handle clobbered structure abstract values correctly
+https://bugs.webkit.org/show_bug.cgi?id=147354
+
+Reviewed by Michael Saboff.
+
+If m_structure.isClobbered(), it means that we had a side effect that clobbered
+the abstract value but it may recover back to its original value at the next
+invalidation point. Since the invalidation point hasn't been reached yet, we need
+to conservatively treat the clobbered state as if it was top. At the invalidation
+point, the clobbered set will return back to being unclobbered.
+
+In addition to fixing the bug, this introduces isInfinite(), which should be used
+in places where it's tempting to just use isTop().
+
+* dfg/DFGSafeToExecute.h:
+(JSC::DFG::safeToExecute): Fix the bug.
+* dfg/DFGStructureAbstractValue.cpp:
+(JSC::DFG::StructureAbstractValue::contains): Switch to using isInfinite().
+(JSC::DFG::StructureAbstractValue::isSubsetOf): Switch to using isInfinite().
+(JSC::DFG::StructureAbstractValue::isSupersetOf): Switch to using isInfinite().
+(JSC::DFG::StructureAbstractValue::overlaps): Switch to using isInfinite().
+* dfg/DFGStructureAbstractValue.h:
+(JSC::DFG::StructureAbstractValue::isFinite): New convenience method.
+(JSC::DFG::StructureAbstractValue::isInfinite): New convenience method.
+(JSC::DFG::StructureAbstractValue::onlyStructure): Switch to using isInfinite().
+
2015-07-27 Yusuke Suzuki utatane@gmail.com
[ES6] Implement Reflect.enumerate
Modified: trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h (187486 => 187487)
--- trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h 2015-07-28 16:29:44 UTC (rev 187486)
+++ trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h 2015-07-28 16:55:21 UTC (rev 187487)
@@ -329,7 +329,7 @@
case GetGetterSetterByOffset:
case PutByOffset: {
StructureAbstractValue value = state.forNode(node-child1()).m_structure;
-if (value.isTop())
+if (value.isInfinite())
return false;
PropertyOffset offset = node-storageAccessData().offset;
for (unsigned i = value.size(); i--;) {
Modified: trunk/Source/_javascript_Core/dfg/DFGStructureAbstractValue.cpp (187486 => 187487)
--- trunk/Source/_javascript_Core/dfg/DFGStructureAbstractValue.cpp 2015-07-28 16:29:44 UTC (rev 187486)
+++ trunk/Source/_javascript_Core/dfg/DFGStructureAbstractValue.cpp 2015-07-28 16:55:21 UTC (rev 187487)
@@ -289,7 +289,7 @@
{
SAMPLE(StructureAbstractValue contains);
-if (isTop() || isClobbered())
+if (isInfinite())
return true;
return m_set.contains(structure);
@@ -299,7 +299,7 @@
{
SAMPLE(StructureAbstractValue isSubsetOf set);
-if (isTop() ||
[webkit-changes] [187488] trunk/Source
Title: [187488] trunk/Source
Revision 187488
Author fpi...@apple.com
Date 2015-07-28 09:58:08 -0700 (Tue, 28 Jul 2015)
Log Message
Add logging when executable code gets deallocated
https://bugs.webkit.org/show_bug.cgi?id=147355
Reviewed by Mark Lam.
Source/_javascript_Core:
* ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::~JITCode): Print something when this is freed.
* jit/JITCode.cpp:
(JSC::JITCodeWithCodeRef::~JITCodeWithCodeRef): Print something when this is freed.
Source/WTF:
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorHandle::dump): It's useful to be able to dump these.
* wtf/MetaAllocatorHandle.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLJITCode.cpp
trunk/Source/_javascript_Core/jit/JITCode.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MetaAllocator.cpp
trunk/Source/WTF/wtf/MetaAllocatorHandle.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (187487 => 187488)
--- trunk/Source/_javascript_Core/ChangeLog 2015-07-28 16:55:21 UTC (rev 187487)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-07-28 16:58:08 UTC (rev 187488)
@@ -1,5 +1,17 @@
2015-07-27 Filip Pizlo fpi...@apple.com
+Add logging when executable code gets deallocated
+https://bugs.webkit.org/show_bug.cgi?id=147355
+
+Reviewed by Mark Lam.
+
+* ftl/FTLJITCode.cpp:
+(JSC::FTL::JITCode::~JITCode): Print something when this is freed.
+* jit/JITCode.cpp:
+(JSC::JITCodeWithCodeRef::~JITCodeWithCodeRef): Print something when this is freed.
+
+2015-07-27 Filip Pizlo fpi...@apple.com
+
DFG::safeToExecute() cases for GetByOffset/PutByOffset don't handle clobbered structure abstract values correctly
https://bugs.webkit.org/show_bug.cgi?id=147354
Modified: trunk/Source/_javascript_Core/ftl/FTLJITCode.cpp (187487 => 187488)
--- trunk/Source/_javascript_Core/ftl/FTLJITCode.cpp 2015-07-28 16:55:21 UTC (rev 187487)
+++ trunk/Source/_javascript_Core/ftl/FTLJITCode.cpp 2015-07-28 16:58:08 UTC (rev 187488)
@@ -28,6 +28,8 @@
#if ENABLE(FTL_JIT)
+#include FTLState.h
+
namespace JSC { namespace FTL {
JITCode::JITCode()
@@ -37,6 +39,15 @@
JITCode::~JITCode()
{
+if (FTL::shouldShowDisassembly()) {
+dataLog(Destroying FTL JIT code at );
+CommaPrinter comma;
+for (auto handle : m_handles)
+dataLog(comma, pointerDump(handle.get()));
+dataLog(comma, pointerDump(m_arityCheckEntrypoint.executableMemory()));
+dataLog(comma, pointerDump(m_exitThunks.executableMemory()));
+dataLog(\n);
+}
}
void JITCode::initializeExitThunks(CodeRef exitThunks)
Modified: trunk/Source/_javascript_Core/jit/JITCode.cpp (187487 => 187488)
--- trunk/Source/_javascript_Core/jit/JITCode.cpp 2015-07-28 16:55:21 UTC (rev 187487)
+++ trunk/Source/_javascript_Core/jit/JITCode.cpp 2015-07-28 16:58:08 UTC (rev 187488)
@@ -119,6 +119,9 @@
JITCodeWithCodeRef::~JITCodeWithCodeRef()
{
+if ((Options::showDisassembly() || (isOptimizingJIT(jitType()) Options::showDFGDisassembly()))
+ m_ref.executableMemory())
+dataLog(Destroying JIT code at , pointerDump(m_ref.executableMemory()), \n);
}
void* JITCodeWithCodeRef::executableAddressAtOffset(size_t offset)
Modified: trunk/Source/WTF/ChangeLog (187487 => 187488)
--- trunk/Source/WTF/ChangeLog 2015-07-28 16:55:21 UTC (rev 187487)
+++ trunk/Source/WTF/ChangeLog 2015-07-28 16:58:08 UTC (rev 187488)
@@ -1,3 +1,14 @@
+2015-07-27 Filip Pizlo fpi...@apple.com
+
+Add logging when executable code gets deallocated
+https://bugs.webkit.org/show_bug.cgi?id=147355
+
+Reviewed by Mark Lam.
+
+* wtf/MetaAllocator.cpp:
+(WTF::MetaAllocatorHandle::dump): It's useful to be able to dump these.
+* wtf/MetaAllocatorHandle.h:
+
2015-07-28 Benjamin Poulain bpoul...@apple.com
Speed up StringBuilder::appendQuotedJSONString()
Modified: trunk/Source/WTF/wtf/MetaAllocator.cpp (187487 => 187488)
--- trunk/Source/WTF/wtf/MetaAllocator.cpp 2015-07-28 16:55:21 UTC (rev 187487)
+++ trunk/Source/WTF/wtf/MetaAllocator.cpp 2015-07-28 16:58:08 UTC (rev 187488)
@@ -113,6 +113,11 @@
m_sizeInBytes = newSizeInBytes;
}
+void MetaAllocatorHandle::dump(PrintStream out) const
+{
+out.print(RawPointer(start()), ..., RawPointer(end()));
+}
+
MetaAllocator::MetaAllocator(size_t allocationGranule, size_t pageSize)
: m_allocationGranule(allocationGranule)
, m_pageSize(pageSize)
Modified: trunk/Source/WTF/wtf/MetaAllocatorHandle.h (187487 => 187488)
--- trunk/Source/WTF/wtf/MetaAllocatorHandle.h 2015-07-28 16:55:21 UTC (rev 187487)
+++ trunk/Source/WTF/wtf/MetaAllocatorHandle.h 2015-07-28 16:58:08 UTC (rev 187488)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2011, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2011, 2013, 2015 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
*
[webkit-changes] [187492] trunk/Source
Title: [187492] trunk/Source
Revision 187492
Author simon.fra...@apple.com
Date 2015-07-28 11:22:00 -0700 (Tue, 28 Jul 2015)
Log Message
PathApplierFunction should take a reference to a PathElement
https://bugs.webkit.org/show_bug.cgi?id=147337
Reviewed by Dan Bates.
Convert PathApplierFunction to take a const PathElement, since it can never be null.
Source/WebCore:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(ConvertPathToScreenSpaceFunction):
* inspector/InspectorOverlay.cpp:
(WebCore::appendPathSegment):
* platform/graphics/Path.cpp:
(WebCore::pathLengthApplierFunction):
* platform/graphics/Path.h:
* platform/graphics/PathTraversalState.h:
(WebCore::PathTraversalState::processPathElement):
* platform/graphics/cg/PathCG.cpp:
(WebCore::CGPathApplierToPathApplier):
* rendering/svg/SVGMarkerData.h:
(WebCore::SVGMarkerData::updateFromPathElement):
(WebCore::SVGMarkerData::updateMarkerDataForPathElement):
* rendering/svg/SVGSubpathData.h:
(WebCore::SVGSubpathData::updateFromPathElement):
* svg/SVGPathUtilities.cpp:
(WebCore::pathIteratorForBuildingString):
Source/WebKit2:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::pathPointCountApplierFunction):
(IPC::pathEncodeApplierFunction):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
trunk/Source/WebCore/inspector/InspectorOverlay.cpp
trunk/Source/WebCore/platform/graphics/Path.cpp
trunk/Source/WebCore/platform/graphics/Path.h
trunk/Source/WebCore/platform/graphics/PathTraversalState.h
trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp
trunk/Source/WebCore/rendering/svg/SVGMarkerData.h
trunk/Source/WebCore/rendering/svg/SVGSubpathData.h
trunk/Source/WebCore/svg/SVGPathUtilities.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187491 => 187492)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 18:20:50 UTC (rev 187491)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 18:22:00 UTC (rev 187492)
@@ -1,3 +1,31 @@
+2015-07-27 Simon Fraser simon.fra...@apple.com
+
+PathApplierFunction should take a reference to a PathElement
+https://bugs.webkit.org/show_bug.cgi?id=147337
+
+Reviewed by Dan Bates.
+
+Convert PathApplierFunction to take a const PathElement, since it can never be null.
+
+* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
+(ConvertPathToScreenSpaceFunction):
+* inspector/InspectorOverlay.cpp:
+(WebCore::appendPathSegment):
+* platform/graphics/Path.cpp:
+(WebCore::pathLengthApplierFunction):
+* platform/graphics/Path.h:
+* platform/graphics/PathTraversalState.h:
+(WebCore::PathTraversalState::processPathElement):
+* platform/graphics/cg/PathCG.cpp:
+(WebCore::CGPathApplierToPathApplier):
+* rendering/svg/SVGMarkerData.h:
+(WebCore::SVGMarkerData::updateFromPathElement):
+(WebCore::SVGMarkerData::updateMarkerDataForPathElement):
+* rendering/svg/SVGSubpathData.h:
+(WebCore::SVGSubpathData::updateFromPathElement):
+* svg/SVGPathUtilities.cpp:
+(WebCore::pathIteratorForBuildingString):
+
2015-07-28 Jer Noble jer.no...@apple.com
[iOS] Notify fullscreen controller in UIProcess whether external playback is allowed
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm (187491 => 187492)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm 2015-07-28 18:20:50 UTC (rev 187491)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm 2015-07-28 18:22:00 UTC (rev 187492)
@@ -247,36 +247,36 @@
CGMutablePathRef path;
};
-static void ConvertPathToScreenSpaceFunction(void* info, const PathElement* element)
+static void ConvertPathToScreenSpaceFunction(void* info, const PathElement element)
{
PathConversionInfo* conversion = (PathConversionInfo*)info;
WebAccessibilityObjectWrapperBase *wrapper = conversion-wrapper;
CGMutablePathRef newPath = conversion-path;
-switch (element-type) {
+switch (element.type) {
case PathElementMoveToPoint:
{
-CGPoint newPoint = [wrapper convertPointToScreenSpace:element-points[0]];
+CGPoint newPoint = [wrapper convertPointToScreenSpace:element.points[0]];
CGPathMoveToPoint(newPath, nil, newPoint.x, newPoint.y);
break;
}
case PathElementAddLineToPoint:
{
-CGPoint newPoint = [wrapper convertPointToScreenSpace:element-points[0]];
+CGPoint newPoint = [wrapper convertPointToScreenSpace:element.points[0]];
CGPathAddLineToPoint(newPath, nil, newPoint.x, newPoint.y);
break;
}
case PathElementAddQuadCurveToPoint:
{
-CGPoint newPoint1 = [wrapper
[webkit-changes] [187494] trunk/Source/WebCore
Title: [187494] trunk/Source/WebCore
Revision 187494
Author timothy_hor...@apple.com
Date 2015-07-28 11:26:25 -0700 (Tue, 28 Jul 2015)
Log Message
Remove some more bits of WebTiledLayer
https://bugs.webkit.org/show_bug.cgi?id=147356
Reviewed by Simon Fraser.
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::setContentsScale): Deleted.
(PlatformCALayer::setTileSize): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (187493 => 187494)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 18:22:53 UTC (rev 187493)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 18:26:25 UTC (rev 187494)
@@ -1,3 +1,15 @@
+2015-07-28 Tim Horton timothy_hor...@apple.com
+
+Remove some more bits of WebTiledLayer
+https://bugs.webkit.org/show_bug.cgi?id=147356
+
+Reviewed by Simon Fraser.
+
+* platform/graphics/ca/PlatformCALayer.h:
+* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
+(PlatformCALayerCocoa::setContentsScale): Deleted.
+(PlatformCALayer::setTileSize): Deleted.
+
2015-07-28 Simon Fraser simon.fra...@apple.com
Change markContainingBlocksForLayout() to take an enum, rather than a bool
Modified: trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h (187493 => 187494)
--- trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2015-07-28 18:22:53 UTC (rev 187493)
+++ trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2015-07-28 18:26:25 UTC (rev 187494)
@@ -243,7 +243,6 @@
void setBoundsOnMainThread(CGRect);
void setPositionOnMainThread(CGPoint);
void setAnchorPointOnMainThread(FloatPoint3D);
-void setTileSize(const IntSize);
#endif
virtual PassRefPtrPlatformCALayer createCompatibleLayer(LayerType, PlatformCALayerClient*) const = 0;
Modified: trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm (187493 => 187494)
--- trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm 2015-07-28 18:22:53 UTC (rev 187493)
+++ trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm 2015-07-28 18:26:25 UTC (rev 187494)
@@ -825,13 +825,6 @@
[m_layer setContentsScale:value];
#if PLATFORM(IOS)
[m_layer setRasterizationScale:value];
-
-if (m_layerType == LayerTypeWebTiledLayer) {
-// This will invalidate all the tiles so we won't end up with stale tiles with the wrong scale in the wrong place,
-// see rdar://problem/9434765 for more information.
-static NSDictionary *optionsDictionary = [[NSDictionary alloc] initWithObjectsAndKeys:[NSNumber numberWithBool:YES], kCATiledLayerRemoveImmediately, nil];
-[(CATiledLayer *)m_layer.get() setNeedsDisplayInRect:[m_layer bounds] levelOfDetail:0 options:optionsDictionary];
-}
#endif
END_BLOCK_OBJC_EXCEPTIONS
}
@@ -998,12 +991,6 @@
END_BLOCK_OBJC_EXCEPTIONS
});
}
-
-void PlatformCALayer::setTileSize(const IntSize)
-{
-if (m_layerType != LayerTypeWebTiledLayer)
-return;
-}
#endif // PLATFORM(IOS)
PlatformCALayer::RepaintRectList PlatformCALayer::collectRectsToPaint(CGContextRef context, PlatformCALayer* platformCALayer)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187490] trunk/Source/WebCore
Title: [187490] trunk/Source/WebCore
Revision 187490
Author beid...@apple.com
Date 2015-07-28 11:11:59 -0700 (Tue, 28 Jul 2015)
Log Message
Handle null CFArrayRef returning from _CFHTTPParsedCookiesWithResponseHeaderFields.
rdar://problem/21995928 and https://bugs.webkit.org/show_bug.cgi?id=147365
Reviewed by Alexey Proskuryakov.
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::filterCookies): ASSERT the input is not null.
(WebCore::createCookies): Always return a CFArrayRef, even if it's empty.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187489 => 187490)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 17:24:26 UTC (rev 187489)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 18:11:59 UTC (rev 187490)
@@ -1,3 +1,14 @@
+2015-07-28 Brady Eidson beid...@apple.com
+
+Handle null CFArrayRef returning from _CFHTTPParsedCookiesWithResponseHeaderFields.
+rdar://problem/21995928 and https://bugs.webkit.org/show_bug.cgi?id=147365
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/network/cf/CookieJarCFNet.cpp:
+(WebCore::filterCookies): ASSERT the input is not null.
+(WebCore::createCookies): Always return a CFArrayRef, even if it's empty.
+
2015-07-28 Chris Dumez cdu...@apple.com
Allow lax MIME type parsing for same-origin CSS in quirks mode.
Modified: trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp (187489 => 187490)
--- trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-28 17:24:26 UTC (rev 187489)
+++ trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-28 18:11:59 UTC (rev 187490)
@@ -80,6 +80,7 @@
static RetainPtrCFArrayRef filterCookies(CFArrayRef unfilteredCookies)
{
+ASSERT(unfilteredCookies);
CFIndex count = CFArrayGetCount(unfilteredCookies);
RetainPtrCFMutableArrayRef filteredCookies = adoptCF(CFArrayCreateMutable(0, count, kCFTypeArrayCallBacks));
for (CFIndex i = 0; i count; ++i) {
@@ -116,10 +117,14 @@
static CFArrayRef createCookies(CFDictionaryRef headerFields, CFURLRef url)
{
#if (PLATFORM(IOS) __IPHONE_OS_VERSION_MIN_REQUIRED = 9)
-return _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
+CFArrayRef parsedCookies = _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
#else
-return CFHTTPCookieCreateWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
+CFArrayRef parsedCookies = CFHTTPCookieCreateWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
#endif
+if (!parsedCookies)
+parsedCookies = CFArrayCreate(kCFAllocatorDefault, 0, 0, kCFTypeArrayCallBacks);
+
+return parsedCookies;
}
void setCookiesFromDOM(const NetworkStorageSession session, const URL firstParty, const URL url, const String value)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187497] trunk/Source/JavaScriptCore
Title: [187497] trunk/Source/_javascript_Core
Revision 187497
Author basile_clem...@apple.com
Date 2015-07-28 11:51:27 -0700 (Tue, 28 Jul 2015)
Log Message
stress/math-pow-with-constants.js fails in cloop
https://bugs.webkit.org/show_bug.cgi?id=147167
Reviewed by Geoffrey Garen.
Baseline JIT, DFG and FTL are using a fast exponentiation fast path
when computing Math.pow() with an integer exponent that is not taken in
the LLInt (or the DFG abstract interpreter). This leads to the result
of pow changing depending on the compilation tier or the fact that
constant propagation kicks in, which is undesirable.
This patch adds the fast path to the slow operationMathPow in order to
maintain an illusion of consistency.
* runtime/MathCommon.cpp:
(JSC::operationMathPow):
* tests/stress/math-pow-coherency.js: Added.
(pow42):
(build42AsDouble.opaqueAdd):
(build42AsDouble):
(powDouble42):
(clobber):
(pow42NoConstantFolding):
(powDouble42NoConstantFolding):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/MathCommon.cpp
Added Paths
trunk/Source/_javascript_Core/tests/stress/math-pow-coherency.js
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (187496 => 187497)
--- trunk/Source/_javascript_Core/ChangeLog 2015-07-28 18:47:14 UTC (rev 187496)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-07-28 18:51:27 UTC (rev 187497)
@@ -1,3 +1,30 @@
+2015-07-28 Basile Clement basile_clem...@apple.com
+
+stress/math-pow-with-constants.js fails in cloop
+https://bugs.webkit.org/show_bug.cgi?id=147167
+
+Reviewed by Geoffrey Garen.
+
+Baseline JIT, DFG and FTL are using a fast exponentiation fast path
+when computing Math.pow() with an integer exponent that is not taken in
+the LLInt (or the DFG abstract interpreter). This leads to the result
+of pow changing depending on the compilation tier or the fact that
+constant propagation kicks in, which is undesirable.
+
+This patch adds the fast path to the slow operationMathPow in order to
+maintain an illusion of consistency.
+
+* runtime/MathCommon.cpp:
+(JSC::operationMathPow):
+* tests/stress/math-pow-coherency.js: Added.
+(pow42):
+(build42AsDouble.opaqueAdd):
+(build42AsDouble):
+(powDouble42):
+(clobber):
+(pow42NoConstantFolding):
+(powDouble42NoConstantFolding):
+
2015-07-28 Joseph Pecoraro pecor...@apple.com
Web Inspector: Show Pseudo Elements in DOM Tree
Modified: trunk/Source/_javascript_Core/runtime/MathCommon.cpp (187496 => 187497)
--- trunk/Source/_javascript_Core/runtime/MathCommon.cpp 2015-07-28 18:47:14 UTC (rev 187496)
+++ trunk/Source/_javascript_Core/runtime/MathCommon.cpp 2015-07-28 18:51:27 UTC (rev 187497)
@@ -417,7 +417,19 @@
return PNaN;
if (std::isinf(y) fabs(x) == 1)
return PNaN;
-return mathPowInternal(x, y);
+int32_t yAsInt = y;
+if (static_castdouble(yAsInt) != y || yAsInt 0)
+return mathPowInternal(x, y);
+
+// If the exponent is a positive int32 integer, we do a fast exponentiation
+double result = 1;
+while (yAsInt) {
+if (yAsInt 1)
+result *= x;
+x *= x;
+yAsInt = 1;
+}
+return result;
}
extern C {
Added: trunk/Source/_javascript_Core/tests/stress/math-pow-coherency.js (0 => 187497)
--- trunk/Source/_javascript_Core/tests/stress/math-pow-coherency.js (rev 0)
+++ trunk/Source/_javascript_Core/tests/stress/math-pow-coherency.js 2015-07-28 18:51:27 UTC (rev 187497)
@@ -0,0 +1,93 @@
+// This test checks that the pow function returns coherent results:
+// (a) Across different compilation tiers
+// (b) With integer exponents represented as int32 or as double
+
+function pow42() {
+return { value: Math.pow(2.1, 42), ftl: isFinalTier() };
+}
+
+function build42AsDouble() {
+function opaqueAdd(x, y) { return x + y; }
+return opaqueAdd(42 - 0.123, 0.123);
+}
+
+var double42 = build42AsDouble();
+
+if (double42 !== 42)
+throw new Error(42 (as double) should be === to 42 (as int));
+
+function powDouble42() {
+return { value: Math.pow(2.1, double42), ftl: isFinalTier() };
+}
+
+function clobber() { }
+noInline(clobber);
+
+function pow42NoConstantFolding() {
+var obj = { x: 2.1, y: 42 };
+clobber(obj);
+return { value: Math.pow(obj.x, obj.y), ftl: isFinalTier() };
+}
+
+function powDouble42NoConstantFolding() {
+var obj = { x: 2.1, y: double42 };
+clobber(obj);
+return { value: Math.pow(obj.x, obj.y), ftl: isFinalTier() };
+}
+
+var results = { 'jit': {}, 'dfg': {}, 'ftl': {} };
+var funs = [
+[ 'pow42', pow42 ],
+[ 'powDouble42', powDouble42 ],
+[ 'pow42NoConstantFolding', pow42NoConstantFolding ],
+[ 'powDouble42NoConstantFolding', powDouble42NoConstantFolding ]
+];
+var tiers = ['jit', 'dfg', 'ftl'];
+
+for (var i = 0; i
[webkit-changes] [187495] trunk/Source/WTF
Title: [187495] trunk/Source/WTF Revision 187495 Author fpi...@apple.com Date 2015-07-28 11:42:44 -0700 (Tue, 28 Jul 2015) Log Message Unreviewed, fix Windows build. * wtf/MetaAllocatorHandle.h: (WTF::MetaAllocatorHandle::key): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/MetaAllocatorHandle.h Diff Modified: trunk/Source/WTF/ChangeLog (187494 => 187495) --- trunk/Source/WTF/ChangeLog 2015-07-28 18:26:25 UTC (rev 187494) +++ trunk/Source/WTF/ChangeLog 2015-07-28 18:42:44 UTC (rev 187495) @@ -1,3 +1,10 @@ +2015-07-28 Filip Pizlo fpi...@apple.com + +Unreviewed, fix Windows build. + +* wtf/MetaAllocatorHandle.h: +(WTF::MetaAllocatorHandle::key): + 2015-07-27 Filip Pizlo fpi...@apple.com Add logging when executable code gets deallocated Modified: trunk/Source/WTF/wtf/MetaAllocatorHandle.h (187494 => 187495) --- trunk/Source/WTF/wtf/MetaAllocatorHandle.h 2015-07-28 18:26:25 UTC (rev 187494) +++ trunk/Source/WTF/wtf/MetaAllocatorHandle.h 2015-07-28 18:42:44 UTC (rev 187495) @@ -104,7 +104,7 @@ return m_start; } -void dump(PrintStream out) const; +WTF_EXPORT_PRIVATE void dump(PrintStream out) const; private: friend class MetaAllocator; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187491] trunk/Source
Title: [187491] trunk/Source Revision 187491 Author jer.no...@apple.com Date 2015-07-28 11:20:50 -0700 (Tue, 28 Jul 2015) Log Message [iOS] Notify fullscreen controller in UIProcess whether external playback is allowed https://bugs.webkit.org/show_bug.cgi?id=147343 Reviewed by Brady Eidson. Source/WebCore: Pass the value of the MediaElementSession's wirelessVideoPlaybackDisabled() property up through WebKit2 to WebVideoFullscreenControllerAVKit. * platform/ios/WebVideoFullscreenControllerAVKit.mm: (WebVideoFullscreenControllerContext::setWirelessVideoPlaybackDisabled): Pass to the interface on the main thread. * platform/ios/WebVideoFullscreenInterface.h: * platform/ios/WebVideoFullscreenInterfaceAVKit.h: * platform/ios/WebVideoFullscreenInterfaceAVKit.mm: (WebVideoFullscreenInterfaceAVKit::setWirelessVideoPlaybackDisabled): Sets .allowsExternalPlayback to !disabled. (WebVideoFullscreenInterfaceAVKit::wirelessVideoPlaybackDisabled): Returns the last value set. * platform/ios/WebVideoFullscreenModelVideoElement.mm: (WebVideoFullscreenModelVideoElement::setWebVideoFullscreenInterface): Update the value of wirelessVideoPlaybackDisabled if the element is present. (WebVideoFullscreenModelVideoElement::setVideoElement): Ditto if the interface is present. (WebVideoFullscreenModelVideoElement::updateForEventName): Update the value either way. Source/WebKit2: Pass the boolean property wirelessVideoPlaybackDisabled across the UIProcess/WebProcess boundary. * UIProcess/ios/WebVideoFullscreenManagerProxy.mm: (WebKit::WebVideoFullscreenManagerProxy::setWirelessVideoPlaybackDisabled): * WebProcess/ios/WebVideoFullscreenManager.mm: (WebKit::WebVideoFullscreenInterfaceContext::setWirelessVideoPlaybackDisabled): (WebKit::WebVideoFullscreenManager::WebVideoFullscreenManager): (WebKit::WebVideoFullscreenManager::setWirelessVideoPlaybackDisabled): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterface.h trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm trunk/Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm trunk/Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.h trunk/Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.mm Diff Modified: trunk/Source/WebCore/ChangeLog (187490 => 187491) --- trunk/Source/WebCore/ChangeLog 2015-07-28 18:11:59 UTC (rev 187490) +++ trunk/Source/WebCore/ChangeLog 2015-07-28 18:20:50 UTC (rev 187491) @@ -1,3 +1,26 @@ +2015-07-28 Jer Noble jer.no...@apple.com + +[iOS] Notify fullscreen controller in UIProcess whether external playback is allowed +https://bugs.webkit.org/show_bug.cgi?id=147343 + +Reviewed by Brady Eidson. + +Pass the value of the MediaElementSession's wirelessVideoPlaybackDisabled() property up through WebKit2 to +WebVideoFullscreenControllerAVKit. + +* platform/ios/WebVideoFullscreenControllerAVKit.mm: +(WebVideoFullscreenControllerContext::setWirelessVideoPlaybackDisabled): Pass to the interface on the main thread. +* platform/ios/WebVideoFullscreenInterface.h: +* platform/ios/WebVideoFullscreenInterfaceAVKit.h: +* platform/ios/WebVideoFullscreenInterfaceAVKit.mm: +(WebVideoFullscreenInterfaceAVKit::setWirelessVideoPlaybackDisabled): Sets .allowsExternalPlayback to !disabled. +(WebVideoFullscreenInterfaceAVKit::wirelessVideoPlaybackDisabled): Returns the last value set. +* platform/ios/WebVideoFullscreenModelVideoElement.mm: +(WebVideoFullscreenModelVideoElement::setWebVideoFullscreenInterface): Update the value of wirelessVideoPlaybackDisabled +if the element is present. +(WebVideoFullscreenModelVideoElement::setVideoElement): Ditto if the interface is present. +(WebVideoFullscreenModelVideoElement::updateForEventName): Update the value either way. + 2015-07-28 Brady Eidson beid...@apple.com Handle null CFArrayRef returning from _CFHTTPParsedCookiesWithResponseHeaderFields. Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm (187490 => 187491) --- trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm 2015-07-28 18:11:59 UTC (rev 187490) +++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm 2015-07-28 18:20:50 UTC (rev 187491) @@ -130,7 +130,8 @@ virtual void setAudioMediaSelectionOptions(const VectorString options, uint64_t selectedIndex) override; virtual void setLegibleMediaSelectionOptions(const VectorString options, uint64_t
[webkit-changes] [187493] trunk/Source/WebCore
Title: [187493] trunk/Source/WebCore
Revision 187493
Author simon.fra...@apple.com
Date 2015-07-28 11:22:53 -0700 (Tue, 28 Jul 2015)
Log Message
Change markContainingBlocksForLayout() to take an enum, rather than a bool
https://bugs.webkit.org/show_bug.cgi?id=147345
Reviewed by Daniel Bates.
Change markContainingBlocksForLayout to take an enum class for the scheduleRelayout
argument, for better code readability.
* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):
* rendering/RenderObject.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (187492 => 187493)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 18:22:00 UTC (rev 187492)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 18:22:53 UTC (rev 187493)
@@ -1,3 +1,21 @@
+2015-07-28 Simon Fraser simon.fra...@apple.com
+
+Change markContainingBlocksForLayout() to take an enum, rather than a bool
+https://bugs.webkit.org/show_bug.cgi?id=147345
+
+Reviewed by Daniel Bates.
+
+Change markContainingBlocksForLayout to take an enum class for the scheduleRelayout
+argument, for better code readability.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::layout):
+(WebCore::FrameView::scheduleRelayout):
+(WebCore::FrameView::scheduleRelayoutOfSubtree):
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::markContainingBlocksForLayout):
+* rendering/RenderObject.h:
+
2015-07-27 Simon Fraser simon.fra...@apple.com
PathApplierFunction should take a reference to a PathElement
Modified: trunk/Source/WebCore/page/FrameView.cpp (187492 => 187493)
--- trunk/Source/WebCore/page/FrameView.cpp 2015-07-28 18:22:00 UTC (rev 187492)
+++ trunk/Source/WebCore/page/FrameView.cpp 2015-07-28 18:22:53 UTC (rev 187493)
@@ -1213,7 +1213,7 @@
AnimationUpdateBlock animationUpdateBlock(frame().animation());
if (!allowSubtree m_layoutRoot) {
-m_layoutRoot-markContainingBlocksForLayout(false);
+m_layoutRoot-markContainingBlocksForLayout(ScheduleRelayout::No);
m_layoutRoot = nullptr;
}
@@ -2550,7 +2550,7 @@
ASSERT(frame().view() == this);
if (m_layoutRoot) {
-m_layoutRoot-markContainingBlocksForLayout(false);
+m_layoutRoot-markContainingBlocksForLayout(ScheduleRelayout::No);
m_layoutRoot = nullptr;
}
if (!m_layoutSchedulingEnabled)
@@ -2600,7 +2600,7 @@
ASSERT(frame().view() == this);
if (renderView.needsLayout()) {
-newRelayoutRoot.markContainingBlocksForLayout(false);
+newRelayoutRoot.markContainingBlocksForLayout(ScheduleRelayout::No);
return;
}
@@ -2619,21 +2619,21 @@
if (!m_layoutRoot) {
// Just relayout the subtree.
-newRelayoutRoot.markContainingBlocksForLayout(false);
+newRelayoutRoot.markContainingBlocksForLayout(ScheduleRelayout::No);
InspectorInstrumentation::didInvalidateLayout(frame());
return;
}
if (isObjectAncestorContainerOf(m_layoutRoot, newRelayoutRoot)) {
// Keep the current root.
-newRelayoutRoot.markContainingBlocksForLayout(false, m_layoutRoot);
+newRelayoutRoot.markContainingBlocksForLayout(ScheduleRelayout::No, m_layoutRoot);
ASSERT(!m_layoutRoot-container() || !m_layoutRoot-container()-needsLayout());
return;
}
if (isObjectAncestorContainerOf(newRelayoutRoot, m_layoutRoot)) {
// Re-root at newRelayoutRoot.
-m_layoutRoot-markContainingBlocksForLayout(false, newRelayoutRoot);
+m_layoutRoot-markContainingBlocksForLayout(ScheduleRelayout::No, newRelayoutRoot);
m_layoutRoot = newRelayoutRoot;
ASSERT(!m_layoutRoot-container() || !m_layoutRoot-container()-needsLayout());
InspectorInstrumentation::didInvalidateLayout(frame());
@@ -2641,9 +2641,9 @@
}
// Just do a full relayout.
-m_layoutRoot-markContainingBlocksForLayout(false);
+m_layoutRoot-markContainingBlocksForLayout(ScheduleRelayout::No);
m_layoutRoot = nullptr;
-newRelayoutRoot.markContainingBlocksForLayout(false);
+newRelayoutRoot.markContainingBlocksForLayout(ScheduleRelayout::No);
InspectorInstrumentation::didInvalidateLayout(frame());
}
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (187492 => 187493)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2015-07-28 18:22:00 UTC (rev 187492)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2015-07-28 18:22:53 UTC (rev 187493)
@@ -580,9 +580,9 @@
downcastRenderView(renderer).frameView().scheduleRelayout();
}
-void
[webkit-changes] [187496] trunk
Title: [187496] trunk Revision 187496 Author commit-qu...@webkit.org Date 2015-07-28 11:47:14 -0700 (Tue, 28 Jul 2015) Log Message Web Inspector: Show Pseudo Elements in DOM Tree https://bugs.webkit.org/show_bug.cgi?id=139612 Patch by Joseph Pecoraro pecor...@apple.com on 2015-07-28 Reviewed by Timothy Hatcher. Source/_javascript_Core: * inspector/protocol/DOM.json: Add new properties to DOMNode if it is a pseudo element or if it has pseudo element children. Add new events for if a pseudo element is added or removed dynamically to an existing DOMNode. Source/WebCore: Tests: inspector/css/pseudo-element-matches-for-pseudo-element-node.html inspector/dom/pseudo-element-dynamic.html inspector/dom/pseudo-element-static.html Much of this patch was modelled after the Blink implementation of pseudo element inspection. * dom/PseudoElement.h: * dom/PseudoElement.cpp: (WebCore::PseudoElement::~PseudoElement): (WebCore::PseudoElement::clearHostElement): Since InspectorDOMAgent may hold a reference to this PseudoElement we can't report it as destroyed in the destructor, as that wouldn't be reached if the inspector holds a reference. Move this to when the psuedo element is disconnected, which is immediately before destruction. * inspector/InspectorCSSAgent.h: * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getMatchedStylesForNode): When computing styles for a pseudo element, compute styles from the host element for just the pseudo element's pseudo type. Likewise only include matched results, not inherited or others. (WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList): Add the pseudo type to the checker context to try and detect exactly which selector in a list of selectors matched the pseudo element. * inspector/InspectorDOMAgent.h: * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::unbind): When unbinding an element, also unbind any pseudo element children it may have had and bound. (WebCore::InspectorDOMAgent::assertEditableNode): (WebCore::InspectorDOMAgent::assertEditableElement): (WebCore::InspectorDOMAgent::removeNode): Improve grammar in error message. Don't allow editing pseudo elements. (WebCore::pseudoElementType): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements): If a node is a pseudo element include its pseudoType. If a node has pseudo element children include them. (WebCore::InspectorDOMAgent::pseudoElementCreated): (WebCore::InspectorDOMAgent::pseudoElementDestroyed): When pseudo elements are dynamically created or destroyed push pseudo element nodes to the frontend if needed. * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::pseudoElementCreatedImpl): (WebCore::InspectorInstrumentation::pseudoElementDestroyedImpl): * inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::pseudoElementCreated): (WebCore::InspectorInstrumentation::pseudoElementDestroyed): (WebCore::InspectorInstrumentation::layerTreeDidChange): (WebCore::InspectorInstrumentation::renderLayerDestroyed): Plumbing for pseudo element created/destroyed events. * style/StyleResolveTree.cpp: (WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded): This is the only place a pseudo element is created, inform the inspector. * inspector/InspectorOverlay.cpp: (WebCore::buildObjectForElementData): Update the element data for the node highlight label to include the host element's selector and the pseudo element selector. Source/WebInspectorUI: * UserInterface/Controllers/DOMTreeManager.js: (WebInspector.DOMTreeManager.prototype._pseudoElementAdded): Hook up the new pseudo element DOMNode to the parent. (WebInspector.DOMTreeManager.prototype._pseudoElementRemoved): Unhook the pseudo element from its parent. (WebInspector.DOMTreeManager.prototype._unbind): When unbinding, unbind any pseudo element children we may have had. * UserInterface/Models/DOMNode.js: (WebInspector.DOMNode.prototype.isPseudoElement): (WebInspector.DOMNode.prototype.pseudoType): (WebInspector.DOMNode.prototype.hasPseudoElements): (WebInspector.DOMNode.prototype.pseudoElements): New state of a DOMNode may include pseudo elements. (WebInspector.DOMNode.prototype.appropriateSelectorFor): A selector for this node includes the selector for the node above it. * UserInterface/Protocol/DOMObserver.js: (WebInspector.DOMObserver.prototype.pseudoElementAdded): (WebInspector.DOMObserver.prototype.pseudoElementRemoved): Pass the message on to DOMTreeManager. * UserInterface/Views/DOMTreeElement.js: (WebInspector.DOMTreeElement.prototype.get editable): Pseudo element nodes are not editable. (WebInspector.DOMTreeElement.prototype.showChildNode): (WebInspector.DOMTreeElement.prototype.onpopulate): (WebInspector.DOMTreeElement.prototype.updateChildren): (WebInspector.DOMTreeElement.prototype._nodeTitleInfo): (WebInspector.DOMTreeElement.prototype._singleTextChild):
[webkit-changes] [187505] trunk/Source/JavaScriptCore
Title: [187505] trunk/Source/_javascript_Core Revision 187505 Author basile_clem...@apple.com Date 2015-07-28 13:12:33 -0700 (Tue, 28 Jul 2015) Log Message Simplify call linking https://bugs.webkit.org/show_bug.cgi?id=147363 Reviewed by Filip Pizlo. Previously, we were passing both the CallLinkInfo and a (CodeSpecializationKind, RegisterPreservationMode) pair to the different call linking slow paths. However, the CallLinkInfo already has all of that information, and we don't gain anything by having them in additional static parameters - except possibly a very small performance gain in presence of inlining. However since those are already slow paths, this performance loss (if it exists) will not be visible in practice. This patch removes the various specialized thunks and JIT operations for regular and polymorphic call linking with a single thunk and operation for each case. Moreover, it removes the four specialized virtual call thunks and operations with one virtual call thunk for each call link info, allowing for better branch prediction by the CPU and fixing a pre-existing FIXME. * bytecode/CallLinkInfo.cpp: (JSC::CallLinkInfo::unlink): (JSC::CallLinkInfo::dummy): Deleted. * bytecode/CallLinkInfo.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::registerPreservationMode): (JSC::CallLinkInfo::setUpCallFromFTL): (JSC::CallLinkInfo::setSlowStub): (JSC::CallLinkInfo::clearSlowStub): (JSC::CallLinkInfo::slowStub): * dfg/DFGDriver.cpp: (JSC::DFG::compileImpl): * dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::link): * ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::link): * jit/JITCall.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): * jit/JITCall32_64.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): * jit/JITOperations.cpp: * jit/JITOperations.h: (JSC::operationLinkFor): Deleted. (JSC::operationVirtualFor): Deleted. (JSC::operationLinkPolymorphicCallFor): Deleted. * jit/Repatch.cpp: (JSC::generateByIdStub): (JSC::linkSlowFor): (JSC::linkFor): (JSC::revertCall): (JSC::unlinkFor): (JSC::linkVirtualFor): (JSC::linkPolymorphicCall): * jit/Repatch.h: * jit/ThunkGenerators.cpp: (JSC::linkCallThunkGenerator): (JSC::linkPolymorphicCallThunkGenerator): (JSC::virtualThunkFor): (JSC::linkForThunkGenerator): Deleted. (JSC::linkConstructThunkGenerator): Deleted. (JSC::linkCallThatPreservesRegsThunkGenerator): Deleted. (JSC::linkConstructThatPreservesRegsThunkGenerator): Deleted. (JSC::linkPolymorphicCallForThunkGenerator): Deleted. (JSC::linkPolymorphicCallThatPreservesRegsThunkGenerator): Deleted. (JSC::virtualForThunkGenerator): Deleted. (JSC::virtualCallThunkGenerator): Deleted. (JSC::virtualConstructThunkGenerator): Deleted. (JSC::virtualCallThatPreservesRegsThunkGenerator): Deleted. (JSC::virtualConstructThatPreservesRegsThunkGenerator): Deleted. * jit/ThunkGenerators.h: (JSC::linkThunkGeneratorFor): Deleted. (JSC::linkPolymorphicCallThunkGeneratorFor): Deleted. (JSC::virtualThunkGeneratorFor): Deleted. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/CallLinkInfo.cpp trunk/Source/_javascript_Core/bytecode/CallLinkInfo.h trunk/Source/_javascript_Core/dfg/DFGDriver.cpp trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp trunk/Source/_javascript_Core/ftl/FTLJSCallBase.cpp trunk/Source/_javascript_Core/jit/JITCall.cpp trunk/Source/_javascript_Core/jit/JITCall32_64.cpp trunk/Source/_javascript_Core/jit/JITOperations.cpp trunk/Source/_javascript_Core/jit/JITOperations.h trunk/Source/_javascript_Core/jit/Repatch.cpp trunk/Source/_javascript_Core/jit/Repatch.h trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp trunk/Source/_javascript_Core/jit/ThunkGenerators.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (187504 => 187505) --- trunk/Source/_javascript_Core/ChangeLog 2015-07-28 20:10:03 UTC (rev 187504) +++ trunk/Source/_javascript_Core/ChangeLog 2015-07-28 20:12:33 UTC (rev 187505) @@ -1,5 +1,86 @@ 2015-07-28 Basile Clement basile_clem...@apple.com +Simplify call linking +https://bugs.webkit.org/show_bug.cgi?id=147363 + +Reviewed by Filip Pizlo. + +Previously, we were passing both the CallLinkInfo and a +(CodeSpecializationKind, RegisterPreservationMode) pair to the +different call linking slow paths. However, the CallLinkInfo already +has all of that information, and we don't gain anything by having them +in additional static parameters - except possibly a very small +performance gain in presence of inlining. However since those are +already slow paths, this performance loss (if it exists) will not be +visible in practice. + +This patch removes the various specialized thunks and JIT operations +for regular and polymorphic call linking with a single thunk and +operation for each case. Moreover, it removes the four
[webkit-changes] [187498] trunk/Source/WebCore
Title: [187498] trunk/Source/WebCore Revision 187498 Author simon.fra...@apple.com Date 2015-07-28 12:14:05 -0700 (Tue, 28 Jul 2015) Log Message Fix builds using PathCairo. * platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::apply): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cairo/PathCairo.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (187497 => 187498) --- trunk/Source/WebCore/ChangeLog 2015-07-28 18:51:27 UTC (rev 187497) +++ trunk/Source/WebCore/ChangeLog 2015-07-28 19:14:05 UTC (rev 187498) @@ -1,3 +1,10 @@ +2015-07-28 Simon Fraser simon.fra...@apple.com + +Fix builds using PathCairo. + +* platform/graphics/cairo/PathCairo.cpp: +(WebCore::Path::apply): + 2015-07-28 Joseph Pecoraro pecor...@apple.com Web Inspector: Show Pseudo Elements in DOM Tree Modified: trunk/Source/WebCore/platform/graphics/cairo/PathCairo.cpp (187497 => 187498) --- trunk/Source/WebCore/platform/graphics/cairo/PathCairo.cpp 2015-07-28 18:51:27 UTC (rev 187497) +++ trunk/Source/WebCore/platform/graphics/cairo/PathCairo.cpp 2015-07-28 19:14:05 UTC (rev 187498) @@ -408,23 +408,23 @@ case CAIRO_PATH_MOVE_TO: pelement.type = PathElementMoveToPoint; pelement.points[0] = FloatPoint(data[1].point.x,data[1].point.y); -function(info, pelement); +function(info, pelement); break; case CAIRO_PATH_LINE_TO: pelement.type = PathElementAddLineToPoint; pelement.points[0] = FloatPoint(data[1].point.x,data[1].point.y); -function(info, pelement); +function(info, pelement); break; case CAIRO_PATH_CURVE_TO: pelement.type = PathElementAddCurveToPoint; pelement.points[0] = FloatPoint(data[1].point.x,data[1].point.y); pelement.points[1] = FloatPoint(data[2].point.x,data[2].point.y); pelement.points[2] = FloatPoint(data[3].point.x,data[3].point.y); -function(info, pelement); +function(info, pelement); break; case CAIRO_PATH_CLOSE_PATH: pelement.type = PathElementCloseSubpath; -function(info, pelement); +function(info, pelement); break; } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187500] trunk/Source/WebInspectorUI
Title: [187500] trunk/Source/WebInspectorUI Revision 187500 Author drou...@apple.com Date 2015-07-28 12:23:10 -0700 (Tue, 28 Jul 2015) Log Message Web Inspector: Invalid selectors can be applied to the stylesheet https://bugs.webkit.org/show_bug.cgi?id=147230 Reviewed by Timothy Hatcher. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Models/CSSRule.js: (WebInspector.CSSRule.prototype.set selectorText): Fires an event with data stating if the newly applied selector was valid or not. (WebInspector.CSSRule.prototype._selectorRejected): (WebInspector.CSSRule.prototype._selectorResolved): (WebInspector.CSSRule): * UserInterface/Models/DOMNodeStyles.js: (WebInspector.DOMNodeStyles.prototype.changeRuleSelector.ruleSelectorChanged): (WebInspector.DOMNodeStyles.prototype.changeRuleSelector): Now returns a promise that will reject if CSSAgent.setRuleSelector has an error, such as if the selector is invalid, and resolve otherwise. * UserInterface/Views/CSSStyleDeclarationSection.css: (.style-declaration-section:not(.invalid-selector) .header .icon.toggle-able:hover): (.style-declaration-section:not(.invalid-selector).rule-disabled .header .icon): (.style-declaration-section.invalid-selector .header .icon): (.style-declaration-section.invalid-selector .header .selector *): (.style-declaration-section .header .icon.toggle-able:hover): Deleted. (.style-declaration-section.rule-disabled .header .icon): Deleted. * UserInterface/Views/CSSStyleDeclarationSection.js: (WebInspector.CSSStyleDeclarationSection): (WebInspector.CSSStyleDeclarationSection.prototype._toggleRuleOnOff): Only allow rule toggling if the selector is valid. (WebInspector.CSSStyleDeclarationSection.prototype._markSelector): If the new selector is valid, refresh the section. Otherwise, apply a class to the section element that marks the selector as being invalid. (WebInspector.CSSStyleDeclarationSection.prototype.get _hasInvalidSelector): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Models/CSSRule.js trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (187499 => 187500) --- trunk/Source/WebInspectorUI/ChangeLog 2015-07-28 19:16:19 UTC (rev 187499) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-28 19:23:10 UTC (rev 187500) @@ -1,3 +1,42 @@ +2015-07-28 Devin Rousso drou...@apple.com + +Web Inspector: Invalid selectors can be applied to the stylesheet +https://bugs.webkit.org/show_bug.cgi?id=147230 + +Reviewed by Timothy Hatcher. + +* Localizations/en.lproj/localizedStrings.js: + +* UserInterface/Models/CSSRule.js: +(WebInspector.CSSRule.prototype.set selectorText): +Fires an event with data stating if the newly applied selector was valid or not. +(WebInspector.CSSRule.prototype._selectorRejected): +(WebInspector.CSSRule.prototype._selectorResolved): +(WebInspector.CSSRule): + +* UserInterface/Models/DOMNodeStyles.js: +(WebInspector.DOMNodeStyles.prototype.changeRuleSelector.ruleSelectorChanged): +(WebInspector.DOMNodeStyles.prototype.changeRuleSelector): +Now returns a promise that will reject if CSSAgent.setRuleSelector has an +error, such as if the selector is invalid, and resolve otherwise. + +* UserInterface/Views/CSSStyleDeclarationSection.css: +(.style-declaration-section:not(.invalid-selector) .header .icon.toggle-able:hover): +(.style-declaration-section:not(.invalid-selector).rule-disabled .header .icon): +(.style-declaration-section.invalid-selector .header .icon): +(.style-declaration-section.invalid-selector .header .selector *): +(.style-declaration-section .header .icon.toggle-able:hover): Deleted. +(.style-declaration-section.rule-disabled .header .icon): Deleted. + +* UserInterface/Views/CSSStyleDeclarationSection.js: +(WebInspector.CSSStyleDeclarationSection): +(WebInspector.CSSStyleDeclarationSection.prototype._toggleRuleOnOff): +Only allow rule toggling if the selector is valid. +(WebInspector.CSSStyleDeclarationSection.prototype._markSelector): +If the new selector is valid, refresh the section. Otherwise, apply a class +to the section element that marks the selector as being invalid. +(WebInspector.CSSStyleDeclarationSection.prototype.get _hasInvalidSelector): + 2015-07-28 Joseph Pecoraro pecor...@apple.com Web Inspector: Show Pseudo Elements in DOM Tree Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (187499 => 187500) ---
[webkit-changes] [187502] trunk
Title: [187502] trunk Revision 187502 Author hy...@apple.com Date 2015-07-28 12:42:03 -0700 (Tue, 28 Jul 2015) Log Message ASSERTION FAILED: !currBox-needsLayout() loading bing maps (and apple.com/music and nytimes) https://bugs.webkit.org/show_bug.cgi?id=93891 Reviewed by Simon Fraser. Source/WebCore: Added new tests in fast/dynamic. Change tracking of positioned objects to always insert objects that need a layout in the end of the ListHashMap for RenderViews. This ensures that dependencies between nested positioned objects that both need a layout by the RenderView are resolved in the correct order. Don't cache the end object when walking the ListHashMap to do layouts of positioned objects, since that list is getting updated dynamically as earlier objects can mark and insert new objects into the list during their layouts. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObject): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::insertIntoTrackedRendererMaps): (WebCore::RenderBlock::insertPositionedObject): (WebCore::RenderBlock::removePositionedObject): * rendering/RenderBlock.h: LayoutTests: * fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash-expected.txt: Added. * fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlock.h Added Paths trunk/LayoutTests/fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash-expected.txt trunk/LayoutTests/fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (187501 => 187502) --- trunk/LayoutTests/ChangeLog 2015-07-28 19:38:13 UTC (rev 187501) +++ trunk/LayoutTests/ChangeLog 2015-07-28 19:42:03 UTC (rev 187502) @@ -1,3 +1,13 @@ +2015-07-27 David Hyatt hy...@apple.com + +ASSERTION FAILED: !currBox-needsLayout() loading bing maps (and apple.com/music and nytimes) +https://bugs.webkit.org/show_bug.cgi?id=93891 + +Reviewed by Simon Fraser. + +* fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash-expected.txt: Added. +* fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash.html: Added. + 2015-07-28 Joseph Pecoraro pecor...@apple.com Web Inspector: Show Pseudo Elements in DOM Tree Added: trunk/LayoutTests/fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash-expected.txt (0 => 187502) --- trunk/LayoutTests/fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash-expected.txt 2015-07-28 19:42:03 UTC (rev 187502) @@ -0,0 +1,2 @@ +This tests that changing the container's position from fixed to absolute is safe, when child container with fixed position is present. +PASS, if no crash or assert in debug. Added: trunk/LayoutTests/fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash.html (0 => 187502) --- trunk/LayoutTests/fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash.html (rev 0) +++ trunk/LayoutTests/fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash.html 2015-07-28 19:42:03 UTC (rev 187502) @@ -0,0 +1,23 @@ +html +body +div id=toabsolute style=position: fixed; +div style=position: fixed;/div +/div +p id=foo +This tests that changing the container's position from fixed to absolute is safe, when +child container with fixed position is present.br +PASS, if no crash or assert in debug. +/p +script +if (window.testRunner) +testRunner.dumpAsText(); + var m = document.getElementById(foo); + var c = document.getElementById(toabsolute); + + c.offsetHeight; + c.style.position = absolute; + c.style.width = m.offsetWidth + px; + c.offsetHeight; + /script +/body +/html Modified: trunk/Source/WebCore/ChangeLog (187501 => 187502) --- trunk/Source/WebCore/ChangeLog 2015-07-28 19:38:13 UTC (rev 187501) +++ trunk/Source/WebCore/ChangeLog 2015-07-28 19:42:03 UTC (rev 187502) @@ -1,3 +1,28 @@ +2015-07-27 David Hyatt hy...@apple.com + +ASSERTION FAILED: !currBox-needsLayout() loading bing maps (and apple.com/music and nytimes) +https://bugs.webkit.org/show_bug.cgi?id=93891 + +Reviewed by Simon Fraser. + +Added new tests in fast/dynamic. + +Change tracking of positioned objects to always insert objects that need a layout in the +end of the ListHashMap for RenderViews. This ensures that dependencies between nested +positioned objects that both need a layout by the RenderView are resolved in the correct order. + +Don't cache the end
[webkit-changes] [187499] branches/safari-600.1.4.17-branch/Source/WebCore
Title: [187499] branches/safari-600.1.4.17-branch/Source/WebCore
Revision 187499
Author bshaf...@apple.com
Date 2015-07-28 12:16:19 -0700 (Tue, 28 Jul 2015)
Log Message
Merged r187490. rdar://problem/22035036
Modified Paths
branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog
branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
Diff
Modified: branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog (187498 => 187499)
--- branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog 2015-07-28 19:14:05 UTC (rev 187498)
+++ branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog 2015-07-28 19:16:19 UTC (rev 187499)
@@ -1,3 +1,18 @@
+2015-07-28 Babak Shafiei bshaf...@apple.com
+
+Merge r187490.
+
+2015-07-28 Brady Eidson beid...@apple.com
+
+Handle null CFArrayRef returning from _CFHTTPParsedCookiesWithResponseHeaderFields.
+rdar://problem/21995928 and https://bugs.webkit.org/show_bug.cgi?id=147365
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/network/cf/CookieJarCFNet.cpp:
+(WebCore::filterCookies): ASSERT the input is not null.
+(WebCore::createCookies): Always return a CFArrayRef, even if it's empty.
+
2015-07-27 Babak Shafiei bshaf...@apple.com
Roll out r180020.
Modified: branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp (187498 => 187499)
--- branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-28 19:14:05 UTC (rev 187498)
+++ branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-28 19:16:19 UTC (rev 187499)
@@ -85,6 +85,7 @@
static RetainPtrCFArrayRef filterCookies(CFArrayRef unfilteredCookies)
{
+ASSERT(unfilteredCookies);
CFIndex count = CFArrayGetCount(unfilteredCookies);
RetainPtrCFMutableArrayRef filteredCookies = adoptCF(CFArrayCreateMutable(0, count, kCFTypeArrayCallBacks));
for (CFIndex i = 0; i count; ++i) {
@@ -120,7 +121,11 @@
static CFArrayRef createCookies(CFDictionaryRef headerFields, CFURLRef url)
{
-return _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
+CFArrayRef parsedCookies = _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
+if (!parsedCookies)
+parsedCookies = CFArrayCreate(kCFAllocatorDefault, 0, 0, kCFTypeArrayCallBacks);
+
+return parsedCookies;
}
void setCookiesFromDOM(const NetworkStorageSession session, const URL firstParty, const URL url, const String value)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187501] trunk/Tools
Title: [187501] trunk/Tools Revision 187501 Author a...@apple.com Date 2015-07-28 12:38:13 -0700 (Tue, 28 Jul 2015) Log Message webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com https://bugs.webkit.org/show_bug.cgi?id=147359 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/tool/commands/newcommitbot.py: (NewCommitBot.begin_work_queue): * Scripts/webkitpy/tool/commands/sheriffbot.py: (SheriffBot.begin_work_queue): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py Diff Modified: trunk/Tools/ChangeLog (187500 => 187501) --- trunk/Tools/ChangeLog 2015-07-28 19:23:10 UTC (rev 187500) +++ trunk/Tools/ChangeLog 2015-07-28 19:38:13 UTC (rev 187501) @@ -1,3 +1,15 @@ +2015-07-28 Alexey Proskuryakov a...@apple.com + +webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com +https://bugs.webkit.org/show_bug.cgi?id=147359 + +Reviewed by Ryosuke Niwa. + +* Scripts/webkitpy/tool/commands/newcommitbot.py: +(NewCommitBot.begin_work_queue): +* Scripts/webkitpy/tool/commands/sheriffbot.py: +(SheriffBot.begin_work_queue): + 2015-07-27 Alex Christensen achristen...@webkit.org Use Ninja on Windows. Modified: trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py (187500 => 187501) --- trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2015-07-28 19:23:10 UTC (rev 187500) +++ trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2015-07-28 19:38:13 UTC (rev 187501) @@ -70,7 +70,6 @@ # AbstractQueue methods def begin_work_queue(self): -AbstractQueue.begin_work_queue(self) self._last_svn_revision = int(self._tool.scm().head_svn_revision()) self._irc_bot = IRCBot(self.name, self._tool, Agent(self._tool, self), self._commands) self._tool.ensure_irc_connected(self._irc_bot.irc_delegate()) Modified: trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py (187500 => 187501) --- trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py 2015-07-28 19:23:10 UTC (rev 187500) +++ trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py 2015-07-28 19:38:13 UTC (rev 187501) @@ -47,7 +47,6 @@ # AbstractQueue methods def begin_work_queue(self): -AbstractQueue.begin_work_queue(self) self._sheriff = Sheriff(self._tool, self) self._irc_bot = IRCBot(self.name, self._tool, self._sheriff, irc_commands) self._tool.ensure_irc_connected(self._irc_bot.irc_delegate()) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187503] trunk/Source/WebCore
Title: [187503] trunk/Source/WebCore
Revision 187503
Author cdu...@apple.com
Date 2015-07-28 12:48:03 -0700 (Tue, 28 Jul 2015)
Log Message
Unreviewed, follow-up nit fix after r187489.
Fix forward declarations ordering.
* css/StyleSheetContents.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleSheetContents.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (187502 => 187503)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 19:42:03 UTC (rev 187502)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 19:48:03 UTC (rev 187503)
@@ -1,3 +1,11 @@
+2015-07-28 Chris Dumez cdu...@apple.com
+
+Unreviewed, follow-up nit fix after r187489.
+
+Fix forward declarations ordering.
+
+* css/StyleSheetContents.h:
+
2015-07-27 David Hyatt hy...@apple.com
ASSERTION FAILED: !currBox-needsLayout() loading bing maps (and apple.com/music and nytimes)
Modified: trunk/Source/WebCore/css/StyleSheetContents.h (187502 => 187503)
--- trunk/Source/WebCore/css/StyleSheetContents.h 2015-07-28 19:42:03 UTC (rev 187502)
+++ trunk/Source/WebCore/css/StyleSheetContents.h 2015-07-28 19:48:03 UTC (rev 187503)
@@ -38,9 +38,9 @@
class CachedResource;
class Document;
class Node;
+class SecurityOrigin;
class StyleRuleBase;
class StyleRuleImport;
-class SecurityOrigin;
class StyleSheetContents : public RefCountedStyleSheetContents {
public:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187504] trunk
Title: [187504] trunk
Revision 187504
Author s...@apple.com
Date 2015-07-28 13:10:03 -0700 (Tue, 28 Jul 2015)
Log Message
Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree
https://bugs.webkit.org/show_bug.cgi?id=147290
Reviewed by Daniel Bates.
Source/WebCore:
When the shadow tree is built for a use element, all the SVG elements
are allowed to be cloned in the shadow tree but later some of the elements
are disallowed and removed. Make sure, when disallowing an element in the
shadow tree, to reset the correspondingElement relationship between all
the disallowed descendant SVG elements and all their original elements.
Test: svg/custom/remove-event-listener-shadow-disallowed-element.svg
*svg/SVGElement.cpp:
(WebCore::SVGElement::setCorrespondingElement)
* svg/SVGUseElement.cpp:
(WebCore::removeDisallowedElementsFromSubtree):
LayoutTests:
Make sure we do not crash when when calling removeEventListener() for an
element which is cloned under a disallowed parent inside the shadow tree
of another use element.
* svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt: Added.
* svg/custom/remove-event-listener-shadow-disallowed-element.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.cpp
trunk/Source/WebCore/svg/SVGUseElement.cpp
Added Paths
trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt
trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (187503 => 187504)
--- trunk/LayoutTests/ChangeLog 2015-07-28 19:48:03 UTC (rev 187503)
+++ trunk/LayoutTests/ChangeLog 2015-07-28 20:10:03 UTC (rev 187504)
@@ -1,3 +1,17 @@
+2015-07-28 Said Abou-Hallawa sabouhall...@apple.com
+
+Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree
+https://bugs.webkit.org/show_bug.cgi?id=147290
+
+Reviewed by Daniel Bates.
+
+Make sure we do not crash when when calling removeEventListener() for an
+element which is cloned under a disallowed parent inside the shadow tree
+of another use element.
+
+* svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt: Added.
+* svg/custom/remove-event-listener-shadow-disallowed-element.svg: Added.
+
2015-07-27 David Hyatt hy...@apple.com
ASSERTION FAILED: !currBox-needsLayout() loading bing maps (and apple.com/music and nytimes)
Added: trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt (0 => 187504)
--- trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt 2015-07-28 20:10:03 UTC (rev 187504)
@@ -0,0 +1 @@
+Pass.
Added: trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg (0 => 187504)
--- trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg 2015-07-28 20:10:03 UTC (rev 187504)
@@ -0,0 +1,37 @@
+svg version=1.1 xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+
+ defs
+svg id=green-svg width=100 height=100
+ defs
+ rect id=green-rect fill=green width=100 height=100/
+ /defs
+ use id=use-green-rect xlink:href=""
+/svg
+ /defs
+
+ use id=use-green-svg x=10 y=10 xlink:href=""
+ textPass./text
+
+ script
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+var _onAlert_ = function() {
+ alert(test);
+}
+
+// This removeEventListener() has to be called before the onload fires. Before
+// onload fires, the shadow tree of the SVGUseElement is not built. So this
+// call should affect the original element only. Once the shadow tree is built,
+// the SVGUseElement calls updateShadowTree() and this is where we want to make
+// sure the eventListeners of all the cloned elements in the shadow tree are
+// updated correctly and the disallowed cloned elements and their descendants
+// are disconnected from their corresponding elements.
+document.getElementById(green-rect).addEventListener(click, onAlert);
+
+window.addEventListener(load, function () {
+ document.getElementById(green-rect).removeEventListener(click, onAlert);
+}, false);
+ /script
+
+/svg
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (187503 => 187504)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 19:48:03 UTC (rev 187503)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 20:10:03 UTC (rev 187504)
@@ -1,3 +1,23 @@
+2015-07-28 Said Abou-Hallawa
[webkit-changes] [187511] tags/Safari-601.1.44.1/Source/WebKit2
Title: [187511] tags/Safari-601.1.44.1/Source/WebKit2
Revision 187511
Author bshaf...@apple.com
Date 2015-07-28 13:59:29 -0700 (Tue, 28 Jul 2015)
Log Message
Roll out r187376. rdar://problem/22000647
Modified Paths
tags/Safari-601.1.44.1/Source/WebKit2/ChangeLog
tags/Safari-601.1.44.1/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: tags/Safari-601.1.44.1/Source/WebKit2/ChangeLog (187510 => 187511)
--- tags/Safari-601.1.44.1/Source/WebKit2/ChangeLog 2015-07-28 20:50:18 UTC (rev 187510)
+++ tags/Safari-601.1.44.1/Source/WebKit2/ChangeLog 2015-07-28 20:59:29 UTC (rev 187511)
@@ -1,3 +1,7 @@
+2015-07-28 Babak Shafiei bshaf...@apple.com
+
+Roll out r187376.
+
2015-07-27 Matthew Hanson matthew_han...@apple.com
Merge r187412. rdar://problem/22003112
Modified: tags/Safari-601.1.44.1/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (187510 => 187511)
--- tags/Safari-601.1.44.1/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-07-28 20:50:18 UTC (rev 187510)
+++ tags/Safari-601.1.44.1/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-07-28 20:59:29 UTC (rev 187511)
@@ -1259,9 +1259,6 @@
- (UIView *)inputAccessoryView
{
-if (![self requiresAccessoryView])
-return nil;
-
if (!_formAccessoryView) {
#if __IPHONE_OS_VERSION_MIN_REQUIRED = 9
if ([UIWebFormAccessory instancesRespondToSelector:@selector(initWithInputAssistantItem:)])
@@ -1272,6 +1269,9 @@
[_formAccessoryView setDelegate:self];
}
+if (![self requiresAccessoryView])
+return nil;
+
return _formAccessoryView.get();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187512] trunk/LayoutTests
Title: [187512] trunk/LayoutTests Revision 187512 Author cdu...@apple.com Date 2015-07-28 14:19:28 -0700 (Tue, 28 Jul 2015) Log Message Unreviewed, fix wrong test baseline landed in r187489. * http/tests/security/same-origin-css-4-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/same-origin-css-4-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (187511 => 187512) --- trunk/LayoutTests/ChangeLog 2015-07-28 20:59:29 UTC (rev 187511) +++ trunk/LayoutTests/ChangeLog 2015-07-28 21:19:28 UTC (rev 187512) @@ -1,3 +1,9 @@ +2015-07-28 Chris Dumez cdu...@apple.com + +Unreviewed, fix wrong test baseline landed in r187489. + +* http/tests/security/same-origin-css-4-expected.txt: + 2015-07-28 Joseph Pecoraro pecor...@apple.com Web Inspector: Include template node content in DOM Tree Modified: trunk/LayoutTests/http/tests/security/same-origin-css-4-expected.txt (187511 => 187512) --- trunk/LayoutTests/http/tests/security/same-origin-css-4-expected.txt 2015-07-28 20:59:29 UTC (rev 187511) +++ trunk/LayoutTests/http/tests/security/same-origin-css-4-expected.txt 2015-07-28 21:19:28 UTC (rev 187512) @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: Did not parse stylesheet at 'http://127.0.0.1:8000/security/resources/xorigincss3.html' because non CSS MIME types are not allowed in strict mode. PASS Testing same-origin and MIME behavior for CSS. PASS xorigincss3.html should not be loaded, even though it is same-origin ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187513] trunk/Source/JavaScriptCore
Title: [187513] trunk/Source/_javascript_Core Revision 187513 Author fpi...@apple.com Date 2015-07-28 14:23:06 -0700 (Tue, 28 Jul 2015) Log Message DFG::ArgumentsEliminationPhase has a redundant check for inserting CheckInBounds when converting GetByVal to GetStack in the inline non-varargs case https://bugs.webkit.org/show_bug.cgi?id=147373 Reviewed by Mark Lam. The code was doing a check for index = inlineCallFrame-arguments.size() - 1 in code where safeToGetStack is true and we aren't in varargs context, but in a non-varargs context, safeToGetStack can only be true if index inlineCallFrame-arguments.size() - 1. When converting a GetByVal to GetStack, there are three possibilities: 1) Impossible to convert. This can happen if the GetByVal is out-of-bounds of the things we know to have stored to the stack. For example, if we inline a function that does arguments[42] at a call that passes no arguments. 2) Possible to convert, but we cannot prove statically that the GetByVal was in bounds. This can happen for arguments[42] with no inline call frame (since we don't know statically how many arguments we will be passed) or in a varargs call frame. 3) Possible to convert, and we know statically that the GetByVal is in bounds. This can happen for arguments[42] if we have an inline call frame, and it's not a varargs call frame, and we know that the caller passed 42 or more arguments. The way the phase handles this is it first determines that we're not in case (1). This is called safeToGetStack. safeToGetStack is true if we have case (2) or (3). For inline call frames that have no varargs, this means that safeToGetStack is true exactly when the GetByVal is in-bounds (i.e. case (3)). But the phase was again doing a check for whether the index is in-bounds for non-varargs inline call frames even when safeToGetStack was true. That check is redundant and should be eliminated, since it makes the code confusing. * dfg/DFGArgumentsEliminationPhase.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (187512 => 187513) --- trunk/Source/_javascript_Core/ChangeLog 2015-07-28 21:19:28 UTC (rev 187512) +++ trunk/Source/_javascript_Core/ChangeLog 2015-07-28 21:23:06 UTC (rev 187513) @@ -1,5 +1,41 @@ 2015-07-28 Filip Pizlo fpi...@apple.com +DFG::ArgumentsEliminationPhase has a redundant check for inserting CheckInBounds when converting GetByVal to GetStack in the inline non-varargs case +https://bugs.webkit.org/show_bug.cgi?id=147373 + +Reviewed by Mark Lam. + +The code was doing a check for index = inlineCallFrame-arguments.size() - 1 in code where +safeToGetStack is true and we aren't in varargs context, but in a non-varargs context, +safeToGetStack can only be true if index inlineCallFrame-arguments.size() - 1. + +When converting a GetByVal to GetStack, there are three possibilities: + +1) Impossible to convert. This can happen if the GetByVal is out-of-bounds of the things we + know to have stored to the stack. For example, if we inline a function that does + arguments[42] at a call that passes no arguments. + +2) Possible to convert, but we cannot prove statically that the GetByVal was in bounds. This + can happen for arguments[42] with no inline call frame (since we don't know statically + how many arguments we will be passed) or in a varargs call frame. + +3) Possible to convert, and we know statically that the GetByVal is in bounds. This can + happen for arguments[42] if we have an inline call frame, and it's not a varargs call + frame, and we know that the caller passed 42 or more arguments. + +The way the phase handles this is it first determines that we're not in case (1). This is +called safeToGetStack. safeToGetStack is true if we have case (2) or (3). For inline call +frames that have no varargs, this means that safeToGetStack is true exactly when the GetByVal +is in-bounds (i.e. case (3)). + +But the phase was again doing a check for whether the index is in-bounds for non-varargs +inline call frames even when safeToGetStack was true. That check is redundant and should be +eliminated, since it makes the code confusing. + +* dfg/DFGArgumentsEliminationPhase.cpp: + +2015-07-28 Filip Pizlo fpi...@apple.com + DFG::PutStackSinkingPhase should be more aggressive about its no GetStack until put rule https://bugs.webkit.org/show_bug.cgi?id=147371 Modified: trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp (187512 => 187513) --- trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp 2015-07-28 21:19:28 UTC (rev 187512) +++ trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp
[webkit-changes] [187521] trunk/Source/WebCore
Title: [187521] trunk/Source/WebCore
Revision 187521
Author timothy_hor...@apple.com
Date 2015-07-28 15:22:14 -0700 (Tue, 28 Jul 2015)
Log Message
[iOS] Creating a TextIndicator causes the view to scroll to the current selection
https://bugs.webkit.org/show_bug.cgi?id=147379
rdar://problem/22038421
Reviewed by Beth Dakin.
* editing/Editor.cpp:
(WebCore::Editor::setIgnoreCompositionSelectionChange):
* editing/Editor.h:
Add a flag so that setIgnoreCompositionSelectionChange(false) can still
not force-reveal the current selection.
This is useful for e.g. TextIndicator, who saves the selection, changes it,
and then restores it, but doesn't want to scroll to the saved/restored selection.
* page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithRange):
Make use of the above flag.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/page/TextIndicator.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187520 => 187521)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 22:14:29 UTC (rev 187520)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 22:22:14 UTC (rev 187521)
@@ -1,3 +1,24 @@
+2015-07-28 Tim Horton timothy_hor...@apple.com
+
+[iOS] Creating a TextIndicator causes the view to scroll to the current selection
+https://bugs.webkit.org/show_bug.cgi?id=147379
+rdar://problem/22038421
+
+Reviewed by Beth Dakin.
+
+* editing/Editor.cpp:
+(WebCore::Editor::setIgnoreCompositionSelectionChange):
+* editing/Editor.h:
+Add a flag so that setIgnoreCompositionSelectionChange(false) can still
+not force-reveal the current selection.
+
+This is useful for e.g. TextIndicator, who saves the selection, changes it,
+and then restores it, but doesn't want to scroll to the saved/restored selection.
+
+* page/TextIndicator.cpp:
+(WebCore::TextIndicator::createWithRange):
+Make use of the above flag.
+
2015-07-28 Eric Carlson eric.carl...@apple.com
[iOS] Set AirPlay discovery mode to disabled when page is hidden
Modified: trunk/Source/WebCore/editing/Editor.cpp (187520 => 187521)
--- trunk/Source/WebCore/editing/Editor.cpp 2015-07-28 22:14:29 UTC (rev 187520)
+++ trunk/Source/WebCore/editing/Editor.cpp 2015-07-28 22:22:14 UTC (rev 187521)
@@ -2757,7 +2757,7 @@
m_frame.selection().revealSelection(alignment, revealExtentOption);
}
-void Editor::setIgnoreCompositionSelectionChange(bool ignore)
+void Editor::setIgnoreCompositionSelectionChange(bool ignore, RevealSelection shouldRevealExistingSelection)
{
if (m_ignoreCompositionSelectionChange == ignore)
return;
@@ -2768,7 +2768,7 @@
if (!ignore)
respondToChangedSelection(m_frame.selection().selection(), 0);
#endif
-if (!ignore)
+if (!ignore shouldRevealExistingSelection == RevealSelection::Yes)
revealSelectionAfterEditingOperation(ScrollAlignment::alignToEdgeIfNeeded, RevealExtent);
}
Modified: trunk/Source/WebCore/editing/Editor.h (187520 => 187521)
--- trunk/Source/WebCore/editing/Editor.h 2015-07-28 22:14:29 UTC (rev 187520)
+++ trunk/Source/WebCore/editing/Editor.h 2015-07-28 22:22:14 UTC (rev 187521)
@@ -310,7 +310,8 @@
bool compositionUsesCustomUnderlines() const { return !m_customCompositionUnderlines.isEmpty(); }
const VectorCompositionUnderline customCompositionUnderlines() const { return m_customCompositionUnderlines; }
-WEBCORE_EXPORT void setIgnoreCompositionSelectionChange(bool);
+enum class RevealSelection { No, Yes };
+WEBCORE_EXPORT void setIgnoreCompositionSelectionChange(bool, RevealSelection shouldRevealExistingSelection = RevealSelection::Yes);
bool ignoreCompositionSelectionChange() const { return m_ignoreCompositionSelectionChange; }
void setStartNewKillRingSequence(bool);
Modified: trunk/Source/WebCore/page/TextIndicator.cpp (187520 => 187521)
--- trunk/Source/WebCore/page/TextIndicator.cpp 2015-07-28 22:14:29 UTC (rev 187520)
+++ trunk/Source/WebCore/page/TextIndicator.cpp 2015-07-28 22:22:14 UTC (rev 187521)
@@ -71,7 +71,7 @@
indicator-setWantsMargin(!areRangesEqual(range, oldSelection.toNormalizedRange().get()));
#if PLATFORM(IOS)
-frame-editor().setIgnoreCompositionSelectionChange(false);
+frame-editor().setIgnoreCompositionSelectionChange(false, Editor::RevealSelection::No);
frame-selection().setUpdateAppearanceEnabled(false);
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187525] trunk
Title: [187525] trunk
Revision 187525
Author mmaxfi...@apple.com
Date 2015-07-28 16:12:46 -0700 (Tue, 28 Jul 2015)
Log Message
[iOS] Crash when encountering characters whose natural font is one we can't look up
https://bugs.webkit.org/show_bug.cgi?id=147377
rdar://problem/22022011
Reviewed by Simon Fraser.
Source/WebCore:
These characters hit the complex text code path, where CoreText picks fonts
to use for each character. We then try to map these CoreText fonts back to
our own Font objects, and we assume (on iOS) that our own font search will
always return something.
On OS X, we do not have such an assumption, and we handle the case where it
does not hold. This method works on iOS as well, so the solution is to just
perform it on both OSes.
Test: fast/text/crash-complex-unknown-font.html
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
LayoutTests:
* fast/text/crash-complex-unknown-font-expected.html: Added.
* fast/text/crash-complex-unknown-font.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm
Added Paths
trunk/LayoutTests/fast/text/crash-complex-unknown-font-expected.html
trunk/LayoutTests/fast/text/crash-complex-unknown-font.html
Diff
Modified: trunk/LayoutTests/ChangeLog (187524 => 187525)
--- trunk/LayoutTests/ChangeLog 2015-07-28 22:39:12 UTC (rev 187524)
+++ trunk/LayoutTests/ChangeLog 2015-07-28 23:12:46 UTC (rev 187525)
@@ -1,3 +1,14 @@
+2015-07-28 Myles C. Maxfield mmaxfi...@apple.com
+
+[iOS] Crash when encountering characters whose natural font is one we can't look up
+https://bugs.webkit.org/show_bug.cgi?id=147377
+rdar://problem/22022011
+
+Reviewed by Simon Fraser.
+
+* fast/text/crash-complex-unknown-font-expected.html: Added.
+* fast/text/crash-complex-unknown-font.html: Added.
+
2015-07-28 Chris Dumez cdu...@apple.com
Tests introduced in r187489 are flaky
Added: trunk/LayoutTests/fast/text/crash-complex-unknown-font-expected.html (0 => 187525)
--- trunk/LayoutTests/fast/text/crash-complex-unknown-font-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/crash-complex-unknown-font-expected.html 2015-07-28 23:12:46 UTC (rev 187525)
@@ -0,0 +1,8 @@
+!DOCTYPE html
+html
+head
+/head
+body
+Test successful (no crash)
+/body
+/html
Added: trunk/LayoutTests/fast/text/crash-complex-unknown-font.html (0 => 187525)
--- trunk/LayoutTests/fast/text/crash-complex-unknown-font.html (rev 0)
+++ trunk/LayoutTests/fast/text/crash-complex-unknown-font.html 2015-07-28 23:12:46 UTC (rev 187525)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+script
+if (window.testRunner)
+testRunner.waitUntilDone();
+window.setTimeout(function() {
+document.getElementById(replaceme).textContent = Test successful (no crash);
+if (window.testRunner)
+testRunner.notifyDone();
+}, 0);
+/script
+/head
+body
+div id=replaceme#x2038;#x094d;#x091f;/div
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (187524 => 187525)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 22:39:12 UTC (rev 187524)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 23:12:46 UTC (rev 187525)
@@ -1,3 +1,25 @@
+2015-07-28 Myles C. Maxfield mmaxfi...@apple.com
+
+[iOS] Crash when encountering characters whose natural font is one we can't look up
+https://bugs.webkit.org/show_bug.cgi?id=147377
+rdar://problem/22022011
+
+Reviewed by Simon Fraser.
+
+These characters hit the complex text code path, where CoreText picks fonts
+to use for each character. We then try to map these CoreText fonts back to
+our own Font objects, and we assume (on iOS) that our own font search will
+always return something.
+
+On OS X, we do not have such an assumption, and we handle the case where it
+does not hold. This method works on iOS as well, so the solution is to just
+perform it on both OSes.
+
+Test: fast/text/crash-complex-unknown-font.html
+
+* platform/graphics/mac/ComplexTextControllerCoreText.mm:
+(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
+
2015-07-28 Said Abou-Hallawa sabouhall...@apple.com
[iOS] REGRESSION(r168075): Fullscreen web video doesn't pause on screen lock
Modified: trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm (187524 => 187525)
--- trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm 2015-07-28 22:39:12 UTC (rev 187524)
+++ trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm 2015-07-28 23:12:46 UTC (rev 187525)
@@ -282,17 +282,12 @@
}
auto fontCache = FontCache::singleton();
runFont =
[webkit-changes] [187507] trunk
Title: [187507] trunk
Revision 187507
Author commit-qu...@webkit.org
Date 2015-07-28 13:37:16 -0700 (Tue, 28 Jul 2015)
Log Message
Web Inspector: Include template node content in DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=147335
Patch by Joseph Pecoraro pecor...@apple.com on 2015-07-28
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
* UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype._unbind):
Cleanup templateContent when DOMNodes get removed.
* UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode.prototype.templateContent):
Create a DOMNode from the payload's templateContent.
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._singleTextChild):
(WebInspector.DOMTreeElement.prototype._hasVisibleChildren):
(WebInspector.DOMTreeElement.prototype._visibleChildren):
A DOMTreeElement has children if the DOMNode has template content.
LayoutTests:
* inspector/dom/template-content-expected.txt: Added.
* inspector/dom/template-content.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js
trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js
Added Paths
trunk/LayoutTests/inspector/dom/template-content-expected.txt
trunk/LayoutTests/inspector/dom/template-content.html
Diff
Modified: trunk/LayoutTests/ChangeLog (187506 => 187507)
--- trunk/LayoutTests/ChangeLog 2015-07-28 20:20:40 UTC (rev 187506)
+++ trunk/LayoutTests/ChangeLog 2015-07-28 20:37:16 UTC (rev 187507)
@@ -1,3 +1,13 @@
+2015-07-28 Joseph Pecoraro pecor...@apple.com
+
+Web Inspector: Include template node content in DOM Tree
+https://bugs.webkit.org/show_bug.cgi?id=147335
+
+Reviewed by Timothy Hatcher.
+
+* inspector/dom/template-content-expected.txt: Added.
+* inspector/dom/template-content.html: Added.
+
2015-07-28 Basile Clement basile_clem...@apple.com
Misleading error message: At least one digit must occur after a decimal point
Added: trunk/LayoutTests/inspector/dom/template-content-expected.txt (0 => 187507)
--- trunk/LayoutTests/inspector/dom/template-content-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/dom/template-content-expected.txt 2015-07-28 20:37:16 UTC (rev 187507)
@@ -0,0 +1,8 @@
+Test that we include template content in DOM Nodes for template elements.
+
+PASS: Got DOMNode for div element
+PASS: DOMNode does not have template content
+
+PASS: Got DOMNode for template element
+PASS: DOMNode has template content
+
Added: trunk/LayoutTests/inspector/dom/template-content.html (0 => 187507)
--- trunk/LayoutTests/inspector/dom/template-content.html (rev 0)
+++ trunk/LayoutTests/inspector/dom/template-content.html 2015-07-28 20:37:16 UTC (rev 187507)
@@ -0,0 +1,33 @@
+html
+head
+script src=""
+script
+function test() {
+WebInspector.domTreeManager.requestDocument(function(documentNode) {
+WebInspector.domTreeManager.querySelector(documentNode.id, #div, function(nodeId) {
+var domNode = WebInspector.domTreeManager.nodeForId(nodeId);
+InspectorTest.expectThat(domNode, Got DOMNode for div element);
+InspectorTest.expectThat(!domNode.templateContent(), DOMNode does not have template content);
+});
+
+WebInspector.domTreeManager.querySelector(documentNode.id, #template, function(nodeId) {
+var domNode = WebInspector.domTreeManager.nodeForId(nodeId);
+InspectorTest.log();
+InspectorTest.expectThat(domNode, Got DOMNode for template element);
+InspectorTest.expectThat(domNode.templateContent(), DOMNode has template content);
+InspectorTest.completeTest();
+});
+});
+}
+/script
+/head
+body _onload_=runTest()
+pTest that we include template content in DOM Nodes for lt;templategt; elements./p
+
+div id=div/div
+template id=template
+h1Header/h1
+pParagraph/p
+/template
+/body
+/html
Modified: trunk/Source/WebInspectorUI/ChangeLog (187506 => 187507)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-07-28 20:20:40 UTC (rev 187506)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-28 20:37:16 UTC (rev 187507)
@@ -1,3 +1,24 @@
+2015-07-28 Joseph Pecoraro pecor...@apple.com
+
+Web Inspector: Include template node content in DOM Tree
+https://bugs.webkit.org/show_bug.cgi?id=147335
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Controllers/DOMTreeManager.js:
+(WebInspector.DOMTreeManager.prototype._unbind):
+Cleanup templateContent when DOMNodes get removed.
+
+* UserInterface/Models/DOMNode.js:
+(WebInspector.DOMNode.prototype.templateContent):
+Create a DOMNode from the payload's templateContent.
+
+*
[webkit-changes] [187509] tags/Safari-601.1.44.1/Source
Title: [187509] tags/Safari-601.1.44.1/Source Revision 187509 Author bshaf...@apple.com Date 2015-07-28 13:46:49 -0700 (Tue, 28 Jul 2015) Log Message Versioning. Modified Paths tags/Safari-601.1.44.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-601.1.44.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-601.1.44.1/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-601.1.44.1/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-601.1.44.1/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-601.1.44.1/Source/_javascript_Core/Configurations/Version.xcconfig (187508 => 187509) --- tags/Safari-601.1.44.1/Source/_javascript_Core/Configurations/Version.xcconfig 2015-07-28 20:45:03 UTC (rev 187508) +++ tags/Safari-601.1.44.1/Source/_javascript_Core/Configurations/Version.xcconfig 2015-07-28 20:46:49 UTC (rev 187509) @@ -24,9 +24,9 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 44; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-601.1.44.1/Source/WebCore/Configurations/Version.xcconfig (187508 => 187509) --- tags/Safari-601.1.44.1/Source/WebCore/Configurations/Version.xcconfig 2015-07-28 20:45:03 UTC (rev 187508) +++ tags/Safari-601.1.44.1/Source/WebCore/Configurations/Version.xcconfig 2015-07-28 20:46:49 UTC (rev 187509) @@ -24,9 +24,9 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 44; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-601.1.44.1/Source/WebInspectorUI/Configurations/Version.xcconfig (187508 => 187509) --- tags/Safari-601.1.44.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-07-28 20:45:03 UTC (rev 187508) +++ tags/Safari-601.1.44.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-07-28 20:46:49 UTC (rev 187509) @@ -1,9 +1,9 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 44; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-601.1.44.1/Source/WebKit/mac/Configurations/Version.xcconfig (187508 => 187509) --- tags/Safari-601.1.44.1/Source/WebKit/mac/Configurations/Version.xcconfig 2015-07-28 20:45:03 UTC (rev 187508) +++ tags/Safari-601.1.44.1/Source/WebKit/mac/Configurations/Version.xcconfig 2015-07-28 20:46:49 UTC (rev 187509) @@ -24,9 +24,9 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 44; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-601.1.44.1/Source/WebKit2/Configurations/Version.xcconfig (187508 => 187509) --- tags/Safari-601.1.44.1/Source/WebKit2/Configurations/Version.xcconfig 2015-07-28 20:45:03 UTC (rev 187508) +++ tags/Safari-601.1.44.1/Source/WebKit2/Configurations/Version.xcconfig 2015-07-28 20:46:49 UTC (rev 187509) @@ -24,9 +24,9 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 44; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187510] trunk/Source/JavaScriptCore
Title: [187510] trunk/Source/_javascript_Core
Revision 187510
Author fpi...@apple.com
Date 2015-07-28 13:50:18 -0700 (Tue, 28 Jul 2015)
Log Message
DFG::PutStackSinkingPhase should be more aggressive about its no GetStack until put rule
https://bugs.webkit.org/show_bug.cgi?id=147371
Reviewed by Mark Lam.
Two fixes:
- Make ConflictingFlush really mean that you can't load from the stack slot. This means not
using ConflictingFlush for arguments.
- Assert that a GetStack never sees ConflictingFlush.
* dfg/DFGPutStackSinkingPhase.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (187509 => 187510)
--- trunk/Source/_javascript_Core/ChangeLog 2015-07-28 20:46:49 UTC (rev 187509)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-07-28 20:50:18 UTC (rev 187510)
@@ -1,3 +1,19 @@
+2015-07-28 Filip Pizlo fpi...@apple.com
+
+DFG::PutStackSinkingPhase should be more aggressive about its no GetStack until put rule
+https://bugs.webkit.org/show_bug.cgi?id=147371
+
+Reviewed by Mark Lam.
+
+Two fixes:
+
+- Make ConflictingFlush really mean that you can't load from the stack slot. This means not
+ using ConflictingFlush for arguments.
+
+- Assert that a GetStack never sees ConflictingFlush.
+
+* dfg/DFGPutStackSinkingPhase.cpp:
+
2015-07-28 Basile Clement basile_clem...@apple.com
Misleading error message: At least one digit must occur after a decimal point
Modified: trunk/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp (187509 => 187510)
--- trunk/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp 2015-07-28 20:46:49 UTC (rev 187509)
+++ trunk/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp 2015-07-28 20:50:18 UTC (rev 187510)
@@ -216,9 +216,10 @@
deferredAtTail[block] =
OperandsFlushFormat(OperandsLike, block-variablesAtHead);
}
+
+for (unsigned local = deferredAtHead.atIndex(0).numberOfLocals(); local--;)
+deferredAtHead.atIndex(0).local(local) = ConflictingFlush;
-deferredAtHead.atIndex(0).fill(ConflictingFlush);
-
do {
changed = false;
@@ -230,12 +231,18 @@
dataLog(Deferred at , node, :, deferred, \n);
if (node-op() == GetStack) {
+DFG_ASSERT(
+m_graph, node,
+deferred.operand(node-stackAccessData()-local) != ConflictingFlush);
+
// A GetStack doesn't affect anything, since we know which local we are reading
// from.
continue;
}
auto escapeHandler = [] (VirtualRegister operand) {
+if (verbose)
+dataLog(For , node, escaping , operand, \n);
if (operand.isHeader())
return;
// We will materialize just before any reads.
@@ -406,6 +413,10 @@
StackAccessData* data = ""
FlushFormat format = deferred.operand(data-local);
if (!isConcrete(format)) {
+DFG_ASSERT(
+m_graph, node,
+deferred.operand(data-local) != ConflictingFlush);
+
// This means there is no deferral. No deferral means that the most
// authoritative value for this stack slot is what is stored in the stack. So,
// keep the GetStack.
@@ -427,12 +438,18 @@
default: {
auto escapeHandler = [] (VirtualRegister operand) {
+if (verbose)
+dataLog(For , node, escaping , operand, \n);
+
if (operand.isHeader())
return;
FlushFormat format = deferred.operand(operand);
-if (!isConcrete(format))
+if (!isConcrete(format)) {
+// It's dead now, rather than conflicting.
+deferred.operand(operand) = DeadFlush;
return;
+}
// Gotta insert a PutStack.
if (verbose)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187506] trunk
Title: [187506] trunk
Revision 187506
Author basile_clem...@apple.com
Date 2015-07-28 13:20:40 -0700 (Tue, 28 Jul 2015)
Log Message
Misleading error message: At least one digit must occur after a decimal point
https://bugs.webkit.org/show_bug.cgi?id=146238
Reviewed by Geoffrey Garen.
Source/_javascript_Core:
Interestingly, we had a comment explaining what this error message was
about that is much clearer than the error message itself. This patch
simply replaces the error message with the explanation from the
comment.
* parser/Lexer.cpp:
(JSC::LexerT::lex):
LayoutTests:
The expected error message in this test has changed.
* js/basic-strict-mode-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/basic-strict-mode-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Lexer.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (187505 => 187506)
--- trunk/LayoutTests/ChangeLog 2015-07-28 20:12:33 UTC (rev 187505)
+++ trunk/LayoutTests/ChangeLog 2015-07-28 20:20:40 UTC (rev 187506)
@@ -1,3 +1,14 @@
+2015-07-28 Basile Clement basile_clem...@apple.com
+
+Misleading error message: At least one digit must occur after a decimal point
+https://bugs.webkit.org/show_bug.cgi?id=146238
+
+Reviewed by Geoffrey Garen.
+
+The expected error message in this test has changed.
+
+* js/basic-strict-mode-expected.txt:
+
2015-07-28 Said Abou-Hallawa sabouhall...@apple.com
Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree
Modified: trunk/LayoutTests/js/basic-strict-mode-expected.txt (187505 => 187506)
--- trunk/LayoutTests/js/basic-strict-mode-expected.txt 2015-07-28 20:12:33 UTC (rev 187505)
+++ trunk/LayoutTests/js/basic-strict-mode-expected.txt 2015-07-28 20:20:40 UTC (rev 187506)
@@ -187,12 +187,12 @@
PASS 'use strict'; (function f() { for(var i in this); })(); true; is true
PASS 'use strict'̻ threw exception SyntaxError: Invalid character '\u0827'.
PASS (function(){'use strict'̻}) threw exception SyntaxError: Invalid character '\u0827'.
-PASS 'use strict'5.f threw exception SyntaxError: At least one digit must occur after a decimal point.
-PASS (function(){'use strict'5.f}) threw exception SyntaxError: At least one digit must occur after a decimal point.
+PASS 'use strict'5.f threw exception SyntaxError: No identifiers allowed directly after numeric literal.
+PASS (function(){'use strict'5.f}) threw exception SyntaxError: No identifiers allowed directly after numeric literal.
PASS 'use strict';̻ threw exception SyntaxError: Invalid character '\u0827'.
PASS (function(){'use strict';̻}) threw exception SyntaxError: Invalid character '\u0827'.
-PASS 'use strict';5.f threw exception SyntaxError: At least one digit must occur after a decimal point.
-PASS (function(){'use strict';5.f}) threw exception SyntaxError: At least one digit must occur after a decimal point.
+PASS 'use strict';5.f threw exception SyntaxError: No identifiers allowed directly after numeric literal.
+PASS (function(){'use strict';5.f}) threw exception SyntaxError: No identifiers allowed directly after numeric literal.
PASS 'use strict';1-(eval=1); threw exception SyntaxError: Cannot modify 'eval' in strict mode..
PASS (function(){'use strict';1-(eval=1);}) threw exception SyntaxError: Cannot modify 'eval' in strict mode..
PASS 'use strict';arguments=1; threw exception SyntaxError: Cannot modify 'arguments' in strict mode..
Modified: trunk/Source/_javascript_Core/ChangeLog (187505 => 187506)
--- trunk/Source/_javascript_Core/ChangeLog 2015-07-28 20:12:33 UTC (rev 187505)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-07-28 20:20:40 UTC (rev 187506)
@@ -1,5 +1,20 @@
2015-07-28 Basile Clement basile_clem...@apple.com
+Misleading error message: At least one digit must occur after a decimal point
+https://bugs.webkit.org/show_bug.cgi?id=146238
+
+Reviewed by Geoffrey Garen.
+
+Interestingly, we had a comment explaining what this error message was
+about that is much clearer than the error message itself. This patch
+simply replaces the error message with the explanation from the
+comment.
+
+* parser/Lexer.cpp:
+(JSC::LexerT::lex):
+
+2015-07-28 Basile Clement basile_clem...@apple.com
+
Simplify call linking
https://bugs.webkit.org/show_bug.cgi?id=147363
Modified: trunk/Source/_javascript_Core/parser/Lexer.cpp (187505 => 187506)
--- trunk/Source/_javascript_Core/parser/Lexer.cpp 2015-07-28 20:12:33 UTC (rev 187505)
+++ trunk/Source/_javascript_Core/parser/Lexer.cpp 2015-07-28 20:20:40 UTC (rev 187506)
@@ -2128,9 +2128,8 @@
token = tokenTypeForIntegerLikeToken(tokenData-doubleValue);
}
-// No identifiers allowed directly after numeric literal, e.g. 3in is bad.
if
[webkit-changes] [187508] tags/Safari-601.1.44.1/
Title: [187508] tags/Safari-601.1.44.1/ Revision 187508 Author bshaf...@apple.com Date 2015-07-28 13:45:03 -0700 (Tue, 28 Jul 2015) Log Message New tag. Added Paths tags/Safari-601.1.44.1/ Diff Property changes: tags/Safari-601.1.44.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187515] trunk/Source/JavaScriptCore
Title: [187515] trunk/Source/_javascript_Core Revision 187515 Author saambara...@gmail.com Date 2015-07-28 14:39:34 -0700 (Tue, 28 Jul 2015) Log Message Implement catch scope using lexical scoping constructs introduced with let scoping patch https://bugs.webkit.org/show_bug.cgi?id=146979 Reviewed by Geoffrey Garen. Now that BytecodeGenerator has a notion of local scope depth, we can easily implement a catch scope that doesn't claim that all variables are dynamically scoped. This means that functions that use try/catch can have local variable resolution. This also means that all functions that use try/catch don't have all their variables marked as being captured. Catch scopes now behave like a let scope (sans the TDZ logic) with a single variable. Catch scopes are now just JSLexicalEnvironments and the symbol table backing the catch scope knows that it corresponds to a catch scope. * CMakeLists.txt: * _javascript_Core.vcxproj/_javascript_Core.vcxproj: * _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: * _javascript_Core.xcodeproj/project.pbxproj: * bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode): * bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::isCacheable): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack): (JSC::BytecodeGenerator::emitLoadGlobalObject): (JSC::BytecodeGenerator::pushLexicalScope): (JSC::BytecodeGenerator::pushLexicalScopeInternal): (JSC::BytecodeGenerator::popLexicalScope): (JSC::BytecodeGenerator::popLexicalScopeInternal): (JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration): (JSC::BytecodeGenerator::variable): (JSC::BytecodeGenerator::resolveType): (JSC::BytecodeGenerator::emitResolveScope): (JSC::BytecodeGenerator::emitPopScope): (JSC::BytecodeGenerator::emitPopWithScope): (JSC::BytecodeGenerator::emitDebugHook): (JSC::BytecodeGenerator::popScopedControlFlowContext): (JSC::BytecodeGenerator::emitPushCatchScope): (JSC::BytecodeGenerator::emitPopCatchScope): (JSC::BytecodeGenerator::beginSwitch): (JSC::BytecodeGenerator::emitPopWithOrCatchScope): Deleted. * bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::lastOpcodeID): * bytecompiler/NodesCodegen.cpp: (JSC::AssignResolveNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::TryNode::emitBytecode): * debugger/DebuggerScope.cpp: (JSC::DebuggerScope::isCatchScope): (JSC::DebuggerScope::isFunctionNameScope): (JSC::DebuggerScope::isFunctionOrEvalScope): (JSC::DebuggerScope::caughtValue): * debugger/DebuggerScope.h: * inspector/ScriptDebugServer.cpp: (Inspector::ScriptDebugServer::exceptionOrCaughtValue): * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_push_name_scope): * jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_push_name_scope): * jit/JITOperations.cpp: * jit/JITOperations.h: * parser/ASTBuilder.h: (JSC::ASTBuilder::createContinueStatement): (JSC::ASTBuilder::createTryStatement): * parser/NodeConstructors.h: (JSC::ThrowNode::ThrowNode): (JSC::TryNode::TryNode): (JSC::FunctionParameters::FunctionParameters): * parser/Nodes.h: * parser/Parser.cpp: (JSC::ParserLexerType::parseTryStatement): * parser/SyntaxChecker.h: (JSC::SyntaxChecker::createBreakStatement): (JSC::SyntaxChecker::createContinueStatement): (JSC::SyntaxChecker::createTryStatement): (JSC::SyntaxChecker::createSwitchStatement): (JSC::SyntaxChecker::createWhileStatement): (JSC::SyntaxChecker::createWithStatement): * runtime/JSCatchScope.cpp: * runtime/JSCatchScope.h: (JSC::JSCatchScope::JSCatchScope): Deleted. (JSC::JSCatchScope::create): Deleted. (JSC::JSCatchScope::createStructure): Deleted. * runtime/JSFunctionNameScope.h: (JSC::JSFunctionNameScope::JSFunctionNameScope): * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildren): * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::withScopeStructure): (JSC::JSGlobalObject::strictEvalActivationStructure): (JSC::JSGlobalObject::activationStructure): (JSC::JSGlobalObject::functionNameScopeStructure): (JSC::JSGlobalObject::directArgumentsStructure): (JSC::JSGlobalObject::scopedArgumentsStructure): (JSC::JSGlobalObject::catchScopeStructure): Deleted. * runtime/JSNameScope.cpp: (JSC::JSNameScope::create): (JSC::JSNameScope::toThis): * runtime/JSNameScope.h: * runtime/JSObject.cpp: (JSC::JSObject::toThis): (JSC::JSObject::isFunctionNameScopeObject): (JSC::JSObject::isCatchScopeObject): Deleted. * runtime/JSObject.h: * runtime/JSScope.cpp: (JSC::JSScope::collectVariablesUnderTDZ): (JSC::JSScope::isLexicalScope): (JSC::JSScope::isCatchScope): (JSC::resolveModeName): * runtime/JSScope.h: * runtime/SymbolTable.cpp: (JSC::SymbolTable::SymbolTable): (JSC::SymbolTable::cloneScopePart): * runtime/SymbolTable.h: * tests/stress/const-semantics.js: (.): Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog
[webkit-changes] [187514] branches/safari-600.8-branch/LayoutTests
Title: [187514] branches/safari-600.8-branch/LayoutTests Revision 187514 Author ander...@apple.com Date 2015-07-28 14:39:34 -0700 (Tue, 28 Jul 2015) Log Message Skip two mixed content tests that don't make sense since we don't disable mixed content access by default. * platform/mac/TestExpectations: Modified Paths branches/safari-600.8-branch/LayoutTests/ChangeLog branches/safari-600.8-branch/LayoutTests/platform/mac/TestExpectations Diff Modified: branches/safari-600.8-branch/LayoutTests/ChangeLog (187513 => 187514) --- branches/safari-600.8-branch/LayoutTests/ChangeLog 2015-07-28 21:23:06 UTC (rev 187513) +++ branches/safari-600.8-branch/LayoutTests/ChangeLog 2015-07-28 21:39:34 UTC (rev 187514) @@ -1,3 +1,9 @@ +2015-07-28 Anders Carlsson ander...@apple.com + +Skip two mixed content tests that don't make sense since we don't disable mixed content access by default. + +* platform/mac/TestExpectations: + 2015-07-27 Babak Shafiei bshaf...@apple.com Roll out r180020. Modified: branches/safari-600.8-branch/LayoutTests/platform/mac/TestExpectations (187513 => 187514) --- branches/safari-600.8-branch/LayoutTests/platform/mac/TestExpectations 2015-07-28 21:23:06 UTC (rev 187513) +++ branches/safari-600.8-branch/LayoutTests/platform/mac/TestExpectations 2015-07-28 21:39:34 UTC (rev 187514) @@ -1507,3 +1507,7 @@ platform/mac/fast/text/vertical-no-sideways.html [ Pass Failure ] fast/canvas/image-potential-subsample.html [ Pass Failure ] + +# Mixed content is not blocked by default. +http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe.html [ Skip ] +http/tests/security/mixedContent/websocket/insecure-websocket-in-main-frame.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187517] trunk/Source/WebKit2
Title: [187517] trunk/Source/WebKit2
Revision 187517
Author commit-qu...@webkit.org
Date 2015-07-28 14:43:30 -0700 (Tue, 28 Jul 2015)
Log Message
Bounds in InteractionInformationAtPosition should be always in main frame coordinate space.
https://bugs.webkit.org/show_bug.cgi?id=147372
When we prepare the bounds for InteractionInformationAtPosition, we should convert the rect to
main frame space since WKContent in UIProcess expects it to be in the web view space.
Patch by Yongjun Zhang yongjun_zh...@apple.com on 2015-07-28
Reviewed by Tim Horton.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation): Convert the bounding rect to main frame space if the element is inside a sub-frame.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (187516 => 187517)
--- trunk/Source/WebKit2/ChangeLog 2015-07-28 21:42:56 UTC (rev 187516)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-28 21:43:30 UTC (rev 187517)
@@ -1,3 +1,16 @@
+2015-07-28 Yongjun Zhang yongjun_zh...@apple.com
+
+Bounds in InteractionInformationAtPosition should be always in main frame coordinate space.
+https://bugs.webkit.org/show_bug.cgi?id=147372
+
+When we prepare the bounds for InteractionInformationAtPosition, we should convert the rect to
+main frame space since WKContent in UIProcess expects it to be in the web view space.
+
+Reviewed by Tim Horton.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::getPositionInformation): Convert the bounding rect to main frame space if the element is inside a sub-frame.
+
2015-07-27 Simon Fraser simon.fra...@apple.com
PathApplierFunction should take a reference to a PathElement
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (187516 => 187517)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-07-28 21:42:56 UTC (rev 187516)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-07-28 21:43:30 UTC (rev 187517)
@@ -2252,6 +2252,11 @@
info.bounds = downcastRenderImage(*renderer).absoluteContentQuad().enclosingBoundingBox();
else
info.bounds = renderer-absoluteBoundingBoxRect();
+
+if (!renderer-document().frame()-isMainFrame()) {
+FrameView *view = renderer-document().frame()-view();
+info.bounds = view-contentsToRootView(info.bounds);
+}
}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187516] trunk/Source/WebCore
Title: [187516] trunk/Source/WebCore
Revision 187516
Author eric.carl...@apple.com
Date 2015-07-28 14:42:56 -0700 (Tue, 28 Jul 2015)
Log Message
[iOS] Set AirPlay discovery mode to disabled when page is hidden
https://bugs.webkit.org/show_bug.cgi?id=147369
Reviewed by Jer Noble.
* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresPlaybackTargetRouteMonitoring): Return false when
the client is not visible.
* html/MediaElementSession.h:
* platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::clientDataBufferingTimerFired): Call configureWireLessTargetMonitoring.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/MediaElementSession.cpp
trunk/Source/WebCore/html/MediaElementSession.h
trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187515 => 187516)
--- trunk/Source/WebCore/ChangeLog 2015-07-28 21:39:34 UTC (rev 187515)
+++ trunk/Source/WebCore/ChangeLog 2015-07-28 21:42:56 UTC (rev 187516)
@@ -1,3 +1,18 @@
+2015-07-28 Eric Carlson eric.carl...@apple.com
+
+[iOS] Set AirPlay discovery mode to disabled when page is hidden
+https://bugs.webkit.org/show_bug.cgi?id=147369
+
+Reviewed by Jer Noble.
+
+* html/MediaElementSession.cpp:
+(WebCore::MediaElementSession::requiresPlaybackTargetRouteMonitoring): Return false when
+ the client is not visible.
+* html/MediaElementSession.h:
+
+* platform/audio/PlatformMediaSession.cpp:
+(WebCore::PlatformMediaSession::clientDataBufferingTimerFired): Call configureWireLessTargetMonitoring.
+
2015-07-28 Said Abou-Hallawa sabouhall...@apple.com
Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree
Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (187515 => 187516)
--- trunk/Source/WebCore/html/MediaElementSession.cpp 2015-07-28 21:39:34 UTC (rev 187515)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp 2015-07-28 21:42:56 UTC (rev 187516)
@@ -413,6 +413,13 @@
return settings settings-allowsPictureInPictureMediaPlayback() !element.webkitCurrentPlaybackTargetIsWireless();
}
+#if PLATFORM(IOS)
+bool MediaElementSession::requiresPlaybackTargetRouteMonitoring() const
+{
+return m_hasPlaybackTargetAvailabilityListeners !client().elementIsHidden();
+}
+#endif
+
#if ENABLE(MEDIA_SOURCE)
const unsigned fiveMinutesOf1080PVideo = 290 * 1024 * 1024; // 290 MB is approximately 5 minutes of 8Mbps (1080p) content.
const unsigned fiveMinutesStereoAudio = 14 * 1024 * 1024; // 14 MB is approximately 5 minutes of 384kbps content.
Modified: trunk/Source/WebCore/html/MediaElementSession.h (187515 => 187516)
--- trunk/Source/WebCore/html/MediaElementSession.h 2015-07-28 21:39:34 UTC (rev 187515)
+++ trunk/Source/WebCore/html/MediaElementSession.h 2015-07-28 21:42:56 UTC (rev 187516)
@@ -112,7 +112,7 @@
virtual void setShouldPlayToPlaybackTarget(bool) override;
#endif
#if PLATFORM(IOS)
-bool requiresPlaybackTargetRouteMonitoring() const override { return m_hasPlaybackTargetAvailabilityListeners; }
+bool requiresPlaybackTargetRouteMonitoring() const override;
#endif
BehaviorRestrictions m_restrictions;
Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp (187515 => 187516)
--- trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp 2015-07-28 21:39:34 UTC (rev 187515)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp 2015-07-28 21:42:56 UTC (rev 187516)
@@ -201,6 +201,10 @@
updateClientDataBuffering();
+#if PLATFORM(IOS)
+PlatformMediaSessionManager::sharedManager().configureWireLessTargetMonitoring();
+#endif
+
if (m_state != Playing || !m_client.elementIsHidden())
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187518] tags/Safari-600.1.4.17.6/
Title: [187518] tags/Safari-600.1.4.17.6/ Revision 187518 Author bshaf...@apple.com Date 2015-07-28 14:50:46 -0700 (Tue, 28 Jul 2015) Log Message New tag. Added Paths tags/Safari-600.1.4.17.6/ Diff Property changes: tags/Safari-600.1.4.17.6 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187519] trunk/Source/WebInspectorUI
Title: [187519] trunk/Source/WebInspectorUI Revision 187519 Author b...@cs.washington.edu Date 2015-07-28 14:53:10 -0700 (Tue, 28 Jul 2015) Log Message Web Inspector: Convert NavigationItem subclasses to ES6 https://bugs.webkit.org/show_bug.cgi?id=147364 Reviewed by Timothy Hatcher. Convert remaining NavigationItem subclasses to use ES6 class. Also promote the _additionalClassNames to be a protected getter, and inline the style class names that are only used in one place. Mechanical changes are elided from the changelog. * UserInterface/Views/ActivateButtonNavigationItem.js: (WebInspector.ActivateButtonNavigationItem): (WebInspector.ActivateButtonNavigationItem.prototype.get additionalClassNames): * UserInterface/Views/ActivateButtonToolbarItem.js: (WebInspector.ActivateButtonToolbarItem): * UserInterface/Views/ButtonNavigationItem.js: (WebInspector.ButtonNavigationItem): (WebInspector.ButtonNavigationItem.prototype.get additionalClassNames): * UserInterface/Views/ButtonToolbarItem.js: (WebInspector.ButtonToolbarItem): * UserInterface/Views/ControlToolbarItem.js: (WebInspector.ControlToolbarItem): (WebInspector.ControlToolbarItem.prototype.get additionalClassNames): * UserInterface/Views/DividerNavigationItem.js: (WebInspector.DividerNavigationItem): (WebInspector.DividerNavigationItem.prototype.get additionalClassNames): * UserInterface/Views/FlexibleSpaceNavigationItem.js: (WebInspector.FlexibleSpaceNavigationItem): (WebInspector.FlexibleSpaceNavigationItem.prototype.get additionalClassNames): * UserInterface/Views/HierarchicalPathNavigationItem.js: (WebInspector.HierarchicalPathNavigationItem.prototype.get additionalClassNames): (WebInspector.HierarchicalPathNavigationItem.prototype.get _additionalClassNames): Deleted. * UserInterface/Views/NavigationItem.js: (WebInspector.NavigationItem): (WebInspector.NavigationItem.prototype.get _classNames): * UserInterface/Views/RadioButtonNavigationItem.js: (WebInspector.RadioButtonNavigationItem): (WebInspector.RadioButtonNavigationItem.prototype.get additionalClassNames): * UserInterface/Views/ToggleButtonNavigationItem.js: (WebInspector.ToggleButtonNavigationItem): (WebInspector.ToggleButtonNavigationItem.prototype.get additionalClassNames): * UserInterface/Views/ToggleControlToolbarItem.js: (WebInspector.ToggleControlToolbarItem): (WebInspector.ToggleControlToolbarItem.prototype.get additionalClassNames): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/ActivateButtonNavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/ActivateButtonToolbarItem.js trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.js trunk/Source/WebInspectorUI/UserInterface/Views/ControlToolbarItem.js trunk/Source/WebInspectorUI/UserInterface/Views/DividerNavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/FlexibleSpaceNavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/RadioButtonNavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/ToggleButtonNavigationItem.js trunk/Source/WebInspectorUI/UserInterface/Views/ToggleControlToolbarItem.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (187518 => 187519) --- trunk/Source/WebInspectorUI/ChangeLog 2015-07-28 21:50:46 UTC (rev 187518) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-28 21:53:10 UTC (rev 187519) @@ -1,3 +1,52 @@ +2015-07-28 Brian J. Burg b...@cs.washington.edu + +Web Inspector: Convert NavigationItem subclasses to ES6 +https://bugs.webkit.org/show_bug.cgi?id=147364 + +Reviewed by Timothy Hatcher. + +Convert remaining NavigationItem subclasses to use ES6 class. + +Also promote the _additionalClassNames to be a protected getter, +and inline the style class names that are only used in one place. + +Mechanical changes are elided from the changelog. + +* UserInterface/Views/ActivateButtonNavigationItem.js: +(WebInspector.ActivateButtonNavigationItem): +(WebInspector.ActivateButtonNavigationItem.prototype.get additionalClassNames): +* UserInterface/Views/ActivateButtonToolbarItem.js: +(WebInspector.ActivateButtonToolbarItem): +* UserInterface/Views/ButtonNavigationItem.js: +(WebInspector.ButtonNavigationItem): +(WebInspector.ButtonNavigationItem.prototype.get additionalClassNames): +* UserInterface/Views/ButtonToolbarItem.js: +(WebInspector.ButtonToolbarItem): +* UserInterface/Views/ControlToolbarItem.js: +(WebInspector.ControlToolbarItem): +(WebInspector.ControlToolbarItem.prototype.get additionalClassNames): +* UserInterface/Views/DividerNavigationItem.js: +(WebInspector.DividerNavigationItem): +
[webkit-changes] [187520] branches/safari-600.1.4.17-branch/Source
Title: [187520] branches/safari-600.1.4.17-branch/Source Revision 187520 Author bshaf...@apple.com Date 2015-07-28 15:14:29 -0700 (Tue, 28 Jul 2015) Log Message Versioning. Modified Paths branches/safari-600.1.4.17-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-600.1.4.17-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-600.1.4.17-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-600.1.4.17-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-600.1.4.17-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-600.1.4.17-branch/Source/_javascript_Core/Configurations/Version.xcconfig (187519 => 187520) --- branches/safari-600.1.4.17-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-07-28 21:53:10 UTC (rev 187519) +++ branches/safari-600.1.4.17-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-07-28 22:14:29 UTC (rev 187520) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 4; MICRO_VERSION = 17; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-600.1.4.17-branch/Source/WebCore/Configurations/Version.xcconfig (187519 => 187520) --- branches/safari-600.1.4.17-branch/Source/WebCore/Configurations/Version.xcconfig 2015-07-28 21:53:10 UTC (rev 187519) +++ branches/safari-600.1.4.17-branch/Source/WebCore/Configurations/Version.xcconfig 2015-07-28 22:14:29 UTC (rev 187520) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 4; MICRO_VERSION = 17; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-600.1.4.17-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (187519 => 187520) --- branches/safari-600.1.4.17-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-07-28 21:53:10 UTC (rev 187519) +++ branches/safari-600.1.4.17-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-07-28 22:14:29 UTC (rev 187520) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 4; MICRO_VERSION = 17; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-600.1.4.17-branch/Source/WebKit/mac/Configurations/Version.xcconfig (187519 => 187520) --- branches/safari-600.1.4.17-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-07-28 21:53:10 UTC (rev 187519) +++ branches/safari-600.1.4.17-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-07-28 22:14:29 UTC (rev 187520) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 4; MICRO_VERSION = 17; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-600.1.4.17-branch/Source/WebKit2/Configurations/Version.xcconfig (187519 => 187520) --- branches/safari-600.1.4.17-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-07-28 21:53:10 UTC (rev 187519) +++ branches/safari-600.1.4.17-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-07-28 22:14:29 UTC (rev 187520) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 4; MICRO_VERSION = 17; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
